On 03/17/2015 02:18 PM, Eric Blake wrote:
On 03/17/2015 12:04 PM, John Snow wrote:
+typedef void (CallbackFn)(void *opaque, int ret);
+
+/* Temporary. Removed in the next patch. */
Actually, no. :-)
(remove in patch 7)
Why are you making them non-static in the first place? I see both
functions mentioned in patch 3 and patch 7 only (except for context in
patch 6).
Won't compile otherwise, because they have no users as of this patch. I
am trying to keep the size of these patches down and in a sane order.
Another solution is to mark it static, but also add
__attribute__((unused)) to shut the compiler up, so that you don't cause
build failures, but also don't cause reviewers to wonder who is using
it. Then when it finally gets used, a patch to remove the attribute is
easier to see than a patch adding static.
Good trick, thanks.
