Hello, everyone
I'm glad to announce the fresh Patchew server deployment:
http://qemu.patchew.org/
The mission of this project is to help identify obvious defects (coding style,
compiling, etc.) of posted patches.
Follow the green "passed" or red "failed" button in the page and you'll see t
Public bug reported:
using the latest build from git (hash 041ccc922ee474693a2869d4e3b59e920c739bc0
) and all older versions i have tested.
i am using an amd64 host with an arm chroot using "qemu-user arm cortex-a8" cpu
emulation to run it
building coreutils hangs on "checking whether printf su
Firstly, thank you very much for your patient work!
On 2/28/15 01:36, Andreas Färber wrote:
> Hi,
>
> "target-tilegx: Initial stub" or "...support"? No need to mention QEMU
> (spelling!) in a QEMU commit.
>
OK, thanks.
> Am 22.02.2015 um 14:33 schrieb Chen Gang S:
>> It almost likes a templa
On 02/26/2015 01:32 AM, Shannon Zhao wrote:
> On 2015/2/19 1:19, Wei Huang wrote:
>> Nice work. I will help review the patches.
>>
> Thanks for your help :-)
>
>> Other than the CPU hotplug support, we are also seeking the guest VM
>> powerdown support via ACPI. This feature is important for man
On 2/28/15 10:09, Chris Metcalf wrote:
> On 2/27/2015 9:10 PM, Chen Gang S wrote:
>> By the way, does Gx8000 mean 8000 core count?
>
> It's marketing, so it doesn't have to mean anything. The TILE-Gx 8036 is the
> 36-core part, the 8072 is the 72-core part, 8009 is the 9-core part, etc.
> Ther
On Fri, Feb 27, 2015 at 5:49 PM, Cornelia Huck
wrote:
On Fri, 27 Feb 2015 06:42:57 +0008
Jason Wang wrote:
On Thu, Feb 26, 2015 at 9:05 PM, Cornelia Huck
wrote:
> On Thu, 26 Feb 2015 15:04:41 +0800
> Jason Wang wrote:
>
>> typedef struct AdapterRoutes {
>> AdapterInfo
On Fri, Feb 27, 2015 at 5:41 PM, Cornelia Huck
wrote:
On Fri, 27 Feb 2015 03:46:25 +0008
Jason Wang wrote:
On Thu, Feb 26, 2015 at 9:02 PM, Cornelia Huck
wrote:
> On Thu, 26 Feb 2015 15:04:39 +0800
> Jason Wang wrote:
>
>> Instead of depending on marco, using a bus specific limi
On Fri, Feb 27, 2015 at 5:34 PM, Cornelia Huck
wrote:
On Fri, 27 Feb 2015 03:42:00 +0008
Jason Wang wrote:
On Thu, Feb 26, 2015 at 8:57 PM, Cornelia Huck
wrote:
> On Thu, 26 Feb 2015 15:04:38 +0800
> Jason Wang wrote:
>
>> This patch introduces a bus specific queue limitation. I
On 2015/2/28 1:42, Eric Blake wrote:
On 02/27/2015 10:07 AM, Dr. David Alan Gilbert wrote:
Rather than pollute the user-exposed enum with a state that we will
never report, can we come up with some internal-only method for tracking
cancelling separate from the enum?
Well I guess we could just
On Fri, 02/27 11:43, Max Reitz wrote:
> static void virtio_scsi_hotplug(HotplugHandler *hotplug_dev, DeviceState
> *dev,
> Error **errp)
> {
> @@ -763,12 +794,26 @@ static void virtio_scsi_hotplug(HotplugHandler
> *hotplug_dev, DeviceState *dev,
> SCSIDevic
On 2015/2/28 0:48, Eric Blake wrote:
On 02/26/2015 11:19 PM, zhanghailiang wrote:
The original 'status' is an open-coded 'str' type, convert it to use an
enum type.
This conversion is backwards compatible, better documented and
more convenient for future extensibility.
In addition, Fix a typo f
On 2/27/2015 9:10 PM, Chen Gang S wrote:
By the way, does Gx8000 mean 8000 core count?
It's marketing, so it doesn't have to mean anything. The TILE-Gx 8036 is the 36-core
part, the 8072 is the 72-core part, 8009 is the 9-core part, etc. There is no
"8000" chip, it's just a way of describin
On 2/28/15 05:49, Chris Metcalf wrote:
> On 2/27/2015 12:36 PM, Andreas Färber wrote:
>> "TILE-Gx" according to
>> http://www.tilera.com/products/?ezchip=585&spage=614 - please fix
>> wherever used in textual form.
>
> Yes, really only "tilegx" or "TILE-Gx" should be used. In type names I agree
On 2015/2/27 22:15, Paolo Bonzini wrote:
> Looks good, I am applying it locally so that it can get into qemu.git
> very soon.
>
OK, thanks.
Regards,
-Gonglei
> Paolo
>
> On 27/02/2015 02:49, arei.gong...@huawei.com wrote:
>> From: Gonglei
>>
>> Reproducer:
>>
>> $./qemu-system-x86_64 --enable-
On Fri, 02/27 19:40, Paolo Bonzini wrote:
>
>
> On 19/02/2015 08:48, Michael S. Tsirkin wrote:
> > V=1 should show what's going on, it's not nice
> > to silence things unconditionally.
> >
> > Signed-off-by: Michael S. Tsirkin
> > ---
> > Makefile | 4 ++--
> > 1 file changed, 2 insertions(+),
To test the failure case, we modify iotests.py to allow us to specify
that we'd like to allow failures when we wait for block job events.
Reviewed-by: Max Reitz
Signed-off-by: John Snow
---
tests/qemu-iotests/124| 57 ++-
tests/qemu-iotests/124.ou
We often don't need the BlockDriverState for functions
that operate on bitmaps. Remove it.
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
block.c | 13 ++---
block/backup.c| 2 +-
block/mirror.c| 26 ++
blockdev.c|
Reviewed-by: Max Reitz
Signed-off-by: John Snow
---
tests/qemu-iotests/124 | 122 +
tests/qemu-iotests/124.out | 4 +-
2 files changed, 124 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/124 b/tests/qemu-iotests/124
index 7985cd1.
For "dirty-bitmap" sync mode, the block job will iterate through the
given dirty bitmap to decide if a sector needs backup (backup all the
dirty clusters and skip clean ones), just as allocation conditions of
"top" sync mode.
Signed-off-by: Fam Zheng
Signed-off-by: John Snow
Reviewed-by: Max Rei
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
block.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/block.c b/block.c
index 06b4264..55243f9 100644
--- a/block.c
+++ b/block.c
@@ -60,11 +60,11 @@
* or enabled. A frozen bitmap can only abdicate() or re
Add bdrv_clear_dirty_bitmap and a matching QMP command,
qmp_block_dirty_bitmap_clear that enables a user to reset
the bitmap attached to a drive.
This allows us to reset a bitmap in the event of a full
drive backup.
Reviewed-by: Max Reitz
Signed-off-by: John Snow
---
block.c | 8
Signed-off-by: John Snow
---
docs/bitmaps.md | 303
1 file changed, 303 insertions(+)
create mode 100644 docs/bitmaps.md
diff --git a/docs/bitmaps.md b/docs/bitmaps.md
new file mode 100644
index 000..ebb6ae8
--- /dev/null
+++ b/docs/b
Signed-off-by: John Snow
---
block.c| 22
include/block/block.h | 1 +
include/qemu/hbitmap.h | 10 ++
util/hbitmap.c | 54 ++
4 files changed, 87 insertions(+)
diff --git a/block.c b/block.c
i
Adds the "disabled" and "frozen" status booleans.
Signed-off-by: Fam Zheng
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
block.c | 2 ++
qapi/block-core.json | 7 ++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/block.c b/block.c
index d969b24..06b4264 1
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
tests/qemu-iotests/124 | 89 ++
tests/qemu-iotests/124.out | 5 +++
tests/qemu-iotests/group | 1 +
3 files changed, 95 insertions(+)
create mode 100644 tests/qemu-iotests/124
create mode 10
Add a status indicating the enabled/disabled state of the bitmap.
A bitmap is by default enabled, but you can lock the bitmap into
a read-only state by setting disabled = true.
A previous version of this patch added a QMP interface for changing
the state of the bitmap, but it has since been remove
We add a bitmap merge operation to assist in error cases
where we wish to combine two bitmaps together.
This is algorithmically O(bits) provided HBITMAP_LEVELS remains
constant. For a full bitmap on a 64bit machine:
sum(bits/64^k, k, 0, HBITMAP_LEVELS) ~= 1.01587 * bits
We may be able to improve
We treat this field with a variety of different types everywhere
in the code. Now it's just uint32_t.
Reviewed-by: Eric Blake
Reviewed-by: Max Reitz
Signed-off-by: John Snow
---
block.c | 11 ++-
block/mirror.c| 4 ++--
include/block/block.h | 2 +-
A bitmap successor is an anonymous BdrvDirtyBitmap that is intended to
be created just prior to a sensitive operation (e.g. Incremental Backup)
that can either succeed or fail, but during the course of which we still
want a bitmap tracking writes.
On creating a successor, we "freeze" the parent bi
The new command pair is added to manage a user created dirty bitmap. The
dirty bitmap's name is mandatory and must be unique for the same device,
but different devices can have bitmaps with the same names.
The granularity is an optional field. If it is not specified, we will
choose a default granu
This returns the granularity (in bytes) of dirty bitmap,
which matches the QMP interface and the existing query
interface.
Signed-off-by: John Snow
Reviewed-by: Max Reitz
Reviewed-by: Eric Blake
---
block.c | 8 ++--
include/block/block.h | 1 +
2 files changed, 7 insertions(
New topic, new version, same great incremental backup taste.
This series relies on [Qemu-devel] [PULL 30/69] blkdebug: fix "once" rule,
part of Stefan's 69 patch pull request submitted 2015-02-27.
This patchset enables the in-memory part of the incremental backup
feature, without transactional su
From: Fam Zheng
This field will be set for user created dirty bitmap. Also pass in an
error pointer to bdrv_create_dirty_bitmap, so when a name is already
taken on this BDS, it can report an error message. This is not global
check, two BDSes can have dirty bitmap with a common name.
Implemented
On 02/28/2015 01:40 AM, Andreas Färber wrote:
> Am 22.02.2015 um 14:36 schrieb Chen Gang S:
>> Add tilegx architecture in "syscall_defs.h", all related features (ioctrl,
>> and stat) are based on Linux kernel tilegx 64-bit implementation.
>>
>> Signed-off-by: Chen Gang
>> ---
>> linux-user/syscal
On 02/28/2015 02:24 AM, Andreas Färber wrote:
> Am 22.02.2015 um 14:37 schrieb Chen Gang S:
>> For tilegx, several syscall macros are not supported, so switch them to
>> avoid building break.
>>
>> Signed-off-by: Chen Gang
>> ---
>> linux-user/syscall.c | 50 ++
Ping
On 2015-02-02 at 12:08, Max Reitz wrote:
BDRV_O_PROTOCOL is an internal qemu flag which a user should be able to
override by explicitly specifying a block driver. This series implements
this and adds two iotests (one for NBD, one for file) to test it.
For the NBD test to succeed, this seri
Ping
On 2015-02-09 at 14:25, Max Reitz wrote:
As has been requested, this series adds new overlap check functions to
the qcow2 code. My local branch is called "qcow2-improved-overlap-v1",
but I am not so sure whether it is actually an improvement; that is left
for you to decide, dear reviewers.
On 2/27/2015 12:36 PM, Andreas Färber wrote:
"TILE-Gx" according to
http://www.tilera.com/products/?ezchip=585&spage=614 - please fix
wherever used in textual form.
Yes, really only "tilegx" or "TILE-Gx" should be used. In type names I agree
that TileGX is probably clearer than any alternati
On 2015-02-27 at 16:44, Stefan Weil wrote:
Am 27.02.2015 um 18:42 schrieb Paolo Bonzini:
An optimized fix could be to use a CoRwLock, then:
Note related to our previous discussion: why does the code use
CoRwlock instead of CoRwLock? Should it be renamed before more code
uses it?
Well, I'
Am 27.02.2015 um 18:42 schrieb Paolo Bonzini:
An optimized fix could be to use a CoRwLock, then:
Note related to our previous discussion: why does the code use CoRwlock
instead of CoRwLock? Should it be renamed before more code uses it?
Stefan
On 27.02.15 16:28, Alexander Graf wrote:
>
>
> On 27.02.15 00:19, Cyril Bur wrote:
>> This patch adds basic support for the VTB.
>>
>> PowerISA:
>> The Virtual Time Base (VTB) is a 64-bit incrementing counter.
>> Virtual Time Base increments at the same rate as the Time Base until its
>> value
On 02/27/2015 12:06 PM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> There are various places where it's useful to hold a series
> of values that change over time and get summaries about them.
>
> This provides:
>
>- a count of the number of items
>- min/max
On 02/20/2015 04:07 PM, John Snow wrote:
> This returns the granularity (in bytes) of dirty bitmap,
> which matches the QMP interface and the existing query
> interface.
>
> Signed-off-by: John Snow
> Reviewed-by: Max Reitz
> ---
> block.c | 8 ++--
> include/block/block.h | 1
Am 27.02.2015 um 21:23 schrieb Max Reitz:
On 2015-02-27 at 15:21, Stefan Weil wrote:
Am 27.02.2015 um 19:55 schrieb Max Reitz:
On 2015-02-27 at 13:15, Max Reitz wrote:
On 2015-02-27 at 13:12, Stefan Weil wrote:
Am 27.02.2015 um 19:09 schrieb Max Reitz:
It always fails for me. Do you have an
Am 27.02.2015 um 19:55 schrieb Max Reitz:
On 2015-02-27 at 13:15, Max Reitz wrote:
On 2015-02-27 at 13:12, Stefan Weil wrote:
Am 27.02.2015 um 19:09 schrieb Max Reitz:
It always fails for me. Do you have an SSD?
On the real machine: yes. On the virtual machine: maybe.
I don't, so maybe that
On 2015-02-27 at 15:21, Stefan Weil wrote:
Am 27.02.2015 um 19:55 schrieb Max Reitz:
On 2015-02-27 at 13:15, Max Reitz wrote:
On 2015-02-27 at 13:12, Stefan Weil wrote:
Am 27.02.2015 um 19:09 schrieb Max Reitz:
It always fails for me. Do you have an SSD?
On the real machine: yes. On the virt
On 02/27/2015 12:24 PM, Vladimir Sementsov-Ogievskiy wrote:
These patches provide dirty bitmap migration feature. Only named dirty
bitmaps are to be migrated. Migration may be enabled using migration
capabilities.
v4 significant changes:
0001: tiny bugfix: out[i] -> out[i-start], same for 'i
On 2015-02-27 at 11:43, Max Reitz wrote:
The only remaining user of the BDS close notifiers is NBD which uses
them to determine when a BDS tree is being ejected. This patch removes
the BDS-level close notifiers and adds a notifier list to the
BlockBackend structure that is invoked whenever a BDS
On 02/27/2015 01:32 PM, Eric Blake wrote:
On 02/27/2015 10:24 AM, Vladimir Sementsov-Ogievskiy wrote:
Reviewed-by: John Snow
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block.c| 1 +
include/qemu/hbitmap.h | 8
qapi/block-core.json | 4 +++-
util/hbitmap.c
When allocating a new cluster, the first write to it must be the one
doing the allocation, because that one pads its write request to the
cluster size; if another write to that cluster is executed before it,
that write will be overwritten due to the padding.
See https://bugs.launchpad.net/qemu/+bu
** Changed in: qemu
Status: New => In Progress
** Changed in: qemu
Importance: Undecided => Critical
** Changed in: qemu
Assignee: (unassigned) => Paolo Bonzini (bonzini)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU
On 19/02/2015 08:48, Michael S. Tsirkin wrote:
> V=1 should show what's going on, it's not nice
> to silence things unconditionally.
>
> Signed-off-by: Michael S. Tsirkin
> ---
> Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index
From: "Dr. David Alan Gilbert"
Hi,
This is an attempt at a generic rolling statistics utility to
allow data (e.g. bandwidth usage, times etc) to be collected
easily. They hold some basic values (min/max/mean/weighted mean)
and the last 'n' raw values.I'd like to use this
maybe in fault-tol
From: "Dr. David Alan Gilbert"
There are various places where it's useful to hold a series
of values that change over time and get summaries about them.
This provides:
- a count of the number of items
- min/max
- mean
- a weighted mean (where you can set the weight to determine
Reported by Leon Alrae on the mailing list, and by
Andreas Gustafsson as Launchpad bug 1426472.
Paolo Bonzini (2):
cpus: fix deadlock and segfault in qemu_mutex_lock_iothread
cpus: be more paranoid in avoiding deadlocks
cpus.c | 12
1 file changed, 8 insertions(+), 4 deletions(-
On 02/20/2015 04:07 PM, John Snow wrote:
> The new command pair is added to manage a user created dirty bitmap. The
> dirty bitmap's name is mandatory and must be unique for the same device,
> but different devices can have bitmaps with the same names.
>
> The granularity is an optional field. If
On Fri, Feb 27, 2015 at 6:17 PM, Stefan Hajnoczi wrote:
> Ekaterina Tumanova (5):
> block: add bdrv functions for geometry and blocksize
> raw-posix: Factor block size detection out of raw_probe_alignment()
> block: Add driver methods to probe blocksizes and geometry
> block-backend: Add w
When two threads (other than the low-priority TCG VCPU thread)
are competing for the iothread lock, a deadlock can happen. This
is because iothread_requesting_mutex is set to false by the first
thread that gets the mutex, and then the VCPU thread might never
yield from the execution loop. If ioth
On Fri, Feb 27, 2015 at 03:10:27PM +0100, Andreas Färber wrote:
> Am 26.02.2015 um 16:59 schrieb Eduardo Habkost:
> > On Wed, Feb 25, 2015 at 11:06:55PM +0100, Andreas Färber wrote:
> >> Am 25.02.2015 um 20:58 schrieb Eduardo Habkost:
> >>> The function is used only for CONFIG_USER, so make its pur
On 19/02/2015 08:48, Michael S. Tsirkin wrote:
> relink binary whenever config-devices.mak changes:
> this makes sense as we are adding/removing devices,
> so binary has to be relinked to be up to date.
>
> Signed-off-by: Michael S. Tsirkin
> ---
> Makefile.target | 4 +++-
> 1 file changed, 3
On 26/02/2015 17:33, Michael S. Tsirkin wrote:
> .hex files are created from .dsl files, so
> cpp adds the dependency %.hex: %.dsl automatically,
> but fails to add a dummy rule so if .dsl
> file is missing, make will fail.
>
> This happened to us in the past when we
> removed some dsl files.
>
Am 27.02.2015 um 20:01 schrieb Eduardo Habkost:
> On Fri, Feb 27, 2015 at 03:10:27PM +0100, Andreas Färber wrote:
>> Am 26.02.2015 um 16:59 schrieb Eduardo Habkost:
>>> On Wed, Feb 25, 2015 at 11:06:55PM +0100, Andreas Färber wrote:
Am 25.02.2015 um 20:58 schrieb Eduardo Habkost:
> The fun
On Fri, Feb 27, 2015 at 6:29 PM, Max Reitz wrote:
> On 2015-02-27 at 13:26, Ekaterina Tumanova wrote:
>>
>> check conf.blk before calling blkconf_blocksizes
>>
>> Signed-off-by: Ekaterina Tumanova
>> ---
>> hw/scsi/scsi-disk.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>
> R
Quoting Bharata B Rao (2015-02-27 03:52:09)
> On Fri, Feb 27, 2015 at 8:41 AM, Michael Roth
> wrote:
> > +static void attach(sPAPRDRConnector *drc, DeviceState *d, void *fdt,
> > + int fdt_start_offset, bool coldplug, Error **errp)
> > +{
> > +DPRINTFN("drc: %x, attach", get
From: "Dr. David Alan Gilbert"
Signed-off-by: Dr. David Alan Gilbert
---
tests/Makefile | 3 +
tests/test-rolling-stats.c | 161 +
2 files changed, 164 insertions(+)
create mode 100644 tests/test-rolling-stats.c
diff --git a/tests/Make
On 27/02/2015 18:11, Max Reitz wrote:
> s->blocker is really only used in hw/scsi/virtio-scsi.c; the only places
> where it is used in hw/scsi/virtio-scsi-dataplane.c is when it is
> allocated and when it is freed. That does not make a whole lot of sense
> (and is actually wrong because this lead
On 2015-02-27 at 13:15, Max Reitz wrote:
On 2015-02-27 at 13:12, Stefan Weil wrote:
Am 27.02.2015 um 19:09 schrieb Max Reitz:
It always fails for me. Do you have an SSD?
On the real machine: yes. On the virtual machine: maybe.
I don't, so maybe that's the issue. But running it in tmpfs doesn
On 02/27/2015 10:24 AM, Vladimir Sementsov-Ogievskiy wrote:
> Reviewed-by: John Snow
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> include/migration/migration.h | 1 +
> migration/migration.c | 9 +
> qapi-schema.json | 5 -
> 3 files changed, 14 insertio
On 27/02/2015 15:24, Leon Alrae wrote:
> On 27/02/2015 13:17, Paolo Bonzini wrote:
>> Can you test this patch? (On top of the previous one).
>
> With this change the system doesn't boot at all I'm afraid.
Hmm, it works for me and fixes the deadlock with Aurelien's images.
Just to be clear, th
On 2015-02-27 at 13:09, Max Reitz wrote:
On 2015-02-27 at 12:42, Paolo Bonzini wrote:
On 27/02/2015 15:05, Max Reitz wrote:
Concurrently modifying the bmap does not seem to be a good idea;
this patch adds
a lock for it. See https://bugs.launchpad.net/qemu/+bug/1422307 for
what
can go wrong w
For good measure, ensure that the following sequence:
thread 1 calls qemu_mutex_lock_iothread
thread 2 calls qemu_mutex_lock_iothread
VCPU thread are created
VCPU thread enters execution loop
results in the VCPU threads letting the other two threads run
and obeying iothread_requesting
On 02/27/2015 10:24 AM, Vladimir Sementsov-Ogievskiy wrote:
> Reviewed-by: John Snow
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> block.c| 1 +
> include/qemu/hbitmap.h | 8
> qapi/block-core.json | 4 +++-
> util/hbitmap.c | 8
> 4 files chan
check conf.blk before calling blkconf_blocksizes
Signed-off-by: Ekaterina Tumanova
---
hw/scsi/scsi-disk.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index 2921728..df5140e 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/scsi-d
From: John Snow
Signed-off-by: John Snow
Message-id: 1424738729-17082-7-git-send-email-js...@redhat.com
Signed-off-by: Stefan Hajnoczi
---
tests/ahci-test.c | 44
1 file changed, 44 insertions(+)
diff --git a/tests/ahci-test.c b/tests/ahci-test.c
i
On 02/27/2015 08:36 AM, Cole Robinson wrote:
> Useful for debugging.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=822418
> Signed-off-by: Cole Robinson
> ---
> v2:
> Explicitly list spice channel mappings
> Use ARRAY_SIZE macro
>
> hmp.c | 26 ++
> 1 file chan
Am 22.02.2015 um 14:37 schrieb Chen Gang S:
> For tilegx, several syscall macros are not supported, so switch them to
> avoid building break.
>
> Signed-off-by: Chen Gang
> ---
> linux-user/syscall.c | 50 +-
> 1 file changed, 49 insertions(+), 1 d
From: Marc Marí
The MSIX interrupt was always acked without checking its value, which caused a
race condition. If the ISR was raised between the read and the acking, the ISR
was never detected and it timed out.
Signed-off-by: Marc Marí
Reviewed-by: John Snow
Tested-by: John Snow
Message-id: 1
for Max Reitz:
Can you please apply this patch and re-test?
Thanks!
Kate
p.s. This is supposed to be merged with patch 5/5 of
"Geometry and blocksize detection for backing devices"
Ekaterina Tumanova (1):
scsi-hd: fix property unset case
hw/scsi/scsi-disk.c | 4 +++-
1 file changed, 3 inser
From: John Snow
Pull this helper out of ide-test and into libqos,
to be shared with ahci-test.
Signed-off-by: John Snow
Message-id: 1424738729-17082-6-git-send-email-js...@redhat.com
Signed-off-by: Stefan Hajnoczi
---
tests/ide-test.c | 23 +--
tests/libqos/libqos.c |
From: Marc Marí
Check the QVIRTIO_F_ANY_LAYOUT flag before performing operations with 2
descriptor layout. This is to follow the specification strictly.
This patch depends on:
[PATCH v5 0/5] libqos: Virtio MMIO driver
Signed-off-by: Marc Marí
Message-id: 1424815154-27243-1-git-send-email-marc.
From: Liu Yuan
These functions mix up -1 and -errno in return values and would might cause
trouble error handling in the call chain.
This patch let them return -errno and add some comments.
Cc: qemu-devel@nongnu.org
Cc: Markus Armbruster
Cc: Kevin Wolf
Cc: Stefan Hajnoczi
Reported-by: Markus
From: John Snow
Add qmp_async, which lets us send QMP commands asynchronously.
This is useful when we want to send commands that will trigger
event responses, but we don't know in what order to expect them.
Sometimes the event responses may arrive even before the command
confirmation will show u
From: John Snow
This will enable the testing of high offsets without
wasting a lot of disk space, and does not impact the
previous tests.
mkimg and mkqcow2 are added to libqos for other tests.
Signed-off-by: John Snow
Message-id: 1424905602-24715-8-git-send-email-js...@redhat.com
Signed-off-by
From: John Snow
ahci_command_set_flags: Set additional flags in the command header.
ahci_command_clr_flags: Clear flags from the command header.
ahci_command_set_offset: Change the IO sector from 0.
ahci_command_adjust: Adjust many values simultaneously.
To be used to adjust the command he
From: John Snow
Even though it's just the reserved space, make sure they're zeroes.
Signed-off-by: John Snow
Message-id: 1424905602-24715-2-git-send-email-js...@redhat.com
Signed-off-by: Stefan Hajnoczi
---
tests/libqos/ahci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
From: John Snow
Test what happens when we try to use extremely short PRDTs
to accomplish a small data transfer.
Signed-off-by: John Snow
Message-id: 1424905602-24715-7-git-send-email-js...@redhat.com
Signed-off-by: Stefan Hajnoczi
---
tests/ahci-test.c | 59 +++
From: John Snow
Test sector offset 0, 1, and the last sector(s)
in LBA28 and LBA48 modes.
Signed-off-by: John Snow
Message-id: 1424905602-24715-9-git-send-email-js...@redhat.com
Signed-off-by: Stefan Hajnoczi
---
tests/ahci-test.c | 68 +++--
From: John Snow
Add a routine that can be used to engage the AHCI
device at a not-granular level so that bringing up
the functionality of the HBA is easy in future tests
that are not concerned with testing the bring-up process.
Signed-off-by: John Snow
Message-id: 1424905602-24715-3-git-send-em
From: John Snow
Signed-off-by: John Snow
Message-id: 1424738729-17082-3-git-send-email-js...@redhat.com
Signed-off-by: Stefan Hajnoczi
---
tests/ahci-test.c| 67
tests/libqos/libqos-pc.c | 5
tests/libqos/libqos-pc.h | 1 +
3 file
From: Paolo Bonzini
This is easy, since start_dma already restarts processing from the
beginning of the PRDT.
Migration is also easy to cover; the comment about busy_slot is
wrong, busy_slot will only be set if there is an error. In this
case we have nothing to do really. The core IDE code wil
From: John Snow
Signed-off-by: John Snow
Message-id: 1424738729-17082-2-git-send-email-js...@redhat.com
Signed-off-by: Stefan Hajnoczi
---
tests/ahci-test.c | 34 ++
1 file changed, 34 insertions(+)
diff --git a/tests/ahci-test.c b/tests/ahci-test.c
index fb473
From: John Snow
Amazingly, we weren't doing this before.
Make sure we migrate the IDEState structure that belongs to
the AHCIDevice.IDEBus structure during migrations.
No version numbering changes because AHCI is not officially
migratable (and we can all see with good reason why) so we
do not i
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
Signed-off-by: John Snow
Message-id: 1424708286-16483-13-git-send-email-js...@redhat.com
Signed-off-by: Stefan Hajnoczi
---
hw/ide/core.c | 12
hw/ide/internal.h | 4
2 files changed, 8 insertions(+), 8 deletions(-)
diff
From: Paolo Bonzini
This patch begins refactoring the restart dma functions
out of bmdma to be shared with AHCI and other future
IDE HBA implementations.
Signed-off-by: Paolo Bonzini
Signed-off-by: John Snow
Message-id: 1424708286-16483-2-git-send-email-js...@redhat.com
Signed-off-by: Stefan H
From: John Snow
These test a few different pathways in the AHCI code.
short: Test the minimum transfer size, exactly one sector.
simple: Test a transfer using a single PRD, in this case, 4K.
double: Test transferring 8K, which we will split up as two PRDs.
long: Test transferring a lot of dat
From: Paolo Bonzini
With BMDMA specific excised from the restart functions,
create a HBA-agnostic restart callback to be shared
between the different HBAs.
Change the callback registered with the vmstate_change
handler to always point to ide_restart_cb instead of
relying on the IDEDMAOps.restart
From: Paolo Bonzini
This only breaks backwards migration compatibility if the bus is in
an error state. It is in principle possible to avoid this by making
two subsections (one for version 1, and one for version 2, but with
the same name) with different "_needed" callbacks. The v1 callback woul
From: John Snow
This patch adds tests for werror and rerror functionality
for the PCI and ISA ide buses.
Tests for the AHCI device are to be included at a later
date after requisite patches have been merged upstream
to support needed functionality by the tests.
Signed-off-by: Paolo Bonzini
Sig
From: Ekaterina Tumanova
Put it in new probe_logical_blocksize().
Signed-off-by: Ekaterina Tumanova
Reviewed-by: Markus Armbruster
Reviewed-by: Stefan Hajnoczi
Message-id: 1424087278-49393-3-git-send-email-tuman...@linux.vnet.ibm.com
Signed-off-by: Stefan Hajnoczi
---
block/raw-posix.c | 51
From: Ekaterina Tumanova
Introduce driver methods of defining disk blocksizes (physical and
logical) and hard drive geometry.
Methods are only implemented for "host_device". For "raw" devices
driver calls child's method.
For now geometry detection will only work for DASD devices. To check
that a
1 - 100 of 294 matches
Mail list logo
