On 02/26/2015 01:32 AM, Shannon Zhao wrote: > On 2015/2/19 1:19, Wei Huang wrote: >> Nice work. I will help review the patches. >> > Thanks for your help :-) > >> Other than the CPU hotplug support, we are also seeking the guest VM >> powerdown support via ACPI. This feature is important for management >> tool to control guest VMs. In fact I had a similar GPIO patch for >> powerdown recently. Given that you already posted a more complete >> version, I wonder if you can add this feature to your patchset? FYI, I >> attached my powerdown patch in this email. Here is a brief list of items: >> >> * DSDT description of power button (to-be-done) >> * Hook up with qemu_qemu_register_powerdown_notifier() with the GPIO IRQ >> >> Feel free to add my name as signed-off-by in this feature if you decide >> to add it. > > Yes, I think the powerdown support is very useful, but maybe this feature can > be > added by a new patchset as this patchset cares about CPU hotplug. > > We can add powerdown, memory hotplug, cpu remove and memory remove support > step > by step if the approach of this patchset is accepted. I can make a patch to > add > powerdown support based on this patchset and your attached patch if you want > to > test this feature. How do you think about this? That sounds good to me. It does make sense to separate them. Keep me in loop.
Thanks, -Wei >
