On Thu, 01/22 15:47, Paolo Bonzini wrote:
> Do the entire lookup under RCU, which avoids atomic operations.
address_space_get_flatview() already is RCU protected, I don't see why this
patch is necessary. Could you explain?
And there is one question below:
>
> Signed-off-by: Paolo Bonzini
> ---
On Thu, 01/22 15:47, Paolo Bonzini wrote:
> Replace the flat_view_mutex by RCU, avoiding futex contention for
> dataplane on large systems and many iothreads.
>
> Signed-off-by: Paolo Bonzini
> ---
> include/exec/memory.h | 5 +
> memory.c | 54
> ++
On Thu, 01/22 15:47, Paolo Bonzini wrote:
> Asynchronous callbacks provided by call_rcu are particularly important
> for QEMU, because the BQL makes it hard to use synchronize_rcu.
>
> In addition, the current RCU implementation is not particularly friendly
> to multiple concurrent synchronize_rcu
On Thu, 01/22 15:47, Paolo Bonzini wrote:
> From: Jan Kiszka
>
> Now that memory_region_destroy can be called from an RCU callback,
> checking the BQL-protected global memory_region_transaction_depth
> does not make much sense.
>
> Signed-off-by: Jan Kiszka
> Signed-off-by: Paolo Bonzini
> ---
Hi again, I am sorry for multiple reply, but i forget to mention one
other thing.
I also use lttng-ust method, and like my printf() attempt, I put my
new defined trace points into all function within net/net.c, net/tap.c
and hw/net/virtio-net.c. Using this approach, i also cannot capture
my new t
On Mon, 2015-01-26 at 04:19 +0100, Alexandre DERUMIER wrote:
> Thanks for your reply.
>
> 2 others things:
>
> 1)
> on cpu unplug, I see that the cpu is correctly removed from my linux guest
> but not from qemu
>
About this, I can do it successfully on my qemu.
So can you tell us more informat
On Mon, 2015-01-26 at 04:25 +0100, Alexandre DERUMIER wrote:
> >>2)when numa is used, the hotplugged cpu is always on numa node 0
> >>(cpu_add or device_add cpu)
>
> About this, it seem to be a display bug in "info numa",
> cpu is correctly assigned to numa node1 in the guest.
>
>
Now in the
On Thu, 01/22 15:47, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> include/qemu/rcu.h | 15 ++-
> tests/rcutorture.c | 2 ++
> 2 files changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/include/qemu/rcu.h b/include/qemu/rcu.h
> index cfef36e..da043f2 100644
> --
On Thu, 01/22 15:47, Paolo Bonzini wrote:
> +
> +long long n_reads = 0LL;
> +long n_updates = 0L;
> +int nthreadsrunning;
> +
> +char argsbuf[64];
This seems unused. Overall the gtest enabled part looks good to me.
Reviewed-by: Fam Zheng
>>2)when numa is used, the hotplugged cpu is always on numa node 0
>>(cpu_add or device_add cpu)
About this, it seem to be a display bug in "info numa",
cpu is correctly assigned to numa node1 in the guest.
- Mail original -
De: "aderumier"
À: "Zhu Guihua"
Cc: "qemu-devel" , tangc...
Thanks for your reply.
2 others things:
1)
on cpu unplug, I see that the cpu is correctly removed from my linux guest but
not from qemu
starting with a guest with 3cpus:
guest: #ls -lah /sys/devices/system/ |grep cpu
drwxr-xr-x 6 root root0 Jan 25 22:16 cpu0
drwxr-xr-x 6 root root0 Jan
On Thu, 01/22 15:47, Paolo Bonzini wrote:
> This includes a (mangled) copy of the liburcu code. The main changes
> are: 1) removing dependencies on many other header files in liburcu; 2)
> removing for simplicity the tentative busy waiting in synchronize_rcu,
> which has limited performance effect
- Original Message -
>
> On 01/26/2015 10:06 AM, Alex Williamson wrote:
> >
> > - Original Message -
> >> CC: qemu-triv...@nongnu.org
> >>
> >> On 01/22/2015 04:14 PM, Eric Auger wrote:
> >>> Hi Chen,
> >>>
> >>> thanks for correcting this mistake I introduced when moving code fr
On 2015/1/25 0:22, Michael S. Tsirkin wrote:
> On Sat, Jan 24, 2015 at 05:21:11PM +0800, Shannon Zhao wrote:
>> > Introduce a preliminary framework in virt-acpi-build.c with the main
>> > ACPI build functions. It exposes the generated ACPI contents to
>> > guest over fw_cfg. Some codes borrowed fro
On 2015/1/25 7:31, Laszlo Ersek wrote:
> On 01/24/15 10:21, Shannon Zhao wrote:
>> This patch series generate seven ACPI v5.1 tables for machine virt on
>> ARM.
>> The set of generated tables are:
>> - RSDP
>> - XSDT
>> - MADT
>> - GTDT
>> - FADT
>> - FACS
>> - DSDT
>>
>> These tables are created d
On 01/26/2015 10:06 AM, Alex Williamson wrote:
- Original Message -
CC: qemu-triv...@nongnu.org
On 01/22/2015 04:14 PM, Eric Auger wrote:
Hi Chen,
thanks for correcting this mistake I introduced when moving code from
pci to common.
so, can you check in this patch?
I've got it queu
Hi Stefan, thank you for the tips.
I was trying the way you suggested to add printfs.
For starter I try to put them into all function within net/net.c,
net/tap.c and hw/net/virtio-net.c (I run qemu using virtio netcard).
However, there were no printf message showed up (when i started a qemu
proces
- Original Message -
> CC: qemu-triv...@nongnu.org
>
> On 01/22/2015 04:14 PM, Eric Auger wrote:
> > Hi Chen,
> >
> > thanks for correcting this mistake I introduced when moving code from
> > pci to common.
>
> so, can you check in this patch?
I've got it queued up and while it's clear
On Fri, 2015-01-23 at 11:24 +0100, Alexandre DERUMIER wrote:
> Hello,
>
> I'm currently testing the new cpu unplug features,
> Works fine here with debian guests and kernel 3.14.
>
Thanks for your test.
> But I have notice some small potential bugs, but I'm not sure I'm doing it
> right.
>
>
On 2015/1/25 2:56, Laszlo Ersek wrote:
> On 01/24/15 10:21, Shannon Zhao wrote:
>> Expose the needed device information to the table generation
>> insfrastructure and register a machine_init_done notify to
>> call virt_acpi_build().
>>
>> Add CONFIG_ACPI to arm-softmmu.mak, but there is compile err
Hi MST,
Thanks for your review :-) Reply below.
On 2015/1/25 16:39, Michael S. Tsirkin wrote:
> On Sat, Jan 24, 2015 at 05:21:18PM +0800, Shannon Zhao wrote:
>> Add acpi_fixed_memory32() for describing device mmio region in resource
>> template.
>> Add acpi_extended_irq() for describing device
On 2015/1/25 6:04, Laszlo Ersek wrote:
> comments below, fix attached
>
> On 01/24/15 10:21, Shannon Zhao wrote:
>> XDST points to other tables except FACS & DSDT.
>> Implement a common header helper functions for generating ACPI tables.
>>
>> Signed-off-by: Shannon Zhao
>> ---
>> hw/arm/virt-ac
On 2015/1/25 6:05, Laszlo Ersek wrote:
> comments below
>
> On 01/24/15 10:21, Shannon Zhao wrote:
>> FADT points to FACS and DSDT, in the case of mach virt, it is also used
>> to set the Hardware Reduced bit and enable PSCI SMP booting through HVC.
>>
>> Update the header definitions for FADT tak
I am not 100% sure whether this is the right place to raise this issue.
Maybe you can forward this to right person
|
I have the feeling this wikipage >>>
http://wiki.qemu.org/Documentation/CreateSnapshot is wrong. I think the
decription and the posted command for creating snapshots [||qemu-img
CC: qemu-triv...@nongnu.org
On 01/22/2015 04:14 PM, Eric Auger wrote:
Hi Chen,
thanks for correcting this mistake I introduced when moving code from
pci to common.
so, can you check in this patch?
Thanks,
Chen
Best Regards
Eric
On 01/22/2015 04:50 AM, Chen Fan wrote:
Signed-off-by: Che
On 2015-01-23 07:30:19, Kashyap Chamarthy wrote:
>On Wed, Jan 21, 2015 at 11:39:44AM +0100, Paolo Bonzini wrote:
> >
> >
> > On 21/01/2015 11:32, Zhang Haoyu wrote:
> > > Hi,
>> >
> > > Does drive_mirror support incremental backup a running vm?
> > > Or other mechanism does?
> > >
>> > increme
On 2015/1/23 8:43, Chen, Tiejun wrote:
On 2015/1/22 8:51, Chen, Tiejun wrote:
On 2015/1/21 21:48, Gerd Hoffmann wrote:
On Mi, 2015-01-21 at 11:37 +, Ian Jackson wrote:
Tiejun Chen writes ("[RFC][PATCH 1/1] libxl: add one machine property
to support IGD GFX passthrough"):
When we're workin
On 25 January 2015 at 21:59, Chen Gang S wrote:
> On 1/25/15 20:49, Peter Maydell wrote:
>> Are you claiming that you've reviewed *all* the code in this
>> file for mismatched lock/unlock calls? If so, it would be nice
>> to say so explicitly in the commit message. If not, it would be
>> nice if t
On 1/25/15 20:49, Peter Maydell wrote:
> On 25 January 2015 at 12:06, Chen Gang S wrote:
>> lock_user_struct() and unlock_user_struct() need always be paired with
>> each other, or will cause resource leak.
>>
>> Also remove redundant check for 'target_mb' in abi_long do_msgrcv().
>>
>> Also match
v2: Replaced some parentheses I lost when preparing the patch for submission.
If the keymap specifies the shift modifier for a keysym and that modifier
isn't in effect, send a fake press/release for shift around the key event.
Specifically, this resolves the issue of # producing a 3 when I press
If the keymap specifies the shift modifier for a keysym and that modifier
isn't in effect, send a fake press/release for shift around the key event.
Specifically, this resolves the issue of # producing a 3 when I press the
# on my UK keyboard with a VM with a US keyboard. (FYI the UK # key is
wher
Based on the pl061 model. This model implements all four banks with 32 I/Os
each.
The I/Os are placed in named groups:
* bankX_in for the 32 inputs of each bank
* bankX_out for the 32 outputs of each bank
Basic I/O and IRQ support tested with the Zynq GPIO driver in Linux 3.12.
Reviewed-by: P
Reviewed-by: Peter Crosthwaite
Signed-off-by: Colin Leitner
---
hw/arm/xilinx_zynq.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c
index 06e6e24..6d8c0d9 100644
--- a/hw/arm/xilinx_zynq.c
+++ b/hw/arm/xilinx_zynq.c
@@ -202,6 +202,8 @@ static
Hello everyone,
this is the fourth version of the Zynq GPIO model patch. It includes
* removal of unneeded memset in zynq_gpio_realize
* some minor code cleanup
* fixes for all remaining checkpatch warnings (lines too long)
Regards,
Colin
Colin Leitner (2):
zynq_gpio: GPIO model fo
Public bug reported:
QEMU version: git a46b3aaf6bb038d4f6f192a84df204f10929e75c
/opt/qemu.git/bin/qemu-system-aarch64 --version
QEMU emulator version 2.2.50, Copyright (c) 2003-2008 Fabrice Bellard
Hosts:
ovs - host machine (Ubuntu 14.04.1, x86_64)
debian8-arm64 - guest
Guest start:
user@ovs:
Hello
attached is the v2 set of patchs.
Le 01/01/2015 20:10, Stefan Weil a écrit :
> I suggest calling MapVirtualKey only for those keys which don't need special
> handling, so it would be in the default case of the switch statement.
Done (patch 0001) . updated code yields to same result as prev
Gns3 Labs shared a post with you on Google+. Google+ makes sharing on the
web more like sharing in real life.Learn more:
http://www.google.com/+/learnmore/
You have received this message because Gns3 Labs shared it with
qemu-devel@nongnu.org.
Accept the invitation to view the full post:
h
On 25 January 2015 at 12:06, Chen Gang S wrote:
> lock_user_struct() and unlock_user_struct() need always be paired with
> each other, or will cause resource leak.
>
> Also remove redundant check for 'target_mb' in abi_long do_msgrcv().
>
> Also match the coding styles found by "./scripts/checkpat
On 25 January 2015 at 11:35, Chen Gang S wrote:
> In main.c, all SIG* need be change to TARGET_SIG*, since the related
> next call are all for TARGET_SIG*: queue_signal() and gdb_handlesig().
>
> The related vi operation command is "1,$ s/\
>
> Signed-off-by: Chen Gang
Reviewed-by: Peter Maydell
On 25 January 2015 at 11:03, Chen Gang S wrote:
> start/end_exclusive() need be pairs, except the start_exclusive() in
> stop_all_tasks() which is only used by force_sig(), which will be abort.
> So at present, start_exclusive() in stop_all_task() need not be paired.
>
> queue_signal() may call fo
On 25 January 2015 at 00:00, Chen Gang S wrote:
> In abi_long do_ioctl_dm(), after calls lock_user(), it does not call
> unlock_user() before go to failure return in default case.
>
> Signed-off-by: Chen Gang
> ---
> linux-user/syscall.c | 2 ++
> 1 file changed, 2 insertions(+)
--
Reviewed-by
lock_user_struct() and unlock_user_struct() need always be paired with
each other, or will cause resource leak.
Also remove redundant check for 'target_mb' in abi_long do_msgrcv().
Also match the coding styles found by "./scripts/checkpatch.pl".
Signed-off-by: Chen Gang
---
linux-user/syscall.
In main.c, all SIG* need be change to TARGET_SIG*, since the related
next call are all for TARGET_SIG*: queue_signal() and gdb_handlesig().
The related vi operation command is "1,$ s/\
---
linux-user/main.c | 64 +++
1 file changed, 32 insertion
start/end_exclusive() need be pairs, except the start_exclusive() in
stop_all_tasks() which is only used by force_sig(), which will be abort.
So at present, start_exclusive() in stop_all_task() need not be paired.
queue_signal() may call force_sig(), or return after kill pid (or queue
signal). If
From: Christian Svensson
This patch adds support for atomic locks
and is an adaption from
https://github.com/bluecmd/or1k-qemu/commits/or32-optimize
Tested via the atomic lock implementation of musl
Signed-off-by: Christian Svensson
Signed-off-by: Sebastian Macke
---
target-openrisc/cpu.h
This patch separates the load and store instruction to a
separate function.
The repetition of the source code can be reduced and further
optimizations can be implemented.
In this case it checks for a zero offset and optimizes it.
Signed-off-by: Sebastian Macke
---
target-openrisc/translate.c | 1
This patch adds the new atomic operations of the
Load-link/store-conditional type which are called
l.lwa and l.swa.
For a cleaner implementation, all load and store instructions
are separated to a function.
Christian Svensson (1):
target-openrisc: Add l.lwa/l.swa support
Sebastian Macke (1):
On Sat, Jan 24, 2015 at 05:21:18PM +0800, Shannon Zhao wrote:
> Add acpi_fixed_memory32() for describing device mmio region in resource
> template.
> Add acpi_extended_irq() for describing device interrupt in resource template.
> These can be used to generating DSDT table for ACPI on ARM.
>
> Sig
48 matches
Mail list logo
