On 1/25/15 20:49, Peter Maydell wrote: > On 25 January 2015 at 12:06, Chen Gang S <gang.c...@sunrus.com.cn> wrote: >> lock_user_struct() and unlock_user_struct() need always be paired with >> each other, or will cause resource leak. >> >> Also remove redundant check for 'target_mb' in abi_long do_msgrcv(). >> >> Also match the coding styles found by "./scripts/checkpatch.pl". >> >> Signed-off-by: Chen Gang <gang.chen.5...@gmail.com> > > Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> > Thank you for your work about the several patches.
> Are you claiming that you've reviewed *all* the code in this > file for mismatched lock/unlock calls? If so, it would be nice > to say so explicitly in the commit message. If not, it would be > nice if the commit message was clearer about what areas of the > code it applied to. The code changes are correct, though. > At present, I finished all lock_user_struct() and unlock_user_struct() in "linux-user/syscall.c". For me, after this patch, they are all OK. But for all lock/unlock in "linux-user/syscall.c", for me, I am doubting several areas, but I did not send patch for them: - I need check them carefully again to be sure they are really issue: Read the related code again and again, if I really treat it as an issue, I shall make related patch (and pass compiling, at least). - I have no enough time resources on it: In week end, I have to spend some time resource on my son (check his homework, play with him). I also need spend time resources on Linux kernel and gcc/binutils. In week day, I may work overtime sometimes, also I need spend 4 hours on subway between my home and office per day (come and go). - So it is really necessary for me to make a schedule (the tasks/steps, the time point, and the risks), and also need consider about: How to use the time resources efficiently: e.g. fully use the time resources on the subway between home and office, in work day; fully use the time resources on holidays (e.g. Chinese Spring Festival). How to fully use the human resources: e.g. try my best to always keep well communication with all related open source members (which will give much valuable help for the related tasks). Welcome any members' ideas, suggestions, and completions, also welcome any members to help check "linux-user/syscall.c" (it will save my time resource: now for qemu, my highest priority task is for tile qemu). Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed
