----- Original Message ----- > > On 01/26/2015 10:06 AM, Alex Williamson wrote: > > > > ----- Original Message ----- > >> CC: qemu-triv...@nongnu.org > >> > >> On 01/22/2015 04:14 PM, Eric Auger wrote: > >>> Hi Chen, > >>> > >>> thanks for correcting this mistake I introduced when moving code from > >>> pci to common. > >> so, can you check in this patch? > > I've got it queued up and while it's clearly an error, I don't see that the > > fix actually changes the resulting code, the parameter is ignored in the > > macro. Am I missing something? If that's the case, I'll include it in my > > next pull request, but I don't see any pressing reason to rush that > > request. Thanks, > Yes, this patch can not affect the result of the code execution for > now, but I think it is also a typo mistake, if the macro > QLIST_HEAD_INITIALIZER > will be changed and using the parameter in the future, this error will > be difficultly found. I think the earlier found the earlier fixed.
Yes, it's obviously an error and I'll get it in before QEMU 2.3, likely within the next week or so. Thanks, Alex > >>> On 01/22/2015 04:50 AM, Chen Fan wrote: > >>>> Signed-off-by: Chen Fan <chen.fan.f...@cn.fujitsu.com> > >>>> --- > >>>> hw/vfio/common.c | 2 +- > >>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>> > >>>> diff --git a/hw/vfio/common.c b/hw/vfio/common.c > >>>> index cf483ff..e71385e 100644 > >>>> --- a/hw/vfio/common.c > >>>> +++ b/hw/vfio/common.c > >>>> @@ -32,7 +32,7 @@ > >>>> #include "trace.h" > >>>> > >>>> struct vfio_group_head vfio_group_list = > >>>> - QLIST_HEAD_INITIALIZER(vfio_address_spaces); > >>>> + QLIST_HEAD_INITIALIZER(vfio_group_list); > >>>> struct vfio_as_head vfio_address_spaces = > >>>> QLIST_HEAD_INITIALIZER(vfio_address_spaces); > >>>> > >>>> > >> > > . > > > >
