Re: [Qemu-devel] [PATCH v2 04/10] rocker: add register programming guide

2015-01-05 Thread Scott Feldman
I would like to keep it with qemu.git, if possible. Since the device doesn't really exist in the real world, and there is no particular company behind it, there isn't really a place for the spec to live other than beside the implementation. docs/specs is fine by me. I had a test/ directory in th

Re: [Qemu-devel] [PATCH] vl.c: fix -usb option assertion failure in qemu_opt_get_bool_helper()

2015-01-05 Thread Shannon Zhao
On 2015/1/6 10:37, Chen, Tiejun wrote: > On 2015/1/5 20:14, Marcel Apfelbaum wrote: >> On 01/05/2015 01:50 PM, Stefan Hajnoczi wrote: >>> On Mon, Jan 5, 2015 at 11:37 AM, Jan Kiszka >>> wrote: On 2015-01-05 12:22, Stefan Hajnoczi wrote: > Commit 49d2e648e8087d154d8bf8b91f27c8e05e79d5a6 ("

[Qemu-devel] [RFC PATCH v3 1/3] hw/arm/virt: Use memory_region_allocate_system_memory to allocate memory

2015-01-05 Thread Shannon Zhao
Use memory_region_allocate_system_memory to allocate memory. The function is sensitive to NUMA and can allocate memory for NUMA topology. Signed-off-by: Shannon Zhao --- hw/arm/virt.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index

[Qemu-devel] [RFC PATCH v3 2/3] hw/arm/virt: Don't add memory node in creat_fdt

2015-01-05 Thread Shannon Zhao
To support memory NUMA, don't add memory node in creat_fdt. But add it in a new function which takes into accout NUMA topology. Signed-off-by: Shannon Zhao --- hw/arm/virt.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index fdafa79..505

[Qemu-devel] [RFC PATCH v3 0/3] Add support for NUMA on ARM64

2015-01-05 Thread Shannon Zhao
Add support for NUMA on ARM64. Tested successfully running a guest Linux kernel with the following patch applied: - arm64:numa: adding numa support for arm64 platforms. http://article.gmane.org/gmane.linux.ports.arm.kernel/382179 Changes v2 ... v3: * update to use NUMA node property arm,associati

[Qemu-devel] [RFC PATCH v3 3/3] hw/arm/boot: Generate memory dtb according to NUMA topology

2015-01-05 Thread Shannon Zhao
Add a new function arm_generate_memory_dtb which is used to generate memory dtb according to NUMA topology and set the NUMA topology property of every cpu. Signed-off-by: Shannon Zhao --- hw/arm/boot.c | 80 ++-- 1 files changed, 77 insertion

Re: [Qemu-devel] [PATCH v2 04/10] rocker: add register programming guide

2015-01-05 Thread Jason Wang
On 01/06/2015 10:24 AM, sfel...@gmail.com wrote: > From: Scott Feldman > > This is the register programming guide for the Rocker device. It's intended > for driver writers and device writers. It covers the device's PCI space, > the register set, DMA interface, and interrupts. > > Signed-off-by:

Re: [Qemu-devel] [PATCH] target-openrisc: bugfix for dec_sys to decode instructions correctly

2015-01-05 Thread Fam Zheng
On Mon, 01/05 12:42, David Morrison wrote: > Fixed the decoding of "system" instructions (starting with 0x2) > in dec_sys() in translate.c. In particular, the l.trap instruction > is now correctly decoded, which enables for singlestepping and > breakpoints to be set in GDB. Missing a Signed-off-b

[Qemu-devel] [Bug 544527] Re: usbfs is bugged with >2.6.32.9 and <=2.6.33 (breaks VMWare, Qemu, sane scanners, ...)

2015-01-05 Thread POJAR GEO
** No longer affects: tvtime -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/544527 Title: usbfs is bugged with >2.6.32.9 and <=2.6.33 (breaks VMWare, Qemu, sane scanners, ...) Status in QEMU: I

Re: [Qemu-devel] [RFC][PATCH] qemu_opt_get_bool_helper: back finding desc by name just if !opt->desc

2015-01-05 Thread Chen, Tiejun
On 2015/1/6 9:21, Chen, Tiejun wrote: On 2015/1/6 1:13, Eric Blake wrote: On 01/04/2015 10:35 PM, Tiejun Chen wrote: After one commit 49d2e648e808, "machine: remove qemu_machine_opts global list", is introduced, QEMU doesn't keep a global list of options but set desc lately. Then we can see the

Re: [Qemu-devel] [PATCH] vl.c: fix -usb option assertion failure in qemu_opt_get_bool_helper()

2015-01-05 Thread Chen, Tiejun
On 2015/1/5 20:14, Marcel Apfelbaum wrote: On 01/05/2015 01:50 PM, Stefan Hajnoczi wrote: On Mon, Jan 5, 2015 at 11:37 AM, Jan Kiszka wrote: On 2015-01-05 12:22, Stefan Hajnoczi wrote: Commit 49d2e648e8087d154d8bf8b91f27c8e05e79d5a6 ("machine: remove qemu_machine_opts global list") removed op

[Qemu-devel] [PATCH v2 10/10] MAINTAINERS: add rocker

2015-01-05 Thread sfeldma
From: Scott Feldman Signed-off-by: Scott Feldman Signed-off-by: Jiri Pirko --- MAINTAINERS |6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 01cfb05..287b147 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -730,6 +730,12 @@ S: Maintained F: hw/net/vmxn

[Qemu-devel] [PATCH v2 04/10] rocker: add register programming guide

2015-01-05 Thread sfeldma
From: Scott Feldman This is the register programming guide for the Rocker device. It's intended for driver writers and device writers. It covers the device's PCI space, the register set, DMA interface, and interrupts. Signed-off-by: Scott Feldman Signed-off-by: Jiri Pirko --- hw/net/rocker/

[Qemu-devel] [PATCH v2 06/10] pci: add network device class 'other' for network switches

2015-01-05 Thread sfeldma
From: Scott Feldman Rocker is an ethernet switch device, so add 'other' network device class as defined by PCI to cover these types of devices. Signed-off-by: Scott Feldman Signed-off-by: Jiri Pirko --- include/hw/pci/pci_ids.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/hw

[Qemu-devel] [PATCH v2 08/10] qmp: add rocker device support

2015-01-05 Thread sfeldma
From: Scott Feldman Add QMP/HMP support for rocker devices. This is mostly for debugging purposes to see inside the device's tables and port configurations. Some examples: (qemu) rocker sw1 name: sw1 id: 0x013512005452 ports: 4 (qemu) rocker-ports sw1 ena/speed/ auto

[Qemu-devel] [PATCH v2 05/10] pci: add rocker device ID

2015-01-05 Thread sfeldma
From: Scott Feldman Signed-off-by: Scott Feldman Signed-off-by: Jiri Pirko --- docs/specs/pci-ids.txt |1 + include/hw/pci/pci.h |1 + 2 files changed, 2 insertions(+) diff --git a/docs/specs/pci-ids.txt b/docs/specs/pci-ids.txt index c6732fe..e4a4490 100644 --- a/docs/specs/pci-ids

[Qemu-devel] [PATCH v2 02/10] net: add MAC address string printer

2015-01-05 Thread sfeldma
From: Scott Feldman We can use this in virtio-net code as well as new Rocker driver code, so up-level this. Signed-off-by: Scott Feldman --- include/net/net.h |1 + net/net.c |7 +++ 2 files changed, 8 insertions(+) diff --git a/include/net/net.h b/include/net/net.h index

[Qemu-devel] [PATCH v2 03/10] virtio-net: use qemu_mac_strdup_printf

2015-01-05 Thread sfeldma
From: Scott Feldman Signed-off-by: Scott Feldman --- hw/net/virtio-net.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index e574bd4..9afe669 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -226,12 +226

[Qemu-devel] [PATCH v2 09/10] rocker: add tests

2015-01-05 Thread sfeldma
From: Scott Feldman Add some basic test for rocker to test L2/L3/L4 functionality. Requires an external test environment, simp, located here: https://github.com/scottfeldman/simp To run tests, simp environment must be installed and a suitable VM image built and installed with a Linux 3.18 (or

[Qemu-devel] [PATCH v2 00/10] rocker: add new rocker ethernet switch device

2015-01-05 Thread sfeldma
From: Scott Feldman v2: - Address reg_guide.txt review comments from Eric Blake - Address QMP review comments from Eric Blake v1: [This is a collaboration between myself and Jiri Pirko]. This patch set adds a new ethernet switch device, called rocker. Rocker is intended to emulate HW featu

[Qemu-devel] [PATCH v2 00/10] rocker: add new rocker ethernet switch device

2015-01-05 Thread sfeldma
From: Scott Feldman v2: - Address reg_guide.txt review comments from Eric Blake - Address QMP review comments from Eric Blake v1: [This is a collaboration between myself and Jiri Pirko]. This patch set adds a new ethernet switch device, called rocker. Rocker is intended to emulate HW featu

[Qemu-devel] [PATCH v2 01/10] pci: move REDHAT_SDHCI device ID to make room for Rocker

2015-01-05 Thread sfeldma
From: Scott Feldman The rocker device uses same PCI device ID as sdhci. Since rocker device driver has already been accepted into Linux 3.18, and REDHAT_SDHCI device ID isn't used by any drivers, it's safe to move REDHAT_SDHCI device ID, avoiding conflict with rocker. Signed-off-by: Scott Feldm

[Qemu-devel] [Bug 1406706] Re: guest will be destroyed when create guest with parameter "-usbdevice tablet".

2015-01-05 Thread chao zhou
test the patch with qemu.git commit ab0302ee764fd702465aef6d88612cdff4302809 create guest with parameter "-usbdevice tablet" , the guest works fine. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1406

Re: [Qemu-devel] [PATCH RESEND 0/2] PoC: Block replication for continuous checkpointing

2015-01-05 Thread Wen Congyang
On 01/05/2015 06:44 PM, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: >> >> >> On 26/12/2014 04:31, Yang Hongyang wrote: >>> Please feel free to comment. >>> We want comments/feedbacks as many as possiable please, thanks in advance. >> >> Hi Yang, >> >> I think it's p

Re: [Qemu-devel] [RFC][PATCH] qemu_opt_get_bool_helper: back finding desc by name just if !opt->desc

2015-01-05 Thread Chen, Tiejun
On 2015/1/6 1:13, Eric Blake wrote: On 01/04/2015 10:35 PM, Tiejun Chen wrote: After one commit 49d2e648e808, "machine: remove qemu_machine_opts global list", is introduced, QEMU doesn't keep a global list of options but set desc lately. Then we can see the following, $ x86_64-softmmu/qemu-syst

Re: [Qemu-devel] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-05 Thread Programmingkid
On Jan 5, 2015, at 5:06 PM, Peter Maydell wrote: > On 5 January 2015 at 21:27, Programmingkid wrote: >> This patches does the following: >> >> - Allows user to select endian format of video display. >> This allows Mac OS X to be used as a guest and show all its colors >> correctly. Just add -di

Re: [Qemu-devel] [PATCH 10/10] block/dmg: improve zeroes handling

2015-01-05 Thread Peter Wu
On Monday 05 January 2015 14:48:03 John Snow wrote: > On 12/27/2014 10:01 AM, Peter Wu wrote: > > Disk images may contain large all-zeroes gaps (1.66k sectors or 812 MiB > > is seen in the real world). These blocks (type 2) do not need to be > > extracted into a temporary buffer, there is no need t

Re: [Qemu-devel] bind interdomain ioctl error xen-kvm.c

2015-01-05 Thread Don Slutz
On 01/05/15 14:10, Rishi Ranjan wrote: > Hi Stefano, > Please find my answers inline. > > However Anthony (CC'ed) should have some patches for it. > Anthony, can you please share any patch that can help me with this? > > > Can you post the full output of the logs? > I h

[Qemu-devel] [Bug 1407813] [NEW] QEMU wrongly translates newlines on serial output

2015-01-05 Thread Nadav Har'El
Public bug reported: When using "-serial stdio", QEMU shows the guest serial port's output on the tty running qemu. As it should, QEMU sets the tty to raw mode. Or almost... Strangely, it neglects to remove one output-translation bit, ONLCR (see termios(3)) enabled on the tty. And it should have r

Re: [Qemu-devel] [PATCH v1 1/1] char: cadence_uart: Convert to realize()

2015-01-05 Thread Alistair Francis
On Fri, Jul 4, 2014 at 9:17 AM, Peter Crosthwaite wrote: > On Fri, Jul 4, 2014 at 2:59 AM, Andreas Färber wrote: >> Am 03.07.2014 18:46, schrieb Peter Maydell: >>> On 24 June 2014 07:06, Alistair Francis wrote: SysBusDevice::init is deprecated. Convert to Object::init and >> >> Note that th

Re: [Qemu-devel] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-05 Thread Peter Maydell
On 5 January 2015 at 21:27, Programmingkid wrote: > This patches does the following: > > - Allows user to select endian format of video display. > This allows Mac OS X to be used as a guest and show all its colors > correctly. Just add -display-endian-big to the command line to use > this feature.

[Qemu-devel] [Bug 1407808] [NEW] virtual console gives strange response to ANSI DSR

2015-01-05 Thread Nadav Har'El
Public bug reported: With "-serial vc" (which is the default), qemu make strange responses to the ANSI DSR escape sequence (\033[6n) which can confuse guests. Terminal emulators supporting the ANSI escape sequences usually support the "Device Status Report" escape sequence, \033[6n, to which as a

[Qemu-devel] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-05 Thread Programmingkid
This patches does the following: - Allows user to select endian format of video display. This allows Mac OS X to be used as a guest and show all its colors correctly. Just add -display-endian-big to the command line to use this feature. - Removes unneeded #ifdefs in drawRect: method. Correct m

[Qemu-devel] [PATCH] target-openrisc: bugfix for dec_sys to decode instructions correctly

2015-01-05 Thread David Morrison
Fixed the decoding of "system" instructions (starting with 0x2) in dec_sys() in translate.c. In particular, the l.trap instruction is now correctly decoded, which enables for singlestepping and breakpoints to be set in GDB. --- target-openrisc/translate.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Qemu-devel] [PATCH] include/qom/cpu.h: Add missing documentation for some CPUClass methods

2015-01-05 Thread Greg Kurz
On Mon, 5 Jan 2015 14:23:32 + Peter Maydell wrote: > The CPUClass QOM methods virtio_is_big_endian, write_elf{32,64}_note > and write_elf{32,64}_qemunote were added without any description > being added to the doc comment. Correct this omission. > > Signed-off-by: Peter Maydell > --- Than

Re: [Qemu-devel] [PATCH] exec.c: Drop TARGET_HAS_ICE define and checks

2015-01-05 Thread Richard Henderson
On 01/05/2015 11:09 AM, Peter Maydell wrote: > The TARGET_HAS_ICE #define is intended to indicate whether a target-* > guest CPU implementation supports the breakpoint handling. However, > all our guest CPUs have that support (the only two which do not > define TARGET_HAS_ICE are unicore32 and open

Re: [Qemu-devel] [PATCH 10/10] block/dmg: improve zeroes handling

2015-01-05 Thread John Snow
On 12/27/2014 10:01 AM, Peter Wu wrote: Disk images may contain large all-zeroes gaps (1.66k sectors or 812 MiB is seen in the real world). These blocks (type 2) do not need to be extracted into a temporary buffer, there is no need to allocate memory for these blocks nor to check its length. (

Re: [Qemu-devel] [PATCH 09/10] block/dmg: support bzip2 block entry types

2015-01-05 Thread John Snow
On 12/27/2014 10:01 AM, Peter Wu wrote: This patch adds support for bzip2-compressed block entries as introduced with OS X 10.4 (source: https://en.wikipedia.org/wiki/Apple_Disk_Image). It was tested against a 5.2G "OS X Yosemite" installation image which stores the BLXX block in the XML prope

Re: [Qemu-devel] bind interdomain ioctl error xen-kvm.c

2015-01-05 Thread Rishi Ranjan
Hi Stefano, Please find my answers inline. However Anthony (CC'ed) should have some patches for it. Anthony, can you please share any patch that can help me with this? Can you post the full output of the logs? I have attached the output of "sudo xl -v create /etc/xen/q

[Qemu-devel] [PATCH] exec.c: Drop TARGET_HAS_ICE define and checks

2015-01-05 Thread Peter Maydell
The TARGET_HAS_ICE #define is intended to indicate whether a target-* guest CPU implementation supports the breakpoint handling. However, all our guest CPUs have that support (the only two which do not define TARGET_HAS_ICE are unicore32 and openrisc, and in both those cases the bp support is prese

Re: [Qemu-devel] [PATCH] target-openrisc: bugfixes for debugging with GDB+Qemu on OpenRISC

2015-01-05 Thread Peter Maydell
On 5 January 2015 at 18:41, David Morrison wrote: > Hi, Peter, > > Thanks for the response. I'll split out the changes into separate commits > and resubmit. I do have one question here: > >> >>> diff --git a/target-openrisc/mmu.c b/target-openrisc/mmu.c >>> index 750a936..bbd05f1 100644 >>> ---

Re: [Qemu-devel] [PATCH] target-openrisc: bugfixes for debugging with GDB+Qemu on OpenRISC

2015-01-05 Thread David Morrison
Hi, Peter, Thanks for the response. I'll split out the changes into separate commits and resubmit. I do have one question here: diff --git a/target-openrisc/mmu.c b/target-openrisc/mmu.c index 750a936..bbd05f1 100644 --- a/target-openrisc/mmu.c +++ b/target-openrisc/mmu.c @@ -219,7 +219,7

Re: [Qemu-devel] [PATCH] target-openrisc: bugfixes for debugging with GDB+Qemu on OpenRISC

2015-01-05 Thread Peter Maydell
On 5 January 2015 at 18:15, Peter Maydell wrote: > On 18 December 2014 at 00:26, David Morrison wrote: >> --- a/target-openrisc/cpu.h >> +++ b/target-openrisc/cpu.h >> @@ -20,6 +20,7 @@ >> #ifndef CPU_OPENRISC_H >> #define CPU_OPENRISC_H >> >> +#define TARGET_HAS_ICE >> #define TARGET_LONG_BIT

Re: [Qemu-devel] Possible security enhancement for QEMU

2015-01-05 Thread Peter Maydell
On 5 January 2015 at 18:13, Daniel P. Berrange wrote: > Configuring 0.0.0.0 and no auth is a valid setup *provided* the virtualization > host itself is on a secured network. In fact this is the normal setup for an > OpenStack deployment, since the virt host/VNC server is not intended to ever > be

Re: [Qemu-devel] [PATCH] vl.c: fix -usb option assertion failure in qemu_opt_get_bool_helper()

2015-01-05 Thread Laszlo Ersek
On 01/05/15 13:14, Marcel Apfelbaum wrote: > On 01/05/2015 01:50 PM, Stefan Hajnoczi wrote: >> On Mon, Jan 5, 2015 at 11:37 AM, Jan Kiszka >> wrote: >>> On 2015-01-05 12:22, Stefan Hajnoczi wrote: Commit 49d2e648e8087d154d8bf8b91f27c8e05e79d5a6 ("machine: remove qemu_machine_opts global

Re: [Qemu-devel] [PATCH] target-openrisc: bugfixes for debugging with GDB+Qemu on OpenRISC

2015-01-05 Thread Peter Maydell
On 18 December 2014 at 00:26, David Morrison wrote: > This patch fixes two bugs in Qemu for OpenRISC, and enables more > functionality from or1k-elf-gdb: > > 1) Fixed the decoding of "system" instructions (starting with 0x2) > in dec_sys() in translate.c. In particular, the l.trap instruction > i

Re: [Qemu-devel] Possible security enhancement for QEMU

2015-01-05 Thread Daniel P. Berrange
On Mon, Dec 29, 2014 at 09:26:45PM +, Peter Maydell wrote: > On 29 December 2014 at 19:09, Attila-Mihaly Balazs wrote: > > My suggestion for improvement would be: > > - change the behaviour of "-vnc :port" such that it listens on "127.0.0.1" > > when the IP isn't specified > > - if host is "0.

Re: [Qemu-devel] [RFC v2 1/4] hw/arm/virt: Allow multiple agents to modify dt

2015-01-05 Thread Peter Maydell
On 5 January 2015 at 17:35, alvise rigo wrote: > So I suppose we need to define a fixed number of PCI slots according > to the number of interrupts available in mach-virt. In this regard, > should this number be a qdev property? The PCI spec means that a bus has an implicit maximum of 32 slots (t

Re: [Qemu-devel] [PATCH] target-openrisc: bugfixes for debugging with GDB+Qemu on OpenRISC

2015-01-05 Thread David Morrison
ping On 12/17/2014 04:26 PM, David Morrison wrote: This patch fixes two bugs in Qemu for OpenRISC, and enables more functionality from or1k-elf-gdb: 1) Fixed the decoding of "system" instructions (starting with 0x2) in dec_sys() in translate.c. In particular, the l.trap instruction is now corr

Re: [Qemu-devel] [RFC v2 1/4] hw/arm/virt: Allow multiple agents to modify dt

2015-01-05 Thread alvise rigo
On Mon, Jan 5, 2015 at 5:41 PM, Peter Maydell wrote: > On 5 January 2015 at 16:14, alvise rigo wrote: >> On Mon, Jan 5, 2015 at 4:36 PM, Peter Maydell >> wrote: >>> Sorry, I think I must have missed this series first time around. >>> I'm not convinced -- I don't see any reason why we should tre

[Qemu-devel] [Bug 1404278] Re: tap connections not working on windows host

2015-01-05 Thread timsoft
have used wireshark on host and nothing is coming through when I try to ping the host from the client. (bare with me as I haven't used wireshark before). I'm just upgrading the client to slack64 14.1 so I can get wireshark running on it. (process is a little slow, especially with no functioning

[Qemu-devel] [PULL 01/02] seccomp: typo in configure error message

2015-01-05 Thread Eduardo Otubo
Error message was misleading people to install wrong version of libseccomp. Signed-off-by: Eduardo Otubo --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index cae588c..7539645 100755 --- a/configure +++ b/configure @@ -1830,7 +1830,7 @@ if

[Qemu-devel] [PULL 02/02] seccomp: add mbind() to the syscall whitelist

2015-01-05 Thread Eduardo Otubo
From: Paul Moore The "memory-backend-ram" QOM object utilizes the mbind(2) syscall to set the policy for a memory range. Add the syscall to the seccomp sandbox whitelist. Signed-off-by: Paul Moore Signed-off-by: Eduardo Otubo Acked-by: Eduardo Otubo Tested-by: Eduardo Habkost Reviewed-by: E

[Qemu-devel] [PULL 00/02] seccomp branch queue

2015-01-05 Thread Eduardo Otubo
The following changes since commit b574f602680d41c4cf4a9c106e3e2244bed01cdd: Merge remote-tracking branch 'remotes/kraxel/tags/pull-vga-20141216-1' into staging (2014-12-17 19:22:42 +) are available in the git repository at: https://github.com/otubo/qemu.git tags/pull-seccom

Re: [Qemu-devel] [PATCH v4 44/47] Postcopy; Handle userfault requests

2015-01-05 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Fri, Oct 03, 2014 at 06:47:50PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > userfaultfd is a Linux syscall that gives an fd that receives a stream > > of notifications of accesses to pages marked as

Re: [Qemu-devel] [RFC v2 3/4] hw/pci-host: Add a generic PCI host controller for virtual platforms

2015-01-05 Thread Alexander Graf
On 21.11.14 19:07, Alvise Rigo wrote: > Add a generic PCI host controller for virtual platforms, based on the > previous work by Rob Herring: > http://lists.gnu.org/archive/html/qemu-devel/2014-06/msg03482.html > > The controller creates a PCI bus for PCI devices; it is intended to > receive fro

Re: [Qemu-devel] [RFC][PATCH] qemu_opt_get_bool_helper: back finding desc by name just if !opt->desc

2015-01-05 Thread Eric Blake
On 01/04/2015 10:35 PM, Tiejun Chen wrote: > After one commit 49d2e648e808, "machine: remove qemu_machine_opts > global list", is introduced, QEMU doesn't keep a global list of > options but set desc lately. Then we can see the following, > > $ x86_64-softmmu/qemu-system-x86_64 -usb > qemu-system-

Re: [Qemu-devel] [PATCH 08/10] qmp: add rocker device support

2015-01-05 Thread Eric Blake
On 01/04/2015 02:24 PM, Scott Feldman wrote: > On Sun, Jan 4, 2015 at 1:16 PM, Scott Feldman wrote: >> On Fri, Jan 2, 2015 at 3:56 PM, Eric Blake wrote: >>> On 12/29/2014 10:14 PM, sfel...@gmail.com wrote: From: Scott Feldman >>> >>> In this mail, I'll review just the QMP interface portion:

Re: [Qemu-devel] [PATCH 08/10] qmp: add rocker device support

2015-01-05 Thread Eric Blake
On 01/04/2015 02:16 PM, Scott Feldman wrote: > On Fri, Jan 2, 2015 at 3:56 PM, Eric Blake wrote: >> On 12/29/2014 10:14 PM, sfel...@gmail.com wrote: >>> From: Scott Feldman >> >> [your message came through as a top-level thread instead of in-reply-to >> the 0/10 cover letter; please see if you ca

Re: [Qemu-devel] More structured migration URIs?

2015-01-05 Thread Eric Blake
On 01/05/2015 05:45 AM, Daniel P. Berrange wrote: >> It all gets a bit more complicated when an application could specify >> an arbitrary exec: uri through that API, rather than you knowing what it's >> doing. > > True, the QMP command would need to support a union of different options > switched

Re: [Qemu-devel] [PATCH] qga: add guest-set-admin-password command

2015-01-05 Thread Daniel P. Berrange
icmp(echo-request) Daniel On Mon, Dec 15, 2014 at 12:47:46PM +, Daniel P. Berrange wrote: > Add a new 'guest-set-admin-password' command for changing the > root/administrator password. This command is needed to allow > OpenStack to support its API for changing the admin password > on a runnin

Re: [Qemu-devel] [PATCH 06/10] block/dmg: process XML plists

2015-01-05 Thread John Snow
On 12/27/2014 10:01 AM, Peter Wu wrote: The format is simple enough to avoid using a full-blown XML parser. The offsets are based on the description at http://newosxbook.com/DMG.html Signed-off-by: Peter Wu --- block/dmg.c | 69 +

Re: [Qemu-devel] [PATCH 3/3] misc: Fix new typos in comments

2015-01-05 Thread John Snow
On 01/03/2015 08:41 AM, Stefan Weil wrote: recieve -> receive suprise -> surprise Cc: Igor Mammedov Cc: John Snow Signed-off-by: Stefan Weil --- include/hw/hotplug.h |2 +- tests/ahci-test.c|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/hw/hotp

Re: [Qemu-devel] [PATCH 06/10] block/dmg: process XML plists

2015-01-05 Thread John Snow
On 01/03/2015 06:54 AM, Peter Wu wrote: On Friday 02 January 2015 19:04:32 John Snow wrote: On 12/27/2014 10:01 AM, Peter Wu wrote: The format is simple enough to avoid using a full-blown XML parser. The offsets are based on the description at http://newosxbook.com/DMG.html Signed-off-by: Pe

Re: [Qemu-devel] [RFC v2 2/4] hw/arm/virt: find_machine_info: handle NULL value

2015-01-05 Thread Peter Maydell
On 5 January 2015 at 16:31, alvise rigo wrote: > It's just because in patch 1/4 of this series we use > find_machine_info(machine->cpu_model), which could be a NULL pointer. Well, don't do that, because in that case you'll do the wrong thing if we take the default value of the cpu model. But I do

Re: [Qemu-devel] [RFC v2 1/4] hw/arm/virt: Allow multiple agents to modify dt

2015-01-05 Thread Peter Maydell
On 5 January 2015 at 16:14, alvise rigo wrote: > On Mon, Jan 5, 2015 at 4:36 PM, Peter Maydell > wrote: >> Sorry, I think I must have missed this series first time around. >> I'm not convinced -- I don't see any reason why we should treat >> the PCI host controller differently from other devices

Re: [Qemu-devel] [RFC v2 2/4] hw/arm/virt: find_machine_info: handle NULL value

2015-01-05 Thread alvise rigo
It's just because in patch 1/4 of this series we use find_machine_info(machine->cpu_model), which could be a NULL pointer. Indeed this patch can be avoided reworking a bit the calling function code. Regards, alvise On Mon, Jan 5, 2015 at 4:36 PM, Peter Maydell wrote: > On 21 November 2014 at 18:

[Qemu-devel] [PATCH v8 3/3] hw/arm/virt: add dynamic sysbus device support

2015-01-05 Thread Eric Auger
Allows sysbus devices to be instantiated from command line by using -device option. Machvirt creates a platform bus at init. The dynamic sysbus devices are attached to this platform bus device. The platform bus device registers a machine init done notifier whose role will be to bind the dynamic sy

[Qemu-devel] [PATCH v8 1/3] hw/arm/sysbus-fdt: helpers for platform bus nodes addition

2015-01-05 Thread Eric Auger
This new C module will be used by ARM machine files to generate platform bus node and their dynamic sysbus device tree nodes. Dynamic sysbus device node addition is done in a machine init done notifier. arm_register_platform_bus_fdt_creator does the registration of this latter and is supposed to b

Re: [Qemu-devel] [RFC v2 1/4] hw/arm/virt: Allow multiple agents to modify dt

2015-01-05 Thread alvise rigo
Hi, On Mon, Jan 5, 2015 at 4:36 PM, Peter Maydell wrote: > On 24 November 2014 at 11:47, Claudio Fontana > wrote: >> On 21.11.2014 19:07, Alvise Rigo wrote: >>> Keep a global list with all the functions that need to modify the device >>> tree. Using qemu_add_machine_init_done_notifier we regist

[Qemu-devel] [PATCH v8 2/3] hw/arm/boot: arm_load_kernel implemented as a machine init done notifier

2015-01-05 Thread Eric Auger
Device tree nodes for the platform bus and its children dynamic sysbus devices are added in a machine init done notifier. To load the dtb once, after those latter nodes are built and before ROM freeze, the actual arm_load_kernel existing code is moved into a notifier notify function, arm_load_kerne

[Qemu-devel] [PATCH v8 0/3] machvirt dynamic sysbus device instantiation

2015-01-05 Thread Eric Auger
This patch series enables machvirt to dynamically instantiate sysbus devices from command line (using -device option). All those sysbus devices are plugged onto a platform bus. This latter device is instantiated in machvirt and takes care of the binding of children sysbus devices on a machine init

Re: [Qemu-devel] [v3 1/5] Qemu-Xen-vTPM: Support for Xen stubdom vTPM command line options

2015-01-05 Thread Eric Blake
On 12/30/2014 04:02 PM, Quan Xu wrote: > Signed-off-by: Quan Xu This message was missing an In-Reply-To header tying it to the 0/5 cover letter, making it show up as an independent thread. Please see if you can fix that for the next submission. > --- > configure| 14 ++ > h

Re: [Qemu-devel] [PATCH v4 33/47] Postcopy: Postcopy startup in migration thread

2015-01-05 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Fri, Oct 03, 2014 at 06:47:39PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Rework the migration thread to setup and start postcopy. > > > > Signed-off-by: Dr. David Alan Gilbert > > --- > > incl

Re: [Qemu-devel] [PATCH 04/10] rocker: add register programming guide

2015-01-05 Thread Eric Blake
On 12/29/2014 10:14 PM, sfel...@gmail.com wrote: > From: Scott Feldman > > This is the register programming guide for the Rocker device. It's intended > for driver writers and device writers. It covers the device's PCI space, > the register set, DMA interface, and interrupts. > > Signed-off-by

Re: [Qemu-devel] [RFC v2 2/4] hw/arm/virt: find_machine_info: handle NULL value

2015-01-05 Thread Peter Maydell
On 21 November 2014 at 18:07, Alvise Rigo wrote: > Signed-off-by: Alvise Rigo > --- > hw/arm/virt.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index e8d527d..4e7b869 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -151,6 +151,10 @@ static

Re: [Qemu-devel] [RFC v2 1/4] hw/arm/virt: Allow multiple agents to modify dt

2015-01-05 Thread Peter Maydell
On 24 November 2014 at 11:47, Claudio Fontana wrote: > On 21.11.2014 19:07, Alvise Rigo wrote: >> Keep a global list with all the functions that need to modify the device >> tree. Using qemu_add_machine_init_done_notifier we register a notifier >> that executes all the functions on the list and l

Re: [Qemu-devel] [PATCH] fw_cfg: fix endianness in fw_cfg_data_mem_read() / _write()

2015-01-05 Thread Laszlo Ersek
On 01/05/15 16:24, Peter Maydell wrote: > On 31 December 2014 at 11:21, Laszlo Ersek wrote: >> (1) Let's contemplate what device endianness means > > ...let's not, I value my sanity :-) Lol. :) I'm happy to have sacrificed mine for this matter! ;) >> hw/nvram/fw_cfg.c | 41 +++

Re: [Qemu-devel] [PATCH] fw_cfg: fix endianness in fw_cfg_data_mem_read() / _write()

2015-01-05 Thread Peter Maydell
On 31 December 2014 at 11:21, Laszlo Ersek wrote: > (1) Let's contemplate what device endianness means ...let's not, I value my sanity :-) > hw/nvram/fw_cfg.c | 41 +++-- > 1 file changed, 7 insertions(+), 34 deletions(-) Reviewed-by: Peter Maydell and tes

[Qemu-devel] [PATCH] include/qom/cpu.h: Add missing documentation for some CPUClass methods

2015-01-05 Thread Peter Maydell
The CPUClass QOM methods virtio_is_big_endian, write_elf{32,64}_note and write_elf{32,64}_qemunote were added without any description being added to the doc comment. Correct this omission. Signed-off-by: Peter Maydell --- More informative phrasings for the elf note callbacks welcome... include/

Re: [Qemu-devel] More structured migration URIs?

2015-01-05 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Mon, Jan 05, 2015 at 12:37:23PM +, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > On Mon, Jan 05, 2015 at 12:14:25PM +, Dr. David Alan Gilbert wrote: > > > > Hi, > > > > I keep thinking of th

Re: [Qemu-devel] [PATCH] target-arm: crypto: fix BE host support

2015-01-05 Thread Peter Maydell
On 5 January 2015 at 13:47, Ard Biesheuvel wrote: > On 5 January 2015 at 12:34, Peter Maydell wrote: >> On 2 January 2015 at 19:21, Ard Biesheuvel wrote: >>> I think the union type may have been a mistake to >>> begin with, because it introduces endianness dependencies that don't >>> actually ex

Re: [Qemu-devel] [PATCH V2 2/2] target-arm: Guest cpu endianness determination for virtio KVM ARM/ARM64

2015-01-05 Thread Peter Maydell
On 22 December 2014 at 09:04, Pranavkumar Sawargaonkar wrote: > This patch implements a fucntion pointer virtio_is_big_endian() > from "CPUClass" structure for arm/arm64. > Function arm_cpu_virtio_endianness() is added to determine and > return the guest cpu endianness to virtio. > This is require

Re: [Qemu-devel] [PATCH] target-arm: crypto: fix BE host support

2015-01-05 Thread Ard Biesheuvel
On 5 January 2015 at 12:34, Peter Maydell wrote: > On 2 January 2015 at 19:21, Ard Biesheuvel wrote: >> I think the union type may have been a mistake to >> begin with, because it introduces endianness dependencies that don't >> actually exist in the code. It probably would have been cleaner if I

Re: [Qemu-devel] [PATCH V2 1/2] target-arm: KVM64: Get and Sync up guest register state like kvm32.

2015-01-05 Thread Peter Maydell
On 22 December 2014 at 09:04, Pranavkumar Sawargaonkar wrote: > This patch adds: > 1. Call write_kvmstate_to_list() and write_list_to_cpustate() >in kvm_arch_get_registers() to sync guest register state. > 2. Call write_list_to_kvmstate() in kvm_arch_put_registers() >to sync guest register

Re: [Qemu-devel] 2.1 unexpected stop after exporting blockdev via nbd server

2015-01-05 Thread Andrey Korolyov
On Fri, Jan 2, 2015 at 4:04 PM, Stefan Hajnoczi wrote: > On Thu, Dec 18, 2014 at 07:38:59PM +0400, Andrey Korolyov wrote: >> 2.1-stable is currently crashing with the >> >> Co-routine re-entered recursively >> 2014-12-16 15:06:23.578+: shutting down >> >> after execution of (for example) follo

Re: [Qemu-devel] [PATCH] tcg-aarch64: handle additional PXN case

2015-01-05 Thread Peter Maydell
On 5 January 2015 at 12:52, Andrew Jones wrote: > On Mon, Jan 05, 2015 at 11:54:17AM +, Peter Maydell wrote: >> This condition is becoming pretty badly overweight. I think that >> rather than just add another clause to it (especially one which >> needs an embedded /* comment */ !) we should sp

Re: [Qemu-devel] bind interdomain ioctl error xen-kvm.c

2015-01-05 Thread Stefano Stabellini
On Tue, 30 Dec 2014, Rishi Ranjan wrote: > I am trying to use Xen as accelerator for my Qemu machine. I have created a > guest domain with following xl config:  > builder = "hvm" > name = "qemu-hvm" > memory = "512" > vcpus = 1 > vif = [''] > vnc = 1 > boot="c" > > > When I try to run with follo

Re: [Qemu-devel] [PATCH] tcg-aarch64: handle additional PXN case

2015-01-05 Thread Andrew Jones
On Mon, Jan 05, 2015 at 11:54:17AM +, Peter Maydell wrote: > On 2 January 2015 at 17:33, Andrew Jones wrote: > > D4.5.1 "Memory access control:Access permissions for instruction > > execution" states > > "... > > In addition: > > * For the EL1&0 translation regime, if the value of the AP[2:1]

Re: [Qemu-devel] More structured migration URIs?

2015-01-05 Thread Daniel P. Berrange
On Mon, Jan 05, 2015 at 12:37:23PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Mon, Jan 05, 2015 at 12:14:25PM +, Dr. David Alan Gilbert wrote: > > > Hi, > > > I keep thinking of things where it might make sense to add > > > options onto the

Re: [Qemu-devel] More structured migration URIs?

2015-01-05 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Mon, Jan 05, 2015 at 12:14:25PM +, Dr. David Alan Gilbert wrote: > > Hi, > > I keep thinking of things where it might make sense to add > > options onto the migration URIs and wondered if it makes > > sense to restructure the migration UR

Re: [Qemu-devel] [PATCH] block: limited request size in write zeroes unsupported path

2015-01-05 Thread Denis V. Lunev
On 05/01/15 14:29, Peter Lieven wrote: If bs->bl.max_write_zeroes is large and we end up in the unsupported path we might allocate a lot of memory for the iovector and/or even generate an oversized requests. Fix this by limiting the request by the minimum of the reported maximum transfer size or

Re: [Qemu-devel] [PATCH] target-arm: crypto: fix BE host support

2015-01-05 Thread Peter Maydell
On 2 January 2015 at 19:21, Ard Biesheuvel wrote: > I think the union type may have been a mistake to > begin with, because it introduces endianness dependencies that don't > actually exist in the code. It probably would have been cleaner if I > had defined the relation between VFP D-regs, words a

[Qemu-devel] [PATCH v3 1/1] block: prepare bdrv_co_do_write_zeroes to deal with large bl.max_write_zeroes

2015-01-05 Thread Denis V. Lunev
bdrv_co_do_write_zeroes split writes using bl.max_write_zeroes or 16 MiB as a chunk size. This is implemented in this way to tolerate buggy block backends which do not accept too big requests. Though if the bdrv_co_write_zeroes callback is not good enough, we fallback to write data explicitely usi

Re: [Qemu-devel] More structured migration URIs?

2015-01-05 Thread Daniel P. Berrange
On Mon, Jan 05, 2015 at 12:14:25PM +, Dr. David Alan Gilbert wrote: > Hi, > I keep thinking of things where it might make sense to add > options onto the migration URIs and wondered if it makes > sense to restructure the migration URIs; my proposal would be: > > a) Restructure tcp::ppp

Re: [Qemu-devel] [PATCH] block: limited request size in write zeroes unsupported path

2015-01-05 Thread Denis V. Lunev
On 05/01/15 15:14, Peter Lieven wrote: On 05.01.2015 12:51, Denis V. Lunev wrote: On 05/01/15 14:29, Peter Lieven wrote: If bs->bl.max_write_zeroes is large and we end up in the unsupported path we might allocate a lot of memory for the iovector and/or even generate an oversized requests. Fix

[Qemu-devel] [PATCH v2 1/1] block: prepare bdrv_co_do_write_zeroes to deal with large bl.max_write_zeroes

2015-01-05 Thread Denis V. Lunev
bdrv_co_do_write_zeroes split writes using bl.max_write_zeroes or 16 MiB as a chunk size. This is implemented in this way to tolerate buggy block backends which do not accept too big requests. Though if the bdrv_co_write_zeroes callback is not good enough, we fallback to write data explicitely usi

Re: [Qemu-devel] [PATCH 1/1] ich9: add disable_s3, disable_s4, s4_val properties

2015-01-05 Thread Amit Shah
On (Wed) 17 Dec 2014 [15:08:36], Marcel Apfelbaum wrote: > On 12/16/2014 01:23 PM, Amit Shah wrote: > >PIIX4 has disable_s3 and disable_s4 properties to enable or disable PM > >functions. Add such properties to the ICH9 chipset as well for the Q35 > >machine type. > > > >S3 / S4 are not guaranteed

Re: [Qemu-devel] [PATCH] block: limited request size in write zeroes unsupported path

2015-01-05 Thread Peter Lieven
On 05.01.2015 12:51, Denis V. Lunev wrote: On 05/01/15 14:29, Peter Lieven wrote: If bs->bl.max_write_zeroes is large and we end up in the unsupported path we might allocate a lot of memory for the iovector and/or even generate an oversized requests. Fix this by limiting the request by the mini

[Qemu-devel] More structured migration URIs?

2015-01-05 Thread Dr. David Alan Gilbert
Hi, I keep thinking of things where it might make sense to add options onto the migration URIs and wondered if it makes sense to restructure the migration URIs; my proposal would be: a) Restructure tcp:: into protocol=tcp,host=,port= b) Have a requirement that protocol= is

  1   2   >