[Qemu-devel] [v2 0/2] Add VT-d Posted-Interrupts support

2014-12-02 Thread Feng Wu
VT-d Posted-Interrupts is an enhancement to CPU side Posted-Interrupt. With VT-d Posted-Interrupts enabled, external interrupts from direct-assigned devices can be delivered to guests without VMM intervention when the guest is running in non-root mode. This patchset uses the new VFIO device attrib

[Qemu-devel] [v2 2/2] kvm, vfio: Update VT-d Posted-Interrupts related information

2014-12-02 Thread Feng Wu
VT-d Posted-Interrupts(PI) is an enhancement to CPU side Posted-Interrupt. With VT-d Posted-Interrupts enabled, external interrupts from direct-assigned devices can be delivered to guests without VMM involvement when guest is running in non-root mode. If VT-d PI is supported by KVM, we need to upd

[Qemu-devel] [v2 1/2] kvm, vfio: Define new VFIO data structure for VT-d Posted-Interrupts.

2014-12-02 Thread Feng Wu
Define new VFIO data structure for VT-d Posted-Interrupts. Signed-off-by: Feng Wu --- linux-headers/linux/kvm.h | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h index 1937afa..2253d01 100644 --- a/linux-heade

[Qemu-devel] [Bug 1368815] Re: qemu-img convert intermittently corrupts output images

2014-12-02 Thread Mathew Hodson
** Tags added: verification-needed-utopic -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1368815 Title: qemu-img convert intermittently corrupts output images Status in OpenStack Compute (Nova):

[Qemu-devel] advent calendar

2014-12-02 Thread Paul Ford
Love the advent calendar! Wonderful idea. One tiny note: On a Mac with qemu installed via the brew installer I don't have access to kvm, so to run the Slackware image I had to remove the kvm command-line option from the "Run" shell script. It was all a little new to me (not a regular qemu user) s

[Qemu-devel] [RFC PATCH v2 6/6] keymaps: convert fprintf to qerror_report

2014-12-02 Thread arei.gonglei
From: Gonglei Only report the first error to QMP monitor. Signed-off-by: Gonglei --- ui/keymaps.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ui/keymaps.c b/ui/keymaps.c index 49410ae..47471d1 100644 --- a/ui/keymaps.c +++ b/ui/keymaps.c @@ -24,6 +24,7 @@ #include

[Qemu-devel] [RFC PATCH v2 1/6] vnc: introduce vnc_display_kbd_layout function

2014-12-02 Thread arei.gonglei
From: Gonglei In order to support changing vnc keyboard layout dynamically. Signed-off-by: Gonglei --- include/ui/console.h | 5 + ui/vnc.c | 21 + 2 files changed, 26 insertions(+) diff --git a/include/ui/console.h b/include/ui/console.h index 887ed91..46

[Qemu-devel] [RFC PATCH v2 3/6] vnc: HMP change-vnc-kbd-layout wrapper

2014-12-02 Thread arei.gonglei
From: Gonglei Add HMP change-vnc-kbd-layout wrapper to allow changing VNC server keyboard layout via monitor. Signed-off-by: Gonglei --- hmp-commands.hx | 15 +++ hmp.c | 9 + hmp.h | 1 + 3 files changed, 25 insertions(+) diff --git a/hmp-commands.hx

[Qemu-devel] [RFC PATCH v2 5/6] keymaps: correct keymaps.c following Qemu coding style

2014-12-02 Thread arei.gonglei
From: Gonglei It's hard to read because of the confused coding style in this file. Let's correct it following Qemu coding style. Signed-off-by: Gonglei --- ui/keymaps.c | 196 --- 1 file changed, 108 insertions(+), 88 deletions(-) diff -

[Qemu-devel] [RFC PATCH v2 4/6] qapi-schema: fix typo about change-vnc-password

2014-12-02 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- qapi-schema.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-schema.json index 0d89b63..ae68a25 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -1533,7 +1533,7 @@ # # Change the VNC server passwor

[Qemu-devel] [RFC PATCH v2 2/6] vnc: add a new QMP command for changing keyboard layout

2014-12-02 Thread arei.gonglei
From: Gonglei Example QMP command of Change VNC keyboard layout: -> { "execute": "change-vnc-kbd-layout", "arguments": { "keymap": "de" } } <- { "return": {} Signed-off-by: Gonglei --- qapi-schema.json | 17 + qmp-commands.hx | 23 +++ qmp.c

[Qemu-devel] [RFC PATCH v2 0/6] Support to change VNC keyboard layout dynamically

2014-12-02 Thread arei.gonglei
From: Gonglei A bonus of this feature is that supporting different people (in different countries) using defferent keyboard to connect the same guest but not need to configure command line or libivrt xml file then restart guest. Using a new QMP command: -> { "execute": "change-vnc-kbd-layout

Re: [Qemu-devel] Review of monitor commands identifying BDS / BB by name

2014-12-02 Thread Fam Zheng
On Tue, 12/02 20:06, Markus Armbruster wrote: > == block-core.json == > > * block-commit > > @device names a backend, @top and @base each name one of its nodes via > file name matching. > > TODO: support specifying the two nodes via node name. > > Why do we need @device when a top node

[Qemu-devel] [PATCH RESCEND v2] target-i386: Intel xsaves

2014-12-02 Thread Wanpeng Li
Add xsaves related definition, it also adds corresponding part to kvm_get/put, and vmstate. Signed-off-by: Wanpeng Li --- v1 -> v2: * use a subsection instead of bumping the version number. target-i386/cpu.h | 2 ++ target-i386/kvm.c | 15 +++ target-i386/machine.c | 21 +

Re: [Qemu-devel] [RFC PATCH] hw/arm/virt: Add support for NUMA on ARM64

2014-12-02 Thread Shannon Zhao
On 2014/12/3 0:00, Peter Maydell wrote: > On 2 December 2014 at 12:56, Shannon Zhao wrote: >> Add support for NUMA on ARM64. Tested successfully running a guest >> Linux kernel with the following patch applied: >> >> - arm64:numa: adding numa support for arm64 platforms. >> http://www.spinics.net/

[Qemu-devel] [PATCH for-2.3 v2 6/6] vmdk: Set errp on failures in vmdk_open_vmdk4

2014-12-02 Thread Fam Zheng
Reported-by: Markus Armbruster Signed-off-by: Fam Zheng Reviewed-by: Markus Armbruster --- block/vmdk.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/vmdk.c b/block/vmdk.c index cde1870..6df0472 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -642,6 +642,7 @@ static int vmdk_open

[Qemu-devel] [PATCH for-2.3 v2 5/6] vmdk: Remove unnecessary initialization

2014-12-02 Thread Fam Zheng
It will be assigned to the return value of vmdk_read_desc. Suggested-by: Markus Armbruster Signed-off-by: Fam Zheng Reviewed-by: Markus Armbruster --- block/vmdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/vmdk.c b/block/vmdk.c index b051adc..cde1870 100644 ---

[Qemu-devel] [PATCH for-2.3 v2 4/6] vmdk: Check descriptor file length when reading it

2014-12-02 Thread Fam Zheng
Since a too small file cannot be a valid VMDK image, and also since the buffer's first 4 bytes will be unconditionally examined by vmdk_open_sparse, let's error out the small file case to be clear. Signed-off-by: Fam Zheng Reviewed-by: Markus Armbruster --- block/vmdk.c | 5 + 1 file change

[Qemu-devel] [PATCH for-2.3 v2 2/6] vmdk: Fix comment to match code of extent lines

2014-12-02 Thread Fam Zheng
commit 04d542c8b (vmdk: support vmfs files) added support of VMFS extent type but the comment above the changed code is left out. Update the comment so they are consistent. Signed-off-by: Fam Zheng Reviewed-by: Markus Armbruster --- block/vmdk.c | 5 +++-- 1 file changed, 3 insertions(+), 2 del

[Qemu-devel] [PATCH for-2.3 v2 1/6] vmdk: Use g_random_int to generate CID

2014-12-02 Thread Fam Zheng
This replaces two "time(NULL)" invocations with "g_random_int()". According to VMDK spec, CID "is a random 32‐bit value updated the first time the content of the virtual disk is modified after the virtual disk is opened". Using "seconds since epoch" is just a "lame way" to generate it, and not comp

[Qemu-devel] [PATCH for-2.3 v2 0/6] vmdk: A few small fixes

2014-12-02 Thread Fam Zheng
v2: 3/6: Don't overwrite the last byte of buffer. (Don) Other patches are unchanged (added Markus' rev-by line). Here are some improvements on miscellaneous things such as CID generation, comments, input validation. Fam Zheng (6): vmdk: Use g_random_int to generate CID vmdk: Fix comment

[Qemu-devel] [PATCH for-2.3 v2 3/6] vmdk: Clean up descriptor file reading

2014-12-02 Thread Fam Zheng
Zeroing a buffer that will be filled right after is not necessary, and allocating a power of two + 1 is naughty. Suggested-by: Markus Armbruster Signed-off-by: Fam Zheng --- block/vmdk.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 2

[Qemu-devel] [PATCH v2] target-i386: Intel xsaves

2014-12-02 Thread Wanpeng Li
Add xsaves related definition, it also adds corresponding part to kvm_get/put, and vmstate. Signed-off-by: Wanpeng Li --- v1 -> v2: * use a subsection instead of bumping the version number. target-i386/cpu.h | 2 ++ target-i386/kvm.c | 15 +++ target-i386/machine.c | 21 +

[Qemu-devel] [PATCH] qemu-iotests: Skip 099 for VMDK subformats with desc file

2014-12-02 Thread Fam Zheng
VMDK extent parsing code doesn't handle the JSON file name, so the case fails for these subformats. Disabled them. Signed-off-by: Fam Zheng --- tests/qemu-iotests/099 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/099 b/tests/qemu-iotests/099 index ffc7e

Re: [Qemu-devel] [PATCH for-2.3 3/6] vmdk: Clean up descriptor file reading

2014-12-02 Thread Fam Zheng
On Tue, 12/02 12:10, Don Koch wrote: > On Tue, 2 Dec 2014 15:39:14 +0800 > Fam Zheng wrote: > > > Zeroing a buffer that will be filled right after is not necessary, and > > allocating a power of two + 1 is naughty. > > > > Suggested-by: Markus Armbruster > > Signed-off-by: Fam Zheng > > --- >

[Qemu-devel] [PATCH] target-mips: Fix DisasContext's ulri member initialization

2014-12-02 Thread Maciej W. Rozycki
Set DisasContext's ulri member to 0 or 1 as with other bool members. Signed-off-by: Maciej W. Rozycki --- qemu-mips-disas-ulri.diff Index: qemu-git-trunk/target-mips/translate.c === --- qemu-git-trunk.orig/target-mips/translate.c 201

[Qemu-devel] [PATCH] linux-user: translate resource also for prlimit64

2014-12-02 Thread Felix Janda
The resource argument is translated from host to target for [gs]etprlimit but not for prlimit64. Fix this. Signed-off-by: Felix Janda --- linux-user/syscall.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index aaac6a2..5658b66

Re: [Qemu-devel] [Xen-devel] [PATCH] increase maxmem before calling xc_domain_populate_physmap

2014-12-02 Thread Don Slutz
On 12/02/14 07:26, Stefano Stabellini wrote: On Mon, 1 Dec 2014, Don Slutz wrote: On 12/01/14 10:37, Stefano Stabellini wrote: On Mon, 1 Dec 2014, Don Slutz wrote: On 11/27/14 05:48, Stefano Stabellini wrote: [...] Works fine in both claim modes and with PoD used (maxmem > memory). Do not

Re: [Qemu-devel] [PATCH] nvme: 64kB page size fixes

2014-12-02 Thread Paolo Bonzini
On 27/11/2014 04:39, Anton Blanchard wrote: > Initialise our maximum page size capability to 64kB and increase > the page_size variable from 16 to 32 bits. > > Signed-off-by: Anton Blanchard > -- > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > index 1327658..aa1ed98 100644 > --- a/hw/bloc

[Qemu-devel] KVM call for agenda for 2014-12-08

2014-12-02 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. hanks, Juan. By popular demand, a google calendar public entry with it https://www.google.com/calendar/embed?src=dG9iMXRqcXAzN3Y4ZXZwNzRoMHE4a3BqcXNAZ3JvdXAuY2FsZW5kYXIuZ29vZ2xlLmNvbQ (Let me know if you have any problems with

Re: [Qemu-devel] [PATCH] pseries: Update SLOF firmware image to 20141202

2014-12-02 Thread Cole Robinson
On 12/02/2014 02:21 PM, Cole Robinson wrote: On 12/01/2014 11:32 PM, Alexey Kardashevskiy wrote: The changelog is: > version: update to 20141202 > ipv4: Fix send packet across a subnet > pci: scan only type 0 and type 1 > usb-xhci: support xhci extended capabilities &

Re: [Qemu-devel] [PATCH] pseries: Update SLOF firmware image to 20141202

2014-12-02 Thread Cole Robinson
On 12/01/2014 11:32 PM, Alexey Kardashevskiy wrote: The changelog is: > version: update to 20141202 > ipv4: Fix send packet across a subnet > pci: scan only type 0 and type 1 > usb-xhci: support xhci extended capabilities > Fix term-io-key to also work when stdin h

Re: [Qemu-devel] [PATCH 1/3] qmp: Add command 'blockdev-backup'

2014-12-02 Thread Markus Armbruster
Fam Zheng writes: > On Tue, 11/04 07:47, Markus Armbruster wrote: >> Fam Zheng writes: >> >> > On Mon, 11/03 15:32, Kevin Wolf wrote: >> >> Am 03.11.2014 um 02:46 hat Fam Zheng geschrieben: >> >> > On Fri, 10/31 10:01, Kevin Wolf wrote: >> >> > > Am 11.09.2014 um 07:05 hat Fam Zheng geschrieben

[Qemu-devel] Review of monitor commands identifying BDS / BB by name

2014-12-02 Thread Markus Armbruster
= Introduction = The block layer and its monitor commands have evolved, resulting in a bit of a mess when it comes to referring to block layer objects in commands. Semantically, we refer to two different kinds of objects: backends and nodes within backends. Example: eject parameter @device names

Re: [Qemu-devel] [PATCH RFC v5 07/19] virtio: allow virtio-1 queue layout

2014-12-02 Thread Michael S. Tsirkin
On Tue, Dec 02, 2014 at 04:41:36PM +0100, Cornelia Huck wrote: > void virtio_queue_set_num(VirtIODevice *vdev, int n, int num) > { > +/* > + * For virtio-1 devices, the number of buffers may only be > + * updated if the ring addresses have not yet been set up. Where does it say that?

Re: [Qemu-devel] [PATCH] i6300esb: fix reading config registers and accept writes of all length

2014-12-02 Thread Richard W.M. Jones
On Tue, Dec 02, 2014 at 07:25:51PM +0100, Adam Hoka wrote: > On 11/30/2014 11:31 PM, Richard W.M. Jones wrote: > >http://git.annexia.org/?p=watchdog-test-framework.git;a=summary > > > >Rich. > > Thanks for the feedback. I guess I could test it on Linux. Should I > just run this utility? The idea

[Qemu-devel] [PATCH 2/2] hw/intc/arm_gic: Initialize the vgic on machine init done

2014-12-02 Thread Eric Auger
With current implementation the vgic is instantiated very late, when the VM is started, on the first VCPU run execution. This patch forces its initialization in a machine init done notifier. This latter is registered in the vgic realize function. The notifier uses a new group/attribute that allows

Re: [Qemu-devel] MinGW build

2014-12-02 Thread Liviu Ionescu
On 01 Dec 2014, at 20:42, Stefan Weil wrote: > Here are some more hints which might help people to get cross > compilation for Windows running. http://qemu.weilnetz.de/debian/ > includes some packages which I made from the GTK all-in-one bundles and > also packages for libfdt which I compiled fr

[Qemu-devel] [PATCH 0/2] arm_gic: Initialize VGIC on machine init done

2014-12-02 Thread Eric Auger
With current implementation the vgic is initialized very late, when the VM is started, on the first VCPU run execution. This series kicks the initialization off on machine init done instead. Among other things, this earlier VGIC initialization allows to have a simpler handling of VFIO. VFIO platfo

[Qemu-devel] [PATCH 1/2] linux-headers: Update KVM headers from linux-next tag ToBeFilled

2014-12-02 Thread Eric Auger
Syncup KVM related linux headers from linux-next tree using scripts/update-linux-headers.sh. Add a new group/attribute in VGIC KVM device enabling to force vgic init: KVM_DEV_ARM_VGIC_GRP_CTRL/KVM_DEV_ARM_VGIC_CTRL_INIT Signed-off-by: Eric Auger --- linux-headers/asm-arm/kvm.h | 2 ++ linux-h

Re: [Qemu-devel] [PATCH] i6300esb: fix reading config registers and accept writes of all length

2014-12-02 Thread Adam Hoka
Hi, On 11/30/2014 11:31 PM, Richard W.M. Jones wrote: On Wed, Oct 29, 2014 at 02:42:51PM +0100, Adam Hoka wrote: Don't require configuration register write to be off a certain length, as some PCI implementations always access them in 32bit only. This is because it's in fact the only kind of acc

Re: [Qemu-devel] [PATCH 0/3] blockdev: Add read-only option to change-blockdev

2014-12-02 Thread Markus Armbruster
Max Reitz writes: > On 2014-11-28 at 16:43, Markus Armbruster wrote: >> Kevin Wolf writes: >> >>> Am 20.11.2014 um 13:44 hat Max Reitz geschrieben: The 'change' QMP and HMP command allows replacing the medium in drives which support this, e.g. floppy disk drives. For some drives, the m

Re: [Qemu-devel] [PATCH v4 0/3] chardev: Add -qmp-pretty

2014-12-02 Thread Markus Armbruster
Max Reitz writes: > On 2014-11-28 at 16:55, Markus Armbruster wrote: >> Copying Luiz. >> >> Max Reitz writes: >> >>> This series does not add new functionality. Adding a QMP monitor with >>> prettily formatted JSON output can be done as follows: >>> >>> $ qemu -chardev stdio,id=mon0 -mon chardev

[Qemu-devel] [PATCH] target-mips: Use local float status pointer across MSA macros

2014-12-02 Thread Maciej W. Rozycki
Reduce line wrapping throughout MSA helper macros by using a local float status pointer rather than referring to the float status through the environment each time. No functional change. Signed-off-by: Maciej W. Rozycki --- Hi, The same float status applies across a single MSA operation (i.e

[Qemu-devel] [PATCH v3 12/13] qcow2: Respect bdrv_truncate() error

2014-12-02 Thread Max Reitz
bdrv_truncate() may fail and qcow2_write_compressed() should return the error code in that case. Cc: qemu-sta...@nongnu.org Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf --- block/qcow2.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c inde

[Qemu-devel] [PATCH v3 10/13] qcow2: Prevent numerical overflow

2014-12-02 Thread Max Reitz
In qcow2_alloc_cluster_offset(), *num is limited to INT_MAX >> BDRV_SECTOR_BITS by all callers. However, since remaining is of type uint64_t, we might as well cast *num to that type before performing the shift. Cc: qemu-sta...@nongnu.org Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf --- bloc

[Qemu-devel] [PATCH v3 13/13] block/raw-posix: Fix ret in raw_open_common()

2014-12-02 Thread Max Reitz
The return value must be negative on error; there is one place in raw_open_common() where errp is set, but ret remains 0. Fix it. Cc: qemu-sta...@nongnu.org Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf --- block/raw-posix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/raw-posix

[Qemu-devel] [PATCH v3 05/13] block: Check create_opts before image creation

2014-12-02 Thread Max Reitz
If a driver supports image creation, it needs to set the .create_opts field. We can use that to make sure .create_opts for both drivers involved is not NULL in bdrv_img_create(), which is important so that the create_opts pointer in that function is not NULL after the qemu_opts_append() calls and w

[Qemu-devel] [PATCH v3 04/13] block/nfs: Add create_opts

2014-12-02 Thread Max Reitz
The nfs protocol driver is capable of creating images, but did not specify any creation options. Fix it. A way to test this issue is the following: $ qemu-img create -f nfs nfs://127.0.0.1/foo.qcow2 64M Without this patch, it segfaults. With this patch, it does not. However, this is not somethin

[Qemu-devel] [PATCH v3 08/13] iotests: Only kill NBD server if it runs

2014-12-02 Thread Max Reitz
There may be NBD tests which do not create a sample image and simply test whether wrong usage of the protocol is rejected as expected. In this case, there will be no NBD server and trying to kill it during clean-up will fail. Cc: qemu-sta...@nongnu.org Signed-off-by: Max Reitz Reviewed-by: Kevin

[Qemu-devel] [PATCH v3 07/13] qemu-img: Check create_opts before image amendment

2014-12-02 Thread Max Reitz
The image options which can be amended are described by the .create_opts field for every driver. This field must therefore be non-NULL so that anything can be amended in the first place. Check that this holds true before going into qemu_opts_create() (because if .create_opts is NULL, the create_opt

[Qemu-devel] [PATCH v3 06/13] qemu-img: Check create_opts before image creation

2014-12-02 Thread Max Reitz
If a driver supports image creation, it needs to set the .create_opts field. We can use that to make sure .create_opts for both drivers involved is not NULL for the target image in qemu-img convert, which is important so that the create_opts pointer in img_convert() is not NULL after the qemu_opts_

[Qemu-devel] [PATCH v3 03/13] block/vvfat: qcow driver may not be found

2014-12-02 Thread Max Reitz
Although virtually impossible right now, bdrv_find_format("qcow") may fail. The vvfat block driver should heed that case. Cc: qemu-sta...@nongnu.org Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf --- block/vvfat.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/block/vvfat.c b/block

[Qemu-devel] [PATCH v3 09/13] iotests: Add test for unsupported image creation

2014-12-02 Thread Max Reitz
Add a test for creating and amending images (amendment uses the creation options) with formats not supporting creation over protocols not supporting creation. Cc: qemu-sta...@nongnu.org Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf --- tests/qemu-iotests/113 | 76

[Qemu-devel] [PATCH v3 11/13] qcow2: Flushing the caches in qcow2_close may fail

2014-12-02 Thread Max Reitz
qcow2_cache_flush() may fail; if one of the caches failed to be flushed successfully to disk in qcow2_close() the image should not be marked clean, and we should emit a warning. This breaks the (qcow2-specific) iotests 026, 071 and 089; change their output accordingly. Cc: qemu-sta...@nongnu.org

[Qemu-devel] [PATCH v3 00/13] block: Various Coverity-spotted fixes

2014-12-02 Thread Max Reitz
This series fixes various issues spotted by Coverity. None of these is critical; most are just "If you do something crazy, qemu-img crashes" or "But what if there is no qcow2 driver?". Also, none is security-relevant. The only crashes which are fixed here are sure to have resulted from dereferenci

[Qemu-devel] [PATCH v3 02/13] block: Omit bdrv_find_format for essential drivers

2014-12-02 Thread Max Reitz
We can always assume raw, file and qcow2 being available; so do not use bdrv_find_format() to locate their BlockDriver objects but statically reference the respective objects. Cc: qemu-sta...@nongnu.org Signed-off-by: Max Reitz --- block.c | 17 + block/qcow2.c | 7 +++

[Qemu-devel] [PATCH v3 01/13] block: Make essential BlockDriver objects public

2014-12-02 Thread Max Reitz
There are some block drivers which are essential to QEMU and may not be removed: These are raw, file and qcow2 (as the default non-raw format). Make their BlockDriver objects public so they can be directly referenced throughout the block layer without needing to call bdrv_find_format() and having t

Re: [Qemu-devel] [PATCH] target-mips: Add missing calls to synchronise SoftFloat status

2014-12-02 Thread Maciej W. Rozycki
On Tue, 2 Dec 2014, Peter Maydell wrote: > Is there ever a situation where you would want to > resynchronise only one of these two things? If not, > why not just have one function for synchronising > softfloat state from the FCR? Good point, I think these are safe and cheap enough to be always c

Re: [Qemu-devel] [PATCH] target-mips: Add missing calls to synchronise SoftFloat status

2014-12-02 Thread Peter Maydell
On 2 December 2014 at 17:02, Maciej W. Rozycki wrote: > Add missing calls to synchronise the SoftFloat status with the CP1.FSCR: > > + for the rounding and flush-to-zero modes upon processor reset, > > + for the flush-to-zero mode on FSCR updates through the GDB stub. > > Refactor code accordingly

Re: [Qemu-devel] [PATCH for-2.3 3/6] vmdk: Clean up descriptor file reading

2014-12-02 Thread Don Koch
On Tue, 2 Dec 2014 15:39:14 +0800 Fam Zheng wrote: > Zeroing a buffer that will be filled right after is not necessary, and > allocating a power of two + 1 is naughty. > > Suggested-by: Markus Armbruster > Signed-off-by: Fam Zheng > --- > block/vmdk.c | 5 +++-- > 1 file changed, 3 insertions

Re: [Qemu-devel] Vhost-user - multi queue support

2014-12-02 Thread Long, Thomas
-Original Message- From: Olivier MATZ [mailto:olivier.m...@6wind.com] Sent: Tuesday, December 2, 2014 4:41 PM To: Michael S. Tsirkin; Long, Thomas Cc: Ryan, Brendan; qemu-devel@nongnu.org; n.nikol...@virtualopensystems.com Subject: Re: [Qemu-devel] Vhost-user - multi queue support Hi Al

[Qemu-devel] [PATCH] target-mips: Add missing calls to synchronise SoftFloat status

2014-12-02 Thread Maciej W. Rozycki
Add missing calls to synchronise the SoftFloat status with the CP1.FSCR: + for the rounding and flush-to-zero modes upon processor reset, + for the flush-to-zero mode on FSCR updates through the GDB stub. Refactor code accordingly and remove the redundant RESTORE_ROUNDING_MODE macro. Signed-of

Re: [Qemu-devel] get a handle for the tap device to shut it down

2014-12-02 Thread Olaf Hering
On Fri, Nov 28, Olaf Hering wrote: > I wonder if the missing disable of the tap device is intentional, or > just an oversight, or if its just to complicated to get from a > "PCIDevice *" to the other end and call the ->cleanup function. qemu-traditional did just close all tap devices. With qemu-u

Re: [Qemu-devel] [RFC PATCH] hw/arm/virt: Add support for NUMA on ARM64

2014-12-02 Thread Peter Maydell
On 2 December 2014 at 12:56, Shannon Zhao wrote: > Add support for NUMA on ARM64. Tested successfully running a guest > Linux kernel with the following patch applied: > > - arm64:numa: adding numa support for arm64 platforms. > http://www.spinics.net/lists/arm-kernel/msg365316.html > > Example qem

[Qemu-devel] [PATCH] tests: Fix bios-tables-test -Werror compilation error

2014-12-02 Thread Maciej W. Rozycki
Fix: .../tests/bios-tables-test.c: In function 'main': .../tests/bios-tables-test.c:796:11: error: ignoring return value of 'fwrite', declared with attribute warn_unused_result [-Werror=unused-result] cc1: all warnings being treated as errors make: *** [tests/bios-tables-test.o] Error 1 happenin

Re: [Qemu-devel] Vhost-user - multi queue support

2014-12-02 Thread Olivier MATZ
Hi All, On 12/02/2014 01:24 PM, Michael S. Tsirkin wrote: On Tue, Dec 02, 2014 at 11:42:22AM +, Long, Thomas wrote: Hi All, I’m just wondering what the status is with regards to supporting multi-queue in Vhost-user? I see that Nikolaev has developed a patch to support this feature: https

Re: [Qemu-devel] [PATCH v2 01/13] block: Make essential BlockDriver objects public

2014-12-02 Thread Eric Blake
On 12/02/2014 02:11 AM, Max Reitz wrote: >>> -static BlockDriver bdrv_qcow2 = { >>> +BlockDriver *bdrv_qcow2 = &(BlockDriver){ >> Do we want any use of 'const', to avoid accidental manipulation of the >> pointer and/or pointed-to contents? > > Sounds good at first, but for instance qemu_opts_cr

Re: [Qemu-devel] AMD video card passthrough reset issues

2014-12-02 Thread Lucio Andrés Illanes Albornoz
On Tue, 02 Dec 2014 08:26:20 -0700 Alex Williamson wrote: > All of the Bonaire-based AMD GPUs seems to have issues with reset > (R7790, R7 260/X). I've tried to engage AMD on this, but haven't gotten > any response on this topic yet. For devices like this that don't > support any kind of functi

Re: [Qemu-devel] [PATCH] target-arm: ARM64: Adding EL1 AARCH32 guest support for KVM.

2014-12-02 Thread Peter Maydell
On 28 November 2014 at 13:06, Pranavkumar Sawargaonkar wrote: > In KVM ARM64 one can choose to run guest in 32bit mode i.e EL1 in AARCH32 > mode. > This patch adds qemu support for running guest EL1 in AARCH32 mode with > virt as a machine model. Thanks for sending this patch. > This patch also

[Qemu-devel] checkpatch hang (was: [PATCH] target-mips/op_helper.c: Restore the order of helpers)

2014-12-02 Thread Maciej W. Rozycki
Hi Blue Swirl, On Wed, 5 Nov 2014, Maciej W. Rozycki wrote: > Restore the order of helpers that used to be: unary operations (generic, > then MIPS-specific), binary operations (generic, then MIPS-specific), > compare operations. At one point FMA operations were inserted at a > random place in

Re: [Qemu-devel] [PATCH RFC v5 07/19] virtio: allow virtio-1 queue layout

2014-12-02 Thread Cornelia Huck
On Tue, 2 Dec 2014 15:54:44 +0100 Cornelia Huck wrote: > On Tue, 2 Dec 2014 16:46:28 +0200 > "Michael S. Tsirkin" wrote: > > pa == -1ULL tricks look quite ugly. > > Can't we set desc/avail/used unconditionally, and drop > > the pa value? > > And have virtio_queue_get_addr() return desc? Let me

Re: [Qemu-devel] AMD video card passthrough reset issues

2014-12-02 Thread Alex Williamson
On Tue, 2014-12-02 at 13:53 +0100, Lucio Andrés Illanes Albornoz wrote: > Hello, > > I'm doing secondary VGA passthrough with an AMD Radeon R7 260X using > QEMU v2.1.2 w/ KVM and VFIO on Debian v7.7 (wheezy) (qemu v2.1 > +dfsg-5~bpo70+1 from wheezy-backports) and kernel version 3.16.5 (from

Re: [Qemu-devel] [PATCH] nvme: 64kB page size fixes

2014-12-02 Thread Kevin Wolf
Am 02.12.2014 um 16:04 hat Stefan Hajnoczi geschrieben: > On Thu, Nov 27, 2014 at 02:39:21PM +1100, Anton Blanchard wrote: > > Initialise our maximum page size capability to 64kB and increase > > the page_size variable from 16 to 32 bits. > > > > Signed-off-by: Anton Blanchard > > -- > > Covered

Re: [Qemu-devel] Update on TCG Multithreading

2014-12-02 Thread Kirill Batuzov
On Mon, 1 Dec 2014, Mark Burton wrote: > > One issue I’d like to see more opinions on is the question of a cache per > core, or a shared cache. > I have heard anecdotal evidence that a shared cache gives a major performance > benefit…. > Does anybody have anything more concrete? There is a theo

[Qemu-devel] [PATCH] target-i386: Intel xsaves

2014-12-02 Thread Wanpeng Li
Add xsaves related definition, it also add corresponding part to kvm_get/put, and vmstate. Signed-off-by: Wanpeng Li --- target-i386/cpu.h | 2 ++ target-i386/kvm.c | 15 +++ target-i386/machine.c | 3 ++- 3 files changed, 19 insertions(+), 1 deletion(-) diff --git a/targ

[Qemu-devel] Vhost-user - multi queue support

2014-12-02 Thread Long, Thomas
Hi All, I'm just wondering what the status is with regards to supporting multi-queue in Vhost-user? I see that Nikolaev has developed a patch to support this feature: https://github.com/SnabbCo/qemu/commit/f41eeccf4ab6ea5970e2941ce2de0aae893b10f9 Are there any current plans to pull either this p

Re: [Qemu-devel] [PATCHv3] block: add event when disk usage exceeds threshold

2014-12-02 Thread Francesco Romani
- Original Message - > From: "Stefan Hajnoczi" > To: "Francesco Romani" > Cc: kw...@redhat.com, mdr...@linux.vnet.ibm.com, qemu-devel@nongnu.org, > lcapitul...@redhat.com > Sent: Tuesday, December 2, 2014 4:01:17 PM > Subject: Re: [Qemu-devel] [PATCHv3] block: add event when disk usage

Re: [Qemu-devel] [Bug 1396052] [NEW] migration failed when running BurnInTest in guest

2014-12-02 Thread Stefan Hajnoczi
On Thu, Nov 27, 2014 at 02:50:59PM +0530, Amit Shah wrote: > On (Tue) 25 Nov 2014 [09:32:58], z08687 wrote: > > Public bug reported: > > > > Hi, > > I found a live migration problem and have found out the reason, but I can't > > fix it up myself. I really need help. > > When live migration vm a

Re: [Qemu-devel] [PATCH] nvme: 64kB page size fixes

2014-12-02 Thread Stefan Hajnoczi
On Thu, Nov 27, 2014 at 02:39:21PM +1100, Anton Blanchard wrote: > Initialise our maximum page size capability to 64kB and increase > the page_size variable from 16 to 32 bits. > > Signed-off-by: Anton Blanchard > -- Covered in NVM Express 1.1 specification "3.1.1 Offset 00h: CAP - Controller Ca

Re: [Qemu-devel] [PATCHv3] block: add event when disk usage exceeds threshold

2014-12-02 Thread Stefan Hajnoczi
On Fri, Nov 28, 2014 at 01:31:07PM +0100, Francesco Romani wrote: > @@ -82,6 +83,8 @@ BlockDeviceInfo *bdrv_block_device_info(BlockDriverState > *bs) > info->iops_size = cfg.op_size; > } > > +info->write_threshold = bdrv_usage_threshold_get(bs); Overall looks good but I notice

Re: [Qemu-devel] [PATCH RFC v5 07/19] virtio: allow virtio-1 queue layout

2014-12-02 Thread Cornelia Huck
On Tue, 2 Dec 2014 16:46:28 +0200 "Michael S. Tsirkin" wrote: > On Tue, Dec 02, 2014 at 02:00:15PM +0100, Cornelia Huck wrote: > > For virtio-1 devices, we allow a more complex queue layout that doesn't > > require descriptor table and rings on a physically-contigous memory area: > > add virtio_q

Re: [Qemu-devel] [PATCH RFC v5 07/19] virtio: allow virtio-1 queue layout

2014-12-02 Thread Michael S. Tsirkin
On Tue, Dec 02, 2014 at 02:00:15PM +0100, Cornelia Huck wrote: > For virtio-1 devices, we allow a more complex queue layout that doesn't > require descriptor table and rings on a physically-contigous memory area: > add virtio_queue_set_rings() to allow transports to set this up. > > Signed-off-by:

[Qemu-devel] [RFC PATCH 2/3] hw/virtio-blk: add a constant for max number of merged requests

2014-12-02 Thread Peter Lieven
As it was not obvious (at least for me) where the 32 comes from; add a constant for it. Signed-off-by: Peter Lieven --- hw/block/virtio-blk.c |2 +- include/hw/virtio/virtio-blk.h |4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/block/virtio-blk.c b/hw/

[Qemu-devel] [RFC PATCH 3/3] virtio-blk: introduce multiread

2014-12-02 Thread Peter Lieven
this patch finally introduce multiread support to virtio-blk while multiwrite support was there for a long time read support was missing. To achieve this the patch does serveral things which might need futher explaination: - the whole merge and multireq logic is moved from block.c into virtio

[Qemu-devel] [RFC PATCH 0/3] virtio-blk: add multiread support

2014-12-02 Thread Peter Lieven
this series adds the long missing multiread support to virtio-blk. some remarks: - i introduced rd_merged and wr_merged block accounting stats to blockstats as a generic interface which can be set from any driver that will introduce multirequst merging in the future. - the knob to disable

[Qemu-devel] [RFC PATCH 1/3] block: add accounting for merged requests

2014-12-02 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block.c|2 ++ block/accounting.c |7 +++ block/qapi.c |2 ++ hmp.c |6 +- include/block/accounting.h |3 +++ qapi/block-core.json | 10 +- 6 files changed, 28

Re: [Qemu-devel] [PATCH v3] qtest/bios-tables: Add DMAR aml file and enable intel_iommu for q35

2014-12-02 Thread Marcel Apfelbaum
On Tue, 2014-12-02 at 13:26 +0100, Vasilis Liaskovitis wrote: > We generate the expected DMAR table and enable intel_iommu on q35 to test the > table. > > Signed-off-by: Vasilis Liaskovitis > --- > tests/acpi-test-data/q35/DMAR | Bin 0 -> 64 bytes > tests/bios-tables-test.c | 2 +- > 2 f

Re: [Qemu-devel] QEMU Advent Calendar has begun - Day 1

2014-12-02 Thread Kashyap Chamarthy
On Mon, Dec 01, 2014 at 04:51:58PM +, Stefan Hajnoczi wrote: > Today is the first day of QEMU Advent Calendar 2014, where an > interesting and fun QEMU disk image is published every day. > > http://www.qemu-advent-calendar.org/ > > I won't spam the mailing list every day but I wanted to let y

Re: [Qemu-devel] [PATCH v2 5/7] coroutine: rewrite pool to avoid mutex

2014-12-02 Thread Kevin Wolf
Am 02.12.2014 um 13:13 hat Paolo Bonzini geschrieben: > > > On 02/12/2014 13:09, Peter Lieven wrote: > >> > >> -static void __attribute__((destructor)) coroutine_pool_cleanup(void) > >> -{ > >> -Coroutine *co; > >> -Coroutine *tmp; > >> - > >> -QSLIST_FOREACH_SAFE(co, &pool, pool_next

[Qemu-devel] [PATCH RFC v5 15/19] virtio-net: no writeable mac for virtio-1

2014-12-02 Thread Cornelia Huck
Devices operating as virtio 1.0 may not allow writes to the mac address in config space. Signed-off-by: Cornelia Huck --- hw/net/virtio-net.c |1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index d6d1b98..ebbea60 100644 --- a/hw/net/virtio-net.c +

[Qemu-devel] [PATCH RFC v5 13/19] virtio: allow to fail setting status

2014-12-02 Thread Cornelia Huck
virtio-1 allow setting of the FEATURES_OK status bit to fail if the negotiated feature bits are inconsistent: let's fail virtio_set_status() in that case and update virtio-ccw to post an error to the guest. Signed-off-by: Cornelia Huck --- hw/s390x/virtio-ccw.c | 20

[Qemu-devel] [PATCH RFC v5 19/19] virtio-blk: revision specific feature bits

2014-12-02 Thread Cornelia Huck
Wire up virtio-blk to provide different feature bit sets depending on whether legacy or v1.0 has been requested. Note that VERSION_1 is still disabled due to missing ANY_LAYOUT support. Signed-off-by: Cornelia Huck --- hw/block/virtio-blk.c | 19 +++ 1 file changed, 19 inserti

[Qemu-devel] [PATCH RFC v5 18/19] virtio: support revision-specific features

2014-12-02 Thread Cornelia Huck
Devices may support different sets of feature bits depending on which revision they're operating at. Let's give the transport a way to re-query the device about its features when the revision has been changed. Signed-off-by: Cornelia Huck --- hw/s390x/virtio-ccw.c | 12 ++-- h

[Qemu-devel] [PATCH RFC v5 10/19] s390x/virtio-ccw: add virtio set-revision call

2014-12-02 Thread Cornelia Huck
From: Thomas Huth Handle the virtio-ccw revision according to what the guest sets. When revision 1 is selected, we have a virtio-1 standard device with byteswapping for the virtio rings. When a channel gets disabled, we have to revert to the legacy behavior in case the next user of the device do

[Qemu-devel] [PATCH RFC v5 17/19] virtio-net: enable virtio 1.0

2014-12-02 Thread Cornelia Huck
virtio-net (non-vhost) now should have everything in place to support virtio 1.0: let's enable the feature bit for it. Note that VIRTIO_F_VERSION_1 is technically a transport feature; once every device is ready for virtio 1.0, we can move setting this feature bit out of the individual devices. Si

[Qemu-devel] [PATCH RFC v5 16/19] virtio-net: support longer header

2014-12-02 Thread Cornelia Huck
virtio-1 devices always use num_buffers in the header, even if mergeable rx buffers have not been negotiated. Signed-off-by: Cornelia Huck --- hw/net/virtio-net.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.

[Qemu-devel] [PATCH RFC v5 14/19] s390x/virtio-ccw: enable virtio 1.0

2014-12-02 Thread Cornelia Huck
virtio-ccw should now have everything in place to operate virtio 1.0 devices, so let's enable revision 1. Signed-off-by: Cornelia Huck --- hw/s390x/virtio-ccw.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/s390x/virtio-ccw.h b/hw/s390x/virtio-ccw.h index fe5c782..d40

[Qemu-devel] [PATCH RFC v5 11/19] s390x/virtio-ccw: support virtio-1 set_vq format

2014-12-02 Thread Cornelia Huck
Support the new CCW_CMD_SET_VQ format for virtio-1 devices. While we're at it, refactor the code a bit and enforce big endian fields (which had always been required, even for legacy). Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck --- hw/s390x/virtio-ccw.c | 114 +++

[Qemu-devel] [PATCH RFC v5 09/19] s390x/css: Add a callback for when subchannel gets disabled

2014-12-02 Thread Cornelia Huck
From: Thomas Huth We need a possibility to run code when a subchannel gets disabled. This patch adds the necessary infrastructure. Signed-off-by: Thomas Huth Signed-off-by: Cornelia Huck --- hw/s390x/css.c | 12 hw/s390x/css.h |1 + 2 files changed, 13 insertions(+) diff -

  1   2   >