Am 02.12.2014 um 13:13 hat Paolo Bonzini geschrieben:
>
>
> On 02/12/2014 13:09, Peter Lieven wrote:
> >>
> >> -static void __attribute__((destructor)) coroutine_pool_cleanup(void)
> >> -{
> >> - Coroutine *co;
> >> - Coroutine *tmp;
> >> -
> >> - QSLIST_FOREACH_SAFE(co, &pool, pool_next, tmp) {
> >> - QSLIST_REMOVE_HEAD(&pool, pool_next);
> >> - qemu_coroutine_delete(co);
> >> - }
> >> -
> >> - qemu_mutex_destroy(&pool_lock);
> >> -}
> >> -
> >
> > I still feel we should leave this destructor in to clean up the
> > release_pool.
>
> Why? If you run QEMU under valgrind, there are thousands of blocks that
> we do not free. Stefan/Kevin, what do you think?
The destructor doesn't seem to be doing anything but freeing memory,
which the OS can indeed do for us. I don't mind either way.
Kevin
