Public bug reported:
The networking code in qemu in versions 2.0.0 and beyond is non-
functional with Solaris/Illumos 5.11 images.
Building 1.7.1, 2.0.0, 2.0.2, 2.1.2,and 2.2.0rc1with the following
standard Slackware config:
# From Slackware build tree . . .
./configure \
--prefix=/usr \
--
Note that the host system, network config, etc. are identical, qemu is
built with an identical config, and started with the same command - the
*ONLY* variable is the qemu version. This is utilizing the bridge-
helper binary, but as noted earlier, using virt-manager whether allowing
it to define i
** Attachment added: "Wireshark pcap format packet dump of 2.1.2 failing to
come up successfully"
https://bugs.launchpad.net/qemu/+bug/1395217/+attachment/4265387/+files/WS_pcap_2.1.2
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEM
Host platform is Slackware 14.1, x86_64 . . . cc 4.8.2, kernel 3.10.17
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1395217
Title:
Networking in qemu 2.0.0 and beyond is not compatible with Open
On 21 November 2014 20:14, Andrea Arcangeli wrote:
> Hi Peter,
>
> On Wed, Oct 29, 2014 at 05:56:59PM +, Peter Maydell wrote:
>> On 29 October 2014 17:46, Andrea Arcangeli wrote:
>> > After some chat during the KVMForum I've been already thinking it
>> > could be beneficial for some usage to
On 11/04/2014 06:03 AM, Max Reitz wrote:
On 2014-10-30 at 04:22, Fam Zheng wrote:
This adds three qmp commands to transactions.
Users can stop a dirty bitmap, start backup of it, and start another
dirty bitmap atomically, so that the dirty bitmap is tracked
incrementally and we don't miss any
I love being ignored, but this appears to have been resolved in later
releases.
Thanks for not so much as even an acknowledgement of this . . .
** Changed in: qemu
Status: New => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subsc
Hello,
We are running a couple of VMs using the qemu command on ubuntu 14.04. It seems
like there is a corruption on the socket. It crashes on its on after a day or
so of light activity.
Is this a known issue?
Please let me know if this is the right place to post this or if you can help.
th
The one failure turns out to be an intermittent failure that has nothing to do
with the patch and probably nothing to do with qemu at all. So I heartily
approve of these patches.
Thanks very much, Paolo, for taking the time to implement these fixes.
From: Richard Bilson mailto:rbil...@qnx.com>>
Hi Serge, just tested your solution but unfortunately with no success. I
also removed a vm and created it again, also with no luck. Sorry ...
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1392504
Tit
Hi Peter,
On Wed, Oct 29, 2014 at 05:56:59PM +, Peter Maydell wrote:
> On 29 October 2014 17:46, Andrea Arcangeli wrote:
> > After some chat during the KVMForum I've been already thinking it
> > could be beneficial for some usage to give userland the information
> > about the fault being read
Hardy has seen the end of its life and is no longer receiving any
updates. Marking the Hardy task for this ticket as "Won't Fix".
** Changed in: madfuload (Ubuntu Hardy)
Status: New => Won't Fix
--
You received this bug notification because you are a member of qemu-
devel-ml, which is sub
Hardy has seen the end of its life and is no longer receiving any
updates. Marking the Hardy task for this ticket as "Won't Fix".
** Changed in: midisport-firmware (Ubuntu Hardy)
Status: New => Won't Fix
--
You received this bug notification because you are a member of qemu-
devel-ml, whi
Hardy has seen the end of its life and is no longer receiving any
updates. Marking the Hardy task for this ticket as "Won't Fix".
** Changed in: fxload (Ubuntu Hardy)
Status: New => Won't Fix
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscr
Hardy has seen the end of its life and is no longer receiving any
updates. Marking the Hardy task for this ticket as "Won't Fix".
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/156085
Title:
Could n
Hardy has seen the end of its life and is no longer receiving any
updates. Marking the Hardy task for this ticket as "Won't Fix".
** Changed in: vmware-server (Ubuntu Hardy)
Status: New => Won't Fix
--
You received this bug notification because you are a member of qemu-
devel-ml, which is
On Fri, Nov 21, 2014 at 11:48:03AM +0800, zhanghailiang wrote:
> Hi David,
>
> When i migrated VM in postcopy way when configuring VM with '-realtime
> mlock=on' option,
> It failed, and reports "postcopy_ram_hosttest: remap_anon_pages not
> available: File exists" in destination,
>
> Is it a b
On Fri, Nov 21 2014 at 4:54am -0500,
Christoph Hellwig wrote:
> On Thu, Nov 20, 2014 at 02:00:59PM -0500, Mike Snitzer wrote:
> > virtio_blk incorrectly established -1U as the default for these
> > queue_limits. Set these limits to sane default values to avoid crashing
> > the kernel. But the
Stefan Hajnoczi writes:
> On Wed, Nov 12, 2014 at 06:48:18PM +, Gary Hook wrote:
>> -return qemu_ftell(f) - last_ftell;
>> +delta_ftell = qemu_ftell(f) - last_ftell;
>> +return( (delta_ftell > 0) ? 1 : (delta_ftell < 0) ? -1 : 0 );
>
> Good find!
>
> Please don't nest the ternary
The Linux SDHCI PCI driver will only register the device if there is a
clock frequency set. So, set a default frequency of 52Mhz.
Signed-off-by: Kevin O'Connor
---
hw/sd/sdhci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
index c4fb27c..
Update the sdhci sysbus QOM types and methods so that sysbus is in
their name. This is in preparation for adding PCI versions of these
types and methods.
Signed-off-by: Kevin O'Connor
---
hw/sd/sdhci.c | 39 ---
hw/sd/sdhci.h | 6 +++---
2 files changed, 27
Support for PCI devices following the "SD Host Controller Simplified
Specification Version 2.00" spec.
Signed-off-by: Kevin O'Connor
---
default-configs/pci.mak | 2 ++
hw/sd/sdhci.c | 44
hw/sd/sdhci.h | 9 -
3 files cha
I'd like to be able to emulate SD cards on x86 machines for testing
purposes. This patch series modifies the existing SDHCI code so that
it can also be used as a PCI device, and can thus be used on any PCI
platform (such as x86).
I have done basic sdhci testing of this series on x86 by adding the
Signed-off-by: Kevin O'Connor
---
docs/specs/pci-ids.txt | 2 ++
include/hw/pci/pci.h | 1 +
include/hw/pci/pci_ids.h | 1 +
3 files changed, 4 insertions(+)
diff --git a/docs/specs/pci-ids.txt b/docs/specs/pci-ids.txt
index 3c65e1a..9b57d5e 100644
--- a/docs/specs/pci-ids.txt
+++ b/docs/s
The SDHCIClass defines a series of class "methods". However, no code
in the QEMU tree overrides these methods or even uses them outside of
sdhci.c.
Remove the virtual methods and replace them with direct calls to the
underlying functions. This simplifies the process of extending the
sdhci code t
On 11/21/2014 10:05 AM, Kevin Wolf wrote:
> This reverts commit 000c4dfff4d7686e2fba3066a477a1290ed60622.
>
> The main reason for reverting this commit before the 2.2 release is that
> it adds a QAPI interface that we don't want to keep: The 'nocow' flag
> doesn't generally make sense for block no
This reverts commit 000c4dfff4d7686e2fba3066a477a1290ed60622.
The main reason for reverting this commit before the 2.2 release is that
it adds a QAPI interface that we don't want to keep: The 'nocow' flag
doesn't generally make sense for block nodes, but only for the raw-posix
driver. It should th
On Fri, Nov 21, 2014 at 01:27:40PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> >There is a constraint if we want to get live migration for free: The
> >bitmap contents must be accessible with bdrv_read() and
> >bdrv_get_block_status() to skip zero regions.
> Hm. I'm afraid, it still will not be fr
On Fri, Nov 21, 2014 at 11:18:52AM -0500, Don Slutz wrote:
> c/s 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4
>
> or
>
> c/s b154537ad07598377ebf98252fb7d2aff127983b
>
> moved the testing of xen_enabled() from pc_init1() to
> pc_machine_initfn().
>
> xen_enabled() does not return the correct value
On 11/21/2014 09:25 AM, Kevin Wolf wrote:
> Am 30.07.2014 um 04:55 hat Chunyan Liu geschrieben:
>> Add nocow info in 'qemu-img info' output to show whether the file
>> currently has NOCOW flag set or not.
>>
>> Signed-off-by: Chunyan Liu
>> Reviewed-by: Eric Blake
>> ---
>> Resend for QEMU 2.2. C
On 11/21/2014 01:43 AM, Francesco Romani wrote:
> A couple of specific questions more, mostly to make sure I can do meaningful
> tests for my next submission:
>
> 1. I'm running a simple test using the attached script -
> which is a qemu command line adapted from libvirt ouput driven
> by oVirt.
Am 30.07.2014 um 04:55 hat Chunyan Liu geschrieben:
> Add nocow info in 'qemu-img info' output to show whether the file
> currently has NOCOW flag set or not.
>
> Signed-off-by: Chunyan Liu
> Reviewed-by: Eric Blake
> ---
> Resend for QEMU 2.2. Change json version comment. Add Reviewed-by.
>
>
On 11/21/14 10:10, Eduardo Habkost wrote:
On Fri, Nov 21, 2014 at 09:56:33AM -0500, Don Slutz wrote:
On 11/21/14 08:53, Eduardo Habkost wrote:
On Fri, Nov 21, 2014 at 08:30:58AM -0500, Don Slutz wrote:
On 11/20/14 21:01, Eduardo Habkost wrote:
On Thu, Nov 20, 2014 at 05:32:56PM -0500, Don Slu
c/s 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4
or
c/s b154537ad07598377ebf98252fb7d2aff127983b
moved the testing of xen_enabled() from pc_init1() to
pc_machine_initfn().
xen_enabled() does not return the correct value in
pc_machine_initfn().
Changed vmport from a bool to an enum. Added the valu
Am 04.11.2014 um 15:19 hat Max Reitz geschrieben:
> Introduce bdrv_get_full_backing_filename_from_filename(), a function
> which takes the name of the backed file and a potentially relative
> backing filename to produce the full (absolute) backing filename.
>
> Use this function from bdrv_get_full
On 11/21/2014 02:29 AM, Max Reitz wrote:
> For the pretty formatting, the functions converting QDicts and QLists to
> JSON should not print a space after the comma separating objects,
> because a newline will emitted immediately afterwards, making the
> whitespace superfluous.
>
> Signed-off-by: M
config.status and tests/qemu-iotests/common.env are generated files
that should be deleted during 'make distclean'.
Signed-off-by: Thomas Huth
---
Makefile |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index f505202..6817c6f 100644
--- a/Makefile
On 11/21/2014 04:31 PM, Bastian Koppelmann wrote:
> Add instructions of RCR opcode format.
> Add helper for madd32/64_ssov and madd32/64_suov.
> Add helper for msub32/64_ssov and msub32/64_suov.
> Add microcode generator function madd/msub for 32bit and 64bit, which
> calculate a mul and a add/sub
- Original Message -
> From: "Kevin Wolf"
> To: "Francesco Romani"
> Cc: qemu-devel@nongnu.org, "Stefan Hajnoczi" ,
> mdr...@linux.vnet.ibm.com, "Luiz Capitulino"
> , "Stefan Hajnoczi"
> Sent: Friday, November 21, 2014 11:11:26 AM
> Subject: Re: [Qemu-devel] [RFC][PATCH v2] block: add w
* Gonglei (arei.gong...@huawei.com) wrote:
> Hi, Gerd
>
> I encounter a problem that breaking migration from qemu-1.5 to qemu-2.1.
> The error message as below:
> qemu-system-x86_64: hw/input/hid.c:121: hid_pointer_event: Assertion `hs->n
> < 16' failed.
> Qemu assert in hid_pointer_event().
W
On Fri, Nov 21, 2014 at 09:56:33AM -0500, Don Slutz wrote:
> On 11/21/14 08:53, Eduardo Habkost wrote:
> >On Fri, Nov 21, 2014 at 08:30:58AM -0500, Don Slutz wrote:
> >>On 11/20/14 21:01, Eduardo Habkost wrote:
> >>>On Thu, Nov 20, 2014 at 05:32:56PM -0500, Don Slutz wrote:
> >>>[...]
> [...]
> >>>
On 21 November 2014 11:12, Stefan Hajnoczi wrote:
> The following changes since commit 9c7074da5ec64e1fd61df881ab291f75541ff2b0:
>
> hw/arm/virt: set stdout-path instead of linux,stdout-path (2014-11-20
> 14:58:37 +)
>
> are available in the git repository at:
>
> git://github.com/stefanh
[Adding qemu-devel@, so folks over there are aware of this.
Original thread at https://sourceware.org/ml/gdb-patches/2014-11/msg00478.html]
On 11/20/2014 04:41 PM, Joel Brobecker wrote:
> A recent change...
>
> commit 1a853c5224e2b8fedfac6d029365522b83080b40
> Date: Wed Nov 12 10:10:49
On 11/21/14 08:53, Eduardo Habkost wrote:
On Fri, Nov 21, 2014 at 08:30:58AM -0500, Don Slutz wrote:
On 11/20/14 21:01, Eduardo Habkost wrote:
On Thu, Nov 20, 2014 at 05:32:56PM -0500, Don Slutz wrote:
[...]
[...]
+pcms->vmport = ON_OFF_AUTO_AUTO;
+object_property_add(obj, PC_MACHINE_
Variable 'ram_lo' is allocated unconditionally, but used only in some cases.
When it is unused pointer will be lost at function exit, resulting in a
memory leak. Allocate memory for 'ram_lo' only if it is needed.
Valgrind output:
==16879== 240 bytes in 1 blocks are definitely lost in loss record 6
On Fr, 2014-11-21 at 12:59 +0100, Markus Armbruster wrote:
> [Copying Eric]
>
> Gerd Hoffmann writes:
>
> > Text partly suggested by Markus Armbruster
> >
> > Signed-off-by: Gerd Hoffmann
> > ---
> > qapi-schema.json | 12
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a
On 2014-11-04 at 15:19, Max Reitz wrote:
Technically, this is a v2 to my previous series
"block: JSON filenames and relative backing files", although only patch
2 and 5 were already part of that series, and also patch 2 has been
changed quite a bit in this version.
So, first the original cover l
Il 21/11/2014 12:05, Fabio Fantoni ha scritto:
Il 20/11/2014 12:21, Fabio Fantoni ha scritto:
Il 13/11/2014 13:22, Fabio Fantoni ha scritto:
Il 13/11/2014 11:14, Fabio Fantoni ha scritto:
Il 19/09/2014 15:18, Fabio Fantoni ha scritto:
Il 12/09/2014 16:46, Fabio Fantoni ha scritto:
Il 08/07/2
Add instructions of RLC opcode format.
Add helper psw_write/read.
Add microcode generator gen_mtcr/mfcr, which loads/stores a value to a core
special function register, which are defined in csfr.def
Signed-off-by: Bastian Koppelmann
Reviewed-by: Richard Henderson
---
target-tricore/csfr.def
Add instructions of RCPW, RCRR and RCRW opcode format.
Add microcode generator function gen_insert.
Signed-off-by: Bastian Koppelmann
Reviewed-by: Richard Henderson
---
target-tricore/translate.c | 132 +++--
1 file changed, 129 insertions(+), 3 deletions
Add instructions of RCR opcode format.
Add helper for madd32/64_ssov and madd32/64_suov.
Add helper for msub32/64_ssov and msub32/64_suov.
Add microcode generator function madd/msub for 32bit and 64bit, which calculate
a mul and a add/sub.
OPC2_32_RCR_MSUB_U_32 -> OPC2_32_RCR_MSUB_U_32.
Signed-of
Hi,
this patch depends on the previous TriCore patches
(https://patchwork.ozlabs.org/patch/405459/) and will hopefully end up in 2.3
QEMU.
Other than adding the RCPW, RCRR, RCRW, RLC and RCR instructions, it cleans up
how ISA versions in the feature bitmask are handled,
to simplify the checks,
Since all the TriCore instructionsets are subsets of each other (1.3 C 1.3.1 C
1.6),
make the features implying each other, e.g 1.6 also has 1.3.1 and 1.3. This way
we only need to check our features for the instructionset, where a instruction
was first introduced.
Signed-off-by: Bastian Koppelm
-20
> 14:58:37 +)
>
> are available in the git repository at:
>
> git://git.kraxel.org/qemu tags/pull-gtk-20141121-1
>
> for you to fetch changes up to b310a2a6095ec927a42cc1aba520a316be0faf51:
>
> g
Am 19.11.2014 um 11:17 schrieb Ekaterina Tumanova:
> Hi folks,
>
> I'm sorry for the recent spam. I messed up during code submission last time.
> So please ignore any previous notes you received from me and answer only to
> this thread.
>
> This is the rework of the geometry+blocksize patch, whic
On Fri, Nov 21, 2014 at 08:30:58AM -0500, Don Slutz wrote:
> On 11/20/14 21:01, Eduardo Habkost wrote:
> >On Thu, Nov 20, 2014 at 05:32:56PM -0500, Don Slutz wrote:
> >[...]
> >>@@ -1711,18 +1711,23 @@ static void pc_machine_set_max_ram_below_4g(Object
> >>*obj, Visitor *v,
> >> pcms->max_ram
Am 19.11.2014 um 11:17 schrieb Ekaterina Tumanova:
[...]
> @@ -678,6 +683,64 @@ static void raw_refresh_limits(BlockDriverState *bs,
> Error **errp)
> bs->bl.opt_mem_alignment = s->buf_align;
> }
>
> +static int CheckForDASD(int fd)
no camelcase for function names check_for_dasd
[...]
On 2014-11-21 at 11:48, Stefan Hajnoczi wrote:
The transaction QMP command performs operations atomically on a group of
drives. This command needs to acquire AioContext in order to work
safely when virtio-blk dataplane IOThreads are accessing drives.
The transactional nature of the command mean
On 11/20/14 21:01, Eduardo Habkost wrote:
On Thu, Nov 20, 2014 at 05:32:56PM -0500, Don Slutz wrote:
[...]
@@ -1711,18 +1711,23 @@ static void pc_machine_set_max_ram_below_4g(Object
*obj, Visitor *v,
pcms->max_ram_below_4g = value;
}
-static bool pc_machine_get_vmport(Object *obj, Er
On 2014-11-21 at 14:22, Max Reitz wrote:
On 2014-11-21 at 11:48, Stefan Hajnoczi wrote:
Originally the transaction QMP command was just for taking snapshots.
The command became more general when drive-backup and abort were added.
It is more accurate to say the command is about performing operat
On 2014-11-21 at 11:48, Stefan Hajnoczi wrote:
drive_backup_prepare() assigns DriveBackupState fields to NULL in the
error path. This is unnecessary because the DriveBackupState is
allocated using g_malloc0() and other functions like
external_snapshot_prepare() already rely on this.
Do not expl
On 2014-11-21 at 11:48, Stefan Hajnoczi wrote:
Originally the transaction QMP command was just for taking snapshots.
The command became more general when drive-backup and abort were added.
It is more accurate to say the command is about performing operations on
an atomic group than to say it is
On 21 November 2014 09:17, Kaiyuan wrote:
> Thanks, Greg. It's useful to me. cpu_physical_memory_read()
> looks like a wrapper of translating guest addr to host addr
> Is there a function that translates guest address to host
> physical address?
No, QEMU never deals with host physical addresses a
On 2014-10-26 at 16:20, Jun Li wrote:
Add qemu-iotests for qcow2 shrinking.
e.g:
$ ./check -qcow2 110
Signed-off-by: Jun Li
---
tests/qemu-iotests/110 | 76 ++
tests/qemu-iotests/110.out | 13
tests/qemu-iotests/group | 1 +
3 fil
The metadata (bitmap
name, granularity, etc) doesn't need to be stored in the image file
because management tools must be aware of it anyway.
What tools do you mean? In my opinion dirty bitmap should exist as a
separate object. If it exists, it should be loaded with it's drive image
and it shoul
On 2014-10-26 at 16:20, Jun Li wrote:
When every item of refcount block is NULL, free refcount block and reset the
corresponding item of refcount table with NULL. At the same time, put this
cluster to s->free_cluster_index.
Signed-off-by: Jun Li
---
v5:
Just instead write_reftable_entry with
Am 12.11.2014 um 17:11 hat Kevin Wolf geschrieben:
> This was supposed to be the first part of a series allowing to override
> the cache mode for backing files, and more specifically to support the
> test cases for that series.
>
> However, this work turned out to be a bit more complicated than I
On Mon, 10 Nov 2014 16:20:50 +
Igor Mammedov wrote:
> If QEMU is started with -numa ... Windows only notices that
> CPU has been hot-added but it will not online such CPUs.
>
> It's caused by the fact that possible CPUs are flagged as
> not enabled in SRAT and Windows honoring that informat
Am 21.11.2014 um 10:29 hat Max Reitz geschrieben:
> For the pretty formatting, the functions converting QDicts and QLists to
> JSON should not print a space after the comma separating objects,
> because a newline will emitted immediately afterwards, making the
> whitespace superfluous.
>
> Signed-
* Paolo Bonzini (pbonz...@redhat.com) wrote:
>
>
> On 20/11/2014 12:45, Dr. David Alan Gilbert wrote:
> > > For this case QEMU has atomic_read/atomic_set (corresponding to
> > > __ATOMIC_RELAXED in C/C++1x), so you could use those as well.
> >
> > Ah, so those look like they just volatile cast an
On 20/11/2014 12:45, Dr. David Alan Gilbert wrote:
> > For this case QEMU has atomic_read/atomic_set (corresponding to
> > __ATOMIC_RELAXED in C/C++1x), so you could use those as well.
>
> Ah, so those look like they just volatile cast anyway.
Yeah, but it explicitly shows that the assignment is
[Copying Eric]
Gerd Hoffmann writes:
> Text partly suggested by Markus Armbruster
>
> Signed-off-by: Gerd Hoffmann
> ---
> qapi-schema.json | 12
> 1 file changed, 12 insertions(+)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index d0926d9..fcd49b1 100644
> --- a/qapi-s
On 21/11/2014 11:49, Stefan Hajnoczi wrote:
> The BLOCK_OP_TYPE_EXTERNAL_SNAPSHOT op blocker exists but was never
> used! Let's fix that so external snapshot can be blocked.
The patch is about internal snapshots tho. :)
Paolo
> Signed-off-by: Stefan Hajnoczi
> ---
> blockdev.c | 4
> 1
On 21/11/2014 08:20, Gerd Hoffmann wrote:
> Yes, for pci class devices (so the guest driver do not match specific
> pci vendor/device ids, except for quirks) we started using the redhat
> ids.
>
> > Gerd, you seem to
> > be in charge of the redhat pci ids - are you okay if I us one (should
> > i
From: Gonglei
Coverity spot:
Assigning: iov = struct iovec [3]({{buf, 12UL},
{(void *)dot1q_buf, 4UL},
{buf + 12, size - 12}})
(address of temporary variable of type struct iovec [3]).
out_of_scope: Temporary variable of type struct iovec [3] goes
From: Gonglei
s->xmit_pos maybe assigned to a negative value (-1),
but in this branch variable s->xmit_pos as an index to
array s->buffer. Let's add a check for s->xmit_pos.
Signed-off-by: Gonglei
Signed-off-by: Paolo Bonzini
Reviewed-by: Jason Wang
Reviewed-by: Jason Wang
Signed-off-by: Ste
The following changes since commit 9c7074da5ec64e1fd61df881ab291f75541ff2b0:
hw/arm/virt: set stdout-path instead of linux,stdout-path (2014-11-20
14:58:37 +)
are available in the git repository at:
git://github.com/stefanha/qemu.git tags/net-pull-request
for you to fetch changes up to
From: Gonglei
If is_connected parameter is false, the saddr
variable will no initialize. Coverity report:
uninit_use: Using uninitialized value saddr.sin_port.
We don't need add saddr information to nc->info_str
when is_connected is false.
Signed-off-by: Gonglei
Reviewed-by: Jason Wang
Signed
From: Gonglei
commit b412eb61 introduce 'cmd:' target for guestfwd,
and fwd don't be used in this scenario, and will leak
memory in true branch with 'cmd:'. Let's allocate memory
for fwd variable just in else statement.
Cc: Alexander Graf
Signed-off-by: Gonglei
Reviewed-by: Jason Wang
Signed-
Il 20/11/2014 12:21, Fabio Fantoni ha scritto:
Il 13/11/2014 13:22, Fabio Fantoni ha scritto:
Il 13/11/2014 11:14, Fabio Fantoni ha scritto:
Il 19/09/2014 15:18, Fabio Fantoni ha scritto:
Il 12/09/2014 16:46, Fabio Fantoni ha scritto:
Il 08/07/2014 12:34, Fabio Fantoni ha scritto:
Il 08/07/2
On 2014-10-26 at 16:20, Jun Li wrote:
This patch is the realization of new function qcow2_shrink_l1_and_l2_table.
This function will shrink/discard l1 and l2 table when do qcow2 shrinking.
Signed-off-by: Jun Li
---
v5:
Do some modifications based on MAX's suggestion. Thanks for MAX.
In v5
* Markus Armbruster (arm...@redhat.com) wrote:
> Don Slutz writes:
>
> > On 11/19/14 07:29, Markus Armbruster wrote:
> >> Don Slutz writes:
> >>
> >>> The other callers to blk_set_enable_write_cache() in this file
> >>> already check for s->blk == NULL.
> >>>
> >>> Signed-off-by: Don Slutz
> >>
On Thu, Nov 20, 2014 at 02:00:59PM -0500, Mike Snitzer wrote:
> virtio_blk incorrectly established -1U as the default for these
> queue_limits. Set these limits to sane default values to avoid crashing
> the kernel. But the virtio-blk protocol should probably be extended to
> allow proper stackin
drive_backup_prepare() assigns DriveBackupState fields to NULL in the
error path. This is unnecessary because the DriveBackupState is
allocated using g_malloc0() and other functions like
external_snapshot_prepare() already rely on this.
Do not explicitly assign fields to NULL so that the error pa
The transaction QMP command performs operations atomically on a group of
drives. This command needs to acquire AioContext in order to work
safely when virtio-blk dataplane IOThreads are accessing drives.
The transactional nature of the command means that actions are split
into prepare, commit, ab
Originally the transaction QMP command was just for taking snapshots.
The command became more general when drive-backup and abort were added.
It is more accurate to say the command is about performing operations on
an atomic group than to say it is about snapshots.
Signed-off-by: Stefan Hajnoczi
The BLOCK_OP_TYPE_EXTERNAL_SNAPSHOT op blocker exists but was never
used! Let's fix that so external snapshot can be blocked.
Signed-off-by: Stefan Hajnoczi
---
blockdev.c | 4
1 file changed, 4 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index 90cb33d..d63bb7f 100644
--- a/blockde
These patches make the QMP 'transaction' command work with virtio-blk
dataplane. Each 'transaction' action must take care to acquire AioContext
around BlockDriverState accesses. Once that protection is in place we can
unblock the op blockers for these commands.
The meat is in Patch 3.
Patches 1
There is a constraint if we want to get live migration for free: The
bitmap contents must be accessible with bdrv_read() and
bdrv_get_block_status() to skip zero regions.
Hm. I'm afraid, it still will not be free. If bitmap is active, it's
actual version is in memory. To migrate bitmap file like
* Kevin Wolf (kw...@redhat.com) wrote:
> Am 20.11.2014 um 21:08 hat Dr. David Alan Gilbert geschrieben:
> > * Kevin Wolf (kw...@redhat.com) wrote:
> >
> >
> > > diff --git a/block/raw_bsd.c b/block/raw_bsd.c
> > > index 401b967..2ce5409 100644
> > > --- a/block/raw_bsd.c
> > > +++ b/block/raw_bsd
* David Gibson (da...@gibson.dropbear.id.au) wrote:
> On Wed, Nov 19, 2014 at 07:40:20PM +, Dr. David Alan Gilbert wrote:
> > * David Gibson (da...@gibson.dropbear.id.au) wrote:
> > > On Fri, Oct 03, 2014 at 06:47:51PM +0100, Dr. David Alan Gilbert (git)
> > > wrote:
> > > > From: "Dr. David A
Am 19.11.2014 um 11:17 schrieb Ekaterina Tumanova:
> Move the IOCTL calls that detect logical blocksize from raw_probe_alignment
> into separate function (probe_logical_blocksize).
> Introduce function which detect physical blocksize via IOCTL
> (probe_physical_blocksize).
> Both functions will be
Am 20.11.2014 um 21:08 hat Dr. David Alan Gilbert geschrieben:
> * Kevin Wolf (kw...@redhat.com) wrote:
>
>
> > diff --git a/block/raw_bsd.c b/block/raw_bsd.c
> > index 401b967..2ce5409 100644
> > --- a/block/raw_bsd.c
> > +++ b/block/raw_bsd.c
> > @@ -58,8 +58,58 @@ static int coroutine_fn raw_c
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
> Hi David,
>
> When i migrated VM in postcopy way when configuring VM with '-realtime
> mlock=on' option,
> It failed, and reports "postcopy_ram_hosttest: remap_anon_pages not
> available: File exists" in destination,
>
> Is it a bug of u
Am 21.11.2014 um 09:43 hat Francesco Romani geschrieben:
> - Original Message -
> > From: "Kevin Wolf"
> > To: "Stefan Hajnoczi"
> > Cc: mdr...@linux.vnet.ibm.com, "Stefan Hajnoczi" ,
> > lcapitul...@redhat.com, qemu-devel@nongnu.org,
> > "Francesco Romani"
> > Sent: Thursday, November
Am 19.11.2014 um 11:17 schrieb Ekaterina Tumanova:
> Add driver functions for geometry and blocksize detection
>
[...]
> /*
> * Create a uniquely-named empty temporary file.
> * Return 0 upon success, otherwise a negative errno value.
> diff --git a/include/block/block.h b/include/block/block
On 11/20/2014 07:18 PM, Kevin Wolf wrote:
Am 19.11.2014 um 16:04 hat Cornelia Huck geschrieben:
On Wed, 19 Nov 2014 14:40:07 +
Peter Maydell wrote:
On 19 November 2014 14:01, Ekaterina Tumanova
wrote:
Signed-off-by: Ekaterina Tumanova
Could you give the compiler error/warning message
Text partly suggested by Markus Armbruster
Signed-off-by: Gerd Hoffmann
---
qapi-schema.json | 12
1 file changed, 12 insertions(+)
diff --git a/qapi-schema.json b/qapi-schema.json
index d0926d9..fcd49b1 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -3250,6 +3250,18 @@
For the pretty formatting, the functions converting QDicts and QLists to
JSON should not print a space after the comma separating objects,
because a newline will emitted immediately afterwards, making the
whitespace superfluous.
Signed-off-by: Max Reitz
---
qobject/qjson.c | 10 ++
1 fil
From: zhanghailiang
local_err in gd_vc_gfx_init() is not freed, and we don't use it,
so remove it.
Signed-off-by: zhanghailiang
Signed-off-by: Gerd Hoffmann
---
ui/gtk.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/ui/gtk.c b/ui/gtk.c
index 38bf463..9496b8d 100644
---
1 - 100 of 113 matches
Mail list logo
