On 2014-11-21 at 11:48, Stefan Hajnoczi wrote:
drive_backup_prepare() assigns DriveBackupState fields to NULL in the
error path.  This is unnecessary because the DriveBackupState is
allocated using g_malloc0() and other functions like
external_snapshot_prepare() already rely on this.

Do not explicitly assign fields to NULL so that the error path is
concise and does not require modification when fields are added to
DriveBackupState.

Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
---
  blockdev.c | 2 --
  1 file changed, 2 deletions(-)

Reviewed-by: Max Reitz <mre...@redhat.com>

Reply via email to