Am 19.11.2014 um 11:17 schrieb Ekaterina Tumanova:
> Add driver functions for geometry and blocksize detection
>
[...]
> /*
> * Create a uniquely-named empty temporary file.
> * Return 0 upon success, otherwise a negative errno value.
> diff --git a/include/block/block.h b/include/block/block.h
> index 5450610..3287dbc 100644
> --- a/include/block/block.h
> +++ b/include/block/block.h
> @@ -60,6 +60,24 @@ typedef enum {
> BDRV_REQ_MAY_UNMAP = 0x4,
> } BdrvRequestFlags;
>
question for Kevin/Stefan/Marcus,
is belows rc type of return code ok for you (see patch 5 for its usage)?
> +struct ProbeBlockSize {
> + int rc;
> + struct BlockSize {
> + uint16_t phys;
> + uint16_t log;
> + } size;
> +};
Kate, can you make this a typedef so that you dont need to drag along "struct"?
> +
> +struct ProbeGeometry {
> + int rc;
> + struct HDGeometry {
> + uint32_t heads;
> + uint32_t sectors;
> + uint32_t cylinders;
> + uint32_t start;
> + } geo;
> +};
dito
Otherwise looks sane.
