On Fr, 2014-11-21 at 09:59 +0800, Fam Zheng wrote:
> This fixes a crash by just skipping the vte resize hack if cur is
> NULL.
Picked up for 2.2.
thanks,
Gerd
> > +int migrate_compress_threads(void)
> > +{
> > +MigrationState *s;
> > +
> > +s = migrate_get_current();
> > +
> > +return s->compress_thread_count;
> > +}
> > +
> > int migrate_use_xbzrle(void)
> > {
> > MigrationState *s;
> > @@ -697,4 +795,5 @@ void migrate_fd_connect(Migr
On 2014/11/6 19:08, Li Liang wrote:
> Instead of sending the guest memory directly, this solution compress
> the ram page before sending, after receiving, the data will be
> decompressed.
> This feature can help to reduce the data transferred about
> 60%, this is very useful when the network bandw
On 2014/11/21 1:38, Andrea Arcangeli wrote:
Hi,
On Thu, Nov 20, 2014 at 10:54:29AM +0800, zhanghailiang wrote:
Yes, you are right. This is what i really want, bypass all non-present faults
and only track strict wrprotect faults. ;)
So, do you plan to support that in the userfault API?
Yes I
Hi,
> I know recent Intel chips (eg, baytrail) have a builtin sdhci
> controller (eg, 8086:0f16). However, that has quirks defined in the
> Linux driver. Basic functionality still does seem to work though when
> I use those ids in qemu. The same basic functionality also seems to
> work when I
> > +static void migrate_put_be32(MigBuf *f, unsigned int v)
> > +{
> > +migrate_put_byte(f, v >> 24);
> > +migrate_put_byte(f, v >> 16);
> > +migrate_put_byte(f, v >> 8);
> > +migrate_put_byte(f, v);
> > +}
> > +
> > +static void migrate_put_be64(MigBuf *f, uint64_t v)
> > +{
> > +
On Wed, Nov 19, 2014 at 05:50:11PM +, Dr. David Alan Gilbert wrote:
> * David Gibson (da...@gibson.dropbear.id.au) wrote:
> > On Fri, Oct 03, 2014 at 06:47:25PM +0100, Dr. David Alan Gilbert (git)
> > wrote:
> > > From: "Dr. David Alan Gilbert"
> > >
> > > Postcopy needs to have two migratio
On Wed, Nov 19, 2014 at 05:53:54PM +, Dr. David Alan Gilbert wrote:
> * David Gibson (da...@gibson.dropbear.id.au) wrote:
> > On Fri, Oct 03, 2014 at 06:47:30PM +0100, Dr. David Alan Gilbert (git)
> > wrote:
> > > From: "Dr. David Alan Gilbert"
> > >
> > > Use that to split the qemu_savevm_s
Eric Blake wrote on 2014-11-06:
Hi Eric
Thanks for your review and comment.
> On 11/06/2014 12:08 PM, Li Liang wrote:
>> Instead of sending the guest memory directly, this solution compress
>> the ram page before sending, after receiving, the data will be
>> decompressed.
>> This feature can h
Awesome.
Thanks!
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1368815
Title:
qemu-img convert intermittently corrupts output images
Status in OpenStack Compute (Nova):
In Progress
Status in QE
@Leen,
I am pushing qemu 2.1+dfsg-4ubuntu6.3~ppa1 (which includes the fix
proposed by Gonglei in comment #7) to ppa:serge-hallyn/libvirt-testing.
Please let us know whether it does in fact solve your issue.
** Also affects: qemu (Ubuntu)
Importance: Undecided
Status: New
** Changed in:
On (Thu) 20 Nov 2014 [09:16:31], Igor Mammedov wrote:
> On Thu, 20 Nov 2014 09:49:20 +0530
> Amit Shah wrote:
>
> > On (Wed) 19 Nov 2014 [11:08:46], Igor Mammedov wrote:
> > > On Wed, 19 Nov 2014 12:51:00 +0530
> > > Amit Shah wrote:
> >
> > > > > -static void *acpi_add_rom_blob(AcpiBuildState
Hi Tony,
yes, I've uploaded a proposed fix for trusty-proposed earlier today. It
should be available for testing as soon as it is accepted.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1368815
Tit
Hi David,
When i migrated VM in postcopy way when configuring VM with '-realtime
mlock=on' option,
It failed, and reports "postcopy_ram_hosttest: remap_anon_pages not available: File
exists" in destination,
Is it a bug of userfaultfd API?
cc: Andrea
reproduce Steps:
Source:
qemu-postcopy/qem
On Thu, Nov 20, 2014 at 05:32:56PM -0500, Don Slutz wrote:
[...]
> @@ -1711,18 +1711,23 @@ static void pc_machine_set_max_ram_below_4g(Object
> *obj, Visitor *v,
> pcms->max_ram_below_4g = value;
> }
>
> -static bool pc_machine_get_vmport(Object *obj, Error **errp)
> +static void pc_machin
This fixes a crash by just skipping the vte resize hack if cur is NULL.
Reproducer:
qemu-system-x86_64 -nodefaults
Signed-off-by: Fam Zheng
---
ui/gtk.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/ui/gtk.c b/ui/gtk.c
index 38bf463..29e09a7 100644
--- a/
On 11/20/2014 07:35 PM, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> Coverity spot:
> Assigning: iov = struct iovec [3]({{buf, 12UL},
>{(void *)dot1q_buf, 4UL},
>{buf + 12, size - 12}})
> (address of temporary variable of type struct iovec [3
On 11/20/2014 07:35 PM, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> s->xmit_pos maybe assigned to a negative value (-1),
> but in this branch variable s->xmit_pos as an index to
> array s->buffer. Let's add a check for s->xmit_pos.
>
> Signed-off-by: Gonglei
> Signed-off-by: Paolo Bonzini
On 2014/11/18 10:47, Gonglei (Arei) wrote:
> From: Gonglei
>
> Reported-by:
> https://bugs.launchpad.net/qemu/+bug/1393440
>
> Signed-off-by: Gonglei
> ---
> hw/pci/pcie.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
> index 58455bd.
On 2014/11/21 8:01, Eric Blake wrote:
> On 11/20/2014 01:55 AM, arei.gong...@huawei.com wrote:
>> From: Gonglei
>>
>> Signed-off-by: Gonglei
>> ---
>> hw/pci/pcie.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> adding qemu-trivial in cc. This is a candidate for 2.2.
>
> Review
On 11/20/2014 03:34 AM, Vladimir Sementsov-Ogievskiy wrote:
> QDB file is for storing dirty bitmap. The specification is based on
> qcow2 specification.
>
> Saving several bitmaps is necessary when server shutdowns during
> backup. In this case 2 tables for each disk are available. One
> collected
On 11/20/2014 04:04 AM, Stefan Hajnoczi wrote:
>>
>> We're "only" talking about an optimisation here, even though a very
>> useful one, so I wouldn't easily make compromises here. We should
>> probably insist on using the node-name. Management tools need new code
>> anyway to make use of the new fu
On 11/20/2014 01:55 AM, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> Signed-off-by: Gonglei
> ---
> hw/pci/pcie.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
adding qemu-trivial in cc. This is a candidate for 2.2.
Reviewed-by: Eric Blake
>
> diff --git a/hw/pci/pcie.c b/
On 11/20/2014 10:06 AM, Max Reitz wrote:
> Add a test for conversion between different refcount widths and errors
> specific to certain widths (i.e. snapshots with refcount_width=1).
>
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/112 | 278
>
Hi Serge,
Is there any chance these fixes will go into trusty?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1368815
Title:
qemu-img convert intermittently corrupts output images
Status in OpenS
c/s 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4
or
c/s b154537ad07598377ebf98252fb7d2aff127983b
moved the testing of xen_enabled() from pc_init1() to
pc_machine_initfn().
xen_enabled() does not return the correct value in
pc_machine_initfn().
Changed vmport from a bool to an enum. Added the valu
** Description changed:
+ ==
+ Impact: occasional qcow2 corruption
+ Test case: see the qemu-img command below
+ Regression potential: this cherrypicks a patch from upstream to a
not-insignificantly older qemu source tree. While the cherryp
On 11/20/2014 10:06 AM, Max Reitz wrote:
> Progress may regress; this should be displayed correctly by
> qemu_progress_print().
>
> Signed-off-by: Max Reitz
> ---
> util/qemu-progress.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Eric Blake
>
> diff --git a/util/qemu-progress.c b/ut
On 11/20/2014 10:06 AM, Max Reitz wrote:
> Add a refcount_order parameter to qcow2_create2(), use that value for
> the image header and for calculating the size required for
> preallocation.
>
> For now, always pass 4.
>
> This addition requires changes to the calculation of the file size for
> t
On 11/20/2014 10:06 AM, Max Reitz wrote:
> Add helper functions for getting and setting refcounts in a refcount
> array for any possible refcount order, and choose the correct one during
> refcount initialization.
>
> Signed-off-by: Max Reitz
> ---
> block/qcow2-refcount.c | 124
> +
On 11/20/2014 10:06 AM, Max Reitz wrote:
> Since refcounts do not always have to be a uint16_t, all refcount blocks
> and arrays in memory should not have a specific type (thus they become
> pointers to void) and for accessing them, two helper functions are used
> (a getter and a setter). Those fun
On 11/20/2014 10:06 AM, Max Reitz wrote:
> Add a helper function for reallocating a refcount array, independent of
> the refcount order. The newly allocated space is zeroed and the function
> handles failed reallocations gracefully.
>
> The helper function will always align the buffer size to a cl
Paolo Bonzini reported that Coverity reports an uninitialized pad value.
Let's use a designated initializer for kvm_irq_routing_entry to avoid
this false positive. This is similar to kvm_irqchip_add_msi_route and
other users of kvm_irq_routing_entry.
Signed-off-by: Christian Borntraeger
---
kvm-
struct kvm_fpu contains an alignment padding on s390x. Let's use a
designated initializer to avoid false positives from valgrind/memcheck.
Signed-off-by: Christian Borntraeger
---
target-s390x/kvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-s390x/kvm.c b/target-s
struct kvm_xcrs contains padding bytes. Let's use a designated
initializer to avoid false positives from valgrind/memcheck.
Signed-off-by: Christian Borntraeger
---
target-i386/kvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index c
kvm_clock_data contains pad fields. Let's use a designated
initializer to avoid false positives from valgrind/memcheck.
Signed-off-by: Christian Borntraeger
---
hw/i386/kvm/clock.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/i386/kvm/clock.c b/hw/i386/kvm/clock.c
ind
struct kvm_msrs contains padding bytes. Let's use a designated
initializer on the info part to avoid false positives from
valgrind/memcheck. Do the same for generic MSRS, the TSC and
feature control.
We also need to zero out the reserved fields in the entries.
We do this in kvm_msr_entry_set as su
struct kvm_dirty_log contains padding fields that trigger false
positives in valgrind. Let's use a designated initializer to avoid
false positives from valgrind/memcheck.
Signed-off-by: Christian Borntraeger
---
kvm-all.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kvm-al
struct kvm_pit_state2 contains pad fields. Let's use a designated
initializer to avoid false positives from valgrind/memcheck.
Signed-off-by: Christian Borntraeger
---
hw/i386/kvm/i8254.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/kvm/i8254.c b/hw/i386/kvm/i8254.
struct kvm_msrs contains a pad field. Let's use a designated
initializer on the info part to avoid false positives from
valgrind/memcheck.
Signed-off-by: Christian Borntraeger
---
target-i386/kvm.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/target-i386/kvm.c b/target
struct kvm_vcpu_events contains reserved fields. Let's use a
designated initializer to avoid false positives in valgrind.
Signed-off-by: Christian Borntraeger
---
target-i386/kvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 791
Paolo, Peter,
here is an updated version of my valgrind tree. Please review and
consider for 2.3.
The following changes since commit af3ff19b48f0bbf3a8bd35c47460358e8c6ae5e5:
Update version for v2.2.0-rc2 release (2014-11-18 18:00:58 +)
are available in the git repository at:
git://git
On 11/20/2014 06:48 AM, Max Reitz wrote:
> Sounds good, the only problem is that I'd have to hand-craft the image
> myself, because qemu generally uses self-references for refblocks (when
> allocating new refblocks, they will contain their own refcount).
>
> I think this already would be too much
On 11/20/2014 07:03 AM, Max Reitz wrote:
> Some people may ask why the walks are performed in a loop without a
> fixed limit (because they can't find cases where allocations haven't
> settled at the third pass). But I doubt that'll be a serious problem.
> It's much easier to have such a basically u
On 20 Nov 2014, at 22:20, Eric Blake wrote:
> Instead, try:
>
> -semihosting-config target=native,cmdline="MessageTest
> --gtest_output=xml:gcm.xml,,baburiba"
with double comma, the output of my custom qemu shows that the command line was
properly parsed:
GNU ARM Eclipse QEMU v2.1.92 (qemu-s
On 11/20/2014 01:13 PM, Liviu Ionescu wrote:
>
> On 20 Nov 2014, at 18:40, Liviu Ionescu wrote:
>
>> A new sub-option was added to -semihosting-config to define the entire
>> semihosting command line (cmdline=string).
>
> unfortunately the use of a sub-option is not appropriate, the command lin
On 20 Nov 2014, at 18:40, Liviu Ionescu wrote:
> A new sub-option was added to -semihosting-config to define the entire
> semihosting command line (cmdline=string).
unfortunately the use of a sub-option is not appropriate, the command line
string must be allowed to include *any* character, inc
* Kevin Wolf (kw...@redhat.com) wrote:
> diff --git a/block/raw_bsd.c b/block/raw_bsd.c
> index 401b967..2ce5409 100644
> --- a/block/raw_bsd.c
> +++ b/block/raw_bsd.c
> @@ -58,8 +58,58 @@ static int coroutine_fn raw_co_readv(BlockDriverState *bs,
> int64_t sector_num,
> static int coroutine_fn
On 11/20/2014 11:21 AM, Don Slutz wrote:
> c/s 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4
>
> or
>
> c/s b154537ad07598377ebf98252fb7d2aff127983b
>
> moved the testing of xen_enabled() from pc_init1() to
> pc_machine_initfn().
>
> xen_enabled() does not return the correct value in
> pc_machine_in
On 11/20/2014 11:56 AM, Max Reitz wrote:
> On 20.11.2014 19:39, Kevin Wolf wrote:
>> Am 17.11.2014 um 13:31 hat Max Reitz geschrieben:
>>> 067 invokes query-block, resulting in a reference output with really
>>> long lines (which may pose a problem in email patches and always poses a
>>> problem wh
On 11/20/14 14:05, Eduardo Habkost wrote:
On Thu, Nov 20, 2014 at 01:21:18PM -0500, Don Slutz wrote:
[...]
@@ -242,9 +243,16 @@ static void pc_q35_init(MachineState *machine)
pc_register_ferr_irq(gsi[13]);
+assert(pc_machine->vmport != ON_OFF_AUTO_MAX);
+if (pc_machine->vmpo
Hi Paolo,
On 07/31/2013 02:19 AM, Paolo Bonzini wrote:
> 1) The GPL says that "if the Program does not specify a version number
> of this License, you may choose any version ever published by the Free
> Software Foundation". This is not true, QEMU includes parts that are
> v2-only.
>
> 2) Provid
On Thu, Nov 20, 2014 at 01:21:18PM -0500, Don Slutz wrote:
[...]
> @@ -242,9 +243,16 @@ static void pc_q35_init(MachineState *machine)
>
> pc_register_ferr_irq(gsi[13]);
>
> +assert(pc_machine->vmport != ON_OFF_AUTO_MAX);
> +if (pc_machine->vmport == ON_OFF_AUTO_AUTO) {
> +
On 20.11.2014 19:39, Kevin Wolf wrote:
Am 17.11.2014 um 13:31 hat Max Reitz geschrieben:
067 invokes query-block, resulting in a reference output with really
long lines (which may pose a problem in email patches and always poses a
problem when the output changes, because it is hard to see what h
Am 17.11.2014 um 13:31 hat Max Reitz geschrieben:
> 067 invokes query-block, resulting in a reference output with really
> long lines (which may pose a problem in email patches and always poses a
> problem when the output changes, because it is hard to see what has
> actually changed). Use -qmp-pre
On 11/19/14 07:29, Markus Armbruster wrote:
Don Slutz writes:
The other callers to blk_set_enable_write_cache() in this file
already check for s->blk == NULL.
Signed-off-by: Don Slutz
---
I think this is a bugfix that should be back ported to stable
releases.
I also think this should be do
c/s 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4
or
c/s b154537ad07598377ebf98252fb7d2aff127983b
moved the testing of xen_enabled() from pc_init1() to
pc_machine_initfn().
xen_enabled() does not return the correct value in
pc_machine_initfn().
Changed vmport from a bool to an enum. Added the valu
I loaded kernel and initramfs through symlinks and make that symlinks
wrong (kernel become initramfs and vice versa)
** Changed in: qemu
Status: New => Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launc
Hi,
This issue has been fixed in master
(af3ff19b48f0bbf3a8bd35c47460358e8c6ae5e5, 2.2.0-rc2):
$ ./qemu-img amend -o compat=0.10 -f qcow2 copy.img
qemu-img: Error while amending options: File too large
Thanks for your report,
Max
** Changed in: qemu
Status: New => Fix Committed
--
You
Hi,
Well, I still (on 2.2.0-rc2) receive "File too large", so I guess that's
the fix.
Max
** Changed in: qemu
Status: New => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/13574
On 11/20/14 03:44, Michael S. Tsirkin wrote:
On Wed, Nov 19, 2014 at 07:38:10PM -0500, Don Slutz wrote:
c/s 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4
or
c/s b154537ad07598377ebf98252fb7d2aff127983b
moved the testing of xen_enabled() from pc_init1() to
pc_machine_initfn().
xen_enabled() does n
Hi,
On Thu, Nov 20, 2014 at 10:54:29AM +0800, zhanghailiang wrote:
> Yes, you are right. This is what i really want, bypass all non-present faults
> and only track strict wrprotect faults. ;)
>
> So, do you plan to support that in the userfault API?
Yes I think it's good idea to support wrprotec
** Attachment added: "/etc/kernels/kernel-config-x86_64-3.17.3-gentoo-gnu-vm"
https://bugs.launchpad.net/qemu/+bug/1394550/+attachment/4264503/+files/kernel-config-x86_64-3.17.3-gentoo-gnu-vm
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed
** Attachment added: "/boot/kernel-genkernel-x86_64-3.17.3-gentoo-gnu-vm"
https://bugs.launchpad.net/qemu/+bug/1394550/+attachment/4264505/+files/kernel-genkernel-x86_64-3.17.3-gentoo-gnu-vm
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed
** Attachment added: "/boot/initramfs-genkernel-x86_64-3.17.3-gentoo-gnu-vm"
https://bugs.launchpad.net/qemu/+bug/1394550/+attachment/4264506/+files/initramfs-genkernel-x86_64-3.17.3-gentoo-gnu-vm
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subsc
** Attachment added: "/etc/genkernel.conf"
https://bugs.launchpad.net/qemu/+bug/1394550/+attachment/4264504/+files/genkernel.conf
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1394550
Title:
qe
On 20 November 2014 17:21, Maciej W. Rozycki wrote:
> It's not possible, the MIPS16 and microMIPS instruction sets are
> mutually exclusive as the same resource (the ISA bit or the LSB of the
> PC) is used to switch to either mode from the standard MIPS mode,
> depending on what a given processor
Hi,
On Fri, Oct 31, 2014 at 12:39:32PM -0700, Peter Feiner wrote:
> On Fri, Oct 31, 2014 at 11:29:49AM +0800, zhanghailiang wrote:
> > Agreed, but for doing live memory snapshot (VM is running when do
> > snapsphot),
> > we have to do this (block the write action), because we have to save the
>
On 03.11.14 16:14, Cédric Le Goater wrote:
> Currently, when the page tables are saved, the kvm_get_htab_header structs
> and the ptes are assumed being big endian and dumped as a indistinct blob
> in the statefile. This is no longer true when the host is little endian
> and this breaks restor
On 11/20/2014 02:28 PM, Bastian Koppelmann wrote:
> +uint64_t helper_madd64_ssov(CPUTriCoreState *env, target_ulong r1,
> +uint64_t r2, target_ulong r3)
> +{
> +uint64_t ret_low, ret_high;
> +uint64_t r2_high;
> +int64_t t1 = sextract64(r1, 0, 32);
> +int
On Thu, 20 Nov 2014, Peter Maydell wrote:
> > For user emulation mode I think we want to default to the highest ISA
> > level supported, for maximum user flexibility. Currently the MIPS64r2
> > ISA is the highest 64-bit ISA we have a real processor support for so
> > use it and the 5KEf which is
* Paolo Bonzini (pbonz...@redhat.com) wrote:
> Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto:
> > From: "Dr. David Alan Gilbert"
> >
> > Rework the migration thread to setup and start postcopy.
> >
> > Signed-off-by: Dr. David Alan Gilbert
> > ---
> > include/migration/migration
Add a function qcow2_change_refcount_order() which allows changing the
refcount order of a qcow2 image.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
---
block/qcow2-refcount.c | 454 +
block/qcow2.h | 4 +
2 files changed, 458 inser
Add an opaque value which is to be passed to the bdrv_amend_options()
status callback.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
---
block.c | 4 ++--
block/qcow2-cluster.c | 14 --
block/qcow2.c | 9 +
block/qcow2.h |
Progress may regress; this should be displayed correctly by
qemu_progress_print().
Signed-off-by: Max Reitz
---
util/qemu-progress.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/util/qemu-progress.c b/util/qemu-progress.c
index 4ee5cd0..c0fb14d 100644
--- a/util/qemu-progress.c
+++ b/util
Some tests do not work well with certain refcount widths (i.e. you
cannot create internal snapshots with refcount_width=1), so make those
widths unsupported.
Furthermore, add another filter to _filter_img_create in common.filter
which filters out the refcount_width value.
This is necessary for te
On 20/11/2014 18:12, Dr. David Alan Gilbert wrote:
> Trace added, and also moved as requested - was the request to move
> it just to elimintate the other DPRINTF?
Yes.
>> > Also what is 2/3/4? Is this just for debugging or is it part of the
>> > protocol?
> Debug; they're very useful for match
Add a creation option to qcow2 for setting the refcount order of images
to be created, and respect that option's value.
This breaks some test outputs, fix them.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
---
block/qcow2.c | 20
include/block/block_int.h | 1 +
t
If a reference count is not representable with the current refcount
order, the image check should point to qemu-img amend for increasing the
refcount order. However, qemu-img amend needs write access to the image
which cannot be provided if the image is marked corrupt; and the image
check will not
Add helper functions for getting and setting refcounts in a refcount
array for any possible refcount order, and choose the correct one during
refcount initialization.
Signed-off-by: Max Reitz
---
block/qcow2-refcount.c | 124 -
1 file changed, 122
Add a test for conversion between different refcount widths and errors
specific to certain widths (i.e. snapshots with refcount_width=1).
Signed-off-by: Max Reitz
---
tests/qemu-iotests/112 | 278 +
tests/qemu-iotests/112.out | 143
Since refcounts do not always have to be a uint16_t, all refcount blocks
and arrays in memory should not have a specific type (thus they become
pointers to void) and for accessing them, two helper functions are used
(a getter and a setter). Those functions are called indirectly through
function poi
Make use of qcow2_change_refcount_order() to support changing the
refcount order with qemu-img amend.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
---
block/qcow2.c | 44 +++-
1 file changed, 35 insertions(+), 9 deletions(-)
diff --git a/block/qcow2.
Add the bit width of every refcount entry to the format-specific
information.
In contrast to lazy_refcounts and the corrupt flag, this should be
always emitted, even for compat=0.10 although it does not support any
refcount width other than 16 bits. This is because if a boolean is
optional, one no
If there is more than one time-consuming operation to be performed for
qcow2_amend_options(), we need an intermediate CB which coordinates the
progress of the individual operations and passes the result to the
original status callback.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
---
block/
If the image version should be upgraded, that is the first we should do;
if it should be downgraded, that is the last we should do. So split the
version change block into an upgrade part at the start and a downgrade
part at the end.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
---
block/qco
Add a refcount_order parameter to qcow2_create2(), use that value for
the image header and for calculating the size required for
preallocation.
For now, always pass 4.
This addition requires changes to the calculation of the file size for
the "full" and "falloc" preallocation modes. That in turn
Add a helper function for reallocating a refcount array, independent of
the refcount order. The newly allocated space is zeroed and the function
handles failed reallocations gracefully.
The helper function will always align the buffer size to a cluster
boundary; if storing the refcounts in such an
No longer refuse to open images with a different refcount entry width
than 16 bits; only reject images with a refcount width larger than 64
bits (which is prohibited by the specification).
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
---
block/qcow2.c | 8
1 file changed, 4 inserti
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
---
block/qcow2.c | 14 ++
tests/qemu-iotests/061.out | 14 +++---
2 files changed, 13 insertions(+), 15 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 39e6061..4e19615 100644
--- a/block/qcow2.c
++
qcow2_alloc_bytes() may reuse a cluster multiple times, in which case
the refcount is increased accordingly. However, if this would lead to an
overflow the function should instead just not reuse this cluster and
allocate a new one.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
---
block/qcow
qcow2_update_cluster_refcount() may fail, and qcow2_alloc_bytes() should
mind that case.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
---
block/qcow2-refcount.c | 32 +---
1 file changed, 21 insertions(+), 11 deletions(-)
diff --git a/block/qcow2-refcount.c b/bl
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
---
block/qcow2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 4e19615..e8d54ab 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -2723,9 +2723,9 @@ static int qcow2_amend_options(Bloc
As of version 3, the qcow2 file format supports different widths for
refcount entries, ranging from 1 to 64 bit (only powers of two).
Currently, qemu only supports 16 bit, which is the only width supported
by version 2 (compat=0.10) images.
This series adds support to qemu for all other valid refc
Refcounts may have a width of up to 64 bits, so qemu should use the same
width to represent refcount values internally.
Since for instance qcow2_get_refcount() signals an error by returning a
negative value, refcount values are generally signed to be able to
represent those error values correctly.
Add two new fields regarding refcount information (the bit width of
every entry and the maximum refcount value) to the BDRVQcowState.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
---
block/qcow2-refcount.c | 2 +-
block/qcow2.c | 9 +
block/qcow2.h | 2 ++
3 files
On 11/20/14 3:54 AM, Dr. David Alan Gilbert wrote:
* Gary R Hook (grhookatw...@gmail.com) wrote:
Ugh, I wish I could teach Thunderbird to understand how to reply to a
newsgroup.
Apologies to Paolo for the direct note.
On 11/19/14 4:19 AM, Paolo Bonzini wrote:
On 19/11/2014 10:35, Dr. David
On Tue, Nov 18, 2014 at 07:27:24AM +0100, Paolo Bonzini wrote:
> On 18/11/2014 05:26, Kevin O'Connor wrote:
> > --- a/include/hw/pci/pci.h
> > +++ b/include/hw/pci/pci.h
> > @@ -53,6 +53,7 @@
> > /* QEMU/Bochs VGA (0x1234) */
> > #define PCI_VENDOR_ID_QEMU 0x1234
> > #define PCI_DE
Am 17.11.2014 um 13:31 hat Max Reitz geschrieben:
> This series does not add new functionality. Adding a QMP monitor with
> prettily formatted JSON output can be done as follows:
>
> $ qemu -chardev stdio,id=mon0 -mon chardev=mon0,mode=control,pretty=on
>
> However, this is rather cumbersome, so
On 11/20/2014 01:44 AM, Michael S. Tsirkin wrote:
> On Wed, Nov 19, 2014 at 07:38:10PM -0500, Don Slutz wrote:
>> c/s 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4
>>
>> or
>>
>> c/s b154537ad07598377ebf98252fb7d2aff127983b
>>
>> moved the testing of xen_enabled() from pc_init1() to
>> pc_machine_initfn
1 - 100 of 238 matches
Mail list logo
