On 20.11.2014 19:39, Kevin Wolf wrote:
Am 17.11.2014 um 13:31 hat Max Reitz geschrieben:
067 invokes query-block, resulting in a reference output with really
long lines (which may pose a problem in email patches and always poses a
problem when the output changes, because it is hard to see what has
actually changed). Use -qmp-pretty to mitigate this issue.
Signed-off-by: Max Reitz <mre...@redhat.com>
Reviewed-by: Eric Blake <ebl...@redhat.com>
---
tests/qemu-iotests/067 | 2 +-
tests/qemu-iotests/067.out | 779 +++++++++++++++++++++++++++++++++++++++++----
2 files changed, 723 insertions(+), 58 deletions(-)
Hm, when I tried to rebase my query-block patch that adds cache
information, I noticed that I get a trailing space on every line of the
JSON dump, which isn't there in this patch. So 'cp 067.out.bad 067.out'
ended up changing every single line. :-/
Did you postprocess the reference output or do really get it without
trailing whitespace?
Yes, I post-processed it, because you once complained about me sending
patches with trailing whitespace. :-P
As I wrote in some reply to some reply from Eric on some version of this
patch, QEMU's pretty JSON formatter emits whitespace at the end of some
lines.
Max
