On Tue, Nov 18, 2014 at 07:27:24AM +0100, Paolo Bonzini wrote: > On 18/11/2014 05:26, Kevin O'Connor wrote: > > --- a/include/hw/pci/pci.h > > +++ b/include/hw/pci/pci.h > > @@ -53,6 +53,7 @@ > > /* QEMU/Bochs VGA (0x1234) */ > > #define PCI_VENDOR_ID_QEMU 0x1234 > > #define PCI_DEVICE_ID_QEMU_VGA 0x1111 > > +#define PCI_DEVICE_ID_SDHCI 0x2222 > > 0x1234 is not a registered PCI id, and it's only used for VGA for > backwards-compatibility reasons. > > Please use 1b36:0005 instead, and document it in docs/specs/pci-ids.txt, > or use a real-world PCI vendor/device pair (if you can find one that > Linux doesn't have quirks for; that could be hard).
Hi Paolo. Thanks for reviewing. I know recent Intel chips (eg, baytrail) have a builtin sdhci controller (eg, 8086:0f16). However, that has quirks defined in the Linux driver. Basic functionality still does seem to work though when I use those ids in qemu. The same basic functionality also seems to work when I use 1b36:0005 as well. Is there a preference then to use the redhat ids? Gerd, you seem to be in charge of the redhat pci ids - are you okay if I us one (should it be the existing 0005 or add 0006)? Thanks, -Kevin
