Re: [Qemu-devel] [RFC V2 00/10] cpu: add device_add foo-x86_64-cpu and i386 cpu hot remove support

2014-11-11 Thread Igor Mammedov
On Wed, 12 Nov 2014 09:46:30 +0800 Gu Zheng wrote: > Hi Igor, > As your hot-plug rework has been merged in upstream, and we need to respin > the i386 cpu hot remove a lot based on the latest tree. > So I want to split the series into two parts: > Part 1/2: add device_add foo-x86_64-cpu support. >

Re: [Qemu-devel] [PATCH] target-i386/FPU: wrong conversion infinity from float80 to int32/int64

2014-11-11 Thread Richard Henderson
On 11/11/2014 01:29 PM, Dmitry Poletaev wrote: > From: Dmitry Poletaev > Signed-off-by: Dmitry Poletaev > > --- > target-i386/fpu_helper.c | 24 +--- > 1 file changed, 21 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH for-2.2] pci: Don't pass negative errno to 'error_set_errno()'

2014-11-11 Thread SeokYeon Hwang
> -Original Message- > From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Wednesday, November 12, 2014 4:33 PM > To: SeokYeon Hwang > Cc: qemu-devel@nongnu.org; kongjian...@gmail.com; paolo.bonz...@gmail.com; > mre...@redhat.com; qemu-triv...@nongnu.org; Michael S. Tsirkin > Subject

Re: [Qemu-devel] [PATCH] target-i386/fpu_helper.c: fbld instruction doesn't set minus sign

2014-11-11 Thread Richard Henderson
On 11/11/2014 01:33 PM, Dmitry Poletaev wrote: > ping > > 25.07.2014, 15:48, "Dmitry Poletaev" : >> Obviously, there is a misprint in function implementation. >> >> From: Dmitry Poletaev >> Signed-off-by: Dmitry Poletaev >> >> --- >> target-i386/fpu_helper.c | 2 +- >> 1 file changed, 1 inserti

Re: [Qemu-devel] [PATCH v4] error: passing a negative value to an os_errno is wrong

2014-11-11 Thread Markus Armbruster
SeokYeon Hwang writes: > Added 'assert(os_errno >= 0)' in 'error_set_errno()'. > > Signed-off-by: SeokYeon Hwang > --- > util/error.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/util/error.c b/util/error.c > index 2ace0d8..6c9d995 100644 > --- a/util/error.c > +++ b/util/error.c >

Re: [Qemu-devel] [PATCH for-2.2] pci: Don't pass negative errno to 'error_set_errno()'

2014-11-11 Thread Markus Armbruster
Copying maintainer and -trivial. In the future, please copy maintainers. You can use "scripts/get_maintainer.pl --no-git-fallback" to find them. SeokYeon Hwang writes: > Signed-off-by: SeokYeon Hwang > --- > hw/pci/pcie.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Qemu-devel] [PATCH 00/17] RFC: userfault v2

2014-11-11 Thread zhanghailiang
Hi Andrea, Is there any new about this discussion? ;) Will you plan to support 'only wrprotect fault' in the userfault API? Thanks, zhanghailiang On 2014/10/30 19:31, zhanghailiang wrote: On 2014/10/30 1:46, Andrea Arcangeli wrote: Hi Zhanghailiang, On Mon, Oct 27, 2014 at 05:32:51PM +0800,

Re: [Qemu-devel] [PATCH v3] error: passing a negative value to an os_errno is wrong

2014-11-11 Thread SeokYeon Hwang
> -Original Message- > From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Monday, November 10, 2014 10:21 PM > To: SeokYeon Hwang > Cc: kongjian...@gmail.com; paolo.bonz...@gmail.com; qemu-devel@nongnu.org; > mre...@redhat.com > Subject: Re: [Qemu-devel] [PATCH v3] error: passing a

[Qemu-devel] [PATCH v4] error: passing a negative value to an os_errno is wrong

2014-11-11 Thread SeokYeon Hwang
Added 'assert(os_errno >= 0)' in 'error_set_errno()'. Signed-off-by: SeokYeon Hwang --- util/error.c | 1 + 1 file changed, 1 insertion(+) diff --git a/util/error.c b/util/error.c index 2ace0d8..6c9d995 100644 --- a/util/error.c +++ b/util/error.c @@ -62,6 +62,7 @@ void error_set_errno(Error **

[Qemu-devel] [PATCH for-2.2] pci: Don't pass negative errno to 'error_set_errno()'

2014-11-11 Thread SeokYeon Hwang
Signed-off-by: SeokYeon Hwang --- hw/pci/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 58455bd..2902f7d 100644 --- a/hw/pci/pcie.c +++ b/hw/pci/pcie.c @@ -229,7 +229,7 @@ static void pcie_cap_slot_hotplug_common(PCIDevice *hotplug_

Re: [Qemu-devel] [PATCH v3] error: passing a negative value to an os_errno is wrong

2014-11-11 Thread SeokYeon Hwang
> -Original Message- > From: Eric Blake [mailto:ebl...@redhat.com] > Sent: Tuesday, November 11, 2014 1:14 AM > To: SeokYeon Hwang; qemu-devel@nongnu.org > Cc: paolo.bonz...@gmail.com; arm...@redhat.com; mre...@redhat.com; > kongjian...@gmail.com > Subject: Re: [PATCH v3] error: passing a n

Re: [Qemu-devel] [PATCH 3/3] iotests: Use -qmp-pretty in 067

2014-11-11 Thread Eric Blake
On 11/11/2014 06:34 AM, Max Reitz wrote: > 067 invokes query-block, resulting in a reference output with really > long lines (which may pose a problem in email patches and always poses a > problem when the output changes, because it is hard to see what has > actually changed). Use -qmp-pretty to mi

Re: [Qemu-devel] [PATCH 2/3] iotests: _filter_qmp for pretty JSON output

2014-11-11 Thread Eric Blake
On 11/11/2014 06:34 AM, Max Reitz wrote: > _filter_qmp should be able to correctly filter out the QMP version > object for pretty JSON output. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/common.filter | 16 +++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff

Re: [Qemu-devel] [PATCH 1/3] chardev: Add -qmp-pretty

2014-11-11 Thread Eric Blake
On 11/11/2014 06:34 AM, Max Reitz wrote: > Add a command line option for adding a QMP monitor using pretty JSON > formatting. > > Signed-off-by: Max Reitz > --- > qemu-options.hx | 8 > vl.c| 15 ++- > 2 files changed, 18 insertions(+), 5 deletions(-) > Minor

Re: [Qemu-devel] [PATCH 20/21] qcow2: Point to amend function in check

2014-11-11 Thread Eric Blake
On 11/10/2014 06:45 AM, Max Reitz wrote: > If a reference count is not representable with the current refcount > order, the image check should point to qemu-img amend for increasing the > refcount order. However, qemu-img amend needs write access to the image > which cannot be provided if the image

Re: [Qemu-devel] [PATCH 19/21] qcow2: Invoke refcount order amendment function

2014-11-11 Thread Eric Blake
On 11/10/2014 06:45 AM, Max Reitz wrote: > Make use of qcow2_change_refcount_order() to support changing the > refcount order with qemu-img amend. > > Signed-off-by: Max Reitz > --- > block/qcow2.c | 44 +++- > 1 file changed, 35 insertions(+), 9 deletions

Re: [Qemu-devel] [PATCH 18/21] qcow2: Add function for refcount order amendment

2014-11-11 Thread Eric Blake
On 11/10/2014 06:45 AM, Max Reitz wrote: > Add a function qcow2_change_refcount_order() which allows changing the > refcount order of a qcow2 image. > > Signed-off-by: Max Reitz > --- > block/qcow2-refcount.c | 424 > + > block/qcow2.h |

[Qemu-devel] [PATCH] virtio-scsi: dataplane: suppress guest notification

2014-11-11 Thread Ming Lei
This patch uses vring_should_notify() to suppress guest notification, and looks notification frequency can be decreased from ~33K/sec to ~2K/sec in my test environment. Suggested-by: Stefan Hajnoczi Signed-off-by: Ming Lei --- hw/scsi/virtio-scsi-dataplane.c |7 ++- 1 file changed, 6 in

Re: [Qemu-devel] [PATCH v1 2/2] virtio-scsi: dataplane: notify guest as batch

2014-11-11 Thread Ming Lei
On Wed, Nov 12, 2014 at 1:28 AM, Stefan Hajnoczi wrote: > On Tue, Nov 11, 2014 at 09:17:10AM +0800, Ming Lei wrote: >> +static void notify_guest_bh(void *opaque) >> +{ >> +VirtIOSCSI *s = opaque; >> +unsigned int qid; >> +uint64_t pending = s->pending_guest_notify; >> + >> +s->pend

Re: [Qemu-devel] [RFC V2 00/10] cpu: add device_add foo-x86_64-cpu and i386 cpu hot remove support

2014-11-11 Thread Gu Zheng
Hi Igor, As your hot-plug rework has been merged in upstream, and we need to respin the i386 cpu hot remove a lot based on the latest tree. So I want to split the series into two parts: Part 1/2: add device_add foo-x86_64-cpu support. Part 2/2: i386 cpu hot remove support. , which will be easy to r

Re: [Qemu-devel] [RFC V2 00/10] cpu: add device_add foo-x86_64-cpu and i386 cpu hot remove support

2014-11-11 Thread Gu Zheng
Hi Igor, As your hot-plug rework has been merged in upstream, and we need to respin the i386 cpu hot remove a lot based on the latest tree. So I want to split the series into two parts: Part 1/2: add device_add foo-x86_64-cpu support. Part 2/2: i386 cpu hot remove support. , which will be easy to r

Re: [Qemu-devel] What "opaque" stand for?

2014-11-11 Thread Kaiyuan
> -Origin email- > From: Peter Maydell > Sent Time: Monday, November 10, 2014 > To: Kaiyuan > Cc: QEMU Developers > Subject: Re: Re: [Qemu-devel] What "opaque" stand for? > > On 10 November 2014 07:33, Kaiyuan wrote: > > Thanks for your explanation, Peter. In this case of > > timer_re

[Qemu-devel] [PATCH v1 15/15] android-console: Add power capacity command

2014-11-11 Thread Greg Bellows
Add the Android emulator console "power capacity" command along associated help messages. The "capacity" command allows the battery capacity of the device to be manipulated. Signed-off-by: Greg Bellows --- android-commands.h | 7 +++ android-console.c | 26 ++ andr

[Qemu-devel] [PATCH v1 14/15] android-console: Add power health command

2014-11-11 Thread Greg Bellows
Add the Android emulator console "power health" command and associated help messages. The "health" command allows the battery health of the device to be manipulated. Signed-off-by: Greg Bellows --- android-commands.h | 7 +++ android-console.c | 47

[Qemu-devel] [PATCH v1 12/15] android-console: Add power status command

2014-11-11 Thread Greg Bellows
Add the Android emulator console "power status" command and associated help messages. The "status" command allows the battery status of the device to be manipulated. Signed-off-by: Greg Bellows --- android-commands.h | 7 +++ android-console.c | 39 +++

[Qemu-devel] [PATCH v1 10/15] android-console: Add GF battery property getter

2014-11-11 Thread Greg Bellows
Add a function for acquiring each of the goldfish battery properties. Signed-off-by: Greg Bellows --- android-commands.h | 7 +++ android-console.c | 20 ++ android-console.h | 1 + hw/misc/goldfish_battery.c | 42 ++

[Qemu-devel] [PATCH v1 08/15] android-console: Add header for battery externs

2014-11-11 Thread Greg Bellows
Added goldfish_battery.h to share power and battery constants and externs between the Goldfish battery code and the Android console code. Signed-off-by: Greg Bellows --- hw/misc/goldfish_battery.c | 4 +-- include/hw/misc/goldfish_battery.h | 71 ++ 2

[Qemu-devel] [PATCH v1 13/15] android-console: Add power present command

2014-11-11 Thread Greg Bellows
Add the Android emulator console "power present" command and associated help messages. The "present" command allows the battery presence in the device to be manipulated. Signed-off-by: Greg Bellows --- android-commands.h | 7 +++ android-console.c | 23 +++ android-con

[Qemu-devel] [PATCH v1 04/15] android-console: Consolidate redir help text

2014-11-11 Thread Greg Bellows
Consolidated the Android emulator console help text for the redir command to make the hndler functions more readable. This establishes the pattern to be used for each command added in the future. Signed-off-by: Greg Bellows --- android-console.c | 50 ++--

[Qemu-devel] [PATCH v1 11/15] android-console: Add power ac command

2014-11-11 Thread Greg Bellows
Add the Android emulator console "power ac" along with the associated help messages. The "ac" command allows the power supply state of the device to be manipulated. Signed-off-by: Greg Bellows --- android-commands.h | 7 +++ android-console.c | 23 +++ android-console.

[Qemu-devel] [PATCH v1 09/15] android-console: Add GF battery prop print func

2014-11-11 Thread Greg Bellows
Add a function for printing out the Goldfish battery properties to the android console. Signed-off-by: Greg Bellows --- hw/misc/goldfish_battery.c | 54 ++ include/hw/misc/goldfish_battery.h | 2 ++ 2 files changed, 56 insertions(+) diff --git a/hw/m

[Qemu-devel] [PATCH v1 07/15] android-console: Init the battery ID state field

2014-11-11 Thread Greg Bellows
Adds initialization of the battery ID field so that it is discoverable by name (ID) when needed by power commands. Signed-off-by: Greg Bellows --- hw/misc/goldfish_battery.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/misc/goldfish_battery.c b/hw/misc/goldfish_battery.c index a0b

[Qemu-devel] [PATCH v1 02/15] android-console: Unify available commands output

2014-11-11 Thread Greg Bellows
Moved the "available commands" print output to the top level help command handler to avoid repitition across all commands with sub-commands. Adjusted the redir command handler to no longer print out available commands. Adjusted "OK" message to be shared by all cases to avoid duplicates. Signed-of

[Qemu-devel] [PATCH v1 05/15] android-console: Add console base power command

2014-11-11 Thread Greg Bellows
Added the base Android emulator console power command and infrastructure for adding sub-commands. Signed-off-by: Greg Bellows --- android-commands.h | 11 +++ android-console.c | 16 android-console.h | 2 ++ 3 files changed, 29 insertions(+) diff --git a/android-com

[Qemu-devel] [PATCH v1 03/15] android-console: Remove extra redir help message

2014-11-11 Thread Greg Bellows
Removed an extraneous message in the redir command help. The message is not part of the standard Android emulator output. Signed-off-by: Greg Bellows --- android-console.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/android-console.c b/android-console.c index be573b5..2de4a0c 100644 --

[Qemu-devel] [PATCH v1 06/15] android-console: Add missing hw_has_battery prop

2014-11-11 Thread Greg Bellows
Added the missing hw_has_battery property to the Goldfish batter state. This property indicates whether the device has a battery and controls whether some power commands are available. In the Android emulator this property is acquired from the AVD for the device. For now, this is wired as always

[Qemu-devel] [PATCH v1 01/15] android-console: Fix goldfish audio misnaming

2014-11-11 Thread Greg Bellows
Replaced goldfish_audio misnaming to goldfish_battery where appropriate in goldfish_battery.c Signed-off-by: Greg Bellows --- hw/misc/goldfish_battery.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/misc/goldfish_battery.c b/hw/misc/goldfish_battery.c index 03

[Qemu-devel] [PATCH v1 00/15] android-console: Add console power command

2014-11-11 Thread Greg Bellows
This patchset includes 3 changes: - Fixes to the existing Android emulator console. - Restructure the emulator console redir help output - Add support for the emulator console power command Greg Bellows (15): android-console: Fix goldfish audio misnaming android-console: Unify available comman

Re: [Qemu-devel] Better Cortex-M support?

2014-11-11 Thread Peter Maydell
On 11 November 2014 21:56, Liviu Ionescu wrote: > I fixed the semihosting/gdb problems, and I added some cosmetic > features (like some verbosity, accept to load image via GDB > without -kernel, some option aliases). > Next I plan to add support for new boards, mainly STM32F ones, > probably star

[Qemu-devel] [ANNOUNCE] QEMU 2.2.0-rc1 is now available

2014-11-11 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the second release candidate for the QEMU 2.2 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-2.2.0-rc1.tar.bz2 You can help i

Re: [Qemu-devel] Better Cortex-M support?

2014-11-11 Thread Liviu Ionescu
On 28 Oct 2014, at 12:43, Liviu Ionescu wrote: > ... GNU ARM Eclipse plug-ins (http://gnuarmeclipse.livius.net/blog/), and I'm > considering, for the mid-term future, adding a new debugging plug-in to run > certain tests under un emulator I did the first steps towards this, I added a branch o

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-11 Thread Christoffer Dall
On Tue, Nov 11, 2014 at 04:48:07PM +, Mark Rutland wrote: > Hi Christoffer, > > On Tue, Nov 11, 2014 at 04:31:01PM +, Christoffer Dall wrote: > > On Tue, Nov 11, 2014 at 03:29:33PM +, Mark Rutland wrote: > > > Hi, > > > > > > On Thu, Nov 06, 2014 at 01:33:20PM +, Alexander Spyrida

Re: [Qemu-devel] [PATCH 17/21] qcow2: Use intermediate helper CB for amend

2014-11-11 Thread Eric Blake
On 11/10/2014 06:45 AM, Max Reitz wrote: > If there is more than one time-consuming operation to be performed for > qcow2_amend_options(), we need an intermediate CB which coordinates the > progress of the individual operations and passes the result to the > original status callback. > > Signed-of

Re: [Qemu-devel] [PATCH 21/21] iotests: Add test for different refcount widths

2014-11-11 Thread Eric Blake
On 11/10/2014 06:45 AM, Max Reitz wrote: > Add a test for conversion between different refcount widths and errors > specific to certain widths (i.e. snapshots with refcount_width=1). > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/112 | 225 >

Re: [Qemu-devel] [PATCH 05/21] qcow2: Refcount overflow and qcow2_alloc_bytes()

2014-11-11 Thread Eric Blake
On 11/11/2014 09:18 AM, Max Reitz wrote: >> No, I was envisioning that we have a brand new image with one cluster >> allocated (cluster 1 has refcount 1), then 5 times in a row we do >> 'savevm' to take an internal snapshot. If I understand your code >> correctly, the first two snapshots increase

[Qemu-devel] [PATCH v2 1/3] vl: Avoid unnecessary 'if' nesting

2014-11-11 Thread Eduardo Habkost
Just a coding style change, to make other changes easier to review. Signed-off-by: Eduardo Habkost --- vl.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/vl.c b/vl.c index f4a6e5e..c1bfc9b 100644 --- a/vl.c +++ b/vl.c @@ -1284,13 +1284,11 @@ static void smp_parse

[Qemu-devel] [PATCH v2 3/3] vl: Don't silently change topology when all -smp options were set

2014-11-11 Thread Eduardo Habkost
QEMU tries to change the "threads" option even if it was explicitly set in the command-line, and it shouldn't do that. The right thing to do when all options (cpus, sockets, cores, threds) are explicitly set is to sanity check them and abort in case they don't make sense (i.e. when sockets*cores*t

[Qemu-devel] [PATCH v2 2/3] vl: fix max_cpus check

2014-11-11 Thread Eduardo Habkost
From: Andrew Jones We should confirm max_cpus, which is >= smp_cpus, is <= the machine's true max_cpus, not just smp_cpus. Signed-off-by: Andrew Jones Reviewed-by: Eduardo Habkost Signed-off-by: Eduardo Habkost --- vl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/

[Qemu-devel] [PATCH v2 0/3] vl: smp_parse sanity checks

2014-11-11 Thread Eduardo Habkost
>From the original series sent by Andrew, only patch 1/3 was kept. Patch 2/3 from v1 was replaced by a safer fix. Patch 3/3 was removed because it generates a warning even on the most common use-case ("-smp " without any extra options). Andrew Jones (1): vl: fix max_cpus check Eduardo Habkost (

Re: [Qemu-devel] [PATCH 2/3] vl: sanity check cpu topology

2014-11-11 Thread Eduardo Habkost
On Tue, Nov 11, 2014 at 03:37:11PM +0100, Andrew Jones wrote: [...] > Below is a v2 I can post if it looks good to you. > > From: Andrew Jones > Date: Fri, 7 Nov 2014 15:45:07 +0100 > Subject: [PATCH v2] vl: sanity check cpu topology > > smp_parse allows partial or complete cpu topology to be gi

Re: [Qemu-devel] [PATCH 16/21] qcow2: Split upgrade/downgrade paths for amend

2014-11-11 Thread Eric Blake
On 11/10/2014 06:45 AM, Max Reitz wrote: > If the image version should be upgraded, that is the first we should do; > if it should be downgraded, that is the last we should do. So split the > version change block into an upgrade part at the start and a downgrade > part at the end. > > Signed-off-b

Re: [Qemu-devel] [PATCH 15/21] qcow2: Use abort() instead of assert(false)

2014-11-11 Thread Eric Blake
On 11/10/2014 06:45 AM, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > block/qcow2.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake Is it worth hoisting this one into 2.2 via the -trivial tree? > > diff --git a/block/qcow2.c b/block/qcow2.c > index b

Re: [Qemu-devel] [PATCH 14/21] qcow2: Use error_report() in qcow2_amend_options()

2014-11-11 Thread Eric Blake
On 11/10/2014 06:45 AM, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > block/qcow2.c | 14 ++ > tests/qemu-iotests/061.out | 14 +++--- > 2 files changed, 13 insertions(+), 15 deletions(-) > > diff --git a/block/qcow2.c b/block/qcow2.c > index 21a1883..beb71

Re: [Qemu-devel] [PATCH 13/21] block: Add opaque value to the amend CB

2014-11-11 Thread Eric Blake
On 11/10/2014 06:45 AM, Max Reitz wrote: > Add an opaque value which is to be passed to the bdrv_amend_options() > status callback. > > Signed-off-by: Max Reitz > --- > block.c | 4 ++-- > block/qcow2-cluster.c | 14 -- > block/qcow2.c | 9 +---

Re: [Qemu-devel] [PATCH 12/21] qcow2: Allow creation with refcount order != 4

2014-11-11 Thread Eric Blake
On 11/10/2014 06:45 AM, Max Reitz wrote: > Add a creation option to qcow2 for setting the refcount order of images > to be created, and respect that option's value. > > This breaks some test outputs, fix them. > > Signed-off-by: Max Reitz > --- > block/qcow2.c | 20 > inc

Re: [Qemu-devel] [PATCH 11/21] iotests: Prepare for refcount_width option

2014-11-11 Thread Eric Blake
On 11/10/2014 06:45 AM, Max Reitz wrote: > Some tests do not work well with certain refcount widths (i.e. you > cannot create internal snapshots with refcount_width=1), so make those > widths unsupported. > > Furthermore, add another filter to _filter_img_create in common.filter > which filters ou

Re: [Qemu-devel] [PATCH v1 2/2] virtio-scsi: dataplane: notify guest as batch

2014-11-11 Thread Stefan Hajnoczi
On Tue, Nov 11, 2014 at 09:17:10AM +0800, Ming Lei wrote: > +static void notify_guest_bh(void *opaque) > +{ > +VirtIOSCSI *s = opaque; > +unsigned int qid; > +uint64_t pending = s->pending_guest_notify; > + > +s->pending_guest_notify = 0; > + > +while ((qid = ffsl(pending))) { >

Re: [Qemu-devel] uniquely identifying KDUMP files that originate from QEMU

2014-11-11 Thread Christopher Covington
On 11/11/2014 06:22 AM, Laszlo Ersek wrote: > (Note: I'm not subscribed to either qemu-devel or the kexec list; please > keep me CC'd.) > > QEMU is able to dump the guest's memory in KDUMP format (kdump-zlib, > kdump-lzo, kdump-snappy) with the "dump-guest-memory" QMP command. > > The resultant v

Re: [Qemu-devel] [PATCH 2/3] vl: sanity check cpu topology

2014-11-11 Thread Eduardo Habkost
On Tue, Nov 11, 2014 at 06:04:18PM +0100, Andrew Jones wrote: > On Tue, Nov 11, 2014 at 01:48:00PM -0200, Eduardo Habkost wrote: > > On Tue, Nov 11, 2014 at 03:37:11PM +0100, Andrew Jones wrote: > > > On Tue, Nov 11, 2014 at 10:41:00AM -0200, Eduardo Habkost wrote: > > > > On Fri, Nov 07, 2014 at 0

Re: [Qemu-devel] [PULL 0/2] seccomp branch queue

2014-11-11 Thread Peter Maydell
t; > Update version for v2.2.0-rc0 release (2014-11-05 15:21:04 +) > > are available in the git repository at: > > git://github.com/otubo/qemu.git tags/pull-seccomp-2014 > > for you to fetch changes up to 4cc47f8b3cc4f32586ba2f7fce1dc267da774a69: > > seccomp:

Re: [Qemu-devel] [PATCH] ahci: Fix byte count regression for ATAPI/PIO

2014-11-11 Thread Stefan Hajnoczi
On Mon, Nov 10, 2014 at 07:41:40PM -0500, John Snow wrote: > This patch fixes a regression caused by commit > 659142ecf71a0da240ab0ff7cf929ee25c32b9bc. > The problem occurs when we wish to return early > from the ahci_start_transfer function, but are now > updating the transferred byte count in the

Re: [Qemu-devel] [PATCH v2] target-i386: move generic memory hotplug methods to DSDTs

2014-11-11 Thread Paolo Bonzini
On 15/10/2014 09:45, Paolo Bonzini wrote: > This makes it simpler to keep the SSDT byte-for-byte identical for a > given machine type, which is a goal we want to have for 2.2 and newer > types. > > Signed-off-by: Paolo Bonzini > --- > v1->v2: do not define the same Device twice (Igor) >

Re: [Qemu-devel] [PATCH v2 0/3] Migration-safe ACPI table sizing algorithm

2014-11-11 Thread Paolo Bonzini
On 06/10/2014 16:56, Paolo Bonzini wrote: > In the emergency last-minute patches of QEMU 2.1 we did two things: > > - fixed migration problems from 1.7 or 2.0 to 2.1 due to changes in > ACPI table sizes > > - ensured that future versions will not break migration compatibility > with 2.2 for

Re: [Qemu-devel] [RFC PATCH] virtio-mmio: support for multiple irqs

2014-11-11 Thread Pawel Moll
On Tue, 2014-11-04 at 09:35 +, Shannon Zhao wrote: > As the current virtio-mmio only support single irq, > so some advanced features such as vhost-net with irqfd > are not supported. And the net performance is not > the best without vhost-net and irqfd supporting. Could you, please, help under

Re: [Qemu-devel] [PATCH 2/3] vl: sanity check cpu topology

2014-11-11 Thread Andrew Jones
On Tue, Nov 11, 2014 at 01:48:00PM -0200, Eduardo Habkost wrote: > On Tue, Nov 11, 2014 at 03:37:11PM +0100, Andrew Jones wrote: > > On Tue, Nov 11, 2014 at 10:41:00AM -0200, Eduardo Habkost wrote: > > > On Fri, Nov 07, 2014 at 05:04:39PM +0100, Andrew Jones wrote: > > > > smp_parse allows partial

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-11 Thread Mark Rutland
Hi Christoffer, On Tue, Nov 11, 2014 at 04:31:01PM +, Christoffer Dall wrote: > On Tue, Nov 11, 2014 at 03:29:33PM +, Mark Rutland wrote: > > Hi, > > > > On Thu, Nov 06, 2014 at 01:33:20PM +, Alexander Spyridakis wrote: > > > On 6 November 2014 14:44, Peter Maydell wrote: > > > > > >

[Qemu-devel] [PATCH 2.3 0/8] Linked list for tcg ops

2014-11-11 Thread Richard Henderson
Currently tcg ops are simply placed in a buffer in order. Which is fine until we want to actually do something with the opcode stream, such as optimize them. Note the horrible things like call opcodes needing their argument count both prefixed and postfixed so that we can iterate across the call

[Qemu-devel] [PATCH 2.3 3/8] tcg: Move emit of INDEX_op_end into gen_tb_end

2014-11-11 Thread Richard Henderson
Signed-off-by: Richard Henderson --- include/exec/gen-icount.h | 2 ++ target-alpha/translate.c | 2 +- target-arm/translate-a64.c| 1 - target-arm/translate.c| 1 - target-cris/translate.c | 2 +- target-i386/translate.c | 2 +- target-lm32/translate.c | 2

[Qemu-devel] [PATCH 2.3 7/8] tcg: Implement insert_op_before

2014-11-11 Thread Richard Henderson
Rather reserving space in the op stream for optimization, let the optimizer add ops as necessary. Signed-off-by: Richard Henderson --- tcg/optimize.c | 57 +++-- tcg/tcg-op.c | 16 2 files changed, 35 insertions(+), 38 deleti

Re: [Qemu-devel] [PULL 0/2] seccomp branch queue

2014-11-11 Thread Eduardo Otubo
On Mon, Nov 10, 2014 at 08:50:07PM +, Peter Maydell wrote: > On 10 November 2014 14:21, Eduardo Otubo > wrote: > > Hi, > > > > This is the seccomp branch queue with fixes regarding a build crach on > > armv7l > > and adding new syscalls to the whitelist. Details below. > > > > The following

[Qemu-devel] [PATCH 2.3 5/8] tcg: Put opcodes in a linked list

2014-11-11 Thread Richard Henderson
The previous setup required ops and args to be completely sequential, and was error prone when it came to both iteration and optimization. Signed-off-by: Richard Henderson --- include/exec/gen-icount.h | 22 ++- tcg/optimize.c| 286 ++- tcg/tcg-op.c

[Qemu-devel] [PATCH 2.3 6/8] tcg: Remove opcodes instead of noping them out

2014-11-11 Thread Richard Henderson
With the linked list scheme we need not leave nops in the stream that we need to process later. Signed-off-by: Richard Henderson --- tcg/optimize.c | 14 +++--- tcg/tcg.c | 28 tcg/tcg.h | 1 + 3 files changed, 32 insertions(+), 11 deletions(-) di

[Qemu-devel] [PATCH 2.3 8/8] tcg: Remove unused opcodes

2014-11-11 Thread Richard Henderson
We no longer need INDEX_op_end to terminate the list, nor do we need 5 forms of nop, since we just remove the TCGOp instead. Signed-off-by: Richard Henderson --- tcg/tcg-opc.h | 9 - tcg/tcg.c | 10 -- tci.c | 13 - 3 files changed, 4 insertions(+), 28 de

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-11 Thread Christoffer Dall
On Tue, Nov 11, 2014 at 03:29:33PM +, Mark Rutland wrote: > Hi, > > On Thu, Nov 06, 2014 at 01:33:20PM +, Alexander Spyridakis wrote: > > On 6 November 2014 14:44, Peter Maydell wrote: > > > > > > > > > > We need ACPI guest support in QEMU for AArch64 over here, with all > > > > features

[Qemu-devel] [PATCH 2.3 2/8] tcg: Reduce ifdefs in tcg-op.c

2014-11-11 Thread Richard Henderson
Almost completely eliminates the ifdefs in this file, improving confidence in the lesser used 32-bit builds. Signed-off-by: Richard Henderson --- tcg/tcg-op.c | 449 +++ 1 file changed, 207 insertions(+), 242 deletions(-) diff --git a/tcg/

[Qemu-devel] [PATCH 2.3 4/8] tcg: Introduce tcg_op_buf_count and tcg_op_buf_full

2014-11-11 Thread Richard Henderson
The method by which we count the number of ops emitted is going to change. Abstract that away into some inlines. Signed-off-by: Richard Henderson --- target-alpha/translate.c | 14 +++--- target-arm/translate-a64.c| 9 +++-- target-arm/translate.c| 9 +++-- ta

[Qemu-devel] [PULL 1/2] seccomp: whitelist syscalls fallocate(), fadvise64(), inotify_init1() and inotify_add_watch()

2014-11-11 Thread Eduardo Otubo
From: Philipp Gesang fallocate() is needed for snapshotting. If it isn’t whitelisted $ qemu-img create -f qcow2 x.qcow 1G Formatting 'x.qcow', fmt=qcow2 size=1073741824 encryption=off cluster_size=65536 lazy_refcounts=off $ qemu-kvm -display none -monitor stdio -sandbox on x.qcow

[Qemu-devel] [PULL 0/2] seccomp branch queue

2014-11-11 Thread Eduardo Otubo
available in the git repository at: git://github.com/otubo/qemu.git tags/pull-seccomp-2014 for you to fetch changes up to 4cc47f8b3cc4f32586ba2f7fce1dc267da774a69: seccomp: change configure to avoid arm 32 to break (2014-11-11 17:05:21 +0100

[Qemu-devel] [PULL 2/2] seccomp: change configure to avoid arm 32 to break

2014-11-11 Thread Eduardo Otubo
Current stable version of libseccomp (2.1.1) only supports i386 and x86_64 archs correctly. This patch limits the usage of the syscall filter for those archs and updates to the correct last version of libseccomp. This patch also fixes the bug: https://bugs.launchpad.net/qemu/+bug/1363641 Signed-o

Re: [Qemu-devel] [PATCH 05/21] qcow2: Refcount overflow and qcow2_alloc_bytes()

2014-11-11 Thread Max Reitz
On 2014-11-11 at 17:13, Eric Blake wrote: On 11/11/2014 01:22 AM, Max Reitz wrote: On 2014-11-10 at 22:12, Eric Blake wrote: On 11/10/2014 06:45 AM, Max Reitz wrote: qcow2_alloc_bytes() may reuse a cluster multiple times, in which case the refcount is increased accordingly. However, if this wo

Re: [Qemu-devel] [PATCH 05/21] qcow2: Refcount overflow and qcow2_alloc_bytes()

2014-11-11 Thread Eric Blake
On 11/11/2014 01:22 AM, Max Reitz wrote: > On 2014-11-10 at 22:12, Eric Blake wrote: >> On 11/10/2014 06:45 AM, Max Reitz wrote: >>> qcow2_alloc_bytes() may reuse a cluster multiple times, in which case >>> the refcount is increased accordingly. However, if this would lead to an >>> overflow the fu

Re: [Qemu-devel] [PULL 00/11 for-2.2] Trivial patches for 2014-11-11

2014-11-11 Thread Peter Maydell
On 11 November 2014 14:46, Michael Tokarev wrote: > Here's another week's trivial patches pull req, for 2.2 release. > There's nothing exciting in there, but some patches are worth to > mention. > > 4/11: numa: make 'info numa' take into account hotplugged memory > this one has been pinged s

Re: [Qemu-devel] [PATCH 02/21] qcow2: Add refcount_width to format-specific info

2014-11-11 Thread Eric Blake
On 11/11/2014 01:11 AM, Max Reitz wrote: >>> +.compat = g_strdup("0.10"), >>> +.refcount_width = s->refcount_bits, >> Hmm - is it really worth displaying a constant? Since the 0.10 format >> cannot change the width from 16, I'm not sure if it adds anything t

Re: [Qemu-devel] [PATCH 2/3] vl: sanity check cpu topology

2014-11-11 Thread Eduardo Habkost
On Tue, Nov 11, 2014 at 03:37:11PM +0100, Andrew Jones wrote: > On Tue, Nov 11, 2014 at 10:41:00AM -0200, Eduardo Habkost wrote: > > On Fri, Nov 07, 2014 at 05:04:39PM +0100, Andrew Jones wrote: > > > smp_parse allows partial or complete cpu topology to be given. > > > In either case there may be i

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-11 Thread Mark Rutland
Hi, On Thu, Nov 06, 2014 at 01:33:20PM +, Alexander Spyridakis wrote: > On 6 November 2014 14:44, Peter Maydell wrote: > > > > > > > We need ACPI guest support in QEMU for AArch64 over here, with all > > > features > > > (including the ability to run ACPI code and add specific tables), for >

[Qemu-devel] [PATCH v6] qcow2: Buffer L1 table in snapshot refcount update

2014-11-11 Thread Max Reitz
From: Zhang Haoyu Buffer the active L1 table in qcow2_update_snapshot_refcount() in order to prevent in-place conversion of the L1 table buffer in the BDRVQcowState to big endian and back, which would lead to data corruption if that buffer was accessed concurrently. This should not happen but bet

Re: [Qemu-devel] [PATCH 2/3] s390: implement pci instructions

2014-11-11 Thread Alexander Graf
On 11.11.14 15:08, Frank Blaschka wrote: > On Tue, Nov 11, 2014 at 01:51:25PM +0100, Alexander Graf wrote: >> >> >> >>> Am 11.11.2014 um 13:39 schrieb Frank Blaschka : >>> On Tue, Nov 11, 2014 at 01:16:04PM +0100, Alexander Graf wrote: > On 11.11.14 13:10, Frank Blaschka wrote:

[Qemu-devel] [PULL 08/11] xen-hvm: Remove redundant variable 'xstate'

2014-11-11 Thread Michael Tokarev
From: Chen Gang In xen_hvm_change_state_handler(), we can pass 'opaque' with type cast to xen_main_loop_prepare() directly, there's no need to use additional variable for it. Signed-off-by: Chen Gang Acked-by: Stefano Stabellini Signed-off-by: Michael Tokarev --- xen-hvm.c |3 +-- 1 file

[Qemu-devel] [PULL 05/11] gdbstub: Add a missing case of signal number translation in gdbstub

2014-11-11 Thread Michael Tokarev
From: Martin Simmons While using qemu with gdb "target remote" to debug an application that uses fork and exec, the qemu process receives SIGSTOP every time the forked process terminates (sending SIGCHLD). This is caused by a missing call to gdb_signal_to_target in gdbstub.c, which is fixed by t

[Qemu-devel] [PULL 06/11] pc-bios: petalogix-s3adsp1800.dtb: Use 'xlnx, xps-ethernetlite-2.00.a' instead of 'xlnx, xps-ethernetlite-2.00.b'

2014-11-11 Thread Michael Tokarev
From: Chen Gang For Linux upstream kernel (e.g. 3.17-rc7), the related compatible string 'xlnx,xps-ethernetlite-2.00.a' is supported, but 'b' is not supported, so change qemu dtb file to match kernel driver. The related operation for qemu (after this patch): yum install libvirt yum instal

[Qemu-devel] [PULL 03/11] slirp/smbd: modify/set several parameters in generated smbd.conf

2014-11-11 Thread Michael Tokarev
From: Peter Wu The file sharing module should not handle printers, so disable it. The options 'load printers' and 'printing' have been available since the beginning (May 1996, commit 0e8fd3398771da2f016d72830179507f3edda51b). Option 'disable spoolss' is available since Samba 2.0.4, commit de5f42c

[Qemu-devel] [PULL 04/11] numa: make 'info numa' take into account hotplugged memory

2014-11-11 Thread Michael Tokarev
From: zhanghailiang When do memory hotplug, if there is numa node, we should add the memory size to the corresponding node memory size. It affects the result of hmp command "info numa". Reviewed-by: Igor Mammedov Signed-off-by: zhanghailiang Signed-off-by: Michael Tokarev --- include/sysemu

[Qemu-devel] [PULL 10/11] sysbus: Correct SYSTEM_BUS(obj) defines

2014-11-11 Thread Michael Tokarev
From: Gonglei Signed-off-by: Gonglei Reviewed-by: Markus Armbruster Signed-off-by: Michael Tokarev --- include/hw/sysbus.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/sysbus.h b/include/hw/sysbus.h index 9fb1782..9bddfde 100644 --- a/include/hw/sysbus.h +

[Qemu-devel] [PULL 09/11] target-i386: cpu: keeping function parameters alignment on new line

2014-11-11 Thread Michael Tokarev
From: Chen Fan Signed-off-by: Chen Fan Signed-off-by: Michael Tokarev --- target-i386/cpu.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index e4ccee1..236bbee 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -533,8

[Qemu-devel] [PULL 02/11] qemu-doc.texi: fix typos in x509 examples

2014-11-11 Thread Michael Tokarev
From: Gonglei Signed-off-by: Gonglei Signed-off-by: Michael Tokarev --- qemu-doc.texi |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-doc.texi b/qemu-doc.texi index 9973090..ad418f8 100644 --- a/qemu-doc.texi +++ b/qemu-doc.texi @@ -1631,7 +1631,7 @@ EOF # cert

[Qemu-devel] [PULL 00/11 for-2.2] Trivial patches for 2014-11-11

2014-11-11 Thread Michael Tokarev
Here's another week's trivial patches pull req, for 2.2 release. There's nothing exciting in there, but some patches are worth to mention. 4/11: numa: make 'info numa' take into account hotplugged memory this one has been pinged several times, and the numa maintainer agreed to push it us

[Qemu-devel] [PULL 01/11] icc_bus: fix typo ICC_BRIGDE -> ICC_BRIDGE

2014-11-11 Thread Michael Tokarev
From: Zhu Guihua Rename ICC_BRIGDE for better readability. Signed-off-by: Zhu Guihua Reviewed-by: Markus Armbruster Signed-off-by: Michael Tokarev --- hw/cpu/icc_bus.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/cpu/icc_bus.c b/hw/cpu/icc_bus.c index 9575fd6

[Qemu-devel] [PULL 07/11] coroutine-sigaltstack: Change jmp_buf to sigjmp_buf

2014-11-11 Thread Michael Tokarev
From: Willem Pinckaers This is a simple patch to change the type of old_env from jmp_buf to sigjmp_buf. old_env is used by sigsetjmp and as such should be a sigjmp_buf. This fixes a stack_chk fail in a OSX 32bit build. Since at least on OSX sigjmp_buf is four bytes larger then a jmpbuf, resulti

[Qemu-devel] [PULL 11/11] block: Fix comment for bdrv_co_get_block_status

2014-11-11 Thread Michael Tokarev
From: Fam Zheng It returns more information than binary, fix the comment. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz Reviewed-by: Markus Armbruster Signed-off-by: Michael Tokarev --- block.c |6 +++--- include/block/block.h |4 +++- 2 files changed, 6 insertions(+

Re: [Qemu-devel] [PATCH 2/3] vl: sanity check cpu topology

2014-11-11 Thread Andrew Jones
On Tue, Nov 11, 2014 at 10:41:00AM -0200, Eduardo Habkost wrote: > On Fri, Nov 07, 2014 at 05:04:39PM +0100, Andrew Jones wrote: > > smp_parse allows partial or complete cpu topology to be given. > > In either case there may be inconsistencies in the input which > > are currently not sounding any a

  1   2   >