> -----Original Message----- > From: Eric Blake [mailto:ebl...@redhat.com] > Sent: Tuesday, November 11, 2014 1:14 AM > To: SeokYeon Hwang; qemu-devel@nongnu.org > Cc: paolo.bonz...@gmail.com; arm...@redhat.com; mre...@redhat.com; > kongjian...@gmail.com > Subject: Re: [PATCH v3] error: passing a negative value to an os_errno is > wrong > > On 11/09/2014 10:54 PM, SeokYeon Hwang wrote: > > Added 'assert(os_errno > 0)' in 'error_set_errno()'. > > Commit message... > > > Fixed errno since it passes wrong value to 'error_set_errno()'. > > > > Signed-off-by: SeokYeon Hwang <syeon.hw...@samsung.com> > > --- > > hw/pci/pcie.c | 2 +- > > > +++ b/util/error.c > > @@ -62,6 +62,7 @@ void error_set_errno(Error **errp, int os_errno, > ErrorClass err_class, > > return; > > } > > assert(*errp == NULL); > > + assert(os_errno >= 0); > > ...does not match code. (Code is correct). > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org
You're right. Thank you.
