On 11/10/2014 06:45 AM, Max Reitz wrote: > Add a creation option to qcow2 for setting the refcount order of images > to be created, and respect that option's value. > > This breaks some test outputs, fix them. > > Signed-off-by: Max Reitz <mre...@redhat.com> > --- > block/qcow2.c | 20 ++++++++ > include/block/block_int.h | 1 + > tests/qemu-iotests/049.out | 112 > ++++++++++++++++++++++----------------------- > tests/qemu-iotests/079.out | 18 ++++---- > tests/qemu-iotests/082.out | 41 ++++++++++++++--- > tests/qemu-iotests/085.out | 38 +++++++-------- > 6 files changed, 139 insertions(+), 91 deletions(-)
Is there any .json file that needs to be modified to allow this option to be set via QMP? I guess that can be a followup. > qemu-img create -f qcow2 TEST_DIR/t.qcow2 -- 1kilobyte > -qemu-img: Invalid image size specified! You may use k, M, G, T, P or E > suffixes for > +qemu-img: Invalid image size specified! You may use k, M, G, T, P or E > suffixes for > qemu-img: kilobytes, megabytes, gigabytes, terabytes, petabytes and exabytes. Nice that you are also getting rid of trailing whitespace. Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
