[Qemu-devel] Vassili Karpov (malc)

2014-11-10 Thread Michael Tokarev
Hello. Anyone know current address of malc (who's listed as audio, ppc and ppc64 maintainer currently)? The usual address, av1...@comtv.ru, bounces with the following message: : host fe01x02-cgp.akado.ru[77.232.31.162] said: 552 av1...@comtv.ru mail receiving disabled, rejecting (in reply to

Re: [Qemu-devel] [PATCH] spice: rework mirror allocation, add no-resize fast path

2014-11-10 Thread Gerd Hoffmann
> > > > To simplify the code a mit move mirror surface allocation to > > s/mit/bit/ ? Yes. Fixed. thanks, Gerd

Re: [Qemu-devel] [PATCH v3 0/4] target-ppc: Add FWNMI support in qemu for powerKVM guests

2014-11-10 Thread Aravinda Prasad
On Tuesday 11 November 2014 08:54 AM, David Gibson wrote: > On Wed, Nov 05, 2014 at 12:42:03PM +0530, Aravinda Prasad wrote: >> This series of patches add support for fwnmi in powerKVM guests. >> >> Currently upon machine check exception, if the address in >> error belongs to guest then KVM invok

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 4/4] target-ppc: Handle ibm, nmi-register RTAS call

2014-11-10 Thread Aravinda Prasad
On Tuesday 11 November 2014 11:41 AM, David Gibson wrote: > On Tue, Nov 11, 2014 at 11:18:05AM +0530, Aravinda Prasad wrote: >> >> >> On Tuesday 11 November 2014 08:49 AM, David Gibson wrote: >>> On Thu, Nov 06, 2014 at 03:30:01PM +0530, Aravinda Prasad wrote: On Wednesday 05 November 2014 0

[Qemu-devel] [PULL 2/2] linux-user: Fix up timer id handling

2014-11-10 Thread riku . voipio
From: Alexander Graf When creating a timer handle, we give the timer id a special magic offset of 0xcafe. However, we never mask that offset out of the timer id before we start using it to dereference our timer array. So we always end up aborting timer operations because the timer id is out o

[Qemu-devel] [PULL 0/2] linux-user fixes after -rc0

2014-11-10 Thread riku . voipio
From: Riku Voipio The following changes since commit 558c2c8ddfb165a36eb95dc93125c04829d68aa7: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2014-11-10 16:28:51 +) are available in the git repository at: git://git.linaro.org/people/riku.voipio/qemu.git t

[Qemu-devel] [PULL 1/2] linux-user: Do not subtract offset from end address

2014-11-10 Thread riku . voipio
From: Tom Musta When computing the upper address of a program segment, do not subtract the offset from the virtual address; instead compute the sum of the virtual address and the memory size. Signed-off-by: Tom Musta Signed-off-by: Riku Voipio --- linux-user/elfload.c | 2 +- 1 file changed,

Re: [Qemu-devel] [PATCH v3 4/4] target-ppc: Handle ibm, nmi-register RTAS call

2014-11-10 Thread Aravinda Prasad
On Tuesday 11 November 2014 08:46 AM, David Gibson wrote: > On Wed, Nov 05, 2014 at 12:43:15PM +0530, Aravinda Prasad wrote: >> This patch adds FWNMI support in qemu for powerKVM >> guests by handling the ibm,nmi-register rtas call. >> Whenever OS issues ibm,nmi-register RTAS call, the >> machine

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 4/4] target-ppc: Handle ibm, nmi-register RTAS call

2014-11-10 Thread David Gibson
On Tue, Nov 11, 2014 at 11:18:05AM +0530, Aravinda Prasad wrote: > > > On Tuesday 11 November 2014 08:49 AM, David Gibson wrote: > > On Thu, Nov 06, 2014 at 03:30:01PM +0530, Aravinda Prasad wrote: > >> On Wednesday 05 November 2014 09:16 PM, Tom Musta wrote: > >>> On 11/5/2014 2:32 AM, Alexander

Re: [Qemu-devel] [Qemu-trivial] [PATCH] pc-bios: petalogix-s3adsp1800.dtb: Use 'xlnx, xps-ethernetlite-2.00.a' instead of 'xlnx, xps-ethernetlite-2.00.b'

2014-11-10 Thread Michael Tokarev
03.11.2014 12:26, Chen Gang wrote: > For Linux upstream kernel (e.g. 3.17-rc7), the related compatible string > 'xlnx,xps-ethernetlite-2.00.a' is supported, but 'b' is not supported, > so change qemu dtb file to match kernel driver. > > The related operation for qemu (after this patch): > >yu

Re: [Qemu-devel] [PATCH] gdbstub: Add a missing case of signal number translation in gdbstub

2014-11-10 Thread Michael Tokarev
05.11.2014 18:06, Peter Maydell wrote: [] > This version Reviewed-by: Peter Maydell > and cc'd trivial. (Somebody's going to have to manually put the > patch together with the commit message now, though.) Applied to -trivial, putting all parts together. Thanks, /mjt

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 4/4] target-ppc: Handle ibm, nmi-register RTAS call

2014-11-10 Thread Aravinda Prasad
On Tuesday 11 November 2014 08:49 AM, David Gibson wrote: > On Thu, Nov 06, 2014 at 03:30:01PM +0530, Aravinda Prasad wrote: >> On Wednesday 05 November 2014 09:16 PM, Tom Musta wrote: >>> On 11/5/2014 2:32 AM, Alexander Graf wrote: On 05.11.14 08:13, Aravinda Prasad wrote: > > [snip] >

Re: [Qemu-devel] [PATCH 10/21] qcow2: refcount_order parameter for qcow2_create2

2014-11-10 Thread Eric Blake
On 11/10/2014 06:45 AM, Max Reitz wrote: > Add a refcount_order parameter to qcow2_create2(), use that value for > the image header and for calculating the size required for > preallocation. > > For now, always pass 4. > > Signed-off-by: Max Reitz > --- > block/qcow2.c | 41

Re: [Qemu-devel] [RFC PATCH 0/8] Add Generic PCI host device update

2014-11-10 Thread Ming Lei
On Tue, Nov 11, 2014 at 11:24 AM, Ming Lei wrote: > On Mon, Nov 10, 2014 at 6:00 PM, alvise rigo > wrote: >> Hi Claudio, >> >> On Fri, Nov 7, 2014 at 4:40 PM, Claudio Fontana >> wrote: >>> >>> Hi Alvise, >>> >>> I now got to test the series for my use case, in particular to enable the >>> ARM 64

Re: [Qemu-devel] [PATCH v3 4/4] target-ppc: Handle ibm, nmi-register RTAS call

2014-11-10 Thread David Gibson
On Wed, Nov 05, 2014 at 12:43:15PM +0530, Aravinda Prasad wrote: > This patch adds FWNMI support in qemu for powerKVM > guests by handling the ibm,nmi-register rtas call. > Whenever OS issues ibm,nmi-register RTAS call, the > machine check notification address is saved and the > machine check inter

Re: [Qemu-devel] [PATCH] pc: piix4_pm: init legacy PCI hotplug when running on Xen

2014-11-10 Thread Zhang, Yang Z
Stefano Stabellini wrote on 2014-11-10: > On Mon, 10 Nov 2014, Zhang, Yang Z wrote: >> Igor Mammedov wrote on 2014-05-23: >>> if user starts QEMU with "-machine pc,accel=xen", then compat >>> property in xenfv won't work and it would cause error: >>> "Unsupported bus. Bus doesn't have property 'acp

Re: [Qemu-devel] [PATCH v3 0/4] target-ppc: Add FWNMI support in qemu for powerKVM guests

2014-11-10 Thread David Gibson
On Wed, Nov 05, 2014 at 12:42:03PM +0530, Aravinda Prasad wrote: > This series of patches add support for fwnmi in powerKVM guests. > > Currently upon machine check exception, if the address in > error belongs to guest then KVM invokes guest's NMI interrupt > vector 0x200. > > This patch series a

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 4/4] target-ppc: Handle ibm, nmi-register RTAS call

2014-11-10 Thread David Gibson
On Thu, Nov 06, 2014 at 03:30:01PM +0530, Aravinda Prasad wrote: > On Wednesday 05 November 2014 09:16 PM, Tom Musta wrote: > > On 11/5/2014 2:32 AM, Alexander Graf wrote: > >> On 05.11.14 08:13, Aravinda Prasad wrote: [snip] > >>> + /* > >>> + * ori r3,r3,KVMPPC_H_REPORT_MC_ERR. The KVMPPC_H_REP

Re: [Qemu-devel] [RFC PATCH 0/8] Add Generic PCI host device update

2014-11-10 Thread Ming Lei
On Mon, Nov 10, 2014 at 6:00 PM, alvise rigo wrote: > Hi Claudio, > > On Fri, Nov 7, 2014 at 4:40 PM, Claudio Fontana > wrote: >> >> Hi Alvise, >> >> I now got to test the series for my use case, in particular to enable the >> ARM 64bit OSv guest (OSv's devices come from pci + virtio). >> >> Coul

Re: [Qemu-devel] [PATCH v1 2/2] virtio-scsi: dataplane: notify guest as batch

2014-11-10 Thread Ming Lei
On Tue, Nov 11, 2014 at 10:52 AM, Fam Zheng wrote: > On Tue, 11/11 10:29, Ming Lei wrote: >> On Tue, Nov 11, 2014 at 9:52 AM, Fam Zheng wrote: >> > On Tue, 11/11 09:17, Ming Lei wrote: >> >> It isn't necessery to notify guest each time when one request >> >> is completed, and it should be enough

Re: [Qemu-devel] [PATCH v1 2/2] virtio-scsi: dataplane: notify guest as batch

2014-11-10 Thread Fam Zheng
On Tue, 11/11 10:29, Ming Lei wrote: > On Tue, Nov 11, 2014 at 9:52 AM, Fam Zheng wrote: > > On Tue, 11/11 09:17, Ming Lei wrote: > >> It isn't necessery to notify guest each time when one request > >> is completed, and it should be enough to just notify one time > >> for each running of virtio_sc

Re: [Qemu-devel] [PATCH v1 2/2] virtio-scsi: dataplane: notify guest as batch

2014-11-10 Thread Ming Lei
On Tue, Nov 11, 2014 at 9:52 AM, Fam Zheng wrote: > On Tue, 11/11 09:17, Ming Lei wrote: >> It isn't necessery to notify guest each time when one request >> is completed, and it should be enough to just notify one time >> for each running of virtio_scsi_iothread_handle_cmd(). >> >> This patch supr

Re: [Qemu-devel] [PATCH v4 38/47] Add assertion to check migration_dirty_pages

2014-11-10 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:44PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > I've seen it go negative once during dev, it shouldn't > happen. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: David Gibson -- David Gibson| I'll h

Re: [Qemu-devel] [PATCH v4 37/47] Page request: Consume pages off the post-copy queue

2014-11-10 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:43PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > When transmitting RAM pages, consume pages that have been queued by > MIG_RPCOMM_REQPAGE commands and send them ahead of normal page scanning. > > Note: > a) After a queued page t

Re: [Qemu-devel] [PATCH v4 39/47] postcopy_ram.c: place_page and helpers

2014-11-10 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:45PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > postcopy_place_page (etc) provide a way for postcopy to place a page > into guests memory atomically (using the new remap_anon_pages syscall). > > Signed-off-by: Dr. David Alan Gilb

Re: [Qemu-devel] [PATCH v1 2/2] virtio-scsi: dataplane: notify guest as batch

2014-11-10 Thread Fam Zheng
On Tue, 11/11 09:17, Ming Lei wrote: > It isn't necessery to notify guest each time when one request > is completed, and it should be enough to just notify one time > for each running of virtio_scsi_iothread_handle_cmd(). > > This patch supresses about 30K/sec write on eventfd. > > Signed-off-by:

Re: [Qemu-devel] [Bug 1385934] Re: USB with passthrougth guest cannot enumerate USB host

2014-11-10 Thread Gonglei
On 2014/11/11 1:52, MikeFrysinger wrote: > i've attached the `lsusb -v` output for the device. it is USB 2.0. the > sysfs speed file shows 480. > You should add an ehci controller or xhci for USB2.0 device. Please use such below cmdline: -device usb-ehci,id=ehci \ -device usb-host,bus=ehci.0,v

Re: [Qemu-devel] [PATCH v1 1/2] virtio-scsi: dataplane: fix allocation for 'cmd_vrings'

2014-11-10 Thread Fam Zheng
On Tue, 11/11 09:17, Ming Lei wrote: > The size of each element should be sizeof(VirtIOSCSIVring *). > > Signed-off-by: Ming Lei > --- > hw/scsi/virtio-scsi-dataplane.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/scsi/virtio-scsi-dataplane.c b/hw/scsi/virtio-s

[Qemu-devel] [PATCH v1 2/2] virtio-scsi: dataplane: notify guest as batch

2014-11-10 Thread Ming Lei
It isn't necessery to notify guest each time when one request is completed, and it should be enough to just notify one time for each running of virtio_scsi_iothread_handle_cmd(). This patch supresses about 30K/sec write on eventfd. Signed-off-by: Ming Lei --- hw/scsi/virtio-scsi-dataplane.c |

[Qemu-devel] [PATCH v1 0/2] virtio-scsi: dataplane: one fix and one optimization

2014-11-10 Thread Ming Lei
Hi, The 1st patch fixes an allocation problem. The 2nd one supresses writing eventfd a lot(~30K/sec in my test). V1: - use g_new() in 1/2 - avoid to dereference VIRTIO_SCSI() directly 2/2 - add build check on queue depth Thanks, Ming Lei

[Qemu-devel] [PATCH v1 1/2] virtio-scsi: dataplane: fix allocation for 'cmd_vrings'

2014-11-10 Thread Ming Lei
The size of each element should be sizeof(VirtIOSCSIVring *). Signed-off-by: Ming Lei --- hw/scsi/virtio-scsi-dataplane.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/virtio-scsi-dataplane.c b/hw/scsi/virtio-scsi-dataplane.c index 855439e..df17229 100644 --- a/h

Re: [Qemu-devel] [PATCH] usb-host: fix usb_host_speed_compat tyops

2014-11-10 Thread Gonglei
On 2014/11/10 19:15, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > hw/usb/host-libusb.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c > index 032a0e4..a5f9dab 100644 > --- a/hw/usb/host-libusb.c > +++ b/h

[Qemu-devel] [PATCH] ahci: Fix byte count regression for ATAPI/PIO

2014-11-10 Thread John Snow
This patch fixes a regression caused by commit 659142ecf71a0da240ab0ff7cf929ee25c32b9bc. The problem occurs when we wish to return early from the ahci_start_transfer function, but are now updating the transferred byte count in the AHCI command header via ahci_commit_buf. This will cause problems i

Re: [Qemu-devel] [PATCH 08/21] qcow2: More helpers for refcount modification

2014-11-10 Thread Eric Blake
On 11/10/2014 06:45 AM, Max Reitz wrote: > Add helper functions for getting and setting refcounts in a refcount > array for any possible refcount order, and choose the correct one during > refcount initialization. > > Signed-off-by: Max Reitz > --- > block/qcow2-refcount.c | 143 > +

Re: [Qemu-devel] [PATCH 07/21] qcow2: Helper for refcount array size calculation

2014-11-10 Thread Eric Blake
On 11/10/2014 06:45 AM, Max Reitz wrote: > Add a helper function which correctly calculates the byte size of a > refcount array for any refcount order, and use that function. > > Signed-off-by: Max Reitz > --- > block/qcow2-refcount.c | 39 --- > 1 file change

[Qemu-devel] [Bug 1387881] Re: qemu fails to recognize full virtualization

2014-11-10 Thread David Britton
@arges -- installation of qemu-kvm has fixed the problem. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1387881 Title: qemu fails to recognize full virtualization Status in QEMU: New Status in “

[Qemu-devel] [Bug 1387881] Re: qemu fails to recognize full virtualization

2014-11-10 Thread Chris J Arges
@Serge Gotcha, I misinterpreted your statement. Yes we are in agreement. @dpb: Have you had any further failures after installing qemu-kvm? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1387881 Titl

Re: [Qemu-devel] [PATCH 06/21] qcow2: Helper function for refcount modification

2014-11-10 Thread Eric Blake
On 11/10/2014 06:45 AM, Max Reitz wrote: > Since refcounts do not always have to be a uint16_t, all refcount blocks > and arrays in memory should not have a specific type (thus they become > pointers to void) and for accessing them, two helper functions are used > (a getter and a setter). Those fun

Re: [Qemu-devel] [PATCH] x86: Update VT-d Posted-Interrupts related information

2014-11-10 Thread Alex Williamson
On Mon, 2014-11-10 at 14:31 +0800, Feng Wu wrote: > VT-d Posted-Interrupts(PI) is an enhancement to CPU side Posted-Interrupt. > With VT-d Posted-Interrupts enabled, external interrupts from > direct-assigned devices can be delivered to guests without VMM > involvement when guest is running in non-

Re: [Qemu-devel] [PATCH] linux-user: Fix up timer id handling

2014-11-10 Thread Tom Musta
On 11/10/2014 2:33 PM, Alexander Graf wrote: > When creating a timer handle, we give the timer id a special magic offset > of 0xcafe. However, we never mask that offset out of the timer id before > we start using it to dereference our timer array. So we always end up aborting > timer operations

Re: [Qemu-devel] [PATCH 03/21] qcow2: Use 64 bits for refcount values

2014-11-10 Thread Eric Blake
On 11/10/2014 06:45 AM, Max Reitz wrote: > Refcounts may have a width of up to 64 bit, so qemu should use the same s/bit/bits/ > width to represent refcount values internally. > > Signed-off-by: Max Reitz > --- > block/qcow2-cluster.c | 9 ++--- > block/qcow2-refcount.c | 37

Re: [Qemu-devel] [PATCH 05/21] qcow2: Refcount overflow and qcow2_alloc_bytes()

2014-11-10 Thread Eric Blake
On 11/10/2014 06:45 AM, Max Reitz wrote: > qcow2_alloc_bytes() may reuse a cluster multiple times, in which case > the refcount is increased accordingly. However, if this would lead to an > overflow the function should instead just not reuse this cluster and > allocate a new one. So if recount_ord

Re: [Qemu-devel] [PULL 0/2] seccomp branch queue

2014-11-10 Thread Peter Maydell
t; > Update version for v2.2.0-rc0 release (2014-11-05 15:21:04 +) > > are available in the git repository at: > > git://github.com/otubo/qemu.git tags/pull-seccomp-20141110 > > for you to fetch changes up to f5c76d3eb66a63604d9d8b47ce94268f9babea10: > > seccomp:

Re: [Qemu-devel] [PATCH 04/21] qcow2: Respect error in qcow2_alloc_bytes()

2014-11-10 Thread Eric Blake
On 11/10/2014 06:45 AM, Max Reitz wrote: > qcow2_update_cluster_refcount() may fail, and qcow2_alloc_bytes() should > mind that case. > > Signed-off-by: Max Reitz > --- > block/qcow2-refcount.c | 32 +--- > 1 file changed, 21 insertions(+), 11 deletions(-) Reviewed-b

Re: [Qemu-devel] [PATCH] linux-user: Fix up timer id handling

2014-11-10 Thread Peter Maydell
On 10 November 2014 20:33, Alexander Graf wrote: > When creating a timer handle, we give the timer id a special magic offset > of 0xcafe. However, we never mask that offset out of the timer id before > we start using it to dereference our timer array. So we always end up aborting > timer opera

[Qemu-devel] [PATCH] linux-user: Fix up timer id handling

2014-11-10 Thread Alexander Graf
When creating a timer handle, we give the timer id a special magic offset of 0xcafe. However, we never mask that offset out of the timer id before we start using it to dereference our timer array. So we always end up aborting timer operations because the timer id is out of bounds. This was not

[Qemu-devel] [PATCH 2.2 v4] linux-user: Fix up timer id handling

2014-11-10 Thread Alexander Graf
When creating a timer handle, we give the timer id a special magic offset of 0xcafe. However, we never mask that offset out of the timer id before we start using it to dereference our timer array. So we always end up aborting timer operations because the timer id is out of bounds. This was not

Re: [Qemu-devel] [PATCHv2] esp: Do not overwrite ESP_TCHI after reset

2014-11-10 Thread Hannes Reinecke
On 11/10/2014 07:32 PM, Paolo Bonzini wrote: > On 10/11/2014 16:52, Hannes Reinecke wrote: >> After a reset ESP_TCHI should contain the unique ID >> of the chip. This value will be overwritten with the >> current tranfer count if the transfer count has >> previously been set. >> So we should always

Re: [Qemu-devel] Starting X remotely

2014-11-10 Thread Brian Jackson
On Monday, November 10, 2014 09:42:45 AM Nigel Horne wrote: > When I start any emulator remotely (i.e. I've logged into the host > machine using 'ssh -Y'), I get this error and the guest console is > unusable. All works well when I am logged in directly to the host > machine's console. I'm follow

Re: [Qemu-devel] [PATCH v2 0/9] raw: Prohibit dangerous writes for probed images

2014-11-10 Thread Eric Blake
On 11/07/2014 12:39 PM, Kevin Wolf wrote: > See the commit message of patch 7 for the why and how. This series > will probably be only part of the solution and doesn't mean that we > should stop looking for other patches which improve different parts of > the problem. I definitely agree that tackl

Re: [Qemu-devel] [PULL 0/5] Block patches for 2.2

2014-11-10 Thread Peter Maydell
On 10 November 2014 10:57, Kevin Wolf wrote: > The following changes since commit 6e76d125f244e10676b917208f2a074729820246: > > Update version for v2.2.0-rc0 release (2014-11-05 15:21:04 +) > > are available in the git repository at: > > git://repo.or.cz/qemu/kevin.git tags/for-upstream >

Re: [Qemu-devel] [PATCH v2 9/9] qemu-iotests: Test writing non-raw image headers to raw image

2014-11-10 Thread Eric Blake
On 11/07/2014 12:39 PM, Kevin Wolf wrote: > This is forbidden if the raw driver was probed. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/109 | 100 ++ > tests/qemu-iotests/109.out | 149 > + > tests/qemu-iot

Re: [Qemu-devel] [PATCH v2 8/9] qemu-iotests: Fix stderr handling in common.qemu

2014-11-10 Thread Eric Blake
On 11/07/2014 12:39 PM, Kevin Wolf wrote: > The original intention was to pipe stderr of qemu into $fifo_out. > However, the redirections were specified in the wrong order for this. > This patch fixes it. > > Now qemu's output on stderr can be retrieved with _send_qemu_cmd, which > applies several

Re: [Qemu-devel] [PATCH v2 7/9] raw: Prohibit dangerous writes for probed images

2014-11-10 Thread Eric Blake
On 11/07/2014 12:39 PM, Kevin Wolf wrote: > If the user neglects to specify the image format, QEMU probes the > image to guess it automatically, for convenience. > [for those patches in 1-6 where I did not leave comments, I'm happy with them, and saw that Max already gave R-b so I didn't spend th

Re: [Qemu-devel] [PATCH 2.2 v3] linux-user: Fix up timer id handling

2014-11-10 Thread Tom Musta
On 11/10/2014 12:21 PM, Alexander Graf wrote: > When creating a timer handle, we give the timer id a special magic offset > of 0xcafe. However, we never mask that offset out of the timer id before > we start using it to dereference our timer array. So we always end up aborting > timer operation

Re: [Qemu-devel] [PATCH v2 1/9] qemu-io: Allow explicitly specifying format

2014-11-10 Thread Eric Blake
On 11/07/2014 12:39 PM, Kevin Wolf wrote: > This adds a -f option to qemu-io which allows to explicitly specify the > block driver to use for the given image. > > Signed-off-by: Kevin Wolf > --- > qemu-io.c | 28 > 1 file changed, 20 insertions(+), 8 deletions(-) >

Re: [Qemu-devel] [PATCH v2 2/2] iotests: Plain blkdebug filename generation

2014-11-10 Thread Eric Blake
On 11/10/2014 09:59 AM, Max Reitz wrote: > Add a test whether blkdebug is able to generate a plain filename if > given a configuration file and a file to be tested only. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/099 | 9 - > tests/qemu-iotests/099.out | 4 > 2 file

Re: [Qemu-devel] [PATCH v2 1/2] blkdebug: Simplify and improve filename generation

2014-11-10 Thread Eric Blake
On 11/10/2014 09:59 AM, Max Reitz wrote: > Instead of actually recreating the options from scratch, just reuse the > options given for creating the BDS, which are the configuration file > name and additional options. In case there are no additional options we > can thus create a plain filename. >

Re: [Qemu-devel] [PATCH 02/21] qcow2: Add refcount_width to format-specific info

2014-11-10 Thread Eric Blake
On 11/10/2014 06:45 AM, Max Reitz wrote: > Add the bit width of every refcount entry to the format-specific > information. > > This breaks some test outputs, fix them. > > Signed-off-by: Max Reitz > --- > block/qcow2.c | 4 +++- > qapi/block-core.json | 5 - > tests/qem

Re: [Qemu-devel] [PATCH 01/21] qcow2: Add two new fields to BDRVQcowState

2014-11-10 Thread Eric Blake
On 11/10/2014 06:45 AM, Max Reitz wrote: > Add two new fields regarding refcount information (the bit width of > every entry and the maximum refcount value) to the BDRVQcowState. > > Signed-off-by: Max Reitz > --- > block/qcow2-refcount.c | 2 +- > block/qcow2.c | 9 + > block/q

Re: [Qemu-devel] [PATCH for-2.2] pc: acpi: mark all possible CPUs as enabled in SRAT

2014-11-10 Thread Paolo Bonzini
On 10/11/2014 19:34, Michael S. Tsirkin wrote: > > It changes the contents of the SRAT. There is a possibility that it > > triggers bugs in previously working guests. > > Absolutely but that's true for any bugfix. > We don't do compatiblity without a good reason. > > Or do you mean that you co

Re: [Qemu-devel] [PATCH for-2.2] pc: acpi: mark all possible CPUs as enabled in SRAT

2014-11-10 Thread Michael S. Tsirkin
On Mon, Nov 10, 2014 at 07:26:41PM +0100, Paolo Bonzini wrote: > > > On 10/11/2014 19:17, Michael S. Tsirkin wrote: > > > No, I mean can you do it also for pc-2.1 and earlier? Or should it be > > > only for the last machine type? > > > > I don't see why it should, it can't break migration. > >

Re: [Qemu-devel] [PATCHv2] esp: Do not overwrite ESP_TCHI after reset

2014-11-10 Thread Paolo Bonzini
On 10/11/2014 16:52, Hannes Reinecke wrote: > After a reset ESP_TCHI should contain the unique ID > of the chip. This value will be overwritten with the > current tranfer count if the transfer count has > previously been set. > So we should always return the chip id if ESP_TCHI > has never been wri

Re: [Qemu-devel] [PATCH for-2.2] pc: acpi: mark all possible CPUs as enabled in SRAT

2014-11-10 Thread Paolo Bonzini
On 10/11/2014 19:17, Michael S. Tsirkin wrote: > > No, I mean can you do it also for pc-2.1 and earlier? Or should it be > > only for the last machine type? > > I don't see why it should, it can't break migration. > It changes the contents of the SRAT. There is a possibility that it triggers

Re: [Qemu-devel] [PATCH 2.2 v3] linux-user: Fix up timer id handling

2014-11-10 Thread Peter Maydell
On 10 November 2014 18:21, Alexander Graf wrote: > When creating a timer handle, we give the timer id a special magic offset > of 0xcafe. However, we never mask that offset out of the timer id before > we start using it to dereference our timer array. So we always end up aborting > timer opera

[Qemu-devel] [PATCH 2.2 v3] linux-user: Fix up timer id handling

2014-11-10 Thread Alexander Graf
When creating a timer handle, we give the timer id a special magic offset of 0xcafe. However, we never mask that offset out of the timer id before we start using it to dereference our timer array. So we always end up aborting timer operations because the timer id is out of bounds. This was not

Re: [Qemu-devel] [PATCH for-2.2] pc: acpi: mark all possible CPUs as enabled in SRAT

2014-11-10 Thread Michael S. Tsirkin
On Mon, Nov 10, 2014 at 06:56:30PM +0100, Paolo Bonzini wrote: > > > On 10/11/2014 18:48, Igor Mammedov wrote: > >> > Does this need to be specific to pc-2.2? > > Why not, It's bug fix. > > But I don't care if it's merged later. > > No, I mean can you do it also for pc-2.1 and earlier? Or shoul

[Qemu-devel] [Bug 1385934] Re: USB with passthrougth guest cannot enumerate USB host

2014-11-10 Thread MikeFrysinger
i've attached the `lsusb -v` output for the device. it is USB 2.0. the sysfs speed file shows 480. the qemu cmdline: qemu-system-x86_64 \ -hda images/root \ -hdb images/var \ -hdc images/usr \ -append "root=/dev/hda console=ttyS0 panic=3 init=/ginit" \ -ke

Re: [Qemu-devel] [PATCH 2.2 v2 3/3] linux-user: Use target_timer_t type for timer parameters

2014-11-10 Thread Peter Maydell
On 10 November 2014 17:44, Alexander Graf wrote: > The timer_gettime and timer_settime syscalls get a timer_t parameter. Since > we now have an internal wrapper type for it, let's make use of it. > > We do not need to check for signed < 0 overflows, because we already mask out > the upper bits of

Re: [Qemu-devel] [PATCH for-2.2] pc: acpi: mark all possible CPUs as enabled in SRAT

2014-11-10 Thread Paolo Bonzini
On 10/11/2014 18:48, Igor Mammedov wrote: >> > Does this need to be specific to pc-2.2? > Why not, It's bug fix. > But I don't care if it's merged later. No, I mean can you do it also for pc-2.1 and earlier? Or should it be only for the last machine type? Paolo

Re: [Qemu-devel] [PATCH 2.2 v2 1/3] linux-user: Fix timer_create timer id return type

2014-11-10 Thread Peter Maydell
On 10 November 2014 17:44, Alexander Graf wrote: > The linux syscall to create_timer really gets an s32* parameter to store > its timer id into, not an abi_ulong*. Remove the useless struct encapsulation > and directly write the 32bit value into memory. > @@ -9601,11 +9600,9 @@ abi_long do_syscal

Re: [Qemu-devel] [PATCH] linux-user: Do not subtract offset from end address

2014-11-10 Thread Tom Musta
On 11/8/2014 6:22 PM, Andreas Färber wrote: > Am 06.11.2014 um 20:43 schrieb Tom Musta: >> When computing the upper address of a program segment, do not subtract the >> offset from the virtual address; instead compute the sum of the virtual >> address >> and the memory size. > > Note that this re

Re: [Qemu-devel] [PATCH for-2.2] pc: acpi: mark all possible CPUs as enabled in SRAT

2014-11-10 Thread Igor Mammedov
On Mon, 10 Nov 2014 18:40:12 +0100 Paolo Bonzini wrote: > > > On 10/11/2014 17:20, Igor Mammedov wrote: > > If QEMU is started with -numa ... Windows only notices that > > CPU has been hot-added but it will not online such CPUs. > > > > It's caused by the fact that possible CPUs are flagged a

[Qemu-devel] [PATCH 2.2 v2 2/3] linux-user: Properly handle timer magic offset

2014-11-10 Thread Alexander Graf
When creating a timer handle, we give the timer id a special magic offset of 0xcafe. However, we never mask that offset out of the timer id before we start using it to dereference our timer array. So we always end up aborting timer operations because the timer id is out of bounds. This was not

[Qemu-devel] [PATCH 2.2 v2 3/3] linux-user: Use target_timer_t type for timer parameters

2014-11-10 Thread Alexander Graf
The timer_gettime and timer_settime syscalls get a timer_t parameter. Since we now have an internal wrapper type for it, let's make use of it. We do not need to check for signed < 0 overflows, because we already mask out the upper bits of the value, rendering the number always unsigned. Signed-of

[Qemu-devel] [PATCH 2.2 v2 1/3] linux-user: Fix timer_create timer id return type

2014-11-10 Thread Alexander Graf
The linux syscall to create_timer really gets an s32* parameter to store its timer id into, not an abi_ulong*. Remove the useless struct encapsulation and directly write the 32bit value into memory. Signed-off-by: Alexander Graf --- linux-user/syscall.c | 5 + linux-user/syscall_defs.h

[Qemu-devel] [PATCH 2.2 v2 0/3] linux-user: Fix posix timer implementation

2014-11-10 Thread Alexander Graf
Tom recently realized that I accidently broke the posix timer functions. With his simple test program he was able to show that we indeed do break posix timers since my last commit touching them: http://csgraf.de/agraf/timer.c These two patches fix it up properly. With these I can successfully r

Re: [Qemu-devel] [PATCH for-2.2] pc: acpi: mark all possible CPUs as enabled in SRAT

2014-11-10 Thread Paolo Bonzini
On 10/11/2014 17:20, Igor Mammedov wrote: > If QEMU is started with -numa ... Windows only notices that > CPU has been hot-added but it will not online such CPUs. > > It's caused by the fact that possible CPUs are flagged as > not enabled in SRAT and Windows honoring that information > doesn't

Re: [Qemu-devel] [PATCH 09/21] qcow2: Open images with refcount order != 4

2014-11-10 Thread Max Reitz
On 2014-11-10 at 18:03, Eric Blake wrote: On 11/10/2014 06:45 AM, Max Reitz wrote: No longer refuse to open images with a different refcount entry width than 16 bits; only reject images with a refcount width larger than 64 bits (which is prohibited by the specification). Signed-off-by: Max Reit

Re: [Qemu-devel] [PATCH v2 0/2] block: Improve filename generation for blkdebug

2014-11-10 Thread Max Reitz
On 2014-11-10 at 17:59, Max Reitz wrote: This is technically a v2 to "block: Fix filename generation for blkdebug and nbd" which contained a fix for the NBD filename generation, which has been merged into master by now. The rest, however, has not been yet, due to lack of reviews. Instead of ping

Re: [Qemu-devel] [PATCH 09/21] qcow2: Open images with refcount order != 4

2014-11-10 Thread Eric Blake
On 11/10/2014 06:45 AM, Max Reitz wrote: > No longer refuse to open images with a different refcount entry width > than 16 bits; only reject images with a refcount width larger than 64 > bits (which is prohibited by the specification). > > Signed-off-by: Max Reitz > --- > block/qcow2.c | 8 -

Re: [Qemu-devel] [PATCH 2.2 2/2] linux-user: Properly handle timer magic offset

2014-11-10 Thread Alexander Graf
On 10.11.14 17:55, Peter Maydell wrote: > On 10 November 2014 16:46, Alexander Graf wrote: >> When creating a timer handle, we give the timer id a special magic offset >> of 0xcafe. However, we never mask that offset out of the timer id before >> we start using it to dereference our timer ar

[Qemu-devel] [PATCH v2 1/2] blkdebug: Simplify and improve filename generation

2014-11-10 Thread Max Reitz
Instead of actually recreating the options from scratch, just reuse the options given for creating the BDS, which are the configuration file name and additional options. In case there are no additional options we can thus create a plain filename. This obviously results in a different output for qe

[Qemu-devel] [PATCH v2 2/2] iotests: Plain blkdebug filename generation

2014-11-10 Thread Max Reitz
Add a test whether blkdebug is able to generate a plain filename if given a configuration file and a file to be tested only. Signed-off-by: Max Reitz --- tests/qemu-iotests/099 | 9 - tests/qemu-iotests/099.out | 4 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/

[Qemu-devel] [PATCH v2 0/2] block: Improve filename generation for blkdebug

2014-11-10 Thread Max Reitz
This is technically a v2 to "block: Fix filename generation for blkdebug and nbd" which contained a fix for the NBD filename generation, which has been merged into master by now. The rest, however, has not been yet, due to lack of reviews. Instead of pinging an old series with an already merged pa

Re: [Qemu-devel] [PATCH 2.2 2/2] linux-user: Properly handle timer magic offset

2014-11-10 Thread Peter Maydell
On 10 November 2014 16:46, Alexander Graf wrote: > When creating a timer handle, we give the timer id a special magic offset > of 0xcafe. However, we never mask that offset out of the timer id before > we start using it to dereference our timer array. So we always end up aborting > timer opera

[Qemu-devel] [PATCH 2.2 0/2] linux-user: Fix posix timer implementation

2014-11-10 Thread Alexander Graf
Tom recently realized that I accidently broke the posix timer functions. With his simple test program he was able to show that we indeed do break posix timers since my last commit touching them: http://csgraf.de/agraf/timer.c These two patches fix it up properly. With these I can successfully r

[Qemu-devel] [PATCH 2.2 1/2] linux-user: Fix timer creation tswap

2014-11-10 Thread Alexander Graf
The timer pointer field we're writing a new timer ID into is of field abi_ulong which means we need to swab 64bits on 64bit ABI targets. Change the tswap from 32 to l to give us correct foreign-endian results. Signed-off-by: Alexander Graf --- linux-user/syscall.c | 2 +- 1 file changed, 1 inse

[Qemu-devel] [PATCH 2.2 2/2] linux-user: Properly handle timer magic offset

2014-11-10 Thread Alexander Graf
When creating a timer handle, we give the timer id a special magic offset of 0xcafe. However, we never mask that offset out of the timer id before we start using it to dereference our timer array. So we always end up aborting timer operations because the timer id is out of bounds. This was not

Re: [Qemu-devel] [PULL 0/5] s390x fixes for 2.2

2014-11-10 Thread Peter Maydell
On 10 November 2014 09:17, Christian Borntraeger wrote: > Am 05.11.2014 um 16:48 schrieb Cornelia Huck: >> The following changes since commit 6e76d125f244e10676b917208f2a074729820246: >> >> Update version for v2.2.0-rc0 release (2014-11-05 15:21:04 +) >> >> are available in the git repositor

[Qemu-devel] [PATCH for-2.2] pc: acpi: mark all possible CPUs as enabled in SRAT

2014-11-10 Thread Igor Mammedov
If QEMU is started with -numa ... Windows only notices that CPU has been hot-added but it will not online such CPUs. It's caused by the fact that possible CPUs are flagged as not enabled in SRAT and Windows honoring that information doesn't use corresponding CPU. ACPI 5.0 Spec regarding to flag

Re: [Qemu-devel] [PATCH v3] error: passing a negative value to an os_errno is wrong

2014-11-10 Thread Eric Blake
On 11/09/2014 10:54 PM, SeokYeon Hwang wrote: > Added 'assert(os_errno > 0)' in 'error_set_errno()'. Commit message... > Fixed errno since it passes wrong value to 'error_set_errno()'. > > Signed-off-by: SeokYeon Hwang > --- > hw/pci/pcie.c | 2 +- > +++ b/util/error.c > @@ -62,6 +62,7 @@ void

Re: [Qemu-devel] [PATCH v2 16/16] hw/intc/arm_gic: add gic_update() for grouping

2014-11-10 Thread Christoffer Dall
On Mon, Nov 10, 2014 at 3:43 PM, Greg Bellows wrote: [...] > On 7 November 2014 06:44, Daniel Thompson > wrote: >> >> On 30/10/14 22:12, Greg Bellows wrote: >> > From: Fabian Aggeler >> > >> > GICs with grouping (GICv2 or GICv1 with Security Extensions) have a >> > different exception generatio

Re: [Qemu-devel] [PATCH] spice: rework mirror allocation, add no-resize fast path

2014-11-10 Thread Eric Blake
On 11/10/2014 04:23 AM, Gerd Hoffmann wrote: > Add fast path to qemu_spice_display_switch in case old and new > displaysurface have identical size (happens with display panning > and page flipping). We just swap the backing store then and don't > go through the whole process of deleting and creati

Re: [Qemu-devel] [PATCH 2/3] s390: implement pci instructions

2014-11-10 Thread Alexander Graf
On 10.11.14 15:20, Frank Blaschka wrote: > From: Frank Blaschka > > This patch implements the s390 pci instructions in qemu. It allows > to access and drive pci devices attached to the s390 pci bus. > Because of platform constrains devices using IO BARs are not > supported. Also a device has to

Re: [Qemu-devel] [PATCH v2 9/9] qemu-iotests: Test writing non-raw image headers to raw image

2014-11-10 Thread Max Reitz
On 2014-11-07 at 20:39, Kevin Wolf wrote: This is forbidden if the raw driver was probed. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/109 | 100 ++ tests/qemu-iotests/109.out | 149 + tests/qemu-iotests/group

[Qemu-devel] [PATCHv2] esp: Do not overwrite ESP_TCHI after reset

2014-11-10 Thread Hannes Reinecke
After a reset ESP_TCHI should contain the unique ID of the chip. This value will be overwritten with the current tranfer count if the transfer count has previously been set. So we should always return the chip id if ESP_TCHI has never been written to. Signed-off-by: Hannes Reinecke --- hw/scsi/e

Re: [Qemu-devel] [PATCH] esp: Do not overwrite ESP_TCHI after reset

2014-11-10 Thread Hannes Reinecke
On 11/10/2014 04:37 PM, Hannes Reinecke wrote: > After a reset ESP_TCHI should contain the unique ID > of the chip. This value will be overwritten with the > current tranfer count if the transfer count has > previously been set. > The code never checks if the transfer count has > been set, so the u

[Qemu-devel] [PATCH] esp: Do not overwrite ESP_TCHI after reset

2014-11-10 Thread Hannes Reinecke
After a reset ESP_TCHI should contain the unique ID of the chip. This value will be overwritten with the current tranfer count if the transfer count has previously been set. The code never checks if the transfer count has been set, so the unique ID will always be overwritten if the driver sends a D

Re: [Qemu-devel] [PATCH 1/3] s390: Add PCI bus support

2014-11-10 Thread Alexander Graf
On 10.11.14 15:20, Frank Blaschka wrote: > From: Frank Blaschka > > This patch implements a pci bus for s390x together with infrastructure > to generate and handle hotplug events, to configure/unconfigure via > sclp instruction, to do iommu translations and provide s390 support for > MSI/MSI-X

  1   2   >