Re: [Qemu-devel] [libvirt] NBD TLS support in QEMU

2014-09-04 Thread Michal Privoznik
On 03.09.2014 18:44, Stefan Hajnoczi wrote: Hi, QEMU offers both NBD client and server functionality. The NBD protocol runs unencrypted, which is a problem when the client and server communicate over an untrusted network. This is not problem for NBD only, but for the rest of data that qemu se

Re: [Qemu-devel] [PATCH 02/17] ppc: avoid excessive TLB flushing

2014-09-04 Thread David Gibson
On Thu, Aug 28, 2014 at 09:35:27PM +0200, Paolo Bonzini wrote: > Il 28/08/2014 19:30, Peter Maydell ha scritto: > > On 28 August 2014 18:14, Paolo Bonzini > wrote: [snip] > > Does PPC hardware do lots of TLB flushes on user-kernel > > transitions, or does it have some sort of info in the TLB > > e

Re: [Qemu-devel] [PATCH 07/12] spapr_pci: add ibm, configure-connector RTAS interface

2014-09-04 Thread Nathan Fontenot
On 08/26/2014 04:12 AM, Alexey Kardashevskiy wrote: > On 08/19/2014 10:21 AM, Michael Roth wrote: >> Signed-off-by: Michael Roth > > I have totally no idea what this patch actually does :) When is this rtas > call made? Once after the guest received the check exception interrupt? Is > it all it d

Re: [Qemu-devel] [PATCH 04/12] spapr_pci: add set-indicator RTAS interface

2014-09-04 Thread Nathan Fontenot
On 08/26/2014 06:36 AM, Alexander Graf wrote: > > > On 19.08.14 02:21, Michael Roth wrote: >> From: Mike Day >> >> Signed-off-by: Mike Day >> Signed-off-by: Michael Roth >> --- >> hw/ppc/spapr_pci.c | 119 >> + >> include/hw/ppc/spapr.h |

Re: [Qemu-devel] [PATCH 09/12] spapr_pci: enable basic hotplug operations

2014-09-04 Thread Nathan Fontenot
On 09/04/2014 11:34 AM, Michael Roth wrote: > Quoting Michael Roth (2014-09-04 11:12:15) >> Quoting Bharata B Rao (2014-09-04 10:08:20) >>> On Thu, Sep 4, 2014 at 4:33 AM, Michael Roth >>> wrote: >> +static int spapr_device_hotplug_add(DeviceState *qdev, PCIDevice *dev) >> +{ >> +

Re: [Qemu-devel] [PATCH 2/2] vmdk: fix buf leak in vmdk_parse_extents()

2014-09-04 Thread Fam Zheng
On Thu, 09/04 21:04, Stefan Hajnoczi wrote: > vmdk_open_sparse() does not take ownership of buf so the caller always > needs to free it. > > Signed-off-by: Stefan Hajnoczi > --- > block/vmdk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/vmdk.c b/block/vmdk.c >

Re: [Qemu-devel] [PATCH 1/2] vmdk: fix vmdk_parse_extents() extent_file leaks

2014-09-04 Thread Fam Zheng
On Thu, 09/04 21:04, Stefan Hajnoczi wrote: > Signed-off-by: Stefan Hajnoczi > --- > block/vmdk.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/block/vmdk.c b/block/vmdk.c > index 07cb62c..9bf28f3 100644 > --- a/block/vmdk.c > +++ b/block/vmdk.c > @@ -834,6 +834,7 @@ static int vmdk

[Qemu-devel] [question] git clone kvm.git failed

2014-09-04 Thread Zhang Haoyu
Hi, all I encounter below error during git clone kvm.git, # git clone git://git.kernel.org/pub/scm/virt/kvm/kvm.git kvm_0905 Cloning into 'kvm_0905'... remote: Counting objects: 3819711, done. remote: Compressing objects: 100% (575699/575699), done. remote: Total 3819711 (delta 3219203), reused 38

[Qemu-devel] [PATCH v4 1/2] IDE: Fill the IDENTIFY request consistently

2014-09-04 Thread John Snow
IDE-HD, IDE-ATAPI and IDE-CFATA all fill the identify buffer in slightly different ways, this is a relatively minor patch to make them uniform, to emphasize that: (1) We build the s->identify_data cache first, then (2) We copy it to s->io_buffer to fulfill the request. Signed-off-by: John Snow -

[Qemu-devel] [PATCH v4 2/2] ide: Add resize callback to ide/core

2014-09-04 Thread John Snow
Currently, if the block device backing the IDE drive is resized, the information about the device as cached inside of the IDEState structure is not updated, thus when a guest OS re-queries the drive, it is unable to see the expanded size. This patch adds a resize callback that updates the IDENTIFY

[Qemu-devel] [PATCH v4 0/2] add resize callback to ide/core

2014-09-04 Thread John Snow
This patch series fixes incorrect IDENTIFY data returned for an IDE drive after a block_resize event by adding a resize callback for IDE devices. Inconsistencies between identify routines are also removed so that they read easier. V4: - Added patch that makes the buffer and cache fill order for

[Qemu-devel] [PATCH] vnc: add additional key up event before repeated key down

2014-09-04 Thread Chunyan Liu
Using xen tools 'xl vncviewer' with tigervnc (default on SLE-12), found that: the display of the guest is unexpected while keep pressing a key. We expect the same character multiple times, but it prints only one time. This happens on a PV guest in text mode. After debugging, found that tigervnc se

Re: [Qemu-devel] [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex property

2014-09-04 Thread Gonglei (Arei)
> From: Eduardo Habkost [mailto:ehabk...@redhat.com] > Sent: Friday, September 05, 2014 10:22 AM > Subject: Re: [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex > property > > On Fri, Sep 05, 2014 at 02:07:23AM +, Gonglei (Arei) wrote: > [...] > > > > > Also, this function (the

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-09-04 Thread Gonglei (Arei)
> From: Eduardo Habkost [mailto:ehabk...@redhat.com] > Sent: Friday, September 05, 2014 10:20 AM > Subject: Re: [PATCH v6 02/27] bootindex: add del_boot_device_path function > > On Fri, Sep 05, 2014 at 12:44:56AM +, Gonglei (Arei) wrote: > [...] > > > can we have a wrapper to reduce code > > >

Re: [Qemu-devel] [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex property

2014-09-04 Thread Eduardo Habkost
On Fri, Sep 05, 2014 at 02:07:23AM +, Gonglei (Arei) wrote: [...] > > > > Also, this function (the property setter) is where I expected > > > > add_boot_device_path() to be called, instead of requiring every device > > > > to add a reset handler and call add_boot_device_path() manually. > > > >

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-09-04 Thread Eduardo Habkost
On Fri, Sep 05, 2014 at 12:44:56AM +, Gonglei (Arei) wrote: [...] > > can we have a wrapper to reduce code > > duplication? e.g. a: > > void device_add_bootindex_property(DeviceState *dev, int32_t *field, const > > char *suffix) > > function. > > > > Then instead of reimplementing set/get/fi

Re: [Qemu-devel] [PATCH v2 3/4] target-ppc: Build error log

2014-09-04 Thread Alexey Kardashevskiy
On 09/04/2014 09:13 PM, Aravinda Prasad wrote: > Whenever there is a physical memory error due to bit > flips, which cannot be corrected by hardware, the error > is passed on to the kernel. If the memory address in > error belongs to guest address space then guest kernel > is responsible to take ac

Re: [Qemu-devel] [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex property

2014-09-04 Thread Gonglei (Arei)
> From: Eduardo Habkost [mailto:ehabk...@redhat.com] > Sent: Friday, September 05, 2014 9:55 AM > Subject: Re: [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex > property > > On Fri, Sep 05, 2014 at 12:37:35AM +, Gonglei (Arei) wrote: > > > Subject: Re: [PATCH v6 07/27] vl.c: a

Re: [Qemu-devel] [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex property

2014-09-04 Thread Eduardo Habkost
On Fri, Sep 05, 2014 at 12:37:35AM +, Gonglei (Arei) wrote: > > Subject: Re: [PATCH v6 07/27] vl.c: add setter/getter functions for > > bootindex > > property > > > > On Sat, Aug 30, 2014 at 06:00:07PM +0800, arei.gong...@huawei.com wrote: > > > From: Gonglei > > > > > > when we remove booti

Re: [Qemu-devel] [PATCH] qemu-char: fix terminal crash when using "-monitor stdio -nographic"

2014-09-04 Thread Li Liu
Ping, any more comments? Thanks. On 2014/8/27 15:40, Li Liu wrote: > > > On 2014/8/27 14:44, Markus Armbruster wrote: >> "john.liuli" writes: >> >>> From: Li Liu >>> >>> Eeay to reproduce, just try "qemu -monitor stdio -nographic" >>> and type "quit", then the terminal will be crashed. >>> >>>

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-09-04 Thread Gonglei (Arei)
> Subject: Re: [PATCH v6 02/27] bootindex: add del_boot_device_path function > > On Thu, Sep 04, 2014 at 03:01:41AM +, Gonglei (Arei) wrote: > > Hi, > > > > > From: Eduardo Habkost [mailto:ehabk...@redhat.com] > > > Sent: Thursday, September 04, 2014 2:13 AM > > > Subject: Re: [PATCH v6 02/27]

Re: [Qemu-devel] [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex property

2014-09-04 Thread Gonglei (Arei)
> Subject: Re: [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex > property > > On Sat, Aug 30, 2014 at 06:00:07PM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > when we remove bootindex form qdev.property to qom.property, > > we can use those functions set/get boo

Re: [Qemu-devel] [PATCH 06/12] spapr_pci: add get-sensor-state RTAS interface

2014-09-04 Thread Tyrel Datwyler
On 08/18/2014 05:21 PM, Michael Roth wrote: > From: Mike Day > > Signed-off-by: Mike Day > Signed-off-by: Michael Roth > --- > hw/ppc/spapr_pci.c | 76 > ++ > 1 file changed, 76 insertions(+) > > diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spa

Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/12] spapr: populate DRC entries for root dt node

2014-09-04 Thread Tyrel Datwyler
On 08/26/2014 12:55 AM, Alexey Kardashevskiy wrote: > On 08/19/2014 10:21 AM, Michael Roth wrote: >> From: Nathan Fontenot >> >> This add entries to the root OF node to advertise our PHBs as being >> DR-capable in according with PAPR specification. >> >> Each PHB is given a name of PHB, advertised

Re: [Qemu-devel] [PATCH v6 06/27] bootindex: move setting bootindex on reset() instead of realize/init()

2014-09-04 Thread Gonglei (Arei)
> Subject: Re: [PATCH v6 06/27] bootindex: move setting bootindex on reset() > instead of realize/init() > > On Sat, Aug 30, 2014 at 06:00:06PM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > Only in this way, we can assure the new bootindex take effect > > during vm rebooting. >

Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 2.1.1, freeze on 2014-09-03

2014-09-04 Thread Michael Roth
Quoting Michael Roth (2014-09-02 10:20:50) > Quoting Michael Roth (2014-08-27 12:35:57) > > Hi everyone, > > > > The following new patches are queued for QEMU stable v2.1.1: > > > > https://github.com/mdroth/qemu/commits/stable-2.1-staging > > As of now the following additional patches have be

Re: [Qemu-devel] NBD TLS support in QEMU

2014-09-04 Thread Benoît Canet
The Friday 05 Sep 2014 à 00:07:04 (+0200), Wouter Verhelst wrote : > On Thu, Sep 04, 2014 at 04:19:17PM +0200, Benoît Canet wrote: > > The Wednesday 03 Sep 2014 à 17:44:17 (+0100), Stefan Hajnoczi wrote : > > > Hi, > > > QEMU offers both NBD client and server functionality. The NBD protocol > > >

Re: [Qemu-devel] [PULL v2 1/3] exec: Save CPUState::exception_index field

2014-09-04 Thread Peter Maydell
On 4 September 2014 18:20, Andreas Färber wrote: > From: Pavel Dovgaluk > > This patch adds a subsection with exception_index field to the VMState for > correct saving the CPU state. > Without this patch, simulator could miss the pending exception in the saved > virtual machine state. > > Signed-

Re: [Qemu-devel] [PATCH 2/3] s390x/css: support format-0 ccws

2014-09-04 Thread Alexander Graf
On 04.09.14 17:32, Jens Freimann wrote: > From: Cornelia Huck > > Add support for format-0 ccws in channel programs. As a format-1 ccw > contains the same information as format-0 ccws, only supporting larger > addresses, simply convert every ccw to format-1 as we walk the chain. > > Reviewed-b

Re: [Qemu-devel] [Qemu-ppc] [PULL 00/52] ppc patch queue 2014-09-04

2014-09-04 Thread Alexander Graf
On 04.09.14 21:53, Tom Musta wrote: > On 9/4/2014 2:13 PM, Alexander Graf wrote: >> >> >>> Am 04.09.2014 um 20:38 schrieb Peter Maydell : >>> On 4 September 2014 18:19, Alexander Graf wrote: Hi Peter, This is my current patch queue for ppc. Please pull. >>> >>> Hi. I'm afrai

Re: [Qemu-devel] NBD TLS support in QEMU

2014-09-04 Thread Wouter Verhelst
On Thu, Sep 04, 2014 at 04:19:17PM +0200, Benoît Canet wrote: > The Wednesday 03 Sep 2014 à 17:44:17 (+0100), Stefan Hajnoczi wrote : > > Hi, > > QEMU offers both NBD client and server functionality. The NBD protocol > > runs unencrypted, which is a problem when the client and server > > communica

Re: [Qemu-devel] NBD TLS support in QEMU

2014-09-04 Thread Wouter Verhelst
[Cc: to nbd-general list added] On Wed, Sep 03, 2014 at 05:44:17PM +0100, Stefan Hajnoczi wrote: > Hi, > QEMU offers both NBD client and server functionality. The NBD protocol > runs unencrypted, which is a problem when the client and server > communicate over an untrusted network. > > The parti

Re: [Qemu-devel] [PATCH] block: Make op blockers recursive

2014-09-04 Thread Stefan Hajnoczi
On Tue, Aug 26, 2014 at 06:45:54AM +, Benoît Canet wrote: > On Tue, Aug 26, 2014 at 12:42:04PM +0800, Fam Zheng wrote: > > On Mon, 08/25 12:12, Benoît Canet wrote: > > > On Mon, Aug 25, 2014 at 05:37:37PM +0800, Fam Zheng wrote: > > > > On Mon, 08/25 09:06, Benoît Canet wrote: > > > > > On Mon,

Re: [Qemu-devel] tcmu-runner and QEMU

2014-09-04 Thread Stefan Hajnoczi
On Thu, Sep 04, 2014 at 08:15:39AM -0700, Andy Grover wrote: > But in the meantime, do you have a use case or user story for the QMP > support that might help me understand better how it might all fit together? From my previous email: "administrator needs to migrate disk images to a new file syst

Re: [Qemu-devel] [PATCH 2/2] vmdk: fix buf leak in vmdk_parse_extents()

2014-09-04 Thread Max Reitz
On 04.09.2014 22:04, Stefan Hajnoczi wrote: vmdk_open_sparse() does not take ownership of buf so the caller always needs to free it. Signed-off-by: Stefan Hajnoczi --- block/vmdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH 1/2] vmdk: fix vmdk_parse_extents() extent_file leaks

2014-09-04 Thread Max Reitz
On 04.09.2014 22:04, Stefan Hajnoczi wrote: Signed-off-by: Stefan Hajnoczi --- block/vmdk.c | 2 ++ 1 file changed, 2 insertions(+) Reviewed-by: Max Reitz

[Qemu-devel] [PATCH 1/2] vmdk: fix vmdk_parse_extents() extent_file leaks

2014-09-04 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- block/vmdk.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/vmdk.c b/block/vmdk.c index 07cb62c..9bf28f3 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -834,6 +834,7 @@ static int vmdk_parse_extents(const char *desc, BlockDriverState *bs,

[Qemu-devel] [PATCH 0/2] vmdk: fix leaks in vmdk_parse_extents()

2014-09-04 Thread Stefan Hajnoczi
See patches for the specific leaks. Stefan Hajnoczi (2): vmdk: fix vmdk_parse_extents() extent_file leaks vmdk: fix buf leak in vmdk_parse_extents() block/vmdk.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 1.9.3

[Qemu-devel] [PATCH 2/2] vmdk: fix buf leak in vmdk_parse_extents()

2014-09-04 Thread Stefan Hajnoczi
vmdk_open_sparse() does not take ownership of buf so the caller always needs to free it. Signed-off-by: Stefan Hajnoczi --- block/vmdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/vmdk.c b/block/vmdk.c index 9bf28f3..a1cb911 100644 --- a/block/vmdk.c +++ b/block/vm

Re: [Qemu-devel] [PATCH 1/4] block: Correct bs->growable

2014-09-04 Thread Max Reitz
On 20.08.2014 13:40, Kevin Wolf wrote: Am 12.07.2014 um 00:23 hat Max Reitz geschrieben: Currently, the field "growable" in a BDS is set iff the BDS is opened in protocol mode (with O_BDRV_PROTOCOL). However, not every protocol block driver allows growing: NBD, for instance, does not. On the oth

Re: [Qemu-devel] [Qemu-ppc] [PULL 00/52] ppc patch queue 2014-09-04

2014-09-04 Thread Tom Musta
On 9/4/2014 2:13 PM, Alexander Graf wrote: > > >> Am 04.09.2014 um 20:38 schrieb Peter Maydell : >> >>> On 4 September 2014 18:19, Alexander Graf wrote: >>> Hi Peter, >>> >>> This is my current patch queue for ppc. Please pull. >> >> Hi. I'm afraid this doesn't build (x86, 64bit, gcc >> 4.8.2,

Re: [Qemu-devel] [PATCH 1/2] target-arm : make parameter of feature/status checking function const

2014-09-04 Thread Chih-Min Chao
Just change what I have used and looked into. There are no other special reasons. On Fri, Sep 5, 2014 at 2:05 AM, Peter Maydell wrote: > On 4 September 2014 19:01, Chih-Min Chao wrote: > > CPUARMState is one of parameter used by > > is_a64 > > arm_feature > > arm_e

[Qemu-devel] [PATCH 1/2] target-arm : make parameter of feature/status checking function const

2014-09-04 Thread Chih-Min Chao
CPUARMState is one of parameter used by is_a64 arm_feature arm_el_is_aa64 They only read it without any side effect and shold be changed to const parameter Signed-off-by: Chih-Min Chao --- target-arm/cpu.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletio

[Qemu-devel] [PATCH 2/2] target-arm : use aarch64 mode testing wrapper

2014-09-04 Thread Chih-Min Chao
Don't use internal member but availabel wrapper function to test status Signed-off-by: Chih-Min Chao --- hw/arm/boot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/arm/boot.c b/hw/arm/boot.c index e32f2f4..26bc25f 100644 --- a/hw/arm/boot.c +++ b/hw/arm/boot

[Qemu-devel] [PATCH 0/2] target-arm : improvement

2014-09-04 Thread Chih-Min Chao
make CPUARMState const to attribute checking functions and use them to reduce internal status exposure Chih-Min Chao (2): target-arm : make parameter of feature/status checking function const target-arm : use aarch64 mode testing wrapper hw/arm/boot.c| 4 ++-- target-arm/cpu.h |

Re: [Qemu-devel] [PULL 00/52] ppc patch queue 2014-09-04

2014-09-04 Thread Alexander Graf
> Am 04.09.2014 um 20:38 schrieb Peter Maydell : > >> On 4 September 2014 18:19, Alexander Graf wrote: >> Hi Peter, >> >> This is my current patch queue for ppc. Please pull. > > Hi. I'm afraid this doesn't build (x86, 64bit, gcc > 4.8.2, non-debug build): > > CCppc64abi32-linux-user/l

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-09-04 Thread Andrey Korolyov
On Thu, Sep 4, 2014 at 10:54 PM, Marcelo Tosatti wrote: > On Thu, Sep 04, 2014 at 03:54:01PM -0300, Marcelo Tosatti wrote: >> On Thu, Sep 04, 2014 at 08:52:00PM +0400, Andrey Korolyov wrote: >> > On Thu, Sep 4, 2014 at 8:38 PM, Marcelo Tosatti >> > wrote: >> > > On Sun, Aug 24, 2014 at 10:51:38P

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-09-04 Thread Marcelo Tosatti
On Thu, Sep 04, 2014 at 03:54:01PM -0300, Marcelo Tosatti wrote: > On Thu, Sep 04, 2014 at 08:52:00PM +0400, Andrey Korolyov wrote: > > On Thu, Sep 4, 2014 at 8:38 PM, Marcelo Tosatti wrote: > > > On Sun, Aug 24, 2014 at 10:51:38PM +0400, Andrey Korolyov wrote: > > >> On Sun, Aug 24, 2014 at 8:57

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-09-04 Thread Marcelo Tosatti
On Thu, Sep 04, 2014 at 08:52:00PM +0400, Andrey Korolyov wrote: > On Thu, Sep 4, 2014 at 8:38 PM, Marcelo Tosatti wrote: > > On Sun, Aug 24, 2014 at 10:51:38PM +0400, Andrey Korolyov wrote: > >> On Sun, Aug 24, 2014 at 8:57 PM, Andrey Korolyov wrote: > >> > On Sun, Aug 24, 2014 at 8:35 PM, Paolo

Re: [Qemu-devel] [PULL 0/3] QOM CPUState patch queue 2014-09-04

2014-09-04 Thread Peter Maydell
On 4 September 2014 18:20, Andreas Färber wrote: > Hello Peter, > > This is my QOM CPU patch queue. Please pull. > > Regards, > Andreas > > Cc: Peter Maydell > > Cc: Eduardo Habkost > > The following changes since commit 01eb313907dda97313b8fea62e5632fca64f069c: > > Merge remote-tracking branc

Re: [Qemu-devel] [PULL 00/52] ppc patch queue 2014-09-04

2014-09-04 Thread Peter Maydell
On 4 September 2014 18:19, Alexander Graf wrote: > Hi Peter, > > This is my current patch queue for ppc. Please pull. Hi. I'm afraid this doesn't build (x86, 64bit, gcc 4.8.2, non-debug build): CCppc64abi32-linux-user/linux-user/signal.o /home/petmay01/linaro/qemu-for-merges/linux-user/si

Re: [Qemu-devel] [PATCH 2/2] target-arm : use aarch64 mode testing wrapper

2014-09-04 Thread Peter Maydell
On 4 September 2014 19:01, Chih-Min Chao wrote: > Don't use internal member but availabel wrapper function to > test status > > Signed-off-by: Chih-Min Chao > --- > hw/arm/boot.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/arm/boot.c b/hw/arm/boot.c >

Re: [Qemu-devel] [PATCH 14/17] ppc: introduce ppc_get_crf and ppc_set_crf

2014-09-04 Thread Tom Musta
On 8/28/2014 12:15 PM, Paolo Bonzini wrote: > These two functions will group together four CR bits into a single > value, once we change the representation of condition registers. > > Signed-off-by: Paolo Bonzini > --- > linux-user/elfload.c | 2 +- > linux-user/main.c| 2 +- > lin

Re: [Qemu-devel] [PATCH 15/17] ppc: store CR registers in 32 1-bit registers

2014-09-04 Thread Tom Musta
On 8/28/2014 12:15 PM, Paolo Bonzini wrote: > This makes comparisons much smaller and faster. The speedup is > approximately 10% on user-mode emulation on x86 host, 3-4% on PPC. > > Note that CRF_* constants are flipped to match PowerPC's big > bit-endianness. Previously, the CR register was eff

Re: [Qemu-devel] [PULL] VirtFS update

2014-09-04 Thread Peter Maydell
On 4 September 2014 17:01, Aneesh Kumar K.V wrote: > The following changes since commit 30eaca3acdf17d7bcbd1213eb149c02037edfb0b: > > Merge remote-tracking branch 'remotes/spice/tags/pull-spice-20140902-1' > into staging (2014-09-02 10:26:10 +0100) > > are available in the git repository at: >

Re: [Qemu-devel] [PULL v2 3/3] target-i386: Reject invalid CPU feature names on the command-line

2014-09-04 Thread Eduardo Habkost
On Thu, Sep 04, 2014 at 07:20:13PM +0200, Andreas Färber wrote: [...] > +static uint32_t x86_cpu_get_supported_feature_word(FeatureWord w, > + bool migratable_only); > + > #ifdef CONFIG_KVM > > static int cpu_x86_fill_model_id(char *str) > @@ -1

Re: [Qemu-devel] [qom-cpu PATCH] Fix build error on linux-user

2014-09-04 Thread Eduardo Habkost
On Thu, Sep 04, 2014 at 07:08:48PM +0200, Andreas Färber wrote: > Am 04.09.2014 18:58, schrieb Eduardo Habkost: > > Move x86_cpu_get_supported_feature_word() prototype outside CONFIG_KVM, > > to fix build error on linux-user and !CONFIG_KVM. > > > > Signed-off-by: Eduardo Habkost > > --- > > Can

Re: [Qemu-devel] HelloWord kernel for qemu-system-aarch64

2014-09-04 Thread Christopher Covington
Hi Semion, On 09/04/2014 09:40 AM, Semion Prihodko wrote: > Still don't know how to build/run a simple Hello World kernel on > qemu-system-aarch64? > > Guys, this is a very basic thing, please provide concrete steps. Thanks. Here you go. Start at the wget. http://lists.gnu.org/archive/html/qemu

[Qemu-devel] [PATCH v2] target-arm: Fix resetting issues on ARMv7-M CPUs

2014-09-04 Thread Martin Galvan
When calling qemu_system_reset after startup on a Cortex-M CPU, the initial values of PC, MSP and the Thumb bit weren't set correctly. In particular, since Thumb was 0, a Usage Fault would arise immediately after trying to excecute any instruction on a Cortex-M. Signed-off-by: Martin Galvan ---

Re: [Qemu-devel] [PATCH 1/2] target-arm : make parameter of feature/status checking function const

2014-09-04 Thread Peter Maydell
On 4 September 2014 19:01, Chih-Min Chao wrote: > CPUARMState is one of parameter used by > is_a64 > arm_feature > arm_el_is_aa64 > They only read it without any side effect and shold be changed to > const parameter I guess, but we have lots of functions that j

Re: [Qemu-devel] [PATCH 0/3] s390x: css patches and small sclp cleanup

2014-09-04 Thread Christian Borntraeger
On 04/09/14 17:32, Jens Freimann wrote: > Cornelia, Christian, Alex, > > here are two css patches and a small sclp cleanup. > > Patch 1 remove duplicate defines in SCLP code > Patch 2 adds support for format-0 ccws > Patch 3 a css bugfix adding a limit of 255 to ccws chains without data > tran

Re: [Qemu-devel] [PATCH v3] ide: Add resize callback to ide/core

2014-09-04 Thread John Snow
On 09/04/2014 12:13 PM, Stefan Hajnoczi wrote: This patch seems to break tests/bios-tables-test.c: ERROR:tests/bios-tables-test.c:744:test_acpi_one: assertion failed (signature == SIGNATURE): (0x == 0xdead) GTester: last random seed: R02S3d881198f35228a485b4c3d116dff3b1 I have run

Re: [Qemu-devel] [PULL v2 0/6] Net patches

2014-09-04 Thread Peter Maydell
On 4 September 2014 17:38, Stefan Hajnoczi wrote: > v2: > * Dropped netdev qdev change which broke aarch64 qtests > > The following changes since commit 30eaca3acdf17d7bcbd1213eb149c02037edfb0b: > > Merge remote-tracking branch 'remotes/spice/tags/pull-spice-20140902-1' > into staging (2014-09

[Qemu-devel] [PULL 4/7] memory: Remove object_property_add_child_array()

2014-09-04 Thread Andreas Färber
From: Peter Crosthwaite Obsoleted by automatic object_property_add() arrayification. Reviewed-by: Paolo Bonzini Signed-off-by: Peter Crosthwaite Signed-off-by: Andreas Färber --- memory.c | 30 +- 1 file changed, 5 insertions(+), 25 deletions(-) diff --git a/memo

[Qemu-devel] Supporting multiple CPU AddressSpaces and memory transaction attributes

2014-09-04 Thread Peter Maydell
One of the parts of the ARM TrustZone/Security Extensions which the patchsets we've seen so far haven't attempted to tackle is the problem of Secure vs NonSecure memory accesses. Architecturally, every memory transaction should have an S/NS bit accompanying the physical address, effectively making

[Qemu-devel] [PULL 3/7] qom: Add automatic arrayification to object_property_add()

2014-09-04 Thread Andreas Färber
From: Peter Crosthwaite If "[*]" is given as the last part of a QOM property name, treat that as an array property. The added property is given the first available name, replacing the * with a decimal number counting from 0. First add with name "foo[*]" will be "foo[0]". Second "foo[1]" and so o

[Qemu-devel] [PULL 6/7] qdev: Use NULL instead of local_err for qbus_child unrealize

2014-09-04 Thread Andreas Färber
From: Gonglei Forcefully unrealize all children regardless of errors in earlier iterations (if any). We should keep going with cleanup operation rather than report an error immediately. Therefore store the first child unrealization failure and propagate it at the end. We also forcefully unregiste

[Qemu-devel] [PULL 2/7] machine: Clean up -machine handling

2014-09-04 Thread Andreas Färber
Since commit c4090f8, -object options are no longer handled through object_set_property(), so clean up -object leftovers by renaming the function and dropping special-casing of qom-type and id properties. Cc: Paolo Bonzini Reviewed-by: Marcel Apfelbaum Signed-off-by: Andreas Färber --- vl.c |

[Qemu-devel] [PULL 5/7] qdev: Use error_abort instead of using local_err

2014-09-04 Thread Andreas Färber
From: Gonglei This error can not happen normally. If it happens, it indicates something very wrong, we should abort QEMU. Moreover, the user can only refer to /machine/peripheral or /objects, not /machine/unattached. While at it, remove superfluous check about local_err. Signed-off-by: Gonglei

[Qemu-devel] [PULL 52/52] hypervisor property clashes with hypervisor node

2014-09-04 Thread Alexander Graf
From: Anton Blanchard dtc fails on a recent QEMU snapshot: ERROR (name_properties): "name" property in /hypervisor#1 is incorrect ("hypervisor" instead of base node name) Looking at the device tree we have a hypervisor property: # lsprop hypervisor hypervisor "kvm" But we also have a h

[Qemu-devel] [PULL for-2.1 0/7] QOM devices patch queue 2014-09-04

2014-09-04 Thread Andreas Färber
Hello Peter, This is my QOM (devices) patch queue. Please pull. Regards, Andreas Cc: Peter Maydell Cc: Michael S. Tsirkin The following changes since commit 01eb313907dda97313b8fea62e5632fca64f069c: Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-2014-09-03' into staging (

[Qemu-devel] [PULL 50/52] spapr_pci: map the MSI window in each PHB

2014-09-04 Thread Alexander Graf
From: Greg Kurz On sPAPR, virtio devices are connected to the PCI bus and use MSI-X. Commit cc943c36faa192cd4b32af8fe5edb31894017d35 has modified MSI-X so that writes are made using the bus master address space and follow the IOMMU path. Unfortunately, the IOMMU address space address space does

[Qemu-devel] [PULL 41/52] PPC: Cuda: Use cuda timer to expose tbfreq to guest

2014-09-04 Thread Alexander Graf
Mac OS X calibrates a number of frequencies on bootup based on reading tb values on bootup and comparing them to via cuda timer values. The only variable we can really steer well (thanks to KVM) is the cuda frequency. So let's use that one to fake Mac OS X into believing the bus frequency is tbfre

[Qemu-devel] [PULL 47/52] target-ppc: Clean Up mullw

2014-09-04 Thread Alexander Graf
From: Tom Musta Eliminate the unecessary ext32s TCG operation and make the multiplication operation explicitly 32 bit. Signed-off-by: Tom Musta Suggested-by: Richard Henderson Reviewed-by: Richard Henderson Signed-off-by: Alexander Graf --- target-ppc/translate.c | 5 ++--- 1 file changed,

[Qemu-devel] [PULL 51/52] PPC: Fix default config ordering and add eTSEC for ppc64

2014-09-04 Thread Alexander Graf
We messed up the ordering in our default configs for PPC. The top entries are generic entries, then come sections that indicate that features are only in because of a special feature (such as PReP). Fix the ordering again and while at it add eTSEC support to the ppc64 target so that we can spawn e

[Qemu-devel] [PULL 43/52] spapr-vlan: Don't touch last entry in buffer list

2014-09-04 Thread Alexander Graf
From: Anton Blanchard The last 8 bytes of the buffer list is defined to contain the number of dropped frames. At the moment we use it to store rx entries, which trips up ethtool -S: rx_no_buffer: 9223380832981355136 Fix this by skipping the last buffer list entry. Signed-off-by: Anton Blanchar

[Qemu-devel] [PULL 38/52] PPC: mac_nvram: Allow 2 and 4 byte accesses

2014-09-04 Thread Alexander Graf
The NVRAM in our Core99 machine really supports 2byte and 4byte accesses just as well as 1byte accesses. In fact, Mac OS X uses those. Add support for higher register size granularities. Signed-off-by: Alexander Graf --- hw/nvram/mac_nvram.c | 4 1 file changed, 4 insertions(+) diff --git

[Qemu-devel] [PULL 49/52] target-ppc: Implement mulldo with TCG

2014-09-04 Thread Alexander Graf
From: Tom Musta Optimize mulldo by using the muls2_i64 operation rather than a helper. Eliminate the obsolete helper code. Signed-off-by: Tom Musta Suggested-by: Richard Henderson Reviewed-by: Richard Henderson Signed-off-by: Alexander Graf --- target-ppc/helper.h | 1 - target-ppc/i

[Qemu-devel] [PULL 31/52] target-ppc: Bug Fix: mulldo OV Detection

2014-09-04 Thread Alexander Graf
From: Tom Musta Fix the code to properly detect overflow; the 128 bit signed product must have all zeroes or all ones in the first 65 bits otherwise OV should be set. Example: R3 45F086A5D5887509 R4 0002 mulldo 3,3,4 Should set XER[OV]. Signed-off-by: Tom Musta Signed-off-by: Ale

[Qemu-devel] [PULL 45/52] target-ppc: Optimize rlwinm MB=0 ME=31

2014-09-04 Thread Alexander Graf
From: Tom Musta Optimize the special case of rlwinm where MB=0 and ME=31. This can be implemented as a 32-bit ROTL. Signed-off-by: Tom Musta Suggested-by: Richard Henderson Reviewed-by: Richard Henderson Signed-off-by: Alexander Graf --- target-ppc/translate.c | 6 ++ 1 file changed, 6

[Qemu-devel] [PULL 48/52] target-ppc: Clean up mullwo

2014-09-04 Thread Alexander Graf
From: Tom Musta Simplify the implementation of mullwo. For 64 bit CPUs, the result is the concatenation of the upper and lower parts of the muls2_i32 operation, which may be slightly better than deposit. For 32 bit CPUs, the lower part of the muls_i32 operation is moved into the target GPR. Si

[Qemu-devel] [PULL 46/52] target-ppc: Optimize rlwnm MB=0 ME=31

2014-09-04 Thread Alexander Graf
From: Tom Musta Optimize the special case of rlwnm where MB=0 and ME=31. This can be implemented using a ROTL. Suggested-by: Richard Henderson Signed-off-by: Tom Musta Reviewed-by: Richard Henderson Signed-off-by: Alexander Graf --- target-ppc/translate.c | 56 +

[Qemu-devel] [PULL 44/52] target-ppc: Special Case of rlwimi Should Use Deposit

2014-09-04 Thread Alexander Graf
From: Tom Musta The special case of rlwimi where MB <= ME and SH = 31-ME can be implemented with a single TCG deposit operation. This replaces the less general case of SH = MB = 0 and ME = 31. Signed-off-by: Tom Musta Suggested-by: Richard Henderson Reviewed-by: Richard Henderson Signed-off-

[Qemu-devel] [PULL 7/7] qdev: Add cleanup logic in device_set_realized() to avoid resource leak

2014-09-04 Thread Andreas Färber
From: Gonglei At present, this function doesn't have partial cleanup implemented, which will cause resource leaks in some scenarios. Example: 1. Assume that "dc->realize(dev, &local_err)" executes successful and local_err == NULL; 2. device hotplug in hotplug_handler_plug() executes but fail

[Qemu-devel] [PULL 30/52] target-ppc: Bug Fix: mullw

2014-09-04 Thread Alexander Graf
From: Tom Musta For 64-bit implementations, the mullw result is the 64 bit product of the sign-extended least significant 32 bits of the source registers. Fix the code to properly sign extend the source operands and produce a 64 bit product. Example: R3 002F37A0 R4 41C33D242F816715 mull

[Qemu-devel] [PULL 32/52] target-ppc: Bug Fix: srawi

2014-09-04 Thread Alexander Graf
From: Tom Musta For 64 bit implementations, the special case of a shift by zero should result in the sign extension of the least significant 32 bits of the source GPR (not a direct copy of the 64 bit source GPR). Example: R3 A6212433228F41DC srawi 3,3,0 R3 expected : 228F41DC R3 actual

[Qemu-devel] [PULL 42/52] spapr_pci: Fix config space corruption

2014-09-04 Thread Alexander Graf
From: Alexey Kardashevskiy When disabling MSI/MSIX via "ibm,change-msi" RTAS call, no check was made if MSI or MSIX is actually supported and the MSI message was reset unconditionally. If this happened on a device which does not support MSI (but does support MSIX, otherwise "ibm,change-msi" would

[Qemu-devel] [PULL 25/52] ppc/spapr: Fix MAX_CPUS to 255

2014-09-04 Thread Alexander Graf
From: Nikunj A Dadhania MAX_CPUS 256 is inconsistent with qemu supporting upto 255 cpus. This MAX_CPUS number was percolated back to "virsh capabilities" with wrong max_cpus. Signed-off-by: Nikunj A Dadhania Signed-off-by: Alexander Graf --- hw/ppc/spapr.c | 2 +- 1 file changed, 1 insertion(

[Qemu-devel] [PULL 1/7] qom: Make object_child_foreach() safe for objects removal

2014-09-04 Thread Andreas Färber
From: Alexey Kardashevskiy Current object_child_foreach() uses QTAILQ_FOREACH() to walk through children and that makes children removal from the callback impossible. This makes object_child_foreach() use QTAILQ_FOREACH_SAFE(). Signed-off-by: Alexey Kardashevskiy Reviewed-by: Hu Tao Signed-of

[Qemu-devel] [PULL 28/52] target-ppc: Bug Fix: rlwimi

2014-09-04 Thread Alexander Graf
From: Tom Musta The rlwimi specification includes the ROTL32 operation, which is defined to be a left rotation of two copies of the least significant 32 bits of the source GPR. The current implementation is incorrect on 64-bit implementations in that it rotates a single copy of the least signifi

[Qemu-devel] [PULL 23/52] ppc: Add software breakpoint support

2014-09-04 Thread Alexander Graf
From: Bharat Bhushan This patch allow insert/remove software breakpoint. When QEMU is not able to handle debug exception then we inject program exception to guest because for software breakpoint QEMU uses a ehpriv-1 instruction; So there cannot be any reason that we are in qemu with exit reason

[Qemu-devel] [PULL 39/52] PPC: mac_nvram: Split NVRAM into OF and OSX parts

2014-09-04 Thread Alexander Graf
Mac OS X (at least with -M mac99) searches for a valid NVRAM partition of a special Apple type. If it can't find that partition in the first half of NVRAM, it will look at the second half. There are a few implications from this. The first is that we need to split NVRAM into 2 halves - one for Open

[Qemu-devel] [PULL 40/52] PPC: Mac: Move tbfreq into local variable

2014-09-04 Thread Alexander Graf
We already expose the real CPU's tb frequency to the guest via fw_cfg. Soon we will need to also expose it to the MacIO, so let's move it to a variable that we can leverage every time we need the frequency. Signed-off-by: Alexander Graf --- hw/ppc/mac_newworld.c | 13 ++--- hw/ppc/mac_ol

[Qemu-devel] [PULL 11/52] PPC: mac99: Move NVRAM to page boundary when necessary

2014-09-04 Thread Alexander Graf
When running KVM we have to adhere to host page boundaries for memory slots. Unfortunately the NVRAM on mac99 is a 4k RAM hole inside of an MMIO flash area. So if our host is configured with 64k page size, we can't use the mac99 target with KVM. This is a real shame, as this limitation is not real

[Qemu-devel] [PULL 33/52] target-ppc: Bug Fix: srad

2014-09-04 Thread Alexander Graf
From: Tom Musta Fix the check for carry in the srad helper to properly construct the mask -- a "1ULL" must be used (instead of "1") in order to get the desired result. Example: R3 8000 R4 F3511AD4A2CD4C38 srad 3,3,4 Should *not* set XER[CA] but does without this patch. Signed-off-

[Qemu-devel] [PULL 37/52] PPC: mac_nvram: Remove unused functions

2014-09-04 Thread Alexander Graf
The macio_nvram_read and macio_nvram_write functions are never called, just remove them. Signed-off-by: Alexander Graf --- hw/nvram/mac_nvram.c | 23 --- hw/ppc/mac.h | 2 -- 2 files changed, 25 deletions(-) diff --git a/hw/nvram/mac_nvram.c b/hw/nvram/mac_nvram.c i

[Qemu-devel] [PULL 34/52] KVM: Add helper to run KVM_CHECK_EXTENSION on vm fd

2014-09-04 Thread Alexander Graf
We now can call KVM_CHECK_EXTENSION on the kvm fd or on the vm fd, whereas the vm version is more accurate when it comes to PPC KVM. Add a helper to make the vm version available that falls back to the non-vm variant if the vm one is not available yet to stay compatible. Signed-off-by: Alexander

[Qemu-devel] [PULL 24/52] ppc: Add hw breakpoint watchpoint support

2014-09-04 Thread Alexander Graf
From: Bharat Bhushan This patch adds hardware breakpoint and hardware watchpoint support for ppc. On BOOKE architecture we cannot share debug resources between QEMU and guest because: When QEMU is using debug resources then debug exception must be always enabled. To achieve this we set M

[Qemu-devel] [PULL 14/52] spapr: Use DT memory node rendering helper for other nodes

2014-09-04 Thread Alexander Graf
From: Alexey Kardashevskiy This finishes refactoring by using the spapr_populate_memory_node helper for all nodes and removing leftovers from spapr_populate_memory(). This is not a part of the previous patch because the patches look nicer apart. Signed-off-by: Alexey Kardashevskiy Signed-off-b

[Qemu-devel] [PULL 22/52] ppc: synchronize excp_vectors for injecting exception

2014-09-04 Thread Alexander Graf
From: Bharat Bhushan This patch synchronizes env->excp_vectors[] with env->iovr[]. This is required for using the existing interrupt injection mechanism for kvm. Signed-off-by: Bharat Bhushan Signed-off-by: Alexander Graf --- target-ppc/kvm.c | 27 +++ 1 file changed,

  1   2   3   4   >