Re: [Qemu-devel] [PATCH for-2.1] linux-user: hide reserved mmap in /proc/self/mmap

2014-07-22 Thread Mikhail Ilin
Adding Riku Voipio On 18.07.2014 11:42, Mikhail Ilin wrote: Hi, Running 32-bits binaries with address sanitizer (ASAN) instrumentations fails under 64-bits qemu. During initialization ASAN relies on the output from /proc/self/mmap then tries to find a big chunk for shadow memory but it is not h

Re: [Qemu-devel] [Bug 1346769] Re: /proc/self/maps content returned to 32-bits guest under 64-bits qemu

2014-07-22 Thread Mikhail Ilin
Adding Riku Voipio On 23.07.2014 09:04, Mikhail Ilin wrote: On 22.07.2014 12:51, Peter Maydell wrote: > I think the ifdefs are just accident of history and we can safely remove > them. > Good, let make a fix. From 719f4e66b134a043dabdf5f6cb6d40445a53e071 Mon Sep 17 00:00:00 2001 From: Mikh

Re: [Qemu-devel] [Bug 1346769] Re: /proc/self/maps content returned to 32-bits guest under 64-bits qemu

2014-07-22 Thread Mikhail Ilin
On 22.07.2014 12:51, Peter Maydell wrote: > I think the ifdefs are just accident of history and we can safely remove > them. > Good, let make a fix. From 719f4e66b134a043dabdf5f6cb6d40445a53e071 Mon Sep 17 00:00:00 2001 From: Mikhail Ilyin Date: Wed, 23 Jul 2014 08:49:09 +0400 Subject: [PATCH]

Re: [Qemu-devel] [PATCH 1/3] intel-iommu: introduce Intel IOMMU (VT-d) emulation

2014-07-22 Thread Le Tan
Hi Michael, Thanks very much for your careful reviewing! 2014-07-23 4:05 GMT+08:00 Michael S. Tsirkin : > On Tue, Jul 22, 2014 at 11:47:48PM +0800, Le Tan wrote: >> Add support for emulating Intel IOMMU according to the VT-d specification for >> the q35 chipset machine. Implement the logic for DMA

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.2] spapr: add host Linux version information to device tree

2014-07-22 Thread Cyril Bur
On 18/07/14 22:01, Alexander Graf wrote: On 18.07.14 13:59, Eric Blake wrote: On 07/17/2014 10:31 PM, cyril...@gmail.com wrote: It may prove useful know which Linux distribution version the host machine is running when an issue in the guest arises but a user cannot access the host. Signed-o

Re: [Qemu-devel] [Bug 1344320] Re: qemu-aarch64 cannot execute glibc

2014-07-22 Thread Peter Maydell
On 22 July 2014 20:46, Richard Henderson wrote: > On 07/21/2014 10:37 AM, Peter Maydell wrote: >>> It's trying to measure clock cycles required to perform the startup >>> relocations. >> >> That's a neat trick, given that the generic timers are not cycle >> counters! They're a fixed frequency coun

[Qemu-devel] [PATCH v10 14/14] iotests: Omit length/offset test in 040 and 041

2014-07-22 Thread Max Reitz
As the length of a mirror block job no longer directly depends on the size of the block device, drop those checks from this test. Instead, just check whether the final offset equals the block job length. As 041 uses the wait_until_completed function from iotests.py, the same applies there as well

[Qemu-devel] [ANNOUNCE] QEMU 2.1.0-rc3 is now available

2014-07-22 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the fourth release candidate for the QEMU 2.1 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-2.1.0-rc3.tar.bz2 Note from Pete

[Qemu-devel] [PATCH v10 13/14] iotests: Add test for qcow2's bdrv_make_empty

2014-07-22 Thread Max Reitz
Add a test for qcow2's fast bdrv_make_empty implementation on images without internal snapshots. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- tests/qemu-iotests/098 | 75 ++ tests/qemu-iotests/098.out | 26 tests/qemu-iote

[Qemu-devel] [PATCH v10 12/14] iotests: Add test for backing-chain commits

2014-07-22 Thread Max Reitz
Add a test for qemu-img commit on backing chains with more than two images. This test also checks whether the top image is emptied (unless this is prevented by specifying either -d or -b) and does therefore not work for qed and vmdk which requires it to be separate from 020. Signed-off-by: Max Rei

[Qemu-devel] [PATCH v10 11/14] iotests: Add _filter_qemu_img_map

2014-07-22 Thread Max Reitz
As different image formats most probably map guest addresses to different host addresses, add a filter to filter the host addresses out; also, the image filename should be filtered. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- tests/qemu-iotests/common.filter | 7 +++ 1 file changed

[Qemu-devel] [PATCH v10 07/14] qemu-img: Implement commit like QMP

2014-07-22 Thread Max Reitz
qemu-img should use QMP commands whenever possible in order to ensure feature completeness of both online and offline image operations. As qemu-img itself has no access to QMP (since this would basically require just everything being linked into qemu-img), imitate QMP's implementation of block-comm

[Qemu-devel] [PATCH v10 08/14] qemu-img: Empty image after commit

2014-07-22 Thread Max Reitz
After the top image has been committed, it should be emptied unless specified otherwise. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- qemu-img-cmds.hx | 4 ++-- qemu-img.c | 34 +++--- qemu-img.texi| 6 +- 3 files changed, 38 insertions(+), 6

[Qemu-devel] [PATCH v10 10/14] qemu-img: Specify backing file for commit

2014-07-22 Thread Max Reitz
Introduce a new parameter for qemu-img commit which may be used to explicitly specify the backing file into which an image should be committed if the backing chain has more than a single layer. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- qemu-img-cmds.hx | 4 ++-- qemu-img.c | 2

[Qemu-devel] [PATCH v10 06/14] block/mirror: Improve progress report

2014-07-22 Thread Max Reitz
Instead of taking the total length of the block device as the block job's length, use the number of dirty sectors. The progress is now the number of sectors mirrored to the target block device. Note that this may result in the job's length increasing during operation, which is however in fact desir

[Qemu-devel] [PATCH v10 09/14] qemu-img: Enable progress output for commit

2014-07-22 Thread Max Reitz
Implement progress output for the commit command by querying the progress of the block job. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- qemu-img-cmds.hx | 4 ++-- qemu-img.c | 24 ++-- qemu-img.texi| 2 +- 3 files changed, 25 insertions(+), 5 deletions(-

[Qemu-devel] [PATCH v10 04/14] blockjob: Introduce block_job_complete_sync()

2014-07-22 Thread Max Reitz
Implement block_job_complete_sync() by doing the exact same thing as block_job_cancel_sync() does, only with calling block_job_complete() instead of block_job_cancel(). Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf --- blockjob.c | 39 --- in

[Qemu-devel] [PATCH v10 02/14] qcow2: Implement bdrv_make_empty()

2014-07-22 Thread Max Reitz
Implement this function by making all clusters in the image file fall through to the backing file (by using the recently extended discard). Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Kevin Wolf --- block/qcow2.c | 27 +++ 1 file changed, 27 insertions

[Qemu-devel] [PATCH v10 03/14] qcow2: Optimize bdrv_make_empty()

2014-07-22 Thread Max Reitz
bdrv_make_empty() is currently only called if the current image represents an external snapshot that has been committed to its base image; it is therefore unlikely to have internal snapshots. In this case, bdrv_make_empty() can be greatly sped up by creating an empty L1 table and dropping all data

[Qemu-devel] [PATCH v10 05/14] blockjob: Add "ready" field

2014-07-22 Thread Max Reitz
When a block job signals readiness, this is currently reported only through QMP. If qemu wants to use block jobs for internal tasks, there needs to be another way to correctly detect when a block job may be completed. For this reason, introduce a bool "ready" which is set when the block job may be

[Qemu-devel] [PATCH v10 01/14] qcow2: Allow "full" discard

2014-07-22 Thread Max Reitz
Normally, discarded sectors should read back as zero. However, there are cases in which a sector (or rather cluster) should be discarded as if they were never written in the first place, that is, reading them should fall through to the backing file again. Signed-off-by: Max Reitz Reviewed-by: Eri

[Qemu-devel] [PATCH v10 00/14] qemu-img: Implement commit like QMP

2014-07-22 Thread Max Reitz
qemu-img should use QMP commands whenever possible in order to ensure feature completeness of both online and offline image operations. For the "commit" command, this is relatively easy, so implement it first (in the hope that indeed others will follow). As qemu-img does not have access to QMP (du

[Qemu-devel] [PATCH] Add ACPI tables for TPM

2014-07-22 Thread Stefan Berger
From: Stefan Berger Add an SSDT ACPI table for the TPM device. Add a TCPA table for BIOS logging area when a TPM is being used. The latter follows this spec here: http://www.trustedcomputinggroup.org/files/static_page_files/DCD4188E-1A4B-B294-D050A155FB6F7385/TCG_ACPIGeneralSpecification_Public

Re: [Qemu-devel] [PATCH v2 1/2] qemu-img: Allow source cache mode specification

2014-07-22 Thread Eric Blake
On 07/22/2014 02:58 PM, Max Reitz wrote: > Many qemu-img subcommands only read the source file(s) once. For these > use cases, a full write-back cache is unnecessary and mainly clutters > host cache memory. Though this is generally no concern as cache memory > is freely available and can be scaled

Re: [Qemu-devel] [PATCH 1/3] intel-iommu: introduce Intel IOMMU (VT-d) emulation

2014-07-22 Thread Michael S. Tsirkin
On Tue, Jul 22, 2014 at 11:47:48PM +0800, Le Tan wrote: > Add support for emulating Intel IOMMU according to the VT-d specification for > the q35 chipset machine. Implement the logic for DMAR (DMA remapping) without > PASID support. Use register-based invalidation for context-cache invalidation > a

[Qemu-devel] [PATCH for-2.1] docs: document remaining QMP events

2014-07-22 Thread Eric Blake
Commit dfab4892 restored this file, but did not address any of the grammar problems that had been fixed in passing when moving events out of this file. There are also a couple events that were undocumented since introduction, and one that had been added only in the time that this file was temporar

[Qemu-devel] [PATCH v2 1/2] qemu-img: Allow source cache mode specification

2014-07-22 Thread Max Reitz
Many qemu-img subcommands only read the source file(s) once. For these use cases, a full write-back cache is unnecessary and mainly clutters host cache memory. Though this is generally no concern as cache memory is freely available and can be scaled by the host OS, it may become a concern with thin

[Qemu-devel] [PATCH v2 2/2] qemu-img: Allow cache mode specification for amend

2014-07-22 Thread Max Reitz
qemu-img amend may extensively modify the target image, depending on the options to be amended (e.g. conversion to qcow2 compat level 0.10 from 1.1 for an image with many unallocated zero clusters). Therefore it makes sense to allow the user to specify the cache mode to be used. Signed-off-by: Max

[Qemu-devel] [PATCH v2 0/2] qemu-img: Allow source cache mode specification

2014-07-22 Thread Max Reitz
Currently, qemu-img does not allow setting the cache mode for source images. However, it reads images generally only once, therefore a full writeback cache unnecessarily clutters the host cache. In case the user finds this undesirable, there has to be a way of disabling that cache. This series firs

Re: [Qemu-devel] [PATCH] Add ACPI tables for TPM

2014-07-22 Thread Michael S. Tsirkin
On Tue, Jul 22, 2014 at 04:13:01PM -0400, Stefan Berger wrote: > On 07/22/2014 03:05 PM, Michael S. Tsirkin wrote: > >On Tue, Jul 22, 2014 at 03:55:38PM -0400, Stefan Berger wrote: > >>From: Stefan Berger > >> > >>Add an SSDT ACPI table for the TPM device. > >>Add a TCPA table for BIOS logging are

Re: [Qemu-devel] [PATCH v2 5/5] block: iotest - update 084 to test static VDI image creation

2014-07-22 Thread Jeff Cody
On Tue, Jul 22, 2014 at 10:21:48PM +0200, Max Reitz wrote: > On 21.07.2014 21:52, Jeff Cody wrote: > >This updates the VDI corruption test to also test static VDI image > >creation, as well as the default dynamic image creation. > > > >Signed-off-by: Jeff Cody > >--- > > tests/qemu-iotests/084

Re: [Qemu-devel] [PATCH] Add ACPI tables for TPM

2014-07-22 Thread Stefan Berger
On 07/22/2014 03:05 PM, Michael S. Tsirkin wrote: On Tue, Jul 22, 2014 at 03:55:38PM -0400, Stefan Berger wrote: From: Stefan Berger Add an SSDT ACPI table for the TPM device. Add a TCPA table for BIOS logging area when a TPM is being used. The latter follows this spec here: http://www.trust

Re: [Qemu-devel] [PATCH v2 5/5] block: iotest - update 084 to test static VDI image creation

2014-07-22 Thread Max Reitz
On 21.07.2014 21:52, Jeff Cody wrote: This updates the VDI corruption test to also test static VDI image creation, as well as the default dynamic image creation. Signed-off-by: Jeff Cody --- tests/qemu-iotests/084 | 16 ++-- tests/qemu-iotests/084.out | 15 +++ 2

Re: [Qemu-devel] [PATCH v2 2/5] block: vdi - use block layer ops in vdi_create, instead of posix calls

2014-07-22 Thread Max Reitz
On 22.07.2014 22:19, Jeff Cody wrote: On Tue, Jul 22, 2014 at 10:14:58PM +0200, Max Reitz wrote: On 21.07.2014 21:52, Jeff Cody wrote: Use the block layer to create, and write to, the image file in the VDI .bdrv_create() operation. This has a couple of benefits: Images can now be created over

Re: [Qemu-devel] [PATCH v2 2/5] block: vdi - use block layer ops in vdi_create, instead of posix calls

2014-07-22 Thread Jeff Cody
On Tue, Jul 22, 2014 at 10:14:58PM +0200, Max Reitz wrote: > On 21.07.2014 21:52, Jeff Cody wrote: > >Use the block layer to create, and write to, the image file in the > >VDI .bdrv_create() operation. > > > >This has a couple of benefits: Images can now be created over protocols, > >and hacks such

Re: [Qemu-devel] [PATCH v2 2/5] block: vdi - use block layer ops in vdi_create, instead of posix calls

2014-07-22 Thread Max Reitz
On 21.07.2014 21:52, Jeff Cody wrote: Use the block layer to create, and write to, the image file in the VDI .bdrv_create() operation. This has a couple of benefits: Images can now be created over protocols, and hacks such as NOCOW are not needed in the image format driver, and the underlying fi

Re: [Qemu-devel] [PATCH 2/2] qemu-img: Allow cache mode specification for amend

2014-07-22 Thread Max Reitz
On 21.07.2014 17:57, Eric Blake wrote: On 07/19/2014 02:35 PM, Max Reitz wrote: qemu-img amend may extensively modify the target image, depending on the options to be amended (e.g. conversion to qcow2 compat level 0.10 from 1.1 for an image with many unallocated zero clusters). Therefore it make

Re: [Qemu-devel] [PATCH 1/2] qemu-img: Allow source cache mode specification

2014-07-22 Thread Max Reitz
On 21.07.2014 17:52, Eric Blake wrote: On 07/19/2014 02:35 PM, Max Reitz wrote: Many qemu-img subcommands only read the source file(s) once. For these use cases, a full write-back cache is unnecessary and mainly clutters host cache memory. Though this is generally no concern as cache memory is f

Re: [Qemu-devel] [PATCH] pci: Don't deliver MSI/MSI-X messages if bus master support is off

2014-07-22 Thread Michael S. Tsirkin
On Mon, Jul 21, 2014 at 12:04:22AM +0200, Jan Kiszka wrote: > On 2014-07-20 23:03, Michael S. Tsirkin wrote: > > On Sun, Jul 20, 2014 at 11:45:10PM +0200, Jan Kiszka wrote: > >> On 2014-07-20 21:48, Michael S. Tsirkin wrote: > >>> On Sat, Jul 19, 2014 at 06:55:48PM +0200, Jan Kiszka wrote: > F

Re: [Qemu-devel] [PATCH] Add ACPI tables for TPM

2014-07-22 Thread Michael S. Tsirkin
On Tue, Jul 22, 2014 at 03:55:38PM -0400, Stefan Berger wrote: > From: Stefan Berger > > Add an SSDT ACPI table for the TPM device. > Add a TCPA table for BIOS logging area when a TPM is being used. > > The latter follows this spec here: > > http://www.trustedcomputinggroup.org/files/static_pag

Re: [Qemu-devel] [Bug 1344320] Re: qemu-aarch64 cannot execute glibc

2014-07-22 Thread Richard Henderson
On 07/21/2014 10:37 AM, Peter Maydell wrote: >> It's trying to measure clock cycles required to perform the startup >> relocations. > > That's a neat trick, given that the generic timers are not cycle > counters! They're a fixed frequency counter which is generally > unrelated and rather slower th

[Qemu-devel] [PATCH] [RFC] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-07-22 Thread Alex Bligh
Add a machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm version 1.0. Signed-off-by: Alex Bligh --- hw/acpi/piix4.c | 49 -- hw/i386/pc_piix.c| 31 + hw/timer/i8254_common.c | 4

Re: [Qemu-devel] [PULL 2.1 0/1] ppc patch queue 2014-07-22

2014-07-22 Thread Peter Maydell
On 22 July 2014 16:38, Alexander Graf wrote: > Hi Peter, > > This is my current patch queue for ppc. Please pull. > > Alex > > > The following changes since commit 35858955e6c6f9ef41c199d15457c13426ac6434: > > Merge remote-tracking branch 'remotes/afaerber/tags/qom-devices-for-2.1' > into stag

[Qemu-devel] [PATCH] hw/misc/imx_ccm.c: Add missing VMState list terminator

2014-07-22 Thread Peter Maydell
The VMStateDescription for the imx_ccm device was missing its terminator. Found by static search of the codebase using a regex based on one suggested by Ian Jackson: pcregrep -rMi '(?s)VMStateField(?:(?!END_OF_LIST).)*?;' $(git grep -l 'VMStateField\[\]') Signed-off-by: Peter Maydell Cc: qemu-

Re: [Qemu-devel] [PATCH for-2.1 for-stable] vmstate_xhci_event: fix unterminated field list

2014-07-22 Thread Peter Maydell
On 22 July 2014 16:48, Laszlo Ersek wrote: > On 07/22/14 17:42, Paolo Bonzini wrote: >> Cc: qemu-sta...@nongnu.org > > As far as I can see, this address was present in my original To: list. > :) (Admittedly, not with CC.) Including the line in the commit message means it can get pulled back out o

Re: [Qemu-devel] [PATCH v3] virtio-rng: Add human-readable error message for negative max-bytes parameter

2014-07-22 Thread Amit Shah
On (Tue) 22 Jul 2014 [11:30:28], John Snow wrote: > > On 07/22/2014 07:48 AM, Amit Shah wrote: > -assert(vrng->conf.max_bytes <= INT64_MAX); > +/* Workaround: Property parsing does not enforce unsigned integers, > + * So this is a hack to reject such numbers. */ > +

[Qemu-devel] [PATCH 3/3] intel-iommu: add Intel IOMMU emulation to q35 and add a machine option "vtd" as a switch

2014-07-22 Thread Le Tan
Add Intel IOMMU emulation to q35 chipset and expose it to the guest. 1. Add a machine option. Users can use "-machine vtd=on|off" in the command line to enable/disable Intel IOMMU. The default is off. 2. Accroding to the machine option, q35 will initialize the Intel IOMMU and use pci_setup_iommu()

[Qemu-devel] [PATCH 0/3] intel-iommu: introduce Intel IOMMU (VT-d) emulation to q35 chipset

2014-07-22 Thread Le Tan
Hi, These patches are intended to introduce Intel IOMMU (VT-d) emulation to q35 chipset. The major job in these patches is to add support for emulating Intel IOMMU according to the VT-d specification, including basic responses to CSRs accesses, the logic of DMAR (DMA remapping) and DMA memory addr

[Qemu-devel] [PATCH 2/3] intel-iommu: add DMAR table to ACPI tables

2014-07-22 Thread Le Tan
Expose Intel IOMMU to the BIOS. If object of TYPE_INTEL_IOMMU_DEVICE exists, add DMAR table to ACPI RSDT table. For now the DMAR table indicates that there is only one hardware unit without INTR_REMAP capability on the platform. Signed-off-by: Le Tan --- hw/i386/acpi-build.c | 41 +++

[Qemu-devel] [PATCH 1/3] intel-iommu: introduce Intel IOMMU (VT-d) emulation

2014-07-22 Thread Le Tan
Add support for emulating Intel IOMMU according to the VT-d specification for the q35 chipset machine. Implement the logic for DMAR (DMA remapping) without PASID support. Use register-based invalidation for context-cache invalidation and IOTLB invalidation. Basic fault reporting and caching are not

Re: [Qemu-devel] [PATCH for-2.1 for-stable] vmstate_xhci_event: fix unterminated field list

2014-07-22 Thread Laszlo Ersek
On 07/22/14 17:42, Paolo Bonzini wrote: > Il 22/07/2014 17:26, Laszlo Ersek ha scritto: >> "vmstate_xhci_event" was introduced in commit 37352df3 ("xhci: add live >> migration support"), and first released in v1.6.0. The field list in this >> VMSD is not terminated with the VMSTATE_END_OF_LIST() ma

Re: [Qemu-devel] [RFC PATCH V4 0/6] icount: Implement delay algorithm between guest and host clocks

2014-07-22 Thread Paolo Bonzini
Il 22/07/2014 17:28, Sebastian Tanase ha scritto: > When not using "-icount" everything is fine because QEMU_CLOCK_VIRTUAL > is based on the real clock and the offset; qemu_icount_bias > doesn't come into play. So the vm_clock_warp_start fix is only for the case > where we use "-icount". I mea

Re: [Qemu-devel] [PATCH for-2.1 for-stable] vmstate_xhci_event: fix unterminated field list

2014-07-22 Thread Paolo Bonzini
Il 22/07/2014 17:26, Laszlo Ersek ha scritto: > "vmstate_xhci_event" was introduced in commit 37352df3 ("xhci: add live > migration support"), and first released in v1.6.0. The field list in this > VMSD is not terminated with the VMSTATE_END_OF_LIST() macro. > > During normal use (ie. migration),

[Qemu-devel] [PULL 2.1 0/1] ppc patch queue 2014-07-22

2014-07-22 Thread Alexander Graf
Hi Peter, This is my current patch queue for ppc. Please pull. Alex The following changes since commit 35858955e6c6f9ef41c199d15457c13426ac6434: Merge remote-tracking branch 'remotes/afaerber/tags/qom-devices-for-2.1' into staging (2014-07-21 18:06:12 +0100) are available in the git repos

Re: [Qemu-devel] [PATCH v3] virtio-rng: Add human-readable error message for negative max-bytes parameter

2014-07-22 Thread John Snow
On 07/22/2014 07:48 AM, Amit Shah wrote: On (Tue) 22 Jul 2014 [13:41:43], Markus Armbruster wrote: Amit Shah writes: On (Mon) 21 Jul 2014 [17:44:37], John Snow wrote: If a negative integer is used for the max_bytes parameter, QEMU currently calls abort() and leaves behind a core dump. This

[Qemu-devel] [PULL 1/1] ppc: fix -mem-path failure

2014-07-22 Thread Alexander Graf
From: Hu Tao commit e938ba0c tried to enable -mem-path for ppc but breaked some ppc boards. The problems are: 1. it fails when allocating memory for rom, sram whose sizes are less than huge page size: ./ppc-softmmu/qemu-system-ppc -m 512 -mem-path /hugepages/ \ -kernel /home/hutao/Do

Re: [Qemu-devel] [PATCH for-2.1 for-stable] vmstate_xhci_event: fix unterminated field list

2014-07-22 Thread Amit Shah
On (Tue) 22 Jul 2014 [17:26:41], Laszlo Ersek wrote: > "vmstate_xhci_event" was introduced in commit 37352df3 ("xhci: add live > migration support"), and first released in v1.6.0. The field list in this > VMSD is not terminated with the VMSTATE_END_OF_LIST() macro. > > During normal use (ie. migra

[Qemu-devel] [PATCH for-2.1 for-stable] vmstate_xhci_event: fix unterminated field list

2014-07-22 Thread Laszlo Ersek
"vmstate_xhci_event" was introduced in commit 37352df3 ("xhci: add live migration support"), and first released in v1.6.0. The field list in this VMSD is not terminated with the VMSTATE_END_OF_LIST() macro. During normal use (ie. migration), the issue is practically invisible, because the "vmstate

Re: [Qemu-devel] [RFC PATCH V4 0/6] icount: Implement delay algorithm between guest and host clocks

2014-07-22 Thread Paolo Bonzini
Il 22/07/2014 17:17, Sebastian Tanase ha scritto: >> > That's a bug to fix indeed, then---it should count up from 0 without >> > icount, and icount shouldn't affect this. Thanks for investigating >> > it. > Just to be sure I don't missunderstand, when you say "without icount" > you refer to qemu_i

Re: [Qemu-devel] [RFC PATCH V4 0/6] icount: Implement delay algorithm between guest and host clocks

2014-07-22 Thread Sebastian Tanase
- Mail original - > De: "Paolo Bonzini" > À: "Sebastian Tanase" > Cc: aligu...@amazon.com, afaer...@suse.de, r...@twiddle.net, "peter maydell" > , > mich...@walle.cc, a...@alex.org.uk, stefa...@redhat.com, > lcapitul...@redhat.com, crobi...@redhat.com, > arm...@redhat.com, wenchaoq...

Re: [Qemu-devel] [RFC PATCH V4 0/6] icount: Implement delay algorithm between guest and host clocks

2014-07-22 Thread Sebastian Tanase
- Mail original - > De: "Paolo Bonzini" > À: "Sebastian Tanase" > Cc: aligu...@amazon.com, afaer...@suse.de, r...@twiddle.net, "peter maydell" > , > mich...@walle.cc, a...@alex.org.uk, stefa...@redhat.com, > lcapitul...@redhat.com, crobi...@redhat.com, > arm...@redhat.com, wenchaoq...

Re: [Qemu-devel] [RFC PATCH V4 0/6] icount: Implement delay algorithm between guest and host clocks

2014-07-22 Thread Paolo Bonzini
Il 22/07/2014 16:02, Sebastian Tanase ha scritto: > Yes, QEMU_CLOCK_VIRTUAL counts up from qemu_clock_get_ns(QEMU_CLOCK_REALTIME) > on ARM (I have only tested with the versatilepb and vexpress boards). That's a bug to fix indeed, then---it should count up from 0 without icount, and icount shouldn'

Re: [Qemu-devel] [RFC PATCH V4 0/6] icount: Implement delay algorithm between guest and host clocks

2014-07-22 Thread Sebastian Tanase
- Mail original - > De: "Paolo Bonzini" > À: "Sebastian Tanase" , qemu-devel@nongnu.org > Cc: aligu...@amazon.com, afaer...@suse.de, r...@twiddle.net, "peter maydell" > , > mich...@walle.cc, a...@alex.org.uk, stefa...@redhat.com, > lcapitul...@redhat.com, crobi...@redhat.com, > arm...@

[Qemu-devel] [PATCH 4/4] block/parallels: 2TB+ parallels images support

2014-07-22 Thread Denis V. Lunev
Parallels has released in the recent updates of Parallels Server 5/6 new addition to his image format. Images with signature WithouFreSpacExt have offsets in the catalog coded not as offsets in sectors (multiple of 512 bytes) but offsets coded in blocks (i.e. header->tracks * 512) In this case all

Re: [Qemu-devel] [RFC PATCH V4 6/6] monitor: Add drift info to 'info jit'

2014-07-22 Thread Sebastian Tanase
- Mail original - > De: "Paolo Bonzini" > À: "Sebastian Tanase" > Cc: aligu...@amazon.com, afaer...@suse.de, r...@twiddle.net, "peter maydell" > , > mich...@walle.cc, a...@alex.org.uk, stefa...@redhat.com, > lcapitul...@redhat.com, crobi...@redhat.com, > arm...@redhat.com, wenchaoq...

[Qemu-devel] [PATCH 1/4] block/parallels: extend parallels format header with actual data values

2014-07-22 Thread Denis V. Lunev
Parallels image format has several additional fields inside: - nb_sectors is actually 64 bit wide. Upper 32bits are not used for images with signature "WithoutFreeSpace" and must be explicitely zeroed according to Parallels. They will be used for images with signature "WithouFreSpacExt" - inu

[Qemu-devel] [PATCH 2/4] block/parallels: replace tabs with spaces in block/parallels.c

2014-07-22 Thread Denis V. Lunev
Signed-off-by: Denis V. Lunev CC: Kevin Wolf CC: Stefan Hajnoczi --- block/parallels.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/block/parallels.c b/block/parallels.c index c44df87..8f9ec8a 100644 --- a/block/parallels.c +++ b/block/parallels.c @@ -61,11 +61

[Qemu-devel] [PATCH 0/4] block/parallels: 2TB+ parallels images support

2014-07-22 Thread Denis V. Lunev
Parallels has released in the recent updates of Parallels Server 5/6 new addition to his image format. Images with signature WithouFreSpacExt have offsets in the catalog coded not as offsets in sectors (multiple of 512 bytes) but offsets coded in blocks (i.e. header->tracks * 512) In this case to

[Qemu-devel] [PATCH 3/4] block/parallels: split check for parallels format in parallels_open

2014-07-22 Thread Denis V. Lunev
and rework error path a bit. There is no difference at the moment, but the code will be definitely shorter when additional processing will be required for WithouFreSpacExt Signed-off-by: Denis V. Lunev CC: Kevin Wolf CC: Stefan Hajnoczi --- block/parallels.c | 13 +++-- 1 file changed,

Re: [Qemu-devel] [PULL v2 for-2.1] virtio-rng: Fix abort on invalid input

2014-07-22 Thread Peter Maydell
On 22 July 2014 13:03, Amit Shah wrote: > The following changes since commit 35858955e6c6f9ef41c199d15457c13426ac6434: > > Merge remote-tracking branch 'remotes/afaerber/tags/qom-devices-for-2.1' > into staging (2014-07-21 18:06:12 +0100) > > are available in the git repository at: > > > git:

Re: [Qemu-devel] KVM call for agenda for 2014-07-22

2014-07-22 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Please, send any topic that you are interested in covering. > > Thanks, Juan. > > Call details: > > 15:00 CEST > 13:00 UTC > 09:00 EDT > > Every two weeks > > If you need phone number details, contact me privately No topis, no call. See you in 2 weeks.

Re: [Qemu-devel] [PATCH for-2.1] exec: fix migration with devices that use address_space_rw

2014-07-22 Thread Juan Quintela
Paolo Bonzini wrote: > Devices that use address_space_rw to write large areas to memory > (as opposed to address_space_map/unmap) were broken with respect > to migration since fe680d0 (exec: Limit translation limiting in > address_space_translate to xen, 2014-05-07). Such devices include > IDE CD

Re: [Qemu-devel] Live migrate, inconsistent machine types - new machine type to fix?

2014-07-22 Thread Amit Shah
On (Tue) 22 Jul 2014 [13:19:43], Alex Bligh wrote: > > On 22 Jul 2014, at 13:12, Paolo Bonzini wrote: > > > There's something similar going on with PIIX4_PM but I don't remember > > the details. > > From memory: > > * qemu-1.0 uses the v2 format > * qemu-kvm-1.0 uses the v3 format but advertis

Re: [Qemu-devel] Live migrate, inconsistent machine types - new machine type to fix?

2014-07-22 Thread Amit Shah
On (Tue) 22 Jul 2014 [13:15:41], Alex Bligh wrote: > > On 22 Jul 2014, at 12:54, Amit Shah wrote: > > > Sigh; please read both my replies. > > > > The only difference between qemu-kvm-1.0 and qemu-1.0 is the presence > > of the pci-assign section in qemu-kvm-1.0. All other output from > > qemu

Re: [Qemu-devel] Live migrate, inconsistent machine types - new machine type to fix?

2014-07-22 Thread Amit Shah
On (Tue) 22 Jul 2014 [14:12:00], Paolo Bonzini wrote: > Il 22/07/2014 13:54, Amit Shah ha scritto: > >> > a) because I'm using qemu-kvm-1.0, not qemu-1.0. You looked at qemu-1.0 > >> >in the previous message; that's not directly relevant for what I'm > >> >looking at as my source is qemu-kv

Re: [Qemu-devel] [PATCH v6 1/5] block: Support Archipelago as a QEMU block backend

2014-07-22 Thread Stefan Hajnoczi
On Thu, Jul 10, 2014 at 01:04:54PM +0300, Chrysostomos Nanakos wrote: > On 07/10/2014 03:23 AM, Jeff Cody wrote: > >On Fri, Jun 27, 2014 at 11:24:08AM +0300, Chrysostomos Nanakos wrote: > >>+err_exit: > >>+__sync_add_and_fetch(&segreq->failed, 1); > >>+if (segments_nr == 1) { > >>+i

Re: [Qemu-devel] [PATCH v6 1/5] block: Support Archipelago as a QEMU block backend

2014-07-22 Thread Stefan Hajnoczi
On Fri, Jun 27, 2014 at 11:24:08AM +0300, Chrysostomos Nanakos wrote: > +xseg_set_req_data(s->xseg, req, reqdata); > +if (op == ARCHIP_OP_WRITE) { > +data = xseg_get_data(s->xseg, req); > +if (!data) { > +archipelagolog("Cannot get XSEG data\n"); > +g

Re: [Qemu-devel] [PATCH v2 2/3] tap-bsd: implement a FreeBSD only version of tap_open

2014-07-22 Thread Stefano Stabellini
On Tue, 22 Jul 2014, Roger Pau Monné wrote: > On 27/05/14 15:29, Stefan Hajnoczi wrote: > > On Fri, May 23, 2014 at 05:57:48PM +0200, Roger Pau Monne wrote: > >> The current behaviour of tap_open for BSD systems differ greatly from > >> it's Linux counterpart. Since FreeBSD supports interface renam

Re: [Qemu-devel] Live migrate, inconsistent machine types - new machine type to fix?

2014-07-22 Thread Alex Bligh
On 22 Jul 2014, at 13:12, Paolo Bonzini wrote: > There's something similar going on with PIIX4_PM but I don't remember > the details. From memory: * qemu-1.0 uses the v2 format * qemu-kvm-1.0 uses the v3 format but advertises itself as v2 * qemu-2.1 uses the v3 format I don't quite understand

Re: [Qemu-devel] Live migrate, inconsistent machine types - new machine type to fix?

2014-07-22 Thread Alex Bligh
On 22 Jul 2014, at 12:54, Amit Shah wrote: > Sigh; please read both my replies. > > The only difference between qemu-kvm-1.0 and qemu-1.0 is the presence > of the pci-assign section in qemu-kvm-1.0. All other output from > qemu-1.0 -> qemu-2.1 is equally applicable to qemu-kvm-1.0 -> > qemu-2.

Re: [Qemu-devel] [PULL for-2.1 0/2] Two fixes for KVM and memory

2014-07-22 Thread Peter Maydell
On 22 July 2014 11:51, Paolo Bonzini wrote: > The following changes since commit fa666c10f2f3e15685ff88abd3bc433ddce012d6: > > Revert "kvmclock: Ensure time in migration never goes backward" (2014-07-18 > 15:28:03 +0200) > > are available in the git repository at: > > git://github.com/bonzini

Re: [Qemu-devel] Live migrate, inconsistent machine types - new machine type to fix?

2014-07-22 Thread Paolo Bonzini
Il 22/07/2014 13:54, Amit Shah ha scritto: >> > a) because I'm using qemu-kvm-1.0, not qemu-1.0. You looked at qemu-1.0 >> >in the previous message; that's not directly relevant for what I'm >> >looking at as my source is qemu-kvm-1.0 (qemu vs qemu-kvm). > Sigh; please read both my replies.

[Qemu-devel] [PATCH 1/1] virtio-rng: Add human-readable error message for negative max-bytes parameter

2014-07-22 Thread Amit Shah
From: John Snow If a negative integer is used for the max_bytes parameter, QEMU currently calls abort() and leaves behind a core dump. This patch replaces the abort with a simple error message to make the reason for the termination clearer. This also ensures device-hotplug with invalid input does

[Qemu-devel] [PULL v2 for-2.1] virtio-rng: Fix abort on invalid input

2014-07-22 Thread Amit Shah
The following changes since commit 35858955e6c6f9ef41c199d15457c13426ac6434: Merge remote-tracking branch 'remotes/afaerber/tags/qom-devices-for-2.1' into staging (2014-07-21 18:06:12 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/qemu/amit/virtio-rng.git

Re: [Qemu-devel] Live migrate, inconsistent machine types - new machine type to fix?

2014-07-22 Thread Amit Shah
On (Tue) 22 Jul 2014 [12:38:14], Alex Bligh wrote: > > On 22 Jul 2014, at 11:54, Amit Shah wrote: > >> > >> This one, together with the PIIX4 one (which for some reason doesn't > >> show up) where the two I hit, after manually fixing the rom sizes > >> stuff on the command line. > >> > >> Appar

Re: [Qemu-devel] [PATCH v3] virtio-rng: Add human-readable error message for negative max-bytes parameter

2014-07-22 Thread Amit Shah
On (Tue) 22 Jul 2014 [13:41:43], Markus Armbruster wrote: > Amit Shah writes: > > > On (Mon) 21 Jul 2014 [17:44:37], John Snow wrote: > >> If a negative integer is used for the max_bytes parameter, QEMU currently > >> calls abort() and leaves behind a core dump. This patch adds a simple > >> erro

Re: [Qemu-devel] [PATCH v2 2/3] tap-bsd: implement a FreeBSD only version of tap_open

2014-07-22 Thread Roger Pau Monné
On 27/05/14 15:29, Stefan Hajnoczi wrote: > On Fri, May 23, 2014 at 05:57:48PM +0200, Roger Pau Monne wrote: >> The current behaviour of tap_open for BSD systems differ greatly from >> it's Linux counterpart. Since FreeBSD supports interface renaming and >> tap device cloning by opening /dev/tap, i

[Qemu-devel] [PATCH 2/2] checker: ignore fields marked unused

2014-07-22 Thread Amit Shah
While comparing qemu-1.0 json output with qemu-2.1, a few fields got marked unused. These need to be skipped over, and not flagged as mismatches. For handling unused fields, the exact number of bytes need to be skipped over as the size of the unused field. Signed-off-by: Amit Shah --- scripts/

[Qemu-devel] [PATCH 0/2] vmstate static checker: handle unused fields,

2014-07-22 Thread Amit Shah
Hi, This patchset updates the whitelist and adds handling for 'unused' fields. These were found when comparing qemu-1.0 json output with qemu-2.1 -M pc-1.0. Amit Shah (2): vmstate static checker: whitelist additions checker: ignore fields marked unused scripts/vmstate-static-checker.py | 7

[Qemu-devel] [PATCH 1/2] vmstate static checker: whitelist additions

2014-07-22 Thread Amit Shah
Comparing json outputs from qemu-1.0 with qemu-2.1 turned up a few description name changes; whitelist them here. Signed-off-by: Amit Shah --- scripts/vmstate-static-checker.py | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/scripts/vmstate-static-checker.py

Re: [Qemu-devel] [PATCH v3] virtio-rng: Add human-readable error message for negative max-bytes parameter

2014-07-22 Thread Markus Armbruster
Amit Shah writes: > On (Mon) 21 Jul 2014 [17:44:37], John Snow wrote: >> If a negative integer is used for the max_bytes parameter, QEMU currently >> calls abort() and leaves behind a core dump. This patch adds a simple >> error message to make the reason for the termination clearer. >> >> There

Re: [Qemu-devel] [PATCH v3] virtio-rng: Add human-readable error message for negative max-bytes parameter

2014-07-22 Thread Markus Armbruster
Amit Shah writes: > On (Mon) 21 Jul 2014 [17:44:37], John Snow wrote: >> If a negative integer is used for the max_bytes parameter, QEMU currently >> calls abort() and leaves behind a core dump. This patch adds a simple >> error message to make the reason for the termination clearer. > > It avoid

Re: [Qemu-devel] Live migrate, inconsistent machine types - new machine type to fix?

2014-07-22 Thread Alex Bligh
On 22 Jul 2014, at 11:54, Amit Shah wrote: >> >> This one, together with the PIIX4 one (which for some reason doesn't >> show up) where the two I hit, after manually fixing the rom sizes >> stuff on the command line. >> >> Apparently "flags" and "channels" are pseudonyms. > > No, they're not;

Re: [Qemu-devel] [PATCH] tests: set QEMU_AUDIO_DRV=none for pci sound cards

2014-07-22 Thread Markus Armbruster
Gerd Hoffmann writes: > This way the tests run without sound hardware being present > on the build machine. Even with sound hardware it IMO isn't > very useful to use it in regression testing. Once the sound > card tests are advanced enougth that they try to actually > play sound we probably wa

Re: [Qemu-devel] [PATCH v3] virtio-rng: Add human-readable error message for negative max-bytes parameter

2014-07-22 Thread Amit Shah
On (Mon) 21 Jul 2014 [17:44:37], John Snow wrote: > If a negative integer is used for the max_bytes parameter, QEMU currently > calls abort() and leaves behind a core dump. This patch adds a simple > error message to make the reason for the termination clearer. > > There is an underlying insuffici

Re: [Qemu-devel] [PATCH v3] virtio-rng: Add human-readable error message for negative max-bytes parameter

2014-07-22 Thread Amit Shah
On (Mon) 21 Jul 2014 [17:44:37], John Snow wrote: > If a negative integer is used for the max_bytes parameter, QEMU currently > calls abort() and leaves behind a core dump. This patch adds a simple > error message to make the reason for the termination clearer. It avoids the abort(), which in the

Re: [Qemu-devel] [PATCH for 2.1] ppc: fix -mem-path failure

2014-07-22 Thread Alexander Graf
On 07/21/2014 11:30 AM, Hu Tao wrote: commit e938ba0c tried to enable -mem-path for ppc but breaked some ppc boards. The problems are: 1. it fails when allocating memory for rom, sram whose sizes are less than huge page size: ./ppc-softmmu/qemu-system-ppc -m 512 -mem-path /hugepages/

Re: [Qemu-devel] [PATCH v3] virtio-rng: Add human-readable error message for negative max-bytes parameter

2014-07-22 Thread Markus Armbruster
John Snow writes: > If a negative integer is used for the max_bytes parameter, QEMU currently > calls abort() and leaves behind a core dump. This patch adds a simple > error message to make the reason for the termination clearer. It also avoids the abort, doesn't it? > There is an underlying in

Re: [Qemu-devel] Live migrate, inconsistent machine types - new machine type to fix?

2014-07-22 Thread Amit Shah
On (Tue) 22 Jul 2014 [11:32:41], Alex Bligh wrote: > > On 22 Jul 2014, at 11:22, Amit Shah wrote: > > > Also interesting is qemu 1.0 -> qemu-kvm-1.0: > > > > Section "isa-pit", Description "i8254": expected field "channels", got > > "flags"; skipping rest > > This one, together with the PIIX4

Re: [Qemu-devel] ipv6 slirp network

2014-07-22 Thread Vasiliy Tolstov
2014-07-22 0:49 GMT+04:00 Samuel Thibault : > Alternatively, you can track the parameters branch, which I don't > regenerate. Thanks. Now all works fine. -- Vasiliy Tolstov, e-mail: v.tols...@selfip.ru jabber: v...@selfip.ru

  1   2   >