Amit Shah <amit.s...@redhat.com> writes: > On (Mon) 21 Jul 2014 [17:44:37], John Snow wrote: >> If a negative integer is used for the max_bytes parameter, QEMU currently >> calls abort() and leaves behind a core dump. This patch adds a simple >> error message to make the reason for the termination clearer. > > It avoids the abort(), which in the case of device hot-plug means > there's no termination either. That's the bigger advantage, because > there's no excuse for qemu to just quit when passing nonsensical > values during device hotplug. > >> There is an underlying insufficiency in the parameter parsing code of QEMU >> that renders it unable to reject negative values for unsigned properties, >> thus the error message "a non-negative integer below 2^63" is the most >> user-friendly and correct message we can give until the underlying >> insufficiency is corrected. >> >> Signed-off-by: John Snow <js...@redhat.com> >> --- >> v3: Adjusted the error message to be more semantically meaningful, but >> while acknowledging the limitations of the current unsigned integer >> parsing routines. > > Thanks, I think this qualifies for 2.1, so I'll send it on after > adjusting the commit message a bit.
You may add Reviewed-by: Markus Armbruster <arm...@redhat.com>
