Re: [Qemu-devel] is there a limit on the number of in-flight I/O operations?

2014-07-18 Thread Chris Friesen
On 07/18/2014 11:49 PM, Paolo Bonzini wrote: Il 19/07/2014 00:48, Chris Friesen ha scritto: I forgot about "-drive ...,iops_max=NNN". :) I'm not sure it's actually useful though, since it specifies the max IO operations per second, not the maximum number of in-flight operations. No, that'

Re: [Qemu-devel] Live migrate, inconsistent machine types - new machine type to fix?

2014-07-18 Thread Paolo Bonzini
Il 19/07/2014 01:33, Alex Bligh ha scritto: > I'm trying to migrate between a pc-1.0 machine on qemu 1.0 and a pc-1.0 > machine on qemu-2.0. This appears not to work. > > It looks to me as if at some point along the line the definition of pc-1.0 > has changed (eek). > > The machine was booted w

Re: [Qemu-devel] is there a limit on the number of in-flight I/O operations?

2014-07-18 Thread Paolo Bonzini
Il 19/07/2014 00:48, Chris Friesen ha scritto: >>> >> >> I forgot about "-drive ...,iops_max=NNN". :) > > I'm not sure it's actually useful though, since it specifies the max IO > operations per second, not the maximum number of in-flight operations. No, that's "-drive iops=NNN". QEMU implements

[Qemu-devel] [Bug 1344320] [NEW] qemu-aarch64 cannot execute glibc

2014-07-18 Thread Andreas Schwab
Public bug reported: $ aarch64-linux-user/qemu-aarch64 -version qemu-aarch64 version 2.0.92, Copyright (c) 2003-2008 Fabrice Bellard $ aarch64-linux-user/qemu-aarch64 -d in_asm /daten/build/build-root/home/abuild/rpmbuild/BUILD/glibc-2.19.90/cc-base/elf/ld-linux-aarch64.so.1 host mmap_min_addr=

[Qemu-devel] [PATCH] kvm-all: Use 'tmpcpu' instead of 'cpu' in sub-looping to avoid 'cpu' be NULL

2014-07-18 Thread Chen Gang
If kvm_arch_remove_sw_breakpoint() in CPU_FOREACH() always be fail, it will let 'cpu' NULL. And the next kvm_arch_remove_sw_breakpoint() in QTAILQ_FOREACH_SAFE() will get NULL parameter for 'cpu'. And kvm_arch_remove_sw_breakpoint() can assumes 'cpu' must never be NULL, so need define additional t

Re: [Qemu-devel] [Intel-gfx] ResettRe: [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-07-18 Thread Kay, Allen M
> For the MCH PCI registers that do need to be read - can you tell us which > ones those are? In qemu/hw/xen_pt_igd.c/igd_pci_read(), following MCH PCI config register reads are passthrough to the host HW. Some of the registers are needed by Ironlake GFX driver which we probably can remove.

[Qemu-devel] Live migrate, inconsistent machine types - new machine type to fix?

2014-07-18 Thread Alex Bligh
I'm trying to migrate between a pc-1.0 machine on qemu 1.0 and a pc-1.0 machine on qemu-2.0. This appears not to work. It looks to me as if at some point along the line the definition of pc-1.0 has changed (eek). The machine was booted with the command line [1] below, then migrated (for the sa

Re: [Qemu-devel] is there a limit on the number of in-flight I/O operations?

2014-07-18 Thread Chris Friesen
On 07/18/2014 02:13 PM, Paolo Bonzini wrote: Il 18/07/2014 18:22, Chris Friesen ha scritto: On 07/18/2014 09:24 AM, Paolo Bonzini wrote: Il 18/07/2014 16:58, Chris Friesen ha scritto: I've recently run up against an interesting issue where I had a number of guests running and when I started d

Re: [Qemu-devel] status for rc3/release

2014-07-18 Thread Paolo Bonzini
Il 18/07/2014 22:12, Paolo Bonzini ha scritto: > Il 18/07/2014 19:14, Dr. David Alan Gilbert ha scritto: >> * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: >> (confirmed by running each twice) >> and : >> b18a990c - good >> cab00a5aa - good >> >> This is squashfs on a livecd falling apart aft

Re: [Qemu-devel] [PATCH v2] virtio-rng: Add human-readable error message for negative max-bytes parameter

2014-07-18 Thread Eric Blake
On 07/18/2014 03:14 PM, John Snow wrote: > visit_type_uint32 has a boundary check where it makes sure that the > value given to it is within its range, though it will still convert > negatives "automatically" and depending on the negative given, it might > pass this range check. > visit_type_uint64

Re: [Qemu-devel] [PATCH v2] virtio-rng: Add human-readable error message for negative max-bytes parameter

2014-07-18 Thread John Snow
On 07/18/2014 09:16 AM, Markus Armbruster wrote: Amit Shah writes: On (Fri) 18 Jul 2014 [13:54:01], Markus Armbruster wrote: Amit Shah writes: On (Fri) 18 Jul 2014 [13:15:18], Markus Armbruster wrote: Amit Shah writes: On (Fri) 18 Jul 2014 [08:27:59], Markus Armbruster wrote: John Sn

[Qemu-devel] [PATCH 4/4] block: vpc - use block layer ops in vpc_create, instead of posix calls

2014-07-18 Thread Jeff Cody
Use the block layer to create, and write to, the image file in the VPC .bdrv_create() operation. This has a couple of benefits: Images can now be created over protocols, and host raw file optimizations (such as nocow) do not need to be handled in the image format driver. Signed-off-by: Jeff Cody

[Qemu-devel] [PATCH 2/4] block: vdi - use block layer ops in vdi_create, instead of posix calls

2014-07-18 Thread Jeff Cody
Use the block layer to create, and write to, the image file in the VDI .bdrv_create() operation. This has a couple of benefits: Images can now be created over protocols, and host raw file optimizations (such as nocow) do not need to be handled in the image format driver. Also some minor cleanup f

[Qemu-devel] [PATCH 0/4] Allow VPC and VDI to be created over protocols

2014-07-18 Thread Jeff Cody
This allows VPC and VDI to be created over protocols; currently, they use posix calls directly to open, seek, and write into new image files. This obviously precludes them from being able to be created over a protocol, like glusterfs. Jeff Cody (4): block: allow bdrv_unref() to be passed NULL p

[Qemu-devel] [PATCH 1/4] block: allow bdrv_unref() to be passed NULL pointers

2014-07-18 Thread Jeff Cody
If bdrv_unref() is passed a NULL BDS pointer, it is safe to exit with no operation. This will allow cleanup code to blindly call bdrv_unref() on a BDS that has been initialized to NULL. Signed-off-by: Jeff Cody --- block.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block.c b/block.c

[Qemu-devel] [PATCH 3/4] block: use the standard 'ret' instead of 'result'

2014-07-18 Thread Jeff Cody
Most QEMU code uses 'ret' for function return values. The VDI driver uses a mix of 'result' and 'ret'. This cleans that up, switching over to the standard 'ret' usage. Signed-off-by: Jeff Cody --- block/vdi.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deleti

Re: [Qemu-devel] is there a limit on the number of in-flight I/O operations?

2014-07-18 Thread Paolo Bonzini
Il 18/07/2014 18:22, Chris Friesen ha scritto: > On 07/18/2014 09:24 AM, Paolo Bonzini wrote: >> Il 18/07/2014 16:58, Chris Friesen ha scritto: >>> >>> I've recently run up against an interesting issue where I had a number >>> of guests running and when I started doing heavy disk I/O on a virtio >>

Re: [Qemu-devel] status for rc3/release

2014-07-18 Thread Paolo Bonzini
Il 18/07/2014 19:14, Dr. David Alan Gilbert ha scritto: > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: >> * Peter Maydell (peter.mayd...@linaro.org) wrote: >>> So we just released rc2. The proposed schedule has >>> rc3 next Tuesday, with final release the Tuesday after. >>> >>> My thought

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-18 Thread Paolo Bonzini
Il 18/07/2014 18:32, Andreas Färber ha scritto: > Am 18.07.2014 18:23, schrieb Marcel Apfelbaum: >> On Fri, 2014-07-18 at 18:10 +0200, Andreas Färber wrote: >>> Hi, >>> >>> Am 18.07.2014 17:59, schrieb Marcel Apfelbaum: On Fri, 2014-07-18 at 16:25 +0200, Andreas Färber wrote: > Am 29.06.20

[Qemu-devel] i686 guest failing to start at 50a2c45 (and earlier versions of 2.1-rc) with pc-i440fx-2.1

2014-07-18 Thread Andrey Korolyov
Hello, 2.0 model works fine 2.1 crashes with following: /tmp/buildd/qemu-2.0.92+rev1/hw/i386/smbios.c:825: smbios_get_tables: Assertion `smbios_smp_sockets >= 1' failed Not sure if bisect will help much, but the commit which introduced this platform works well (3458b2b0). arg set follows: /us

Re: [Qemu-devel] [RFC PATCH v1 4/5] VMState test: set the frequency of the vmstate testing process

2014-07-18 Thread Sanidhya Kashyap
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > This feels like a write-only command. How do I query what it is > currently set to? > > I'm also afraid that we aren't learning our lessons from migrate. > Adding one new command per new tunable does not scale very well in > the number of command

[Qemu-devel] [PATCH 6/6] iotests: Add test for image filename construction

2014-07-18 Thread Max Reitz
Testing a real in-use protocol such as NBD is hard; testing blkdebug and blkverify in its stead is easier and tests basically the same functionality. Signed-off-by: Max Reitz --- tests/qemu-iotests/099 | 116 + tests/qemu-iotests/099.out | 20

[Qemu-devel] [PATCH 4/6] nbd: Implement bdrv_refresh_filename()

2014-07-18 Thread Max Reitz
Signed-off-by: Max Reitz --- block/nbd.c | 36 1 file changed, 36 insertions(+) diff --git a/block/nbd.c b/block/nbd.c index 4eda095..89775e1 100644 --- a/block/nbd.c +++ b/block/nbd.c @@ -31,8 +31,10 @@ #include "block/block_int.h" #include "qemu/module.h"

[Qemu-devel] [PATCH 5/6] quorum: Implement bdrv_refresh_filename()

2014-07-18 Thread Max Reitz
Signed-off-by: Max Reitz --- block/quorum.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index d5ee9c0..0de07bb 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -16,7 +16,12 @@ #include #include #include "bloc

[Qemu-devel] [PATCH 2/6] blkdebug: Implement bdrv_refresh_filename()

2014-07-18 Thread Max Reitz
Because blkdebug cannot simply create a configuration file, simply refuse to reconstruct a plain filename and only generate an options QDict from the rules instead. Signed-off-by: Max Reitz --- Instead of this rather complicated implementation, we could decide to just drop it and let this be hand

[Qemu-devel] [PATCH 0/6] block: Let drivers reconstruct the filename

2014-07-18 Thread Max Reitz
We may sometimes want a filename for BDSs which do not have one because they weren't opened using a simple filename (but rather just through options, for example). Some block drivers are always capable of reconstructing a valid filename (e.g. NBD), even if the BDS has been opened using the options

[Qemu-devel] [PATCH 1/6] block: Add bdrv_refresh_filename()

2014-07-18 Thread Max Reitz
Some block devices may not have a filename in their BDS; and for some, there may not even be a normal filename at all. To work around this, add a function which tries to construct a valid filename for the BDS.filename field. If a filename exists or a block driver is able to reconstruct a valid fil

[Qemu-devel] [PATCH 3/6] blkverify: Implement bdrv_refresh_filename()

2014-07-18 Thread Max Reitz
Signed-off-by: Max Reitz --- block/blkverify.c | 29 + 1 file changed, 29 insertions(+) diff --git a/block/blkverify.c b/block/blkverify.c index 621b785..7c78ca4 100644 --- a/block/blkverify.c +++ b/block/blkverify.c @@ -10,6 +10,8 @@ #include #include "qemu/socket

Re: [Qemu-devel] [PATCH v4 3/8] BitmapLog: bitmap dump code via QAPI framework with runstates

2014-07-18 Thread Sanidhya Kashyap
>> +#define RAMBLOCK_NAME_LENGTH (1<<8) > > Be careful; making this bigger would break migration formats, > making it smaller would probably break migration loading. > its the same as previous, will write it explicitly. What I think is that we should make name_length to be global. I have seen at

Re: [Qemu-devel] [PATCH v4 3/8] BitmapLog: bitmap dump code via QAPI framework with runstates

2014-07-18 Thread Sanidhya Kashyap
> > Be careful; lets say that was set to 20ms, you wouldn't > get 50 dumps a second, since you *add* that delay to the > rest of the time in the loop. > > Dave > -- > Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK > yup, true. will definitely change the misleading name and will s

Re: [Qemu-devel] Migration breakage from fe680d0 'exec: Limit translation limiting in address_space_translate to xen'

2014-07-18 Thread Dr. David Alan Gilbert
Hi Alexey, I've got a migration breakage that bisects back to fe680d0 'exec: Limit translation limiting in address_space_translate to xen' I'm told this is unlikely, but it seems to be reliably reproducable and if I comment out the 'xen_enabled() &&' it all works fine. Test system: x86-64 i7-3

Re: [Qemu-devel] [PATCH v4 2/8] RunState: added two new flags for bitmap dump and migration process

2014-07-18 Thread Sanidhya Kashyap
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 >> +# +# @migrate: migration process is being executed +# +# >> @dump-bitmap: dump the writable working set of the guest > > Please document these new flags as (since 2.2). > > How does 'migrate' differ from 'inmigrate' and 'finish-migrate'? > Why do

Re: [Qemu-devel] [PATCH v4 5/8] BitmapLog: cancel mechanism for an already running dump bitmap process

2014-07-18 Thread Sanidhya Kashyap
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > So here you provide HMP and QMP in one patch (fine); but earlier > you separated them between 3/8 and 4/8. Might be nice to be > consistent in the series. > Will separate the patch. >> +{ + .name = "ldbc|log-dirty-bitmap-cancel", >

Re: [Qemu-devel] [PATCH v4 0/8] Obtain dirty bitmap via VM logging

2014-07-18 Thread Dr. David Alan Gilbert
* Sanidhya Kashyap (sanidhya.ii...@gmail.com) wrote: > > > > 1) Do you have some examples of output? > >Can you see hot areas in the kernel or something else? > > > > I looked at it sometimes back. I will try to provide some images (as > suggested by you earlier) to see any consistently used

Re: [Qemu-devel] [PATCH v4 7/8] BitmapLog: get the information about the parameters

2014-07-18 Thread Sanidhya Kashyap
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > > No need to abbreviate. And given my naming question in 3/8, would > this be better as: current-iteration > Okay, I will surely modify it. >> +# +# @epochs: provides the information about the actual epoch > > and iterations > > Wait. Is thi

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2014-07-18 Thread Peter Maydell
Most rececnt qemu-devel discussion and a promising looking approach (ie it would work whereas my idea linked from comment #14 would not): http://lists.gnu.org/archive/html/qemu-devel/2014-02/msg04569.html -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [PATCH v4 0/8] Obtain dirty bitmap via VM logging

2014-07-18 Thread Sanidhya Kashyap
> > 1) Do you have some examples of output? >Can you see hot areas in the kernel or something else? > I looked at it sometimes back. I will try to provide some images (as suggested by you earlier) to see any consistently used areas. > 2) 'frequency' is probably the wrong name for the paramet

Re: [Qemu-devel] status for rc3/release

2014-07-18 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > So we just released rc2. The proposed schedule has > > rc3 next Tuesday, with final release the Tuesday after. > > > > My thought is that we should aim for rc3 to add only > > a fairly sma

Re: [Qemu-devel] is there a limit on the number of in-flight I/O operations?

2014-07-18 Thread Chris Friesen
On 07/18/2014 10:30 AM, Andrey Korolyov wrote: On Fri, Jul 18, 2014 at 8:26 PM, Chris Friesen wrote: On 07/18/2014 09:54 AM, Andrey Korolyov wrote: On Fri, Jul 18, 2014 at 6:58 PM, Chris Friesen wrote: Hi, I've recently run up against an interesting issue where I had a number of guests ru

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-18 Thread Marcel Apfelbaum
On Fri, 2014-07-18 at 18:32 +0200, Andreas Färber wrote: > Am 18.07.2014 18:23, schrieb Marcel Apfelbaum: > > On Fri, 2014-07-18 at 18:10 +0200, Andreas Färber wrote: > >> Hi, > >> > >> Am 18.07.2014 17:59, schrieb Marcel Apfelbaum: > >>> On Fri, 2014-07-18 at 16:25 +0200, Andreas Färber wrote: > >

[Qemu-devel] [PATCH v2] machine: replace underscores in machine's property names

2014-07-18 Thread Marcel Apfelbaum
Replaced '_' with '-' to comply with QOM guidelines. Made the conversion from HMP to QMP in vl.c Signed-off-by: Marcel Apfelbaum --- v1 -> v2: - Addressed Peter Maydell's comments: - Replaced free by g_free to match the allocation. - Rebased to master. hw/core/machine.c | 8 vl.c

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-18 Thread Andreas Färber
Am 18.07.2014 18:23, schrieb Marcel Apfelbaum: > On Fri, 2014-07-18 at 18:10 +0200, Andreas Färber wrote: >> Hi, >> >> Am 18.07.2014 17:59, schrieb Marcel Apfelbaum: >>> On Fri, 2014-07-18 at 16:25 +0200, Andreas Färber wrote: Am 29.06.2014 11:09, schrieb Marcel Apfelbaum: > Replaced '_' w

Re: [Qemu-devel] is there a limit on the number of in-flight I/O operations?

2014-07-18 Thread Andrey Korolyov
On Fri, Jul 18, 2014 at 8:26 PM, Chris Friesen wrote: > On 07/18/2014 09:54 AM, Andrey Korolyov wrote: >> >> On Fri, Jul 18, 2014 at 6:58 PM, Chris Friesen >> wrote: >>> >>> Hi, >>> >>> I've recently run up against an interesting issue where I had a number of >>> guests running and when I started

Re: [Qemu-devel] is there a limit on the number of in-flight I/O operations?

2014-07-18 Thread Chris Friesen
On 07/18/2014 09:54 AM, Andrey Korolyov wrote: On Fri, Jul 18, 2014 at 6:58 PM, Chris Friesen wrote: Hi, I've recently run up against an interesting issue where I had a number of guests running and when I started doing heavy disk I/O on a virtio disk (backed via ceph rbd) the memory consumptio

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-18 Thread Marcel Apfelbaum
On Fri, 2014-07-18 at 18:10 +0200, Andreas Färber wrote: > Hi, > > Am 18.07.2014 17:59, schrieb Marcel Apfelbaum: > > On Fri, 2014-07-18 at 16:25 +0200, Andreas Färber wrote: > >> Am 29.06.2014 11:09, schrieb Marcel Apfelbaum: > >>> Replaced '_' with '-' to comply with QOM guidelines. > >>> Made t

Re: [Qemu-devel] [PATCH v2] virtio-rng: Add human-readable error message for negative max-bytes parameter

2014-07-18 Thread John Snow
On 07/18/2014 09:16 AM, Markus Armbruster wrote: Amit Shah writes: On (Fri) 18 Jul 2014 [13:54:01], Markus Armbruster wrote: Amit Shah writes: On (Fri) 18 Jul 2014 [13:15:18], Markus Armbruster wrote: Amit Shah writes: On (Fri) 18 Jul 2014 [08:27:59], Markus Armbruster wrote: John Sn

Re: [Qemu-devel] is there a limit on the number of in-flight I/O operations?

2014-07-18 Thread Chris Friesen
On 07/18/2014 09:24 AM, Paolo Bonzini wrote: Il 18/07/2014 16:58, Chris Friesen ha scritto: I've recently run up against an interesting issue where I had a number of guests running and when I started doing heavy disk I/O on a virtio disk (backed via ceph rbd) the memory consumption spiked and t

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-18 Thread Andreas Färber
Hi, Am 18.07.2014 17:59, schrieb Marcel Apfelbaum: > On Fri, 2014-07-18 at 16:25 +0200, Andreas Färber wrote: >> Am 29.06.2014 11:09, schrieb Marcel Apfelbaum: >>> Replaced '_' with '-' to comply with QOM guidelines. >>> Made the conversion from HMP to QMP in vl.c >>> >>> Signed-off-by: Marcel Apf

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-18 Thread Marcel Apfelbaum
On Fri, 2014-07-18 at 16:15 +0200, Andreas Färber wrote: > Am 17.07.2014 19:00, schrieb Paolo Bonzini: > > Il 17/07/2014 18:47, Michael Roth ha scritto: > >>> > My argument for getting this into 2.1 had been to avoid tools > >>> picking up > >>> > these to-be-renamed property names from the start.

Re: [Qemu-devel] [RFC PATCH v2 47/49] replay: replay_break command

2014-07-18 Thread Eric Blake
On 07/17/2014 05:06 AM, Pavel Dovgalyuk wrote: > This patch adds support for replay_break monitor command. This command > sets the step (measured in executed instructions) where replay should be > stopped. > > Signed-off-by: Pavel Dovgalyuk > --- > hmp-commands.hx | 14 ++ > mo

Re: [Qemu-devel] [RFC PATCH v2 48/49] replay: replay_seek_step command

2014-07-18 Thread Eric Blake
On 07/17/2014 05:06 AM, Pavel Dovgalyuk wrote: > This patch adds support for replay_seek_step monitor command. This command > loads one of the snapshots and replays the execution until the specified > step is met. > > Signed-off-by: Pavel Dovgalyuk > --- > hmp-commands.hx | 14 +++

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-18 Thread Marcel Apfelbaum
On Fri, 2014-07-18 at 16:25 +0200, Andreas Färber wrote: > Am 29.06.2014 11:09, schrieb Marcel Apfelbaum: > > Replaced '_' with '-' to comply with QOM guidelines. > > Made the conversion from HMP to QMP in vl.c > > > > Signed-off-by: Marcel Apfelbaum > > --- > > hw/core/machine.c | 8 >

Re: [Qemu-devel] [RFC PATCH v2 46/49] replay: replay_info command

2014-07-18 Thread Eric Blake
On 07/17/2014 05:06 AM, Pavel Dovgalyuk wrote: > This patch adds support for replay_info monitor command. This command > returns the information about replay execution (replay mode and current step). > > Signed-off-by: Pavel Dovgalyuk > --- Oh, missed one. > +++ b/qapi-schema.json > +## > +#

Re: [Qemu-devel] [RFC PATCH v2 46/49] replay: replay_info command

2014-07-18 Thread Eric Blake
On 07/17/2014 05:06 AM, Pavel Dovgalyuk wrote: > This patch adds support for replay_info monitor command. This command > returns the information about replay execution (replay mode and current step). > > Signed-off-by: Pavel Dovgalyuk > --- > +++ b/qapi-schema.json > @@ -3491,3 +3491,30 @@ > #

Re: [Qemu-devel] [PULL v2 for-2.1 0/6] target-i386, module, qtest patches for 2014-07-18

2014-07-18 Thread Peter Maydell
On 18 July 2014 14:31, Paolo Bonzini wrote: > The following changes since commit 146ae00192ffcbd78f6b11fa78c72d1b3d628d8a: > > Merge remote-tracking branch 'remotes/agraf/tags/signed-ppc-for-upstream' > into staging (2014-07-15 15:51:12 +0100) > > are available in the git repository at: > > >

Re: [Qemu-devel] is there a limit on the number of in-flight I/O operations?

2014-07-18 Thread Andrey Korolyov
On Fri, Jul 18, 2014 at 6:58 PM, Chris Friesen wrote: > Hi, > > I've recently run up against an interesting issue where I had a number of > guests running and when I started doing heavy disk I/O on a virtio disk > (backed via ceph rbd) the memory consumption spiked and triggered the > OOM-killer.

Re: [Qemu-devel] is there a limit on the number of in-flight I/O operations?

2014-07-18 Thread Paolo Bonzini
Il 18/07/2014 16:58, Chris Friesen ha scritto: > > I've recently run up against an interesting issue where I had a number > of guests running and when I started doing heavy disk I/O on a virtio > disk (backed via ceph rbd) the memory consumption spiked and triggered > the OOM-killer. > > I want t

[Qemu-devel] [Bug 1343827] [NEW] block.c: multiwrite_merge() truncates overlapping requests

2014-07-18 Thread Slava Pestov
Public bug reported: If the list of requests passed to multiwrite_merge() contains two requests where the first is for a range of sectors that is a strict subset of the second's, the second request is truncated to end where the first starts, so the second half of the second request is lost. This

[Qemu-devel] is there a limit on the number of in-flight I/O operations?

2014-07-18 Thread Chris Friesen
Hi, I've recently run up against an interesting issue where I had a number of guests running and when I started doing heavy disk I/O on a virtio disk (backed via ceph rbd) the memory consumption spiked and triggered the OOM-killer. I want to reserve some memory for I/O, but I don't know how

[Qemu-devel] [PATCH v2 for-2.1] po: Update German translation

2014-07-18 Thread Stefan Weil
Line numbers changed, and some translations were missing after commit 3d914488aee3dc1bf495e461aedf8fb4e5bb2270. Update also "Show Tabs" to a more common translation, and remove some old unused lines at the end. Signed-off-by: Stefan Weil --- v2: Rebased. v1 was based not based on the official Q

[Qemu-devel] [PATCH v2 for-2.1] po: Fix Makefile rules for in-tree builds without configuration

2014-07-18 Thread Stefan Weil
Adding 'update' to the phony targets fixes this error: $ LANG=C make -C po update make: Entering directory `/qemu/po' LINK update /qemu/po/de_DE.po: file not recognized: File format not recognized collect2: error: ld returned 1 exit status make: *** [update] Error 1 make: Leaving directory `/qe

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-18 Thread Paolo Bonzini
Il 18/07/2014 16:25, Andreas Färber ha scritto: > Actually, is this really safe? By my reading, this function handles > -object as well, which in turn allows - in theory - to instantiate any > device, where some will still have underscores in their property names. > Not sure if all non-device objec

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-18 Thread Andreas Färber
Am 29.06.2014 11:09, schrieb Marcel Apfelbaum: > Replaced '_' with '-' to comply with QOM guidelines. > Made the conversion from HMP to QMP in vl.c > > Signed-off-by: Marcel Apfelbaum > --- > hw/core/machine.c | 8 > vl.c | 12 +++- > 2 files changed, 15 insertions

Re: [Qemu-devel] [PULL 2/8] Fix new typos in comments (found by codespell)

2014-07-18 Thread Andrey Korolyov
On Fri, Jul 18, 2014 at 6:09 PM, Michael Tokarev wrote: > From: Stefan Weil > > arbitary -> arbitrary > basicly -> basically > > Signed-off-by: Stefan Weil > Signed-off-by: Michael Tokarev > --- > hw/i386/pc_piix.c |2 +- > hw/i386/pc_q35.c |2 +

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-18 Thread Paolo Bonzini
Il 18/07/2014 16:15, Andreas Färber ha scritto: > I was mainly concerned about qom-set, but same goes for qom-get. The > breakage would be in 2.2, if in 2.1 we introduce properties with foo_bar > and rename them to foo-bar in 2.2. Since they're not in 2.0, I had asked > Marcel to rename them for 2.

[Qemu-devel] [PULL 1/8] slirp: Give error message if hostfwd_add/remove for unrecognized vlan/stack

2014-07-18 Thread Michael Tokarev
From: Peter Maydell If the user specified a (vlan ID, slirp stack name) tuple in a monitor hostfwd_add/remove command and we can't find it, give the user an error message rather than silently doing nothing. This brings this error case in slirp_lookup() into line with the other two. Signed-off-b

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-18 Thread Andreas Färber
Am 17.07.2014 19:00, schrieb Paolo Bonzini: > Il 17/07/2014 18:47, Michael Roth ha scritto: >>> > My argument for getting this into 2.1 had been to avoid tools >>> picking up >>> > these to-be-renamed property names from the start. At this point, I'm >>> > not so sure whether it's worse to break ma

[Qemu-devel] [PULL 8/8] tests: Add missing 'static' attributes (fix warnings from smatch)

2014-07-18 Thread Michael Tokarev
From: Stefan Weil Smatch also complains about 0 used for pointers, so replace those by NULL in test-visitor-serialization.c, too. Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- tests/fdc-test.c |2 +- tests/test-aio.c |2 +- tests/tes

[Qemu-devel] [PULL 3/8] qemu-img: Remove redundancy "ret = -1"

2014-07-18 Thread Michael Tokarev
From: Chen Gang In this case, 'ret' is already '-1', so need not do it again. Signed-off-by: Chen Gang Signed-off-by: Michael Tokarev --- qemu-img.c |1 - 1 file changed, 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index c98896b..d4518e7 100644 --- a/qemu-img.c +++ b/qemu-img.c @@

[Qemu-devel] [PULL for-2.1 0/8] Trivial patches for 2014-07-18

2014-07-18 Thread Michael Tokarev
Since we're close to release, I included only really-really-trivial and safe changes in this pull request, -- only those which wont break anything. One good patch is a documentation change mentioning icmp sockets, plus a series from Stefan Weil which adds some missing `static' attributes here and

[Qemu-devel] [PULL 5/8] hw/usb: Add missing 'static' attribute

2014-07-18 Thread Michael Tokarev
From: Stefan Weil Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- hw/usb/hcd-ohci.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c index cace945..13afdf5 100644 --- a/hw/usb/hcd-ohci.c +++ b/hw/usb/hcd-ohci.c @@ -2021,

[Qemu-devel] [PULL 2/8] Fix new typos in comments (found by codespell)

2014-07-18 Thread Michael Tokarev
From: Stefan Weil arbitary -> arbitrary basicly -> basically Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- hw/i386/pc_piix.c |2 +- hw/i386/pc_q35.c |2 +- include/libdecnumber/decNumberLocal.h |2 +- xen-hvm.c

[Qemu-devel] [PULL 4/8] doc: slirp supports ICMP echo if enabled in Linux

2014-07-18 Thread Michael Tokarev
From: Gernot Hillier Since QEMU 0.15, slirp (user mode networking) supports ping to the Internet, see e6d43cfb1f9 Signed-off-by: Gernot Hillier Signed-off-by: Michael Tokarev --- qemu-doc.texi | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/qemu-doc.texi b

[Qemu-devel] [PULL 6/8] qga: Add missing 'static' attribute

2014-07-18 Thread Michael Tokarev
From: Stefan Weil This fixes a warning from the static code analysis (smatch). Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- qga/commands-posix.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 34ddba0..8

[Qemu-devel] [PULL 7/8] migration: Add missing 'static' attribute

2014-07-18 Thread Michael Tokarev
From: Stefan Weil Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- block-migration.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block-migration.c b/block-migration.c index 25a0388..73cdd07 100644 --- a/block-migration.c +++ b/block-migration.c @@ -861,7

Re: [Qemu-devel] [PULL 4/6] module: Don't complain when a module is absent

2014-07-18 Thread Michael Tokarev
18.07.2014 13:04, Paolo Bonzini wrote: > From: Andreas Färber > > The current implementation depends on a configure-time generated list of > block modules. When any of them is absent, module_load() emits a warning. > > This is suboptimal because extracting code to modules was mainly done to > al

Re: [Qemu-devel] [PULL for-2.1 0/4] Block patches

2014-07-18 Thread Peter Maydell
On 18 July 2014 13:41, Stefan Hajnoczi wrote: > The following changes since commit 5a7348045091a2bc15d85bb177e5956aa6114e5a: > > Update version for v2.1.0-rc2 release (2014-07-15 18:55:37 +0100) > > are available in the git repository at: > > git://github.com/stefanha/qemu.git tags/block-pull-

Re: [Qemu-devel] [Intel-gfx] ResettRe: [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-07-18 Thread Konrad Rzeszutek Wilk
On Thu, Jul 17, 2014 at 05:37:12PM +, Kay, Allen M wrote: > > That sounds great. Tiejun could you confirm that with windows driver guys > > too? > > I believe windows driver can also assume specific CPU/PCH combos. I will > discuss this with native Windows driver guys. Preferably, the same

Re: [Qemu-devel] [PATCH v4 0/8] Obtain dirty bitmap via VM logging

2014-07-18 Thread Eric Blake
On 07/18/2014 04:56 AM, Dr. David Alan Gilbert wrote: > * Sanidhya Kashyap (sanidhya.ii...@gmail.com) wrote: >> Hi, >> >> The following patches introduce the support of the dirty bitmap logging and >> dumping to a specified file. This patch addresses the previous issues raised >> by David and Juan.

Re: [Qemu-devel] [PATCH] block/quorum: implement .bdrv_co_get_block_status

2014-07-18 Thread Paolo Bonzini
Il 17/07/2014 13:50, Liu Yuan ha scritto: > - allow drive-mirror to create sprase mirror on images like qcow2 > - allow qemu-img map to work as expected on quorum driver > > Cc: Benoit Canet > Cc: Kevin Wolf > Cc: Stefan Hajnoczi > Signed-off-by: Liu Yuan > --- > block/quorum.c | 16 +

[Qemu-devel] [PULL 6/6] Revert "kvmclock: Ensure time in migration never goes backward"

2014-07-18 Thread Paolo Bonzini
This reverts commit a096b3a6732f846ec57dc28b47ee9435aa0609bf. This patch caused a hang that was fixed by commit 9b17868 (kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation, 2014-06-03), and we just had to revert that commit. Drop this one too. Cc: ag...@suse.de Cc: mtos

[Qemu-devel] [PULL 4/6] module: Don't complain when a module is absent

2014-07-18 Thread Paolo Bonzini
From: Andreas Färber The current implementation depends on a configure-time generated list of block modules. When any of them is absent, module_load() emits a warning. This is suboptimal because extracting code to modules was mainly done to allow separate packaging of modules with intrusive depe

[Qemu-devel] [PULL 2/6] qtest: new test for wdt_ib700

2014-07-18 Thread Paolo Bonzini
Since the "pause" watchdog action had a regression and it went unnoticed for a while, let's add a test for it. Signed-off-by: Paolo Bonzini --- tests/Makefile | 3 ++ tests/wdt_ib700-test.c | 134 + 2 files changed, 137 insertions(+) cre

[Qemu-devel] [PULL 3/6] module: Simplify module_load()

2014-07-18 Thread Paolo Bonzini
From: Andreas Färber The file path is not used for error reporting, so we can free it directly after use. Reviewed-by: Fam Zheng Signed-off-by: Andreas Färber Signed-off-by: Paolo Bonzini --- util/module.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/util/module.

[Qemu-devel] [PULL 5/6] Revert "kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation"

2014-07-18 Thread Paolo Bonzini
This reverts commit 9b1786829aefb83f37a8f3135e3ea91c56001b56. This patch fixed a hang introduced by commit a096b3a (kvmclock: Ensure time in migration never goes backward, 2014-05-16), but it causes a regression in migration whose cause is not quite clear. Because of this, I'm choosing to revert

[Qemu-devel] [PULL 1/6] target-i386: Allow execute from user mode when SMEP is enabled.

2014-07-18 Thread Paolo Bonzini
From: Ricky Zhou Previously, execute would be disabled for all pages with SMEP enabled, regardless of what mode the access took place in. Signed-off-by: Ricky Zhou Signed-off-by: Paolo Bonzini --- target-i386/helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/targe

[Qemu-devel] [PULL v2 for-2.1 0/6] target-i386, module, qtest patches for 2014-07-18

2014-07-18 Thread Paolo Bonzini
The following changes since commit 146ae00192ffcbd78f6b11fa78c72d1b3d628d8a: Merge remote-tracking branch 'remotes/agraf/tags/signed-ppc-for-upstream' into staging (2014-07-15 15:51:12 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for y

[Qemu-devel] USB MTP emulation state?

2014-07-18 Thread Paolo Bonzini
I took a quick look at the MTP emulation and the first things I noticed are: * all I/O is synchronous >> I guess this is just a limitation of the code * it doesn't use the -fsdev infrastructure >> Perhaps we should rename the "root" property to x-root to identify it as

Re: [Qemu-devel] [PATCH v2] virtio-rng: Add human-readable error message for negative max-bytes parameter

2014-07-18 Thread Markus Armbruster
Amit Shah writes: > On (Fri) 18 Jul 2014 [13:54:01], Markus Armbruster wrote: >> Amit Shah writes: >> >> > On (Fri) 18 Jul 2014 [13:15:18], Markus Armbruster wrote: >> >> Amit Shah writes: >> >> >> >> > On (Fri) 18 Jul 2014 [08:27:59], Markus Armbruster wrote: >> >> >> John Snow writes: >> >

Re: [Qemu-devel] [PULL for-2.1 0/6] target-i386, module, qtest patches for 2014-07-18

2014-07-18 Thread Paolo Bonzini
Il 18/07/2014 14:46, Peter Maydell ha scritto: > On 18 July 2014 10:04, Paolo Bonzini wrote: >> The following changes since commit 146ae00192ffcbd78f6b11fa78c72d1b3d628d8a: >> >> Merge remote-tracking branch 'remotes/agraf/tags/signed-ppc-for-upstream' >> into staging (2014-07-15 15:51:12 +0100

Re: [Qemu-devel] [PULL for-2.1 0/6] target-i386, module, qtest patches for 2014-07-18

2014-07-18 Thread Peter Maydell
On 18 July 2014 10:04, Paolo Bonzini wrote: > The following changes since commit 146ae00192ffcbd78f6b11fa78c72d1b3d628d8a: > > Merge remote-tracking branch 'remotes/agraf/tags/signed-ppc-for-upstream' > into staging (2014-07-15 15:51:12 +0100) > > are available in the git repository at: > > >

[Qemu-devel] [PULL for-2.1 3/4] raw-posix: Fail gracefully if no working alignment is found

2014-07-18 Thread Stefan Hajnoczi
From: Kevin Wolf If qemu couldn't find out what O_DIRECT alignment to use with a given file, it would run into assert(bdrv_opt_mem_align(bs) != 0); in block.c and confuse users. This adds a more descriptive error message for such cases. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Signed-

[Qemu-devel] [PULL for-2.1 2/4] block: Add Error argument to bdrv_refresh_limits()

2014-07-18 Thread Stefan Hajnoczi
From: Kevin Wolf Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- block.c | 33 +++-- block/iscsi.c | 3 +-- block/qcow2.c | 4 +--- block/qed.c | 4 +--- block/raw-posix

[Qemu-devel] [PULL for-2.1 0/4] Block patches

2014-07-18 Thread Stefan Hajnoczi
The following changes since commit 5a7348045091a2bc15d85bb177e5956aa6114e5a: Update version for v2.1.0-rc2 release (2014-07-15 18:55:37 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request for you to fetch changes up to 8283c5c316333fb9d2

[Qemu-devel] [PULL for-2.1 4/4] qemu-iotests: fix 028 failure due to disk image path

2014-07-18 Thread Stefan Hajnoczi
The disk image path is echoed by QEMU's readline when the "drive_backup disk ${TEST_IMG}.copy" HMP command is issued. Unfortunately it is very hard to filter out the path due to readline's character-by-character output (with terminal escape sequences). Just redirect this command to /dev/null for

[Qemu-devel] [PULL for-2.1 1/4] qcow2: Fix error path for unknown incompatible features

2014-07-18 Thread Stefan Hajnoczi
From: Kevin Wolf qcow2's report_unsupported_feature() had two bugs: A 32 bit truncation would prevent feature table entries for bits 32-63 from being used, and it could assign errp multiple times if there was more than one unknown feature, resulting in an error_set() assertion failure. Fix the t

Re: [Qemu-devel] [PATCH v4 0/8] Obtain dirty bitmap via VM logging

2014-07-18 Thread Eric Blake
On 07/17/2014 05:21 AM, Sanidhya Kashyap wrote: > Hi, > > The following patches introduce the support of the dirty bitmap logging and > dumping to a specified file. This patch addresses the previous issues raised > by David and Juan. Since, I have not received any comments on the runstates, > I'll

Re: [Qemu-devel] [PATCH v4 7/8] BitmapLog: get the information about the parameters

2014-07-18 Thread Eric Blake
On 07/17/2014 05:21 AM, Sanidhya Kashyap wrote: > Added the qmp interface to know about the information of the bitmap dump > process. When the command is executed, one can know about the current epoch > value in which the process is in, the total iterations value and the current > frequency value.

Re: [Qemu-devel] [PATCH v4 6/8] BitmapLog: set the frequency of the dump bitmap process

2014-07-18 Thread Eric Blake
On 07/17/2014 05:21 AM, Sanidhya Kashyap wrote: > Rectified the example mistake in qmp-commands.hx. Is this comment about a mistake that existed prior to your series, or is it a changelog compared to v1-3 of your posts? If the former, it might be nice to say which existing commit was buggy (so we

Re: [Qemu-devel] [PATCH for-2.1] qemu-iotests: fix 028 failure due to disk image path

2014-07-18 Thread Stefan Hajnoczi
On Thu, Jul 17, 2014 at 07:13:39PM +0100, Stefan Hajnoczi wrote: > The disk image path is echoed by QEMU's readline when the "drive_backup > disk ${TEST_IMG}.copy" HMP command is issued. Unfortunately it is very > hard to filter out the path due to readline's character-by-character > output (with

  1   2   >