Re: [Qemu-devel] [PATCH 4/9] target-ppc: Implement "compat" CPU option

2014-05-20 Thread Alexey Kardashevskiy
On 05/17/2014 06:47 AM, Alexander Graf wrote: > > On 16.05.14 17:17, Alexey Kardashevskiy wrote: >> On 05/17/2014 12:05 AM, Alexander Graf wrote: >>> On 15.05.14 13:28, Alexey Kardashevskiy wrote: This adds basic support for the "compat" CPU option. By specifying the compat property, the

Re: [Qemu-devel] [PATCH 0/6] Obtain dirty bitmap via VM logging

2014-05-20 Thread Sanidhya Kashyap
> > We can do it like this: > https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg02185.html > Thanks. If we are using only one of the threads, then I think we do not require the splitting of the dirty bitmap ( https://lists.gnu.org/archive/html/qemu-devel/2014-05/msg04041.html ). I can dire

Re: [Qemu-devel] [PATCH 0/6] Obtain dirty bitmap via VM logging

2014-05-20 Thread ChenLiang
On 2014/5/21 12:56, Sanidhya Kashyap wrote: > On Wed, May 21, 2014 at 9:43 AM, ChenLiang wrote: >> Hi, >> Nice job. We should avoid running migration_thread and bitmap_logging_thread >> simultaneously. >> > Any particular suggestion to avoid running simultaneous execution of > the threads? > >

Re: [Qemu-devel] [PATCH v2 1/8] xics: Add flags for interrupts

2014-05-20 Thread Alexey Kardashevskiy
On 05/15/2014 07:59 PM, Alexey Kardashevskiy wrote: > The existing interrupt allocation scheme in SPAPR assumes that > interrupts are allocated at the start time, continously and the config > will not change. However, there are cases when this is not going to work > such as: > > 1. migration - we

[Qemu-devel] [PATCH 7/9] KVM: target-ppc: Enable transactional state migration

2014-05-20 Thread Alexey Kardashevskiy
This adds migration support for registers saved before transaction started. Signed-off-by: Alexey Kardashevskiy --- target-ppc/cpu.h | 19 +++ target-ppc/kvm.c | 38 ++ target-ppc/machine.c | 35 +++ 3 fi

[Qemu-devel] [PATCH 3/9] target-ppc: Add POWER7 SPRs

2014-05-20 Thread Alexey Kardashevskiy
This adds TIR/SIAR/SDAR/MMCRA/MMCR0/MMCR1. This redefines UMMCRA (was MCCRA) and defines hypv version of if. Signed-off-by: Alexey Kardashevskiy --- target-ppc/cpu.h| 10 +- target-ppc/translate_init.c | 41 + 2 files changed, 46 inser

[Qemu-devel] [PATCH 0/9] POWER8 patches

2014-05-20 Thread Alexey Kardashevskiy
Here is patchset to improve POWER8 support in QEMU. Patches 1..5 are to enable little-endian guest to boot in TCG mode, this basically defines a bunch of SPR which modern kernels try using. Patch 6 enables migration for some SPRs. Patch 7 enables migration while in transaction. Patches 8, 9 imp

[Qemu-devel] [PATCH 6/9] target-ppc: Enable PPR and VRSAVE SPRs migration

2014-05-20 Thread Alexey Kardashevskiy
Signed-off-by: Alexey Kardashevskiy --- target-ppc/translate_init.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index d23fcc6..82b502a 100644 --- a/target-ppc/translate_init.c +++ b/target-ppc/trans

[Qemu-devel] [PATCH 5/9] target-ppc: Add POWER8 SPRs

2014-05-20 Thread Alexey Kardashevskiy
This adds helper which adds TAR/BESCRS/BESCRSU/BESCRR/BESCRRU/ EBBHR/EBBRR/BESCR/TFHAR/TFIAR/TEXASR/TEXASRU SPRs. This adds MMCR2/FSCR/MMCRS SPRs. Signed-off-by: Alexey Kardashevskiy --- target-ppc/cpu.h| 15 ++ target-ppc/translate_init.c | 123

[Qemu-devel] [PATCH 9/9] spapr_hcall: Add address-translation-mode-on-interrupt resource in H_SET_MODE

2014-05-20 Thread Alexey Kardashevskiy
This adds handling of the RESOURCE_ADDR_TRANS_MODE resource from the H_SET_MODE, for POWER8 (PowerISA 2.07) only. This defines AIL flags for LPCR special register. This changes @excp_prefix according to the mode, takes effect in TCG. This turns support of a new capability PPC2_ISA207S flag for T

[Qemu-devel] [PATCH 1/9] target-ppc: Rename MMCR0/1 contants

2014-05-20 Thread Alexey Kardashevskiy
MMCR0 and MMCR1 have different numbers for 32 and 64 bit POWERPC. We are going to support 64bit versions too so let's rename 32bit ones to avoid confusion. 604 uses same SPR number for MMCR0 so it is included in this patch too. Signed-off-by: Alexey Kardashevskiy --- target-ppc/cpu.h

[Qemu-devel] [PATCH 4/9] target-ppc: Refactor init_proc_POWER8

2014-05-20 Thread Alexey Kardashevskiy
This duplicates code of init_proc_POWER7() in init_proc_POWER8() as there will be registers implemented in POWER7 and missing in POWER8 so we need separate init functions for POWER7 and POWER8. Signed-off-by: Alexey Kardashevskiy --- target-ppc/translate_init.c | 27 ---

[Qemu-devel] [PATCH 2/9] target-ppc: Refactor init_proc_POWER7

2014-05-20 Thread Alexey Kardashevskiy
This moves SPR initialization to helper functions. Signed-off-by: Alexey Kardashevskiy --- target-ppc/translate_init.c | 83 + 1 file changed, 62 insertions(+), 21 deletions(-) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c ind

[Qemu-devel] [PATCH 8/9] spapr_hcall: Split h_set_mode()

2014-05-20 Thread Alexey Kardashevskiy
This moves H_SET_MODE_RESOURCE_LE handler to a separate function as there are other "resources" coming and this is going to becode ugly. Signed-off-by: Alexey Kardashevskiy --- hw/ppc/spapr_hcall.c | 67 +++- 1 file changed, 35 insertions(+), 32 de

Re: [Qemu-devel] [PATCH v20 04/15] block: Move op_blocker check from block_job_create to its caller

2014-05-20 Thread Fam Zheng
On Wed, 05/21 00:34, Jeff Cody wrote: > On Wed, May 21, 2014 at 09:36:08AM +0800, Fam Zheng wrote: > > On Tue, 05/20 07:43, Jeff Cody wrote: > > > On Tue, May 20, 2014 at 02:04:29PM +0800, Fam Zheng wrote: > > > > It makes no sense to check for "any" blocker on bs, we are here only > > > > because

Re: [Qemu-devel] [RFC PATCH v2 0/7] qapi: Specify default value for optional argument in schema json

2014-05-20 Thread Markus Armbruster
Fam Zheng writes: > On Tue, 05/20 13:13, Eric Blake wrote: >> On 05/20/2014 03:07 AM, Fam Zheng wrote: >> > Please first take a look at patch 7 to see what is supported by this >> > series. >> > >> > Patch 1 ~ 3 allows some useful basic types in schema. >> > >> > Patch 4 ~ 6 implements the new

Re: [Qemu-devel] [PATCH 0/6] Obtain dirty bitmap via VM logging

2014-05-20 Thread Sanidhya Kashyap
On Wed, May 21, 2014 at 9:43 AM, ChenLiang wrote: > Hi, > Nice job. We should avoid running migration_thread and bitmap_logging_thread > simultaneously. > Any particular suggestion to avoid running simultaneous execution of the threads? -- Sanidhya

Re: [Qemu-devel] [PATCH v20 04/15] block: Move op_blocker check from block_job_create to its caller

2014-05-20 Thread Jeff Cody
On Wed, May 21, 2014 at 09:36:08AM +0800, Fam Zheng wrote: > On Tue, 05/20 07:43, Jeff Cody wrote: > > On Tue, May 20, 2014 at 02:04:29PM +0800, Fam Zheng wrote: > > > It makes no sense to check for "any" blocker on bs, we are here only > > > because of the mechanical conversion from in_use to op_b

Re: [Qemu-devel] [PATCH 0/6] Obtain dirty bitmap via VM logging

2014-05-20 Thread ChenLiang
Hi, Nice job. We should avoid running migration_thread and bitmap_logging_thread simultaneously. Best regards: ChenLiang > Hi, > > This is the first part of my gsoc work. > > Following patches add the support of dirty bitmap logging and dumping > to a specified file. These patches provide the

[Qemu-devel] fpu/softfloat.c licensing

2014-05-20 Thread Alexey Kardashevskiy
Hi! We recently discovered that not entire QEMU is GPL2-compatible, the fpu emulation has a different license (copied below) which might create legal problems because of that "INDEMNIFY" statement. Does anyone else care (except IBM)? What would the proper solution be? Ask the creator to relicens

Re: [Qemu-devel] [PATCH] iscsi: Fix compile error

2014-05-20 Thread Alexey Kardashevskiy
On 05/21/2014 01:49 PM, Alexey Kardashevskiy wrote: > This fixes compile error when LIBISCSI_FEATURE_IOVECTOR is not defined: > > block/iscsi.c|384 col 13| error: 'iscsi_allocationmap_is_allocated' defined > but not used [-Werror=unused-function] Oops, never mind. Fix is already on its way.

[Qemu-devel] [PATCH] iscsi: Fix compile error

2014-05-20 Thread Alexey Kardashevskiy
This fixes compile error when LIBISCSI_FEATURE_IOVECTOR is not defined: block/iscsi.c|384 col 13| error: 'iscsi_allocationmap_is_allocated' defined but not used [-Werror=unused-function] Signed-off-by: Alexey Kardashevskiy --- block/iscsi.c | 4 +--- 1 file changed, 1 insertion(+), 3 delet

Re: [Qemu-devel] [PATCH] w32: Fix regression caused by new g_poll implementation

2014-05-20 Thread Sangho Park
Thanks for the quick patch. Best Regards, Sangho Park -Original Message- From: qemu-devel-bounces+sangho1206.park=samsung@nongnu.org [mailto:qemu-devel-bounces+sangho1206.park=samsung@nongnu.org] On Behalf Of Stefan Weil Sent: Saturday, May 17, 2014 5:35 PM To: qemu-devel@nongnu.or

[Qemu-devel] [Bug 1321464] Re: qemu/block/qcow2.c:1942: possible performance problem ?

2014-05-20 Thread Max Reitz
notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1321464 Title: qemu/block/qcow2.c:1942: possible performance problem ? Status in QEMU: New Bug description: I just ran static analyser cppcheck over today (20140520) qemu

[Qemu-devel] [PATCH v3] aio: Fix use-after-free in cancellation path

2014-05-20 Thread Fam Zheng
The current flow of canceling a thread from THREAD_ACTIVE state is: 1) Caller wants to cancel a request, so it calls thread_pool_cancel. 2) thread_pool_cancel waits on the conditional variable elem->check_cancel. 3) The worker thread changes state to THREAD_DONE once the task is

Re: [Qemu-devel] [PATCH v2] aio: Fix use-after-free in cancellation path

2014-05-20 Thread Fam Zheng
On Tue, 05/20 16:01, Paolo Bonzini wrote: > Il 20/05/2014 15:16, Stefan Hajnoczi ha scritto: > >On Tue, May 20, 2014 at 10:00:47AM +0800, Fam Zheng wrote: > >>diff --git a/thread-pool.c b/thread-pool.c > >>index fbdd3ff..d4984ba 100644 > >>--- a/thread-pool.c > >>+++ b/thread-pool.c > >>@@ -223,6 +

Re: [Qemu-devel] [PATCH v4 1/3] qapi: fix coding style in parameters list

2014-05-20 Thread Amos Kong
On Mon, May 12, 2014 at 08:57:30PM -0600, Eric Blake wrote: > On 05/07/2014 07:14 PM, Amos Kong wrote: > > The space before pointers is redundant. > > > > Signed-off-by: Amos Kong > > --- > > scripts/qapi-visit.py | 20 ++-- > > 1 file changed, 10 insertions(+), 10 deletions(-) >

Re: [Qemu-devel] [RFC PATCH v2 0/7] qapi: Specify default value for optional argument in schema json

2014-05-20 Thread Fam Zheng
On Tue, 05/20 13:13, Eric Blake wrote: > On 05/20/2014 03:07 AM, Fam Zheng wrote: > > Please first take a look at patch 7 to see what is supported by this series. > > > > Patch 1 ~ 3 allows some useful basic types in schema. > > > > Patch 4 ~ 6 implements the new syntax. > > > > Note: The introd

Re: [Qemu-devel] [PATCH v20 04/15] block: Move op_blocker check from block_job_create to its caller

2014-05-20 Thread Fam Zheng
On Tue, 05/20 07:43, Jeff Cody wrote: > On Tue, May 20, 2014 at 02:04:29PM +0800, Fam Zheng wrote: > > It makes no sense to check for "any" blocker on bs, we are here only > > because of the mechanical conversion from in_use to op_blockers. Remove > > it now, and let the callers check specific oper

Re: [Qemu-devel] [v2][PATCH 4/8] xen, gfx passthrough: reserve 00:02.0 for INTEL IGD

2014-05-20 Thread Chen, Tiejun
> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: Tuesday, May 20, 2014 10:45 PM > To: Chen, Tiejun > Cc: Gerd Hoffmann; stefano.stabell...@eu.citrix.com; m...@redhat.com; > kelly.zyta...@amd.com; peter.mayd...@linaro.org; > xen-de...@lists.xensource.com

Re: [Qemu-devel] [PATCH v3 19/22] target-arm: A64: Register VBAR_EL2

2014-05-20 Thread Edgar E. Iglesias
On Tue, May 20, 2014 at 07:02:37PM +1000, Peter Crosthwaite wrote: > On Mon, May 19, 2014 at 7:23 PM, Edgar E. Iglesias > wrote: > > From: "Edgar E. Iglesias" > > > > Signed-off-by: Edgar E. Iglesias > > --- > > target-arm/cpu.h| 2 +- > > target-arm/helper.c | 20 > >

Re: [Qemu-devel] [PATCH] tests: check empty qmp output visitor

2014-05-20 Thread Michael Roth
Quoting Marcel Apfelbaum (2014-05-20 10:07:59) > Checks the output visitor behaviour for NULL values. > > Signed-off-by: Marcel Apfelbaum > --- > Notes: > - I didn't add Michael's Sob because I tweaked the test a little. Tweaked it so it didn't crash 100% of the time even after your fix? :) A

Re: [Qemu-devel] [v2][PATCH 8/8] xen, gfx passthrough: add opregion mapping

2014-05-20 Thread Chen, Tiejun
> -Original Message- > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > Sent: Tuesday, May 20, 2014 6:51 PM > To: Chen, Tiejun > Cc: Stefano Stabellini; anthony.per...@citrix.com; m...@redhat.com; > kelly.zyta...@amd.com; qemu-devel@nongnu.org; > xen-de...@lists.xensourc

[Qemu-devel] GSoC student self-introduction

2014-05-20 Thread Le Tan
Hi, I am a student participating in GSoC 2014. My brief introduction is given below. I am looking forward to studying QEMU and finishing the GSoC project with the community. Thank you very much! Name: Le Tan IRC nick: #tamlok Public git repo URL: https://github.com/tamlok/qemu.git Project: Intel I

Re: [Qemu-devel] [PATCH 6/6] python script for extracting bitmap from a binary file

2014-05-20 Thread Sanidhya Kashyap
>>> Signed-off-by: Sanidhya Kashyap >>> --- >>> scripts/extract-bitmap.py | 68 >>> +++ >>> 1 file changed, 68 insertions(+) >>> create mode 100755 scripts/extract-bitmap.py > > Does this file need to be mentioned in any Makefile to ensure that it > g

[Qemu-devel] [PATCH 1/2] arch_init: replace fprintf(stderr, ...) with error_report()

2014-05-20 Thread Le Tan
Replace fprintf(stderr,...) with error_report() in the file arch_init.c. The trailing "\n"s of the @fmt argument have been removed because @fmt of error_report() should not contain newline. Signed-off-by: Le Tan --- arch_init.c | 32 +++- 1 file changed, 15 insertio

[Qemu-devel] [PATCH 2/2] block: replace fprintf(stderr, ...) with error_report()

2014-05-20 Thread Le Tan
Replace fprintf(stderr,...) with error_report() in files block/*, block.c, block-migration.c and blockdev.c. The trailing "\n"s of the @fmt argument have been removed because @fmt of error_report() should not contain newline. Signed-off-by: Le Tan --- block-migration.c |5 +-- block.c

[Qemu-devel] [PATCH 0/2] replace some fprintf(stderr, ...) with error_report()

2014-05-20 Thread Le Tan
This series of patches replaces some more occurrences of fprintf(stderr, ...) with error_report() and removes the trailing "\n". Those for debugging are not changed. Le Tan (2): arch_init: replace fprintf(stderr,...) with error_report() block: replace fprintf(stderr,...) with error_report()

Re: [Qemu-devel] Help needed testing on ppc

2014-05-20 Thread BALATON Zoltan
On Wed, 7 May 2014, Tom Musta wrote: On 5/6/2014 6:17 PM, BALATON Zoltan wrote: On Tue, 6 May 2014, Tom Musta wrote: On 5/6/2014 5:03 AM, BALATON Zoltan wrote: I'd appreciate some insight and help. [snip] (1) Why is MorphOS using this invalid instruction form? Would it be easier to fix the

Re: [Qemu-devel] [PATCH v2] qga: Add 'mountpoints' argument to guest-fsfreeze-freeze command

2014-05-20 Thread Eric Blake
On 05/20/2014 04:01 PM, Tomoki Sekiyama wrote: > The patch below is for the command to get filesystems list. > > === > From: Tomoki Sekiyama You'll want to resend it as a series of patches as a top-level thread; not everyone notices a patch buried as a reply. > > qga: Add guest-get-fs-info com

Re: [Qemu-devel] [PATCH qom v5 0/2] Named GPIOs

2014-05-20 Thread Peter Maydell
On 20 May 2014 07:30, Peter Crosthwaite wrote: > This series implements Named GPIOs on the qdev level. Patch 1 is the > feature presentation. I'm way behind on my review queue, but hopefully I can find time to do the conversion of the GIC GPIOs -- I think that's the major device with a really cum

Re: [Qemu-devel] [PATCH qom v5 0/2] Named GPIOs

2014-05-20 Thread Peter Crosthwaite
On Tue, May 20, 2014 at 7:49 PM, Andreas Färber wrote: > Am 20.05.2014 08:30, schrieb Peter Crosthwaite: >> This series implements Named GPIOs on the qdev level. Patch 1 is the >> feature presentation. >> >> Second patch I give a useful example of the feature's use (an SSI >> cleanup). >> >> This

Re: [Qemu-devel] [PATCH qom v5 2/2] ssi: Name the CS GPIO.

2014-05-20 Thread Peter Crosthwaite
On Tue, May 20, 2014 at 7:53 PM, Andreas Färber wrote: > Am 20.05.2014 08:31, schrieb Peter Crosthwaite: >> To get it out of the default GPIO list. This allows child devices to >> use the un-named GPIO namespace without having to be SSI aware. That >> is, there is no more need for machines to know

Re: [Qemu-devel] [PATCH v2] qga: Add 'mountpoints' argument to guest-fsfreeze-freeze command

2014-05-20 Thread Tomoki Sekiyama
> On 04/28/2014 09:25 AM, Tomoki Sekiyama wrote: >> When an array of mount point paths is specified as 'mountpoints' argument >> of guest-fsfreeze-freeze, qemu-ga with this patch will only freeze the file >> systems mounted on specified paths in Linux. > > How does the management application learn

Re: [Qemu-devel] [PATCH v2] qga: Add 'mountpoints' argument to guest-fsfreeze-freeze command

2014-05-20 Thread Tomoki Sekiyama
> On 04/28/2014 09:25 AM, Tomoki Sekiyama wrote: >> When an array of mount point paths is specified as 'mountpoints' argument >> of guest-fsfreeze-freeze, qemu-ga with this patch will only freeze the file >> systems mounted on specified paths in Linux. > > How does the management application learn

[Qemu-devel] [Bug 1321464] [NEW] qemu/block/qcow2.c:1942: possible performance problem ?

2014-05-20 Thread dcb
Public bug reported: I just ran static analyser cppcheck over today (20140520) qemu source code. It said many things, including [qemu/block/qcow2.c:1942] -> [qemu/block/qcow2.c:1943]: (performance) Buffer 'pad_buf' is being writ ten before its old content has been used. S

Re: [Qemu-devel] [PATCH 3/3] target-i386: get CPL from SS.DPL

2014-05-20 Thread Kevin O'Connor
On Fri, May 16, 2014 at 09:59:25PM +0200, Paolo Bonzini wrote: > CS.RPL is not equal to the CPL in the few instructions between > setting CR0.PE and reloading CS. We get this right in the common > case, because writes to CR0 do not modify the CPL, but it would > not be enough if an SMI comes exact

[Qemu-devel] [PATCH 3/3] target-xtensa: add tests for cross-page TB

2014-05-20 Thread Max Filippov
Signed-off-by: Max Filippov --- tests/tcg/xtensa/test_mmu.S | 220 1 file changed, 220 insertions(+) diff --git a/tests/tcg/xtensa/test_mmu.S b/tests/tcg/xtensa/test_mmu.S index 37174b9..58c5bca 100644 --- a/tests/tcg/xtensa/test_mmu.S +++ b/tests/tcg

[Qemu-devel] [PATCH 2/3] target-xtensa: completely clean TLB between MMU tests

2014-05-20 Thread Max Filippov
Signed-off-by: Max Filippov --- tests/tcg/xtensa/test_mmu.S | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/tests/tcg/xtensa/test_mmu.S b/tests/tcg/xtensa/test_mmu.S index 099031f..37174b9 100644 --- a/tests/tcg/xtensa/test_mmu.S +++ b/tests/tcg/xte

[Qemu-devel] [PATCH 1/3] target-xtensa: fix cross-page jumps/calls at the end of TB

2014-05-20 Thread Max Filippov
Use tb->pc instead of dc->pc to check for cross-page jumps. When TB translation stops at the page boundary dc->pc points to the next page allowing chaining to TBs in it, which is wrong. Cc: qemu-sta...@nongnu.org Signed-off-by: Max Filippov --- target-xtensa/translate.c | 4 ++-- 1 file changed,

[Qemu-devel] [PATCH 0/3] target-xtensa: fix cross-page jumps/calls at the end of TB

2014-05-20 Thread Max Filippov
Hi, this series fixes cross-page TB linking bug in target-xtensa that managed to survive for a major release period. With this bug fixed it is finally possible to build linux kernel under xtensa linux running in system mode QEMU (but it may take a couple of days to complete). Max Filippov (3):

[Qemu-devel] [PATCH] target-i386: Fix vm86 mode regression introduced in fd460606fd6f.

2014-05-20 Thread Kevin O'Connor
Commit fd460606fd6f moved setting of eflags above calls to cpu_x86_load_seg_cache() in seg_helper.c. Unfortunately, in do_interrupt_protected() this moved the clearing of VM_MASK above a test for it. Fix this regression by storing the value of VM_MASK at the start of do_interrupt_protected(). Si

[Qemu-devel] [PATCH] iotests: Use _img_info in test 089

2014-05-20 Thread Max Reitz
Currently, test 089 uses $QEMU_IMG info manually in order to obtain the according output. However, the iotests should generally use _img_info as this filters out more irrelevant information such as the host image size or format specific information. Therefore, test 089 should use _img_info as well.

[Qemu-devel] [PATCH v2 6/7] iotests: Drop Python version from 065's Shebang

2014-05-20 Thread Max Reitz
Test 065 specified python2 to be used in its Shebang; this might not work on systems without a python2 symlink and furthermore it is now counter-productive, as the check script compares the Shebang to "#!/usr/bin/env python" and only uses the Python interpreter selected by configure on an exact mat

[Qemu-devel] [PATCH v2 4/7] iotests: Source common.env

2014-05-20 Thread Max Reitz
Source common.env in the iotests' check script. If the one supposed to be created by configure cannot be found, use common.env.default from the source tree. Signed-off-by: Max Reitz --- tests/qemu-iotests/check | 16 1 file changed, 16 insertions(+) diff --git a/tests/qemu-iote

[Qemu-devel] [PATCH v2 3/7] iotests: Add default common.env

2014-05-20 Thread Max Reitz
Add a default common.env in case the one supposed to be emitted by configure cannot be found. Signed-off-by: Max Reitz --- tests/qemu-iotests/common.env.default | 6 ++ 1 file changed, 6 insertions(+) create mode 100644 tests/qemu-iotests/common.env.default diff --git a/tests/qemu-iotests/

[Qemu-devel] [PATCH v2 5/7] iotests: Use $PYTHON for Python scripts

2014-05-20 Thread Max Reitz
Instead of invoking Python scripts directly via ./, use $PYTHON to obtain the correct Python interpreter command. Signed-off-by: Max Reitz --- tests/qemu-iotests/031 | 8 tests/qemu-iotests/036 | 6 +++--- tests/qemu-iotests/039 | 18 +- tests/qemu-iotests/054

[Qemu-devel] [PATCH v2 2/7] configure: Enable out-of-tree iotests

2014-05-20 Thread Max Reitz
In order to allow out-of-tree iotests, create a symlink for the check script in the build tree. While doing so, also write configured options relevant to the iotests to common.env in the build tree; currently, this is the command to invoke Python 2. Signed-off-by: Max Reitz --- configure | 12 +

[Qemu-devel] [PATCH v2 7/7] iotests: Fix 083 for out-of-tree builds

2014-05-20 Thread Max Reitz
iotest 083 filters out debug messages from nbd, which are prefixed (and recognized) by __FILE__. However, the current filter (/^nbd\.c…/) is valid for in-tree builds only, as out-of-tree builds will have a path before that filename (e.g. "/tmp/qemu/nbd.c"). Fix this by adding .* before "nbd\.c". W

[Qemu-devel] [PATCH v2 1/7] iotests: Allow out-of-tree run

2014-05-20 Thread Max Reitz
As out-of-tree builds are preferred for qemu, running the qemu-iotests in that out-of-tree build should be supported as well. To do so, a symbolic link has to be created pointing to the check script in the source directory. That script will check whether it has been run through a symlink, and if so

[Qemu-devel] [PATCH v2 0/7] iotests: Allow out-of-tree run

2014-05-20 Thread Max Reitz
This series enables qemu-iotests to be run in a build tree outside of the source tree. It also makes the tests use the command for invoking the Python interpreter specified through configure instead of always using "/usr/bin/env python". v2: - Patch 1: - added error handling for obtaining the

Re: [Qemu-devel] [PATCH] qga: Fix handle fd leak in acquire_privilege()

2014-05-20 Thread Michael Roth
Quoting Luiz Capitulino (2014-05-20 14:17:42) > On Mon, 19 May 2014 15:26:03 +0800 > wrote: > > > From: Gonglei > > > > token should be closed in all conditions. > > So move CloseHandle(token) to "out" branch. > > Looks good to me. Michael, are you going to pick this one? Sure I'll queue it.

Re: [Qemu-devel] [PATCH 6/6] python script for extracting bitmap from a binary file

2014-05-20 Thread Eric Blake
On 05/20/2014 01:38 PM, Eric Blake wrote: > On 05/20/2014 11:47 AM, Sanidhya Kashyap wrote: >> This script extracts the bitmap only from a binary file. It takes only >> a single input as file. This will be useful to users for exploring the >> writable working set for the VM. >> >> Signed-off-by: Sa

Re: [Qemu-devel] [PATCH 6/6] python script for extracting bitmap from a binary file

2014-05-20 Thread Eric Blake
On 05/20/2014 11:47 AM, Sanidhya Kashyap wrote: > This script extracts the bitmap only from a binary file. It takes only > a single input as file. This will be useful to users for exploring the > writable working set for the VM. > > Signed-off-by: Sanidhya Kashyap > --- > scripts/extract-bitmap.

Re: [Qemu-devel] [PATCH 5/6] set the frequency of the dump bitmap process

2014-05-20 Thread Eric Blake
On 05/20/2014 11:47 AM, Sanidhya Kashyap wrote: > This patch introduces both qmp and hmp (log-dirty-bitmap-set-frequency) > interface to update the value of the frequency. > > Signed-off-by: Sanidhya Kashyap > --- > +++ b/qapi-schema.json > @@ -4715,3 +4715,11 @@ > # cancel the dirty bitmap log

Re: [Qemu-devel] [PATCH 4/6] cancel mechanism for an already running dump bitmap process

2014-05-20 Thread Eric Blake
On 05/20/2014 11:47 AM, Sanidhya Kashyap wrote: > This patch introduces both hmp and qmp (log-dirty-bitmap-cancel) interface > to cancel an already executing dump process. > > Signed-off-by: Sanidhya Kashyap > --- > +++ b/qapi-schema.json > @@ -4710,3 +4710,8 @@ > '*epochs'

Re: [Qemu-devel] [PATCH 2/6] bitmap dump code via QAPI framework

2014-05-20 Thread Sanidhya Kashyap
>> +#define QERR_LOG_DIRTY_BITMAP_ACTIVE \ >> +ERROR_CLASS_GENERIC_ERROR, "Dirty bitmap dump already in progress" >> + > > Please don't add new ERROR_CLASS macros. Instead, just use error_setg() > and directly output the error message at the call site that produces the > error. > will keep in

Re: [Qemu-devel] [RFC PATCH v2 2/7] qapi: Allow true, false and null in schema json

2014-05-20 Thread Eric Blake
On 05/20/2014 03:07 AM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > scripts/qapi.py | 24 +--- > 1 file changed, 17 insertions(+), 7 deletions(-) I applied this patch and tried to break things. Pre-patch, { 'random': tru } => foo.json:1:13: Stray "t" { 'random': true

Re: [Qemu-devel] [PATCH] qga: Fix handle fd leak in acquire_privilege()

2014-05-20 Thread Luiz Capitulino
On Mon, 19 May 2014 15:26:03 +0800 wrote: > From: Gonglei > > token should be closed in all conditions. > So move CloseHandle(token) to "out" branch. Looks good to me. Michael, are you going to pick this one? > > Signed-off-by: Wang Rui > Signed-off-by: Gonglei > --- > qga/commands-win32.

Re: [Qemu-devel] [PATCH] virtio-balloon: return empty data when no stats are available

2014-05-20 Thread Luiz Capitulino
On Mon, 19 May 2014 08:41:21 +0200 Ján Tomko wrote: > If the guest hasn't updated the stats yet, instead of returning > an error, return '-1' for the stats and '0' as 'last-update'. > > This lets applications ignore this without parsing the error message. > > Related libvirt patch and discussio

Re: [Qemu-devel] [RFC PATCH v2 0/7] qapi: Specify default value for optional argument in schema json

2014-05-20 Thread Eric Blake
On 05/20/2014 03:07 AM, Fam Zheng wrote: > Please first take a look at patch 7 to see what is supported by this series. > > Patch 1 ~ 3 allows some useful basic types in schema. > > Patch 4 ~ 6 implements the new syntax. > > Note: The introduced '@arg' sigil, just like the preexisting '*arg', is

Re: [Qemu-devel] [PATCH 2/6] bitmap dump code via QAPI framework

2014-05-20 Thread Eric Blake
On 05/20/2014 11:47 AM, Sanidhya Kashyap wrote: > This patch introduces the mechanism of dumping the dirty bitmap either > in an ascii format or binary format. The implementation is almost > similar to the migration one. A separate thread is created for the > dumping process. > > The bitmap is obt

Re: [Qemu-devel] [PATCH v4 0/3] SMBIOS cleanup round

2014-05-20 Thread Gabriel L. Somlo
On Mon, May 19, 2014 at 10:44:48PM +0300, Michael S. Tsirkin wrote: > Thanks! > One question: we don't seem to have unit-test for this > interface in qemu, do we? > I would like to see at least a basic test along the lines of > tests/acpi-test.c: run bios to load tables from QEMU, > then do some ba

Re: [Qemu-devel] [PATCH] qapi: zero-initialize all QMP command parameters

2014-05-20 Thread Michael Roth
Quoting Peter Maydell (2014-05-20 13:21:15) > On 20 May 2014 18:20, Michael Roth wrote: > > In general QMP command parameter values are specified by consumers of the > > QMP/HMP interface, but in the case of optional parameters these values may > > be left uninitialized. > > > > It is considered a

Re: [Qemu-devel] [PATCH] doc: add "setup" to list of migration states

2014-05-20 Thread Luiz Capitulino
On Fri, 16 May 2014 10:40:47 -0400 pe...@gridcentric.ca wrote: > From: Peter Feiner > > On a slow VM (e.g., nested), you see the "setup" state when you query the > migration status. > > Signed-off-by: Peter Feiner Applied to the qmp branch, thanks. > --- > qapi-schema.json |2 +- > qmp-

[Qemu-devel] [PATCH] scripts/qapi.py: Avoid syntax not supported by Python 2.4

2014-05-20 Thread Luiz Capitulino
The Python "except Foo as x" syntax was only introduced in Python 2.6, but we aim to support Python 2.4 and later. Use the old-style "except Foo, x" syntax instead, thus fixing configure/compile on systems with older Python. Reported-by: Peter Maydell Signed-off-by: Luiz Capitulino --- scripts/

Re: [Qemu-devel] [PATCH] qapi: zero-initialize all QMP command parameters

2014-05-20 Thread Peter Maydell
On 20 May 2014 18:20, Michael Roth wrote: > In general QMP command parameter values are specified by consumers of the > QMP/HMP interface, but in the case of optional parameters these values may > be left uninitialized. > > It is considered a bug for code to make use of optional parameters that ha

[Qemu-devel] [PULL 3/4] block: iscsi build fix if LIBISCSI_FEATURE_IOVECTOR is not defined

2014-05-20 Thread Paolo Bonzini
From: Jeff Cody Commit b03c380 introduced the function iscsi_allocationmap_is_allocated(), however it is only used within a code block that is conditionally compiled. This produces a warning (error with -werror) of "defined but not used" for the the function, if LIBISCSI_FEATURE_IOVECTOR is not

[Qemu-devel] [PULL 4/4] megasas: remove buildtime strings

2014-05-20 Thread Paolo Bonzini
From: Olaf Hering Using __DATE__ or __TIME__ in binary pkgs changes the checksum of compiled binaries if they get rebuilt, even if there are no other source changes. Replace the dynamic strings with some equally informative static strings. Signed-off-by: Olaf Hering Signed-off-by: Paolo Bonzin

[Qemu-devel] [PULL 00/15] SCSI changes for 2014-05-20

2014-05-20 Thread Paolo Bonzini
Peter, The following changes since commit 6a86dec61921163b6ab582df988416a6f0ca0ed5: [PATCH] block/iscsi: bump year in copyright notice (2014-05-05 10:04:30 +0200) are available in the git repository at: git://github.com/bonzini/qemu.git scsi-next for you to fetch changes up to 5a7733b0b728

[Qemu-devel] [PULL 2/4] virtio-scsi: Plug memory leak on virtio_scsi_push_event() error path

2014-05-20 Thread Paolo Bonzini
From: Markus Armbruster Spotted by Coverity. Signed-off-by: Markus Armbruster Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index b0d7517..91

[Qemu-devel] [PULL 1/4] scsi: Document intentional fall through in scsi_req_length()

2014-05-20 Thread Paolo Bonzini
From: Markus Armbruster For clarity, and to hush up Coverity. Signed-off-by: Markus Armbruster Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-bus.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c index ae921a6..26770fb 100644 --- a/hw/scsi/scsi-bus

Re: [Qemu-devel] [PATCH 6/6] docs: add multiseat.txt

2014-05-20 Thread Paolo Bonzini
Il 20/05/2014 16:00, Gerd Hoffmann ha scritto: + -device pci-bridge,addr=12.0,chassis_nr=2,id=head.2 \ + -device secondary-vga,bus=head.2,addr=02.0,id=video.2 \ + -device nec-usb-xhci,bus=head.2,addr=0f.0,id=usb.2 \ + -device usb-kbd,bus=usb.2.0,port=1,display=video.2 \ +

[Qemu-devel] [PATCH 3/6] hmp interface for dirty bitmap dump

2014-05-20 Thread Sanidhya Kashyap
Added the log-dirty-bitmap or ldb hmp interface. Signed-off-by: Sanidhya Kashyap --- hmp-commands.hx | 17 + hmp.c | 19 +++ hmp.h | 1 + 3 files changed, 37 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index 8971f1b..032a320

Re: [Qemu-devel] [PATCH] qapi: zero-initialize all QMP command parameters

2014-05-20 Thread Markus Armbruster
Michael Roth writes: > In general QMP command parameter values are specified by consumers of the > QMP/HMP interface, but in the case of optional parameters these values may > be left uninitialized. > > It is considered a bug for code to make use of optional parameters that have > not been flagge

[Qemu-devel] [PATCH 6/6] python script for extracting bitmap from a binary file

2014-05-20 Thread Sanidhya Kashyap
This script extracts the bitmap only from a binary file. It takes only a single input as file. This will be useful to users for exploring the writable working set for the VM. Signed-off-by: Sanidhya Kashyap --- scripts/extract-bitmap.py | 68 +++ 1 fil

[Qemu-devel] [PATCH 5/6] set the frequency of the dump bitmap process

2014-05-20 Thread Sanidhya Kashyap
This patch introduces both qmp and hmp (log-dirty-bitmap-set-frequency) interface to update the value of the frequency. Signed-off-by: Sanidhya Kashyap --- hmp-commands.hx | 15 +++ hmp.c| 12 hmp.h| 1 + qapi-schema.json | 8 qmp-comm

[Qemu-devel] [PATCH 2/6] bitmap dump code via QAPI framework

2014-05-20 Thread Sanidhya Kashyap
This patch introduces the mechanism of dumping the dirty bitmap either in an ascii format or binary format. The implementation is almost similar to the migration one. A separate thread is created for the dumping process. The bitmap is obtained with the help of ramlist blocks. I have used almost si

[Qemu-devel] [PATCH 1/6] split dirty bitmap into four for dumping the bitmaps

2014-05-20 Thread Sanidhya Kashyap
Added another flag - DIRTY_MEMORY_LOG_BITMAP for the purpose of logging the dirty bitmap. The dumping bitmap process will utilize this flag for dumping the data in the file. Signed-off-by: Sanidhya Kashyap --- exec.c | 4 include/exec/memory.h | 3 ++- include/exec/ram_

[Qemu-devel] [PATCH 4/6] cancel mechanism for an already running dump bitmap process

2014-05-20 Thread Sanidhya Kashyap
This patch introduces both hmp and qmp (log-dirty-bitmap-cancel) interface to cancel an already executing dump process. Signed-off-by: Sanidhya Kashyap --- hmp-commands.hx | 14 ++ hmp.c| 5 + hmp.h| 1 + qapi-schema.json | 5 + qmp-commands.hx |

[Qemu-devel] [PATCH 0/6] Obtain dirty bitmap via VM logging

2014-05-20 Thread Sanidhya Kashyap
Hi, This is the first part of my gsoc work. Following patches add the support of dirty bitmap logging and dumping to a specified file. These patches provide the mechanism to get the dirty bitmap if the user wants to log the VM besides migration. This can be useful in case of learning about the wr

[Qemu-devel] [PATCH] qapi: zero-initialize all QMP command parameters

2014-05-20 Thread Michael Roth
In general QMP command parameter values are specified by consumers of the QMP/HMP interface, but in the case of optional parameters these values may be left uninitialized. It is considered a bug for code to make use of optional parameters that have not been flagged as being present by the marshall

[Qemu-devel] [PATCH v2 30/31] pc: ACPI BIOS: reserve SRAT entry for hotplug mem hole

2014-05-20 Thread Igor Mammedov
Needed for Windows to use hotplugged memory device, otherwise it complains that server is not configured for memory hotplug. Tests shows that aftewards it uses dynamically provided proximity value from _PXM() method if available. Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 14 +

[Qemu-devel] [PATCH v4 4/4] sclp-s390: Add memory hotplug SCLPs

2014-05-20 Thread Matthew Rosato
Add memory information to read SCP info and add handlers for Read Storage Element Information, Attach Storage Element, Assign Storage and Unassign Storage. Signed-off-by: Matthew Rosato --- hw/s390x/sclp.c| 259 ++-- target-s390x/cpu.h | 15

[Qemu-devel] [PATCH v4 1/4] vl.c: extend -m option to support options for memory hotplug

2014-05-20 Thread Matthew Rosato
From: Igor Mammedov From: Igor Mammedov Add following parameters: "slots" - total number of hotplug memory slots "maxmem" - maximum possible memory "slots" and "maxmem" should go in pair and "maxmem" should be greater than "mem" for memory hotplug to be enabled. Signed-off-by: Igor Mammed

[Qemu-devel] [PATCH v4 0/4] s390: Support for Hotplug of Standby Memory

2014-05-20 Thread Matthew Rosato
This patchset adds support in s390 for a pool of standby memory, which can be set online/offline by the guest (ie, via chmem). New options, maxmem and slots, are added to the QEMU command line memory parameter to specify the total amount of memory available to the guest as well as the number of me

[Qemu-devel] [PATCH v4 3/4] virtio-ccw: Include standby memory when calculating storage increment

2014-05-20 Thread Matthew Rosato
When determining the memory increment size, use the maxmem size if it was specified. Signed-off-by: Matthew Rosato --- hw/s390x/s390-virtio-ccw.c | 46 qemu-options.hx|3 ++- target-s390x/cpu.h |3 +++ 3 files changed, 43

[Qemu-devel] [PATCH v4 2/4] sclp-s390: Add device to manage s390 memory hotplug

2014-05-20 Thread Matthew Rosato
Add sclpMemoryHotplugDev to contain associated data structures, etc. Signed-off-by: Matthew Rosato --- hw/s390x/sclp.c | 38 ++ include/hw/s390x/sclp.h | 20 2 files changed, 58 insertions(+) diff --git a/hw/s390x/sclp.c b/hw/

Re: [Qemu-devel] [PATCH v2 06/31] pc: create custom generic PC machine type

2014-05-20 Thread Marcel Apfelbaum
On Tue, 2014-05-20 at 17:15 +0200, Igor Mammedov wrote: > it will be used for PC specific options/variables > > Signed-off-by: Igor Mammedov > --- > hw/i386/pc.c | 57 > ++ > hw/i386/pc_piix.c| 36 +++--- >

Re: [Qemu-devel] [PATCH v2 18/31] acpi: rename cpu_hotplug_defs.h to acpi_defs.h

2014-05-20 Thread Igor Mammedov
On Tue, 20 May 2014 18:35:33 +0300 "Michael S. Tsirkin" wrote: > On Tue, May 20, 2014 at 05:15:21PM +0200, Igor Mammedov wrote: > > to make it more generic, so it could be used for memory hotplug > > as well. > > > > Signed-off-by: Igor Mammedov > > These are actually qemu pc specific hotplug

  1   2   3   >