On 05/20/2014 11:47 AM, Sanidhya Kashyap wrote: > This patch introduces both hmp and qmp (log-dirty-bitmap-cancel) interface > to cancel an already executing dump process. > > Signed-off-by: Sanidhya Kashyap <sanidhya.ii...@gmail.com> > ---
> +++ b/qapi-schema.json
> @@ -4710,3 +4710,8 @@
> '*epochs' : 'int',
> '*frequency' : 'int',
> '*readable' : 'bool' } }
> +## @log-dirty-bitmap-cancel
> +#
> +# cancel the dirty bitmap logging process
> +##
Missing 'Since: 2.1'; also, the formatting doesn't quite match other
commands where ## is on a line by itself at the start.
> +{ 'command': 'log-dirty-bitmap-cancel' }
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index 33e7719..55b2251 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -3603,3 +3603,23 @@ value is 3 while that of frequency is 40 and readable
> defaults to false.
>
> EQMP
>
> + {
> + .name = "log-dirty-bitmap-cancel",
> + .args_type = "",
> + .mhandler.cmd_new = qmp_marshal_input_log_dirty_bitmap_cancel,
> + },
> +
> +SQMP
> +log_bitmap_cancel
Incorrect command name.
> +--------------
> +
> +Cancel the current logging of the dirty bitmap.
> +
> +Arguments: None.
> +
> +Example:
> +
> +-> { "execute": "log-bitmap-cancel" }
And yet another spelling of an incorrect command name.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
