On 05/20/2014 11:47 AM, Sanidhya Kashyap wrote: > This patch introduces both qmp and hmp (log-dirty-bitmap-set-frequency) > interface to update the value of the frequency. > > Signed-off-by: Sanidhya Kashyap <sanidhya.ii...@gmail.com> > ---
> +++ b/qapi-schema.json
> @@ -4715,3 +4715,11 @@
> # cancel the dirty bitmap logging process
> ##
> { 'command': 'log-dirty-bitmap-cancel' }
> +
> +## @log-dirty-bitmap-set-frequency
> +#
> +# sets the frequency of the dirty bitmap logging process
> +##
Same comments as in other patches about missing documentation.
> +{ 'command': 'log-dirty-bitmap-set-frequency',
> + 'data': {'frequency': 'int' } }
> +
> diff --git a/qmp-commands.hx b/qmp-commands.hx
Please don't end files with an extra blank line.
> +Arguments:
> +
> +- "frequency": the updated frequency (json-int)
In what unit? I'm assuming milliseconds based on the rest of the series,
but spelling it out will help readers.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
