Kevin Wolf writes:
> If you specify the same option more than once (e.g. -o cluster_size=4k
> -o lazy_refcounts=on), qemu-img silently ignores all but the last one. This
Sounds like perfectly common behavior to me.
> series fixes it to either consider all options or to give an error message.
D
Signed-off-by: Wenchao Xia
Signed-off-by: Markus Armbruster
---
tests/Makefile |8 +---
tests/qapi-schema/duplicate-key.err|1 +
tests/qapi-schema/duplicate-key.exit |1 +
tests/qapi-schema/duplicate-key.json
After this patch, hidden enum type BlockdevOptionsKind will not
be generated, and other API can use enum BlockdevDriver.
Signed-off-by: Wenchao Xia
---
qapi-schema.json | 14 +-
1 files changed, 13 insertions(+), 1 deletions(-)
diff --git a/qapi-schema.json b/qapi-schema.json
inde
On Thu, Feb 20, 2014 at 12:37:17PM +0800, Fam Zheng wrote:
> On Wed, 02/19 18:24, Jeff Cody wrote:
> > On Wed, Feb 19, 2014 at 04:22:30PM -0500, Jeff Cody wrote:
> > > On Wed, Feb 19, 2014 at 09:42:25PM +0800, Fam Zheng wrote:
> > > > Dropping intermediate could be useful both for commit and stream
Signed-off-by: Wenchao Xia
---
docs/qapi-code-gen.txt |8 +++-
scripts/qapi.py |6 ++
tests/qapi-schema/qapi-schema-test.json |9 ++---
tests/qapi-schema/qapi-schema-test.out |5 +++--
tests/test-qmp-input-strict.c |
Now "enum AIOContext" will generate AIO_CONTEXT instead of A_I_O_CONTEXT,
"X86CPU" will generate X86_CPU instead of X86_C_P_U.
Signed-off-by: Wenchao Xia
Reviewed-by: Eric Blake
---
include/qapi/qmp/qerror.h |2 +-
scripts/qapi.py | 26 +++---
target-i386/cpu
Later both qapi-types.py and qapi-visit.py need a common function
for enum name generation.
Signed-off-by: Wenchao Xia
Reviewed-by: Eric Blake
---
scripts/qapi-types.py | 10 --
scripts/qapi.py | 10 ++
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/s
Before this patch, 'QAPISchemaError' scans whole input until 'pos'
to get error line number. After this patch, the scan is avoided since
line number is remembered in schema parsing. This patch also benefits
other error report functions, which would be introduced later.
Signed-off-by: Wenchao Xia
It will check whether base is set, whether discriminator is found
in base, whether the values specified are written correctly, and
whether all enum values are covered, when discriminator is a
pre-defined enum type. Exprs now have addtional info inside qapi.py
to form better error message.
Signed-o
It is bad that same key was specified twice, especially when a union have
two branches with same condition. This patch can prevent it.
Signed-off-by: Wenchao Xia
---
scripts/qapi.py |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/scripts/qapi.py b/scripts/qapi.py
index
Prior to this patch, qapi-visit.py used custom code to generate enum
names used for handling a qapi union. Fix it to instead reuse common
code, with identical generated results, and allowing future updates to
generation to only need to touch one place.
Signed-off-by: Wenchao Xia
Reviewed-by: Eric
This series address two issues:
1. support using enum as discriminator in union.
For example, if we have following define in qapi schema:
{ 'enum': 'EnumOne',
'data': [ 'value1', 'value2', 'value3' ] }
{ 'type': 'UserDefBase0',
'data': { 'base-string0': 'str', 'base-enum0': 'EnumOne' } }
Bef
Later other scripts will need to check the enum values.
Signed-off-by: Wenchao Xia
Reviewed-by: Eric Blake
---
scripts/qapi.py| 18 ++
tests/qapi-schema/comments.out |2 +-
tests/qapi-schema/qapi-schema-test.out | 10 +-
3 files ch
By default, any union will automatically generate a enum type as
"[UnionName]Kind" in C code, and it is duplicated when the discriminator
is specified as a pre-defined enum type in schema. After this patch,
the pre-defined enum type will be really used as the switch case
condition in generated C co
On Thu, Feb 20, 2014 at 01:01:38PM +0800, Fam Zheng wrote:
> On Wed, 02/19 16:17, Jeff Cody wrote:
> > On Wed, Feb 19, 2014 at 09:42:23PM +0800, Fam Zheng wrote:
> > > This makes use of op_blocker and blocks all the operations except for
> > > commit target, on each BlockDriverState->backing_hd.
>
On Wed, Feb 19, 2014 at 02:45:29PM -0500, Gabriel L. Somlo wrote:
> On Wed, Feb 19, 2014 at 09:02:15PM +0200, Michael S. Tsirkin wrote:
> > On Wed, Feb 19, 2014 at 03:50:22PM +0200, Michael S. Tsirkin wrote:
> > > On Mon, Feb 17, 2014 at 09:51:39AM -0500, Gabriel L. Somlo wrote:
> > > > With this l
On 02/19/2014 09:00 AM, Li Guang wrote:
Hi,
mrhi...@linux.vnet.ibm.com wrote:
From: "Michael R. Hines"
This patch sets up the initial changes to the migration state
machine and prototypes to be used by the checkpointing code
to interact with the state machine so that we can later handle
failur
On Wed, 02/19 16:17, Jeff Cody wrote:
> On Wed, Feb 19, 2014 at 09:42:23PM +0800, Fam Zheng wrote:
> > This makes use of op_blocker and blocks all the operations except for
> > commit target, on each BlockDriverState->backing_hd.
> >
> > The asserts for op_blocker in bdrv_swap are removed because
On Wed, 02/19 18:24, Jeff Cody wrote:
> On Wed, Feb 19, 2014 at 04:22:30PM -0500, Jeff Cody wrote:
> > On Wed, Feb 19, 2014 at 09:42:25PM +0800, Fam Zheng wrote:
> > > Dropping intermediate could be useful both for commit and stream, and
> > > BDS refcnt plus bdrv_swap could do most of the job nice
> -Original Message-
> From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com]
> Sent: Wednesday, February 19, 2014 6:54 PM
> To: Gonglei (Arei)
> Cc: qemu-devel@nongnu.org; Peter Maydell; chenliang (T); Juan Quintela;
> Luonengjun; owass...@redhat.com; Huangweidong (Hardware)
> Subject:
On 02/19/2014 07:27 PM, Dr. David Alan Gilbert wrote:
I was just wondering if a separate 'max buffer size' knob would allow
you to more reasonably bound memory without setting policy; I don't think
people like having potentially x2 memory.
Note: Checkpoint memory is not monotonic in this patch
This patch implements the ARM PMCCNTR register including
the disable and reset components of the PMCR register.
Signed-off-by: Alistair Francis
---
V7: Fixed a bug that caused the cycle count scaling to be determined
by the PMCRDP register instead of PMCRD. Also stopped PMCRDP from
disabling the
I agree with your comments. I can't believe I missed the PMCRDP/PMCRD
mistake. Submitting V7 now
On Wed, Feb 19, 2014 at 2:08 AM, Peter Maydell wrote:
> On 17 February 2014 01:20, Alistair Francis
> wrote:
>> This patch implements the ARM PMCCNTR register including
>> the disable and reset comp
On Wed, Feb 19, 2014 at 04:22:30PM -0500, Jeff Cody wrote:
> On Wed, Feb 19, 2014 at 09:42:25PM +0800, Fam Zheng wrote:
> > Dropping intermediate could be useful both for commit and stream, and
> > BDS refcnt plus bdrv_swap could do most of the job nicely. It also needs
> > to work with op blockers
On Wed, 2014-02-19 at 19:03 +1100, Vadim Rozenfeld wrote:
> On Tue, 2014-02-18 at 13:00 -0800, Nicholas A. Bellinger wrote:
> > On Mon, 2014-02-10 at 11:05 -0800, Nicholas A. Bellinger wrote:
> >
> >
> >
> > > > > > Hi Yan,
> > > > > >
> > > > > > So recently I've been doing some KVM guest perf
On 02/19/14 21:40, Gabriel L. Somlo wrote:
> On Wed, Feb 19, 2014 at 10:59:34AM +0100, Gerd Hoffmann wrote:
>> Hi,
>>
>>> However, when I compare unmodified SMBIOS against what I get when
>>> supplying the patched binary table via command line, I get this:
>>
>> As Laszlo already sayed: one table
Il 19/02/2014 19:18, Roland Dreier ha scritto:
On Wed, Feb 19, 2014 at 10:11 AM, Andreas Färber wrote:
> HEX64 will conflict with your patches in the pending pull.
I'm not aware of the issue. Is there a better tree for me to work
against than qemu.git master?
No, I'll take care of rebasing
Add v2.3 fields to Type 4 and 17 structures, to comply with the
major/minor smbios spec version (2.4) advertised in the smbios
entry point structure.
Signed-off-by: Gabriel Somlo
---
On Tue, Feb 18, 2014 at 03:02:16PM -0500, Kevin O'Connor wrote:
> Thanks for running tests. One thing that has b
On 19/02/14 13:01, Andreas Färber wrote:
Am 19.02.2014 10:05, schrieb Mark Cave-Ayland:
This patchset provides QEMU with an implementation of the Sun CG3 8-bit
framebuffer. It is based upon Bob Breuer's original work which has been
rebased onto git master, and is now capable of running with an
On 19/02/14 13:35, Leandro Dorileo wrote:
Hi Leandro,
+static void cg3_realizefn(DeviceState *dev, Error **errp)
+{
+SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
+CG3State *s = CG3(dev);
+int ret;
+char *fcode_filename;
+
+/* FCode ROM */
+memory_region_init_ram(&s->rom, NUL
On Wed, Feb 19, 2014 at 09:42:26PM +0800, Fam Zheng wrote:
> This reuses the new bdrv_drop_intermediate.
>
> Signed-off-by: Fam Zheng
> ---
> block/stream.c | 30 +-
> 1 file changed, 1 insertion(+), 29 deletions(-)
>
> diff --git a/block/stream.c b/block/stream.c
>
On 17/02/14 12:30, Mark Cave-Ayland wrote:
On 09/02/14 15:32, Andreas Färber wrote:
IIUC SUNW,cgthree is an optional device, so it's not covered by my
qom-test. Please follow-up with a tests/cg3-test.c so that it gets
covered. Compare my recent PCI NIC series for how such a stub could look
lik
On Wed, Feb 19, 2014 at 09:42:25PM +0800, Fam Zheng wrote:
> Dropping intermediate could be useful both for commit and stream, and
> BDS refcnt plus bdrv_swap could do most of the job nicely. It also needs
> to work with op blockers.
>
> Signed-off-by: Fam Zheng
> ---
> block.c| 146
> +
On Wed, Feb 19, 2014 at 09:42:23PM +0800, Fam Zheng wrote:
> This makes use of op_blocker and blocks all the operations except for
> commit target, on each BlockDriverState->backing_hd.
>
> The asserts for op_blocker in bdrv_swap are removed because with this
> change, the target of block commit h
On Wed, 2014-02-19 at 15:20 -0500, Bandan Das wrote:
> Certain cards such as the Broadcom BCM57810 have rom quirks
> that exhibit unstable system behavior duing device assignment. In
> the particular case of 57810, rom execution hangs and if a FLR
> follows, the device becomes inoperable until a po
Alex Williamson writes:
> On Wed, 2014-02-19 at 15:20 -0500, Bandan Das wrote:
>> The following patch depends on the value of rom_bar to
>> determine rom blacklist behavior. Existing code shouldn't
>> be affected by changing the default value of rom_bar since
>> all relevant decisions only rely o
On Wed, Feb 19, 2014 at 10:59:34AM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > However, when I compare unmodified SMBIOS against what I get when
> > supplying the patched binary table via command line, I get this:
>
> As Laszlo already sayed: one table per file.
So I gave up on that relatively qui
On Wed, 2014-02-19 at 15:20 -0500, Bandan Das wrote:
> The following patch depends on the value of rom_bar to
> determine rom blacklist behavior. Existing code shouldn't
> be affected by changing the default value of rom_bar since
> all relevant decisions only rely on whether rom_bar is zero
> or n
The following patch depends on the value of rom_bar to
determine rom blacklist behavior. Existing code shouldn't
be affected by changing the default value of rom_bar since
all relevant decisions only rely on whether rom_bar is zero
or non-zero.
Signed-off-by: Bandan Das
---
hw/pci/pci.c | 7
Certain cards such as the Broadcom BCM57810 have rom quirks
that exhibit unstable system behavior duing device assignment. In
the particular case of 57810, rom execution hangs and if a FLR
follows, the device becomes inoperable until a power cycle. This
is a simple change to blacklist loading of ro
v2:
1. Break up into two patches separating the infrastructural changes
2. Change vendor_id and device_id type to uint16_t
3. Rename struct for blacklisted devid and vendorid to more meaningful names
4. Remove unnecessary rom_quirk variable and just call vfio_blacklist_opt_rom()
in vfio_pci_size_ro
On Wed, Feb 19, 2014 at 10:11 AM, Andreas Färber wrote:
> HEX64 will conflict with your patches in the pending pull.
I'm not aware of the issue. Is there a better tree for me to work
against than qemu.git master?
> Also I notice that underscores are being used in new properties -
> oversight or
On Wed, Feb 19, 2014 at 09:02:15PM +0200, Michael S. Tsirkin wrote:
> On Wed, Feb 19, 2014 at 03:50:22PM +0200, Michael S. Tsirkin wrote:
> > On Mon, Feb 17, 2014 at 09:51:39AM -0500, Gabriel L. Somlo wrote:
> > > With this latest version of your patch, I crash during OS X boot with
> > > "unable t
Some of my recent changes introduced variable declarations in the middle
of code blocks.
Fix the code so that it compiles without warnings when using
-Wdeclaration-after-statement.
Signed-off-by: Eduardo Habkost
---
Changes v2:
* Rebased on top of qom-cpu
---
target-i386/cpu.c | 7 ---
1 f
Ping? Who is willing to apply this?
On Sun, Feb 09, 2014 at 07:03:01AM -0200, Eduardo Habkost wrote:
> We had an unwritten rule about declarations having to be at beginning of
> blocks. Make it a written rule.
>
> Signed-off-by: Eduardo Habkost
> ---
> CODING_STYLE | 7 +++
> 1 file changed
Alex Williamson writes:
> On Wed, 2014-02-19 at 13:58 -0500, Bandan Das wrote:
>> Alex Williamson writes:
>>
>> > On Wed, 2014-02-19 at 11:12 -0500, Bandan Das wrote:
>> >> Certain cards such as the Broadcom BCM57810 have rom quirks
>> >> that exhibit unstable system behavior duing device assig
Hi,
my linux system boots up fine in the emulator, but when I try to extract perl
source code it just hangs after a while:
..
perl-5.18.1/cpan/Pod-Simple/t/basic.t
perl-5.18.1/cpan/Pod-Simple/t/begin.t
perl-5.18.1/cpan/Pod-Simple/t/cbacks.t
perl-5.18.1/cpan/Pod-Simple/t/chunking.t
no further con
On Wed, Feb 19, 2014 at 11:58:09AM -0300, Eduardo Habkost wrote:
> This is the approach I believe was agreed upon during the last QEMU developers
> conf call (sorry I didn't join, the meeting timezone change confused me).
Yes.
> Some may notice that representing this new behavior using solely def
On Wed, 2014-02-19 at 13:58 -0500, Bandan Das wrote:
> Alex Williamson writes:
>
> > On Wed, 2014-02-19 at 11:12 -0500, Bandan Das wrote:
> >> Certain cards such as the Broadcom BCM57810 have rom quirks
> >> that exhibit unstable system behavior duing device assignment. In
> >> the particular cas
On Wed, Feb 19, 2014 at 10:24:50AM -0500, Gabriel L. Somlo wrote:
> On Wed, Feb 19, 2014 at 03:50:22PM +0200, Michael S. Tsirkin wrote:
> > On Mon, Feb 17, 2014 at 09:51:39AM -0500, Gabriel L. Somlo wrote:
> > >
> > > With this latest version of your patch, I crash during OS X boot with
> > > "una
On Wed, Feb 19, 2014 at 03:50:22PM +0200, Michael S. Tsirkin wrote:
> On Mon, Feb 17, 2014 at 09:51:39AM -0500, Gabriel L. Somlo wrote:
> > Michael,
> >
> > On Mon, Feb 17, 2014 at 04:25:26PM +0200, Michael S. Tsirkin wrote:
> > > As reported in
> > > http://article.gmane.org/gmane.comp.emulators.
Alex Williamson writes:
> On Wed, 2014-02-19 at 11:12 -0500, Bandan Das wrote:
>> Certain cards such as the Broadcom BCM57810 have rom quirks
>> that exhibit unstable system behavior duing device assignment. In
>> the particular case of 57810, rom execution hangs and if a FLR
>> follows, the devi
On 02/11/2014 11:33 PM, Chunyan Liu wrote:
> vhdx.c: replace QEMUOptionParameter with QemuOpts
>
> Signed-off-by: Dong Xu Wang
> Signed-off-by: Chunyan Liu
> ---
> block/vhdx.c | 93 +++--
> block/vhdx.h |1 +
> 2 files changed, 45 inser
The commit 88c1ee73d3231c74ff90bcfc084a7589670ec244
char/serial: Fix emptyness check
Still causes extra NULL byte(s) to be sent.
So if the fifo is empty, do not send an extra NULL byte.
Signed-off-by: Don Slutz
---
hw/char/serial.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
di
On Wed, Feb 19, 2014 at 7:30 AM, Stefan Hajnoczi wrote:
> On Fri, Feb 14, 2014 at 05:40:24PM +0100, Vincenzo Maffione wrote:
> > This patch fixes configure so that netmap is not compiled in if the
> > host doesn't support an API version >= 11.
> >
> > Moreover, some modifications have been done t
Am 19.02.2014 15:50, schrieb Stefan Hajnoczi:
> Reviewed by Paolo and Markus. Here is the pull request.
>
> v2:
> * Don't call qtest_end() from SIGABRT handler to avoid reentrancy [Paolo]
> * Use sigemptyset() to avoid assumption about signal mask [Markus]
> * if (fd != -1) close(fd) is no lon
Am 19.02.2014 18:07, schrieb Paolo Bonzini:
> Il 19/02/2014 17:28, Roland Dreier ha scritto:
>> From: Roland Dreier
>>
>> To make a VM more convincing to my application, it's useful to be able
>> to add a port WWN and relative target port index to the descriptors
>> returned for VPD page 83h. Add
On Wed, 2014-02-19 at 11:12 -0500, Bandan Das wrote:
> Certain cards such as the Broadcom BCM57810 have rom quirks
> that exhibit unstable system behavior duing device assignment. In
> the particular case of 57810, rom execution hangs and if a FLR
> follows, the device becomes inoperable until a po
Il 19/02/2014 17:28, Roland Dreier ha scritto:
From: Roland Dreier
To make a VM more convincing to my application, it's useful to be able
to add a port WWN and relative target port index to the descriptors
returned for VPD page 83h. Add device properties to allow setting
these, and return them
On 02/19/2014 08:12 AM, Kevin Wolf wrote:
> Multiple -o options has the same meaning as having a single option with
> all settings in the order of their respective -o options.
Ah, this addresses (part of) the problem I raised about patch 1. But it
feels a bit awkward to have the intermediate stat
On Wed, Feb 19, 2014 at 05:38:28PM +0100, Igor Mammedov wrote:
> On Wed, 19 Feb 2014 11:58:10 -0300
> Eduardo Habkost wrote:
>
> > We will later make the KVM-specific code affect other feature words,
> > too.
> patch doesn't apply to current master, is there dependencies on list?
It is against t
On 02/19/2014 08:12 AM, Kevin Wolf wrote:
> If you specified multiple -o options for qemu-img create, it would
> silently ignore all but the last one. Similarly, for other options the
> last occurence wins (which is at least a bit less surprising). Error out
s/occurence/occurrence/
> instead.
Fo
On Wed, 19 Feb 2014 11:58:10 -0300
Eduardo Habkost wrote:
> We will later make the KVM-specific code affect other feature words,
> too.
patch doesn't apply to current master, is there dependencies on list?
>
> Signed-off-by: Eduardo Habkost
> ---
> target-i386/cpu.c | 17 +
>
From: Roland Dreier
To make a VM more convincing to my application, it's useful to be able
to add a port WWN and relative target port index to the descriptors
returned for VPD page 83h. Add device properties to allow setting
these, and return them from INQUIRY commands.
Signed-off-by: Roland Dr
On Wed, 02/19 16:12, Kevin Wolf wrote:
> Multiple -o options has the same meaning as having a single option with
> all settings in the order of their respective -o options.
>
> Signed-off-by: Kevin Wolf
> ---
> qemu-img.c | 21 -
> 1 file changed, 12 insertions(+), 9 deletion
Hi,
we have a workaround for that. We´ve add sleep
${RANDOM:0:1}.${RANDOM:-1:1} between the IP Tables rules. The Problem
is, that IP tables cannot execute twice or more times simultaneously.
Cheers Tim
--
You received this bug notification because you are a member of qemu-
devel-ml, which is su
Certain cards such as the Broadcom BCM57810 have rom quirks
that exhibit unstable system behavior duing device assignment. In
the particular case of 57810, rom execution hangs and if a FLR
follows, the device becomes inoperable until a power cycle.
This is a simple change to disable rom loading f
On Mon, 2014-02-17 at 09:51 -0500, Gabriel L. Somlo wrote:
> Michael,
>
> On Mon, Feb 17, 2014 at 04:25:26PM +0200, Michael S. Tsirkin wrote:
> > As reported in
> > http://article.gmane.org/gmane.comp.emulators.qemu/253987
> > Mac OSX actually requires describing all occupied slots
> > in ACPI - e
On Wed, 02/19 16:12, Kevin Wolf wrote:
> If you specified multiple -o options for qemu-img create, it would
> silently ignore all but the last one. Similarly, for other options the
> last occurence wins (which is at least a bit less surprising). Error out
> instead.
>
> The only exception is a -o
Stefan Hajnoczi writes:
> Lluis: CCed you since Mohamad's LTTng 2.x patches conflict with your cleanup
> series.
Will rebase and adjust.
Thanks,
Lluis
> The following changes since commit 46eef33b89e936ca793e13c4aeea1414e97e8dbb:
> Fix QEMU build on OpenBSD on x86 archs (2014-02-17 11:44
On Thu, Feb 06, 2014 at 05:02:14PM +0100, Vincenzo Maffione wrote:
> The purpose of this patch series is to add offloadings support
> (TSO/UFO/CSUM) to the netmap network backend, and make it possible
> for the paravirtual network frontends (virtio-net and vmxnet3) to
> use it.
> In order to achiev
2014-02-19 16:30 GMT+01:00 Stefan Hajnoczi :
> On Fri, Feb 14, 2014 at 05:40:24PM +0100, Vincenzo Maffione wrote:
> > This patch fixes configure so that netmap is not compiled in if the
> > host doesn't support an API version >= 11.
> >
> > Moreover, some modifications have been done to net/netmap
Commit 1b90d56e changed the implementation of in/out imm to not assign
the accessed port number to cpu_T[0] as it appeared unnecessary.
However, currently gen_check_io() makes use of cpu_T[0] to implement the
I/O bitmap checks, so it's in fact still used and the change broke the
check, leading to #
From: Mohamad Gebai
Add generation of new files for LTTng ust.
Signed-off-by: Mohamad Gebai
Signed-off-by: Stefan Hajnoczi
---
Makefile| 5 +
trace/Makefile.objs | 25 +
2 files changed, 30 insertions(+)
diff --git a/Makefile b/Makefile
index 807054b.
The following changes since commit 46eef33b89e936ca793e13c4aeea1414e97e8dbb:
Fix QEMU build on OpenBSD on x86 archs (2014-02-17 11:44:00 +)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for you to fetch changes up to 6d093a4f499fd945b39bd55b30
From: Kevin Wolf
s/offet/offset/
Signed-off-by: Kevin Wolf
Reviewed-by: Fam Zheng
Signed-off-by: Stefan Hajnoczi
---
trace-events | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/trace-events b/trace-events
index ab11f97..3713063 100644
--- a/trace-events
+++ b/tra
From: Mohamad Gebai
Signed-off-by: Mohamad Gebai
Reviewed-by: Alex Bennée
Signed-off-by: Stefan Hajnoczi
---
.gitignore | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.gitignore b/.gitignore
index 6e48b5e..ff0ae64 100644
--- a/.gitignore
+++ b/.gitignore
@@ -10,6 +10,8 @@
/trace/gener
From: Mohamad Gebai
* A new format is required to generate definitions for ust tracepoints.
Files ust_events_h.py and ust_events_c.py define common macros, while
new function ust_events_h in events.py does the actual definition of
each tracepoint.
* ust.py generates the new interface for ca
Lluis: CCed you since Mohamad's LTTng 2.x patches conflict with your cleanup
series.
The following changes since commit 46eef33b89e936ca793e13c4aeea1414e97e8dbb:
Fix QEMU build on OpenBSD on x86 archs (2014-02-17 11:44:00 +)
are available in the git repository at:
git://github.com/stefa
From: Mohamad Gebai
Signed-off-by: Mohamad Gebai
Reviewed-by: Alex Bennée
Signed-off-by: Stefan Hajnoczi
---
docs/tracing.txt | 36
1 file changed, 36 insertions(+)
diff --git a/docs/tracing.txt b/docs/tracing.txt
index bfc261b..bf2e15c 100644
--- a/docs/
From: Mohamad Gebai
Signed-off-by: Mohamad Gebai
Signed-off-by: Stefan Hajnoczi
---
configure | 20 +++-
1 file changed, 15 insertions(+), 5 deletions(-)
diff --git a/configure b/configure
index 4648117..8c0ead9 100755
--- a/configure
+++ b/configure
@@ -3379,15 +3379,25 @@ fi
The Wednesday 19 Feb 2014 à 21:42:18 (+0800), Fam Zheng wrote :
> This adds the enum of all the operations that can be taken on a block
> device.
>
> Signed-off-by: Fam Zheng
> ---
> include/block/block.h | 19 +++
> 1 file changed, 19 insertions(+)
>
> diff --git a/include/bloc
The Wednesday 19 Feb 2014 à 21:42:19 (+0800), Fam Zheng wrote :
> BlockDriverState.op_blockers is an array of lists with BLOCK_OP_TYPE_MAX
> elements. Each list is a list of blockers of an operation type
> (BlockOpType), that marks this BDS as currently blocked for a certain
> type of operation wit
The Wednesday 19 Feb 2014 à 21:42:25 (+0800), Fam Zheng wrote :
> Dropping intermediate could be useful both for commit and stream, and
> BDS refcnt plus bdrv_swap could do most of the job nicely. It also needs
> to work with op blockers.
>
> Signed-off-by: Fam Zheng
> ---
> block.c| 146
Il 19/02/2014 15:58, Eduardo Habkost ha scritto:
This is the approach I believe was agreed upon during the last QEMU developers
conf call (sorry I didn't join, the meeting timezone change confused me).
Yes, that's correct.
Some may notice that representing this new behavior using solely defau
The Wednesday 19 Feb 2014 à 21:42:23 (+0800), Fam Zheng wrote :
> This makes use of op_blocker and blocks all the operations except for
> commit target, on each BlockDriverState->backing_hd.
>
> The asserts for op_blocker in bdrv_swap are removed because with this
> change, the target of block com
On Fri, Feb 14, 2014 at 05:40:24PM +0100, Vincenzo Maffione wrote:
> This patch fixes configure so that netmap is not compiled in if the
> host doesn't support an API version >= 11.
>
> Moreover, some modifications have been done to net/netmap.c in
> order to reflect the current netmap API (11).
>
The Wednesday 19 Feb 2014 à 21:42:20 (+0800), Fam Zheng wrote :
> This drops BlockDriverState.in_use with op_blockers:
>
> - Call bdrv_op_block_all in place of bdrv_set_in_use(bs, 1).
> - Call bdrv_op_unblock_all in place of bdrv_set_in_use(bs, 0).
> - Check bdrv_op_is_blocked() in place of
The Wednesday 19 Feb 2014 à 21:42:21 (+0800), Fam Zheng wrote :
> It makes no sense to check for "any" blocker on bs, we are here only
> because of the mechanical conversion from in_use to op_blockers. Remove
> it now, and let the callers check specific operation types. Backup and
> mirror already
On Wed, Feb 19, 2014 at 03:50:22PM +0200, Michael S. Tsirkin wrote:
> On Mon, Feb 17, 2014 at 09:51:39AM -0500, Gabriel L. Somlo wrote:
> >
> > With this latest version of your patch, I crash during OS X boot with
> > "unable to find driver for this
> > platform:\"ACPI\".\n"@/SourceCache/xnu/xnu-
The Wednesday 19 Feb 2014 à 21:42:22 (+0800), Fam Zheng wrote :
> This is the common but non-trivial steps to assign or change the
> backing_hd of BDS.
>
> Signed-off-by: Fam Zheng
> ---
> block.c | 34 +++---
> include/block/block.h | 1 +
> 2 files ch
Stefan Hajnoczi writes:
> On Mon, Feb 17, 2014 at 08:36:19PM +0100, Lluís Vilanova wrote:
>> Minimizes the amount of backend code, making it simpler to add new/different
>> backends.
>>
>> Also performs other cleanups all around.
>>
>> Signed-off-by: Lluís Vilanova
>> ---
>>
>> Lluís Vilanova
Multiple -o options has the same meaning as having a single option with
all settings in the order of their respective -o options.
Signed-off-by: Kevin Wolf
---
qemu-img.c | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index a889
Instead of ignoring all option values but the last one, error out if an
option is set multiple times.
Again, the only exception is a -o help option, which may be added to any
valid qemu-img amend command and ignores all other options.
Signed-off-by: Kevin Wolf
---
qemu-img.c | 18 ++
If you specified multiple -o options for qemu-img create, it would
silently ignore all but the last one. Similarly, for other options the
last occurence wins (which is at least a bit less surprising). Error out
instead.
The only exception is a -o help option, which may be added to any valid
qemu-i
Multiple -o options has the same meaning as having a single option with
all settings in the order of their respective -o options.
Signed-off-by: Kevin Wolf
---
qemu-img.c | 44 ++--
1 file changed, 26 insertions(+), 18 deletions(-)
diff --git a/qemu-img.c
Multiple -o options has the same meaning as having a single option with
all settings in the order of their respective -o options.
Signed-off-by: Kevin Wolf
---
qemu-img.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index e0d19f8..1a989
Instead of ignoring all option values but the last one, error out if an
option is set multiple times.
Again, the only exception is a -o help option, which may be added to any
valid qemu-img convert command and ignores all other options.
Signed-off-by: Kevin Wolf
---
qemu-img.c | 49
Instead of ignoring all option values but the last one, error out if an
option is set multiple times. These are the simpler subcommands without
-o, so the patch becomes a bit easier and we can fix the remaining
subcommands in a single patch.
Signed-off-by: Kevin Wolf
---
qemu-img.c | 66
If you specify the same option more than once (e.g. -o cluster_size=4k
-o lazy_refcounts=on), qemu-img silently ignores all but the last one. This
series fixes it to either consider all options or to give an error message.
Boolean option can still be given more than once as they aren't problematic
1 - 100 of 191 matches
Mail list logo
