On 17/02/14 12:30, Mark Cave-Ayland wrote:

On 09/02/14 15:32, Andreas Färber wrote:

IIUC SUNW,cgthree is an optional device, so it's not covered by my
qom-test. Please follow-up with a tests/cg3-test.c so that it gets
covered. Compare my recent PCI NIC series for how such a stub could look
like, in particular vmxnet3-test.c since this will be sparc-only.

Okay - should this be a totally separate patch or appended to the end of
this patchset?

So I tried this, and if I launch with -device cgthree then I get an error about the device not being pluggable (which I'm guessing is because the device is attached to sysbus).

Some further poking shows that several other of the -vga devices appear to be marked as non-pluggable too, so I'm not sure this could work with QOM tests based upon the current implementation.


ATB,

Mark.

Reply via email to