Re: [Qemu-devel] Signed pull requests

2014-01-30 Thread Markus Armbruster
Peter Maydell writes: [...] > The handful of people whose keys I signed after KVM Forum > last year will find the git commit message looks prettier. > (I'd have made a greater effort to sign more keys if I'd known > at the time I was going to be a committer.) I suspect many of the keys examined

Re: [Qemu-devel] [PATCH] Use error_is_set() only when necessary

2014-01-30 Thread Markus Armbruster
Andreas Färber writes: > Am 30.01.2014 15:07, schrieb Markus Armbruster: >> error_is_set(&var) is the same as var != NULL, but it takes >> whole-program analysis to figure that out. Unnecessarily hard for >> optimizers, static checkers, and human readers. Dumb it down to >> obvious. >> >> Gets

Re: [Qemu-devel] [PATCH 4/4] spapr: add more details error description of why load_elf() failed

2014-01-30 Thread Alexander Graf
On 22.01.2014, at 06:20, Alexey Kardashevskiy wrote: > This makes use of new error codes which load_elf() can return. > > Signed-off-by: Alexey Kardashevskiy > --- > hw/ppc/spapr.c | 17 ++--- > 1 file changed, 14 insertions(+), 3 deletions(-) > > diff --git a/hw/ppc/spapr.c b/hw/p

Re: [Qemu-devel] [PATCH 2/4] moxie: fix load_elf() usage

2014-01-30 Thread Alexander Graf
On 22.01.2014, at 06:20, Alexey Kardashevskiy wrote: > At the moment in the case of error, load_elf() returns -1 so load_kernel() > will not signal error at all. > > Signed-off-by: Alexey Kardashevskiy Anthony (Green), could you please ack this patch? Alex > --- > hw/moxie/moxiesim.c | 2 +

Re: [Qemu-devel] [PATCH] PPC: KVM: store SLB slot number

2014-01-30 Thread Alexander Graf
On 31.01.2014, at 03:24, Alexey Kardashevskiy wrote: > When ppc_store_slb() is called from kvm_arch_get_registers(), it stores > a SLB in CPUPPCState::slb[slot]. However it drops the slot number from > ESID so when kvm_arch_put_registers() puts SLBs back to KVM, they do not > have correct "index

Re: [Qemu-devel] [PATCH v5 0/2] target-ppc: CPU device tree id

2014-01-30 Thread Alexey Kardashevskiy
On 01/22/2014 03:20 PM, Alexey Kardashevskiy wrote: > On 01/10/2014 07:20 PM, Alexey Kardashevskiy wrote: >> On 12/20/2013 12:16 AM, Alexey Kardashevskiy wrote: >>> On 12/10/2013 07:16 PM, Alexey Kardashevskiy wrote: On 12/03/2013 02:30 PM, Alexey Kardashevskiy wrote: > Hi! > > Thi

Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC: KVM: store SLB slot number

2014-01-30 Thread Aneesh Kumar K.V
Alexey Kardashevskiy writes: > When ppc_store_slb() is called from kvm_arch_get_registers(), it stores > a SLB in CPUPPCState::slb[slot]. However it drops the slot number from > ESID so when kvm_arch_put_registers() puts SLBs back to KVM, they do not > have correct "index" field anymore. This bro

[Qemu-devel] [PATCH target-arm v5 1/1] target-arm: Implements the ARM PMCCNTR register

2014-01-30 Thread Alistair Francis
This patch implements the ARM PMCCNTR register including the disable and reset components of the PMCR register. Signed-off-by: Alistair Francis --- This patch assumes that non-invasive debugging is not permitted when determining if the counter is disabled V5: Implement the actual write function t

Re: [Qemu-devel] [PATCH 08/42] input: qapi: add pause key

2014-01-30 Thread Eric Blake
On 01/28/2014 02:57 AM, Gerd Hoffmann wrote: > It's missing. > > Signed-off-by: Gerd Hoffmann > --- > qapi-schema.json | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http:

[Qemu-devel] [PATCH] PPC: KVM: store SLB slot number

2014-01-30 Thread Alexey Kardashevskiy
When ppc_store_slb() is called from kvm_arch_get_registers(), it stores a SLB in CPUPPCState::slb[slot]. However it drops the slot number from ESID so when kvm_arch_put_registers() puts SLBs back to KVM, they do not have correct "index" field anymore. This broke migration with LPCR_AIR enabled as n

Re: [Qemu-devel] [PATCH 3/4] elf-loader: add more return codes

2014-01-30 Thread Alexey Kardashevskiy
On 01/22/2014 06:27 PM, Alexey Kardashevskiy wrote: > On 01/22/2014 04:20 PM, Alexey Kardashevskiy wrote: >> The existing load_elf() just returns -1 if it fails to load ELF. However >> it could be smarter than this and tell more about the failure such as >> wrong endianness or incompatible platform

Re: [Qemu-devel] [PATCH target-arm v4 1/1] target-arm: Implements the ARM PMCCNTR register

2014-01-30 Thread Peter Crosthwaite
On Thu, Jan 30, 2014 at 8:22 PM, Peter Maydell wrote: > On 30 January 2014 07:00, Peter Crosthwaite > wrote: >> On Wed, Jan 29, 2014 at 10:28 PM, Peter Maydell >> wrote: >>> This will break migration. You must provide a mechanism for the >>> migration to do a "read register on source end; write

Re: [Qemu-devel] [PATCH 07/42] input: qapi: add unmapped key

2014-01-30 Thread Eric Blake
On 01/28/2014 02:57 AM, Gerd Hoffmann wrote: > Simplifies building something -> QkeyCode mapping tables. > Uninitialized entries can easily identified then. > > Signed-off-by: Gerd Hoffmann > --- > qapi-schema.json | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/qap

Re: [Qemu-devel] [PATCH 06/42] input: qapi: define event types

2014-01-30 Thread Eric Blake
On 01/28/2014 02:56 AM, Gerd Hoffmann wrote: > Define input event types, using qapi. So we get nicely autogenerated > types for our input events. And when it comes to qmp support some day > things will be alot easier. s/alot/a lot/ > > Types are modeled after the linux input layer. There are

Re: [Qemu-devel] [PULL 0/3] xen-170114

2014-01-30 Thread Peter Maydell
On 17 January 2014 15:38, Stefano Stabellini wrote: > The following changes since commit 1cf892ca2689c84960b4ce4d2723b6bee453711c: > > SPARC: Fix LEON3 power down instruction (2014-01-15 15:37:33 +1000) > > are available in the git repository at: > > git://xenbits.xen.org/people/sstabellini/qe

Re: [Qemu-devel] [PULL 0/4] Net patches

2014-01-30 Thread Peter Maydell
On 27 January 2014 14:48, Stefan Hajnoczi wrote: > The following changes since commit 0169c511554cb0014a00290b0d3d26c31a49818f: > > Merge remote-tracking branch 'qemu-kvm/uq/master' into staging (2014-01-24 > 15:52:44 -0800) > > are available in the git repository at: > > > git://github.com/s

Re: [Qemu-devel] [PATCH 0/2] qtest: don't leak pid files and UNIX domain sockets

2014-01-30 Thread Peter Maydell
On 21 November 2013 11:03, Stefan Hajnoczi wrote: > GLib uses abort(3) to exit failed test cases. As a result, the pid file and > UNIX domain sockets for a running test are leaked upon failure. > > Since abort(3) does not call atexit(3) handler functions, we could set up a > SIGABRT handler that

Re: [Qemu-devel] [PATCH v2] seccomp: add timerfd_create and timerfd_settime to the whitelist

2014-01-30 Thread Eduardo Otubo
On 01/30/2014 06:28 PM, Felix Geyer wrote: libusb calls timerfd_create() and timerfd_settime() when it's built with timerfd support. Command to reproduce: -device usb-host,hostbus=1,hostaddr=3,id=hostdev0 Log messages: audit(1390730418.924:135): auid=4294967295 uid=121 gid=103 ses=4

[Qemu-devel] [PATCH v5 2/4] util/fifo8: clear fifo head upon reset

2014-01-30 Thread Beniamino Galvani
To improve the predictability of fifo8_pop_buf(), the fifo head is set to start of data buffer upon a reset so that the first call to the function will be able to retrieve all data in the fifo. Signed-off-by: Beniamino Galvani --- util/fifo8.c |1 + 1 file changed, 1 insertion(+) diff --git

[Qemu-devel] [PATCH v5 3/4] hw/net: add support for Allwinner EMAC Fast Ethernet controller

2014-01-30 Thread Beniamino Galvani
This patch adds support for the Fast Ethernet MAC found on Allwinner SoCs, together with a basic emulation of Realtek RTL8201CP PHY. Since there is no public documentation of the Allwinner controller, the implementation is based on Linux kernel driver. Signed-off-by: Beniamino Galvani Reviewed-b

[Qemu-devel] [PATCH v5 4/4] hw/arm/allwinner-a10: initialize EMAC

2014-01-30 Thread Beniamino Galvani
Signed-off-by: Beniamino Galvani Reviewed-by: Peter Crosthwaite Reviewed-by: Peter Maydell --- hw/arm/allwinner-a10.c | 16 hw/arm/cubieboard.c| 11 +-- include/hw/arm/allwinner-a10.h |3 +++ 3 files changed, 28 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH v5 1/4] util/fifo8: implement push/pop of multiple bytes

2014-01-30 Thread Beniamino Galvani
The patch adds functions fifo8_push_all() and fifo8_pop_buf() which can be used respectively to push the content of a memory buffer to the fifo and to pop multiple bytes obtaining a pointer to the fifo backing buffer. In addition, it implements fifo8_num_free() and fifo8_num_used() which allow to

[Qemu-devel] [PATCH v5 0/4] hw/arm: add ethernet support to Allwinner A10

2014-01-30 Thread Beniamino Galvani
This patch series adds support for the EMAC Fast Ethernet controller found on Allwinner SoCs to the Allwinner A10. Changelog: v5: Address comments from Peter Crosthwaite and Peter Maydell: * Move reinitialization of fifo head to a new patch * Remove fifo8_has_space() and add fifo8_num_free

Re: [Qemu-devel] Signed pull requests (was: Re: [PULL 00/11] Trivial patches for 2014-01-16)

2014-01-30 Thread Peter Maydell
On 30 January 2014 21:45, Stefan Weil wrote: > Am 30.01.2014 15:33, schrieb Peter Maydell: >> On 16 January 2014 17:35, Michael Tokarev wrote: >>> There's nothing exciting in there, but we have some small bugfixes here and >>> there, and a few cosmetic changes too. >>> >>> This is my first signed

Re: [Qemu-devel] [uq/master PATCH 0/7] x86 CPU subclasses, take 7

2014-01-30 Thread Paolo Bonzini
Il 30/01/2014 20:48, Eduardo Habkost ha scritto: Is there any hope to get this into QEMU 2.0, or it is now too late? I got almost no feedback on take 6 (submitted November 27). It's not too late, not for me at least. I wanted to send the next uq/master pull request tomorrow or Tuesday, after

[Qemu-devel] Signed pull requests (was: Re: [PULL 00/11] Trivial patches for 2014-01-16)

2014-01-30 Thread Stefan Weil
Am 30.01.2014 15:33, schrieb Peter Maydell: > On 16 January 2014 17:35, Michael Tokarev wrote: >> There's nothing exciting in there, but we have some small bugfixes here and >> there, and a few cosmetic changes too. >> >> This is my first signed pull request too, based on my regular GnuPG key whic

Re: [Qemu-devel] [PATCHv7 1/5] block: add native support for NFS

2014-01-30 Thread Peter Lieven
Am 30.01.2014 um 15:22 schrieb Stefan Hajnoczi : > On Wed, Jan 29, 2014 at 05:19:59PM +0100, Benoît Canet wrote: >> Le Wednesday 29 Jan 2014 à 09:50:21 (+0100), Peter Lieven a écrit : > > Hi Peter, > If I read your reply to Benoit correctly, you only addressed the > questions about nfs_client_cl

Re: [Qemu-devel] [PATCH] s390x/kvm: cleanup partial register handling

2014-01-30 Thread Alexander Graf
> Am 30.01.2014 um 17:18 schrieb Christian Borntraeger : > > From: Dominik Dingel > > Alex, if you have no complaints, I will push this patch to s390-next for 1.8. > This brings s390 back in line with other kvm users and simply use > cpu_synchronize_state. > > Ok? Ack. Alex > > Christia

Re: [Qemu-devel] [PATCHv7 1/5] block: add native support for NFS

2014-01-30 Thread Peter Lieven
Am 30.01.2014 um 15:23 schrieb Stefan Hajnoczi : > On Thu, Jan 30, 2014 at 10:12:35AM +0100, Peter Lieven wrote: >> >> Am 30.01.2014 um 10:05 schrieb Stefan Hajnoczi : >> >>> On Wed, Jan 29, 2014 at 05:38:29PM +0100, Peter Lieven wrote: On 29.01.2014 17:19, Benoît Canet wrote: > Le Wed

Re: [Qemu-devel] [PATCH] trace backend: introduce multi tracing backend

2014-01-30 Thread Stefan Hajnoczi
On Tue, Jan 28, 2014 at 01:35:20PM +0900, Kazuya Saito wrote: Some initial comments, I will continue reviewing tomorrow. > This patch implements "multi tracing backend" which enables several > tracing backend simultaneously. > > QEMU has multiple trace backends, but one of them needs to be chose

Re: [Qemu-devel] OSX guest vs. kvm ioapic polarity

2014-01-30 Thread Gabriel L. Somlo
On Thu, Jan 30, 2014 at 10:28:35PM +0200, Michael S. Tsirkin wrote: > Okay so this is really same as fedora now, isn't it? > Final irq_level is flipping at (almost) each call. I haven't logged with Fedora (which works fine either way). I can try to printk that (or run it with ioapic_debug) if you

Re: [Qemu-devel] OSX guest vs. kvm ioapic polarity

2014-01-30 Thread Michael S. Tsirkin
On Thu, Jan 30, 2014 at 03:21:55PM -0500, Gabriel L. Somlo wrote: > On Thu, Jan 30, 2014 at 09:48:42PM +0200, Michael S. Tsirkin wrote: > > Also, can you send the patch that you applied please? I'd say try uncommenting ioapic_debug at the top of virt/kvm/ioapic.c Let's see why is polarity getting

Re: [Qemu-devel] OSX guest vs. kvm ioapic polarity

2014-01-30 Thread Michael S. Tsirkin
On Thu, Jan 30, 2014 at 03:21:55PM -0500, Gabriel L. Somlo wrote: > On Thu, Jan 30, 2014 at 09:48:42PM +0200, Michael S. Tsirkin wrote: > > Also, can you send the patch that you applied please? > > The kvm patch allowing OS X to boot is a one-liner: > > diff --git a/virt/kvm/ioapic.c b/virt/kvm/i

[Qemu-devel] [PATCH v2] seccomp: add timerfd_create and timerfd_settime to the whitelist

2014-01-30 Thread Felix Geyer
libusb calls timerfd_create() and timerfd_settime() when it's built with timerfd support. Command to reproduce: -device usb-host,hostbus=1,hostaddr=3,id=hostdev0 Log messages: audit(1390730418.924:135): auid=4294967295 uid=121 gid=103 ses=4294967295 pid=5232 co

Re: [Qemu-devel] OSX guest vs. kvm ioapic polarity

2014-01-30 Thread Gabriel L. Somlo
On Thu, Jan 30, 2014 at 09:48:42PM +0200, Michael S. Tsirkin wrote: > Also, can you send the patch that you applied please? The kvm patch allowing OS X to boot is a one-liner: diff --git a/virt/kvm/ioapic.c b/virt/kvm/ioapic.c index ce9ed99..1539d37 100644 --- a/virt/kvm/ioapic.c +++ b/virt/kvm/i

Re: [Qemu-devel] [PATCH 13/12] qapi: refine human printing of sizes

2014-01-30 Thread Eric Blake
On 01/30/2014 09:42 AM, Paolo Bonzini wrote: > This fixes several bugs or shortcomings of the previous pretty-printer. > In particular: > > * use PRIu64 instead of casting to long long > > * the exact value is included too > > * the correct unit of measure (MiB, GiB, etc.) is used. PiB and EiB

[Qemu-devel] [uq/master PATCH 6/7] target-i386: Rename x86_def_t to X86CPUDefinition

2014-01-30 Thread Eduardo Habkost
As the new X86CPU subclass code is going to change lots of the code invoving x86_def_t, let's rename the struct to match coding style first. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/targe

[Qemu-devel] [uq/master PATCH 5/7] target-i386: Call x86_cpu_load_def() earlier

2014-01-30 Thread Eduardo Habkost
As we will initialize the X86CPU fields on instance_init eventually, move the code that initializes the X86CPU data based on the CPU model name closer to the object_new() call. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

[Qemu-devel] [uq/master PATCH 7/7] target-i386: CPU model subclasses

2014-01-30 Thread Eduardo Habkost
Register separate QOM classes for each x86 CPU model. This will allow management code to more easily probe what each CPU model provides, by simply creating objects using the appropriate class name, without having to restart QEMU. This also allows us to eliminate the qdev_prop_set_globals_for_type

[Qemu-devel] [uq/master PATCH 1/7] target-i386: Eliminate CONFIG_KVM #ifdefs

2014-01-30 Thread Eduardo Habkost
The compiler is already able to eliminate the kvm_arch_get_supported_cpuid() calls in kvm_cpu_fill_host() and filter_features_for_kvm(), so we can eliminate the CONFIG_KVM #ifdefs there. Also, kvm_cpu_fill_host() and host_cpuid() don't need to check CONFIG_KVM, as they don't have any KVM-specific

[Qemu-devel] [uq/master PATCH 2/7] target-i386: Don't change x86_def_t struct on cpu_x86_register()

2014-01-30 Thread Eduardo Habkost
As eventually the x86_def_t data is going to be provided by the CPU class, it's better to not touch it, and handle the special cases on the X86CPU object itself. Current behavior of the code should stay exactly the same. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 11 ++- 1 f

[Qemu-devel] [uq/master PATCH 0/7] x86 CPU subclasses, take 7

2014-01-30 Thread Eduardo Habkost
Is there any hope to get this into QEMU 2.0, or it is now too late? I got almost no feedback on take 6 (submitted November 27). This is the main blocker to allow libvirt finally implement an equivalent to the "enforce" flag, finally making the CPU configuration safe and sane (today libvirt simply

[Qemu-devel] [uq/master PATCH 4/7] target-i386: Rename cpu_x86_register() to x86_cpu_load_def()

2014-01-30 Thread Eduardo Habkost
There isn't any kind of "registration" involved in cpu_x86_register() anymore: it is simply looking up a CPU model name and loading the model definition data into the X86CPU object. Rename it to x86_cpu_load_def() to reflect what it does. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 6

[Qemu-devel] [uq/master PATCH 3/7] target-i386: Move KVM default-vendor hack to instance_init

2014-01-30 Thread Eduardo Habkost
As we will not have a cpu_x86_find_by_name() function anymore, move the KVM default-vendor hack to instance_init. Unfortunately we can't move that code to class_init because it depends on KVM being initialized. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 32 +++---

Re: [Qemu-devel] OSX guest vs. kvm ioapic polarity

2014-01-30 Thread Michael S. Tsirkin
On Thu, Jan 30, 2014 at 09:18:12AM -0500, Gabriel L. Somlo wrote: > On Thu, Jan 30, 2014 at 12:18:17AM +0200, Michael S. Tsirkin wrote: > > > OS X will boot fine with the one-liner KVM patch removing the > > > statement: > > > > > > "irq_level ^= entry.fields.polarity;" > > > > > > regardless

Re: [Qemu-devel] [PULL 00/42] rework input handling, sdl2 support

2014-01-30 Thread Peter Maydell
On 28 January 2014 09:56, Gerd Hoffmann wrote: > The input layer moves to a model modeled roughly after the linux > event layer. It also uses qapi to create all the data types needed. > First, because it is convinient to have all the support code generated, > and also to make it easier to integra

Re: [Qemu-devel] [PULL 0/5] tcg/i386 movbe support

2014-01-30 Thread Peter Maydell
On 25 January 2014 23:32, Richard Henderson wrote: > This is mostly Aurelien's patch series, with a few tweaks: > > In patch 3, rename P_EXT2 to P_EXT38, as I thing that's less > arbitrary for the 0x0f 0x38 prefix. > > In patch 4, use a "movop" local variable to reduce code duplication. > > Tested

Re: [Qemu-devel] [PATCH v2 4/6] XBZRLE cache size should not be larger than guest memory size

2014-01-30 Thread Orit Wasserman
On 01/30/2014 08:48 PM, Dr. David Alan Gilbert wrote: * Orit Wasserman (owass...@redhat.com) wrote: On 01/30/2014 08:23 PM, Dr. David Alan Gilbert wrote: * Orit Wasserman (owass...@redhat.com) wrote: Signed-off-by: Orit Wasserman --- migration.c | 7 +++ 1 file changed, 7 insertions(+)

Re: [Qemu-devel] [PATCH v2 4/6] XBZRLE cache size should not be larger than guest memory size

2014-01-30 Thread Dr. David Alan Gilbert
* Orit Wasserman (owass...@redhat.com) wrote: > On 01/30/2014 08:23 PM, Dr. David Alan Gilbert wrote: > >* Orit Wasserman (owass...@redhat.com) wrote: > >>Signed-off-by: Orit Wasserman > >>--- > >> migration.c | 7 +++ > >> 1 file changed, 7 insertions(+) > >> > >>diff --git a/migration.c b/m

Re: [Qemu-devel] [PATCH v2 4/6] XBZRLE cache size should not be larger than guest memory size

2014-01-30 Thread Dr. David Alan Gilbert
* Orit Wasserman (owass...@redhat.com) wrote: > Signed-off-by: Orit Wasserman Reviewed-by: Dr. David Alan Gilbert > --- > migration.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/migration.c b/migration.c > index 46a7305..25add6f 100644 > --- a/migration.c > +++ b/migration

Re: [Qemu-devel] [PATCH v2 4/6] XBZRLE cache size should not be larger than guest memory size

2014-01-30 Thread Orit Wasserman
On 01/30/2014 08:23 PM, Dr. David Alan Gilbert wrote: * Orit Wasserman (owass...@redhat.com) wrote: Signed-off-by: Orit Wasserman --- migration.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/migration.c b/migration.c index 46a7305..25add6f 100644 --- a/migration.c +++ b/migrati

Re: [Qemu-devel] [PULL 0/1] xen-140130

2014-01-30 Thread Stefano Stabellini
Anthony, I would appreciate if you could pull this branch quickly, as I am looking forward to backport the patch to the qemu-xen tree for the Xen 4.4 release. Thanks, Stefano On Thu, 30 Jan 2014, Stefano Stabellini wrote: > The following changes since commit 0169c511554cb0014a00290b0d3d26c31a4981

Re: [Qemu-devel] [PATCH 1/6] Set xbzrle buffers to NULL after freeing them to avoid double free errors

2014-01-30 Thread Eric Blake
On 01/30/2014 12:14 AM, Orit Wasserman wrote: > Signed-off-by: Orit Wasserman > Reviewed-by: Juan Quintela > --- > arch_init.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Eric Blake > > diff --git a/arch_init.c b/arch_init.c > index 77912e7..66f5e82 100644 > --- a/arch_init.c > +

[Qemu-devel] Live migration results in non-working virtio-net device (sometimes)

2014-01-30 Thread Neil Skrypuch
First, let me briefly outline the way we use live migration, as it is probably not typical. We use live migration (with block migration) to make backups of VMs with zero downtime. The basic process goes like this: 1) migrate src VM -> dest VM 2) migration completes 3) cont src VM 4) gracefully s

Re: [Qemu-devel] [PATCH v2 4/6] XBZRLE cache size should not be larger than guest memory size

2014-01-30 Thread Dr. David Alan Gilbert
* Orit Wasserman (owass...@redhat.com) wrote: > Signed-off-by: Orit Wasserman > --- > migration.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/migration.c b/migration.c > index 46a7305..25add6f 100644 > --- a/migration.c > +++ b/migration.c > @@ -479,6 +479,13 @@ void qmp_migr

Re: [Qemu-devel] [PATCH v2 5/6] Don't abort on out of memory when creating page cache

2014-01-30 Thread Dr. David Alan Gilbert
* Orit Wasserman (owass...@redhat.com) wrote: > Signed-off-by: Orit Wasserman > --- > arch_init.c | 18 -- > page_cache.c | 18 ++ > 2 files changed, 30 insertions(+), 6 deletions(-) Reviewed-by: Dr. David Alan Gilbert > > diff --git a/arch_init.c b/arch_init.

Re: [Qemu-devel] [PATCH v2 6/6] Don't abort on memory allocation error

2014-01-30 Thread Dr. David Alan Gilbert
* Orit Wasserman (owass...@redhat.com) wrote: > It is better to fail migration in case of failure to > allocate new cache item > > Signed-off-by: Orit Wasserman > --- > arch_init.c| 4 +++- > include/migration/page_cache.h | 4 +++- > page_cache.c | 16 +++

[Qemu-devel] [PATCH v2 6/6] Don't abort on memory allocation error

2014-01-30 Thread Orit Wasserman
It is better to fail migration in case of failure to allocate new cache item Signed-off-by: Orit Wasserman --- arch_init.c| 4 +++- include/migration/page_cache.h | 4 +++- page_cache.c | 16 +++- 3 files changed, 17 insertions(+), 7 deletions(

[Qemu-devel] [PATCH v2 5/6] Don't abort on out of memory when creating page cache

2014-01-30 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- arch_init.c | 18 -- page_cache.c | 18 ++ 2 files changed, 30 insertions(+), 6 deletions(-) diff --git a/arch_init.c b/arch_init.c index 5eff80b..1fa5f1f 100644 --- a/arch_init.c +++ b/arch_init.c @@ -664,8 +664,22 @@ static int

[Qemu-devel] [PATCH v2 2/6] Add check for cache size smaller than page size

2014-01-30 Thread Orit Wasserman
Signed-off-by: Orit Wasserman Reviewed-by: Juan Quintela --- arch_init.c | 4 migration.c | 10 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/arch_init.c b/arch_init.c index 66f5e82..8edeabe 100644 --- a/arch_init.c +++ b/arch_init.c @@ -178,6 +178,10 @@ static

[Qemu-devel] [PATCH v2 3/6] migration:fix free XBZRLE decoded_buf wrong

2014-01-30 Thread Orit Wasserman
From: "Gonglei (Arei)" When qemu do live migration with xbzrle, qemu malloc decoded_buf at destination end but free it at source end. It will crash qemu by double free error in some scenarios. Splitting the XBZRLE structure for clear logic distinguishing src/dst side. Signed-off-by: ChenLiang R

[Qemu-devel] [PATCH v2 4/6] XBZRLE cache size should not be larger than guest memory size

2014-01-30 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- migration.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/migration.c b/migration.c index 46a7305..25add6f 100644 --- a/migration.c +++ b/migration.c @@ -479,6 +479,13 @@ void qmp_migrate_set_cache_size(int64_t value, Error **errp) return;

[Qemu-devel] [PATCH v2 1/6] Set xbzrle buffers to NULL after freeing them to avoid double free errors

2014-01-30 Thread Orit Wasserman
Signed-off-by: Orit Wasserman Reviewed-by: Juan Quintela --- arch_init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch_init.c b/arch_init.c index 77912e7..66f5e82 100644 --- a/arch_init.c +++ b/arch_init.c @@ -617,6 +617,9 @@ static void migration_end(void) g_free(XBZRLE.c

[Qemu-devel] [PATCH v2 0/6] XBZRLE Fixes

2014-01-30 Thread Orit Wasserman
Fix memory leak and missing NULLs. Better cache size validation checks. Fail migration instead of aborting QEMU in case there is not enough memory for the page cache. Changes from v1: Free encoded_buf in case of failure to allocate current_buf. Update num_items after successful allocation. Gongl

Re: [Qemu-devel] [PATCH 6/6] Don't abort on memory allocation error

2014-01-30 Thread Orit Wasserman
On 01/30/2014 06:08 PM, Dr. David Alan Gilbert wrote: * Orit Wasserman (owass...@redhat.com) wrote: It is better to fail migration in case of failure to allocate new cache item Does this actually fail migration or just drop back to sending an uncompressed page? (I think the latter, and that's

Re: [Qemu-devel] [PATCH v6 0/5] Fix UST backend for LTTng 2.x

2014-01-30 Thread Mohamad Gebai
On 01/30/2014 09:02 AM, Stefan Hajnoczi wrote: Thanks for your efforts to bring the LTTng UST tracer back to life! Applied to my tracing tree: https://github.com/stefanha/qemu/commits/tracing Stefan Great, thank you! Mohamad

Re: [Qemu-devel] [PATCH 5/6] Don't abort on out of memory when creating page cache

2014-01-30 Thread Orit Wasserman
On 01/30/2014 05:48 PM, Dr. David Alan Gilbert wrote: * Orit Wasserman (owass...@redhat.com) wrote: Signed-off-by: Orit Wasserman --- arch_init.c | 16 ++-- page_cache.c | 18 ++ 2 files changed, 28 insertions(+), 6 deletions(-) diff --git a/arch_init.c b/arch_

Re: [Qemu-devel] [PATCH RFC 4/5] hw/machine: add qemu machine opts as properties to QemuMachineState

2014-01-30 Thread Paolo Bonzini
Il 30/01/2014 18:28, Marcel Apfelbaum ha scritto: > QEMUMachineInitArgs args = { .machine = machine, > .ram_size = ram_size, > .boot_order = boot_order, > .kernel_filename = kernel_filename,

Re: [Qemu-devel] [PATCH RFC 4/5] hw/machine: add qemu machine opts as properties to QemuMachineState

2014-01-30 Thread Marcel Apfelbaum
On Thu, 2014-01-30 at 17:48 +0100, Paolo Bonzini wrote: > Il 30/01/2014 15:47, Marcel Apfelbaum ha scritto: > > diff --git a/include/hw/boards.h b/include/hw/boards.h > > index 3cd48fe..51bcaba 100644 > > --- a/include/hw/boards.h > > +++ b/include/hw/boards.h > > @@ -86,6 +86,21 @@ struct QemuMach

Re: [Qemu-devel] [PATCH] Define the architecture for compressed dump format.

2014-01-30 Thread Laszlo Ersek
On 01/30/14 18:01, Ekaterina Tumanova wrote: > If you apply this patch on top of your changes, your patches will work > on s390x as well. > > --- > dump.c | 8 ++-- > target-i386/cpu.h | 2 ++ > target-s390x/cpu.h | 1 + > 3 files changed, 9 insertions(+), 2 deletions(-) > > dif

Re: [Qemu-devel] [PATCH v8 08/13] dump: add API to write dump header

2014-01-30 Thread Ekaterina Tumanova
On 01/28/2014 10:22 AM, qiaonuohan wrote: the functions are used to write header of kdump-compressed format to vmcore. Header of kdump-compressed format includes: 1. common header: DiskDumpHeader32 / DiskDumpHeader64 2. sub header: KdumpSubHeader32 / KdumpSubHeader64 3. extra information: only el

Re: [Qemu-devel] [PATCH] Use error_is_set() only when necessary

2014-01-30 Thread Andreas Färber
Am 30.01.2014 15:07, schrieb Markus Armbruster: > error_is_set(&var) is the same as var != NULL, but it takes > whole-program analysis to figure that out. Unnecessarily hard for > optimizers, static checkers, and human readers. Dumb it down to > obvious. > > Gets rid of several dozen Coverity fa

[Qemu-devel] [PATCH] Define the architecture for compressed dump format.

2014-01-30 Thread Ekaterina Tumanova
If you apply this patch on top of your changes, your patches will work on s390x as well. --- dump.c | 8 ++-- target-i386/cpu.h | 2 ++ target-s390x/cpu.h | 1 + 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/dump.c b/dump.c index 8f64aab..12ad114 100644 --- a/dum

Re: [Qemu-devel] [PATCH RFC 4/5] hw/machine: add qemu machine opts as properties to QemuMachineState

2014-01-30 Thread Paolo Bonzini
Il 30/01/2014 15:47, Marcel Apfelbaum ha scritto: diff --git a/include/hw/boards.h b/include/hw/boards.h index 3cd48fe..51bcaba 100644 --- a/include/hw/boards.h +++ b/include/hw/boards.h @@ -86,6 +86,21 @@ struct QemuMachineState { Object parent; /* public */ +char *accel; +boo

[Qemu-devel] [PATCH 13/12] qapi: refine human printing of sizes

2014-01-30 Thread Paolo Bonzini
This fixes several bugs or shortcomings of the previous pretty-printer. In particular: * use PRIu64 instead of casting to long long * the exact value is included too * the correct unit of measure (MiB, GiB, etc.) is used. PiB and EiB are added too. * due to an off-by-one error, 512*2^30 was pr

[Qemu-devel] [PATCH] s390x/kvm: cleanup partial register handling

2014-01-30 Thread Christian Borntraeger
From: Dominik Dingel Alex, if you have no complaints, I will push this patch to s390-next for 1.8. This brings s390 back in line with other kvm users and simply use cpu_synchronize_state. Ok? Christian ---snip--- The partial register handling (introduced with commits 420840e58b85f7f4e5493

Re: [Qemu-devel] [PATCH 6/6] Don't abort on memory allocation error

2014-01-30 Thread Dr. David Alan Gilbert
* Orit Wasserman (owass...@redhat.com) wrote: > It is better to fail migration in case of failure to > allocate new cache item Does this actually fail migration or just drop back to sending an uncompressed page? (I think the latter, and that's an even better result). > Signed-off-by: Orit Wasserm

Re: [Qemu-devel] [PATCH] Use error_is_set() only when necessary

2014-01-30 Thread Markus Armbruster
Eric Blake writes: > On 01/30/2014 07:07 AM, Markus Armbruster wrote: >> error_is_set(&var) is the same as var != NULL, but it takes >> whole-program analysis to figure that out. Unnecessarily hard for >> optimizers, static checkers, and human readers. Dumb it down to >> obvious. >> >> Gets ri

[Qemu-devel] [PATCH] xen_disk: add discard support

2014-01-30 Thread Olaf Hering
Implement discard support for xen_disk. It makes use of the existing discard code in qemu. The discard support is enabled unconditionally. The tool stack may provide a property "discard-enable" in the backend node to optionally disable discard support. This is helpful in case the backing file was

[Qemu-devel] [PATCH v2] block: handle "rechs" and "large" translation options

2014-01-30 Thread Paolo Bonzini
Sure, CHS translation is an obscure topic, and legacy options for hard-disk geometries are obscure as well. But since QEMU does nothing with it except telling the BIOS, and since there "large" and "rechs" are listed in the enums, parsing them seems to be the bare minimum. Signed-off-by: Paolo Bon

Re: [Qemu-devel] OSX guest vs. kvm ioapic polarity

2014-01-30 Thread Gabriel L. Somlo
On Thu, Jan 30, 2014 at 12:13:59AM +0100, Alexander Graf wrote: > Can you check whether it configures the ioapic differently? I poked around hw/i386/kvm/ioapic.c, looking for a few good spots to add printf statements. These should be spots where calls from the guest are handled, not where QEMU its

[Qemu-devel] hw/scsi/megasas.c: (sdev->id & 0xFF) >> 8

2014-01-30 Thread Markus Armbruster
There are several instances of ((sdev->id & 0xFF) >> 8) | (sdev->lun & 0xFF) or similar. The left operand of | is always 0. Did you intend to shift to the other right?

Re: [Qemu-devel] [PATCH 5/6] Don't abort on out of memory when creating page cache

2014-01-30 Thread Dr. David Alan Gilbert
* Orit Wasserman (owass...@redhat.com) wrote: > Signed-off-by: Orit Wasserman > --- > arch_init.c | 16 ++-- > page_cache.c | 18 ++ > 2 files changed, 28 insertions(+), 6 deletions(-) > > diff --git a/arch_init.c b/arch_init.c > index 5eff80b..806d096 100644 > --- a

Re: [Qemu-devel] [PATCH] Use error_is_set() only when necessary

2014-01-30 Thread Eric Blake
On 01/30/2014 07:07 AM, Markus Armbruster wrote: > error_is_set(&var) is the same as var != NULL, but it takes > whole-program analysis to figure that out. Unnecessarily hard for > optimizers, static checkers, and human readers. Dumb it down to > obvious. > > Gets rid of several dozen Coverity f

[Qemu-devel] [PATCH] dataplane: Comment fix

2014-01-30 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/block/dataplane/virtio-blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c index 456d437..2237edb 100644 --- a/hw/block/dataplane/virtio-blk.c +++ b/hw/block/dataplane/

Re: [Qemu-devel] [PATCH 12/12] qdev: use QAPI type names for properties

2014-01-30 Thread Eric Blake
On 01/30/2014 06:09 AM, Paolo Bonzini wrote: > Use "drive", "chr", etc. only for legacy_name (which shows up > in -device foo,? output). From the point of view of their type, > these are just strings. > > Signed-off-by: Paolo Bonzini > --- > hw/core/qdev-properties-system.c | 12 >

Re: [Qemu-devel] [PATCH 11/12] qdev: add enum property types to QAPI schema

2014-01-30 Thread Eric Blake
On 01/30/2014 06:09 AM, Paolo Bonzini wrote: > Prepare for when QOM introspection will be able to piggyback on the QAPI > schema for describing property types. > > Signed-off-by: Paolo Bonzini > --- > hw/core/qdev-properties.c | 18 +++ > hw/i386/kvm/i8254.c | 6 ++--- > hw/ti

Re: [Qemu-devel] [PATCH] xen_disk: add discard support

2014-01-30 Thread Stefano Stabellini
On Thu, 30 Jan 2014, Olaf Hering wrote: > Implement discard support for xen_disk. It makes use of the existing > discard code in qemu. > > The discard support is enabled unconditionally. The tool stack may provide a > property "discard-enable" in the backend node to optionally disable discard > su

Re: [Qemu-devel] [PATCH 10/12] qdev: remove hex8/32/64 property types

2014-01-30 Thread Eric Blake
On 01/30/2014 06:09 AM, Paolo Bonzini wrote: > Replace them with uint8/32/64. > > Signed-off-by: Paolo Bonzini > --- Reviewed-by: Eric Blake > +++ b/hw/audio/pcspk.c > @@ -181,7 +181,7 @@ static void pcspk_realizefn(DeviceState *dev, Error > **errp) > } > > static Property pcspk_propertie

Re: [Qemu-devel] Query Regarding Device Tree Support in QEMU

2014-01-30 Thread Peter Maydell
On 30 January 2014 14:11, rajan pathak wrote: > I have some Query regarding Device tree support in QEMU. > > I have gone through for OMAP qemu emulation and noticed a lots of effort has > been > gone for manually mapping the Register set and Hardware representaion into > Device emulation. > > Insi

Re: [Qemu-devel] [PATCH 09/12] qdev: remove most legacy printers

2014-01-30 Thread Eric Blake
On 01/30/2014 06:09 AM, Paolo Bonzini wrote: > Their functionality is either aesthetic only (e.g. on/off vs. true/false) > or obtained by the "human mode" of StringOutputVisitor. > > Signed-off-by: Paolo Bonzini > --- > hw/core/qdev-properties.c | 60 > --

[Qemu-devel] [PULL 0/1] libcacard glusterfs fix

2014-01-30 Thread Alon Levy
The following changes since commit 0706f7c85b3c0783f92d44b551f362884db0f4bd: Merge remote-tracking branch 'mjt/tags/trivial-patches-2014-01-16' into staging (2014-01-30 13:56:00 +) are available in the git repository at: git://people.freedesktop.org/~alon/qemu pull-libcacard.glusterfs

[Qemu-devel] [PULL 1/1] libcacard: Don't link with all libraries QEMU links to

2014-01-30 Thread Alon Levy
From: Christophe Fergeau As described in https://bugzilla.redhat.com/show_bug.cgi?id=987441 , libcacard currently links to all the libraries QEMU is linking to, including glusterfs libraries, libiscsi, ... libcacard does not need all of these. This patch ensures it's only linked with the librarie

Re: [Qemu-devel] [PATCH 08/12] qdev: use human mode in "info qtree"

2014-01-30 Thread Eric Blake
On 01/30/2014 06:09 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > qdev-monitor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signatur

Re: [Qemu-devel] [PATCH] libcacard: Don't link with all libraries QEMU links to

2014-01-30 Thread Alon Levy
On 01/30/2014 03:56 PM, Christophe Fergeau wrote: Acked-by: Alon Levy > As described in https://bugzilla.redhat.com/show_bug.cgi?id=987441 , > libcacard currently links to all the libraries QEMU is linking to, > including glusterfs libraries, libiscsi, ... libcacard does not need all of > these.

[Qemu-devel] [PATCH RFC 5/5] vl.c: set current_machine's properties

2014-01-30 Thread Marcel Apfelbaum
Setting machine's properties provides a cleaner way to get the properties values than using QemuOpts. Signed-off-by: Marcel Apfelbaum --- vl.c | 5 + 1 file changed, 5 insertions(+) diff --git a/vl.c b/vl.c index 4f4722e..fcd56db 100644 --- a/vl.c +++ b/vl.c @@ -4307,6 +4307,11 @@ int main(

[Qemu-devel] [PATCH RFC 3/5] hw/boards: converted current_machine to be an instance of QemuMachineCLass

2014-01-30 Thread Marcel Apfelbaum
In order to allow attaching machine options to a machine instance, current_machine is converted into QemuMachineState. As a first step of deprecating QEMUMachine, some of the functions were modified to return QemuMachineCLass. Signed-off-by: Marcel Apfelbaum --- device-hotplug.c| 4 +++- in

[Qemu-devel] [PATCH RFC 2/5] vl: use qemu machine QOM class instead of global machines list

2014-01-30 Thread Marcel Apfelbaum
The machine registration flow is refactored to use the QOM functionality. Instead of linking the machines into a list, each machine has a type and the types can be traversed in the QOM way. Signed-off-by: Marcel Apfelbaum --- vl.c | 75 +---

[Qemu-devel] [PATCH RFC 4/5] hw/machine: add qemu machine opts as properties to QemuMachineState

2014-01-30 Thread Marcel Apfelbaum
It is cleaner to query current_machine's properties than accessing QemuOpts from the code. Signed-off-by: Marcel Apfelbaum --- hw/core/machine.c | 251 include/hw/boards.h | 15 2 files changed, 266 insertions(+) diff --git a/hw/core/

[Qemu-devel] [PATCH RFC 1/5] hw/core: introduced qemu machine as QOM object

2014-01-30 Thread Marcel Apfelbaum
The main functionality change is to convert QEMUMachine into QemuMachineClass and QEMUMachineInitArgs into QemuMachineState, instance of QemuMachineClass. As a first step, in order to make possible an incremental developement, both QEMUMachine and QEMUMachineInitArgs are being embeded into the new

  1   2   >