Am 30.01.2014 15:07, schrieb Markus Armbruster:
> error_is_set(&var) is the same as var != NULL, but it takes
> whole-program analysis to figure that out.  Unnecessarily hard for
> optimizers, static checkers, and human readers.  Dumb it down to
> obvious.
> 
> Gets rid of several dozen Coverity false positives.
> 
> Note that the obvious form is already used in many places.
> 
> Signed-off-by: Markus Armbruster <arm...@redhat.com>

Reviewed-by: Andreas Färber <afaer...@suse.de>

I don't suppose you used a Coccinelle script that we could re-run in the
future? ;)

Via QMP queue?

Thanks,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Reply via email to