* Orit Wasserman (owass...@redhat.com) wrote: > Signed-off-by: Orit Wasserman <owass...@redhat.com> > --- > migration.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/migration.c b/migration.c > index 46a7305..25add6f 100644 > --- a/migration.c > +++ b/migration.c > @@ -479,6 +479,13 @@ void qmp_migrate_set_cache_size(int64_t value, Error > **errp) > return; > } > > + /* Cache should not be larger than guest ram size */
Why? (It's admittedly odd, but does it actually break something if it's larger?) Dave > + if (value > ram_bytes_total()) { > + error_set(errp, QERR_INVALID_PARAMETER_VALUE, "cache size", > + "exceeds guest ram size "); > + return; > + } > + > new_size = xbzrle_cache_resize(value); > if (new_size < 0) { > error_set(errp, QERR_INVALID_PARAMETER_VALUE, "cache size", > -- > 1.8.3.1 > -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK