Re: [Qemu-devel] [PATCH v1 2/2] Revert "error: Don't use error_report() for assertion msgs."

2014-01-27 Thread Markus Armbruster
Peter Crosthwaite writes: > Ping! > > Do reverts require the usual reviewed-by? Markus are you happy with > this mini series to address your error_report() concerns? Yes, I'm happy with it. Thank you!

[Qemu-devel] [PATCH v8 00/13] Make 'dump-guest-memory' dump in kdump-compressed format

2014-01-27 Thread qiaonuohan
Hi, all The last version is here: http://lists.nongnu.org/archive/html/qemu-devel/2014-01/msg00209.html Command 'dump-guest-memory' was introduced to dump guest's memory. But the vmcore's format is only elf32 or elf64. The message is here: http://lists.gnu.org/archive/html/qemu-devel/2012-04/msg0

Re: [Qemu-devel] [PATCH v8 00/13] Make 'dump-guest-memory' dump in kdump-compressed format

2014-01-27 Thread Qiao Nuohan
On 01/28/2014 02:21 PM, qiaonuohan wrote: Command 'dump-guest-memory' was introduced to dump guest's memory. But the vmcore's format is only elf32 or elf64. The message is here: http://lists.gnu.org/archive/html/qemu-devel/2012-04/msg03379.html Forget to change the URL, sorry. The last version

[Qemu-devel] [PATCH v8 09/13] dump: add API to write dump_bitmap

2014-01-27 Thread qiaonuohan
functions are used to write 1st and 2nd dump_bitmap of kdump-compressed format, which is used to indicate whether the corresponded page is existed in vmcore. 1st and 2nd dump_bitmap are same, because dump level is specified to 1 here. Signed-off-by: Qiao Nuohan --- dump.c| 164 +

[Qemu-devel] [PATCH v8 05/13] dump: add API to write elf notes to buffer

2014-01-27 Thread qiaonuohan
the function can be used by write_elf32_notes/write_elf64_notes to write notes to a buffer. If fd_write_vmcore is used, write_elf32_notes/write_elf64_notes will write elf notes to vmcore directly. Instead, if buf_write_note is used, elf notes will be written to opaque->note_buf at first. Signed-of

[Qemu-devel] [PATCH v8 01/13] dump: const-qualify the buf of WriteCoreDumpFunction

2014-01-27 Thread qiaonuohan
WriteCoreDumpFunction is a function pointer that points to the function used to write content in "buf" into core file, so "buf" should be const-qualify. Signed-off-by: Qiao Nuohan Reviewed-by: Laszlo Ersek --- dump.c|2 +- include/qom/cpu.h |3 ++- 2 files changed, 3 inserti

[Qemu-devel] [PATCH v8 07/13] dump: add members to DumpState and init some of them

2014-01-27 Thread qiaonuohan
add some members to DumpState that will be used in writing vmcore in kdump-compressed format. some of them, like page_size, will be initialized in the patch. Signed-off-by: Qiao Nuohan --- dump.c| 28 include/sysemu/dump.h |7 +++ 2 files ch

[Qemu-devel] [PATCH v8 10/13] dump: add APIs to operate DataCache

2014-01-27 Thread qiaonuohan
DataCache is used to store data temporarily, then the data will be written to vmcore. These functions will be called later when writing data of page to vmcore. Signed-off-by: Qiao Nuohan Reviewed-by: Laszlo Ersek --- dump.c| 47 +++

[Qemu-devel] [PATCH v8 12/13] dump: make kdump-compressed format available for 'dump-guest-memory'

2014-01-27 Thread qiaonuohan
Make monitor command 'dump-guest-memory' be able to dump in kdump-compressed format. The command's usage: dump [-p] protocol [begin] [length] [format] 'format' is used to specified the format of vmcore and can be: 1. 'elf': ELF format, without compression 2. 'kdump-zlib': kdump-compressed forma

[Qemu-devel] [PATCH v8 04/13] dump: add API to write vmcore

2014-01-27 Thread qiaonuohan
Function is used to write vmcore in flatten format. In flatten format, data is written block by block, and in front of each block, a struct MakedumpfileDataHeader is stored there to indicate the offset and size of the data block. struct MakedumpfileDataHeader { int64_t offset; int64_t buf_

[Qemu-devel] [PATCH target-arm v4 1/1] target-arm: Implements the ARM PMCCNTR register

2014-01-27 Thread Alistair Francis
This patch implements the ARM PMCCNTR register including the disable and reset components of the PMCR register. Signed-off-by: Alistair Francis --- This patch assumes that non-invasive debugging is not permitted when determining if the counter is disabled V4: Some bug fixes pointed out by Peter C

[Qemu-devel] [PATCH v8 11/13] dump: add API to write dump pages

2014-01-27 Thread qiaonuohan
functions are used to write page to vmcore. vmcore is written page by page. page desc is used to store the information of a page, including a page's size, offset, compression format, etc. Signed-off-by: Qiao Nuohan Reviewed-by: Laszlo Ersek --- dump.c| 231 +

[Qemu-devel] [PATCH v8 08/13] dump: add API to write dump header

2014-01-27 Thread qiaonuohan
the functions are used to write header of kdump-compressed format to vmcore. Header of kdump-compressed format includes: 1. common header: DiskDumpHeader32 / DiskDumpHeader64 2. sub header: KdumpSubHeader32 / KdumpSubHeader64 3. extra information: only elf notes here Signed-off-by: Qiao Nuohan Re

[Qemu-devel] [PATCH v8 13/13] dump: add 'query-dump-guest-memory-capability' command

2014-01-27 Thread qiaonuohan
'query-dump-guest-memory-capability' is used to query whether option 'format' is available for 'dump-guest-memory' and the available format. The output of the command will be like: -> { "execute": "query-dump-guest-memory-capability" } <- { "return": { "format-option": "optional",

[Qemu-devel] [PATCH v8 02/13] dump: add argument to write_elfxx_notes

2014-01-27 Thread qiaonuohan
write_elf32_notes/wirte_elf64_notes use fd_write_vmcore to write elf notes to vmcore. Adding parameter "WriteCoreDumpFunction f" makes it available to choose the method of writing elf notes Signed-off-by: Qiao Nuohan Reviewed-by: Laszlo Ersek --- dump.c | 16 1 files changed,

[Qemu-devel] [PATCH v8 06/13] dump: add support for lzo/snappy

2014-01-27 Thread qiaonuohan
kdump-compressed format supports three compression format, zlib/lzo/snappy. Currently, only zlib is available. This patch is used to support lzo/snappy. '--enable-lzo/--enable-snappy' is needed to be specified with configure to make lzo/snappy available for qemu Signed-off-by: Qiao Nuohan Reviewe

[Qemu-devel] [PATCH v8 03/13] dump: add API to write header of flatten format

2014-01-27 Thread qiaonuohan
flatten format will be used when writing kdump-compressed format. The format is also used by makedumpfile, you can refer to the following URL to get more detailed information about flatten format of kdump-compressed format: http://sourceforge.net/projects/makedumpfile/ The two functions here are u

Re: [Qemu-devel] [Qemu-ppc] KVM and variable-endianness guest CPUs

2014-01-27 Thread Benjamin Herrenschmidt
On Mon, 2014-01-27 at 16:44 -0800, Christoffer Dall wrote: > I'm loosing track of this discussion, Ben, can you explain a bit? You > wrote: > > Having a byte array coming in that represents what the CPU does in its > current byte order means you do *NOT* need to query the endianness of > t

[Qemu-devel] [PATCH 5/5] query-command-line-options: return help message for legacy options

2014-01-27 Thread Amos Kong
Some legacy options that have arguments weren't added to vm_config_groups[], so query-command-line-options returns a NULL parameters infolist. This patch try to return help message for this kind of legacy options. Example: { "helpmsg": "\"-vnc displaystart a VNC server on display\\n\"",

[Qemu-devel] [PATCH 4/5] introduce QEMU_OPTIONS_GENERATE_HELPMSG

2014-01-27 Thread Amos Kong
This patch introduced a new maroc, it will be used to dump the help messages of all the options. Signed-off-by: Amos Kong --- qemu-options-wrapper.h | 9 + 1 file changed, 9 insertions(+) diff --git a/qemu-options-wrapper.h b/qemu-options-wrapper.h index c36a9ee..bb0ac87 100644 --- a/qe

Re: [Qemu-devel] [PATCH arm-ccnt v3 1/1] ARM-CCNT: Implements the ARM PMCCNTR register

2014-01-27 Thread Alistair Francis
On Tue, Jan 28, 2014 at 12:01 PM, Peter Crosthwaite wrote: > On Tue, Jan 28, 2014 at 11:31 AM, Alistair Francis > wrote: >> Thanks, I'll rename the patch in the next version >> >> On Thu, Jan 23, 2014 at 11:56 PM, Peter Crosthwaite >> wrote: >>> Same subject-prefix as commented by Andreas. Shoul

[Qemu-devel] [PATCH 2/5] introduce two marcos to dump the options info

2014-01-27 Thread Amos Kong
We will use the marocs to generate two tables, which contain the option name and argument information. Signed-off-by: Amos Kong --- qemu-options-wrapper.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/qemu-options-wrapper.h b/qemu-options-wrapper.h index 13bfea0..c36a9e

[Qemu-devel] [PATCH 3/5] query-command-line-options: query all the options in qemu-options.hx

2014-01-27 Thread Amos Kong
vm_config_groups[] contain the options which have parameter, but some legcy options haven't been added to vm_config_groups[]. All the options can be found in qemu-options.hx, this patch used two new marcos to generate two tables, we can check if the option name is valid and if the option has argum

[Qemu-devel] [PATCH 1/5] qmp: rename query_option_descs() to get_param_infolist()

2014-01-27 Thread Amos Kong
Signed-off-by: Amos Kong --- util/qemu-config.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/util/qemu-config.c b/util/qemu-config.c index 9298f55..d624d92 100644 --- a/util/qemu-config.c +++ b/util/qemu-config.c @@ -39,7 +39,7 @@ QemuOptsList *qemu_find_opts(const

[Qemu-devel] [PATCH 0/5] fix query-command-line-options

2014-01-27 Thread Amos Kong
This patchset fixed some issues of query-command-line-options: * some new options haven't arguments can't be queried. (eg: -enable-fips) * some legcy options have arguments can't be queried. (eg: -vnc display) More discussion: http://marc.info/?l=qemu-devel&m=139081830416684&w=2 Amos Kong (5

[Qemu-devel] [Bug 1253777] Re: OpenBSD VM running on OpenBSD host has sleep calls taking twice as long as they should

2014-01-27 Thread Martin van den Nieuwelaar
Hadn't heard any news on this bug so decided to check the latest source. 1.7.0 now available so downloaded it and compiled it. No mean feat in itself for OpenBSD. FWIW it seemed a lot more difficult than for earlier (1.6.x) versions. 1.7.0 now reports its version as 1.7.0 - a good start. Alas t

Re: [Qemu-devel] [PATCH v1 2/2] Revert "error: Don't use error_report() for assertion msgs."

2014-01-27 Thread Edgar E. Iglesias
Hi, I committed it last week, forgot to email you. Cheers, Edgar On Tue, Jan 28, 2014 at 12:35:08PM +1000, Peter Crosthwaite wrote: > Ping! > > Do reverts require the usual reviewed-by? Markus are you happy with > this mini series to address your error_report() concerns? > > Regards, > Peter >

Re: [Qemu-devel] [PATCH v1 2/2] Revert "error: Don't use error_report() for assertion msgs."

2014-01-27 Thread Peter Crosthwaite
Ping! Do reverts require the usual reviewed-by? Markus are you happy with this mini series to address your error_report() concerns? Regards, Peter On Wed, Jan 15, 2014 at 9:06 PM, Peter Crosthwaite wrote: > This reverts commit d32934c84c72f57e78d430c22974677b7bcabe5d. > > The original implement

Re: [Qemu-devel] [RFC PATCH v4 3/8] arm_gic: Fix GIC pending behavior

2014-01-27 Thread Christoffer Dall
On Sun, Jan 19, 2014 at 07:49:58PM +, Peter Maydell wrote: > On 21 December 2013 06:09, Christoffer Dall > wrote: > > The existing implementation of the pending behavior in gic_set_irq, > > gic_acknowledge_irq, gic_complete_irq, and the distributor pending > > set/clear registers does not fol

Re: [Qemu-devel] [PATCH 19/24] target-arm: Implement AArch64 TTBR*

2014-01-27 Thread Peter Crosthwaite
On Sat, Jan 25, 2014 at 10:09 AM, Peter Maydell wrote: > On 24 January 2014 23:44, Peter Crosthwaite > wrote: >> On Wed, Jan 22, 2014 at 6:12 AM, Peter Maydell >> wrote: >>> Implement the AArch64 TTBR* registers. For v7 these were already 64 bits >>> to handle LPAE, but implemented as two separ

Re: [Qemu-devel] [PATCH arm-ccnt v3 1/1] ARM-CCNT: Implements the ARM PMCCNTR register

2014-01-27 Thread Peter Crosthwaite
On Tue, Jan 28, 2014 at 11:31 AM, Alistair Francis wrote: > Thanks, I'll rename the patch in the next version > > On Thu, Jan 23, 2014 at 11:56 PM, Peter Crosthwaite > wrote: >> Same subject-prefix as commented by Andreas. Should be "target-arm". >> >> On Wed, Jan 22, 2014 at 9:40 AM, Alistair Fr

Re: [Qemu-devel] [PATCH 11/24] target-arm: Implement AArch64 DAIF system register

2014-01-27 Thread Peter Crosthwaite
On Wed, Jan 22, 2014 at 6:12 AM, Peter Maydell wrote: > Implement the DAIF system register which is a view of the > DAIF bits in PSTATE. > > TODO: include support for the MSR_i encodings? > Isn't this already separately handled by the MSR_i implementation? > Signed-off-by: Peter Maydell Otherw

Re: [Qemu-devel] [PATCH 10/24] target-arm: Implement AArch64 MIDR_EL1

2014-01-27 Thread Peter Crosthwaite
On Wed, Jan 22, 2014 at 6:12 AM, Peter Maydell wrote: > Implement the AArch64 view of the MIDR system register > (for AArch64 it is a simple constant, unlike the complicated > mess that TI925 imposes on the 32-bit view). > > Signed-off-by: Peter Maydell Reviewed-by: Peter Crosthwaite > --- >

Re: [Qemu-devel] [PATCH 07/24] target-arm: A64: Make cache ID registers visible to AArch64

2014-01-27 Thread Peter Crosthwaite
On Wed, Jan 22, 2014 at 6:12 AM, Peter Maydell wrote: > Make the cache ID system registers (CLIDR, CCSELR, CCSIDR, CTR) > visible to AArch64. These are mostly simple 64-bit extensions of the > existing 32 bit system registers and so can share reginfo definitions. > CTR needs to have a split defini

[Qemu-devel] [Bug 942299] Re: Regression in booting HelenOS/ppc under Qemu

2014-01-27 Thread Stewart Smith
Works in current qemu trunk, setting Fix Released. ** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/942299 Title: Regression in bootin

Re: [Qemu-devel] [PATCH arm-ccnt v3 1/1] ARM-CCNT: Implements the ARM PMCCNTR register

2014-01-27 Thread Alistair Francis
Thanks, I'll rename the patch in the next version On Thu, Jan 23, 2014 at 11:56 PM, Peter Crosthwaite wrote: > Same subject-prefix as commented by Andreas. Should be "target-arm". > > On Wed, Jan 22, 2014 at 9:40 AM, Alistair Francis > wrote: >> This patch implements the ARM PMCCNTR register inc

Re: [Qemu-devel] [Qemu/Virtio-scsi]The feature of 'raw device mapping' cannot isolate the LUN to the owning virtual machine

2014-01-27 Thread Qixiaozhen
> On Mon, Jan 27, 2014 at 02:50:04AM +, Qixiaozhen wrote: > > A instance was created by virsh command in the CentOS 6.4. > > > > The LUN in the Storage Array Network(SAN) was attached to the instance > with the following xml. > > > > > > > >dev='/dev/mapper/360022a11ecba

Re: [Qemu-devel] [PATCH 05/24] target-arm: Add exception level to the AArch64 TB flags

2014-01-27 Thread Peter Crosthwaite
On Wed, Jan 22, 2014 at 6:12 AM, Peter Maydell wrote: > We already implicitly rely on the exception level being > part of the TB flags for coprocessor access, Maybe that's the issue? Why not just treat the exception level as state like any other and generate the TCG to just check it at execution

Re: [Qemu-devel] Support for Emulated SMSC 911X

2014-01-27 Thread Peter Crosthwaite
On Tue, Jan 28, 2014 at 7:40 AM, Peter Maydell wrote: > On 27 January 2014 21:05, Romanic Dean wrote: >> Just a small a query here,Can we call different Ethernet Controllers like >> Broadcom or e1000 from VersatilePB board. >> >> Is VersatilePB board only supports SMSC series of controllers? > >

Re: [Qemu-devel] [PATCH target-arm v5 4/5] arm: Implement reset GPIO.

2014-01-27 Thread Peter Crosthwaite
On Tue, Jan 28, 2014 at 3:52 AM, Peter Maydell wrote: > On 15 January 2014 09:14, Peter Crosthwaite > wrote: >> Implement a reset GPIO for ARM CPUs. This allows individual reset of ARM >> CPUs from device land without the need for the much unwanted reset API >> calls. >> >> The CPU is halted as l

Re: [Qemu-devel] [Qemu-ppc] KVM and variable-endianness guest CPUs

2014-01-27 Thread Christoffer Dall
On Tue, Jan 28, 2014 at 11:36:13AM +1100, Benjamin Herrenschmidt wrote: > On Mon, 2014-01-27 at 23:49 +, Peter Maydell wrote: > > > > Er, what? If we make the array be guest's current order > > then by definition userspace has to look at the guest's > > current endianness. I agree that would b

Re: [Qemu-devel] [Qemu-ppc] KVM and variable-endianness guest CPUs

2014-01-27 Thread Christoffer Dall
On Tue, Jan 28, 2014 at 11:32:41AM +1100, Benjamin Herrenschmidt wrote: > On Thu, 2014-01-23 at 20:11 -0800, Victor Kamensky wrote: > > > I would take 50 byteswaps with a clear ABI any day over an obscure > > > standard that can avoid a single hardware-on-register instruction. > > This > > > is abo

Re: [Qemu-devel] [Qemu-ppc] KVM and variable-endianness guest CPUs

2014-01-27 Thread Benjamin Herrenschmidt
On Mon, 2014-01-27 at 23:49 +, Peter Maydell wrote: > > Er, what? If we make the array be guest's current order > then by definition userspace has to look at the guest's > current endianness. I agree that would be bad. Either > of the two current proposals (host kernel order; guest > CPU's nat

Re: [Qemu-devel] [PATCH 2/2] block: remove qcow2 .bdrv_make_empty implementation

2014-01-27 Thread Benoît Canet
Le Monday 27 Jan 2014 à 16:09:13 (-0500), Jeff Cody a écrit : > The QCOW2 .bdrv_make_empty implementation always returns 0 for success, > but does not actually do anything. > > The proper way to not support an optional driver function stub is to > just not implement it, so let's remove the stub. >

Re: [Qemu-devel] [PATCH 1/2] block: remove QED .bdrv_make_empty implementation

2014-01-27 Thread Benoît Canet
Le Monday 27 Jan 2014 à 16:09:12 (-0500), Jeff Cody a écrit : > The QED .bdrv_make_empty() implementation does nothing but return > -ENOTSUP, which causes problems in bdrv_commit(). Since the function > stub exists for QED, it is called, which then always returns an error. > > The proper way to n

Re: [Qemu-devel] [Qemu-ppc] KVM and variable-endianness guest CPUs

2014-01-27 Thread Benjamin Herrenschmidt
On Thu, 2014-01-23 at 20:11 -0800, Victor Kamensky wrote: > > I would take 50 byteswaps with a clear ABI any day over an obscure > > standard that can avoid a single hardware-on-register instruction. > This > > is about designing a clean software interface, not about building an > > optimized integ

Re: [Qemu-devel] [PATCH v4 3/3] hw/arm/allwinner-a10: initialize EMAC

2014-01-27 Thread Peter Crosthwaite
On Mon, Jan 27, 2014 at 7:39 AM, Beniamino Galvani wrote: > Signed-off-by: Beniamino Galvani Reviewed-by: Peter Crosthwaite > --- > hw/arm/allwinner-a10.c | 16 > hw/arm/cubieboard.c| 11 +-- > include/hw/arm/allwinner-a10.h |3 +++ > 3 fil

Re: [Qemu-devel] [PATCH v4 2/3] hw/net: add support for Allwinner EMAC Fast Ethernet controller

2014-01-27 Thread Peter Crosthwaite
On Mon, Jan 27, 2014 at 7:39 AM, Beniamino Galvani wrote: > This patch adds support for the Fast Ethernet MAC found on Allwinner > SoCs, together with a basic emulation of Realtek RTL8201CP PHY. > > Since there is no public documentation of the Allwinner controller, the > implementation is based o

Re: [Qemu-devel] [Qemu-ppc] KVM and variable-endianness guest CPUs

2014-01-27 Thread Benjamin Herrenschmidt
> The point is simple, and Peter has made it over and over: > Any consumer of a memory operation sees "value, len, address". > > This is what KVM_EXIT_MMIO emulates. So just by knowing the ABI > definition and having a pointer to the structure you need to be able to > tell me "value, len, addres

Re: [Qemu-devel] [Qemu-ppc] KVM and variable-endianness guest CPUs

2014-01-27 Thread Benjamin Herrenschmidt
On Tue, 2014-01-28 at 11:07 +1100, Benjamin Herrenschmidt wrote: > On Thu, 2014-01-23 at 15:33 +, Peter Maydell wrote: > > (4) PPC CPUs in BE mode and ARM CPUs in BE mode are not > > the same, because in the ARM case it is doing an > > internal-to-CPU byteswap, and in the PPC case it

Re: [Qemu-devel] [Qemu-ppc] KVM and variable-endianness guest CPUs

2014-01-27 Thread Benjamin Herrenschmidt
On Thu, 2014-01-23 at 15:33 +, Peter Maydell wrote: > (4) PPC CPUs in BE mode and ARM CPUs in BE mode are not > the same, because in the ARM case it is doing an > internal-to-CPU byteswap, and in the PPC case it is not Aren't they both byte-order invariant ? In that case they are t

Re: [Qemu-devel] [PATCH V6 8/8] block: Use graph node name as reference in bdrv_file_open().

2014-01-27 Thread Benoît Canet
Le Monday 27 Jan 2014 à 20:11:59 (+0100), Max Reitz a écrit : > On 27.01.2014 15:36, Benoît Canet wrote: > >Le Friday 24 Jan 2014 à 15:54:39 (+0100), Max Reitz a écrit : > >>On 24.01.2014 15:48, Kevin Wolf wrote: > >>>Am 24.01.2014 um 14:37 hat Max Reitz geschrieben: > On 24.01.2014 14:26, Kevi

Re: [Qemu-devel] [PATCH v4 1/3] util/fifo8: implement push/pop of multiple bytes

2014-01-27 Thread Peter Crosthwaite
On Tue, Jan 28, 2014 at 4:32 AM, Peter Maydell wrote: > On 26 January 2014 21:39, Beniamino Galvani wrote: >> In some circumstances it is useful to be able to push the entire >> content of a memory buffer to the fifo or to pop multiple bytes with a >> single operation. >> >> The functions fifo8_h

Re: [Qemu-devel] [PATCH] ACPI: Add IRQ resource to HPET._CRS on Mac OS X

2014-01-27 Thread Alexander Graf
On 27.01.2014, at 23:51, Gabriel L. Somlo wrote: > On Sat, Jan 25, 2014 at 10:08:37AM +0100, Alexander Graf wrote: >>> From a cursory pass through the Chameleon source, I don't think so. >> Ok :). I only barely remember what Chameleon did on top of the normal >> Apple BIOS bootloader. > > I'll

Re: [Qemu-devel] [Qemu-ppc] KVM and variable-endianness guest CPUs

2014-01-27 Thread Peter Maydell
On 27 January 2014 23:34, Benjamin Herrenschmidt wrote: > On Wed, 2014-01-22 at 20:02 +, Peter Maydell wrote: >> >> Defining it as being always guest-order would mean that >> userspace had to continually look at the guest CPU >> endianness bit, which is annoying and awkward. >> >> Defining it

Re: [Qemu-devel] [Qemu-ppc] KVM and variable-endianness guest CPUs

2014-01-27 Thread Benjamin Herrenschmidt
On Wed, 2014-01-22 at 20:02 +, Peter Maydell wrote: > > Defining it as being always guest-order would mean that > userspace had to continually look at the guest CPU > endianness bit, which is annoying and awkward. > > Defining it as always host-endian order is the most > reasonable option ava

Re: [Qemu-devel] [Qemu-ppc] KVM and variable-endianness guest CPUs

2014-01-27 Thread Benjamin Herrenschmidt
On Wed, 2014-01-22 at 11:29 -0800, Victor Kamensky wrote: > I don't see why you so attached to desire to describe > data part of memory transaction as just one of int > types. If we are talking about bunch of hypothetical > cases imagine such bus that allow transaction with > size of 6 bytes. How d

Re: [Qemu-devel] [Qemu-ppc] KVM and variable-endianness guest CPUs

2014-01-27 Thread Benjamin Herrenschmidt
On Wed, 2014-01-22 at 17:29 +, Peter Maydell wrote: > > > Basically if it would be on real bus, get byte value > > that corresponds to phys_addr + 0 address place > > it into data[0], get byte value that corresponds to > > phys_addr + 1 address place it into data[1], etc. > > This just isn't

Re: [Qemu-devel] [PATCH] ACPI: Add IRQ resource to HPET._CRS on Mac OS X

2014-01-27 Thread Gabriel L. Somlo
On Sat, Jan 25, 2014 at 10:08:37AM +0100, Alexander Graf wrote: > > From a cursory pass through the Chameleon source, I don't think so. > Ok :). I only barely remember what Chameleon did on top of the normal > Apple BIOS bootloader. I'll start poking at it to find out exactly what it does, but it

[Qemu-devel] [PATCH] monitor: Add device_del argument completion.

2014-01-27 Thread Hani Benhabiles
Signed-off-by: Hani Benhabiles --- monitor.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/monitor.c b/monitor.c index 80456fb..a7a589e 100644 --- a/monitor.c +++ b/monitor.c @@ -4254,6 +4254,25 @@ static const char *next_arg_type(const char *typestr) return (p

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/8] target-ppc: Add bctar Instruction

2014-01-27 Thread Alexander Graf
On 27.01.2014, at 20:34, Tom Musta wrote: > On 1/27/2014 12:46 PM, Alexander Graf wrote: >>> static inline void gen_bcond(DisasContext *ctx, int type) { @@ -3756,10 +3757,12 @@ static inline void gen_bcond(DisasContext *ctx, int type) TCGv target; ctx->excep

Re: [Qemu-devel] [Qemu-ppc] [PATCH 5/8] target-ppc: Load Quadword

2014-01-27 Thread Alexander Graf
On 27.01.2014, at 20:53, Tom Musta wrote: > On 1/27/2014 12:55 PM, Alexander Graf wrote: >> You're mixing two semantically separate things here. legal_in_user_mode >> doesn't really indicate that le_mode isn't usable. I'm sure if you just make >> this two if()'s with two separate bools that ge

Re: [Qemu-devel] Support for Emulated SMSC 911X

2014-01-27 Thread Peter Maydell
On 27 January 2014 21:05, Romanic Dean wrote: > Just a small a query here,Can we call different Ethernet Controllers like > Broadcom or e1000 from VersatilePB board. > > Is VersatilePB board only supports SMSC series of controllers? You need to distinguish: * what does the real hardware do? *

Re: [Qemu-devel] [PATCH 0/2] Remove unsupported / empty .bdrv_make_empty functions

2014-01-27 Thread Eric Blake
On 01/27/2014 02:09 PM, Jeff Cody wrote: > QED and QCOW2 both have .bdrv_make_empty stubs that do nothing. In the > case of QED, it returns an error (-ENOTSUP), which causes problems with > bdrv_commit(). > > This removes those stubs. > > Jeff Cody (2): > block: remove QED .bdrv_make_empty im

[Qemu-devel] [PATCH 2/2] block: remove qcow2 .bdrv_make_empty implementation

2014-01-27 Thread Jeff Cody
The QCOW2 .bdrv_make_empty implementation always returns 0 for success, but does not actually do anything. The proper way to not support an optional driver function stub is to just not implement it, so let's remove the stub. Signed-off-by: Jeff Cody --- block/qcow2.c | 21 -

[Qemu-devel] [PATCH 1/2] block: remove QED .bdrv_make_empty implementation

2014-01-27 Thread Jeff Cody
The QED .bdrv_make_empty() implementation does nothing but return -ENOTSUP, which causes problems in bdrv_commit(). Since the function stub exists for QED, it is called, which then always returns an error. The proper way to not support an optional driver function stub is to just not implement it,

[Qemu-devel] [PATCH 0/2] Remove unsupported / empty .bdrv_make_empty functions

2014-01-27 Thread Jeff Cody
QED and QCOW2 both have .bdrv_make_empty stubs that do nothing. In the case of QED, it returns an error (-ENOTSUP), which causes problems with bdrv_commit(). This removes those stubs. Jeff Cody (2): block: remove QED .bdrv_make_empty implementation block: remove qcow2 .bdrv_make_empty imple

Re: [Qemu-devel] Support for Emulated SMSC 911X

2014-01-27 Thread Romanic Dean
Thanks Peter for your thoughts. We are able to call lan9118 controller from VersatilePB board. We made little modification to our guest OS. Just a small a query here,Can we call different Ethernet Controllers like Broadcom or e1000 from VersatilePB board. Is VersatilePB board only supports SMSC

Re: [Qemu-devel] [PATCH v3 00/19] bsd-user: Add system call and mips/arm support.

2014-01-27 Thread Peter Maydell
On 27 January 2014 19:27, Stacey Son wrote: > On Jan 27, 2014, at 1:15 PM, Peter Maydell wrote: >> I've been hoping somebody who uses FreeBSD would review >> these, but since nobody has I'm going to take a look at >> them. However, I've noticed that none of the patches in >> this series have Sign

Re: [Qemu-devel] [PATCH v3 19/19] bsd-user: fix linking conflicts with FreeBSD libcrypto

2014-01-27 Thread Stacey Son
On Jan 27, 2014, at 2:07 PM, Peter Maydell wrote: > On 17 December 2013 11:52, Stacey Son wrote: >> FreeBSD has it's own AES_set_decrypt_key, etc. in libcrypto. This >> change fixes these conflicts and allows statically linking BSD >> user mode qemu. >> --- >> include/qemu/aes.h |9 +++

Re: [Qemu-devel] [PATCH 16/18] bsd-user: add support for extended attribute and ACL related syscalls

2014-01-27 Thread Peter Maydell
On 16 October 2013 15:37, Stacey Son wrote: > This change add support for extended attribute and Access Control List > (ACL) related system calls including extattrctl(), extattr_set_file(2), > extattr_delete_file(2), extattr_set_fd(2), extattr_get_fd(2), > extattr_delete_fd(2), extattr_get_link(2)

Re: [Qemu-devel] [PATCH v3 19/19] bsd-user: fix linking conflicts with FreeBSD libcrypto

2014-01-27 Thread Peter Maydell
On 17 December 2013 11:52, Stacey Son wrote: > FreeBSD has it's own AES_set_decrypt_key, etc. in libcrypto. This > change fixes these conflicts and allows statically linking BSD > user mode qemu. > --- > include/qemu/aes.h |9 + > 1 files changed, 9 insertions(+), 0 deletions(-) > >

Re: [Qemu-devel] [PATCH v3 18/19] bsd-user: add arm, mips and mips64 options to configure target-list

2014-01-27 Thread Peter Maydell
On 17 December 2013 11:52, Stacey Son wrote: > This change adds arm-bsd-user, mips-bsd-user, mips64-bsd-user, > mips64el-bsd-user, and mipsel-bsd-user as --target-list options to configure. > --- > default-configs/arm-bsd-user.mak |3 +++ > default-configs/mips-bsd-user.mak |1 +

Re: [Qemu-devel] [Qemu-ppc] [PATCH 7/8] target-ppc: Add Load Quadword and Reserve

2014-01-27 Thread Tom Musta
On 1/27/2014 12:59 PM, Alexander Graf wrote: > > On 27.01.2014, at 18:54, Tom Musta wrote: > >> This patch adds the Load Quadword and Reserve (lqarx) instruction, >> which is new in Power ISA 2.07. >> >> Signed-off-by: Tom Musta >> --- >> target-ppc/translate.c | 34 ++

Re: [Qemu-devel] [PATCH v3 06/19] bsd-user: add support for freebsd time related system calls

2014-01-27 Thread Peter Maydell
On 17 December 2013 11:52, Stacey Son wrote: > This change adds support or stubs for time related system calls > including nanosleep(2), clock_gettime(2), clock_settime(2), > clock_getres(2), gettimeofday(2), settimeofday(2), adjtime(2), > ntp_adjtime(2), ntp_gettime(2), utimes(2), lutimes(2), fut

Re: [Qemu-devel] [Qemu-ppc] [PATCH 5/8] target-ppc: Load Quadword

2014-01-27 Thread Tom Musta
On 1/27/2014 12:55 PM, Alexander Graf wrote: > You're mixing two semantically separate things here. legal_in_user_mode > doesn't really indicate that le_mode isn't usable. I'm sure if you just make > this two if()'s with two separate bools that get assigned the same value gcc > will be smart eno

Re: [Qemu-devel] [PATCH v3 05/19] bsd-user: move arch/OS dependent code out of syscall.c

2014-01-27 Thread Peter Maydell
On 17 December 2013 11:52, Stacey Son wrote: > This change moves the system call handler for sysctl(2) and > sysarch(2) from syscall.c to the OS and arch dependent directories. > This eliminates many of the #ifdef's in syscall.c. These system > call handlers are now located in the host os and tar

Re: [Qemu-devel] [PATCH v3 04/19] bsd-user: move arch/OS dependent code out of main.c

2014-01-27 Thread Peter Maydell
On 17 December 2013 11:52, Stacey Son wrote: > This change moves the cpu initialization and main loop code from > main.c to the OS and arch dependent directories. This eliminates > many of the #ifdef's in main.c. The cpu initialization and loop > code is now located in the arch directory along wit

Re: [Qemu-devel] [PATCH v3 03/19] bsd-user: move strace OS/arch dependent code to host/arch dirs

2014-01-27 Thread Peter Maydell
On 17 December 2013 11:52, Stacey Son wrote: > This change moves host OS and arch dependent code for the sysarch > system call related to the -strace functionality into the > appropriate host OS and target arch directories. This patch seems to be trying to do too much at once. Before this patch

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/8] target-ppc: Add bctar Instruction

2014-01-27 Thread Tom Musta
On 1/27/2014 12:46 PM, Alexander Graf wrote: >> static inline void gen_bcond(DisasContext *ctx, int type) >> > { >> > @@ -3756,10 +3757,12 @@ static inline void gen_bcond(DisasContext *ctx, >> > int type) >> > TCGv target; >> > >> > ctx->exception = POWERPC_EXCP_BRANCH; >> > -if (type

Re: [Qemu-devel] [PATCH 01/10] block: Change BDS parameter of bdrv_open() to **

2014-01-27 Thread Max Reitz
On 27.01.2014 20:31, Jeff Cody wrote: On Sun, Jan 26, 2014 at 08:02:34PM +0100, Max Reitz wrote: Make bdrv_open() take a pointer to a BDS pointer, similarly to bdrv_file_open(). If a pointer to a NULL pointer is given, bdrv_open() will create a new BDS with an empty name; if the BDS pointer is n

Re: [Qemu-devel] [PATCH v3 02/19] bsd-user: add HOST_VARIANT_DIR for various *BSD dependent code

2014-01-27 Thread Peter Maydell
On 17 December 2013 11:52, Stacey Son wrote: > This change adds HOST_VARIANT_DIR so the various BSD OS dependent > code can be seperated into its own directories rather than > using #ifdef's. This may also allow an BSD variant OS to host > another BSD variant's executible as a target. Reviewed

Re: [Qemu-devel] [PATCH v3 01/19] bsd-user: refresh freebsd system call numbers

2014-01-27 Thread Peter Maydell
On 17 December 2013 11:52, Stacey Son wrote: > Update FreeBSD system call numbers in freebsd/syscall_nr.h. > > Reviewed-by: Ed Maste Reviewed-by: Peter Maydell though this patch would look much nicer if you hadn't changed every single line in the file including the ones for syscalls we alread

Re: [Qemu-devel] [PATCH 01/10] block: Change BDS parameter of bdrv_open() to **

2014-01-27 Thread Jeff Cody
On Sun, Jan 26, 2014 at 08:02:34PM +0100, Max Reitz wrote: > Make bdrv_open() take a pointer to a BDS pointer, similarly to > bdrv_file_open(). If a pointer to a NULL pointer is given, bdrv_open() > will create a new BDS with an empty name; if the BDS pointer is not > NULL, that existing BDS will b

Re: [Qemu-devel] [PATCH v3 00/19] bsd-user: Add system call and mips/arm support.

2014-01-27 Thread Stacey Son
On Jan 27, 2014, at 1:15 PM, Peter Maydell wrote: > On 17 December 2013 11:52, Stacey Son wrote: >> [v3] >> >> - Rebases to commit f46e720a82ccdf1a521cf459448f3f96ed895d43 (HEAD). >> - Changes 'HOST_API_DIR' to 'HOST_VARIANT_DIR' for the BSD variant. >> - Fixes boundry condition bug in mmap()

Re: [Qemu-devel] [PULL 1/4] tracing: start trace processing thread in final child process

2014-01-27 Thread Eric Blake
On 01/27/2014 07:53 AM, Stefan Hajnoczi wrote: > From: Michael Mueller > > When running with trace backend e.g. "simple" the writer thread needs to be > implemented in the same process context as the trace points that will be > processed. Under libvirtd control, qemu gets first started in daemoni

Re: [Qemu-devel] [PATCH v3 00/19] bsd-user: Add system call and mips/arm support.

2014-01-27 Thread Peter Maydell
On 17 December 2013 11:52, Stacey Son wrote: > [v3] > > - Rebases to commit f46e720a82ccdf1a521cf459448f3f96ed895d43 (HEAD). > - Changes 'HOST_API_DIR' to 'HOST_VARIANT_DIR' for the BSD variant. > - Fixes boundry condition bug in mmap() system call handler. > - Fixes floating point support for MIP

Re: [Qemu-devel] [PATCH V6 8/8] block: Use graph node name as reference in bdrv_file_open().

2014-01-27 Thread Max Reitz
On 27.01.2014 15:36, Benoît Canet wrote: Le Friday 24 Jan 2014 à 15:54:39 (+0100), Max Reitz a écrit : On 24.01.2014 15:48, Kevin Wolf wrote: Am 24.01.2014 um 14:37 hat Max Reitz geschrieben: On 24.01.2014 14:26, Kevin Wolf wrote: Am 23.01.2014 um 21:31 hat Benoît Canet geschrieben: Signed-o

Re: [Qemu-devel] [PATCH target-arm v3] display: avoid multi-statement macro

2014-01-27 Thread Peter Maydell
On 27 January 2014 18:12, Paolo Bonzini wrote: > For blizzard, pl110 and tc6393xb this is harmless, but for pxa2xx > Coverity noticed that it is used inside an "if" statement. > Fix it because it's the file with the highest number of defects > in the whole QEMU tree! Use "do...while (0)", or just

Re: [Qemu-devel] [PATCH 09/10] block: Reuse success path from bdrv_open()

2014-01-27 Thread Max Reitz
On 27.01.2014 18:44, Jeff Cody wrote: On Sun, Jan 26, 2014 at 08:02:42PM +0100, Max Reitz wrote: The fail and success paths of bdrv_file_open() may be further shortened by reusing code already existent in bdrv_open(). This includes bdrv_file_open() not taking the reference to options which allow

Re: [Qemu-devel] [Qemu-ppc] [PATCH 7/8] target-ppc: Add Load Quadword and Reserve

2014-01-27 Thread Alexander Graf
On 27.01.2014, at 18:54, Tom Musta wrote: > This patch adds the Load Quadword and Reserve (lqarx) instruction, > which is new in Power ISA 2.07. > > Signed-off-by: Tom Musta > --- > target-ppc/translate.c | 34 ++ > 1 files changed, 34 insertions(+), 0 deletion

Re: [Qemu-devel] [PATCH 07/10] block: Reuse fail path from bdrv_open()

2014-01-27 Thread Max Reitz
On 27.01.2014 04:10, Benoît Canet wrote: Le Sunday 26 Jan 2014 à 20:02:40 (+0100), Max Reitz a écrit : The fail paths of bdrv_file_open() and bdrv_open() naturally exhibit similarities, thus it is possible to reuse the one from bdrv_open() and shorten the one in bdrv_file_open() accordingly. Si

Re: [Qemu-devel] [Qemu-ppc] [PATCH 5/8] target-ppc: Load Quadword

2014-01-27 Thread Alexander Graf
On 27.01.2014, at 18:54, Tom Musta wrote: > This patch adds the Book I (user space) Load Quadword (lq) instruction. > This instruction was introduced into Book I in Power ISA V2.07. Previous > versions of the architecture supported this as a privileged instruction. > Previous versions of the ar

Re: [Qemu-devel] [PATCH 01/10] block: Change BDS parameter of bdrv_open() to **

2014-01-27 Thread Max Reitz
On 27.01.2014 03:38, Benoît Canet wrote: Le Sunday 26 Jan 2014 à 20:02:34 (+0100), Max Reitz a écrit : Make bdrv_open() take a pointer to a BDS pointer, similarly to bdrv_file_open(). If a pointer to a NULL pointer is given, bdrv_open() will create a new BDS with an empty name; if the BDS pointe

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/8] target-ppc: Add bctar Instruction

2014-01-27 Thread Alexander Graf
On 27.01.2014, at 18:54, Tom Musta wrote: > This patch adds the Branch Conditional to Address Register (bctar) > instruction. > > Signed-off-by: Tom Musta > --- > target-ppc/translate.c | 11 ++- > 1 files changed, 10 insertions(+), 1 deletions(-) > > diff --git a/target-ppc/translat

Re: [Qemu-devel] [PATCH v4 3/3] hw/arm/allwinner-a10: initialize EMAC

2014-01-27 Thread Peter Maydell
On 26 January 2014 21:39, Beniamino Galvani wrote: > Signed-off-by: Beniamino Galvani Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v4 2/3] hw/net: add support for Allwinner EMAC Fast Ethernet controller

2014-01-27 Thread Peter Maydell
On 26 January 2014 21:39, Beniamino Galvani wrote: > This patch adds support for the Fast Ethernet MAC found on Allwinner > SoCs, together with a basic emulation of Realtek RTL8201CP PHY. > > Since there is no public documentation of the Allwinner controller, the > implementation is based on Linux

Re: [Qemu-devel] [PATCH] block/vmdk: add basic .bdrv_check support

2014-01-27 Thread Peter Lieven
Am 27.01.2014 16:37, schrieb Stefan Hajnoczi: > On Mon, Jan 13, 2014 at 12:24:06PM +0100, Peter Lieven wrote: >> +for (;;) { >> +if (sector_num >= total_sectors) { >> +return 0; >> +} >> +extent = find_extent(s, sector_num, extent); >> +if (!extent) {

Re: [Qemu-devel] [PATCH v4 1/3] util/fifo8: implement push/pop of multiple bytes

2014-01-27 Thread Peter Maydell
On 26 January 2014 21:39, Beniamino Galvani wrote: > In some circumstances it is useful to be able to push the entire > content of a memory buffer to the fifo or to pop multiple bytes with a > single operation. > > The functions fifo8_has_space() and fifo8_push_all() added by this > patch allow to

Re: [Qemu-devel] [PATCHv6 0/6] block: add native support for NFS

2014-01-27 Thread Peter Lieven
Am 27.01.2014 17:11, schrieb Stefan Hajnoczi: > On Mon, Jan 13, 2014 at 11:21:52AM +0100, Peter Lieven wrote: >> This adds v6 of the NFS protocol driver + qemu-iotest adjustments. >> >> v5->v6: >> - use internal qemu function to parse the NFS url [Kevin] >> - zero pad short reads [Kevin, Paolo] >

  1   2   >