Re: [Qemu-devel] ?????? ?????? ?????? ?????? qemu vm big network latency when met heavy io

On 01/13/2014 10:39 PM, ?? wrote: Hi Josh Thanks for your reply. librbd version : 0.67.5-1 /etc/ceph/ceph.conf config file: the ip and hostname was hiddened. [global] ;open auth. auth cluster required = cephx auth service required = cephx auth client req

Re: [Qemu-devel] [PATCH v15 0/9] Shared library module support

On Mon, 01/13 22:01, Peter Maydell wrote: > On 13 January 2014 16:59, Paolo Bonzini wrote: > > This is based on Fam's patches from October. Very few changes > > apart from rebasing: > > > > * I split his patch 8 in two parts. There is benefit in > > using per-object cflags and libs even before t

Re: [Qemu-devel] [PATCH v2] SPARC: Fix LEON3 power down instruction

Hello, maybe this patch can be qualified as trivial? http://lists.nongnu.org/archive/html/qemu-devel/2013-11/msg03488.html On 2014-01-07 19:07, Sebastian Huber wrote: Hello, would somebody mind committing this. On 12/06/2013 06:48 PM, Richard Henderson wrote: On 11/27/2013 08:50 PM, Sebasti

Re: [Qemu-devel] 回复： 回复： 回复： qemu vm big network latency when met heavy io

On 01/12/2014 06:39 PM, Stefan Hajnoczi wrote: > On Fri, Jan 10, 2014 at 11:50 AM, 叶绍琛 wrote: > > Please use Reply-all to keep the CC list in tact. That way the > conversation stays on the mailing list and others can participate. > >>> Is the sum of guests' RAM less than the total physical RAM

[Qemu-devel] [PATCH] exec: Exclude non portable function for MinGW

cpu_physical_memory_set_dirty_lebitmap calls getpageaddr and ffsl which are unavailable for MinGW. As the function is unused for MinGW, it can simply be excluded from compilation. Signed-off-by: Stefan Weil --- include/exec/ram_addr.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/incl

Re: [Qemu-devel] Question about drive mirror

On Tue, Jan 14, 2014 at 09:41:41AM +0800, Fam Zheng wrote: > On Mon, 01/13 23:44, rudy...@163.com wrote: > > I tested the capability of drive mirror, I found the IO is low. Then I read > > the code, > > The code mirror_run() will call mirror_iteration() to read the size of > > buffer data > >

Re: [Qemu-devel] [PATCH v2 1/2] hw/net: add support for Allwinner EMAC Fast Ethernet controller

On Mon, Jan 13, 2014 at 11:16:37PM +1000, Peter Crosthwaite wrote: > On Mon, Jan 13, 2014 at 11:15 PM, Peter Crosthwaite > wrote: > > On Sat, Jan 11, 2014 at 8:13 PM, Beniamino Galvani > > wrote: > >> +} else { > >> +mii->bmsr &= ~MII_BMSR_LINK_ST; > >> +mii->anlpar = MII_ANA

Re: [Qemu-devel] [PATCH 4/5] net: add offloadings support to netmap backend

On Mon, Jan 13, 2014 at 04:11:25PM +0100, Vincenzo Maffione wrote: > 2014/1/13 Stefan Hajnoczi > > > On Fri, Dec 13, 2013 at 01:05:02PM +0100, Vincenzo Maffione wrote: > > > +static void netmap_using_vnet_hdr(NetClientState *nc, bool enable) > > > +{ > > > +} > > > > I was trying to figure out wh

Re: [Qemu-devel] [PULL 00/14] QMP queue

On Tue, Jan 14, 2014 at 09:27:10AM +1000, Peter Crosthwaite wrote: > Ping, > > Has this one been forgotten or are there issues? PMM had a small > comment, but he waived it AFAICT. Pong, I've merged it now, thanks! Cheers, Edgar > > Regards, > Peter > > On Tue, Jan 7, 2014 at 8:03 AM, Luiz Ca

Re: [Qemu-devel] Using virtio-net and vhost_net on an ARM machine using qemu-system-arm & KVM

Hi, Barak, Hope the following info can help you 1. HOST: http://git.linaro.org/people/christoffer.dall/linux-kvm-arm.git branch: v3.10-arndale config: arch/arm/configs/exynos5_arndale_defconfig dtb: arch/arm/boot/dts/exynos5250-ar

[Qemu-devel] [PATCH] dataplane: fix shadowed return value

Propagate the error return value from get_indirect(). Signed-off-by: Stefan Hajnoczi --- hw/virtio/dataplane/vring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/dataplane/vring.c b/hw/virtio/dataplane/vring.c index 250d45e..665a1ff 100644 --- a/hw/virtio/datapla

Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading

On Mon, 01/13 22:05, Peter Maydell wrote: > On 13 January 2014 16:59, Paolo Bonzini wrote: > > From: Fam Zheng > > > > This patch adds loading, stamp checking and initialization of modules. > > > > The init function of dynamic module is no longer directly called as > > __attribute__((constructor)

Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading

On Mon, 01/13 22:09, Peter Maydell wrote: > On 13 January 2014 16:59, Paolo Bonzini wrote: > > From: Fam Zheng > > > > This patch adds loading, stamp checking and initialization of modules. > > > > The init function of dynamic module is no longer directly called as > > __attribute__((constructor)

Re: [Qemu-devel] [PATCH v2 19/24] block: Allow wait_serialising_requests() at any point

于 2014/1/13 19:29, Kevin Wolf 写道: Am 27.12.2013 um 05:17 hat Wenchao Xia geschrieben: 于 2013/12/13 21:22, Kevin Wolf 写道: We can only have a single wait_serialising_requests() call per request because otherwise we can run into deadlocks where requests are waiting for each other. do you mean:

Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading

On Mon, 01/13 14:15, Richard Henderson wrote: > On 01/13/2014 08:59 AM, Paolo Bonzini wrote: > > +echo "CONFIG_STAMP=`date +%s`_$$_$RANDOM" >> $config_host_mak > > I really really don't like random numbers that make for non-repeatable builds. > It's a quality-assurance nightmare. Can you elabora

Re: [Qemu-devel] [PATCH v6 06/11] dump: add API to write dump header

On 01/14/2014 10:29 AM, Laszlo Ersek wrote: I can't really provide any input to that decision -- I have no clue which tools support which format. The non-flat (ie. random-access, regular file) format appears more space- and computation-efficient, and I thought that would be the "natural" choice.

Re: [Qemu-devel] [PATCH v6 06/11] dump: add API to write dump header

On 01/14/14 03:07, Qiao Nuohan wrote: > On 01/13/2014 06:39 PM, Laszlo Ersek wrote: >> >> - When this write_buffer() is directed to a regular file in non-flat >> mode, then the file might become sparse (you jump over a range of >> offsets with lseek() in write_buffer()).

Re: [Qemu-devel] [PATCH v6 06/11] dump: add API to write dump header

On 01/13/2014 06:39 PM, Laszlo Ersek wrote: >> >> - When this write_buffer() is directed to a regular file in non-flat >> mode, then the file might become sparse (you jump over a range of >> offsets with lseek() in write_buffer()). If the output has been opened >> by qemu itself (ie."file:...

Re: [Qemu-devel] [PATCH arm-midr v2 1/1] Microblaze: Convert Microblaze-pic handling to GPIOs

On Mon, Jan 13, 2014 at 01:35:26PM +1000, Alistair Francis wrote: > This patch uses inbound GPIO lines (IRQ and FIR) for > interrupts instead of using the old pic_cpu method, > which doesn't correspond to real hardware. > > This creates the CPU's inbound IRQ and FIR GPIO lines and > updates the Mi

Re: [Qemu-devel] Question about drive mirror

On Mon, 01/13 23:44, rudy...@163.com wrote: > Hi,everyone. > I tested the capability of drive mirror, I found the IO is low. Then I read > the code, > The code mirror_run() will call mirror_iteration() to read the size of buffer > data > from source storage, when the read callback ,and then in

[Qemu-devel] 回复： Re: 回复： Re: [PATCH] linux-user: sync syscall numbers upto 3.13

I'm sorry, but what's exactly your meaning? Change linux-user/unicore32/syscall_nr.h to be the same as linux kernel. Or, we will use include/*/unistd.h in linux kernel directly, by copying or referencing. Thanks, Guan Xuetao - Peter Maydell 写道： > On 13 January 2014 15:14, 管雪涛 wrote: > > T

Re: [Qemu-devel] [PATCH] target-arm: Switch ARMCPUInfo arrays to use terminator entries

On Mon, Jan 13, 2014 at 10:26:16AM +, Peter Maydell wrote: > Switch the ARMCPUInfo arrays in cpu.c and cpu64.c to use a terminator > entry rather than looping based on ARRAY_SIZE. The latter causes > compile warnings on some versions of gcc if the configure options > happen to result in an empt

Re: [Qemu-devel] [PATCH 1/1] genius: add genius serial mouse emulation

Hi, Thanks for review. Le 13/01/2014 23:45, Eric Blake a écrit : On 01/13/2014 03:33 PM, Romain Naour wrote: This patch adds the emulation for a serial Genius mouse using Mouse Systems protocol (5bytes). This protocol is compatible with most 3-button serial mouse. Signed-off-by: Romain Naour

[Qemu-devel] [PATCH arm-midr v2 0/2] Make ARM-MIDR a property and use in Zynq

This series converts cpu->midr (the MIDR register) to a property. This allows it to be set after init which is useful for specific boards (such as Zynq). The change has been done in such a way that it doesn't break compatibility with boards that don't need a custom MIDR. V2: Use dc->props to avoi

[Qemu-devel] [PATCH arm-midr v2 2/2] ZYNQ: Implement board MIDR control for Zynq

This patch uses the fact that the midr variable is now a property This patch sets the midr variable to the boards custom midr Signed-off-by: Alistair Francis --- hw/arm/xilinx_zynq.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xil

[Qemu-devel] [PATCH arm-midr v2 1/2] ARM: Convert MIDR to a property

Convert the MIDR register to a property. This allows boards to later set a custom MIDR value. This has been done in such a way to maintain compatibility with all existing CPUs and boards Signed-off-by: Alistair Francis --- I originally added the properties to the cpu->midr variable in a similar m

Re: [Qemu-devel] [PATCH v3 00/22] Steps towards per CPU address-spaces

On Mon, Jan 13, 2014 at 09:37:23PM +0100, Artyom Tarasenko wrote: > Hi Edgar, Hi Artyom, > > On Mon, Jan 13, 2014 at 8:39 AM, wrote: > > From: "Edgar E. Iglesias" > > > > Hi, > > > > I'm looking at modeling systems where multiple CPUs co-exist with > > different views of their attached buses/

Re: [Qemu-devel] [PULL 00/14] QMP queue

Ping, Has this one been forgotten or are there issues? PMM had a small comment, but he waived it AFAICT. Regards, Peter On Tue, Jan 7, 2014 at 8:03 AM, Luiz Capitulino wrote: > The following changes since commit f976b09ea2493fd41c98aaf6512908db0bae: > > PPC: Fix compilation with TCG debug

Re: [Qemu-devel] [PULL 14/28] exec: make address spaces 64-bit wide

On Mon, 2014-01-13 at 22:48 +0100, Alexander Graf wrote: > > > Am 13.01.2014 um 22:39 schrieb Alex Williamson : > > > >> On Sun, 2014-01-12 at 16:03 +0100, Alexander Graf wrote: > >>> On 12.01.2014, at 08:54, Michael S. Tsirkin wrote: > >>> > On Fri, Jan 10, 2014 at 08:31:36AM -0700, Alex

Re: [Qemu-devel] [PATCH 1/1] genius: add genius serial mouse emulation

On 01/13/2014 03:33 PM, Romain Naour wrote: > This patch adds the emulation for a serial Genius mouse using > Mouse Systems protocol (5bytes). > This protocol is compatible with most 3-button serial mouse. > > Signed-off-by: Romain Naour > --- > backends/Makefile.objs | 2 +- > backends/gnmous

[Qemu-devel] [PATCH 1/1] genius: add genius serial mouse emulation

This patch adds the emulation for a serial Genius mouse using Mouse Systems protocol (5bytes). This protocol is compatible with most 3-button serial mouse. Signed-off-by: Romain Naour --- backends/Makefile.objs | 2 +- backends/gnmouse.c | 339 ++

[Qemu-devel] [PATCH 0/1] Genius serial mouse emulation.

This patch adds the emulation for a serial Genius mouse using Mouse Systems protocol (5bytes) [1]. This protocol is compatible with most 3-buttons serial mouse. This work was developed for qemu-1.1.0 and rebased on master. To test this patch you need to start qemu with "-serial gnmouse". Then you

Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading

On 01/13/2014 08:59 AM, Paolo Bonzini wrote: > +echo "CONFIG_STAMP=`date +%s`_$$_$RANDOM" >> $config_host_mak I really really don't like random numbers that make for non-repeatable builds. It's a quality-assurance nightmare. If you want a non-random number unique to the build, try git log -n1

Re: [Qemu-devel] [PATCH v15 0/9] Shared library module support

On 13 January 2014 16:59, Paolo Bonzini wrote: > This is based on Fam's patches from October. Very few changes > apart from rebasing: > > * I split his patch 8 in two parts. There is benefit in > using per-object cflags and libs even before the module-loading > machinery gets in. > > * I added a

Re: [Qemu-devel] [PATCH v15 4/9] darwin: do not use -mdynamic-no-pic

On 13 January 2014 16:59, Paolo Bonzini wrote: > While -mdynamic-no-pic can speed up the code somewhat, it is only used > on the legacy PowerPC Mac OS X, and I am not sure if anyone is still > testing that. Disabling PIC can cause problems when enabling modules, > so do not do that. > > Signed-of

Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading

On 13 January 2014 16:59, Paolo Bonzini wrote: > From: Fam Zheng > > This patch adds loading, stamp checking and initialization of modules. > > The init function of dynamic module is no longer directly called as > __attribute__((constructor)) in static linked version, it is called > only after pa

Re: [Qemu-devel] [BUGFIX][PATCH v2] configure: Disable libtool if -fPIE does not work with it (bug #1257099)

On 01/02/14 21:12, Don Slutz wrote: Ping. Adjust TMPO and added TMPB, TMPL, and TMPA. libtool needs the names to be fixed (TMPB). Add new functions do_libtool and libtool_prog. Add check for broken gcc and libtool. Signed-off-by: Don Slutz --- Was posted as an attachment. https://lists.gn

Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading

On 13 January 2014 16:59, Paolo Bonzini wrote: > From: Fam Zheng > > This patch adds loading, stamp checking and initialization of modules. > > The init function of dynamic module is no longer directly called as > __attribute__((constructor)) in static linked version, it is called > only after pa

[Qemu-devel] [Bug 1268671] [NEW] CentOS guest crashing due to assertion failure in qemu-char.c

Public bug reported: Here is the log in /var/log/libvirt/qemu/centos_heavy.log qemu-kvm: /builddir/build/BUILD/qemu-kvm-0.12.1.2/qemu-char.c:630: io_watch_poll_finalize: Assertion `iwp->src == ((void *)0)' failed. 2014-01-13 16:50:31.576+: shutting down The code it's failing the assertion o

[Qemu-devel] [Bug 1268671] Re: CentOS guest crashing due to assertion failure in qemu-char.c

** Description changed: Here is the log in /var/log/libvirt/qemu/centos_heavy.log qemu-kvm: /builddir/build/BUILD/qemu-kvm-0.12.1.2/qemu-char.c:630: io_watch_poll_finalize: Assertion `iwp->src == ((void *)0)' failed. 2014-01-13 16:50:31.576+: shutting down The code it's failing

[Qemu-devel] 回复： Re: [PATCH] linux-user: sync syscall numbers upto 3.13

The syscall numbers in unicore32 are correct because we have two ABIs for 32 bits. In qemu, it's old ABI, while in kernel, it's new ABI. However, for now, old ABI is widely used for unicore32's applications. Thanks and Regards, Xuetao Guan - Peter Maydell 写道： > On 13 January 2014 12:33,

[Qemu-devel] [Bug 1268596] [NEW] Compilation Error: hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may be used uninitialised in this function

Public bug reported: Qemu git-cloned from mo. 13.01.14 (ca. 13:00 GMT), Version 1.7.50 #git clone git://git.qemu-project.org/qemu.git # cd qemu; git submodule update --init dtc #./configure --disable-xen --enable-kvm ...No Errors... #CC="ccache gcc" make -j8 GEN qemu.1 Signing option

Re: [Qemu-devel] [PATCH microblaze v1 1/1] Microblaze: Convert Microblaze-pic handling to GPIOs

On Fri, Jan 10, 2014 at 04:41:06PM +1000, Alistair Francis wrote: > This patch uses inbound GPIO lines (IRQ and FIR) for > interrupts instead of using the old pic_cpu method, > which doesn't correspond to real hardware. > > This creates the CPU's inbound IRQ and FIR GPIO lines and > updates the Mi

[Qemu-devel] [Bug 1268596] Re: Compilation Error: hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may be used uninitialised in this function

** Description changed: Qemu git-cloned from mo. 13.01.14 (ca. 13:00 GMT), Version 1.7.50 - #git clone git://git.qemu-project.org/qemu.git # cd qemu; git submodule update --init dtc #./configure --disable-xen --enable-kvm ...No Errors... #CC="ccache gcc" make -j8 - GEN

Re: [Qemu-devel] [PULL 14/28] exec: make address spaces 64-bit wide

> Am 13.01.2014 um 22:39 schrieb Alex Williamson : > >> On Sun, 2014-01-12 at 16:03 +0100, Alexander Graf wrote: >>> On 12.01.2014, at 08:54, Michael S. Tsirkin wrote: >>> On Fri, Jan 10, 2014 at 08:31:36AM -0700, Alex Williamson wrote: > On Fri, 2014-01-10 at 14:55 +0200, Michael S.

Re: [Qemu-devel] [PULL 14/28] exec: make address spaces 64-bit wide

On Sun, 2014-01-12 at 16:03 +0100, Alexander Graf wrote: > On 12.01.2014, at 08:54, Michael S. Tsirkin wrote: > > > On Fri, Jan 10, 2014 at 08:31:36AM -0700, Alex Williamson wrote: > >> On Fri, 2014-01-10 at 14:55 +0200, Michael S. Tsirkin wrote: > >>> On Thu, Jan 09, 2014 at 03:42:22PM -0700, Al

[Qemu-devel] [PATCH] vfio: Destroy memory regions

Somehow this has been lurking for a while; we remove our subregions from the base BAR and VGA region mappings, but we don't destroy them, creating a leak and more serious problems when we try to migrate after removing these devices. Add the trivial bit of final cleanup to remove these entirely. S

[Qemu-devel] [PATCH v3] configure: add option to disable -fstack-protector flags

The -fstack-protector flag family is useful for ensuring safety and for debugging, but has a performance impact. Here are some boot time comparisons of the various versions of -fstack-protector using qemu-system-arm on an x86_64 host: # -fstack-protector-all Startup finished in 1.810s (ker

Re: [Qemu-devel] [PATCH v3 00/22] Steps towards per CPU address-spaces

Hi Edgar, On Mon, Jan 13, 2014 at 8:39 AM, wrote: > From: "Edgar E. Iglesias" > > Hi, > > I'm looking at modeling systems where multiple CPUs co-exist with > different views of their attached buses/devs. > > With this series I'm trying to take some steps towards having > an address-space per CP

Re: [Qemu-devel] [PATCH] configure: add option to disable -fstack-protector flags

Hi, please see comments below. Am 13.01.2014 21:00, schrieb Steven Noonan: > The -fstack-protector flag family is useful for ensuring safety and for > debugging, but has a performance impact. Here are some boot time comparisons > of > the various versions of -fstack-protector using qemu-system-a

[Qemu-devel] [PATCH v2] ACPI: Fix AppleSMC _STA size

Minimize the storage used for AppleSMC's _STA (8bit), relying on ASL to implicitly convert it to the officially specified 32bit value. Signed-off-by: Gabriel Somlo --- This applies incrementally on top of "Add DSDT node for AppleSMC" v.3 (accepted Dec. 25, 2013), and obsoletes everything I've se

Re: [Qemu-devel] [PATCH RESEND 2/2] hw/mips: use sizes.h macros

Am 13.01.2014 21:23, schrieb Antony Pavlov: > Signed-off-by: Antony Pavlov > Reviewed-by: Richard Henderson > Reviewed-by: Andreas Färber > --- > hw/mips/mips_malta.c | 25 + > include/hw/mips/bios.h | 3 ++- > 2 files changed, 15 insertions(+), 13 deletions(-) > > d

[Qemu-devel] [PATCH 1/2] block: resize backing file image during offline commit, if necessary

Currently, if an image file is logically larger than its backing file, commiting it via 'qemu-img commit' will fail. For instance, if we have a base image with a virtual size 10G, and a snapshot image of size 20G, then committing the snapshot offline with 'qemu-img commit' will likely fail. This

[Qemu-devel] [PATCH 0/2] block: commits of snapshots larger than backing files

If a snapshot is larger than a backing file, then the offline bdrv_commit and the live active layer commit will fail with an i/o error (usually). A live commit of a non-active layer will complete successfully, as it runs bdrv_truncate() on the backing image to resize it to the larger size. For bo

[Qemu-devel] [PATCH 2/2] block: resize backing image during active layer commit, if needed

If the top image to commit is the active layer, and also larger than the base image, then an I/O error will likely be returned during block-commit. For instance, if we have a base image with a virtual size 10G, and a active layer image of size 20G, then committing the snapshot via 'block-commit' w

[Qemu-devel] [PATCH RESEND 2/2] hw/mips: use sizes.h macros

Signed-off-by: Antony Pavlov Reviewed-by: Richard Henderson Reviewed-by: Andreas Färber --- hw/mips/mips_malta.c | 25 + include/hw/mips/bios.h | 3 ++- 2 files changed, 15 insertions(+), 13 deletions(-) diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c index

[Qemu-devel] [PATCH RESEND 0/2] use sizes.h macros for power-of-two sizes

The sizes.h macros is an easy-to-read method of power-of-two memory sizes representation. The sizes.h macros are actively used in the linux kernel and other projects, so let's use them in QEMU too. Antony Pavlov (2): include/qemu: introduce sizes.h hw/mips: use sizes.h macros hw/mips/mips_ma

[Qemu-devel] [PATCH RESEND 1/2] include/qemu: introduce sizes.h

The header file sizes.h is used in linux kernel, barebox bootloader and u-boot bootloader. It provides short and easy-to-read names for power-of-two numbers. The numbers like this are othen used for memory range sizes. Signed-off-by: Antony Pavlov Reviewed-by: Richard Henderson Reviewed-by: Andr

[Qemu-devel] [PATCH] configure: add option to disable -fstack-protector flags

The -fstack-protector flag family is useful for ensuring safety and for debugging, but has a performance impact. Here are some boot time comparisons of the various versions of -fstack-protector using qemu-system-arm on an x86_64 host: # -fstack-protector-all Startup finished in 1.810s (ker

[Qemu-devel] [PATCH] ACPI: AppleSMC _STA method should return 32bit value

Signed-off-by: Gabriel Somlo --- This applies incrementally on top of "Add DSDT node for AppleSMC" v.3 (accepted Dec. 25, 2013), and obsoletes v.4 of same with cleaner code in acpi-build.c. Thanks, Gabriel hw/i386/acpi-dsdt-isa.dsl | 4 ++-- hw/i386/acpi-build.c | 11 +-- 2 fil

[Qemu-devel] [PATCH 34/49] memory: cpu_physical_memory_get_dirty() is used as returning a bool

Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman --- include/exec/memory-internal.h | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h index edca8a8..fa28fc6 100644 -

[Qemu-devel] [PATCH 38/49] memory: cpu_physical_memory_clear_dirty_range() now uses bitmap operations

We were clearing a range of bits, so use bitmap_clear(). Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman --- include/exec/memory-internal.h | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/include/exec/memory-internal.h b/include/e

[Qemu-devel] [PATCH 16/49] exec: use accessor function to know if memory is dirty

Signed-off-by: Juan Quintela Reviewed-by: Orit Wasserman Reviewed-by: Eric Blake --- exec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exec.c b/exec.c index 7e49e8e..c42a2f9 100644 --- a/exec.c +++ b/exec.c @@ -1508,7 +1508,7 @@ static void notdirty_mem_write(void *opaq

[Qemu-devel] [PATCH 47/49] memory: syncronize kvm bitmap using bitmaps operations

If bitmaps are aligned properly, use bitmap operations. If they are not, just use old bit at a time code. Signed-off-by: Juan Quintela Reviewed-by: Orit Wasserman --- include/exec/ram_addr.h | 54 - 1 file changed, 36 insertions(+), 18 deletions(

[Qemu-devel] [PATCH 33/49] memory: make cpu_physical_memory_get_dirty() the main function

And make cpu_physical_memory_get_dirty_flag() to use it. It used to be the other way around. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman --- include/exec/memory-internal.h | 36 +++- 1 file changed, 19 insertions(+), 17 dele

[Qemu-devel] [PATCH 49/49] migration: synchronize memory bitmap 64bits at a time

We use the old code if the bitmaps are not aligned Signed-off-by: Juan Quintela Reviewed-by: Orit Wasserman --- arch_init.c | 38 +- 1 file changed, 29 insertions(+), 9 deletions(-) diff --git a/arch_init.c b/arch_init.c index 2cd3d00..77912e7 100644 --- a/a

[Qemu-devel] [PATCH 43/49] memory: unfold memory_region_test_and_clear()

We are going to update the bitmap directly Signed-off-by: Juan Quintela Reviewed-by: Orit Wasserman --- arch_init.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/arch_init.c b/arch_init.c index e0acbc5..0e8c8b5 100644 --- a/arch_init.c +++ b/arch_init.c @@ -48,6

[Qemu-devel] [PATCH 44/49] kvm: use directly cpu_physical_memory_* api for tracking dirty pages

Performance is important in this function, and we want to optimize even further. Signed-off-by: Juan Quintela Reviewed-by: Orit Wasserman --- kvm-all.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 3937754..308dfba 100644 --- a/kvm-all.c

[Qemu-devel] [PATCH v4] Add DSDT node for AppleSMC

AppleSMC (-device isa-applesmc) is required to boot OS X guests. OS X expects a SMC node to be present in the ACPI DSDT. This patch adds a SMC node to the DSDT, and dynamically patches the return value of SMC._STA to either 0x0B if the chip is present, or otherwise to 0x00, before booting the guest

[Qemu-devel] [PATCH 40/49] memory: make cpu_physical_memory_reset_dirty() take a length parameter

We have an end parameter in all the callers, and this make it coherent with the rest of cpu_physical_memory_* functions, that also take a length parameter. Once here, move the start/end calculation to tlb_reset_dirty_range_all() as we don't need it here anymore. Signed-off-by: Juan Quintela Revi

[Qemu-devel] [PATCH 36/49] memory: use find_next_bit() to find dirty bits

This operation is way faster than doing it bit by bit. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman --- include/exec/memory-internal.h | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/include/exec/memory-internal.h b/incl

[Qemu-devel] [PATCH 48/49] ram: split function that synchronizes a range

This function is the only bit where we care about speed. Signed-off-by: Juan Quintela Reviewed-by: Orit Wasserman --- arch_init.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/arch_init.c b/arch_init.c index 0e8c8b5..2cd3d00 100644 ---

[Qemu-devel] [PATCH 42/49] memory: split cpu_physical_memory_* functions to its own include

All the functions that use ram_addr_t should be here. Signed-off-by: Juan Quintela Reviewed-by: Orit Wasserman --- cputlb.c | 1 + exec.c | 1 + include/exec/memory-internal.h | 76 include/exec/ram_addr.h|

[Qemu-devel] [PATCH 35/49] memory: s/mask/clear/ cpu_physical_memory_mask_dirty_range

Now all functions use the same wording that bitops/bitmap operations Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman --- exec.c | 2 +- include/exec/memory-internal.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --g

[Qemu-devel] [PATCH 46/49] memory: move bitmap synchronization to its own function

We want to have all the functions that handle directly the dirty bitmap near. We will change it later. Signed-off-by: Juan Quintela Reviewed-by: Orit Wasserman --- include/exec/ram_addr.h | 31 +++ kvm-all.c | 27 ++- 2 files ch

[Qemu-devel] [PATCH 41/49] memory: cpu_physical_memory_set_dirty_tracking() should return void

Result was always 0, and not used anywhere. Once there, use bool type for the parameter. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman --- exec.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/exec.c b/exec.c index c71f2d5..51

[Qemu-devel] [PATCH 32/49] memory: unfold cpu_physical_memory_set_dirty_flag()

Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman --- include/exec/memory-internal.h | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h index 9d34434..b99617a 100644 --- a/in

[Qemu-devel] [PATCH 45/49] kvm: refactor start address calculation

Signed-off-by: Juan Quintela Reviewed-by: Orit Wasserman --- kvm-all.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 308dfba..cb62ba4 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -382,7 +382,8 @@ static int kvm_get_dirty_pages_log_range(Mem

[Qemu-devel] [PATCH 30/49] memory: unfold cpu_physical_memory_clear_dirty_flag() in its only user

Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman --- include/exec/memory-internal.h | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h index 6fb1b64..2f6610a 100644 --- a/

[Qemu-devel] [PATCH 37/49] memory: cpu_physical_memory_set_dirty_range() now uses bitmap operations

We were setting a range of bits, so use bitmap_set(). Note: xen has always been wrong, and should have used start instead of addr from the beginning. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman --- include/exec/memory-internal.h | 19 +++ 1

[Qemu-devel] [PATCH 39/49] memory: s/dirty/clean/ in cpu_physical_memory_is_dirty()

All uses except one really want the other meaning. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman --- cputlb.c | 3 ++- exec.c | 6 +++--- include/exec/memory-internal.h | 5 ++--- 3 files changed, 7 insertions(+),

[Qemu-devel] [PATCH 29/49] memory: split dirty bitmap into three

After all the previous patches, spliting the bitmap gets direct. Note: For some reason, I have to move DIRTY_MEMORY_* definitions to the beginning of memory.h to make compilation work. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman --- exec.c

[Qemu-devel] [PATCH 27/49] memory: cpu_physical_memory_clear_dirty_flag() result is never used

Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman --- include/exec/memory-internal.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h index d09d6d8..666490c 100644 --- a/include

[Qemu-devel] [PATCH 31/49] memory: unfold cpu_physical_memory_set_dirty() in its only user

Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman --- include/exec/memory-internal.h | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h index 2f6610a..9d34434 100644 --- a

[Qemu-devel] [PATCH 25/49] memory: make sure that client is always inside range

Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman --- include/exec/memory-internal.h | 4 1 file changed, 4 insertions(+) diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h index b58010f..d09d6d8 100644 --- a/include/exec/memory-int

[Qemu-devel] [PATCH 26/49] memory: only resize dirty bitmap when memory size increases

Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman --- exec.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/exec.c b/exec.c index 82aca4a..db369dc 100644 --- a/exec.c +++ b/exec.c @@ -1211,6 +1211,9 @@ ram_addr_t qemu_ram_alloc_fr

[Qemu-devel] [PATCH 22/49] memory: cpu_physical_memory_set_dirty_range() always dirty all flags

So remove the flag argument and do it directly. After this change, there is nothing else using cpu_physical_memory_set_dirty_flags() so remove it. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman --- exec.c | 2 +- include/exec/memory-i

[Qemu-devel] [PATCH 23/49] memory: cpu_physical_memory_mask_dirty_range() always clears a single flag

Document it Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman --- cputlb.c | 4 ++-- exec.c | 19 ++- include/exec/memory-internal.h | 40 ++-- include/exec/memory.

[Qemu-devel] [PATCH 21/49] memory: set single dirty flags when possible

Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman --- exec.c | 7 --- include/exec/memory-internal.h | 4 +++- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/exec.c b/exec.c index a8c79e5..ffda8be 100644 --- a/exec.c +++

[Qemu-devel] [PATCH 24/49] memory: use bit 2 for migration

For historical reasons it was bit 3. Once there, create a constant to know the number of clients. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman --- include/exec/memory.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/exec/memor

[Qemu-devel] [PATCH 20/49] memory: all users of cpu_physical_memory_get_dirty used only one flag

So cpu_physical_memory_get_dirty_flags is not needed anymore Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman --- include/exec/memory-internal.h | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/include/exec/memory-internal.h b/include

[Qemu-devel] [PATCH 28/49] bitmap: Add bitmap_zero_extend operation

Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman --- include/qemu/bitmap.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/qemu/bitmap.h b/include/qemu/bitmap.h index afdd257..1babd5d 100644 --- a/include/qemu/bitmap.h +++ b/include/qemu/bitm

[Qemu-devel] [PATCH 13/49] bitmap: use long as index

Move index and size fields from int to long. We need that for migration. long is 64 bits on sane architectures, and 32bits should be enough on all the 32bits architectures. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman --- include/qemu/bitmap.h | 77 +++

[Qemu-devel] [PATCH 17/49] memory: create function to set a single dirty bit

Signed-off-by: Juan Quintela Reviewed-by: Orit Wasserman Reviewed-by: Eric Blake --- cputlb.c | 2 +- include/exec/memory-internal.h | 6 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/cputlb.c b/cputlb.c index 9270055..c545e4c 100644 --- a/cputlb.c +

[Qemu-devel] [PATCH 14/49] memory: cpu_physical_memory_set_dirty_flags() result is never used

So return void. Signed-off-by: Juan Quintela Reviewed-by: Orit Wasserman Reviewed-by: Eric Blake --- include/exec/memory-internal.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h index d0e0633..c71a5e6 100

[Qemu-devel] [PATCH 09/49] vmstate: Move VMState code to vmstate.c

From: Eduardo Habkost This will allow unit tests to be written for VMState code without pulling dependencies from the savevm code. Signed-off-by: Eduardo Habkost Reviewed-by: Orit Wasserman Signed-off-by: Juan Quintela --- Makefile.objs | 1 + savevm.c | 645 --

[Qemu-devel] [PATCH 10/49] qemu-file: Move QEMUFile code to qemu-file.c

From: Eduardo Habkost Signed-off-by: Eduardo Habkost Reviewed-by: Orit Wasserman Signed-off-by: Juan Quintela --- Makefile.objs | 1 + qemu-file.c | 826 ++ savevm.c | 820

[Qemu-devel] [PATCH 19/49] memory: make cpu_physical_memory_is_dirty return bool

Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman --- exec.c | 7 ++- include/exec/memory-internal.h | 8 ++-- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/exec.c b/exec.c index ea78d82..a8c79e5 100644 --- a/exec.c

[Qemu-devel] [PATCH 15/49] memory: cpu_physical_memory_set_dirty_range() return void

Signed-off-by: Juan Quintela Reviewed-by: Orit Wasserman Reviewed-by: Eric Blake --- memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/memory.c b/memory.c index 7764314..e497f99 100644 --- a/memory.c +++ b/memory.c @@ -1182,7 +1182,7 @@ void memory_region_set_dirty(Me

[Qemu-devel] [PATCH 12/49] tests: Some unit tests for vmstate.c

From: Eduardo Habkost * Basic load/save tests * Tests for loading older versions * Tests for .field_exists() handling Signed-off-by: Eduardo Habkost Signed-off-by: Juan Quintela --- tests/.gitignore | 1 + tests/Makefile | 4 + tests/test-vmstate.c | 357 +

  1   2   3   >