On Mon, 01/13 22:01, Peter Maydell wrote: > On 13 January 2014 16:59, Paolo Bonzini <pbonz...@redhat.com> wrote: > > This is based on Fam's patches from October. Very few changes > > apart from rebasing: > > > > * I split his patch 8 in two parts. There is benefit in > > using per-object cflags and libs even before the module-loading > > machinery gets in. > > > > * I added a new patch "darwin: do not use -mdynamic-no-pic". > > CCing Alex Graf for it. > > > > * applied the small change I had requested a small change in patch 2 > > > > I'm not sending a pull request yet because of these two changes, > > but I'll be sending one in a few days. > > This doesn't build on MacOSX if you try to enable modules with > --enable-modules: >
module-common.c is missing in patch 6/9, so it failed. Fam