Re: [Qemu-devel] [PATCH v6 00/11] Make 'dump-guest-memory' dump in kdump-compressed format

2014-01-06 Thread Qiao Nuohan
On 01/07/2014 03:27 PM, Laszlo Ersek wrote: I haven't finished reviewing it yet, but thus far (up to& including patch 05) I'm OK with it. I see, thanks for your work. -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH v6 00/11] Make 'dump-guest-memory' dump in kdump-compressed format

2014-01-06 Thread Laszlo Ersek
On 01/07/14 07:32, Qiao Nuohan wrote: > Hello Eric, Luiz and Laszlo, > > What do you think about my series? And I have add the light-weight > introspection in the last patch, do you have some comments on it? I haven't finished reviewing it yet, but thus far (up to & including patch 05) I'm OK wit

Re: [Qemu-devel] [PATCH V5] char: restore read callback on a reattached (hotplug) chardev

2014-01-06 Thread Amit Shah
On (Wed) 18 Dec 2013 [16:15:19], Gal Hammer wrote: > Fix a bug that was introduced in commit 386a5a1e. A removal of a device > set the chr handlers to NULL. However when the device is plugged back, > its read callback is not restored so data can't be transferred from the > host to the guest (e.g. v

Re: [Qemu-devel] [PATCH v6 05/11] dump: add support for lzo/snappy

2014-01-06 Thread Laszlo Ersek
On 01/07/14 07:25, Qiao Nuohan wrote: > On 01/07/2014 03:25 AM, Laszlo Ersek wrote: >> You could have displayed the lzo / snappy settings along with the other >> settings in the "big echo block". But it's not too important; if you >> want you can add it later. > > You mean the following part? Than

Re: [Qemu-devel] [PATCH v6 00/11] Make 'dump-guest-memory' dump in kdump-compressed format

2014-01-06 Thread Qiao Nuohan
Hello Eric, Luiz and Laszlo, What do you think about my series? And I have add the light-weight introspection in the last patch, do you have some comments on it? On 01/05/2014 03:27 PM, Qiao Nuohan wrote: Hi, all The last version is here: http://lists.nongnu.org/archive/html/qemu-devel/2013-

Re: [Qemu-devel] [PATCH v6 05/11] dump: add support for lzo/snappy

2014-01-06 Thread Qiao Nuohan
On 01/07/2014 03:25 AM, Laszlo Ersek wrote: You could have displayed the lzo / snappy settings along with the other settings in the "big echo block". But it's not too important; if you want you can add it later. You mean the following part? Thanks for pointing it out. echo "Standard options:"

Re: [Qemu-devel] [PATCH v6 04/11] dump: Add API to write elf notes to buffer

2014-01-06 Thread Qiao Nuohan
On 01/07/2014 02:46 AM, Laszlo Ersek wrote: static int dump_cleanup(DumpState *s) > @@ -754,6 +757,22 @@ static int write_buffer(int fd, bool flag_flatten, off_t offset, void *buf, >return 0; >} > > +static int buf_write_note(void *buf, size_t size, void *opaque) > +{ "const vo

Re: [Qemu-devel] [PATCH v6 03/11] dump: Add API to write vmcore

2014-01-06 Thread Qiao Nuohan
On 01/07/2014 02:12 AM, Laszlo Ersek wrote: @@ -726,6 +726,34 @@ static int write_end_flat_header(int fd) >return 0; >} > > +static int write_buffer(int fd, bool flag_flatten, off_t offset, void *buf, > +size_t size) > +{ You might have wanted to const-qual

Re: [Qemu-devel] [PATCH v6 01/11] dump: Add argument to write_elfxx_notes

2014-01-06 Thread Qiao Nuohan
On 01/07/2014 01:03 AM, Laszlo Ersek wrote: I assume the direct calls to fd_write_vmcore() (which we're not replacing here) will be substituted / abstracted later on in the series. Yes, patch 6 will reuse write_elf32_notes/wirte_elf64_notes, but write notes into buffer instead of vmcore directl

Re: [Qemu-devel] [RFC PATCH 1/3] target-i386: Add 486sx, old486, and old486sx CPU models

2014-01-06 Thread H. Peter Anvin
On 03/25/2013 01:56 PM, Eduardo Habkost wrote: > >> >> It needs to be possible to fix bugs > > It is possible to fix them today: just write a compat function or add a > global variable that is handled by cpu_x86_init(), and call it from the > pc-1.3 machine-type init function. See disable_kvm

[Qemu-devel] [PATCH] Fix typo of tiemr in timer.h

2014-01-06 Thread Namhyung Kim
Signed-off-by: Namhyung Kim --- include/qemu/timer.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/qemu/timer.h b/include/qemu/timer.h index 5afcffc..7f9a074 100644 --- a/include/qemu/timer.h +++ b/include/qemu/timer.h @@ -405,7 +405,7 @@ int64_t timerlistgroup

[Qemu-devel] [PATCH] qom: Introduce object_property_remove()

2014-01-06 Thread Namhyung Kim
As the object_property_del(), object_property_del_child() and object_property_del_all() do similar job, factor out the common code to a new object_property_remove(). It'll also remove unnecessary call to object_property_find() in case of object_property_del_child() so that we can get rid of the un

[Qemu-devel] [RFC PATCH] elf loader: exit if incompatible architecture is detected

2014-01-06 Thread Alexey Kardashevskiy
If we know for sure that the image in "-kernel" is an ELF and we know its architecture and it is not supported by the current QEMU, there is no point to continue trying booting this image so let's exit once we deteced this fact. Signed-off-by: Alexey Kardashevskiy --- One of our users tried an

Re: [Qemu-devel] [RFC PATCH V2 3/5] qapi script: add event support by qapi-event.py

2014-01-06 Thread Wenchao Xia
+ + +# Following are the functions that generate event behavior control functions. +# Those functions are put here in the qapi-event.c, since it need to include +# qapi-event.h for the event enum type declaration, put them in other file +# requiring other file include qapi-event.h, causing a cross

Re: [Qemu-devel] [RFC PATCH V2 3/5] qapi script: add event support by qapi-event.py

2014-01-06 Thread Wenchao Xia
diff --git a/scripts/qapi-event.py b/scripts/qapi-event.py new file mode 100644 index 000..7526366 --- /dev/null +++ b/scripts/qapi-event.py @@ -0,0 +1,432 @@ +# +# QAPI event generator +# +# Copyright IBM, Corp. 2014 +# +# Authors: +# Wenchao Xia +# +# This work is licensed under the terms

Re: [Qemu-devel] [RFC PATCH V2 2/5] qapi: add event helper functions

2014-01-06 Thread Wenchao Xia
于 2014/1/7 6:23, Luiz Capitulino 写道: On Fri, 3 Jan 2014 07:10:31 +0800 Wenchao Xia wrote: This file hold some functions that do not need to be generated. Signed-off-by: Wenchao Xia --- include/qapi/qmp-event.h | 22 ++ qapi/Makefile.objs |1 + qapi/qmp-event.

Re: [Qemu-devel] [PATCHv3 3/6] ui/vnc: optimize dirty bitmap tracking

2014-01-06 Thread Wenchao Xia
于 2014/1/6 21:31, Peter Lieven 写道: > On 06.01.2014 11:08, Wenchao Xia wrote: >> 于 2014/1/6 2:02, Peter Lieven 写道: >>> vnc_update_client currently scans the dirty bitmap of each client >>> bitwise which is a very costly operation if only few bits are dirty. >>> vnc_refresh_server_surface does almost

Re: [Qemu-devel] [RFC PATCH V2 3/5] qapi script: add event support by qapi-event.py

2014-01-06 Thread Luiz Capitulino
On Fri, 3 Jan 2014 07:10:32 +0800 Wenchao Xia wrote: > qapi-event.py will parse the schema and generate qapi-event.c, then > the API in qapi-event.c can be used to handle event in qemu code. > All API have prefix "qapi_event", all types have prefix "QAPIEvent". > Examples can be found in followi

Re: [Qemu-devel] [RFC PATCH V2 0/5] add direct support of event in qapi schema

2014-01-06 Thread Luiz Capitulino
On Fri, 3 Jan 2014 07:10:29 +0800 Wenchao Xia wrote: > This series add support for tag/keyword 'event' in qapi-schema. > A new file was created to store some helper functions in patch 2, patch 4 is > the test case, patch 5 is a convert example. > > The implemention is done by generate API and a

Re: [Qemu-devel] [RFC PATCH V2 3/5] qapi script: add event support by qapi-event.py

2014-01-06 Thread Luiz Capitulino
[Pressed enter too soon, forgot two things] On Mon, 6 Jan 2014 18:10:04 -0500 Luiz Capitulino wrote: > On Fri, 3 Jan 2014 07:10:32 +0800 > Wenchao Xia wrote: > > > qapi-event.py will parse the schema and generate qapi-event.c, then > > the API in qapi-event.c can be used to handle event in q

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2014-01-06 Thread Alexey Kardashevskiy
On 01/06/2014 10:12 PM, Greg Kurz wrote: > On Fri, 03 Jan 2014 09:08:21 +1100 > Alexey Kardashevskiy wrote: >> >> Please read the rest of this thread. It does not visibly break things but >> with this patch QEMU starts calling unassigned_mem_accepts() (normally >> silent) which is not a good sign.

[Qemu-devel] [PULL 09/14] qdev: Delete dead code

2014-01-06 Thread Luiz Capitulino
From: Peter Crosthwaite This is unreachable code, as it's already asserted that no errors have occurred. Delete. Signed-off-by: Peter Crosthwaite Reviewed-by: Markus Armbruster Signed-off-by: Luiz Capitulino --- hw/core/qdev.c | 5 - 1 file changed, 5 deletions(-) diff --git a/hw/core/q

[Qemu-devel] [PULL 12/14] qemu-option: Remove qemu_opts_create_nofail

2014-01-06 Thread Luiz Capitulino
From: Peter Crosthwaite This is a boiler-plate _nofail variant of qemu_opts_create. Remove and use error_abort in call sites. null/0 arguments needs to be added for the id and fail_if_exists fields in affected callsites due to argument inconsistency between the normal and no_fail variants. Sign

Re: [Qemu-devel] [RFC PATCH V2 2/5] qapi: add event helper functions

2014-01-06 Thread Luiz Capitulino
On Fri, 3 Jan 2014 07:10:31 +0800 Wenchao Xia wrote: > This file hold some functions that do not need to be generated. > > Signed-off-by: Wenchao Xia > --- > include/qapi/qmp-event.h | 22 ++ > qapi/Makefile.objs |1 + > qapi/qmp-event.c | 56 > +

[Qemu-devel] [PULL 04/14] qom: fix leak for objects created with -object

2014-01-06 Thread Luiz Capitulino
From: Paolo Bonzini The object must be unref-ed when its variable goes out of scope. Signed-off-by: Paolo Bonzini Reviewed-by: Igor Mammedov Tested-by: Igor Mammedov Signed-off-by: Luiz Capitulino --- vl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/vl.c b/vl.c ind

[Qemu-devel] [PULL 02/14] qemu-monitor: HMP cpu-add wrapper

2014-01-06 Thread Luiz Capitulino
From: "Jason J. Herne" Add HMP cpu-add wrapper to allow cpu hot plugging via monitor. Signed-off-by: Jason J. Herne Reviewed-by: Igor Mammedov Signed-off-by: Luiz Capitulino --- hmp-commands.hx | 13 + hmp.c | 10 ++ hmp.h | 1 + 3 files changed, 24 i

[Qemu-devel] [PULL 01/14] vl: add missing transition debug->finish_migrate

2014-01-06 Thread Luiz Capitulino
From: Paolo Bonzini This fixes an abort if you invoke the "migrate" command while the guest is being debugged. Cc: qemu-sta...@nongnu.org Cc: lcapitul...@redhat.com Signed-off-by: Paolo Bonzini Signed-off-by: Luiz Capitulino --- vl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/vl.c b/

Re: [Qemu-devel] [PULL 00/14] QMP queue

2014-01-06 Thread Peter Maydell
On 6 January 2014 22:03, Luiz Capitulino wrote: > Peter Crosthwaite (6): > error: Add error_abort > qdev: Delete dead code > hw: Remove assert_no_error usages > target-i386: Remove assert_no_error usage > qemu-option: Remove qemu_opts_create_nofail > qerror: Rem

[Qemu-devel] [PULL 05/14] qom: catch errors in object_property_add_child

2014-01-06 Thread Luiz Capitulino
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Reviewed-by: Igor Mammedov Tested-by: Igor Mammedov Signed-off-by: Luiz Capitulino --- qom/object.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/qom/object.c b/qom/object.c index fc19cf6..4dee02b 100644 --- a

[Qemu-devel] [PULL 03/14] rng: initialize file descriptor to -1

2014-01-06 Thread Luiz Capitulino
From: Paolo Bonzini The file descriptor is never initialized to -1, which makes rng-random close stdin if an object is created and immediately destroyed. If we change it to -1, we also need to protect qemu_set_fd_handler from receiving a bogus file descriptor. Signed-off-by: Paolo Bonzini Revi

Re: [Qemu-devel] [PATCHv2 04/18] qemu-iotests: fix test 013 to work with any protocol

2014-01-06 Thread Peter Lieven
> Am 06.01.2014 um 21:40 schrieb Jeff Cody : > >> On Mon, Jan 06, 2014 at 07:48:25AM +0100, Peter Lieven wrote: >>> On 06.01.2014 06:31, Fam Zheng wrote: On 2014年01月06日 01:21, Peter Lieven wrote: Signed-off-by: Peter Lieven --- tests/qemu-iotests/013 |9 - >>>

[Qemu-devel] [PULL 14/14] migration: qmp_migrate(): keep working after syntax error

2014-01-06 Thread Luiz Capitulino
If a user or QMP client enter a bad syntax for the migrate command in QMP/HMP, then the migrate command will never succeed from that point on. For example, if you enter: (qemu) migrate tcp;0: migrate: Parameter 'uri' expects a valid migration protocol Then the migrate command will always fai

[Qemu-devel] [PULL 00/14] QMP queue

2014-01-06 Thread Luiz Capitulino
The following changes since commit f976b09ea2493fd41c98aaf6512908db0bae: PPC: Fix compilation with TCG debug (2013-12-22 19:15:55 +0100) are available in the git repository at: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp for you to fetch changes up to c950114286ea358a93ce632db04219

Re: [Qemu-devel] [PATCHv2 02/18] qemu-iotests: enable support for NFS protocol

2014-01-06 Thread Peter Lieven
> Am 06.01.2014 um 21:14 schrieb Jeff Cody : > >> On Sun, Jan 05, 2014 at 06:21:52PM +0100, Peter Lieven wrote: >> Signed-off-by: Peter Lieven >> --- >> tests/qemu-iotests/common| 22 +++--- >> tests/qemu-iotests/common.rc |3 +++ >> 2 files changed, 22 insertions(+), 3

[Qemu-devel] [PULL 06/14] monitor: add object-del (QMP) and object_del (HMP) command

2014-01-06 Thread Luiz Capitulino
From: Paolo Bonzini These two commands invoke the "unparent" method of Object. Signed-off-by: Paolo Bonzini Reviewed-by: Igor Mammedov Tested-by: Igor Mammedov Signed-off-by: Luiz Capitulino --- hmp-commands.hx | 14 ++ hmp.c| 9 + hmp.h| 1 +

[Qemu-devel] [PULL 13/14] qerror: Remove assert_no_error()

2014-01-06 Thread Luiz Capitulino
From: Peter Crosthwaite This is no longer needed, and is obsoleted by error_abort. Remove. Signed-off-by: Peter Crosthwaite Reviewed-by: Markus Armbruster Signed-off-by: Luiz Capitulino --- include/qapi/qmp/qerror.h | 1 - qobject/qerror.c | 8 2 files changed, 9 deletions(

[Qemu-devel] [PULL 07/14] monitor: add object-add (QMP) and object_add (HMP) command

2014-01-06 Thread Luiz Capitulino
From: Paolo Bonzini Add two commands that are the monitor counterparts of -object. The commands have the same Visitor-based implementation, but use different kinds of visitors so that the HMP command has a DWIM string-based syntax, while the QMP variant accepts a stricter JSON-based properties d

[Qemu-devel] [PULL 11/14] target-i386: Remove assert_no_error usage

2014-01-06 Thread Luiz Capitulino
From: Peter Crosthwaite Replace an assert_no_error() usage with the error_abort system. Signed-off-by: Peter Crosthwaite Reviewed-by: Markus Armbruster Signed-off-by: Luiz Capitulino --- target-i386/cpu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target-i386/cpu.

[Qemu-devel] [PULL 10/14] hw: Remove assert_no_error usages

2014-01-06 Thread Luiz Capitulino
From: Peter Crosthwaite Replace assert_no_error() usages with the error_abort system. &error_abort is passed into API calls to signal to the Error sub-system that any errors are fatal. Removes need for caller assertions. Signed-off-by: Peter Crosthwaite Reviewed-by: Markus Armbruster Signed-of

[Qemu-devel] [PULL 08/14] error: Add error_abort

2014-01-06 Thread Luiz Capitulino
From: Peter Crosthwaite Add a special Error * that can be passed to error handling APIs to signal that any errors are fatal and should abort QEMU. There are two advantages to this: - allows for brevity when wishing to assert success of Error ** accepting APIs. No need for this pattern:

Re: [Qemu-devel] [Xen-devel] Project idea: make QEMU more flexible

2014-01-06 Thread Paolo Bonzini
Il 06/01/2014 16:04, Peter Maydell ha scritto: > On 6 January 2014 14:54, Stefano Stabellini > wrote: >> How would you avoid the compilation of all the >> unnecessary emulated devices? > > Didn't we have some patches for doing a Kconfig-style > "select the devices you need" build recently? It wa

Re: [Qemu-devel] [Xen-devel] Project idea: make QEMU more flexible

2014-01-06 Thread Paolo Bonzini
Il 06/01/2014 19:00, Andreas Färber ha scritto: > Am 06.01.2014 16:39, schrieb Anthony Liguori: >> We already have accel=xen. I'm echoing Peter's suggestion of having the >> ability to compile out accel=tcg. > > Didn't you and Paolo even have patches for that a while ago? Yes, but some code shuf

Re: [Qemu-devel] [PATCH v3] linux-user: Support the accept4 socketcall

2014-01-06 Thread Erik de Castro Lopo
André Hentschel wrote: > From: André Hentschel > Cc: Riku Voipio > Signed-off-by: André Hentschel Reviewed-by: Erik de Castro Lopo -- -- Erik de Castro Lopo http://www.mega-nerd.com/

Re: [Qemu-devel] [PATCHv2 04/18] qemu-iotests: fix test 013 to work with any protocol

2014-01-06 Thread Jeff Cody
On Mon, Jan 06, 2014 at 07:48:25AM +0100, Peter Lieven wrote: > On 06.01.2014 06:31, Fam Zheng wrote: > >On 2014年01月06日 01:21, Peter Lieven wrote: > >>Signed-off-by: Peter Lieven > >>--- > >> tests/qemu-iotests/013 |9 - > >> tests/qemu-iotests/013.out |2 +- > >> 2 files chan

Re: [Qemu-devel] [PATCH v3] linux-user: Support the accept4 socketcall

2014-01-06 Thread Peter Maydell
On 6 January 2014 19:18, André Hentschel wrote: > From: André Hentschel > Cc: Riku Voipio > Signed-off-by: André Hentschel Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCHv2 02/18] qemu-iotests: enable support for NFS protocol

2014-01-06 Thread Jeff Cody
On Sun, Jan 05, 2014 at 06:21:52PM +0100, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > tests/qemu-iotests/common| 22 +++--- > tests/qemu-iotests/common.rc |3 +++ > 2 files changed, 22 insertions(+), 3 deletions(-) > > diff --git a/tests/qemu-iotests/commo

Re: [Qemu-devel] [V3 PATCH 10/14] target-ppc: Fix and enable fri[mnpz]

2014-01-06 Thread Tom Musta
On 12/24/2013 10:02 AM, Richard Henderson wrote: > I'll also note that frin can't properly be implemented with > float_round_nearest_even because it doesn't round to even. Good catch. I should be able to use Peter's ties away rounding mode patches.

Re: [Qemu-devel] [PATCH qmp v4 0/6] Add error_abort and associated cleanups

2014-01-06 Thread Luiz Capitulino
On Mon, 06 Jan 2014 20:18:45 +0100 Andreas Färber wrote: > Am 06.01.2014 20:13, schrieb Luiz Capitulino: > > On Wed, 1 Jan 2014 18:46:24 -0800 > > Peter Crosthwaite wrote: > > > >> Following our discussion RE self asserting API calls, here is a spin of > >> my proposal. This series obsoletes t

Re: [Qemu-devel] [PULL 0/2] QMP queue

2014-01-06 Thread Luiz Capitulino
On Fri, 20 Dec 2013 11:38:54 -0500 Luiz Capitulino wrote: > I've dropped the two series which need to be respun. As the fix I have from > Paolo is pending for a long time, I figure it's better to send what I have > in the queue now. Please, don't pull this one. I'm working on a more complete pul

Re: [Qemu-devel] [PATCH v6 05/11] dump: add support for lzo/snappy

2014-01-06 Thread Laszlo Ersek
On 01/05/14 08:27, Qiao Nuohan wrote: > kdump-compressed format supports three compression format, zlib/lzo/snappy. > Currently, only zlib is available. This patch is used to support lzo/snappy. > '--enable-lzo/--enable-snappy' is needed to be specified with configure to > make > lzo/snappy availa

[Qemu-devel] [PATCH v3] linux-user: Support the accept4 socketcall

2014-01-06 Thread André Hentschel
From: André Hentschel Cc: Riku Voipio Signed-off-by: André Hentschel --- See https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/uapi/linux/net.h for the value. linux-user/syscall.c | 16 linux-user/syscall_defs.h | 1 + 2 files changed, 17 ins

Re: [Qemu-devel] [PATCH qmp v4 0/6] Add error_abort and associated cleanups

2014-01-06 Thread Andreas Färber
Am 06.01.2014 20:13, schrieb Luiz Capitulino: > On Wed, 1 Jan 2014 18:46:24 -0800 > Peter Crosthwaite wrote: > >> Following our discussion RE self asserting API calls, here is a spin of >> my proposal. This series obsoletes the need for _nofail variants for >> Error ** accepting APIs. Is also gr

Re: [Qemu-devel] [PATCH qmp v4 0/6] Add error_abort and associated cleanups

2014-01-06 Thread Luiz Capitulino
On Wed, 1 Jan 2014 18:46:24 -0800 Peter Crosthwaite wrote: > Following our discussion RE self asserting API calls, here is a spin of > my proposal. This series obsoletes the need for _nofail variants for > Error ** accepting APIs. Is also greatly reduces the verbosity of calls > sites that are c

Re: [Qemu-devel] [PATCH v3 0/5] Monitor commands for object-add/del

2014-01-06 Thread Luiz Capitulino
On Fri, 20 Dec 2013 23:21:05 +0100 Paolo Bonzini wrote: > These allow hotplugging (and hot-unplugging without leaking an object) > virtio-rng devices. They can also be used for memory hotplug. > > v1->v2: fix mistyped underscores in qapi-schema.json > > v2->v3: preserve bisectability by invert

Re: [Qemu-devel] [PATCH v2 24/24] target-arm: A64: Add support for FCVT between half, single and double

2014-01-06 Thread Richard Henderson
On 01/06/2014 05:11 AM, Peter Maydell wrote: > Add support for FCVT between half, single and double precision. > > Signed-off-by: Peter Maydell > --- > target-arm/helper.c| 20 + > target-arm/helper.h| 2 ++ > target-arm/translate-a64.c | 75 > ++

Re: [Qemu-devel] [PATCH v2 21/24] target-arm: A64: Add "Floating-point<->fixed-point" instructions

2014-01-06 Thread Richard Henderson
On 01/06/2014 05:11 AM, Peter Maydell wrote: > From: Alexander Graf > > This patch adds emulation for the instruction group labeled > "Floating-point <-> fixed-point conversions" in the ARM ARM. > > Namely this includes the instructions SCVTF, UCVTF, FCVTZS, FCVTZU > (scalar, fixed-point). > >

Re: [Qemu-devel] [PATCH v2 23/24] target-arm: A64: Add 1-source 32-to-32 and 64-to-64 FP instructions

2014-01-06 Thread Richard Henderson
On 01/06/2014 05:11 AM, Peter Maydell wrote: > +DEF_HELPER_FLAGS_2(rints_exact, TCG_CALL_NO_RWG_SE, f32, f32, ptr) > +DEF_HELPER_FLAGS_2(rintd_exact, TCG_CALL_NO_RWG_SE, f64, f64, ptr) > +DEF_HELPER_FLAGS_2(rints, TCG_CALL_NO_RWG_SE, f32, f32, ptr) > +DEF_HELPER_FLAGS_2(rintd, TCG_CALL_NO_RWG_SE, f

Re: [Qemu-devel] [PATCH v2 22/24] target-arm: A64: Add floating-point<->integer conversion instructions

2014-01-06 Thread Richard Henderson
On 01/06/2014 05:11 AM, Peter Maydell wrote: > From: Will Newton > > Add support for the AArch64 floating-point <-> integer conversion > instructions to disas_fpintconv. In the process we can rearrange > and simplify the detection of unallocated encodings a little. > We also correct a typo in the

Re: [Qemu-devel] [PATCH v6 04/11] dump: Add API to write elf notes to buffer

2014-01-06 Thread Laszlo Ersek
some tangential comments: On 01/05/14 08:27, Qiao Nuohan wrote: > the function can be used by write_elf32_notes/write_elf64_notes to write notes > to a buffer. If fd_write_vmcore is used, write_elf32_notes/write_elf64_notes > will write elf notes to vmcore directly. Instead, if buf_write_note is u

Re: [Qemu-devel] [PATCH v2 17/24] target-arm: Prepare VFP_CONV_FIX helpers for A64 uses

2014-01-06 Thread Richard Henderson
On 01/06/2014 05:11 AM, Peter Maydell wrote: > From: Will Newton > > Make the VFP_CONV_FIX helpers a little more flexible in > preparation for the A64 uses. This requires two changes: > * use the correct softfloat conversion function based on itype >rather than always the int32 one; this is

Re: [Qemu-devel] [PATCH v2 16/24] softfloat: Add support for ties-away rounding

2014-01-06 Thread Richard Henderson
On 01/06/2014 05:11 AM, Peter Maydell wrote: > IEEE754-2008 specifies a new rounding mode: > > "roundTiesToAway: the floating-point number nearest to the infinitely > precise result shall be delivered; if the two nearest floating-point > numbers bracketing an unrepresentable infinitely precise res

Re: [Qemu-devel] [PATCH v2 15/24] softfloat: Refactor code handling various rounding modes

2014-01-06 Thread Richard Henderson
On 01/06/2014 05:11 AM, Peter Maydell wrote: > Refactor the code in various functions which calculates rounding > increments given the current rounding mode, so that instead of a > set of nested if statements we have a simple switch statement. > This will give us a clean place to add the case for t

Re: [Qemu-devel] [PATCH v2 14/24] softfloat: Add float16 <=> float64 conversion functions

2014-01-06 Thread Richard Henderson
On 01/06/2014 05:11 AM, Peter Maydell wrote: > Add the conversion functions float16_to_float64() and > float64_to_float16(), which will be needed for the ARM > A64 instruction set. > > Signed-off-by: Peter Maydell > --- > fpu/softfloat.c | 75 > ++

Re: [Qemu-devel] [PATCH v2 13/24] softfloat: Factor out RoundAndPackFloat16 and NormalizeFloat16Subnormal

2014-01-06 Thread Richard Henderson
On 01/06/2014 05:11 AM, Peter Maydell wrote: > In preparation for adding conversions between float16 and float64, > factor out code currently done inline in the float16<=>float32 > conversion functions into functions RoundAndPackFloat16 and > NormalizeFloat16Subnormal along the lines of the existin

Re: [Qemu-devel] Project idea: make QEMU more flexible

2014-01-06 Thread Wei Liu
On Mon, Jan 06, 2014 at 07:12:07PM +0100, Andreas Färber wrote: > Am 06.01.2014 16:12, schrieb Wei Liu: > > On Mon, Jan 06, 2014 at 01:30:20PM +, Peter Maydell wrote: > >> On 6 January 2014 12:54, Wei Liu wrote: > >>> In fact I've already hacked a prototype during Christmas. What's I've > >>>

Re: [Qemu-devel] [PATCH v2 08/24] softfloat: Add float32_to_uint64()

2014-01-06 Thread Richard Henderson
On 01/06/2014 05:11 AM, Peter Maydell wrote: > +return (int64_t)LIT64(0x); Silly but harmless cast, considering the uint64_t return type. Otherwise, Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v2 06/24] softfloat: Only raise Invalid when conversions to int are out of range

2014-01-06 Thread Richard Henderson
On 01/06/2014 05:11 AM, Peter Maydell wrote: > We implement a number of float-to-integer conversions using conversion > to an integer type with a wider range and then a check against the > narrower range we are actually converting to. If we find the result to > be out of range we correctly raise th

[Qemu-devel] [RFC] PPC: KVM: add support for LPCR

2014-01-06 Thread Greg Kurz
The LPCR special purpose register was introduced with the PowerPC 970MP family. This patch initializes LPCR for the following families: - 970 MP - POWER5+ - POWER7 - POWER8 Signed-off-by: Greg Kurz --- Along with Alexey's fixes for the get/put one reg API, I could drop the target-ppc/kvm.c bits

Re: [Qemu-devel] [PATCH v2 05/24] softfloat: Fix float64_to_uint64

2014-01-06 Thread Richard Henderson
On 01/06/2014 05:11 AM, Peter Maydell wrote: > From: Tom Musta > > The comment preceding the float64_to_uint64 routine suggests that > the implementation is broken. And this is, indeed, the case. > > This patch properly implements the conversion of a 64-bit floating > point number to an unsigne

Re: [Qemu-devel] [PATCH v2 04/24] softfloat: Make the int-to-float functions take exact-width types

2014-01-06 Thread Richard Henderson
On 01/06/2014 05:11 AM, Peter Maydell wrote: > Currently the int-to-float functions take types which are specified > as "at least X bits wide", rather than "exactly X bits wide". This is > confusing and unhelpful since it means that the callers have to include > an explicit cast to [u]intXX_t to en

Re: [Qemu-devel] [PATCH v6 03/11] dump: Add API to write vmcore

2014-01-06 Thread Laszlo Ersek
On 01/05/14 08:27, Qiao Nuohan wrote: > Function is used to write vmcore. If flag_flatten is specified, flatten format > will be used. In flatten format, data is written block by block in vmcore. > struct MakedumpfileDataHeader is used to indicate the offset and size of a > data > block. > > stru

Re: [Qemu-devel] [PATCH v2 03/24] softfloat: Add 16 bit integer to float conversions

2014-01-06 Thread Richard Henderson
On 01/06/2014 05:11 AM, Peter Maydell wrote: > Add the float to 16 bit integer conversion routines. These can be > trivially implemented in terms of the int32_to_float* routines, but > providing them makes our API more symmetrical and can simplify callers. > > Signed-off-by: Peter Maydell > --- >

Re: [Qemu-devel] [PATCH v2 01/24] softfloat: Fix exception flag handling for float32_to_float16()

2014-01-06 Thread Richard Henderson
On 01/06/2014 05:10 AM, Peter Maydell wrote: > Our float32 to float16 conversion routine was generating the correct > numerical answers, but not always setting the right set of exception > flags. Fix this, mostly by rearranging the code to more closely > resemble RoundAndPackFloat*, and in particul

Re: [Qemu-devel] Project idea: make QEMU more flexible

2014-01-06 Thread Andreas Färber
Am 06.01.2014 16:12, schrieb Wei Liu: > On Mon, Jan 06, 2014 at 01:30:20PM +, Peter Maydell wrote: >> On 6 January 2014 12:54, Wei Liu wrote: >>> In fact I've already hacked a prototype during Christmas. What's I've >>> done so far: >>> >>> 1. create target-null which only has some stubs to CP

Re: [Qemu-devel] Project idea: make QEMU more flexible

2014-01-06 Thread Peter Maydell
On 6 January 2014 17:34, Stefano Stabellini wrote: > On Mon, 6 Jan 2014, Peter Maydell wrote: >> However I don't think we can have a qemu-system-null >> (regardless of use cases) until/unless we get rid of >> all the things which are compile-time decided by >> the system config. In an ideal world

Re: [Qemu-devel] [Xen-devel] Project idea: make QEMU more flexible

2014-01-06 Thread Stefano Stabellini
On Mon, 6 Jan 2014, Anthony Liguori wrote: > On Mon, Jan 6, 2014 at 7:57 AM, Stefano Stabellini > wrote: > > On Mon, 6 Jan 2014, Anthony Liguori wrote: > >> On Jan 6, 2014 6:55 AM, "Stefano Stabellini" > >> wrote: > >> > > >> > On Mon, 6 Jan 2014, Anthony Liguori wrote: > >> > > On Jan 6, 2014 6

Re: [Qemu-devel] [Xen-devel] Project idea: make QEMU more flexible

2014-01-06 Thread Andreas Färber
Am 06.01.2014 16:39, schrieb Anthony Liguori: > We already have accel=xen. I'm echoing Peter's suggestion of having the > ability to compile out accel=tcg. Didn't you and Paolo even have patches for that a while ago? Cheers, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, G

Re: [Qemu-devel] [Xen-devel] Project idea: make QEMU more flexible

2014-01-06 Thread Anthony Liguori
On Mon, Jan 6, 2014 at 7:57 AM, Stefano Stabellini wrote: > On Mon, 6 Jan 2014, Anthony Liguori wrote: >> On Jan 6, 2014 6:55 AM, "Stefano Stabellini" >> wrote: >> > >> > On Mon, 6 Jan 2014, Anthony Liguori wrote: >> > > On Jan 6, 2014 6:23 AM, "Peter Maydell" wrote: >> > > > >> > > > On 6 Janu

Re: [Qemu-devel] Project idea: make QEMU more flexible

2014-01-06 Thread Stefano Stabellini
On Mon, 6 Jan 2014, Peter Maydell wrote: > On 6 January 2014 15:11, Wei Liu wrote: > > On Mon, Jan 06, 2014 at 11:23:24PM +1000, Peter Crosthwaite wrote: > > [...] > >> > > >> > Finally I got a qemu-system-null. And the effect is immediately visible > >> > >> qemu-system-null has been on my wish-l

Re: [Qemu-devel] [PATCHv3 3/6] ui/vnc: optimize dirty bitmap tracking

2014-01-06 Thread Peter Lieven
On 06.01.2014 11:08, Wenchao Xia wrote: > 于 2014/1/6 2:02, Peter Lieven 写道: >> vnc_update_client currently scans the dirty bitmap of each client >> bitwise which is a very costly operation if only few bits are dirty. >> vnc_refresh_server_surface does almost the same. >> this patch optimizes both b

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] target-ppc: fix Authority Mask Register init value

2014-01-06 Thread Greg Kurz
On Mon, 6 Jan 2014 16:36:39 +1100 Alexey Kardashevskiy wrote: > The existing default value (-1) of the AMR register forbids data access > to all 32 classes. Since the guest linux does not change this register, > we end up with the guest hanging right after switching from the real to > protected m

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] PPC: KVM: fix "set one register"

2014-01-06 Thread Greg Kurz
On Mon, 6 Jan 2014 16:36:40 +1100 Alexey Kardashevskiy wrote: > Due to missing @one_reg_id assignment in _spr_register(), > the kvm_get_one_reg/kvm_set_one_reg API has never really been working. > > This enabled the API and removes use of the API for LPCR as > kvm_arch_get_registers/kvm_arch_pu

Re: [Qemu-devel] [PATCH v2] linux-user: Support the accept4 socketcall

2014-01-06 Thread Peter Maydell
On 6 January 2014 17:07, Laurent Vivier wrote: > >> Le 6 janvier 2014 à 17:15, André Hentschel a écrit : >> >> >> From: André Hentschel >> Cc: Riku Voipio >> Signed-off-by: André Hentschel >> --- >> See >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/uapi/linux/

Re: [Qemu-devel] [PATCH v6 02/11] dump: Add API to write header of flatten format

2014-01-06 Thread Laszlo Ersek
On 01/05/14 08:27, Qiao Nuohan wrote: > flatten format may be used when writing kdump-compressed format. The format is > also used by makedumpfile, you can refer to the following URL to get more > detailed information about flatten format of kdump-compressed format: > http://sourceforge.net/project

Re: [Qemu-devel] [PATCH v2] linux-user: Support the accept4 socketcall

2014-01-06 Thread Laurent Vivier
> Le 6 janvier 2014 à 17:15, André Hentschel a écrit : > > > From: André Hentschel > Cc: Riku Voipio > Signed-off-by: André Hentschel > --- > See > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/uapi/linux/net.h > for the value. > > linux-user/syscall.c | 16 +

Re: [Qemu-devel] [PATCH 07/13] mxs/imx23: Implements the pin mux, GPIOs

2014-01-06 Thread Peter Maydell
On 11 December 2013 13:56, Michel Pollet wrote: > Implements the pinctrl and GPIO block for the imx23 > It handles GPIO output, and GPIO input from qemu translated > into pin values and interrupts, if appropriate. > > Signed-off-by: Michel Pollet > --- > hw/arm/Makefile.objs | 2 +- > hw/arm

Re: [Qemu-devel] [PATCH v6 01/11] dump: Add argument to write_elfxx_notes

2014-01-06 Thread Laszlo Ersek
On 01/05/14 08:27, Qiao Nuohan wrote: > write_elf32_notes/wirte_elf64_notes use fd_write_vmcore to write elf notes to > vmcore. Adding parameter "WriteCoreDumpFunction f" makes it available to > choose > the method of writing elf notes > > Signed-off-by: Qiao Nuohan > --- > dump.c | 16 ++

Re: [Qemu-devel] Project idea: make QEMU more flexible

2014-01-06 Thread Peter Maydell
On 6 January 2014 15:11, Wei Liu wrote: > On Mon, Jan 06, 2014 at 11:23:24PM +1000, Peter Crosthwaite wrote: > [...] >> > >> > Finally I got a qemu-system-null. And the effect is immediately visible >> >> qemu-system-null has been on my wish-list in the past, although my >> reasons were slightly d

[Qemu-devel] [PATCH v2] linux-user: Support the accept4 socketcall

2014-01-06 Thread André Hentschel
From: André Hentschel Cc: Riku Voipio Signed-off-by: André Hentschel --- See https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/uapi/linux/net.h for the value. linux-user/syscall.c | 16 linux-user/syscall_defs.h | 1 + 2 files changed, 17 ins

Re: [Qemu-devel] [PATCH resend] linux-user: Support the accept4 socketcall

2014-01-06 Thread Peter Maydell
On 6 January 2014 15:38, André Hentschel wrote: > This warning seems wrong: > - the if statement has no braces and only one arm > - the if statement looks like the others around it, i just try to keep the > same style The warning is saying that you need braces. "all arms" for an if() with only

Re: [Qemu-devel] [Xen-devel] Project idea: make QEMU more flexible

2014-01-06 Thread Stefano Stabellini
On Mon, 6 Jan 2014, Anthony Liguori wrote: > On Jan 6, 2014 6:55 AM, "Stefano Stabellini" > wrote: > > > > On Mon, 6 Jan 2014, Anthony Liguori wrote: > > > On Jan 6, 2014 6:23 AM, "Peter Maydell" wrote: > > > > > > > > On 6 January 2014 14:17, Stefano Stabellini > > > > wrote: > > > > > It does

Re: [Qemu-devel] [PATCH] discard rbd error output when not relevant in qemu-iotests

2014-01-06 Thread Loic Dachary
On 06/01/2014 03:23, Stefan Hajnoczi wrote: > On Mon, Dec 30, 2013 at 01:33:34AM +0100, Loic Dachary wrote: >> diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc >> index 28ba0d9..af66bbd 100644 >> --- a/tests/qemu-iotests/common.rc >> +++ b/tests/qemu-iotests/common.rc >> @

Re: [Qemu-devel] [PATCH 06/13] mxs/imx23: Add digctl driver

2014-01-06 Thread Peter Maydell
On 11 December 2013 13:56, Michel Pollet wrote: > This implements just enough of the digctl IO block to allow > linux to believe it's running on (currently only) an imx23. > > Signed-off-by: Michel Pollet > --- > hw/arm/Makefile.objs | 1 + > hw/arm/imx23_digctl.c | 110 > +++

Re: [Qemu-devel] [PATCH 04/13] mxs/imx23: Add DMA driver

2014-01-06 Thread Peter Maydell
On 11 December 2013 13:56, Michel Pollet wrote: > This driver works sufficiently well that linux can use it to access > the SD card using the SD->DMA->SSI->SD. It hasn't been tested for > much else. > > Signed-off-by: Michel Pollet > --- > hw/dma/Makefile.objs | 1 + > hw/dma/mxs_dma.c | 3

Re: [Qemu-devel] [PATCH 05/13] mxs/imx23: Add the interrupt collector

2014-01-06 Thread Peter Maydell
On 11 December 2013 13:56, Michel Pollet wrote: > Implements the interrupt collector IO block > > Signed-off-by: Michel Pollet > --- > hw/intc/Makefile.objs | 1 + > hw/intc/mxs_icoll.c | 200 > ++ > 2 files changed, 201 insertions(+) > creat

[Qemu-devel] KVM call agenda for 2014-01-07

2014-01-06 Thread Juan Quintela
Hi First of all, poll told to move the call earlier. 9:00 EST (15:00 CET or 6:00 Pacific) Please, send any topic that you are interested in covering. Happy new year Thanks, Juan.

Re: [Qemu-devel] [Xen-devel] Project idea: make QEMU more flexible

2014-01-06 Thread Anthony Liguori
On Jan 6, 2014 6:55 AM, "Stefano Stabellini" < stefano.stabell...@eu.citrix.com> wrote: > > On Mon, 6 Jan 2014, Anthony Liguori wrote: > > On Jan 6, 2014 6:23 AM, "Peter Maydell" wrote: > > > > > > On 6 January 2014 14:17, Stefano Stabellini > > > wrote: > > > > It doesn't do any emulation so it

Re: [Qemu-devel] [PATCH 03/13] mxs/imx23: Add uart driver

2014-01-06 Thread Peter Maydell
On 11 December 2013 13:56, Michel Pollet wrote: > Prototype driver for the mxs/imx23 uart IO block. This has no > real 'uart' functional code, apart from letting itself be > initialized by linux without generating a timeout error. > > Signed-off-by: Michel Pollet Hi; there are some minor code st

Re: [Qemu-devel] [RFC PATCH v4 0/8] Support arm-gic-kvm save/restore

2014-01-06 Thread Christoffer Dall
On Mon, Jan 06, 2014 at 11:09:28AM +, Peter Maydell wrote: > On 21 December 2013 06:09, Christoffer Dall > wrote: > > Implement support to save/restore the ARM KVM VGIC state from the > > kernel. The basic appraoch is to transfer state from the in-kernel VGIC > > to the emulated arm-gic stat

Re: [Qemu-devel] [PATCH resend] linux-user: Support the accept4 socketcall

2014-01-06 Thread André Hentschel
> This looks ok, except that scripts/checkpatch.pl says: > > WARNING: braces {} are necessary for all arms of this statement > #36: FILE: linux-user/syscall.c:2254: > +if (get_user_ual(sockfd, vptr) > [...] > > total: 0 errors, 1 warnings, 30 lines checked > > Fix

  1   2   3   >