On Fri, 3 Jan 2014 07:10:29 +0800 Wenchao Xia <xiaw...@linux.vnet.ibm.com> wrote:
> This series add support for tag/keyword 'event' in qapi-schema. > A new file was created to store some helper functions in patch 2, patch 4 is > the test case, patch 5 is a convert example. > > The implemention is done by generate API and a batch of parameters for each > event define, it doesn't generate a struture and visit function in the > background for every event, so it doesn't support nested structure in the > define to avoid trouble. A callback layer is added to control the behavior. > More detail can be found in patch 3's message and incode comments. The general approach seems good to me. Would be nice to get another reviewer though, maybe Eric and/or Michael.