On 6 January 2014 15:38, André Hentschel <n...@dawncrow.de> wrote: > This warning seems wrong: > - the if statement has no braces and only one arm > - the if statement looks like the others around it, i just try to keep the > same style
The warning is saying that you need braces. "all arms" for an if() with only one arm means "on that one arm". See the CODING_STYLE file's section on 'block structure'. QEMU includes a fair amount of legacy code which doesn't follow our coding standards. Our general policy on this is that new code follows the standards, and when a patch touches old code it updates it (at least sufficiently to get checkpatch to be happy). We don't generally do large-scale "update whole file to new standard" patches as this breaks git blame and can cause unnecessary patch conflicts. thanks -- PMM
