Re: [Qemu-devel] [PATCH v4 1/6] qemu-iotests: Add "-c " option

2013-12-02 Thread Fam Zheng
On 2013年12月03日 14:31, Wenchao Xia wrote: xpand=true @@ -147,6 +155,7 @@ check options -o options -o options to pass to qemu-img create/convert -Toutput timestamps -r randomize test order +-c

[Qemu-devel] [PATCH arm-devs v3 9/9] arm/highbank.c: Fix MPCore periphbase name

2013-12-02 Thread Peter Crosthwaite
GIC_BASE_ADDR is not the base address of the GIC. Its clear from the code that this is the base address of the MPCore. Rename to MPCORE_PERIPHBASE accordingly. Signed-off-by: Peter Crosthwaite --- changed since v2: Fixed broken comment (PMM review) hw/arm/highbank.c | 15 --- 1 file

[Qemu-devel] [PATCH arm-devs v3 8/9] arm/xilinx_zynq: Implement CBAR initialisation

2013-12-02 Thread Peter Crosthwaite
Fix the CBAR initialisation by using the newly defined static property. Zynq will now correctly init the CBAR to the SCU base address. Needed to boot Linux on the xilinx_zynq machine model. Signed-off-by: Peter Crosthwaite --- changed since v1: use error report rather than fprintf(stderr rename

[Qemu-devel] [PATCH arm-devs v3 7/9] arm/xilinx_zynq: Use object_new() rather than cpu_arm_init()

2013-12-02 Thread Peter Crosthwaite
To allow the machine model to set device properties before CPU realization. Signed-off-by: Peter Crosthwaite --- changed since v1: use error report rather than fprintf(stderr hw/arm/xilinx_zynq.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/hw/arm/xilinx_zynq

[Qemu-devel] [PATCH arm-devs v3 6/9] arm/highbank: Fix CBAR initialisation

2013-12-02 Thread Peter Crosthwaite
Fix the CBAR initialisation by using the newly defined static property. CBAR is now set before realization, so the intended value is now actually used. So I have kind of tested this. I booted an ARM kernel on Highbank with the stock Highbank DTB. It doesn't boot (and I will be doing something wron

[Qemu-devel] [PATCH arm-devs v3 5/9] arm/highbank: Use object_new() rather than cpu_arm_init()

2013-12-02 Thread Peter Crosthwaite
To allow the machine model to set device properties before CPU realization. Signed-off-by: Peter Crosthwaite --- changed since v1: use error_report rather than fprintf(stderr hw/arm/highbank.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/hw/arm/highbank.c b/h

[Qemu-devel] [PATCH arm-devs v3 4/9] target-arm/cpu: Convert reset CBAR to a property

2013-12-02 Thread Peter Crosthwaite
The reset Value of the CP15 CBAR is a vendor (machine) configurable property. If ARM_FEATURE_CBAR is set, add it as a property at post_init time. Signed-off-by: Peter Crosthwaite --- Change since v1: Re-implement as dynamic property target-arm/cpu.c | 14 ++ 1 file changed, 14 inser

[Qemu-devel] [PATCH arm-devs v3 3/9] target-arm: Define and use ARM_FEATURE_CBAR

2013-12-02 Thread Peter Crosthwaite
Some processors (notably A9 within Highbank) define and use the CP15 configuration base address (CBAR). This is vendor specific so its best implemented as a CPU property (otherwise we would need vendor specific child classes for every ARM implementation). This patch prepares support for converting

[Qemu-devel] [PATCH arm-devs v3 2/9] target-arm/helper.c: Allow cp15.c15 dummy override

2013-12-02 Thread Peter Crosthwaite
The cp15.c15 space is implementation defined. Currently there is a dummy placeholder register RAZing it. Allow overriding of this RAZ so implementations of specific registers can take precedence. Signed-off-by: Peter Crosthwaite --- target-arm/helper.c | 3 ++- 1 file changed, 2 insertions(+),

[Qemu-devel] [PATCH arm-devs v3 1/9] qom/object: Make uintXX added properties writable

2013-12-02 Thread Peter Crosthwaite
Currently the uintXX property adders make a read only property. This is not useful for devices that want to create board (or container) configurable dynamic device properties. Fix by trivially adding property setters to object_property_add_uintXX. Signed-off-by: Peter Crosthwaite --- changed sinc

[Qemu-devel] [PATCH arm-devs v3 0/9] Fix Support for ARM A9 CBAR

2013-12-02 Thread Peter Crosthwaite
Hi Peter, This patch series fixed the Configuration base address init logic for ARM CPUs, most notably for A9. Fixes both Zynq and Highbank which both had broken CBAR. Regards, Peter changed since v2: Fixed comment in p8 (PMM review) Enabled CBAR for a15 (PMM review) Typo sweep Changed since v1:

Re: [Qemu-devel] [PATCH arm-devs v2 8/8] arm/highbank.c: Fix MPCore periphbase name

2013-12-02 Thread Peter Crosthwaite
Hi Peter, On Fri, Nov 29, 2013 at 10:09 AM, Peter Crosthwaite wrote: > On Fri, Nov 29, 2013 at 5:41 AM, Peter Maydell > wrote: >> On 28 November 2013 03:31, Peter Crosthwaite >> wrote: >>> GIC_BASE_ADDR is not the base address of the GIC. Its clear from the >>> code that this is the base addre

Re: [Qemu-devel] [PATCH v4 1/6] qemu-iotests: Add "-c " option

2013-12-02 Thread Wenchao Xia
> xpand=true > @@ -147,6 +155,7 @@ check options > -o options -o options to pass to qemu-img create/convert > -Toutput timestamps > -r randomize test order > +-c cache mode > "+-c mode

Re: [Qemu-devel] [PATCH v4 5/6] qemu-iotests: Clean up spaces in usage output

2013-12-02 Thread Wenchao Xia
Reviewed-by: Wenchao Xia

Re: [Qemu-devel] [PATCH v4 4/6] qemu-iotests: Change default cache mode to "writeback"

2013-12-02 Thread Wenchao Xia
Reviewed-by: Wenchao Xia

[Qemu-devel] [RFC PATCH v1 4/5] qemu-option: Remove qemu_opts_create_nofail

2013-12-02 Thread Peter Crosthwaite
This is a boiler-plate _nofail variant of qemu_opts_create. Remove and use error_abort in call sites. A null argument needs to be added for the id field in affected callsites due to inconsistency between the normal and no_fail variants. Signed-off-by: Peter Crosthwaite --- block/blkdebug.c

[Qemu-devel] [RFC PATCH v1 1/5] error: Add error_abort

2013-12-02 Thread Peter Crosthwaite
Add a special Error * that can be passed to error handling APIs to signal that any errors are fatal and should abort QEMU. There are two advantages to this: - allows for brevity when wishing to assert success of Error ** accepting APIs. No need for this pattern: Error * local_err = NULL;

[Qemu-devel] [RFC PATCH v1 3/5] target-i386: Remove assert_no_error usage

2013-12-02 Thread Peter Crosthwaite
Replace an assert_no_error() usage with the error_abort system. Signed-off-by: Peter Crosthwaite --- target-i386/cpu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 47af9a8..b930ca5 100644 --- a/target-i386/cpu.c +++ b/target-

Re: [Qemu-devel] [PATCH v4 3/6] qemu-iotests: Add _default_cache_mode and _supported_cache_modes

2013-12-02 Thread Wenchao Xia
This patch override only when default is specified, I am +1 with it. I think we had discuss before, just want a double check, stefan, do you agree with this? > This replaces _unsupported_qemu_io_options and check for support of > current cache mode, and allow to provide a default if user didn't >

[Qemu-devel] [RFC PATCH v1 5/5] qerror: Remove assert_no_error()

2013-12-02 Thread Peter Crosthwaite
This is no longer needed, and is obsoleted by error_abort. Remove. Signed-off-by: Peter Crosthwaite --- include/qapi/qmp/qerror.h | 1 - qobject/qerror.c | 8 2 files changed, 9 deletions(-) diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h index c30c2f6..73c

Re: [Qemu-devel] [PATCH] qom: abort on error in property setter if caller passed errp == NULL

2013-12-02 Thread Peter Crosthwaite
On Fri, Nov 29, 2013 at 5:56 PM, Markus Armbruster wrote: > Peter Crosthwaite writes: > >> On Fri, Nov 29, 2013 at 1:03 AM, Markus Armbruster wrote: >>> Paolo Bonzini writes: >>> Il 28/11/2013 14:23, Igor Mammedov ha scritto: > > object_property_set(Foo, bar, "baz", &abort_on_err); >>>

[Qemu-devel] [RFC PATCH v1 2/5] hw: Remove assert_no_error usages

2013-12-02 Thread Peter Crosthwaite
Replace assert_no_error() usages with the error_abort system. &error_abort is passed into API calls to signal to the Error sub-system that any errors are fatal. Removes need for caller assertions. Signed-off-by: Peter Crosthwaite --- hw/core/qdev-properties-system.c | 8 ++-- hw/core/qdev-

[Qemu-devel] [RFC PATCH v1 0/5] Add error_abort and associated cleanups

2013-12-02 Thread Peter Crosthwaite
Following our discussion RE self asserting API calls, here is a spin of my proposal. This series obsoletes the need for _nofail variants for Error ** accepting APIs. Is also greately reduces the verbosity of calls sites that are currently asserting against errors. Patch 1 is the main event - addit

Re: [Qemu-devel] [PATCH v4 2/6] qemu-iotests: Honour cache mode in iotests.py

2013-12-02 Thread Wenchao Xia
Reviewed-by: Wenchao Xia

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-02 Thread Alexey Kardashevskiy
On 11/26/2013 03:55 PM, Alexey Kardashevskiy wrote: > Hi! > > btw there is a problem with this patch - it does not compile for > "linux-user" as there is no current-machine global variable defined in vl.c > which is not compiled for linux-user. > > How to solve this problem correctly? > > > On

Re: [Qemu-devel] [PATCH v6 0/2] spapr: rma and numa nodes fixes

2013-12-02 Thread Alexey Kardashevskiy
On 11/25/2013 02:14 PM, Alexey Kardashevskiy wrote: > This fixes a bug in patch#1 and mistype in patch#2, details are in > the commit messages. > > Alexey Kardashevsksy (1): > spapr: make sure RMA is in first mode of first memory node > > Paul Mackerras (1): > spapr: limit numa memory regions

[Qemu-devel] [PATCH v4] cpu: add suboptions support

2013-12-02 Thread Alexey Kardashevskiy
This adds suboptions support for -cpu. This keeps @cpu_model in order not to break the existing architectures/machines. Cc: Andreas Färber Signed-off-by: Alexey Kardashevskiy --- Changes: v4: * moved QemuOpts logic to qeom/cpu.c * added cpu_opt_get() as the machine init code wants to know the CP

Re: [Qemu-devel] [PATCH V6 0/6] export internal snapshot by qemu-nbd

2013-12-02 Thread Wenchao Xia
于 2013/11/29 16:54, Wenchao Xia 写道: >> v6: >> Address Kevin's comments: >> 1: typo fix, remove device and snapshot info in error message. >> 2: use strstart(). >> 3: use _require_command(), limit proto to file, since when proto=nbd >> it can't work. also changed _require_command() t

[Qemu-devel] [PATCH v5 0/2] target-ppc: CPU device tree id

2013-12-02 Thread Alexey Kardashevskiy
Hi! This is some cleanup. Please, comment. Thanks! Changes: v5: * cleanup * removed cpustate::kvm_cpu_id * split into 2 patches - new PPC API and the usage of the API Alexey Kardashevskiy (2): target-ppc: add PowerPCCPU::cpu_dt_id target-ppc: spapr: e500: fix to use cpu_dt_id hw/intc/op

[Qemu-devel] [PATCH v5 1/2] target-ppc: add PowerPCCPU::cpu_dt_id

2013-12-02 Thread Alexey Kardashevskiy
Normally CPUState::cpu_index is used to pick the right CPU for various operations. However default consecutive numbering does not always work for POWERPC. These indexes are reflected in /proc/device-tree/cpus/PowerPC,POWER7@XX and used to call KVM VCPU's ioctls. In order to achieve this, kvmppc_fi

[Qemu-devel] [PATCH v5 2/2] target-ppc: spapr: e500: fix to use cpu_dt_id

2013-12-02 Thread Alexey Kardashevskiy
This makes use of @cpu_dt_id and related API in: 1. emulated XICS hypercall handlers as they receive fixed CPU indexes; 2. XICS-KVM to enable in-kernel XICS on right CPU; 3. device-tree renderer. This removes @cpu_index fixup as @cpu_dt_id is used instead so QEMU monitor can accept command-line CP

Re: [Qemu-devel] [PATCH V3 8/9] qapi: convert BlockdevOptions to use enum discriminator

2013-12-02 Thread Eric Blake
On 11/29/2013 01:41 AM, Wenchao Xia wrote: > After this patch, hidden enum type BlockdevOptionsKind will not > be generated, and other API can use enum BlockdevDriver. > > Signed-off-by: Wenchao Xia > --- > qapi-schema.json | 14 +- > 1 files changed, 13 insertions(+), 1 deletions(

Re: [Qemu-devel] [PATCH V3 6/9] qapi script: support pre-defined enum type as discriminator in union

2013-12-02 Thread Eric Blake
On 11/29/2013 01:41 AM, Wenchao Xia wrote: > By default, any union will automatically generate a enum type as > "[UnionName]Kind" in C code, and it is duplicated when the discriminator > is specified as a pre-defined enum type in schema. After this patch, > the pre-defined enum type will be really

Re: [Qemu-devel] [PATCH V2 5/8] qapi script: use same function to generate enum string

2013-12-02 Thread Wenchao Xia
于 2013/12/3 4:17, Eric Blake 写道: On 11/12/2013 03:25 PM, Wenchao Xia wrote: One function one rule, so the enum string generating have same behavior for different caller. If multiple caller exist for one enum define in schema, it is for sure the generated string is identical. Note before the pat

Re: [Qemu-devel] [PATCH] vmdk: Fix creating big description file

2013-12-02 Thread Fam Zheng
On 2013年12月02日 21:26, Stefan Hajnoczi wrote: On Mon, Dec 02, 2013 at 11:01:20AM +0800, Fam Zheng wrote: The buffer for description file was 4096 which only covers a few hundred of extents. This changes the buffer to dynamic allocated with g_strdup_printf in order to support bigger cases. Signed

Re: [Qemu-devel] [PATCH 3/4 v4] block: return status for each device

2013-12-02 Thread Roy Franz
On Thu, Nov 28, 2013 at 11:10 AM, Peter Maydell wrote: > On 22 October 2013 17:35, Roy Franz wrote: >> Now that we know how wide each flash device that makes up the bank is, >> return status for each device in the bank. Leave existing code >> that treats 32 bit wide banks as composed of two 16 b

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vl: remove (max_cpus > 255) check from smp_parse

2013-12-02 Thread Alexey Kardashevskiy
On 12/03/2013 09:09 AM, Andreas Färber wrote: > Am 02.12.2013 18:06, schrieb Michael Tokarev: >> 25.11.2013 07:39, Alexey Kardashevskiy wrote: >>> Since modern POWER7/POWER8 chips can have more that 256 CPU threads >>> (>2000 actually), remove this check from smp_parse. >>> >>> The CPUs number is s

[Qemu-devel] [Bug 1257099] [NEW] QEMU fails to build on CentOS 5.10 with relocation R_X86_64_PC32 error

2013-12-02 Thread Don Slutz
Public bug reported: lt LINK libcacard.la /usr/bin/ld: libcacard/.libs/vcard.o: relocation R_X86_64_PC32 against `vcard_buffer_response_delete' can not be used when making a shared object; recompile with -fPIC /usr/bin/ld: final link failed: Bad value collect2: ld returned 1 exit status make[4

Re: [Qemu-devel] [PATCH v7 2/6] target-arm: Implement ARMv8 VSEL instruction.

2013-12-02 Thread Peter Maydell
On 2 December 2013 20:12, Will Newton wrote: > This adds support for the VSEL floating point selection instruction > which was added in ARMv8. Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v7 6/6] target-arm: Implement ARMv8 SIMD VMAXNM and VMINNM instructions.

2013-12-02 Thread Peter Maydell
On 2 December 2013 20:12, Will Newton wrote: > This adds support for the ARMv8 Advanced SIMD VMAXNM and VMINNM > instructions. > > Signed-off-by: Will Newton > --- > target-arm/helper.h | 3 +++ > target-arm/neon_helper.c | 16 > target-arm/translate.c | 31 +

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vl: remove (max_cpus > 255) check from smp_parse

2013-12-02 Thread Andreas Färber
Am 02.12.2013 18:06, schrieb Michael Tokarev: > 25.11.2013 07:39, Alexey Kardashevskiy wrote: >> Since modern POWER7/POWER8 chips can have more that 256 CPU threads >> (>2000 actually), remove this check from smp_parse. >> >> The CPUs number is still checked against machine->max_cpus and this check

Re: [Qemu-devel] [PATCH v7 5/6] target-arm: Implement ARMv8 FP VMAXNM and VMINNM instructions.

2013-12-02 Thread Peter Maydell
On 2 December 2013 20:12, Will Newton wrote: > This adds support for the ARMv8 floating point VMAXNM and VMINNM > instructions. Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [PATCH] adlib: fix patching of port I/O addresses

2013-12-02 Thread Hervé Poussineau
Paolo Bonzini a écrit : Commit 2b21fb5 (adlib: sort offsets in portio registration, 2013-08-14) fixed the offsets in adlib_portio_list, but forgot the matching indices in adlib_realizefn. Reported at http://virtuallyfun.superglobalmegacorp.com/?p=3616 by "neozeed". Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH v7 1/6] target-arm: Move call to disas_vfp_insn out of disas_coproc_insn.

2013-12-02 Thread Peter Maydell
On 2 December 2013 20:12, Will Newton wrote: > Floating point is an extension to the instruction set rather than > a coprocessor, so call it directly from the ARM and Thumb decode > functions. Reviewed-by: Peter Maydell (In case you're not familiar with the convention, please copy that reviewed

Re: [Qemu-devel] [PATCH v7 4/6] softfloat: Add minNum() and maxNum() functions to softfloat.

2013-12-02 Thread Peter Maydell
On 2 December 2013 20:12, Will Newton wrote: > Add floatnn_minnum() and floatnn_maxnum() functions which are equivalent > to the minNum() and maxNum() functions from IEEE 754-2008. They are > similar to min() and max() but differ in the handling of QNaN arguments. Missing Signed-off-by: line here

Re: [Qemu-devel] [PATCH 1/8] add pc-{i440fx,q35}-2.0 machine types

2013-12-02 Thread Andreas Färber
Am 02.12.2013 15:44, schrieb Gerd Hoffmann: > On Mo, 2013-12-02 at 15:30 +0100, Igor Mammedov wrote: >> why 2.0, are we jumping from 1.7 strait to 2.0? > > Looks like this is the plan ... > > nilsson kraxel ~/projects/qemu# git show master > commit 7dc65c02fe3fb8f3146ce0b9ff5fec5945329f0e > Autho

Re: [Qemu-devel] [PATCH v7 3/6] softfloat: Remove unused argument from MINMAX macro.

2013-12-02 Thread Peter Maydell
On 2 December 2013 20:12, Will Newton wrote: > The nan_exp argument is not used, so remove it. Nice catch -- this has actually been present since I originally introduced the macros (probably as cut-n-paste legacy from the compare macros). PS: you missed your signed-off-by line. Reviewed-by: Pet

Re: [Qemu-devel] [Xen-devel] RESEND [Xen-unstable][Qemu-xen] HVM Guest reading of Expansion ROM from passthroughed PCI device returns data from emulated VGA rom

2013-12-02 Thread Sander Eikelenboom
Monday, December 2, 2013, 9:39:37 PM, you wrote: > On Mon, Dec 02, 2013 at 08:55:57PM +0100, Sander Eikelenboom wrote: >> >> Monday, December 2, 2013, 8:41:31 PM, you wrote: >> >> > On Tue, Sep 17, 2013 at 04:33:39PM +0200, Sander Eikelenboom wrote: >> >> *RESEND* due to exceeding the mailingli

Re: [Qemu-devel] [Xen-devel] RESEND [Xen-unstable][Qemu-xen] HVM Guest reading of Expansion ROM from passthroughed PCI device returns data from emulated VGA rom

2013-12-02 Thread Konrad Rzeszutek Wilk
On Mon, Dec 02, 2013 at 08:55:57PM +0100, Sander Eikelenboom wrote: > > Monday, December 2, 2013, 8:41:31 PM, you wrote: > > > On Tue, Sep 17, 2013 at 04:33:39PM +0200, Sander Eikelenboom wrote: > >> *RESEND* due to exceeding the mailinglists limit for attachment size. > >> > >> Hi, > >> > >> I

Re: [Qemu-devel] [PATCH V2 7/8] qapi script: do not add "_" for every capitalized char in enum

2013-12-02 Thread Eric Blake
On 11/12/2013 03:25 PM, Wenchao Xia wrote: > Now "enum AIOContext" will generate AIO_CONTEXT instead of A_I_O_CONTEXT, > "X86CPU" will generate X86_CPU instead of X86_C_P_U. > > Signed-off-by: Wenchao Xia > --- > include/qapi/qmp/qerror.h |2 +- > scripts/qapi.py | 26 +++

Re: [Qemu-devel] [PATCH V2 5/8] qapi script: use same function to generate enum string

2013-12-02 Thread Eric Blake
On 11/12/2013 03:25 PM, Wenchao Xia wrote: > One function one rule, so the enum string generating have same > behavior for different caller. If multiple caller exist for one > enum define in schema, it is for sure the generated string is > identical. > > Note before the patch qapi-visit.py used cu

[Qemu-devel] [PATCH v7 4/6] softfloat: Add minNum() and maxNum() functions to softfloat.

2013-12-02 Thread Will Newton
Add floatnn_minnum() and floatnn_maxnum() functions which are equivalent to the minNum() and maxNum() functions from IEEE 754-2008. They are similar to min() and max() but differ in the handling of QNaN arguments. --- fpu/softfloat.c | 54 +

[Qemu-devel] [PATCH v7 2/6] target-arm: Implement ARMv8 VSEL instruction.

2013-12-02 Thread Will Newton
This adds support for the VSEL floating point selection instruction which was added in ARMv8. --- target-arm/translate.c | 135 - 1 file changed, 134 insertions(+), 1 deletion(-) Changes in v7: - Break out VSEL handling into a function - Properly

[Qemu-devel] [PATCH v7 6/6] target-arm: Implement ARMv8 SIMD VMAXNM and VMINNM instructions.

2013-12-02 Thread Will Newton
This adds support for the ARMv8 Advanced SIMD VMAXNM and VMINNM instructions. Signed-off-by: Will Newton --- target-arm/helper.h | 3 +++ target-arm/neon_helper.c | 16 target-arm/translate.c | 31 ++- 3 files changed, 41 insertions(+), 9 dele

[Qemu-devel] [PATCH v7 5/6] target-arm: Implement ARMv8 FP VMAXNM and VMINNM instructions.

2013-12-02 Thread Will Newton
This adds support for the ARMv8 floating point VMAXNM and VMINNM instructions. --- target-arm/helper.c| 25 + target-arm/helper.h| 5 + target-arm/translate.c | 50 ++ 3 files changed, 80 insertions(+) Changes in

[Qemu-devel] [PATCH v7 3/6] softfloat: Remove unused argument from MINMAX macro.

2013-12-02 Thread Will Newton
The nan_exp argument is not used, so remove it. --- fpu/softfloat.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Changes in v7: - New patch diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 7ba51b6..97bf627 100644 --- a/fpu/softfloat.c +++ b/fpu/softfloat.c @@ -6706,7 +6706,7

[Qemu-devel] [PATCH v7 1/6] target-arm: Move call to disas_vfp_insn out of disas_coproc_insn.

2013-12-02 Thread Will Newton
Floating point is an extension to the instruction set rather than a coprocessor, so call it directly from the ARM and Thumb decode functions. --- target-arm/translate.c | 32 +++- 1 file changed, 27 insertions(+), 5 deletions(-) Changes in v7: - Fix comment style - F

[Qemu-devel] [PATCH v7 0/6] target-arm: Add support for VSEL and VMIN/MAXNM.

2013-12-02 Thread Will Newton
This series adds support for three new instructions added in ARMv8 - VSEL, VMINNM and VMAXNM. Will Newton (6): target-arm: Move call to disas_vfp_insn out of disas_coproc_insn. target-arm: Implement ARMv8 VSEL instruction. softfloat: Remove unused argument from MINMAX macro. softfloat: Add

Re: [Qemu-devel] [PATCH] arm: Raspberry Pi support

2013-12-02 Thread Gregory ESTRADE
Hi Jan, Stefan and all people at the qemu-devel mailing list :) As Stefan stated, there's a new patch in progress, which includes additional cleanup. Sorry Jan, I should have notified you about it before. However, I would love to see any comments about it. Regards, Greg Le 02/12/2013 21:01, S

Re: [Qemu-devel] [PATCH] arm: Raspberry Pi support

2013-12-02 Thread Peter Maydell
On 2 December 2013 11:11, Jan Petrouš wrote: > > Initial commit. Added 'raspi' virtual platform and corresponding > BCM2835 devices support. > > The code is (c) Gregory Estrade > retrieved from Greg's out-of-tree repository on github > https://github.com/Torlus/qemu/tree/rpi > and squashed the fo

Re: [Qemu-devel] [PATCH] arm: Raspberry Pi support

2013-12-02 Thread Stefan Weil
Am 02.12.2013 12:11, schrieb Jan Petrouš: > > Initial commit. Added 'raspi' virtual platform and corresponding > BCM2835 devices support. > > The code is (c) Gregory Estrade > > retrieved from Greg's out-of-tree repository on github > https://github.com/Torlus/qem

Re: [Qemu-devel] [Xen-devel] RESEND [Xen-unstable][Qemu-xen] HVM Guest reading of Expansion ROM from passthroughed PCI device returns data from emulated VGA rom

2013-12-02 Thread Sander Eikelenboom
Monday, December 2, 2013, 8:41:31 PM, you wrote: > On Tue, Sep 17, 2013 at 04:33:39PM +0200, Sander Eikelenboom wrote: >> *RESEND* due to exceeding the mailinglists limit for attachment size. >> >> Hi, >> >> I'm trying to get secondary vga-passthrough on a HVM guest to work with a >> AMD HD657

[Qemu-devel] [PATCH trivial] hw/ppc/mac.h: remove unused BIOS_FILENAME definition

2013-12-02 Thread Michael Tokarev
This definition has been moved to prep.c. Signed-off-by: Michael Tokarev --- hw/ppc/mac.h |1 - 1 file changed, 1 deletion(-) diff --git a/hw/ppc/mac.h b/hw/ppc/mac.h index 1e578dd..c1faf9c 100644 --- a/hw/ppc/mac.h +++ b/hw/ppc/mac.h @@ -34,7 +34,6 @@ #define MAX_CPUS 1 #define BIOS_SI

Re: [Qemu-devel] [PATCH V2 3/8] qapi script: check correctness of discriminator values in union

2013-12-02 Thread Eric Blake
On 11/12/2013 03:25 PM, Wenchao Xia wrote: > It will check whether the values specified are written correctly, > and whether all enum values are covered, when discriminator is a > pre-defined enum type > > Signed-off-by: Wenchao Xia > --- > scripts/qapi-visit.py | 17 + > scrip

Re: [Qemu-devel] [Xen-devel] RESEND [Xen-unstable][Qemu-xen] HVM Guest reading of Expansion ROM from passthroughed PCI device returns data from emulated VGA rom

2013-12-02 Thread Konrad Rzeszutek Wilk
On Tue, Sep 17, 2013 at 04:33:39PM +0200, Sander Eikelenboom wrote: > *RESEND* due to exceeding the mailinglists limit for attachment size. > > Hi, > > I'm trying to get secondary vga-passthrough on a HVM guest to work with a AMD > HD6570 and the native kernel radeon driver and kernel modesettin

Re: [Qemu-devel] [PATCH V2 2/8] qapi script: add check for duplicated key

2013-12-02 Thread Eric Blake
On 11/12/2013 03:25 PM, Wenchao Xia wrote: > It is bad that same key was specified twice, especially when a union have > two branches with same condition. This patch can prevent it. > > Signed-off-by: Wenchao Xia > --- > scripts/qapi.py |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(

[Qemu-devel] questions about Quemu

2013-12-02 Thread Daniela Zurita
Hello all, Where can I get more information on using this tool? I would need to install my app on a remote device including Android and iPhone. Many thanks in advance! Kind regards, Daniela __ Daniela Zurita QA Analyst, ITX Corp. dzur...@itx.com

Re: [Qemu-devel] [PATCH 4/4] tpm: Provide libtpms software TPM backend

2013-12-02 Thread Stefan Berger
On 12/02/2013 09:16 AM, Corey Bryant wrote: Stefan, do you know if this is the same code that was used to build our bios.bin? Probably similar, but forward-ported to a more recent version.

[Qemu-devel] [Bug 1256826] [NEW] INT instruction bug in WindowsXP

2013-12-02 Thread Jackend
Public bug reported: This bug is in -no-kvm mode. In windowsXP at IDT entry 2&8 is Task gate when application use INT 2 or INT 8 it will cause blue screen in XP. I found it should cause #GP not generate hw interrupt. also I check this bug with -enable-kvm and works correctly. ** Affects: qemu

Re: [Qemu-devel] [RFC PATCH 03/15] input: define event types using qapi

2013-12-02 Thread Eric Blake
On 11/28/2013 07:29 AM, Gerd Hoffmann wrote: > Define input event types, using qapi. So we get nicely autogenerated > types for our input events. And when it comes to qmp support some day > things will be alot easier. > > Types are modeled after the linux input layer. There are separate > event

Re: [Qemu-devel] [RFC PATCH 12/15] input: mouse: add qemu_input_is_absolute()

2013-12-02 Thread John Baboval
Perhaps this should just return the mask instead of a boolean? It would be nice at some point to handle a USB HID style device that can send both relative and absolute events, for example. Though perhaps that would be better as future work, since this is a nice drop-in replacement for the old

Re: [Qemu-devel] [RFC PATCH 11/15] input: mouse: add graphic_rotate support

2013-12-02 Thread John Baboval
I'm not sure this is correct. Generally when the display gets rotated, the input device coordinates do not, and the in-guest code handles the math. On 11/28/2013 09:30 AM, Gerd Hoffmann wrote: Transform absolute mouse events according to graphic_rotate. Legacy input code does it for both absol

Re: [Qemu-devel] [PATCH] spapr_vscsi: Fix REPORT_LUNS handling

2013-12-02 Thread Paolo Bonzini
Il 02/12/2013 18:51, Nathan Whitehorn ha scritto: > Any news on this? FreeBSD is unbootable from CDROM devices in > QEMU/pseries without this patch. > -Nathan Acked-by: Paolo Bonzini Alex, can you pick it up?

Re: [Qemu-devel] [PATCHv4] qdev: Validate hex properties

2013-12-02 Thread Eric Blake
On 11/28/2013 11:48 PM, Hannes Reinecke wrote: > strtoul(l) might overflow, in which case it'll return '-1' and set > the appropriate error code. So update the calls to strtoul(l) when > parsing hex properties to avoid silent overflows. > And we should be using an intermediate variable to avoid clo

Re: [Qemu-devel] [PATCH] spapr_vscsi: Fix REPORT_LUNS handling

2013-12-02 Thread Nathan Whitehorn
Any news on this? FreeBSD is unbootable from CDROM devices in QEMU/pseries without this patch. -Nathan On 10/18/13 07:33, Nathan Whitehorn wrote: Intercept REPORT_LUNS commands addressed either to SRP LUN 0 or the well-known LUN for REPORT_LUNS commands. This is required to implement the SAM an

Re: [Qemu-devel] [PATCH 1/4] X86: Intel MPX definiation

2013-12-02 Thread Paolo Bonzini
Il 02/12/2013 17:43, Liu, Jinsong ha scritto: > From fbfa537f690eca139a96c6b2636ab5130bf57716 Mon Sep 17 00:00:00 2001 > From: Liu Jinsong > Date: Fri, 29 Nov 2013 01:27:00 +0800 > Subject: [PATCH 1/4] X86: Intel MPX definiation > > Signed-off-by: Xudong Hao > Signed-off-by: Liu Jinsong > --- >

Re: [Qemu-devel] [PATCH 1/2] target-i386: fix cpuid leaf 0x0d

2013-12-02 Thread Paolo Bonzini
Il 02/12/2013 17:41, Liu, Jinsong ha scritto: > From 57751d87392d7ee9df5698bc83b356de654453ef Mon Sep 17 00:00:00 2001 > From: Liu Jinsong > Date: Tue, 3 Dec 2013 04:17:50 +0800 > Subject: [PATCH 1/2] target-i386: fix cpuid leaf 0x0d > > Fix cpuid leaf 0x0d which incorrectly parsed eax and ebx. >

Re: [Qemu-devel] [PATCH 2/2] target-i386: Intel MPX

2013-12-02 Thread Paolo Bonzini
Il 02/12/2013 17:42, Liu, Jinsong ha scritto: > From 1a199d68265ffeb0234530f29d92a00a5edeff75 Mon Sep 17 00:00:00 2001 > From: Liu Jinsong > Date: Tue, 3 Dec 2013 05:08:19 +0800 > Subject: [PATCH 2/2] target-i386: Intel MPX > > Add some MPX related definiation, and hardcode sizes and offsets > of

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] Don't crash on keyboard input with no handler

2013-12-02 Thread Michael Tokarev
20.11.2013 00:01, Don Koch wrote: > Prevent a call to put_kbd if null. > > On shutdown of some OSes, the keyboard handler goes away before the > system is down. If a key is typed during this window, qemu crashes. Thanks, applied to the trivial patches queue. /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] libcacard/vcard_emul_nss: Remove unused statement (value stored is never read)

2013-12-02 Thread Michael Tokarev
18.11.2013 01:12, Stefan Weil wrote: > Warning from ccc-analyzer: > > libcacard/vcard_emul_nss.c:937:9: warning: > Value stored to 'cert_count' is never read > cert_count = options->vreader[i].cert_count; > ^~~ Applied to trivial patches, t

Re: [Qemu-devel] [Qemu-trivial] [PATCH] libcacard/cac: Remove unused statement (value stored is never read)

2013-12-02 Thread Michael Tokarev
18.11.2013 01:11, Stefan Weil wrote: > Warning from ccc-analyzer: > > libcacard/cac.c:192:13: warning: Value stored to 'ret' is never read > ret = VCARD_DONE; > ^ ~~ > > Here 'ret' is assigned a value inside of a switch statement and also after > that switch st

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vl: remove (max_cpus > 255) check from smp_parse

2013-12-02 Thread Michael Tokarev
25.11.2013 07:39, Alexey Kardashevskiy wrote: > Since modern POWER7/POWER8 chips can have more that 256 CPU threads > (>2000 actually), remove this check from smp_parse. > > The CPUs number is still checked against machine->max_cpus and this check > should be enough not to break other archs. [] >

Re: [Qemu-devel] [Qemu-trivial] [PATCH] virtio-net: fix the indent

2013-12-02 Thread Michael Tokarev
Thanks, applied to the trivial patches queue. /mjt

[Qemu-devel] [PATCH 4/4] KVM/X86: Enable Intel MPX for guest

2013-12-02 Thread Liu, Jinsong
>From 62553aebb7b72f1203fefc59dd4d8969e4216ddb Mon Sep 17 00:00:00 2001 From: Liu Jinsong Date: Tue, 3 Dec 2013 07:34:32 +0800 Subject: [PATCH 4/4] KVM/X86: Enable Intel MPX for guest Signed-off-by: Xudong Hao Signed-off-by: Liu Jinsong --- arch/x86/kvm/cpuid.c |2 +- arch/x86/kvm/x86.c

[Qemu-devel] [PATCH 3/4] KVM/X86: Intel MPX vmx and msr handle

2013-12-02 Thread Liu, Jinsong
>From e9ba40b3d1820b8ab31431c73226ee3ed485edd1 Mon Sep 17 00:00:00 2001 From: Liu Jinsong Date: Tue, 3 Dec 2013 07:02:27 +0800 Subject: [PATCH 3/4] KVM/X86: Intel MPX vmx and msr handle Signed-off-by: Xudong Hao Signed-off-by: Liu Jinsong --- arch/x86/include/asm/vmx.h|2 ++ ar

[Qemu-devel] [PATCH 2/4] KVM/X86: Fix xsave cpuid exposing bug

2013-12-02 Thread Liu, Jinsong
>From 4a2eb0a8467b4f278e59d2df209a1bc03349d088 Mon Sep 17 00:00:00 2001 From: Liu Jinsong Date: Tue, 3 Dec 2013 06:28:20 +0800 Subject: [PATCH 2/4] KVM/X86: Fix xsave cpuid exposing bug EBX of cpuid(0xD, 0) is dynamic per XCR0 features enable/disable. Bit 63 of XCR0 is reserved for future expansi

[Qemu-devel] [PATCH 1/4] X86: Intel MPX definiation

2013-12-02 Thread Liu, Jinsong
>From fbfa537f690eca139a96c6b2636ab5130bf57716 Mon Sep 17 00:00:00 2001 From: Liu Jinsong Date: Fri, 29 Nov 2013 01:27:00 +0800 Subject: [PATCH 1/4] X86: Intel MPX definiation Signed-off-by: Xudong Hao Signed-off-by: Liu Jinsong --- arch/x86/include/asm/cpufeature.h |2 ++ arch/x86/include

[Qemu-devel] [PATCH 2/2] target-i386: Intel MPX

2013-12-02 Thread Liu, Jinsong
>From 1a199d68265ffeb0234530f29d92a00a5edeff75 Mon Sep 17 00:00:00 2001 From: Liu Jinsong Date: Tue, 3 Dec 2013 05:08:19 +0800 Subject: [PATCH 2/2] target-i386: Intel MPX Add some MPX related definiation, and hardcode sizes and offsets of xsave features 3 and 4. Signed-off-by: Liu Jinsong ---

[Qemu-devel] [PATCH 1/2] target-i386: fix cpuid leaf 0x0d

2013-12-02 Thread Liu, Jinsong
>From 57751d87392d7ee9df5698bc83b356de654453ef Mon Sep 17 00:00:00 2001 From: Liu Jinsong Date: Tue, 3 Dec 2013 04:17:50 +0800 Subject: [PATCH 1/2] target-i386: fix cpuid leaf 0x0d Fix cpuid leaf 0x0d which incorrectly parsed eax and ebx. However, before this patch the CPUID worked fine -- the su

Re: [Qemu-devel] [PATCHv2 00/14] Spice block device, ready-to-go patches

2013-12-02 Thread Stefan Hajnoczi
On Sun, Dec 01, 2013 at 10:23:33PM +0100, Marc-André Lureau wrote: > This patch series is a split-off from the Spice block device RFC. > http://lists.gnu.org/archive/html/qemu-devel/2013-11/msg02024.html > > It should include only non-controversial or simple patches. The most > important change is

Re: [Qemu-devel] sparc64 with openbios-sparc64

2013-12-02 Thread Mark Cave-Ayland
On 26/11/13 22:05, Mahmood Naderan wrote: On Tuesday, November 26, 2013 4:51 PM, Mahmood Naderan wrote: Hello, Is there any news on emulating sparc64 machine with openbios-sparc64 on a x86_64 host machine? I followed >some posts regarding this from 2010 however didn't end-up with a conclusion

Re: [Qemu-devel] [RFC] Incremental live backup with in memory dirty bitmap

2013-12-02 Thread Stefan Hajnoczi
On Mon, Nov 25, 2013 at 05:59:12PM +0800, Fam Zheng wrote: > This is an idea about allowing online incremental backup of block > device, with drive-backup and (proposed here) in-memory block dirty > bitmap: > > 1. We enable a dirty bitmap on a block device, at the start point of > write tracking:

Re: [Qemu-devel] [PATCH] target-arm: add support for v8 AES instructions

2013-12-02 Thread Peter Maydell
On 6 November 2013 14:21, Ard Biesheuvel wrote: > This adds support for the AESE/AESD/AESMC/AESIMC instructions that > are available on some v8 implementations of Aarch32. > > Signed-off-by: Ard Biesheuvel Hi; thanks for this patch. I have a few minor review comments, but it looks pretty good.

Re: [Qemu-devel] [PATCH] spice: flip streaming video mode to off by default

2013-12-02 Thread Alon Levy
On 12/02/2013 12:27 PM, Gerd Hoffmann wrote: > Video streaming detection heuristics in spice-server have problems > keeping modern desktop animations (as done by gnome shell) and real > video playback apart. This leads to jpeg compression artefacts on > your desktop, due to spice using mjpeg to se

Re: [Qemu-devel] [PATCH 1/8] add pc-{i440fx,q35}-2.0 machine types

2013-12-02 Thread Gerd Hoffmann
On Mo, 2013-12-02 at 15:30 +0100, Igor Mammedov wrote: > On Mon, 2 Dec 2013 13:24:36 +0100 > Gerd Hoffmann wrote: > why 2.0, are we jumping from 1.7 strait to 2.0? Looks like this is the plan ... nilsson kraxel ~/projects/qemu# git show master commit 7dc65c02fe3fb8f3146ce0b9ff5fec5945329f0e Aut

[Qemu-devel] [PATCH 3/4] memory: hoist coalesced MMIO flush

2013-12-02 Thread Paolo Bonzini
No need to flush the coalesced MMIO buffer multiple times when combining multiple accesses into one. Signed-off-by: Paolo Bonzini --- memory.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/memory.c b/memory.c index 1ade19c..495e693 100644 --- a/memory.c +++ b

[Qemu-devel] [PATCH 2/4] memory: streamline common case for memory dispatch

2013-12-02 Thread Paolo Bonzini
In the common case where there is no combining or splitting, access_with_adjusted_size is adding a lot of overhead. Call the MMIO ops directly in that case. Signed-off-by: Paolo Bonzini --- memory.c | 68 1 file changed, 56 insert

[Qemu-devel] [PATCH 4/4] memory: small tweaks

2013-12-02 Thread Paolo Bonzini
Make adjust_endianness inline, and do not use a ctz instruction when a shift will do. Signed-off-by: Paolo Bonzini --- memory.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/memory.c b/memory.c index 495e693..d3b0dce 100644 --- a/memory.c +++ b/memory.c @@

[Qemu-devel] [PATCH 1/4] memory: cache min/max_access_size

2013-12-02 Thread Paolo Bonzini
This will simplify the code in the next patch. Signed-off-by: Paolo Bonzini --- include/exec/memory.h | 2 ++ memory.c | 27 +++ 2 files changed, 13 insertions(+), 16 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index 480dfbf..cf6

Re: [Qemu-devel] [PATCH 1/8] add pc-{i440fx,q35}-2.0 machine types

2013-12-02 Thread Igor Mammedov
On Mon, 2 Dec 2013 13:24:36 +0100 Gerd Hoffmann wrote: why 2.0, are we jumping from 1.7 strait to 2.0? > Signed-off-by: Gerd Hoffmann > --- > hw/i386/pc_piix.c | 14 -- > hw/i386/pc_q35.c | 11 ++- > 2 files changed, 22 insertions(+), 3 deletions(-) > > diff --git a/hw/i3

  1   2   >