δΊ 2013/11/29 16:54, Wenchao Xia ει: >> v6: >> Address Kevin's comments: >> 1: typo fix, remove device and snapshot info in error message. >> 2: use strstart(). >> 3: use _require_command(), limit proto to file, since when proto=nbd >> it can't work. also changed _require_command() to tip better. >> 4: use strstart(). >> 6: new patch, since I found the doc missing in debugging. >> > Kevin, I found there is exsiting _require_command() in common.rc, and > snapshot create can't work when PROTO=NBD for EOF write request, so > limited the work condition to file and added _require_command QEMU_NBD. > Could u take a look at it? > > Hello, is this version OK to be merged?
- [Qemu-devel] [PATCH V6 3/6] qemu-iotests: add 058 internal... Wenchao Xia
- Re: [Qemu-devel] [PATCH V6 3/6] qemu-iotests: add 058... Stefan Hajnoczi
- [Qemu-devel] [PATCH V6 1/6] snapshot: distinguish id and n... Wenchao Xia
- [Qemu-devel] [PATCH V6 6/6] qemu-nbd: add doc for option -... Wenchao Xia
- [Qemu-devel] [PATCH V6 5/6] qemu-iotests: add test for sna... Wenchao Xia
- [Qemu-devel] [PATCH V6 4/6] qemu-img: add -l for snapshot ... Wenchao Xia
- Re: [Qemu-devel] [PATCH V6 4/6] qemu-img: add -l for ... Stefan Hajnoczi
- Re: [Qemu-devel] [PATCH V6 0/6] export internal snapshot b... Wenchao Xia
- Re: [Qemu-devel] [PATCH V6 0/6] export internal snaps... Wenchao Xia
- Re: [Qemu-devel] [PATCH V6 0/6] export internal snapshot b... Stefan Hajnoczi