On 11/12/2013 03:25 PM, Wenchao Xia wrote: > It is bad that same key was specified twice, especially when a union have > two branches with same condition. This patch can prevent it. > > Signed-off-by: Wenchao Xia <xiaw...@linux.vnet.ibm.com> > --- > scripts/qapi.py | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-)
Reviewed-by: Eric Blake <ebl...@redhat.com> > > diff --git a/scripts/qapi.py b/scripts/qapi.py > index 82f586e..aa91edc 100644 > --- a/scripts/qapi.py > +++ b/scripts/qapi.py > @@ -116,6 +116,8 @@ class QAPISchema: > if self.tok != ':': > raise QAPISchemaError(self, 'Expected ":"') > self.accept() > + if key in expr: > + raise QAPISchemaError(self, 'Duplicated key "%s"' % key) > expr[key] = self.get_expr(True) > if self.tok == '}': > self.accept() > -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
