On 11/06/2013 08:03 PM, Stefan Hajnoczi wrote:
On Thu, Oct 31, 2013 at 10:18:08AM +0800, Fam Zheng wrote:
This patch suspends the test image IO before starting block stream job
so that it doesn't complete before we could check the status.
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/030
On Thu, Nov 07, 2013 at 08:59:22AM +0200, Michael S. Tsirkin wrote:
> On Tue, Nov 05, 2013 at 07:17:18PM +0800, Amos Kong wrote:
> > We currently just update the HMP NIC info when the last bit of macaddr
> > is written. This assumes that guest driver will write all the macaddr
> > from bit 0 to bit
If backing file doesn't exist, the error message is confusing and
misleading:
$ qemu /tmp/a.qcow2
qemu: could not open disk image /tmp/a.qcow2: Could not open file: No
such file or directory
But...
$ ls /tmp/a.qcow2
/tmp/a.qcow2
$ qemu-img info /tmp/a.qcow2
image: /t
On 2013-11-06 16:08, Aneesh Kumar K.V wrote:
> Jan Kiszka writes:
>
>> On 2013-10-07 18:53, Aneesh Kumar K.V wrote:
>>> From: "Aneesh Kumar K.V"
>>>
>>> Targets like ppc64 support different typed of KVM, one which use
>>> hypervisor mode and the other which doesn't. Add a new machine
>>> propert
On Tue, Nov 05, 2013 at 07:17:18PM +0800, Amos Kong wrote:
> We currently just update the HMP NIC info when the last bit of macaddr
> is written. This assumes that guest driver will write all the macaddr
> from bit 0 to bit 5 when it changes the macaddr, this is the current
> behavior of linux driv
"Kirill A. Shutemov" writes:
> From: "Kirill A. Shutemov"
>
> Currently we have few issues with P9_STATS_GEN:
>
> - We don't try to read st_gen anything except files or directories, but
>still set P9_STATS_GEN bit in st_result_mask. It may mislead client:
>we present garbage as valid st
32 and 64 bit variants of QEMU already had different default installation
directories, but used a common registry key for saving the choosen
directory. This is confusing for users who want to install both variants,
so fix it by using different registry keys.
Signed-off-by: Stefan Weil
---
qemu.n
Some targets use a stat64 structure for the stat64 syscall while others
use a stat structure. SPARC64 used the wrong kind.
Instead of extending the conditional compilation in syscall.c, now a
macro TARGET_HAS_STRUCT_STAT64 is defined whenever a target has a
target_stat64.
Signed-off-by: Stefan We
The latest configure invocation was saved in config-host.mak and could
be extracted from that file to recreate the configuration.
Now it is saved in a new file config.status which can be directly executed
to recreate the configuration. The file name and the comments were copied
from GNU autoconf.
The following changes since commit 964668b03d26f0b5baa5e5aff0c966f4fcb76e9e:
Update version for 1.7.0-rc0 release (2013-11-06 21:49:39 -0800)
are available in the git repository at:
git://qemu.weilnetz.de/qemu.git mingw
for you to fetch changes up to 20d155bc902f41c5b354937e730ad85b43614ae9
Hi Serge, you are right. I have reported this issue to redhat. They said that
RHEL 6.5 have removed this option.
https://bugzilla.redhat.com/show_bug.cgi?id=1027074
** Bug watch added: Red Hat Bugzilla #1027074
https://bugzilla.redhat.com/show_bug.cgi?id=1027074
** Summary changed:
- weath
This started out merely to update the i386 target to use the
new tcg_gen_qemu_{ld,st}_{i32,i64,tl} entry points. This goal
is complete around patch 18.
But in the process of doing that, I noticed a lot of room for
cleanup wrt "helper" functions that only obfuscate the goal.
That's primarily what
On 11/06/2013 05:55 AM, Gerd Hoffmann wrote:
Hi,
In QEMU 1.3, there was a DisplayState list. We used one DisplayState per
monitor. The DisplayChangeListener has a new hw_add_display vector, so
that when the UI requests a second monitor the new display gets attached
to the emulated hardware.
Propagate its definition into all users.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index 6b7c89e..f07fca0 100644
--- a/target-i386/translate.c
+++ b/t
Later both qapi-types.py and qapi-visit.py need a common function
for enum name generation.
Signed-off-by: Wenchao Xia
---
scripts/qapi-types.py | 10 --
scripts/qapi.py | 10 ++
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/scripts/qapi-types.py b/sc
By default, any union will automatically generate a enum type as
"[UnionName]Kind" in C code, and it is duplicated when the discriminator
is specified as a pre-defined enum type in schema. After this patch,
the pre-defined enum type will be really used as the switch case
condition in generated C c
This series is respined from RFC series at:
http://lists.nongnu.org/archive/html/qemu-devel/2013-11/msg00363.html
Patch 1-6 add support for enum as discriminator.
Patch 7 improve enum name generation, now AIOContext->AIO_CONTEXT, X86CPU->
X86_CPU.
Patch 8 are the test cases.
Changes from RFC:
M
Later other scripts will need to check the enum values.
Signed-off-by: Wenchao Xia
Reviewed-by: Eric Blake
---
scripts/qapi.py| 18 ++
tests/qapi-schema/comments.out |2 +-
tests/qapi-schema/qapi-schema-test.out |4 +++-
3 files changed,
The SPAPR specification says that the RMA starts at the LPAR's logical
address 0 and is the first logical memory block reported in
the LPAR’s device tree.
So SLOF only maps the first block and that block needs to span
the full RMA.
This makes sure that the RMA area is where SLOF expects it.
Cc:
Changing the domain to TCGMemOp makes it easier to interoperate
with other portions of the rest of the translator.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 180 +++-
1 file changed, 87 insertions(+), 93 deletions(-)
diff --git a/
Use gen_lea_v_seg for centralized segment base knowledge. Unify
code across 32- and 64-bit. Fix note about "must save state"
before using the out-of-line helpers.
Signed-off-by: Richard Henderson
---
target-i386/helper.h | 4 ---
target-i386/seg_helper.c | 68 -
Test for inherit and complex union.
Signed-off-by: Wenchao Xia
---
tests/qapi-schema/qapi-schema-test.json | 25 +
tests/qapi-schema/qapi-schema-test.out | 11 ++
tests/test-qmp-input-visitor.c | 152 +++
tests/test-qmp-output-visitor.c | 172 +
Now "enum AIOContext" will generate AIO_CONTEXT instead of A_I_O_CONTEXT,
"X86CPU" will generate X86_CPU instead of X86_C_P_U.
Signed-off-by: Wenchao Xia
---
include/qapi/qmp/qerror.h |2 +-
scripts/qapi.py | 26 +++---
target-i386/cpu.c |2 +-
3 f
It is possible to reach default case, when an union have a enum
discriminator, so don't abort() but report the error message.
Signed-off-by: Wenchao Xia
---
scripts/qapi-visit.py | 14 --
1 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/scripts/qapi-visit.py b/script
One function one rule, so the enum string generating have same
behavior for different caller. If multiple caller exist for one
enum define in schema, it is for sure the generated string is
identical.
Note before the patch qapi-visit.py used custom function to
generate the string in union visit, al
It will check whether the values specified are written correctly when
discriminator is a pre-defined enum type, which help check whether the
schema is in good form.
It is allowed, that not every value in enum is used, so does not check
that case.
Signed-off-by: Wenchao Xia
---
scripts/qapi-visi
We can use the MO_SIGN bit to tidy the reg-reg switch statement
as well as pass it on to gen_op_ld_v, eliminating one call.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/target-i386/trans
Change the domain of the parameter and update all callers.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index e3b24aa..6b09dea 100644
--- a
Unify the code across stack pointer widths. Fix the note about
not updating ESP before the potential exception.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 29 +++--
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/target-i386/translate.
Propagate the definitions into all users.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 16 +++-
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index bda9ff4..2fa222b 100644
--- a/target-i386/translate
Change the domain of the parameter and update all callers.
Which lets us defer completely to gen_op_mov_reg_v.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 32
1 file changed, 8 insertions(+), 24 deletions(-)
diff --git a/target-i386/translate.
Propagate the definitions into all users. In two cases, this allows
us to share code between the 32-bit and 64-bit immediate moves.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 26 +++---
1 file changed, 3 insertions(+), 23 deletions(-)
diff --git a/target
Serge, I believe the other bug mentioned is this one:
https://bugs.launchpad.net/nova/+bug/1247185
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1248427
Title:
weather qemu-img convert will suppor
Always perform a sign-extending load. In the extremely unlikely
case that we've used an 0x66 prefix, the extension to 64-bits is
unnecessary but not wrong; the store will still examine only 16 bits.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 6 +-
1 file changed, 1 inser
On 11/06/2013 07:17 PM, Michael S. Tsirkin wrote:
> On Wed, Nov 06, 2013 at 04:58:08PM +0800, Jason Wang wrote:
>> We delete without check whether it existed during exit. This will lead NULL
>> pointer deference since it was created conditionally depends on guest driver
>> status and features. So a
For the known MO_32/MO_64 cases, we don't need to extend a 32-bit temp
into a 64-bit temp before storing into the hardware register.
We do need the extension for the MO_8/MO_16 cases, in order for the
deposit_tl operation to work, so leave those alone.
Signed-off-by: Richard Henderson
---
targe
In preference to the older helpers. Stores only in this patch.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 75 ++---
1 file changed, 34 insertions(+), 41 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
i
In preference to the older helpers. Loads only in this patch.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 84 ++---
1 file changed, 31 insertions(+), 53 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
in
On Tue, 2013-11-05 at 19:17 +0800, Amos Kong wrote:
> We currently just update the HMP NIC info when the last bit of macaddr
> is written. This assumes that guest driver will write all the macaddr
> from bit 0 to bit 5 when it changes the macaddr, this is the current
> behavior of linux driver (e10
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 87 -
1 file changed, 36 insertions(+), 51 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index 911f6e8..73ff589 100644
--- a/target-i386/translate.c
+++ b/
Centralize handling of segment bases.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 82 +
1 file changed, 22 insertions(+), 60 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index b588eb9..ec2716d 1006
On 11/05/2013 08:46 PM, Dave Airlie wrote:
On Wed, Nov 6, 2013 at 6:42 AM, John Baboval wrote:
Hello,
I am currently the device model maintainer for XenClient Enterprise. As you
may or may not know, we maintain a patch queue on top of QEMU (currently
1.3) that adds functionality needed to supp
On Wed, 06 Nov 2013 18:20:36 +0900, Michael Tokarev wrote:
06.11.2013 05:54, whitearchey wrote:
For now guest agent uses following command to shutdown system:
shutdown -P +0 "blabla"
but this syntax works only with shutdown command from systemd or upstart,
because SysV shutdown requires -h swi
Replace its users by gen_op_ld_v with the MO_SIGN bit set.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index 1f0c441..42620e8 100644
--- a/target-i
于 2013/11/6 21:33, Eric Blake 写道:
On 11/05/2013 08:20 PM, Wenchao Xia wrote:
+ 'server': {
+ '_base': 'NetworkConnectionInfo',
Interesting idea for shorthand. However, I would suggest that you pick
a different character than '_', since '_' is valid in names. That is,
we already
Propagate its definition into all users.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index 951931c..4d03d53 100644
--- a/target-i386/translate.c
于 2013/11/7 2:50, Max Reitz 写道:
> It should be possible to execute the QMP "drive-mirror" command in
> "none" sync mode and "absolute-paths" mode even for block devices
> lacking a backing file.
>
> "absolute-paths" does in fact not require a backing file to be present,
> as can be seen from the "
Rather than add s->mem_index into a combined size+mem_index
argument, pass the context down. This will allow cleaning
up s->mem_index later.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 331 +---
1 file changed, 170 insertions(+), 16
The reg_ptr and offset_ptr outputs are universally unused.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 141 +++-
1 file changed, 68 insertions(+), 73 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index
Propagate its definition into all users.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 77 +++--
1 file changed, 36 insertions(+), 41 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index e0cf3cb..951931c 1
Propagate the definitions into all users. The only time that
gen_op_movl_T1_imu was used, the input was type 'unsigned',
so the replacement works identically.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 30 ++
1 file changed, 10 insertions(+), 20 d
Propagate the definition of gen_op_movl_T0_im to all users.
The function gen_op_movl_T0_imu was unused.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 32 ++--
1 file changed, 10 insertions(+), 22 deletions(-)
diff --git a/target-i386/translate.c b/ta
More centralization of handling of segment bases.
Also fixes the note about 16-bit wrap around not fully handled.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 50 +++--
1 file changed, 23 insertions(+), 27 deletions(-)
diff --git a/t
These functions used the aflags/dflags domain, which is log2-1
of the byte size. Confusingly, they used enumeration values
from the log2 domain.
Change the domain of the parameter and update all callers.
Since we're now in a common domain, defer the deposit/extend/mov
decision to gen_op_mov_reg_
It sounds like that is an issue in RHEL 6.5. Since the
option exists in 1.6, I don't see this being a valid bug
against qemu.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1248427
Title:
weather q
Quoting Neo (huwei@gmail.com):
> Public bug reported:
>
> In ubuntu os, my qemu-img version is 0.12.0 and its help message show that
> "qemu-img convert" command supports "-s" option, but it disappeared in
> qemu-img 0.12.1. However, though it disappeared, it does support in RHEL6.4,
> and
Remove an unnecessary move opcode.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index af8a27b..60ace71 100644
--- a/target-i386/translate.c
+++ b/target-i386/tr
Merge gen_op_addl_A0_im and gen_op_addq_A0_im into gen_add_A0_im
and clean up the ifdef.
Replace the one remaining user of gen_op_addl_A0_im with gen_add_A0_im.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 27 +--
1 file changed, 5 insertions(+), 22 del
Replace with its definition, via Coccinelle.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index 28587a6..cae0cb5 100644
--- a/target-i386/translate.c
Replace with its definition, via Coccinelle.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 127 +++-
1 file changed, 61 insertions(+), 66 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index c663c6f..dd28d
And make the destination argument explicit.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index 61df97e..af8a27b 100644
--- a/target-i386/transl
Clean up relics of multiple size domains: - MO_16 + 1 => - 1 + 1 => 0.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index f8290b3..61df97e 100644
--- a/targ
Add forgotten zero-extension in the TARGET_X86_64, !CODE64, ss32 case;
use this new function to implement gen_string_movl_A0_EDI,
gen_string_movl_A0_ESI, gen_add_A0_ds_seg.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 159
1 file
Reduce ifdefs, share more code between paths, reduce the number of TCG
ops generated. Avoid re-computing the size of the operation across
gen_pop_T0 and gen_pop_update.
Add forgotten zero-extension in the TARGET_X86_64, !CODE64, ss32 case.
Signed-off-by: Richard Henderson
---
target-i386/trans
Replace with its definition, via Coccinelle.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 111 +++-
1 file changed, 53 insertions(+), 58 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index cae0cb5..5dd68
Changing the domain to TCGMemOp makes it easier to interoperate
with other portions of the rest of the translator.
We now only have one domain for size operands inside the translator,
which makes things less confusing all the way around. There are
still a number of helpers that continue to use th
Centralize computation of a MO_SIZE for the stack pointer.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 43 ++-
1 file changed, 18 insertions(+), 25 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index 529a12
No longer used.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index 2a5879c..0b49a35 100644
--- a/target-i386/translate.c
+++ b/target-i386/translate.c
@@ -376,11 +376,6 @@ st
Replace with its definition, via Coccinelle.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 19 +++
1 file changed, 7 insertions(+), 12 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index dd28d48..28587a6 100644
--- a/target-i386/tra
Replace it with tcg_gen_ext16u_tl, and in two cases merge with a
previous move from cpu_regs.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 33 +
1 file changed, 13 insertions(+), 20 deletions(-)
diff --git a/target-i386/translate.c b/target-i386
Replace with its definition.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index 5dd68e1..2a5879c 100644
--- a/target-i386/translate.c
+++ b/target-i386/tran
I.e. gen_push_v, gen_pop_T0, gen_stack_A0.
More centralization of handling of segment bases.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 49 +++--
1 file changed, 15 insertions(+), 34 deletions(-)
diff --git a/target-i386/translate.
Propagate its definition into all users.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index 746eda1..a382c41 100644
--- a/target-i386/translate
Reduce ifdefs, share more code between paths, reduce the number of TCG
ops generated.
Add forgotten zero-extension in the TARGET_X86_64, !CODE64, ss32 case.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 106 +++-
1 file changed, 32 in
We can now use tcg_gen_qemu_ld_i32 directly to avoid the truncation.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 39 +++
1 file changed, 19 insertions(+), 20 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index
Fix the following run-test-x86_64 testsuite failures:
-lea (%%eax) = 0001
-lea (%%ebx) = 0002
-lea (%%ecx) = 0004
-lea (%%edx) = 0008
-lea (%%esi) = 0010
-lea (%%edi) = 0020
+lea (%%eax) = abcc0001
+lea (%%ebx) = a
Having segs[].base as a register significantly improves code
generation for real and protected modes, particularly for TBs
that have multiple memory references where the segment base
can be held in a hard register through the TB.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 71
Replace it with its definition.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index b8a8954..9a5f704 100644
--- a/target-i386/translate.c
+++
Fold the bswap into the memory operation.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 40 +---
1 file changed, 5 insertions(+), 35 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index 714fb38..c433cc3 100644
---
Unlike the addr32, there was no bug. But we can use the same
technique to reduce the number of TCG ops.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 34 --
1 file changed, 16 insertions(+), 18 deletions(-)
diff --git a/target-i386/translate.c b
For the 16 and 32-bit cases, we don't need to truncate via
a temporary register.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index c433cc3..7b40805 1006
Replace it with its definition.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index 9a5f704..e71b1c0 100644
--- a/target-i386/translate.c
+++ b/target-i386/t
The 'ot' variables (operand type?) hold the log2(byte size) of
the operand being manipulated. This is the same as the MO_SIZE
subset of the TCGMemOp. Indeed, we often pass 'ot' to the
tcg_gen_qemu_ld/st functions.
Changing the type from 'int' makes it easier to see what domain
the variable shoul
Replace it with tcg_gen_ext16u_tl. In four places we can combine that
with a previous move into cpu_T[0], and in one place we can infer that
the zero-extension has already happened via the previous load.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 43 ++---
Propagate its definition into all users.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 83 -
1 file changed, 40 insertions(+), 43 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index 5cf0306..6b7c89e 1
By inspection, obviously we should be storing T[1] not T[0].
This could only happen for x86_64 in 64-bit mode with 0x66
prefix to call insn -- i.e. never.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-i386/
Too many places have the same test vs OR_TMP0 to indicate
a write back to memory. Hoist that to a subroutine.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 85 ++---
1 file changed, 24 insertions(+), 61 deletions(-)
diff --git a/targ
We can now use tcg_gen_qemu_st_i32 directly to avoid the extension.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index e8dadc
Propagate its definition into all users.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 23 +--
1 file changed, 9 insertions(+), 14 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index 4d03d53..1f0c441 100644
--- a/target-i386/tra
Now that we don't combine mem_index with operand size info,
we don't need to encode it. Which tidies many places that
access it.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 67 ++---
1 file changed, 25 insertions(+), 42 deletions(-)
The previous placement could result in duplicate logging while
still processing interrupts.
Signed-off-by: Richard Henderson
---
cpu-exec.c | 36 +++-
1 file changed, 19 insertions(+), 17 deletions(-)
diff --git a/cpu-exec.c b/cpu-exec.c
index 30cfa2a..3c4800f 10
On 11/06/2013 06:04 AM, Juan Quintela wrote:
> We were setting a range of bits, so use bitmap_set().
>
> Note: xen has always been wrong, and should have used start instead
> of addr from the beggining.
s/beggining/beginning/
>
> Signed-off-by: Juan Quintela
> ---
> include/exec/memory-intern
On 11/06/2013 06:04 AM, Juan Quintela wrote:
> Result was always 0, and not used anywhere. Once there, use bool type
> for the parameter.
>
> Signed-off-by: Juan Quintela
> ---
> exec.c | 10 --
> 1 file changed, 4 insertions(+), 6 deletions(-)
For 28-31,
Reviewed-by: Eric Blake
--
On Wed, Nov 6, 2013 at 8:57 PM, Gerd Hoffmann wrote:
> Hi,
>
>> It currently just adds multiple DisplaySurfaces to the QemuConsole,
>> now Gerd said he thought I should be using multiple QemuConsoles but I
>> really didn't think this was a good idea,
>
> Why?
It's a fair question and I haven't
On 11/06/2013 06:04 AM, Juan Quintela wrote:
> And make cpu_physical_memory_get_dirty_flag() to use it. It used to
s/to use/use/
> be the other way around.
>
> Signed-off-by: Juan Quintela
> ---
> include/exec/memory-internal.h | 35 ++-
> 1 file changed, 18 in
On 11/06/2013 06:04 AM, Juan Quintela wrote:
> After all the previous patches, spliting the bitmap gets direct.
>
> ToDo: Why can't i include "exec/memory.h" into cpu-all.h? This is the
> reason that I have duplicated DIRTY_MEMORY_NUM.
>
> ToDo2: current bitmaps have one int as index, this
On 11/06/2013 06:04 AM, Juan Quintela wrote:
> Instead of the bitmap, we use the bitmap number. Once this is done,
> we change all names from dirty_flag to memory regions naming of
> client.
>
> Signed-off-by: Juan Quintela
> ---
> cputlb.c | 4 ++--
> exec.c
On 11/06/2013 06:04 AM, Juan Quintela wrote:
s/clear/clears/ in the subject
> Document it
>
> Signed-off-by: Juan Quintela
> ---
> exec.c | 4 ++--
> include/exec/memory-internal.h | 12 ++--
> 2 files changed, 8 insertions(+), 8 deletions(-)
But the code is c
On Thu, Oct 31, 2013 at 01:21:58PM -0700, Richard Henderson wrote:
> We can and/or/xor/andcm small constants, saving one cycle.
>
> Signed-off-by: Richard Henderson
> ---
> tcg/ia64/tcg-target.c | 64
> +++
> 1 file changed, 34 insertions(+), 30 d
On 11/06/2013 06:04 AM, Juan Quintela wrote:
s/allways dirty/always dirties/ in the subject
> So remove the flag argument and do it directly. After this change, there is
> nothing else using cpu_physical_memory_set_dirty_flags() so remove it.
Any reason you didn't line wrap the commit message?
1 - 100 of 349 matches
Mail list logo
