On 11/06/2013 06:04 AM, Juan Quintela wrote: > After all the previous patches, spliting the bitmap gets direct. > > ToDo: Why can't i include "exec/memory.h" into cpu-all.h? This is the > reason that I have duplicated DIRTY_MEMORY_NUM. > > ToDo2: current bitmaps have one int as index, this limit us to 8TB RAM > guest, Should we move to longs?
Do we still want "ToDo" in the commit message? > > Signed-off-by: Juan Quintela <quint...@redhat.com> > --- > exec.c | 9 ++++++--- > include/exec/cpu-all.h | 4 +++- > include/exec/memory-internal.h | 11 ++++------- > 3 files changed, 13 insertions(+), 11 deletions(-) But the code looks correct. For 14-19, Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature