[Qemu-devel] An issue in block-migration

2013-10-02 Thread Yaodong Yang
Hi all,In block-migration.c file, line 435, if (bdrv_get_dirty(bmds->bs, sector)) {It looks like this "if statement" is used to check whether a chunk is dirty or not. If it is dirty, system will migrate a whole chunk, 1MB data, to the destination. Otherwise, the cur_dirty will increase by 1MB/512B

Re: [Qemu-devel] [PATCH 0/8 RFC] migration: Introduce side channel for RAM

2013-10-02 Thread Lei Li
On 09/26/2013 08:44 PM, Lei Li wrote: On 09/25/2013 11:02 PM, Paolo Bonzini wrote: Il 25/09/2013 16:32, Lei Li ha scritto: This RFC patch series tries to introduce a mechanism using side channel pipe for RAM via SCM_RIGHTS with unix domain socket protocol migration. This side channel will be u

Re: [Qemu-devel] [PATCH V13 10/13] NUMA: add qmp command set-mem-policy to set memory policy for NUMA node

2013-10-02 Thread Marcelo Tosatti
On Tue, Sep 17, 2013 at 11:16:22AM +0800, Wanlong Gao wrote: > This QMP command allows user set guest node's memory policy > through the QMP protocol. The qmp-shell command is like: > set-mem-policy nodeid=0 policy=membind relative=true host-nodes=0-1 > > Reviewed-by: Luiz Capitulino > Signed

Re: [Qemu-devel] [OpenRISC] [PATCH] Correction of the TLB handling of the OpenRISC target

2013-10-02 Thread Jia Liu
On Wed, Oct 2, 2013 at 2:15 PM, Stefan Kristiansson wrote: > On Wed, Oct 2, 2013 at 8:33 AM, Jia Liu wrote: >> >> Hi Sebastian, >> >> On Wed, Oct 2, 2013 at 1:12 PM, Sebastian Macke >> wrote: >> > Hi, >> > >> > this patch corrects two problems for the OpenRISC Target in QEMU. The >> > first >> >

Re: [Qemu-devel] [PATCH] hmp: Print \n after [not inserted]

2013-10-02 Thread Lucas Meneghel Rodrigues
On 10/02/2013 10:08 PM, Lucas Meneghel Rodrigues wrote: I've noticed this when virt-test QEMU monitor protocol code was getting all confused with output like: 'Removable device: not locked, tray closed\n [not inserted](qemu)' Since it was breaking some assumptions on that code. I've fixed the p

Re: [Qemu-devel] [PATCH] Update MAINTAINERS

2013-10-02 Thread Rob Landley
On 10/02/2013 06:40:18 PM, Laurent Vivier wrote: Le 02/10/2013 20:42, Rob Landley a écrit : Laurent Vivier has an m68k gitorious branch to add the q800 target, which I've occasionally tested and would really really like to see finished and merged. Alas, last time I tested it the sucker died

[Qemu-devel] [PATCH] hmp: Print \n after [not inserted]

2013-10-02 Thread Lucas Meneghel Rodrigues
I've noticed this when virt-test QEMU monitor protocol code was getting all confused with output like: 'Removable device: not locked, tray closed\n [not inserted](qemu) ' Since it was breaking some assumptions on that code. I've fixed the prompt matching code to be more lenient, but here the huma

Re: [Qemu-devel] [PATCH] Update MAINTAINERS

2013-10-02 Thread Laurent Vivier
Le 02/10/2013 20:42, Rob Landley a écrit : On 10/02/2013 12:09:58 PM, Anthony Liguori wrote: All of Paul's emails are bouncing and he hasn't been active for some time. ... M68K -M: Paul Brook -S: Odd Fixes +S: Orphan F: target-m68k/ F: hw/m68k/ Laurent Vivier has an m68k gitorious branch

[Qemu-devel] [PULL] Update OpenBIOS images to r1229

2013-10-02 Thread Mark Cave-Ayland
Hi Anthony, The following changes since commit a684f3cf9b9b9c3cb82be87aafc463de8974610c: Merge remote-tracking branch 'kraxel/seabios-1.7.3.2' into staging (2013-09-30 17:15:27 -0500) are available in the git repository at: https://github.com/mcayland/qemu.git qemu-openbios for you to f

[Qemu-devel] 82574/82571 emulation?

2013-10-02 Thread akepner
Hi qemu-devel; We're using qemu to emulate a platform that uses Intel 82574, and 82571 based NICs (which use the e1000e driver). AFAICT, an emulation of 82574/82571 devices is not available in qemu. Couple of questions: 1) is someone already working on a 82574/82571 emulation? (and if so

Re: [Qemu-devel] [PATCH RFC v2 5/9] hw/vfio: set interrupts using pci irq wrappers

2013-10-02 Thread Marcel Apfelbaum
On Wed, 2013-10-02 at 09:58 -0600, Alex Williamson wrote: > On Wed, 2013-10-02 at 15:41 +0300, Marcel Apfelbaum wrote: > > pci_set_irq and the other pci irq wrappers use > > PCI_INTERRUPT_PIN config register to compute device > > INTx pin to assert/deassert. > > > > Save INTx pin into the config r

Re: [Qemu-devel] [PATCH RFC v2 2/9] hw/pci: add pci wrappers for allocating and asserting irqs

2013-10-02 Thread Marcel Apfelbaum
On Wed, 2013-10-02 at 17:21 +0200, Paolo Bonzini wrote: > Il 02/10/2013 14:41, Marcel Apfelbaum ha scritto: > > +static inline void pci_irq_pulse(PCIDevice *pci_dev) > > +{ > > +pci_irq_lower(pci_dev); > > +pci_irq_raise(pci_dev); > > +} > > + > > Why is this in the opposite order, compare

Re: [Qemu-devel] [Bug 1180777] Re: RDP traffic freeze on quiet network

2013-10-02 Thread f3a97
Thanks for the tip Dumitrescu, I'll rive it a try AMD report here che result. Regards Il 29/set/2013 14:50 "Vasile Dumitrescu" ha scritto: > I added a rtl8139c netcard to the VM and connected through it by RDP - > no more freezes. > > It looks like kvm does not play well with virtio network ca

Re: [Qemu-devel] [PATCH 6/8] [PATCH RFC v3] s390-qemu: cpu hotplug - s390 cpu init improvements for hotplug

2013-10-02 Thread Jason J. Herne
On 09/13/2013 11:24 AM, Jason J. Herne wrote: On 09/05/2013 08:28 AM, Andreas Färber wrote: Am 01.08.2013 16:12, schrieb Jason J. Herne: From: "Jason J. Herne" s390_new_cpu is created to encapsulate the creation of a new QOM S390CPU object given a cpuid and a model string. All

Re: [Qemu-devel] [PATCH 5/8] [PATCH RFC v3] s390-qemu: cpu hotplug - ipi_states enhancements

2013-10-02 Thread Jason J. Herne
On 09/19/2013 04:19 PM, Jason J. Herne wrote: On 09/05/2013 08:01 AM, Andreas Färber wrote: Am 01.08.2013 16:12, schrieb Jason J. Herne: From: "Jason J. Herne" ... This is what got us into the link<> discussion last time. If we do for (i = 0; i < ARRAY_SIZE(ipi_states); i++) { name =

Re: [Qemu-devel] [PATCH] coroutine: add ./configure --disable-coroutine-pool

2013-10-02 Thread Stefan Weil
Am 02.10.2013 10:54, schrieb Stefan Hajnoczi: > This is an interesting backtrace. The 'current' thread-local variable > from coroutine-win32.c is NULL or doesn't have a caller assigned. > > Please post 'thread apply all bt' so we can identify the other threads. > > Stefan The other threads don't

[Qemu-devel] [PATCH] util/path: Fix type which is longer than 8 bit for MinGW

2013-10-02 Thread Stefan Weil
While dirent->d_type is 8 bit for most systems, it is 32 bit for MinGW. Reducing it to 8 bit results in a compiler warning because the macro is_dir_maybe compares that 8 bit value with 32 bit constants. Using 'unsigned' instead of 'unsigned char' matches the declaration for MinGW and does not harm

Re: [Qemu-devel] [Qemu-trivial] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized)

2013-10-02 Thread Stefan Weil
Am 02.10.2013 21:02, schrieb Michael Tokarev: > How about this: > > diff --git a/migration.c b/migration.c > index b4f8462..6066ab4 100644 > --- a/migration.c > +++ b/migration.c > @@ -146,22 +146,16 @@ uint64_t migrate_max_downtime(void) > MigrationCapabilityStatusList *qmp_query_migrate_capabili

Re: [Qemu-devel] [Qemu-trivial] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized)

2013-10-02 Thread Michael Tokarev
How about this: diff --git a/migration.c b/migration.c index b4f8462..6066ab4 100644 --- a/migration.c +++ b/migration.c @@ -146,22 +146,16 @@ uint64_t migrate_max_downtime(void) MigrationCapabilityStatusList *qmp_query_migrate_capabilities(Error **errp) { MigrationCapabilityStatusList *he

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3 1/2] tests: Fix schema parser test for in-tree build

2013-10-02 Thread Michael Tokarev
24.09.2013 11:43, arm...@redhat.com wrote: From: Markus Armbruster Commit 4f193e3 added the test, but screwed up in-tree builds (SRCDIR=.): the tests's output overwrites the expected output, and is thus compared to itself. Thanks, applied to the trivial patches queue. The `clean' target for

Re: [Qemu-devel] [PATCH] Update MAINTAINERS

2013-10-02 Thread Rob Landley
On 10/02/2013 12:09:58 PM, Anthony Liguori wrote: All of Paul's emails are bouncing and he hasn't been active for some time. ... M68K -M: Paul Brook -S: Odd Fixes +S: Orphan F: target-m68k/ F: hw/m68k/ Laurent Vivier has an m68k gitorious branch to add the q800 target, which I've occasi

[Qemu-devel] [PATCH] block: use correct filename

2013-10-02 Thread Dunrong Huang
The content filename point to may be erased by qemu_opts_absorb_qdict() in raw_open_common() in drv->bdrv_file_open() So it's better to use bs->filename. Signed-off-by: Dunrong Huang --- block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 93e1

Re: [Qemu-devel] [PATCH] Update MAINTAINERS

2013-10-02 Thread Andreas Färber
Am 02.10.2013 19:09, schrieb Anthony Liguori: > All of Paul's emails are bouncing and he hasn't been active for > some time. > > Signed-off-by: Anthony Liguori > --- > MAINTAINERS | 21 + > 1 file changed, 5 insertions(+), 16 deletions(-) $ echo -n p...@codesourcery.com | md

Re: [Qemu-devel] [PATCH v6 0/5] Do not set SO_REUSEADDR on Windows

2013-10-02 Thread Stefan Weil
Am 02.10.2013 14:28, schrieb Eric Blake: > On 10/02/2013 04:23 AM, Sebastian Ottlik wrote: >> This patchset disables most uses of SO_REUSEADDR on Windows and replaces it with >> calls to the new function socket_set_fast_reuse. On Windows systems the default >> behaviour is equivalent to SO_REUSEADD

[Qemu-devel] [PULL 5/5] util: call socket_set_fast_reuse instead of setting SO_REUSEADDR

2013-10-02 Thread Stefan Weil
From: Sebastian Ottlik SO_REUSEADDR should be avoided on Windows but is desired on other operating systems. So instead of setting it we call socket_set_fast_reuse that will result in the appropriate behaviour on all operating systems. Signed-off-by: Sebastian Ottlik Reviewed-by: Eric Blake Sig

[Qemu-devel] [PULL 3/5] net: call socket_set_fast_reuse instead of setting SO_REUSEADDR

2013-10-02 Thread Stefan Weil
From: Sebastian Ottlik SO_REUSEADDR should be avoided on Windows but is desired on other operating systems. So instead of setting it we call socket_set_fast_reuse that will result in the appropriate behaviour on all operating systems. An exception to this rule are multicast sockets where it is s

[Qemu-devel] [PULL 1/5] util: add socket_set_fast_reuse function which will replace setting SO_REUSEADDR

2013-10-02 Thread Stefan Weil
From: Sebastian Ottlik If a socket is closed it remains in TIME_WAIT state for some time. On operating systems using BSD sockets the endpoint of the socket may not be reused while in this state unless SO_REUSEADDR was set on the socket. On windows on the other hand the default behaviour is to all

[Qemu-devel] [PULL 2/5] gdbstub: call socket_set_fast_reuse instead of setting SO_REUSEADDR

2013-10-02 Thread Stefan Weil
From: Sebastian Ottlik SO_REUSEADDR should be avoided on Windows but is desired on other operating systems. So instead of setting it we call socket_set_fast_reuse that will result in the appropriate behaviour on all operating systems. Signed-off-by: Sebastian Ottlik Reviewed-by: Eric Blake Sig

[Qemu-devel] [PULL 4/5] slirp: call socket_set_fast_reuse instead of setting SO_REUSEADDR

2013-10-02 Thread Stefan Weil
From: Sebastian Ottlik SO_REUSEADDR should be avoided on Windows but is desired on other operating systems. So instead of setting it we call socket_set_fast_reuse that will result in the appropriate behaviour on all operating systems. Signed-off-by: Sebastian Ottlik Reviewed-by: Eric Blake Sig

[Qemu-devel] [PULL 0/5] net: Add and use new function socket_set_fast_reuse

2013-10-02 Thread Stefan Weil
The following changes since commit a684f3cf9b9b9c3cb82be87aafc463de8974610c: Merge remote-tracking branch 'kraxel/seabios-1.7.3.2' into staging (2013-09-30 17:15:27 -0500) are available in the git repository at: git://qemu.weilnetz.de/qemu.git mingw for you to fetch changes up to 04fd1c78

Re: [Qemu-devel] ioh3420: Add a map_irq function

2013-10-02 Thread Alexander Duyck
On 10/02/2013 10:12 AM, Alex Williamson wrote: > On Fri, 2013-09-27 at 15:10 -0700, Alexander Duyck wrote: >> On 02/28/2013 10:49 AM, Alex Williamson wrote: >>> Every bridge needs to know how to map IRQs from it's secondary bus to >>> the primary bus. We seem to be direct mapped on ioh3420. This

[Qemu-devel] [Bug 1233225] Re: mips/mipsel linux user float division problem

2013-10-02 Thread Johannes Schauer
For system emulation I used the default which is malta. cheers, josch -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1233225 Title: mips/mipsel linux user float division problem Status in QEMU:

Re: [Qemu-devel] ioh3420: Add a map_irq function

2013-10-02 Thread Alex Williamson
On Fri, 2013-09-27 at 15:10 -0700, Alexander Duyck wrote: > On 02/28/2013 10:49 AM, Alex Williamson wrote: > > Every bridge needs to know how to map IRQs from it's secondary bus to > > the primary bus. We seem to be direct mapped on ioh3420. This avoids > > segfaults when trying to put assigned d

Re: [Qemu-devel] [PATCHv3 20/20] block/raw: copy BlockLimits on raw_open

2013-10-02 Thread Eric Blake
On 09/24/2013 07:35 AM, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > block/raw_bsd.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/block/raw_bsd.c b/block/raw_bsd.c > index 8dc7bba..7af26ad 100644 > --- a/block/raw_bsd.c > +++ b/block/raw_bsd.c > @@ -159,6 +159,7 @@ st

[Qemu-devel] [PATCH] Update MAINTAINERS

2013-10-02 Thread Anthony Liguori
All of Paul's emails are bouncing and he hasn't been active for some time. Signed-off-by: Anthony Liguori --- MAINTAINERS | 21 + 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 5c3c70c..ab8166a 100644 --- a/MAINTAINERS +++ b/MAI

Re: [Qemu-devel] [PATCH] block/iscsi: reenable iscsi_co_get_block_status

2013-10-02 Thread Stefan Weil
Am 02.10.2013 13:52, schrieb Peter Lieven: > Commit f35c934a accidently disabled iscsi_co_get_block_status for all > libiscsi versions. Its not possible to check for enumeration constants > in the C preprocessor. This patch changes the check to the preprocessor > constant LIBISCSI_FEATURE_IOVECTOR

Re: [Qemu-devel] [PATCHv3 18/20] qemu-img: add support for fully allocated images

2013-10-02 Thread Eric Blake
On 09/24/2013 07:35 AM, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > qemu-img.c |8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) Missing a counterpart change to qemu-img.texi. > > diff --git a/qemu-img.c b/qemu-img.c > index 926f0a0..c6eff15 100644 > --- a/qemu-i

Re: [Qemu-devel] [PATCHv3 13/20] block: introduce bdrv_zeroize

2013-10-02 Thread Eric Blake
On 09/24/2013 07:35 AM, Peter Lieven wrote: > this patch adds a call to completely zero out a block device. > the operation is sped up by checking the block status and > only writing zeroes to the device if they currently do not > return zeroes. optionally the zero writing can be sped up > by setti

Re: [Qemu-devel] [PATCHv3 11/20] iscsi: add bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes

2013-10-02 Thread Eric Blake
On 09/24/2013 07:35 AM, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > block/iscsi.c | 16 +++- > 1 file changed, 15 insertions(+), 1 deletion(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libv

Re: [Qemu-devel] [PATCHv3 10/20] iscsi: set limits in BlockDriverState

2013-10-02 Thread Eric Blake
On 09/24/2013 07:35 AM, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > block/iscsi.c | 14 ++ > 1 file changed, 14 insertions(+) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature

Re: [Qemu-devel] [PATCHv3 08/20] block: honour BlockLimits in bdrv_co_discard

2013-10-02 Thread Eric Blake
On 09/24/2013 07:35 AM, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > block.c | 37 - > 1 file changed, 36 insertions(+), 1 deletion(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization libr

Re: [Qemu-devel] [PATCHv3 07/20] block: honour BlockLimits in bdrv_co_do_write_zeroes

2013-10-02 Thread Eric Blake
On 09/24/2013 07:35 AM, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > block.c | 65 > +++ > 1 file changed, 49 insertions(+), 16 deletions(-) > > diff --git a/block.c b/block.c > index ac35cb5..580570a 100644 > --- a/bloc

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/9pfs: Fix errno value for xattr functions

2013-10-02 Thread Michael Tokarev
01.10.2013 15:28, Daniel P. Berrange пишет: From: "Daniel P. Berrange" If there is no operation driver for the xattr type the functions return '-1' and set errno to '-EOPNOTSUPP'. When the calling code sets 'ret = -errno' this turns into a large positive number. In Linux 3.11, the kernel has s

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vl: Clean up unnecessary boot_order complications

2013-10-02 Thread Michael Tokarev
01.10.2013 15:47, arm...@redhat.com пишет: From: Markus Armbruster Messed up in commit 8281abd. Thanks, applied to the trivial patches queue. /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-char: Fix potential out of bounds access to local arrays

2013-10-02 Thread Michael Tokarev
01.10.2013 01:04, Stefan Weil wrote: Latest gcc-4.8 supports a new option -fsanitize=address which activates an AddressSanitizer. This AddressSanitizer stops the QEMU system emulation very early because two character arrays of size 8 are potentially written with 9 bytes. Commit 6ea314d91439741e9

Re: [Qemu-devel] [PATCH v3 uq/master 2/2] x86: cpuid: reconstruct leaf 0Dh data

2013-10-02 Thread Gleb Natapov
On Wed, Oct 02, 2013 at 05:54:57PM +0200, Paolo Bonzini wrote: > The data in leaf 0Dh depends on information from other feature bits. > Instead of passing it blindly from the host, compute it based on > whether these feature bits are enabled. > Applied both. Thanks. > Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH RFC v2 0/9] hw/pci: set irq without selecting INTx pin

2013-10-02 Thread Alex Williamson
On Wed, 2013-10-02 at 16:05 +0300, Marcel Apfelbaum wrote: > On Wed, 2013-10-02 at 15:58 +0300, Michael S. Tsirkin wrote: > > On Wed, Oct 02, 2013 at 03:41:25PM +0300, Marcel Apfelbaum wrote: > > > Note: Added RFC because not all affected devices were > > > checked yet. > > > > What do you

Re: [Qemu-devel] [PATCHv4] block/get_block_status: avoid redundant callouts on raw devices

2013-10-02 Thread Peter Lieven
Am 02.10.2013 17:13, schrieb Paolo Bonzini: > Il 02/10/2013 17:06, Stefan Hajnoczi ha scritto: >> Sorry I didn't review this earlier but this flag looks hacky and I'm not >> confident about merging the patch yet. >> >> The patch makes me wonder if the raw_bsd driver should avoid calling >> bs->file

Re: [Qemu-devel] [PATCH RFC v2 5/9] hw/vfio: set interrupts using pci irq wrappers

2013-10-02 Thread Alex Williamson
On Wed, 2013-10-02 at 15:41 +0300, Marcel Apfelbaum wrote: > pci_set_irq and the other pci irq wrappers use > PCI_INTERRUPT_PIN config register to compute device > INTx pin to assert/deassert. > > Save INTx pin into the config register before calling > pci_set_irq > > Signed-off-by: Marcel Apfelb

Re: [Qemu-devel] [PATCH] block/iscsi: introduce bdrv_co_{readv, writev, flush_to_disk}

2013-10-02 Thread Peter Lieven
Am 02.10.2013 17:55, schrieb Paolo Bonzini: > Il 02/10/2013 17:54, Peter Lieven ha scritto: I'm not sure it's already the time for this... Cancellation sucks in QEMU, and this is going to make things even worse. >> Ok, I was not aware. I talked with Kevin about this some months ago >> an

Re: [Qemu-devel] [PATCH] block/iscsi: introduce bdrv_co_{readv, writev, flush_to_disk}

2013-10-02 Thread Paolo Bonzini
Il 02/10/2013 17:54, Peter Lieven ha scritto: >> > I'm not sure it's already the time for this... Cancellation sucks in >> > QEMU, and this is going to make things even worse. > Ok, I was not aware. I talked with Kevin about this some months ago > and promised (list CCed) to prepare this for 1.7.0

[Qemu-devel] [PATCH v3 uq/master 2/2] x86: cpuid: reconstruct leaf 0Dh data

2013-10-02 Thread Paolo Bonzini
The data in leaf 0Dh depends on information from other feature bits. Instead of passing it blindly from the host, compute it based on whether these feature bits are enabled. Signed-off-by: Paolo Bonzini --- target-i386/cpu.c | 65 --- 1 file ch

Re: [Qemu-devel] [PATCH] block/iscsi: introduce bdrv_co_{readv, writev, flush_to_disk}

2013-10-02 Thread Peter Lieven
Am 02.10.2013 17:46, schrieb Paolo Bonzini: > Il 02/10/2013 17:41, Peter Lieven ha scritto: >> this converts read, write and flush functions from aio to coroutines. > I'm not sure it's already the time for this... Cancellation sucks in > QEMU, and this is going to make things even worse. Ok, I was

Re: [Qemu-devel] [PATCHv3 06/20] block: add BlockLimits structure to BlockDriverState

2013-10-02 Thread Eric Blake
On 09/24/2013 07:35 AM, Peter Lieven wrote: > this patch adds BlockLimits which introduces discard and write_zeroes > limits and alignment information to the BlockDriverState. > > Signed-off-by: Peter Lieven > --- > include/block/block_int.h | 17 + > 1 file changed, 17 inserti

Re: [Qemu-devel] [PATCH] block/iscsi: introduce bdrv_co_{readv, writev, flush_to_disk}

2013-10-02 Thread Paolo Bonzini
Il 02/10/2013 17:41, Peter Lieven ha scritto: > this converts read, write and flush functions from aio to coroutines. I'm not sure it's already the time for this... Cancellation sucks in QEMU, and this is going to make things even worse. Paolo > Signed-off-by: Peter Lieven > --- > block/iscsi

Re: [Qemu-devel] [PATCHv3 05/20] block/raw: add bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes

2013-10-02 Thread Eric Blake
On 09/24/2013 07:34 AM, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > block/raw_bsd.c | 56 > +-- > 1 file changed, 34 insertions(+), 22 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3

Re: [Qemu-devel] [PATCH V4] block: Add BlockDriver.bdrv_check_ext_snapshot.

2013-10-02 Thread Eric Blake
On 10/02/2013 09:33 AM, Max Reitz wrote: > On 2013-10-02 14:33, Benoît Canet wrote: >> This field is used by blkverify to disable external snapshots creation. >> I will also be used by block filters like quorum to disable external >> snapshots >> creation. > Oh, I nearly missed it: s/I will also be

Re: [Qemu-devel] [PATCHv3 04/20] block: introduce bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes

2013-10-02 Thread Eric Blake
On 09/24/2013 07:34 AM, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > block.c | 29 + > include/block/block.h |2 ++ > include/block/block_int.h | 13 + > 3 files changed, 44 insertions(+) > Reviewed-by: Eric Blak

[Qemu-devel] [PATCH] block/iscsi: introduce bdrv_co_{readv, writev, flush_to_disk}

2013-10-02 Thread Peter Lieven
this converts read, write and flush functions from aio to coroutines. Signed-off-by: Peter Lieven --- block/iscsi.c | 405 +++-- 1 file changed, 107 insertions(+), 298 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 5c7baee..f37

Re: [Qemu-devel] [PATCH v2 uq/master 2/2] x86: cpuid: reconstruct leaf 0Dh data

2013-10-02 Thread Gleb Natapov
On Wed, Oct 02, 2013 at 05:37:31PM +0200, Paolo Bonzini wrote: > Il 02/10/2013 17:21, Gleb Natapov ha scritto: > >> -if (kvm_enabled()) { > >> -KVMState *s = cs->kvm_state; > >> +kvm_mask = > >> +kvm_arch_get_supported_cpuid(s, 0xd, 0, R_EAX) | > >> +

Re: [Qemu-devel] [PATCH v2 uq/master 2/2] x86: cpuid: reconstruct leaf 0Dh data

2013-10-02 Thread Paolo Bonzini
Il 02/10/2013 17:21, Gleb Natapov ha scritto: >> -if (kvm_enabled()) { >> -KVMState *s = cs->kvm_state; >> +kvm_mask = >> +kvm_arch_get_supported_cpuid(s, 0xd, 0, R_EAX) | >> +((uint64_t)kvm_arch_get_supported_cpuid(s, 0xd, 0, R_EDX) << >> 32); >

Re: [Qemu-devel] [PATCH V4] block: Add BlockDriver.bdrv_check_ext_snapshot.

2013-10-02 Thread Max Reitz
On 2013-10-02 14:33, Benoît Canet wrote: This field is used by blkverify to disable external snapshots creation. I will also be used by block filters like quorum to disable external snapshots creation. Signed-off-by: Benoit Canet --- block.c | 17 + block/bl

Re: [Qemu-devel] [PATCHv4] block/get_block_status: avoid redundant callouts on raw devices

2013-10-02 Thread Peter Lieven
Am 02.10.2013 17:13, schrieb Paolo Bonzini: > Il 02/10/2013 17:06, Stefan Hajnoczi ha scritto: >> Sorry I didn't review this earlier but this flag looks hacky and I'm not >> confident about merging the patch yet. >> >> The patch makes me wonder if the raw_bsd driver should avoid calling >> bs->file

Re: [Qemu-devel] [PATCH V4] block: Add BlockDriver.bdrv_check_ext_snapshot.

2013-10-02 Thread Max Reitz
On 2013-10-02 14:33, Benoît Canet wrote: This field is used by blkverify to disable external snapshots creation. I will also be used by block filters like quorum to disable external snapshots creation. Oh, I nearly missed it: s/I will also be/It will also be/ and probably s/external snapshots cr

Re: [Qemu-devel] [PATCHv3 02/20] block: add flags to bdrv_*_write_zeroes

2013-10-02 Thread Eric Blake
On 09/24/2013 07:34 AM, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > block-migration.c |2 +- > block.c | 20 +++- > block/backup.c|3 ++- > block/qcow2-cluster.c |2 +- > block/qcow2.c |2 +- > b

Re: [Qemu-devel] [PATCH v2 0/6] Improve getauxval support

2013-10-02 Thread Richard Henderson
On 10/01/2013 06:42 PM, Peter Maydell wrote: > On 2 October 2013 06:25, Richard Henderson wrote: >> Ping. > > Does this need updating now that commit 03cfd8faa (which manually > walks through the auxval in get_execfd()) has been committed? Well, such a patch could be added to the series, but it

Re: [Qemu-devel] [PATCH v2 uq/master 2/2] x86: cpuid: reconstruct leaf 0Dh data

2013-10-02 Thread Gleb Natapov
On Fri, Sep 13, 2013 at 03:55:58PM +0200, Paolo Bonzini wrote: > The data in leaf 0Dh depends on information from other feature bits. > Instead of passing it blindly from the host, compute it based on > whether these feature bits are enabled. > > Signed-off-by: Paolo Bonzini > --- > target-i386/

Re: [Qemu-devel] [PATCH RFC v2 2/9] hw/pci: add pci wrappers for allocating and asserting irqs

2013-10-02 Thread Paolo Bonzini
Il 02/10/2013 14:41, Marcel Apfelbaum ha scritto: > +static inline void pci_irq_pulse(PCIDevice *pci_dev) > +{ > +pci_irq_lower(pci_dev); > +pci_irq_raise(pci_dev); > +} > + Why is this in the opposite order, compared to qemu_irq_pulse? Paolo

Re: [Qemu-devel] [PATCHv4] block/get_block_status: avoid redundant callouts on raw devices

2013-10-02 Thread Paolo Bonzini
Il 02/10/2013 17:06, Stefan Hajnoczi ha scritto: > Sorry I didn't review this earlier but this flag looks hacky and I'm not > confident about merging the patch yet. > > The patch makes me wonder if the raw_bsd driver should avoid calling > bs->file itself: > > return BDRV_BLOCK_DATA | BDRV_BLOCK_

Re: [Qemu-devel] [PATCHv4] block/get_block_status: avoid redundant callouts on raw devices

2013-10-02 Thread Eric Blake
On 10/02/2013 08:20 AM, Peter Lieven wrote: > if a raw device like an iscsi target or host device is used > the current implementation makes a second call out to get > the block status of bs->file. however, the raw driver already > has called bdrv_get_block_status on bs->file. > > v4: use a flag t

Re: [Qemu-devel] [PATCHv4] block/get_block_status: avoid redundant callouts on raw devices

2013-10-02 Thread Stefan Hajnoczi
On Wed, Oct 02, 2013 at 04:20:36PM +0200, Peter Lieven wrote: > if a raw device like an iscsi target or host device is used > the current implementation makes a second call out to get > the block status of bs->file. however, the raw driver already > has called bdrv_get_block_status on bs->file. >

[Qemu-devel] [PATCH] qemu-iotests: Correct 026 output

2013-10-02 Thread Max Reitz
Because l2_allocate now frees the unused L2 cluster on error, the according test cases in 026 don't result in one leaked cluster anymore. Signed-off-by: Max Reitz --- This patch depends on and is a follow-up to "qcow2: Free allocated L2 cluster on error" which was part of the "qcow2: Small error

Re: [Qemu-devel] [PATCH RFC 10/11] s390/qemu: cpu model QMP query-cpu-model

2013-10-02 Thread Michael Mueller
On Wed, 02 Oct 2013 06:06:32 -0600 Eric Blake wrote: > On 10/02/2013 05:33 AM, Michael Mueller wrote: > > This patch implements a new QMP request named "cpu-model". It returns > > the cpu model of cpu 0. eg: > > > > request: '{"execute" : "query-cpu-model" } > > answer: '{"return" : "2817-ga1"

[Qemu-devel] [PATCHv4] block/get_block_status: avoid redundant callouts on raw devices

2013-10-02 Thread Peter Lieven
if a raw device like an iscsi target or host device is used the current implementation makes a second call out to get the block status of bs->file. however, the raw driver already has called bdrv_get_block_status on bs->file. v4: use a flag to detect the raw driver instead of the strncmp hack.

Re: [Qemu-devel] [PATCH -V4 RESEND 0/6] target-ppc: Add support for dumping guest memory using qemu gdb server

2013-10-02 Thread Alexander Graf
On 01.10.2013, at 18:19, Aneesh Kumar K.V wrote: > Hi, > > This patch series implement support for dumping guest memory using qemu gdb > server. The last patch also enable qemu monitor command dump-guest-memory Thanks, applied all but 2/6 to ppc-next. I think the core dump bits should be more

Re: [Qemu-devel] [PATCH v7 00/27] qemu: generate acpi tables for the guest

2013-10-02 Thread Michael S. Tsirkin
On Wed, Oct 02, 2013 at 03:52:17PM +0200, Igor Mammedov wrote: > On Wed, 2 Oct 2013 16:30:36 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Oct 02, 2013 at 03:05:52PM +0200, Igor Mammedov wrote: > > > On Wed, 2 Oct 2013 00:26:11 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > This code

Re: [Qemu-devel] [PATCH -V4 2/4] target-ppc: Fix page table lookup with kvm enabled

2013-10-02 Thread Alexander Graf
On 01.10.2013, at 03:27, Aneesh Kumar K.V wrote: > Alexander Graf writes: > >> On 09/05/2013 10:16 AM, Aneesh Kumar K.V wrote: >>> From: "Aneesh Kumar K.V" >>> >>> With kvm enabled, we store the hash page table information in the >>> hypervisor. >>> Use ioctl to read the htab contents. Withou

Re: [Qemu-devel] [PATCH v7 00/27] qemu: generate acpi tables for the guest

2013-10-02 Thread Igor Mammedov
On Wed, 2 Oct 2013 16:30:36 +0300 "Michael S. Tsirkin" wrote: > On Wed, Oct 02, 2013 at 03:05:52PM +0200, Igor Mammedov wrote: > > On Wed, 2 Oct 2013 00:26:11 +0300 > > "Michael S. Tsirkin" wrote: > > > > > This code can also be found here: > > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.g

[Qemu-devel] [Bug 1234179] [NEW] QEMU segfaults during Windows 7 unattended install

2013-10-02 Thread Lucas Meneghel Rodrigues
Public bug reported: During today's automated qemu.git testing, a segmentation fault while installing Windows 7 SP1 happened. qemu.git top commit: 10/02 01:30:24 INFO | git:0150| git commit ID is a684f3cf9b9b9c3cb82be87aafc463de8974610c (tag v1.4.0-4237-ga684f3c) commit a684f3cf9b9b9c3cb

Re: [Qemu-devel] [PATCH] block: use correct filename for error report

2013-10-02 Thread Dunrong Huang
On Wed, Oct 2, 2013 at 5:48 PM, Stefan Hajnoczi wrote: > On Tue, Sep 24, 2013 at 06:14:01PM +0800, Dunrong Huang wrote: > > The content filename point to will be erased by qemu_opts_absorb_qdict() > > in raw_open_common() in drv->bdrv_file_open() > > > > So it's better to use bs->filename. > > >

Re: [Qemu-devel] [PATCH] qcow2: Switch L1 table in a single sequence

2013-10-02 Thread Stefan Hajnoczi
On Mon, Sep 30, 2013 at 05:57:21PM +0200, Max Reitz wrote: > Switching the L1 table in memory should be an atomic operation, as far > as possible. Calling qcow2_free_clusters on the old L1 table on disk is > not a good idea when the old L1 table is no longer valid and the address > to the new one h

Re: [Qemu-devel] [PATCH v7 00/27] qemu: generate acpi tables for the guest

2013-10-02 Thread Michael S. Tsirkin
On Wed, Oct 02, 2013 at 03:05:52PM +0200, Igor Mammedov wrote: > On Wed, 2 Oct 2013 00:26:11 +0300 > "Michael S. Tsirkin" wrote: > > > This code can also be found here: > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi > > > > While this patch still uses info not available in QOM, I th

Re: [Qemu-devel] [PATCH V3 0/7] qcow2: rollback the modification on fail in snapshot creation

2013-10-02 Thread Stefan Hajnoczi
On Mon, Sep 09, 2013 at 10:57:55AM +0800, Wenchao Xia wrote: > V2: > 1: all fail case will goto fail section. > 2: add the goto code. > v3: > Address Stefan's comments: > 2: don't goto fail after allocation failure. > 3: use sn->l1size correctly in qcow2_free_cluster(). > 4-7: add test

Re: [Qemu-devel] [PATCH V3 1/7] qcow2: restore nb_snapshots when fail in snapshot creation

2013-10-02 Thread Stefan Hajnoczi
On Mon, Sep 09, 2013 at 10:57:56AM +0800, Wenchao Xia wrote: > If it is not restored after qcow2_write_snapshots() fail, a core > dump will happen in bdrv_close() since access of invalid pointer. > > Signed-off-by: Wenchao Xia > --- > block/qcow2-snapshot.c |4 +++- > 1 files changed, 3 inse

Re: [Qemu-devel] [PATCH] block: vhdx - add migration blocker

2013-10-02 Thread Stefan Hajnoczi
On Tue, Oct 01, 2013 at 11:59:20AM -0400, Jeff Cody wrote: > This blocks migration for VHDX image files, until the > functionality can be supported. > > Signed-off-by: Jeff Cody > --- > block/vhdx.c | 10 ++ > 1 file changed, 10 insertions(+) Strictly speaking live migration is safe sin

Re: [Qemu-devel] [PATCH v7 00/27] qemu: generate acpi tables for the guest

2013-10-02 Thread Igor Mammedov
On Wed, 2 Oct 2013 00:26:11 +0300 "Michael S. Tsirkin" wrote: > This code can also be found here: > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi > > While this patch still uses info not available in QOM, I think it's reasonable > to merge it and then refactor as QOM properties cover m

Re: [Qemu-devel] [PATCH 1/7] usb: remove old usb-host code

2013-10-02 Thread Jan Kiszka
On 2013-09-19 11:34, Gerd Hoffmann wrote: > The usb-host code has been rewritten for qemu 1.5 to use libusb, > the old code has been left in as temporary fallback. Now we are > two releases further out, targeting the 1.7 release. No major > issues with the new code poped up until now. Time to re

Re: [Qemu-devel] [Bug 1233225] Re: mips/mipsel linux user float division problem

2013-10-02 Thread Peter Maydell
On 2 October 2013 14:22, Stefan Weil wrote: > The original bug report said that it runs in QEMU system emulation > (which I did not test because of lack of time). As system emulation > uses the same cpu, it should be fine. ...that's what prompted me to ask, actually -- system emulation will pick

Re: [Qemu-devel] [PATCH v2 0/9] target-s390 tcg improvements

2013-10-02 Thread Alexander Graf
On 01.10.2013, at 19:17, Richard Henderson wrote: > Changes v1-v2: > * Squashed patches 1, 2, 4. The feedback from patch 1 called for a >re-ordering of the patch set to better deal with STFL, but I could >not find an ordering that worked well. I think this is probably >just as clea

Re: [Qemu-devel] [PATCH RFC v2 1/9] hw/core: Add interface to allocate and free a single IRQ

2013-10-02 Thread Michael S. Tsirkin
On Wed, Oct 02, 2013 at 03:41:26PM +0300, Marcel Apfelbaum wrote: > qemu_allocate_irq returns a single qemu_irq. > The interface allows to specify an interrupt number. > > qemu_free_irq frees it. > > Signed-off-by: Marcel Apfelbaum > --- > hw/core/irq.c| 16 > include/hw/ir

Re: [Qemu-devel] [PATCH RFC v2 0/9] hw/pci: set irq without selecting INTx pin

2013-10-02 Thread Marcel Apfelbaum
On Wed, 2013-10-02 at 15:58 +0300, Michael S. Tsirkin wrote: > On Wed, Oct 02, 2013 at 03:41:25PM +0300, Marcel Apfelbaum wrote: > > Note: Added RFC because not all affected devices were > > checked yet. > > What do you have in mind exactly? Sanity test for *all* modified devices. Any other

[Qemu-devel] [PATCH V9 03/11] quorum: Add quorum_aio_writev and its dependencies.

2013-10-02 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 123 + 1 file changed, 123 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 9557e61..b49e3c6 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -64,11 +64,134 @@ struct Quoru

Re: [Qemu-devel] [PATCH RFC v2 2/9] hw/pci: add pci wrappers for allocating and asserting irqs

2013-10-02 Thread Marcel Apfelbaum
On Wed, 2013-10-02 at 15:54 +0300, Michael S. Tsirkin wrote: > On Wed, Oct 02, 2013 at 03:41:27PM +0300, Marcel Apfelbaum wrote: > > Interrupt pin is selected and saved into PCI_INTERRUPT_PIN > > register during device initialization. Devices should not call > > directly qemu_set_irq and specify th

[Qemu-devel] [PATCH RFC v2 0/9] hw/pci: set irq without selecting INTx pin

2013-10-02 Thread Marcel Apfelbaum
Note: Added RFC because not all affected devices were checked yet. Interrupt pin is selected and saved into PCI_INTERRUPT_PIN register during device initialization. Devices should not call directly qemu_set_irq and specify the INTx pin. Added pci_* wrappers to replace qemu_set_irq, qemu_ir

Re: [Qemu-devel] [PATCH] block/qcow2: Use bdrv_truncate for size amend

2013-10-02 Thread Max Reitz
On 2013-10-02 14:32, Stefan Hajnoczi wrote: On Mon, Sep 09, 2013 at 12:17:41PM +0200, Max Reitz wrote: When amending the size option for a qcow2 image, use bdrv_truncate instead of qcow2_truncate directly, since the latter will not adjust the total_sectors count in the BDS structure (whereas the

[Qemu-devel] [PATCH RFC v2 5/9] hw/vfio: set interrupts using pci irq wrappers

2013-10-02 Thread Marcel Apfelbaum
pci_set_irq and the other pci irq wrappers use PCI_INTERRUPT_PIN config register to compute device INTx pin to assert/deassert. Save INTx pin into the config register before calling pci_set_irq Signed-off-by: Marcel Apfelbaum --- hw/misc/vfio.c | 11 ++- 1 file changed, 6 insertions(+),

[Qemu-devel] [PATCH RFC v2 9/9] hw/pci: removed irq field from PCIDevice

2013-10-02 Thread Marcel Apfelbaum
Instead of exposing the the irq field, pci wrappers to qemu_set_irq or qemu_irq_* can be used. Signed-off-by: Marcel Apfelbaum --- hw/pci/pci.c | 2 -- include/hw/pci/pci.h | 3 --- 2 files changed, 5 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index fbfd8f7..f8d0b81 100644 --

Re: [Qemu-devel] [PATCH RFC v2 0/9] hw/pci: set irq without selecting INTx pin

2013-10-02 Thread Michael S. Tsirkin
On Wed, Oct 02, 2013 at 03:41:25PM +0300, Marcel Apfelbaum wrote: > Note: Added RFC because not all affected devices were > checked yet. What do you have in mind exactly? > Interrupt pin is selected and saved into PCI_INTERRUPT_PIN > register during device initialization. Devices should no

Re: [Qemu-devel] [PATCH RFC v2 2/9] hw/pci: add pci wrappers for allocating and asserting irqs

2013-10-02 Thread Michael S. Tsirkin
On Wed, Oct 02, 2013 at 03:41:27PM +0300, Marcel Apfelbaum wrote: > Interrupt pin is selected and saved into PCI_INTERRUPT_PIN > register during device initialization. Devices should not call > directly qemu_set_irq and specify the INTx pin on each call. > > Added pci_* wrappers to replace qemu_se

[Qemu-devel] [PATCH RFC v2 8/9] hw/pcie: AER and hot-plug events must use device's interrupt

2013-10-02 Thread Marcel Apfelbaum
The fields hpev_intx and aer_intx were removed because both AER and hot-plug events must use device's interrupt. Assert/deassert interrupts using pci_set_irq wrapper instead. Signed-off-by: Marcel Apfelbaum --- hw/pci/pcie.c | 4 ++-- hw/pci/pcie_aer.c | 4 ++-- include/hw/pci/pcie

  1   2   >