On Mon, Sep 30, 2013 at 05:57:21PM +0200, Max Reitz wrote: > Switching the L1 table in memory should be an atomic operation, as far > as possible. Calling qcow2_free_clusters on the old L1 table on disk is > not a good idea when the old L1 table is no longer valid and the address > to the new one hasn't yet been written into the corresponding > BDRVQcowState field. To be more specific, this can lead to segfaults due > to qcow2_check_metadata_overlap trying to access the L1 table during the > free operation. > > Signed-off-by: Max Reitz <mre...@redhat.com> > --- > block/qcow2-cluster.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-)
Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan