Re: [Qemu-devel] [RFC] sanitize memory on system reset

2013-06-13 Thread Christian Borntraeger
On 13/06/13 13:56, Anthony Liguori wrote: > Markus Armbruster writes: > >> Peter Lieven writes: >> >>> On 13.06.2013 10:40, Stefan Hajnoczi wrote: On Thu, Jun 13, 2013 at 08:09:09AM +0200, Peter Lieven wrote: > I was thinking if it would be a good idea to zeroize all memory > resour

Re: [Qemu-devel] [PATCH] fix some printf errors when debug is enabled

2013-06-13 Thread Hu Tao
On Thu, Jun 13, 2013 at 01:10:04PM +0200, Andreas Färber wrote: > Am 13.06.2013 12:51, schrieb Hu Tao: > > Signed-off-by: Hu Tao > > --- > > cputlb.c| 4 ++-- > > hw/acpi/piix4.c | 6 +++--- > > 2 files changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/cputlb.c b/cputlb.c > >

[Qemu-devel] [PATCH 2/2] q35: use type-safe cast instead of directly access of parent dev

2013-06-13 Thread Hu Tao
And remove variables if possible. Signed-off-by: Hu Tao --- hw/pci-host/q35.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c index 24df6b5..efe96d0 100644 --- a/hw/pci-host/q35.c +++ b/hw/pci-host/q3

[Qemu-devel] [PATCH 1/2] piix: use type-safe cast instead of directly access of parent dev

2013-06-13 Thread Hu Tao
Signed-off-by: Hu Tao --- hw/pci-host/piix.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index f9e68c3..ba9a8f0 100644 --- a/hw/pci-host/piix.c +++ b/hw/pci-host/piix.c @@ -121,22 +121,24 @@ static int pci_slot_get_pirq(

[Qemu-devel] [PATCH v8 04/13] rdma: export throughput w/ MigrationStats QMP

2013-06-13 Thread mrhines
From: "Michael R. Hines" This exposes throughput (in megabits/sec) through QMP. Reviewed-by: Paolo Bonzini Signed-off-by: Michael R. Hines --- hmp.c |2 ++ include/migration/migration.h |1 + migration.c |6 ++ qapi-schema.json

[Qemu-devel] [PATCH v8 08/13] rdma: introduce qemu_ram_foreach_block()

2013-06-13 Thread mrhines
From: "Michael R. Hines" This is used during RDMA initialization in order to transmit a description of all the RAM blocks to the peer for later dynamic chunk registration purposes. Reviewed-by: Paolo Bonzini Signed-off-by: Michael R. Hines --- exec.c|9 + inclu

Re: [Qemu-devel] [PATCH] allow reading variable size vmdk descriptor files

2013-06-13 Thread Evgeny Budilovsky
On Fri, Jun 14, 2013 at 12:15 AM, Don Slutz wrote: > On 06/12/13 03:08, Evgeny Budilovsky wrote: > >> The hard-coded 2k buffer on the stack won't allow reading big descriptor >> files which can be generated when storing big images (For example 500G >> vmdk splitted to 2G chunks). >> >> Signed-off

[Qemu-devel] RDMA: please pull and re-test freezing fixes

2013-06-13 Thread Michael R. Hines
Chegu, I believe I've fixed all the pinning / freezing issues per Paolo's recommendations. I've re-submitted as v8 - Can you "git pull" from github and re-test? Thanks, - Michael

Re: [Qemu-devel] [PATCH v7 00/12] rdma: migration support

2013-06-13 Thread Michael R. Hines
On 06/13/2013 05:40 PM, Paolo Bonzini wrote: Il 13/06/2013 17:17, Michael R. Hines ha scritto: On 06/13/2013 04:06 PM, Paolo Bonzini wrote: Regarding the timestamp problem, it should be fixed in the RDMA code. You did find a bug, but xyz_start_outgoing_migration should be asynchronous and the p

[Qemu-devel] [PATCH v8 05/13] rdma: introduce qemu_file_mode_is_not_valid()

2013-06-13 Thread mrhines
From: "Michael R. Hines" QEMUFileRDMA also has read and write modes. This function is now shared to reduce code duplication. Reviewed-by: Paolo Bonzini Signed-off-by: Michael R. Hines --- include/migration/qemu-file.h |1 + savevm.c | 20 +--- 2 file

[Qemu-devel] [PATCH v8 02/13] rdma: introduce qemu_update_position()

2013-06-13 Thread mrhines
From: "Michael R. Hines" RDMA writes happen asynchronously, and thus the performance accounting also needs to be able to occur asynchronously. This allows anybody to call into savevm.c to update both f->pos as well as into arch_init.c to update the acct_info structure with up-to-date values when

[Qemu-devel] [PATCH v8 09/13] rdma: new QEMUFileOps hooks

2013-06-13 Thread mrhines
From: "Michael R. Hines" These are the prototypes and implementation of new hooks that RDMA takes advantage of to perform dynamic page registration. An optional hook is also introduced for a custom function to be able to override the default save_page function. Also included are the prototypes

[Qemu-devel] [PATCH v8 07/13] rdma: introduce ram_handle_compressed()

2013-06-13 Thread mrhines
From: "Michael R. Hines" This gives RDMA shared access to madvise() on the destination side when an entire chunk is found to be zero. Reviewed-by: Paolo Bonzini Signed-off-by: Michael R. Hines --- arch_init.c | 24 include/migration/migration.h |

[Qemu-devel] [PATCH v8 10/13] rdma: introduce capability x-rdma-pin-all

2013-06-13 Thread mrhines
From: "Michael R. Hines" This capability allows you to disable dynamic chunk registration for better throughput on high-performance links. For example, using an 8GB RAM virtual machine with all 8GB of memory in active use and the VM itself is completely idle using a 40 gbps infiniband link: 1.

[Qemu-devel] [PATCH v8 12/13] rdma: send pc.ram

2013-06-13 Thread mrhines
From: "Michael R. Hines" This takes advantages of the previous patches: 1. use the new QEMUFileOps hook 'save_page' 2. call out to the right accessor methods to invoke the iteration hooks defined in QEMUFileOps Reviewed-by: Paolo Bonzini Signed-off-by: Michael R. Hines --- arch_init.c |

[Qemu-devel] [PATCH v8 13/13] rdma: fix mlock() freezes and accounting

2013-06-13 Thread mrhines
From: "Michael R. Hines" This patch is contained to migration-rdma.c and fixes the problems experienced by others when the x-rdma-pin-all feature appeared to freeze the VM. By moving this operation out of the connection setup time and instead moving it to ram_save_setup() code, we no longer execu

[Qemu-devel] [PATCH v8 03/13] rdma: export yield_until_fd_readable()

2013-06-13 Thread mrhines
From: "Michael R. Hines" The RDMA event channel can be made non-blocking just like a TCP socket. Exporting this function allows us to yield so that the QEMU monitor remains available. Reviewed-by: Paolo Bonzini Signed-off-by: Michael R. Hines --- include/block/coroutine.h |6 ++ qemu-

[Qemu-devel] [PATCH v8 01/13] rdma: add documentation

2013-06-13 Thread mrhines
From: "Michael R. Hines" docs/rdma.txt contains full documentation, wiki links, github url and contact information. Reviewed-by: Paolo Bonzini Signed-off-by: Michael R. Hines --- docs/rdma.txt | 404 + 1 file changed, 404 insertions(+)

[Qemu-devel] [PATCH v8 00/13] rdma: migration support

2013-06-13 Thread mrhines
From: "Michael R. Hines" Please pull. Changes since v7: This fixes the problems experienced by others when the x-rdma-pin-all feature appeared to freeze the VM. By moving this operation out of the connection setup time and instead moving it to ram_save_setup() code, we no

[Qemu-devel] [PATCH v8 06/13] rdma: export qemu_fflush()

2013-06-13 Thread mrhines
From: "Michael R. Hines" RDMA uses this to flush the control channel before sending its own message to handle page registrations. Reviewed-by: Paolo Bonzini Signed-off-by: Michael R. Hines --- include/migration/qemu-file.h |1 + savevm.c |2 +- 2 files changed, 2

Re: [Qemu-devel] [RESEND PATCH] virtio-scsi: forward scsibus for virtio-scsi-pci.

2013-06-13 Thread Frederic Konrad
On 13/06/2013 09:59, Michael S. Tsirkin wrote: On Thu, Jun 13, 2013 at 09:34:30AM +0200, Frederic Konrad wrote: On 13/06/2013 09:23, Michael S. Tsirkin wrote: On Thu, Jun 13, 2013 at 04:46:09PM +1000, Alexey Kardashevskiy wrote: On 06/13/2013 04:28 PM, Frederic Konrad wrote: On 12/06/2013 13:

Re: [Qemu-devel] [SeaBIOS] solaris x86 in qemu? [bisected]

2013-06-13 Thread Michael Tokarev
14.06.2013 03:47, Kevin O'Connor wrote: >> Move code from PCI hotplug DSDT macros to methods. >> >> Simplify the hotplug code by moving the bulk of the logic out of the >> macros and into static method definitions. This also reduces the ACPI >> DSDT code size. >> >> Signed-off

Re: [Qemu-devel] [PATCH v5] net: add support of mac-programming over macvtap in QEMU side

2013-06-13 Thread Amos Kong
On Fri, Jun 07, 2013 at 09:46:12AM -0400, Luiz Capitulino wrote: > On Wed, 5 Jun 2013 18:42:13 +0800 > Amos Kong wrote: > > > Currently macvtap based macvlan device is working in promiscuous > > mode, we want to implement mac-programming over macvtap through > > Libvirt for better performance. >

Re: [Qemu-devel] [PATCH v5] net: add support of mac-programming over macvtap in QEMU side

2013-06-13 Thread Amos Kong
On Thu, Jun 06, 2013 at 03:00:34PM +0800, Jason Wang wrote: > On 06/05/2013 06:42 PM, Amos Kong wrote: > > Currently macvtap based macvlan device is working in promiscuous > > mode, we want to implement mac-programming over macvtap through > > Libvirt for better performance. ... > > +SQMP > > +que

Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-06-13 Thread Amos Kong
On Fri, May 31, 2013 at 08:31:17PM +0800, Amos Kong wrote: > On Thu, May 30, 2013 at 11:48:46AM -0500, Anthony Liguori wrote: > > Amos Kong writes: > > > diff --git a/hw/input/ps2.c b/hw/input/ps2.c > > > index 3412079..8adbb4a 100644 > > > --- a/hw/input/ps2.c > > > +++ b/hw/input/ps2.c > > > @

Re: [Qemu-devel] solaris x86 in qemu?

2013-06-13 Thread Michael Tokarev
14.06.2013 01:44, Brad Smith wrote: > On 13/06/13 3:51 AM, Michael Tokarev wrote: >> I think that supporting solaris as _guest_ OS is an important goal >> for qemu/kvm (as opposed to _host_). > > IMO both are important goals. I don't think it would be that big of a deal to > find one or two peopl

Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-06-13 Thread Amos Kong
On Thu, Jun 13, 2013 at 01:28:14PM -0500, Anthony Liguori wrote: > Paolo Bonzini writes: > > Il 13/06/2013 09:01, Anthony Liguori ha scritto: > >> Paolo Bonzini writes: > > static bool ps2_keyboard_ledstate_needed(void *opaque) > > @@ -638,9 +648,12 @@ static const VMStateDescription >

[Qemu-devel] [PATCH] QEMUBH: make AioContext's bh re-entrant

2013-06-13 Thread Liu Ping Fan
BH will be used outside big lock, so introduce lock to protect it. Note that the lock only affects the writer and bh's callback does not take this extra lock. Signed-off-by: Liu Ping Fan --- async.c | 10 +- include/block/aio.h | 2 ++ 2 files changed, 11 insertions(+), 1 de

Re: [Qemu-devel] [PATCH 2/2] Add monitor command mem-nodes

2013-06-13 Thread Wanlong Gao
On 06/14/2013 09:05 AM, Anthony Liguori wrote: > Paolo Bonzini writes: > >> Il 13/06/2013 08:50, Eduardo Habkost ha scritto: >>> I believe an interface based on guest physical memory addresses is more >>> flexible (and even simpler!) than one that only allows binding of whole >>> virtual NUMA nod

Re: [Qemu-devel] [SeaBIOS] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-13 Thread Peter Stuge
Anthony Liguori wrote: > However, with PCs, the ACPI tables are generated by/included in the > firmware. There's no question about that. I think the key point is that the firmware is developed and delivered by the hardware vendor, and not by an independent source. The firmware is intimately tied

Re: [Qemu-devel] [PATCH 4/4] linux-user: Restore original behavior of the -E and -U command-line options.

2013-06-13 Thread Alexander Graf
On 29.05.2013, at 15:50, Thomas Schwinge wrote: > Revert the change in behavior that had been introducecd in commit > fc9c54124d134dbd76338a92a91804dab2df8166 for the -E and -U command-line > options, but keep the comma-splitting for the QEMU_SET_ENV and QEMU_UNSET_ENV > environment variables. >

Re: [Qemu-devel] [PATCH 2/2] Add monitor command mem-nodes

2013-06-13 Thread Anthony Liguori
Paolo Bonzini writes: > Il 13/06/2013 08:50, Eduardo Habkost ha scritto: >> I believe an interface based on guest physical memory addresses is more >> flexible (and even simpler!) than one that only allows binding of whole >> virtual NUMA nodes. > > And "-numa node" is already one, what about jus

Re: [Qemu-devel] [PATCH 2/2] Add monitor command mem-nodes

2013-06-13 Thread Anthony Liguori
Eduardo Habkost writes: > On Wed, Jun 05, 2013 at 07:57:42AM -0500, Anthony Liguori wrote: >> Wanlong Gao writes: >> >> > Add monitor command mem-nodes to show the huge mapped >> > memory nodes locations. >> > >> > (qemu) info mem-nodes >> > /proc/14132/fd/13: 2ac0-2aaaeac0:

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-13 Thread Anthony Liguori
Paolo Bonzini writes: > Il 11/06/2013 03:35, Michael S. Tsirkin ha scritto: >> Two points >> 1. You never explained what you mean by un-hardware like. >> >>Currently bios is in a ROM device, and it has a >>template for ACPI tables together with it. >>This simply moves the tables to a

Re: [Qemu-devel] [PATCH v2 RFC] virtio-pci: fix LE host/BE guest capacity for blk

2013-06-13 Thread Alexander Graf
On 28.05.2013, at 12:18, Michael S. Tsirkin wrote: > When a BE guest reads capacity from an LE host virtio-blk device or vice > versa, it will get the dwords of the qword field swapped. > As virtio-blk is the only one with such a quirk, > and as non-pci transports don't do byte-swaps at all, > so

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-13 Thread Laszlo Ersek
On 06/14/13 01:02, Paolo Bonzini wrote: > Il 10/06/2013 21:03, Anthony Liguori ha scritto: I'm not really convinced that QEMU<->firmware is a GPL boundary because of how tightly the two are linked. >>> >>> Where has 'linked' in terms of the GPL ever been anything other than >>> actua

Re: [Qemu-devel] [SeaBIOS] solaris x86 in qemu? [bisected]

2013-06-13 Thread Kevin O'Connor
On Fri, Jun 14, 2013 at 12:32:22AM +0400, Michael Tokarev wrote: > 13.06.2013 11:51, Michael Tokarev wrote: > > Hello. > > > > In order to verify some build issues on solaris, I tried to install > > sol10 x86 in a kvm vm. But unfortunately it does not work: after the > > grub prompt and choosing

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-13 Thread Paolo Bonzini
Il 11/06/2013 03:35, Michael S. Tsirkin ha scritto: > Two points > 1. You never explained what you mean by un-hardware like. > >Currently bios is in a ROM device, and it has a >template for ACPI tables together with it. >This simply moves the tables to a separate ROM >device (FW CF

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-13 Thread Paolo Bonzini
Il 10/06/2013 21:03, Anthony Liguori ha scritto: >>> I'm not really convinced that >>> QEMU<->firmware is a GPL boundary because of how tightly the two are >>> linked. >> >> Where has 'linked' in terms of the GPL ever been anything other than >> actual executable linking? > > I should not have eve

Re: [Qemu-devel] [PATCH] exec: move io_mem_read/write to memory.h

2013-06-13 Thread Paolo Bonzini
Il 13/06/2013 18:26, Michael S. Tsirkin ha scritto: > On Thu, Jun 13, 2013 at 06:04:41PM -0400, Paolo Bonzini wrote: >> Il 13/06/2013 08:59, Michael S. Tsirkin ha scritto: >>> implementation is in memory.c, move function >>> to match. This allows use from places that >>> don't pull in exec-all.h >>

Re: [Qemu-devel] [PATCH 2/2] Add monitor command mem-nodes

2013-06-13 Thread Paolo Bonzini
Il 13/06/2013 08:50, Eduardo Habkost ha scritto: > I believe an interface based on guest physical memory addresses is more > flexible (and even simpler!) than one that only allows binding of whole > virtual NUMA nodes. And "-numa node" is already one, what about just adding "mem-path=/foo" or "hos

Re: [Qemu-devel] [PATCH] exec: move io_mem_read/write to memory.h

2013-06-13 Thread Michael S. Tsirkin
On Thu, Jun 13, 2013 at 06:04:41PM -0400, Paolo Bonzini wrote: > Il 13/06/2013 08:59, Michael S. Tsirkin ha scritto: > > implementation is in memory.c, move function > > to match. This allows use from places that > > don't pull in exec-all.h > > But they shouldn't be used. :) > > Everything excep

Re: [Qemu-devel] [PATCH RFC 6/8] exec: Clean up unnecessary S390 ifdeffery

2013-06-13 Thread Paolo Bonzini
Il 13/06/2013 03:02, Markus Armbruster ha scritto: > +} else if (kvm_enabled() && kvm_arch_ram_alloc) { > +/* some s390/kvm configurations have special constraints */ > +if (mem_path) { > +fprintf(stderr, > +"-mem-path not supported with this vers

Re: [Qemu-devel] [PATCH RFC 5/8] s390: Make qemu_ram_remap() consistent with allocation

2013-06-13 Thread Paolo Bonzini
Il 13/06/2013 03:02, Markus Armbruster ha scritto: > -static void *legacy_s390_alloc(ram_addr_t size) > + > +static void *legacy_s390_mmap(void *vaddr, ram_addr_t size) > { > -void *mem; > +return mmap(vaddr, size, PROT_EXEC | PROT_READ | PROT_WRITE, > +MAP_FIXED | MAP_SHAR

Re: [Qemu-devel] [PATCH RFC 4/8] s390: Simplify the RAM allocation hook

2013-06-13 Thread Paolo Bonzini
Il 13/06/2013 03:02, Markus Armbruster ha scritto: > Less code and ifdeffery. Less ifdeffery is of course fine, but please add instead kvm_arch_ram_alloc to the other target-*/kvm.c files. It can just return NULL. I think this may affect the karma that comes from a negative diffstat, but it is m

Re: [Qemu-devel] [PATCH RFC 2/8] exec: Clean up fall back when -mem-path allocation fails

2013-06-13 Thread Paolo Bonzini
Il 13/06/2013 03:02, Markus Armbruster ha scritto: > With -mem-path, qemu_ram_alloc_from_ptr() first tries to allocate > accordingly, but when it fails, it falls back to normal allocation. > > The fall back allocation code used to be effectively identical to the > "-mem-path not given" code, until

Re: [Qemu-devel] [PATCH 3/5] qcow2: Options to enable discard for freed clusters

2013-06-13 Thread Paolo Bonzini
Il 13/06/2013 07:47, Kevin Wolf ha scritto: > +s->discard_passthrough[QCOW2_DISCARD_NEVER] = false, > +s->discard_passthrough[QCOW2_DISCARD_ALWAYS] = true, > +s->discard_passthrough[QCOW2_DISCARD_REQUEST] = > +qemu_opt_get_bool(opts, QCOW2_OPT_DISCARD_REQUEST, > +

Re: [Qemu-devel] [PATCH 5/5] block: Always enable discard on the protocol level

2013-06-13 Thread Paolo Bonzini
Il 13/06/2013 07:47, Kevin Wolf ha scritto: > Turning on discard options in qcow2 doesn't help a lot when the discard > requests that it issues are thrown away by the raw-posix layer. This > patch always enables discard functionality on the protocol level so that > it's the image format's responsib

Re: [Qemu-devel] [PATCH] exec: move io_mem_read/write to memory.h

2013-06-13 Thread Paolo Bonzini
Il 13/06/2013 08:59, Michael S. Tsirkin ha scritto: > implementation is in memory.c, move function > to match. This allows use from places that > don't pull in exec-all.h But they shouldn't be used. :) Everything except the current users (TCG, and address_space_rw and friends) should go through e

[Qemu-devel] [Bug 830723] Re: bad patch net_h.patch on freebsd ports

2013-06-13 Thread Paolo Bonzini
** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/830723 Title: bad patch net_h.patch on freebsd ports Status in QEMU: Invalid Bug description: w

Re: [Qemu-devel] solaris x86 in qemu?

2013-06-13 Thread Brad Smith
On 13/06/13 3:51 AM, Michael Tokarev wrote: I think that supporting solaris as _guest_ OS is an important goal for qemu/kvm (as opposed to _host_). IMO both are important goals. I don't think it would be that big of a deal to find one or two people to provide Solaris x64 10 and/or 11.1 builds

Re: [Qemu-devel] virsh live migration w/o shared storage fails with error as vm is not running

2013-06-13 Thread Paolo Bonzini
Il 13/06/2013 13:26, chandrashekar shastri ha scritto: > On 06/13/2013 02:14 PM, Stefan Hajnoczi wrote: >> On Thu, Jun 13, 2013 at 10:31:04AM +0530, chandrashekar shastri wrote: >>> We are testing the upstream KVM with : >>> >>> Kernel, Qemu, Libvirt, Virt-Manager is built from the source (git). >>

Re: [Qemu-devel] [PATCH v7 00/12] rdma: migration support

2013-06-13 Thread Paolo Bonzini
Il 13/06/2013 17:17, Michael R. Hines ha scritto: > On 06/13/2013 04:06 PM, Paolo Bonzini wrote: >> Regarding the timestamp problem, it should be fixed in the RDMA code. >> You did find a bug, but xyz_start_outgoing_migration should be >> asynchronous and the pinning should happen in the setup phas

[Qemu-devel] [Bug 830723] Re: bad patch net_h.patch on freebsd ports

2013-06-13 Thread Ed Maste
Does not appear to be an issue any longer -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/830723 Title: bad patch net_h.patch on freebsd ports Status in QEMU: New Bug description: work patch fi

Re: [Qemu-devel] [PATCH v7 00/12] rdma: migration support

2013-06-13 Thread Michael R. Hines
On 06/13/2013 04:06 PM, Paolo Bonzini wrote: (CC-ing qemu-devel). OK, that's good to know. This means that we need to bringup the mlock() problem as a "larger" issue in the linux community instead of the QEMU community. In the meantime, how about I make update to the RDMA patch which does the

Re: [Qemu-devel] [PATCH] allow reading variable size vmdk descriptor files

2013-06-13 Thread Don Slutz
On 06/12/13 03:08, Evgeny Budilovsky wrote: The hard-coded 2k buffer on the stack won't allow reading big descriptor files which can be generated when storing big images (For example 500G vmdk splitted to 2G chunks). Signed-off-by: Evgeny Budilovsky --- block/vmdk.c | 28 +++

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: Change default machine for 64-bit

2013-06-13 Thread Peter Maydell
On 13 June 2013 20:02, Anthony Liguori wrote: > I believe it's there only because libfdt used to be optional. libfdt is > no longer optional. Technically speaking those patches haven't actually been committed yet ;-) [partly because it needs a trivial fixup and I haven't either resent with the f

Re: [Qemu-devel] [PATCH] make screendump an async command

2013-06-13 Thread Alon Levy
> Il 13/06/2013 15:27, Alon Levy ha scritto: > > This fixes the broken screendump behavior for qxl devices in native mode > > since 81fb6f1504fb9ef71f2382f44af34756668296e8. > > > > Note: due to QAPI not generating async commands yet I had to remove the > > schema screendump definition. > > > > R

Re: [Qemu-devel] solaris x86 in qemu? [bisected]

2013-06-13 Thread Michael Tokarev
13.06.2013 11:51, Michael Tokarev wrote: > Hello. > > In order to verify some build issues on solaris, I tried to install > sol10 x86 in a kvm vm. But unfortunately it does not work: after the > grub prompt and choosing "Solaris 10 x86" boot entry, the kernel > gets loaded (there's a row of dots

Re: [Qemu-devel] [PATCH] make screendump an async command

2013-06-13 Thread Paolo Bonzini
Il 13/06/2013 15:27, Alon Levy ha scritto: > This fixes the broken screendump behavior for qxl devices in native mode > since 81fb6f1504fb9ef71f2382f44af34756668296e8. > > Note: due to QAPI not generating async commands yet I had to remove the > schema screendump definition. > > Related RHBZ: 973

Re: [Qemu-devel] [PATCH v7 00/12] rdma: migration support

2013-06-13 Thread Paolo Bonzini
Il 13/06/2013 10:55, Michael R. Hines ha scritto: > On 06/13/2013 10:26 AM, Chegu Vinod wrote: >>> >>> 1. start QEMU with the lock option *first* >>> 2. Then enable x-rdma-pin-all >>> 3. Then perform the migration >>> >>> What happens here? Does pinning "in advance" help you? >> >> Yes it does help

[Qemu-devel] [PATCH] make screendump an async command

2013-06-13 Thread Alon Levy
This fixes the broken screendump behavior for qxl devices in native mode since 81fb6f1504fb9ef71f2382f44af34756668296e8. Note: due to QAPI not generating async commands yet I had to remove the schema screendump definition. Related RHBZ: 973374 This patch is not enough to fix said bz, with the lin

Re: [Qemu-devel] [RFC] sanitize memory on system reset

2013-06-13 Thread Peter Lieven
Am 13.06.2013 um 17:51 schrieb Markus Armbruster : > Peter Lieven writes: > >> On 13.06.2013 12:55, Markus Armbruster wrote: >>> Peter Lieven writes: >>> On 13.06.2013 10:40, Stefan Hajnoczi wrote: > On Thu, Jun 13, 2013 at 08:09:09AM +0200, Peter Lieven wrote: >> I was thinking

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: Change default machine for 64-bit

2013-06-13 Thread Anthony Liguori
Scott Wood writes: > On 06/13/2013 01:31:48 PM, Anthony Liguori wrote: >> Alexander Graf writes: >> >> > On 17.05.2013, at 09:42, Andreas Färber wrote: >> > >> >> Am 17.05.2013 06:25, schrieb David Gibson: >> >>> Currently, for qemu-system-ppc64, the default machine type is >> 'mac99'. >> >>>

Re: [Qemu-devel] [PATCH v3 1/3] ARM: Allow boards to provide an fdt blob

2013-06-13 Thread Peter Maydell
(I've taken this work over from John so these review comments are more in the nature of "notes to myself" than anything else ;-) On 10 May 2013 07:58, John Rigby wrote: > If no fdt is provided on command line and the new field > get_dtb in struct arm_boot_info is set then call it to > get a devic

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: Change default machine for 64-bit

2013-06-13 Thread Scott Wood
On 06/13/2013 01:31:48 PM, Anthony Liguori wrote: Alexander Graf writes: > On 17.05.2013, at 09:42, Andreas Färber wrote: > >> Am 17.05.2013 06:25, schrieb David Gibson: >>> Currently, for qemu-system-ppc64, the default machine type is 'mac99'. >>> Since the mac99 machine is not being activel

Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-06-13 Thread Anthony Liguori
Paolo Bonzini writes: > Il 13/06/2013 09:01, Anthony Liguori ha scritto: >> Paolo Bonzini writes: >> >>> Il 13/06/2013 06:19, Andreas Färber ha scritto: Am 31.05.2013 14:31, schrieb Amos Kong: > diff --git a/hw/input/ps2.c b/hw/input/ps2.c > index cdb18e6..fdb9912 100644 > ---

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: Change default machine for 64-bit

2013-06-13 Thread Anthony Liguori
Alexander Graf writes: > On 17.05.2013, at 09:42, Andreas Färber wrote: > >> Am 17.05.2013 06:25, schrieb David Gibson: >>> Currently, for qemu-system-ppc64, the default machine type is 'mac99'. >>> Since the mac99 machine is not being actively maintained, and shows quite >>> a few signs of bitro

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-13 Thread Luiz Capitulino
On Tue, 11 Jun 2013 09:48:40 +0800 Qiao Nuohan wrote: > introspection. I just want these patches reviewed first, then I may get these > patches ready for merging soon after introspection support. I've started reviewing this, but I'm out of cycles for this week. Can anyone CC'ed help with this?

Re: [Qemu-devel] [Xen-devel] [PATCH] Remove hardcoded xen-platform device initialization

2013-06-13 Thread Paolo Bonzini
Il 13/06/2013 13:44, Ian Campbell ha scritto: > On Thu, 2013-06-13 at 18:33 +0100, Stefano Stabellini wrote: >> On Thu, 13 Jun 2013, Paul Durrant wrote: >>> The xen-platform device should be initialized by the Xen toolstack by >>> passing the appropriate -device argument on the command line. >>> >>

Re: [Qemu-devel] [PATCH v3 2/3] ARM: Allow dumping of device tree

2013-06-13 Thread Peter Maydell
On 10 May 2013 07:58, John Rigby wrote: > By calling qemu_devtree_dumpdtb near the end of load_dtb. > > Signed-off-by: John Rigby Reviewed-by: Peter Maydell I'm just going to put this in arm-devs.next now, since it makes '-machine dumpdtb=filename' work rather than be silently ignored. thanks

[Qemu-devel] [Bug 504368] Re: sdl window intermittently scales instead of resizing

2013-06-13 Thread Lekensteyn
I cannot reproduce with KWin FWIW, but have an openbox box somewhere (no pun intended). Can you apply the attached debug patch, reproduce your bug (move with alt+click) and attach the output? If the log grows too large, try: uniq -f1 -c log What version of SDL are you using? ** Patch added:

Re: [Qemu-devel] [Xen-devel] [PATCH] Remove hardcoded xen-platform device initialization

2013-06-13 Thread Ian Campbell
On Thu, 2013-06-13 at 18:33 +0100, Stefano Stabellini wrote: > On Thu, 13 Jun 2013, Paul Durrant wrote: > > The xen-platform device should be initialized by the Xen toolstack by > > passing the appropriate -device argument on the command line. > > > > Signed-off-by: Paul Durrant > > This patch i

Re: [Qemu-devel] [PATCH v2] kvm/openpic: in-kernel mpic support

2013-06-13 Thread Scott Wood
On 06/13/2013 06:01:49 AM, Andreas Färber wrote: Am 12.06.2013 22:32, schrieb Scott Wood: > +typedef struct KVMOpenPICState { > +SysBusDevice busdev; SysBusDevice parent_obj; please! http://wiki.qemu.org/QOMConventions The word "QOMConventions" doesn't exist once in the QEMU source tree.

Re: [Qemu-devel] [PATCH v7 00/12] rdma: migration support

2013-06-13 Thread Michael R. Hines
On 06/13/2013 10:26 AM, Chegu Vinod wrote: 1. start QEMU with the lock option *first* 2. Then enable x-rdma-pin-all 3. Then perform the migration What happens here? Does pinning "in advance" help you? Yes it does help by avoiding the freeze time at the start of the pin-all migration. I alr

Re: [Qemu-devel] [PATCH] Remove hardcoded xen-platform device initialization

2013-06-13 Thread Stefano Stabellini
On Thu, 13 Jun 2013, Paul Durrant wrote: > The xen-platform device should be initialized by the Xen toolstack by > passing the appropriate -device argument on the command line. > > Signed-off-by: Paul Durrant This patch is problematic because we can't know for sure the version of upstream QEMU t

Re: [Qemu-devel] [PATCH RFC 7/8] exec: Don't abort when we can't allocate guest memory

2013-06-13 Thread Markus Armbruster
Peter Maydell writes: > On 13 June 2013 08:02, Markus Armbruster wrote: >> #ifdef __linux__ >> >> +static void no_guest_mem(RAMBlock *block) >> +{ >> +fprintf(stderr, "Cannot set up guest memory '%s': %s\n", >> +block->mr->name, strerror(errno)); >> +exit(1); >> +} > > This

Re: [Qemu-devel] [PATCH RFC 7/8] exec: Don't abort when we can't allocate guest memory

2013-06-13 Thread Markus Armbruster
Richard Henderson writes: > On 06/13/2013 12:02 AM, Markus Armbruster wrote: >> @@ -945,7 +952,7 @@ static void *file_ram_alloc(RAMBlock *block, >> area = mmap(0, memory, PROT_READ | PROT_WRITE, MAP_PRIVATE, fd, 0); >> #endif >> if (area == MAP_FAILED) { >> -perror("file_ram_al

Re: [Qemu-devel] virsh live migration w/o shared storage fails with error as vm is not running

2013-06-13 Thread chandrashekar shastri
On 06/13/2013 02:14 PM, Stefan Hajnoczi wrote: On Thu, Jun 13, 2013 at 10:31:04AM +0530, chandrashekar shastri wrote: We are testing the upstream KVM with : Kernel, Qemu, Libvirt, Virt-Manager is built from the source (git). kernel version : 3.9.0+ qemu version : QEMU emulator version 1.5.0 li

Re: [Qemu-devel] [Xen-devel] [BUG 1747]Guest could't find bootable device with memory more than 3600M

2013-06-13 Thread Ian Campbell
On Thu, 2013-06-13 at 17:55 +0100, Stefano Stabellini wrote: > > > We could have a xenstore flag somewhere that enables the old behaviour > > > so that people can revert back to qemu-xen-traditional and make the pci > > > hole below 4G even bigger than 448MB, but I think that keeping the old > > >

[Qemu-devel] [Bug 504368] Re: sdl window intermittently scales instead of resizing

2013-06-13 Thread Jamin W. Collins
Window manager varies. In the original report it was openbox (as I believe I stated, in comment #7). Current window manager is xfwm4. For the screenshot provided, I intentionally moved the window with Alt+left_click as I knew this would trigger the issue (also indicated in comment #7). However

Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-06-13 Thread Anthony Liguori
Amos Kong writes: > On Fri, May 31, 2013 at 08:31:17PM +0800, Amos Kong wrote: >> On Thu, May 30, 2013 at 11:48:46AM -0500, Anthony Liguori wrote: >> > Amos Kong writes: >> > >> > > Guest driver sets repeat rate and delay time by KBD_CMD_SET_RATE, >> > > but ps2 backend doesn't process it and n

Re: [Qemu-devel] [PATCH v3] create qemu_openpty_raw() helper function and move it to a separate file

2013-06-13 Thread Andreas Färber
Am 13.06.2013 18:04, schrieb Michael Tokarev: > In two places qemu uses openpty() which is very system-dependent, > and in both places the pty is switched to raw mode as well. > Make a wrapper function which does both steps, and move all the > system-dependent complexity into a separate file, toget

Re: [Qemu-devel] [Xen-devel] [BUG 1747]Guest could't find bootable device with memory more than 3600M

2013-06-13 Thread Stefano Stabellini
On Thu, 13 Jun 2013, Ian Campbell wrote: > On Thu, 2013-06-13 at 15:50 +0100, Stefano Stabellini wrote: > > On Thu, 13 Jun 2013, George Dunlap wrote: > > > On 13/06/13 14:44, Stefano Stabellini wrote: > > > > On Wed, 12 Jun 2013, George Dunlap wrote: > > > > > On 12/06/13 08:25, Jan Beulich wrote:

Re: [Qemu-devel] [PATCH] linux-user: add SIOCADDRT/SIOCDELRT support

2013-06-13 Thread Peter Maydell
On 27 May 2013 19:48, Laurent Vivier wrote: > This allows to pass the device name. > > You can test this with the "route" command. > > WITHOUT this patch: > > $ sudo route add -net default gw 10.0.3.1 eth0 > SIOCADDRT: Bad address > $ netstat -nr > Kernel IP routing table > Destination Gateway

Re: [Qemu-devel] fdisk still shows the "/dev/sdb" partitions even after the removal of scsi disk

2013-06-13 Thread chandrashekar shastri
On 06/13/2013 06:20 PM, Laszlo Ersek wrote: On 06/13/13 12:19, chandrashekar shastri wrote: Hi, I have filed a bug "fdisk still shows the "/dev/sdb" partitions even after the removal of scsi disk" for the upstream kernel. Bug link: https://bugs.launchpad.net/qemu/+bug/1190525 RHEL guest shows

Re: [Qemu-devel] [PATCH RFC 7/8] exec: Don't abort when we can't allocate guest memory

2013-06-13 Thread Peter Maydell
On 13 June 2013 08:02, Markus Armbruster wrote: > #ifdef __linux__ > > +static void no_guest_mem(RAMBlock *block) > +{ > +fprintf(stderr, "Cannot set up guest memory '%s': %s\n", > +block->mr->name, strerror(errno)); > +exit(1); > +} This new error message is inside an #ifdef

Re: [Qemu-devel] [Xen-devel] [BUG 1747]Guest could't find bootable device with memory more than 3600M

2013-06-13 Thread Stefano Stabellini
On Thu, 13 Jun 2013, George Dunlap wrote: > On 13/06/13 15:50, Stefano Stabellini wrote: > > Keep in mind that if we start the pci hole at 0xe000, the number of > > cases for which any workarounds are needed is going to be dramatically > > decreased to the point that I don't think we need a wor

Re: [Qemu-devel] [PATCH v7 00/12] rdma: migration support

2013-06-13 Thread Michael R. Hines
On 06/13/2013 09:50 AM, Chegu Vinod wrote: Attempted to migrate a smaller guest 10Vcpu/64GB (the guest was just idle) with the pin-all option. It took ~20 sec to do the pin of the guest's RAM (this is the time when the guest is "frozen") and then the actual migration started... and took ab

[Qemu-devel] [PATCH v3] create qemu_openpty_raw() helper function and move it to a separate file

2013-06-13 Thread Michael Tokarev
In two places qemu uses openpty() which is very system-dependent, and in both places the pty is switched to raw mode as well. Make a wrapper function which does both steps, and move all the system-dependent complexity into a separate file, together with static/local implementations of openpty() and

Re: [Qemu-devel] [PATCH RFC 7/8] exec: Don't abort when we can't allocate guest memory

2013-06-13 Thread Richard Henderson
On 06/13/2013 12:02 AM, Markus Armbruster wrote: > @@ -945,7 +952,7 @@ static void *file_ram_alloc(RAMBlock *block, > area = mmap(0, memory, PROT_READ | PROT_WRITE, MAP_PRIVATE, fd, 0); > #endif > if (area == MAP_FAILED) { > -perror("file_ram_alloc: can't mmap RAM pages"); > +

Re: [Qemu-devel] [RFC] sanitize memory on system reset

2013-06-13 Thread Markus Armbruster
Peter Lieven writes: > On 13.06.2013 12:55, Markus Armbruster wrote: >> Peter Lieven writes: >> >>> On 13.06.2013 10:40, Stefan Hajnoczi wrote: On Thu, Jun 13, 2013 at 08:09:09AM +0200, Peter Lieven wrote: > I was thinking if it would be a good idea to zeroize all memory > resources

Re: [Qemu-devel] [Xen-devel] [BUG 1747]Guest could't find bootable device with memory more than 3600M

2013-06-13 Thread Stefano Stabellini
On Thu, 13 Jun 2013, Ian Campbell wrote: > On Thu, 2013-06-13 at 14:54 +0100, George Dunlap wrote: > > On 13/06/13 14:44, Stefano Stabellini wrote: > > > On Wed, 12 Jun 2013, George Dunlap wrote: > > >> On 12/06/13 08:25, Jan Beulich wrote: > > >> On 11.06.13 at 19:26, Stefano Stabellini > > >>

Re: [Qemu-devel] [Xen-devel] [BUG 1747]Guest could't find bootable device with memory more than 3600M

2013-06-13 Thread George Dunlap
On 13/06/13 16:36, Ian Campbell wrote: On Thu, 2013-06-13 at 16:30 +0100, George Dunlap wrote: On 13/06/13 16:16, Ian Campbell wrote: On Thu, 2013-06-13 at 14:54 +0100, George Dunlap wrote: On 13/06/13 14:44, Stefano Stabellini wrote: On Wed, 12 Jun 2013, George Dunlap wrote: On 12/06/13 08:

Re: [Qemu-devel] [Xen-devel] [BUG 1747]Guest could't find bootable device with memory more than 3600M

2013-06-13 Thread Ian Campbell
On Thu, 2013-06-13 at 16:40 +0100, George Dunlap wrote: > On 13/06/13 16:36, Ian Campbell wrote: > > On Thu, 2013-06-13 at 16:30 +0100, George Dunlap wrote: > >> On 13/06/13 16:16, Ian Campbell wrote: > >>> On Thu, 2013-06-13 at 14:54 +0100, George Dunlap wrote: > On 13/06/13 14:44, Stefano St

Re: [Qemu-devel] [Xen-devel] [BUG 1747]Guest could't find bootable device with memory more than 3600M

2013-06-13 Thread Ian Campbell
On Thu, 2013-06-13 at 16:30 +0100, George Dunlap wrote: > On 13/06/13 16:16, Ian Campbell wrote: > > On Thu, 2013-06-13 at 14:54 +0100, George Dunlap wrote: > >> On 13/06/13 14:44, Stefano Stabellini wrote: > >>> On Wed, 12 Jun 2013, George Dunlap wrote: > On 12/06/13 08:25, Jan Beulich wrote:

Re: [Qemu-devel] [Xen-devel] [BUG 1747]Guest could't find bootable device with memory more than 3600M

2013-06-13 Thread Ian Campbell
On Thu, 2013-06-13 at 15:50 +0100, Stefano Stabellini wrote: > On Thu, 13 Jun 2013, George Dunlap wrote: > > On 13/06/13 14:44, Stefano Stabellini wrote: > > > On Wed, 12 Jun 2013, George Dunlap wrote: > > > > On 12/06/13 08:25, Jan Beulich wrote: > > > > > > > > On 11.06.13 at 19:26, Stefano Stabe

Re: [Qemu-devel] [Xen-devel] [BUG 1747]Guest could't find bootable device with memory more than 3600M

2013-06-13 Thread George Dunlap
On 13/06/13 16:16, Ian Campbell wrote: On Thu, 2013-06-13 at 14:54 +0100, George Dunlap wrote: On 13/06/13 14:44, Stefano Stabellini wrote: On Wed, 12 Jun 2013, George Dunlap wrote: On 12/06/13 08:25, Jan Beulich wrote: On 11.06.13 at 19:26, Stefano Stabellini wrote: I went through the code

Re: [Qemu-devel] [Xen-devel] [BUG 1747]Guest could't find bootable device with memory more than 3600M

2013-06-13 Thread George Dunlap
On 13/06/13 15:50, Stefano Stabellini wrote: Keep in mind that if we start the pci hole at 0xe000, the number of cases for which any workarounds are needed is going to be dramatically decreased to the point that I don't think we need a workaround anymore. You don't think anyone is going to

Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-06-13 Thread Paolo Bonzini
Il 13/06/2013 09:01, Anthony Liguori ha scritto: > Paolo Bonzini writes: > >> Il 13/06/2013 06:19, Andreas Färber ha scritto: >>> Am 31.05.2013 14:31, schrieb Amos Kong: diff --git a/hw/input/ps2.c b/hw/input/ps2.c index cdb18e6..fdb9912 100644 --- a/hw/input/ps2.c +++ b/hw/in

  1   2   3   >