Re: [Qemu-devel] [PATCH] qemu-iotests: Filter out vmdk creation options

2013-05-02 Thread Kevin Wolf
Am 03.05.2013 um 03:31 hat Fam Zheng geschrieben: > Cover new image creation options for vmdk, so we can use '-o > zeroed_grain=XXX' and '-o subformat=XXX' to run the tests successfully. > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/common.rc | 2 ++ > 1 file changed, 2 insertions(+) > >

[Qemu-devel] [PATCH] spapr_llan: fix device reenabling

2013-05-02 Thread Alexey Kardashevskiy
Normally, the "tap" device is polled by QEMU if a guest NIC can receive packets. If a guest NIC is stopped during transfer (rmmod or ifdown), it may still have packets in a queue which have to be send to the guest before QEMU enables polling of a "tap" interface via tap_update_fd_handler(). Howeve

Re: [Qemu-devel] [PATCH 3/6] kvm: workaround a possible KVM bug when using KVM_MEM_READONLY

2013-05-02 Thread Xiao Guangrong
On 04/28/2013 04:32 PM, Jordan Justen wrote: > On a Linux 3.8.0 based kernel, I occasionally saw a situation > where the memory region would continue to trap on memory > read even though KVM_MEM_READONLY was set. > > I found that if I set the slot to a size of 0, and before > setting the slot, it

Re: [Qemu-devel] [PATCH 4/4] usb-host: raise libusbx minimum version to 1.0.13

2013-05-02 Thread Gerd Hoffmann
Hi, > I'm wondering how best to address QEMU's libusb support on FreeBSD, > and discovered the libusb vs. libusbx saga. Is it safe to assume that > in the Linux world "pkg-config libusb-1.0" is generally going to refer > to libusbx? In recent linux distributions yes. > FreeBSD has its own lib

Re: [Qemu-devel] [PATCH 2/6] kvm: support using KVM_MEM_READONLY flag for readonly regions

2013-05-02 Thread Xiao Guangrong
On 04/28/2013 04:32 PM, Jordan Justen wrote: > A slot that uses KVM_MEM_READONLY can be read from and code > can execute from the region, but writes will trap. > > For regions that are readonly and also not writeable, we > force the slot to be removed so reads or writes to the region > will trap.

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/7] pci: add MPC105 PCI host bridge emulation

2013-05-02 Thread Hervé Poussineau
Alexander Graf a écrit : Am 02.05.2013 um 22:08 schrieb Hervé Poussineau : Non-contiguous I/O is not implemented. There is also somewhere a bug in the memory controller, which means that some real firmwares may not detect the correct amount of memory. This can be bypassed by adding '-m 1G' on

Re: [Qemu-devel] [PATCH 4/7] m48t59: register a QOM type for each nvram type we support

2013-05-02 Thread Hervé Poussineau
Artyom Tarasenko a écrit : On Thu, May 2, 2013 at 10:09 PM, Hervé Poussineau wrote: As m48t59 devices can only be created with m48t59_init() or m48t59_init_isa(), we know exactly which nvram types are required. Register only those three types. Wasn't this patch NACKed by Blue? I think I cha

[Qemu-devel] KVM VM(rhel-5.5) %si is too high when TX/RX packets

2013-05-02 Thread Zhanghaoyu (A)
I running a VM(RHEL-5.5) on KVM hypervisor(linux-3.8 + QEMU-1.4.1), and direct-assign intel 82576 VF to the VM. When TX/RX packets on VM to the other host via iperf tool, top tool result on VM shown that the %si is too high, approximately 95% ~ 100%, but from the view of host, the VM's total CPU

Re: [Qemu-devel] Target-agnostic virtio?

2013-05-02 Thread Rob Landley
On 04/30/2013 04:31:29 PM, Artyom Tarasenko wrote: On Mon, Apr 29, 2013 at 7:43 AM, Rob Landley wrote: > On 04/27/2013 03:00:06 PM, Artyom Tarasenko wrote: >> >> > For a lot of the 64-bit targets, actual 64 bit userspace support is >> > strangely lacking. For ppc64 they say to use ppc32, and I

Re: [Qemu-devel] qemu/virtio issue due to non-atomic data access

2013-05-02 Thread Paul Guo
Yes, sounds to be a better idea. I'm wondering whether the final real virtual address for loading in lduw_phys(), etc is aligned also in most cases? given the load address (the input argument with type hwaddr) is required to be aligned (according to the comment). If so we should make the lduw_ph

Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump()

2013-05-02 Thread Wenchao Xia
于 2013-5-2 20:02, Luiz Capitulino 写道: On Thu, 02 May 2013 10:05:08 +0800 Wenchao Xia wrote: 于 2013-4-30 3:05, Luiz Capitulino 写道: On Fri, 26 Apr 2013 16:46:57 +0200 Stefan Hajnoczi wrote: On Fri, Apr 26, 2013 at 05:31:15PM +0800, Wenchao Xia wrote: @@ -2586,10 +2585,12 @@ void do_info_sna

[Qemu-devel] [PATCH v2 4/6] hostmem: hostmem listener pin RAM-Device by refcnt

2013-05-02 Thread Liu Ping Fan
From: Liu Ping Fan With ref()/unref() interface of MemoryRegion, we can pin RAM-Device when using its memory, and release it when done. Signed-off-by: Liu Ping Fan --- hw/virtio/dataplane/hostmem.c | 44 +++- hw/virtio/dataplane/vring.c |8 ++

[Qemu-devel] [PATCH v2 3/6] memory: add ref/unref interface for MemroyRegionOps

2013-05-02 Thread Liu Ping Fan
From: Liu Ping Fan This pair of interface are optinal, except for those device which is used outside the biglock's protection for hot unplug. Currently, HostMem used by virtio-blk dataplane is outside biglock, so the RAM device should implement this. Signed-off-by: Liu Ping Fan --- include/exe

[Qemu-devel] [PATCH v2 2/6] hostmem: AddressSpace has its own map and maintained by RCU prepared style

2013-05-02 Thread Liu Ping Fan
From: Liu Ping Fan Each address space will have a map between its hwaddr and hva, this is expressed as the struct AddrSpaceMem. Currently only address space of system memory's map is used by virtio device, and the map is stored in AddrSpaceMem *system_mem. The map is maintained by RCU prepared s

[Qemu-devel] [PATCH v2 6/6] virtio-blk: release reference to RAM's memoryRegion

2013-05-02 Thread Liu Ping Fan
From: Liu Ping Fan virtio-blk will unref RAM's memoryRegion when the io-req has been done. So we can avoid to call bdrv_drain_all() when RAM hot unplug. Signed-off-by: Liu Ping Fan --- hw/block/dataplane/virtio-blk.c | 51 +- 1 files changed, 39 insertions

[Qemu-devel] [PATCH v2 5/6] Vring: use hostmem's RAM safe api

2013-05-02 Thread Liu Ping Fan
From: Liu Ping Fan Before mm-ops done, we should gurantee the validaion of regions which is used by Vring self and the chunck pointed by vring desc. We acheive this goal by inc refcnt of RAM-Device. When finished, we dec this cnt through the interface of MemoryRegion. Signed-off-by: Liu Ping Fan

[Qemu-devel] [PATCH v2 1/6] hostmem: make hostmem single, not per Vring related

2013-05-02 Thread Liu Ping Fan
From: Liu Ping Fan The hwaddr and hva mapping relation is system wide, no need to be created for each Vring Signed-off-by: Liu Ping Fan --- exec.c|1 + hw/virtio/dataplane/hostmem.c | 33 +++-- hw/virtio/dataplane/vring.

[Qemu-devel] [PATCH v2 0/6] proposal to make hostmem listener RAM unplug safe

2013-05-02 Thread Liu Ping Fan
v1->v2: 1.split RCU prepared style update and monitor the RAM-Device refcnt into two patches (patch 2,4) 2.introduce AddrSpaceMem, which is similar to HostMem, but based on address space, while the original HostMem only server system memory address space Liu Ping Fan (6): hostmem: make

[Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-05-02 Thread David Gibson
This patch adds the necessary support for saving the state of the PAPR VIO virtual SCSI device. This turns out to be trivial, because the generiC SCSI code already quiesces the attached virtual SCSI bus. Signed-off-by: David Gibson --- hw/scsi/spapr_vscsi.c | 28

[Qemu-devel] [PATCH 2/8] target-ppc: Convert ppc cpu savevm to VMStateDescription

2013-05-02 Thread David Gibson
The savevm code for the powerpc cpu emulation is currently based around the old register_savevm() rather than register_vmstate() method. It's also rather broken, missing some important state on some CPU models. This patch completely rewrites the savevm for target-ppc, using the new VMStateDescrip

[Qemu-devel] [PATCH 3/8] pseries: savevm support for XICS interrupt controller

2013-05-02 Thread David Gibson
This patch adds the necessary VMStateDescription information to support savevm/loadvm for the XICS interrupt controller used on the pseries machine. Signed-off-by: David Gibson --- hw/ppc/xics.c | 57 + 1 file changed, 53 insertions(+), 4

[Qemu-devel] [0/8] pseries: savevm / migration support

2013-05-02 Thread David Gibson
So, it's obviously too late to merge these for the 1.5 release. But I'm sending them so that they're out there and with any luck we can merge them early in the 1.6 cycle. These patches have been baking in my internal tree for a while, and seem to be pretty solid.

[Qemu-devel] [PATCH 5/8] pseries: savevm support for PAPR VIO logical lan

2013-05-02 Thread David Gibson
This patch adds the necessary VMStateDescription information to support savevm/loadvm for the spapr_llan (PAPR logical lan) device. Signed-off-by: David Gibson --- hw/char/spapr_vty.c | 16 hw/net/spapr_llan.c | 24 ++-- 2 files changed, 38 insertions(+),

[Qemu-devel] [PATCH 8/8] pseries: savevm support for pseries machine

2013-05-02 Thread David Gibson
This adds the necessary pieces to implement savevm / migration for the pseries machine. The most complex part here is migrating the hash table - for the paravirtualized pseries machine the guest's hash page table is not stored within guest memory, but externally and the guest accesses it via hyper

[Qemu-devel] [PATCH 6/8] pseries: savevm support for PAPR TCE tables

2013-05-02 Thread David Gibson
This patch adds the necessary VMStateDescription information to save the state of PAPR TCE tables (that is, the PAPR specified IOMMU). Signed-off-by: David Gibson --- hw/ppc/spapr_iommu.c | 24 1 file changed, 24 insertions(+) diff --git a/hw/ppc/spapr_iommu.c b/hw/pp

[Qemu-devel] [PATCH 1/8] savevm: Implement VMS_DIVIDE flag

2013-05-02 Thread David Gibson
The vmstate infrastructure includes a VMS_MULTIPY flag, and associated VMSTATE_VBUFFER_MULTIPLY helper macro. These can be used to save a variably sized buffer where the size in bytes of the buffer isn't directly accessible as a structure field, but an element count from which the size can be deri

[Qemu-devel] [PATCH 4/8] pseries: savevm support for VIO devices

2013-05-02 Thread David Gibson
This patch adds helpers to allow PAPR VIO devices to save state common to all VIO devices during savevm. Signed-off-by: David Gibson --- hw/ppc/spapr_vio.c | 20 include/hw/ppc/spapr_vio.h |5 + 2 files changed, 25 insertions(+) diff --git a/hw/ppc/spapr_v

[Qemu-devel] [PATCH] qemu-iotests: Filter out vmdk creation options

2013-05-02 Thread Fam Zheng
Cover new image creation options for vmdk, so we can use '-o zeroed_grain=XXX' and '-o subformat=XXX' to run the tests successfully. Signed-off-by: Fam Zheng --- tests/qemu-iotests/common.rc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/co

Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())

2013-05-02 Thread Peter Crosthwaite
Hi Peter, On Fri, May 3, 2013 at 1:33 AM, Peter Maydell wrote: > On 2 May 2013 16:30, Paolo Bonzini wrote: >> /me changes his scripts... >> >> -s/PATCH/PULL/ if (/PATCH 0+\\//); >> +s/PATCH/PULL/ if (/^Subject:/); >> >> Yes, Perl... > > Heh, I use sed for this bit: > sed -i -e 's/^Subject: \[PUL

Re: [Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator.

2013-05-02 Thread Peter Crosthwaite
Hi JC, On Fri, May 3, 2013 at 4:33 AM, Jean-Christophe DUBOIS wrote: > Peter, > > Thanks for you review. > > I have a few questions below. > > JC > > > On 05/02/2013 02:16 PM, Peter Crosthwaite wrote: >> >> Hi Jean-Christophe, >> >> Thanks for your contribution. Please run the patch through >> sc

Re: [Qemu-devel] [PATCH 4/7] m48t59: register a QOM type for each nvram type we support

2013-05-02 Thread Artyom Tarasenko
On Thu, May 2, 2013 at 10:09 PM, Hervé Poussineau wrote: > As m48t59 devices can only be created with m48t59_init() or m48t59_init_isa(), > we know exactly which nvram types are required. Register only those three > types. Wasn't this patch NACKed by Blue? > Remove .model and .size properties as

Re: [Qemu-devel] [PATCH v2 02/12] ARM: Prepare translation for AArch64 code

2013-05-02 Thread John Rigby
On Tue, Apr 30, 2013 at 6:36 AM, Peter Maydell wrote: > > On 30 April 2013 10:36, Alexander Graf wrote: > > > > On 30.04.2013, at 08:36, John Rigby wrote: > >> - remove many uses of is_a64 as that is a indicator the target arch is > >> aarch64 not what mode it is running in. > > > > It indicates

Re: [Qemu-devel] [PATCH v2 02/12] ARM: Prepare translation for AArch64 code

2013-05-02 Thread John Rigby
On Wed, May 1, 2013 at 4:33 AM, Peter Maydell wrote: > On 1 May 2013 11:19, Laurent Desnogues > wrote: > > On Wednesday, May 1, 2013, Richard Henderson wrote: > >> On 2013-04-30 07:36, John Rigby wrote: > >>> > >>> uint32_t regs[16]; > >>> + > >>> +/* Regs for A64 mode. */ > >>> +

Re: [Qemu-devel] [PATCH 4/7] block: distinguish id and name in bdrv_find_snapshot()

2013-05-02 Thread Pavel Hrdina
On 2.5.2013 04:02, Wenchao Xia wrote: 于 2013-5-1 2:16, Eric Blake 写道: On 04/26/2013 03:31 AM, Wenchao Xia wrote: To make it clear about id and name in searching, the API is changed a bit to distinguish them, and caller can choose to search by id or name. If not found, *errp will be set to tip w

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/7] pci: add MPC105 PCI host bridge emulation

2013-05-02 Thread Alexander Graf
Am 02.05.2013 um 22:08 schrieb Hervé Poussineau : > Non-contiguous I/O is not implemented. > > There is also somewhere a bug in the memory controller, which means > that some real firmwares may not detect the correct amount of memory. > This can be bypassed by adding '-m 1G' on the command line

Re: [Qemu-devel] [RFC][PATCH v2]Add timestamp to error message

2013-05-02 Thread Seiji Aguchi
Thank you for giving the comments. I will separate this functionality from the qemu error file. > I also don't buy that we can't use strftime. There are very few places > where we use fork() in QEMU (it doesn't exist on Windows so it can't be > used without protection). None of those places use

[Qemu-devel] [Bug 1175513] Re: Qemu 1.5-git gpu clock control doesn`t work after guest reboot

2013-05-02 Thread commiethebeastie
With kernel-3.9.0 host system hangs after guest (win 7) poweroff or reboot. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1175513 Title: Qemu 1.5-git gpu clock control doesn`t work after guest rebo

[Qemu-devel] [Bug 1175513] Re: Qemu 1.5.0 gpu clock control doesn`t work after guest reboot

2013-05-02 Thread commiethebeastie
Linux localhost 3.8.10-gentoo #3 SMP PREEMPT Wed May 1 19:30:30 MSK 2013 x86_64 AMD FX(tm)-8120 Eight-Core Processor AuthenticAMD GNU/Linux -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1175513 Title

[Qemu-devel] [Bug 1175513] Re: Qemu 1.5-git gpu clock control doesn`t work after guest reboot

2013-05-02 Thread commiethebeastie
** Summary changed: - Qemu 1.5.0 gpu clock control doesn`t work after guest reboot + Qemu 1.5-git gpu clock control doesn`t work after guest reboot -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/11755

[Qemu-devel] [Bug 1175513] Re: Qemu 1.5-git gpu clock control doesn`t work after guest reboot

2013-05-02 Thread commiethebeastie
First I added radeon.ko and fglrx.ko to the blacklist. Second I ran the modprobe vfio-pci echo ":02:00.0" > /sys/bus/pci/devices/\:02\:00.0/driver/unbind echo ":02:00.1" > /sys/bus/pci/devices/\:02\:00.1/driver/unbind echo "1002 6739" > /sys/bus/pci/drivers/vfio-pci/new_id echo "1

[Qemu-devel] [Bug 1175513] [NEW] Qemu 1.5.0 gpu clock control doesn`t work after guest reboot

2013-05-02 Thread commiethebeastie
Public bug reported: I run qemu from git with such command: qemu-system-x86_64 -nodefaults -m 4096 -smp 8,cores=4,threads=2,sockets=1 -cpu 'kvm64' -device usb-mouse -M q35 -vga qxl -no-hpet -boot once=c,menu=on -device vfio-pci,host=02:00.0,x-vga=on \ -enable-kvm -monitor stdio -chardev socket

[Qemu-devel] [Bug 1084148] Re: Qt5 Beta 1 QProcess start and execute causes segmentation fault on armhf

2013-05-02 Thread Thomi Richards
** Also affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1084148 Title: Qt5 Beta 1 QProcess start and execute causes segmentation fault on a

[Qemu-devel] [Bug 1175513] Re: Qemu 1.5.0 gpu clock control doesn`t work after guest reboot

2013-05-02 Thread commiethebeastie
** Tags added: vfio-pci ** Attachment added: "lspci -vvvnn" https://bugs.launchpad.net/qemu/+bug/1175513/+attachment/3662420/+files/lspci1.txt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/117551

Re: [Qemu-devel] [PATCH 4/4] usb-host: raise libusbx minimum version to 1.0.13

2013-05-02 Thread Ed Maste
I recently discovered QEMU's libusb support and hoped that this would provide a good solution for the USB host issue on current FreeBSD versions. (Right now the FreeBSD ports tree sets USB_HOST=stub, since the bsd USB code isn't compatible with FreeBSD 8.x and later.) I'm wondering how best to ad

[Qemu-devel] [PATCH 7/7] prep: QOM'ify System I/O

2013-05-02 Thread Hervé Poussineau
Most of the functionality is extracted from hw/ppc/prep.c. Also add support for board identification/equipment registers. Document it for the IBM 43p emulation. Cc: Julio Guerra Signed-off-by: Hervé Poussineau --- docs/ibm_43p.cfg |5 + hw/ppc/Makefile.objs |1 + hw/ppc/prep_sy

[Qemu-devel] [PATCH 4/7] m48t59: register a QOM type for each nvram type we support

2013-05-02 Thread Hervé Poussineau
As m48t59 devices can only be created with m48t59_init() or m48t59_init_isa(), we know exactly which nvram types are required. Register only those three types. Remove .model and .size properties as they can be infered from nvram name. Rename type to 'isa-*' (and 'sysbus-*') to do like other device

[Qemu-devel] [PATCH 6/7] prep: add IBM RS/6000 7248 (43p) machine emulation

2013-05-02 Thread Hervé Poussineau
Machine is very simple (only one PCI host bridge and an ISA bridge). Provide a ibm_43p.cfg file to add more devices to this machine. Syntax is: qemu-system-ppc -M 43p -readconfig ibm_43p.cfg Signed-off-by: Hervé Poussineau --- docs/ibm_43p.cfg | 38 ++ hw/ppc/prep.c| 213

[Qemu-devel] [PATCH 5/7] m48t59: add a Nvram interface

2013-05-02 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/timer/m48t59.c | 61 + include/hw/timer/m48t59.h | 24 ++ 2 files changed, 85 insertions(+) diff --git a/hw/timer/m48t59.c b/hw/timer/m48t59.c index 23a6ab3..3ecb14e 100644 --- a/hw/tim

[Qemu-devel] [PATCH 2/7] qom: handle registration of new types when initializing the first ones

2013-05-02 Thread Hervé Poussineau
When initializing all types in object_class_foreach, called by object_class_get_list, some new types may be registered. Those will change the type internal hashtable which is currently enumerated, and may crash QEMU. Fix it, by adding a second hash table which contains all the non-initialized t

[Qemu-devel] [PATCH 3/7] m48t59: move ISA ports/memory regions registration to QOM constructor

2013-05-02 Thread Hervé Poussineau
-device m48t59_isa can now be used to create a fully functional nvram. Signed-off-by: Hervé Poussineau --- hw/timer/m48t59.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/hw/timer/m48t59.c b/hw/timer/m48t59.c index 45753d8..fb78d20 100644 --- a/hw/timer/m4

[Qemu-devel] [PATCH 1/7] pci: add MPC105 PCI host bridge emulation

2013-05-02 Thread Hervé Poussineau
Non-contiguous I/O is not implemented. There is also somewhere a bug in the memory controller, which means that some real firmwares may not detect the correct amount of memory. This can be bypassed by adding '-m 1G' on the command line. Add x-auto-conf property, to automatically configure the mem

[Qemu-devel] [PATCH 0/7] ppc/prep: add IBM RS/6000 43p machine

2013-05-02 Thread Hervé Poussineau
Hi, This patchset adds an emulation of the IBM RS/6000 43p, also known as 7248. I've fixed comments of Blue Swirl in this series, so I'm sending it as PATCH instead of RFC. Andreas did some preliminary patches for OpenBIOS to support PReP machines, available at git://repo.or.cz/openbios/afaerbe

Re: [Qemu-devel] [PATCH qom-cpu 0/9] x86: feature words array (v11) + "feature-words" property

2013-05-02 Thread Eric Blake
On 05/02/2013 01:43 PM, Eduardo Habkost wrote: >> >> As mentioned earlier I'd prefer to defer the property design rather than >> putting it lightly reviewed into 1.5 and living with some ABI. >> If libvirt urgently needs this info, this series needs to be reviewed >> and sorted out until the weeken

Re: [Qemu-devel] [PATCH qom-cpu 0/9] x86: feature words array (v11) + "feature-words" property

2013-05-02 Thread Eduardo Habkost
On Thu, May 02, 2013 at 12:53:33AM +0200, Andreas Färber wrote: > > Eduardo Habkost (9): > > target-i386: cleanup: Group together level, xlevel, xlevel2 fields > > target-i386/kvm.c: Code formatting changes > > target-i386/cpu.c: Break lines so they don't get too long > > target-i386: Repla

Re: [Qemu-devel] [PATCH qom-cpu for-1.5 2/4] qdev: Introduce qdev_prop_set_custom_globals()

2013-05-02 Thread Eduardo Habkost
On Wed, May 01, 2013 at 06:07:18PM +0200, Andreas Färber wrote: > Reuse it in qdev_prop_set_globals(). > > Signed-off-by: Andreas Färber Very useful to allow us to implement sane bugfixes while the QOM conversion is still work in progress, and much more flexible than having to write special-purp

Re: [Qemu-devel] [PATCH qom-cpu for-1.5 1/4] qdev: Let qdev_prop_parse() pass through Error

2013-05-02 Thread Eduardo Habkost
On Wed, May 01, 2013 at 06:07:17PM +0200, Andreas Färber wrote: > Move error reporting to callers. > > Signed-off-by: Andreas Färber Keeps existing behavior, and makes sense even if the rest of the series doesn't get included. Reviewed-by: Eduardo Habkost > --- > hw/core/qdev-properties.c

[Qemu-devel] [Bug 1084148] Re: Qt5 Beta 1 QProcess start and execute causes segmentation fault on armhf

2013-05-02 Thread Colin Watson
** Tags added: qemu-user-ubuntu -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1084148 Title: Qt5 Beta 1 QProcess start and execute causes segmentation fault on armhf Status in QEMU: New Status

Re: [Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator.

2013-05-02 Thread Jean-Christophe DUBOIS
Peter, Thanks for you review. I have a few questions below. JC On 05/02/2013 02:16 PM, Peter Crosthwaite wrote: Hi Jean-Christophe, Thanks for your contribution. Please run the patch through scripts/checkpatch.pl to check for formatting errors. On Thu, May 2, 2013 at 5:53 AM, Jean-Christoph

Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())

2013-05-02 Thread Anthony Liguori
Paolo Bonzini writes: > Il 02/05/2013 18:06, Michael S. Tsirkin ha scritto: >> On Thu, May 02, 2013 at 10:52:47AM -0500, Anthony Liguori wrote: >>> Peter Maydell writes: >>> On 2 May 2013 16:30, Paolo Bonzini wrote: > /me changes his scripts... > > -s/PATCH/PULL/ if (/PATCH 0+\

Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())

2013-05-02 Thread Anthony Liguori
Peter Maydell writes: > On 2 May 2013 14:51, Michael S. Tsirkin wrote: >> As it is, patchwork is full of patches that were already reviewed and >> merged, all my scripts that were filtering and sorting patches are also >> useless, and I get to wade through each patch for the second time. > > You

Re: [Qemu-devel] [PATCH 0/2] nbd: support large NBD requests

2013-05-02 Thread Paolo Bonzini
Il 02/05/2013 14:23, Stefan Hajnoczi ha scritto: > These patches switch from fixed-size 1 MB data buffers to dynamically sized > buffers in NBD. This is necessary because the Linux nbd driver now allows up > to 32 MB request size. > > Patch 1 gets rid of the request freelist, which becomes pointl

Re: [Qemu-devel] lsi_soft_reset: Assertion `!s->current' failed with Windows XP setup

2013-05-02 Thread Paolo Bonzini
Il 30/04/2013 14:59, Claudio Bley ha scritto: > At Mon, 29 Apr 2013 17:54:37 +0200, > Paolo Bonzini wrote: >> >> Il 12/04/2013 16:02, Claudio Bley ha scritto: >>> Hi. >>> >>> I'm using the latest qemu release 1.4.0 and libvirt 1.0.4. >>> >>> The host system is a Ubuntu 12.04 LTS system, Intel Xeon

Re: [Qemu-devel] [PATCH v7 0/7] push mmio dispatch out of big lock

2013-05-02 Thread Jan Kiszka
On 2013-05-02 18:58, Jan Kiszka wrote: > Hi Pingfan, > > On 2012-12-06 08:28, liu ping fan wrote: >> Any suggestion? Or new design idea for this? > > Finally... I'm getting back to this. I'm currently trying to make use of > this series, adapting it to my needs (selective BQL-free dispatching of

Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())

2013-05-02 Thread Andreas Färber
Am 02.05.2013 18:08, schrieb Peter Maydell: > On 2 May 2013 16:59, Andreas Färber wrote: >> Am 02.05.2013 16:57, schrieb Peter Maydell: >>> Wow, you trust get_maintainer.pl that much? IME it >>> tends to give a huge pile of useless cc suggestions. >> >> Useless? It's based on MAINTAINERS, which I

Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())

2013-05-02 Thread Paolo Bonzini
Il 02/05/2013 18:06, Michael S. Tsirkin ha scritto: > On Thu, May 02, 2013 at 10:52:47AM -0500, Anthony Liguori wrote: >> Peter Maydell writes: >> >>> On 2 May 2013 16:30, Paolo Bonzini wrote: /me changes his scripts... -s/PATCH/PULL/ if (/PATCH 0+\\//); +s/PATCH/PULL/ if (/^S

Re: [Qemu-devel] [PATCH v7 0/7] push mmio dispatch out of big lock

2013-05-02 Thread Jan Kiszka
Hi Pingfan, On 2012-12-06 08:28, liu ping fan wrote: > Any suggestion? Or new design idea for this? Finally... I'm getting back to this. I'm currently trying to make use of this series, adapting it to my needs (selective BQL-free dispatching of PIO regions). Is there a newer version available on

Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())

2013-05-02 Thread Michael S. Tsirkin
On Thu, May 02, 2013 at 05:08:06PM +0100, Peter Maydell wrote: > On 2 May 2013 16:59, Andreas Färber wrote: > > Am 02.05.2013 16:57, schrieb Peter Maydell: > >> Wow, you trust get_maintainer.pl that much? IME it > >> tends to give a huge pile of useless cc suggestions. > > > > Useless? It's based

Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())

2013-05-02 Thread Peter Maydell
On 2 May 2013 16:59, Andreas Färber wrote: > Am 02.05.2013 16:57, schrieb Peter Maydell: >> Wow, you trust get_maintainer.pl that much? IME it >> tends to give a huge pile of useless cc suggestions. > > Useless? It's based on MAINTAINERS, which I expect maintainers to keep > up-to-date if they no

Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())

2013-05-02 Thread Michael S. Tsirkin
On Thu, May 02, 2013 at 10:52:47AM -0500, Anthony Liguori wrote: > Peter Maydell writes: > > > On 2 May 2013 16:30, Paolo Bonzini wrote: > >> /me changes his scripts... > >> > >> -s/PATCH/PULL/ if (/PATCH 0+\\//); > >> +s/PATCH/PULL/ if (/^Subject:/); > >> > >> Yes, Perl... > > > > Heh, I use se

Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())

2013-05-02 Thread Andreas Färber
Am 02.05.2013 16:57, schrieb Peter Maydell: > On 2 May 2013 15:46, Gerd Hoffmann wrote: >> On 05/02/13 16:21, Peter Maydell wrote: >>> I think cc'ing somebody on half a pullrequest or series is >>> a bit odd, personally. >> >> Not uncommon if you do this ... >> >> [sendemail] >> to = q

Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())

2013-05-02 Thread Peter Maydell
On 2 May 2013 16:52, Anthony Liguori wrote: > Peter Maydell writes: >> Heh, I use sed for this bit: >> sed -i -e 's/^Subject: \[PULL\(.*\)].*/Subject: [PULL\1] >> '"$BRANCHPFX"' queue/;/^$/q' "$COVERLETTER" > > You can also just do git format-patch --subject-prefix=PULL and avoid > any fixups...

Re: [Qemu-devel] [PATCH v2] virtio-net: count VIRTIO_NET_F_MAC when calculating config_len

2013-05-02 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] sysemu: drop register_devices from header

2013-05-02 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v21 0/8] Add pvpanic device to deal with guest panic event

2013-05-02 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] libqtest: only call fclose() on open files

2013-05-02 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())

2013-05-02 Thread Anthony Liguori
Peter Maydell writes: > On 2 May 2013 16:30, Paolo Bonzini wrote: >> /me changes his scripts... >> >> -s/PATCH/PULL/ if (/PATCH 0+\\//); >> +s/PATCH/PULL/ if (/^Subject:/); >> >> Yes, Perl... > > Heh, I use sed for this bit: > sed -i -e 's/^Subject: \[PULL\(.*\)].*/Subject: [PULL\1] > '"$BRANCHP

[Qemu-devel] [Bug 1171211] Re: Qemu-kvm 1.4.0 q35 no bootable device

2013-05-02 Thread commiethebeastie
Invalid options ^( ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1171211 Title: Qemu-kvm 1.4.0 q35 no bootable device Status in QEMU: Invalid

Re: [Qemu-devel] [PATCH qom-cpu for-1.5 4/4] target-i386: Change CPUID model of 486 to 8

2013-05-02 Thread Eduardo Habkost
On Wed, May 01, 2013 at 06:07:20PM +0200, Andreas Färber wrote: > This changes the model number of 486 to 8 (DX4) which matches the > feature set presented, and actually has the CPUID instruction. > > This adds a compatibility property, to keep model=0 on pc-*-1.4 and older. > > Signed-off-by: H.

Re: [Qemu-devel] [PATCH 3/3] gtk: add devices menu to allow changing removable block devices

2013-05-02 Thread Anthony Liguori
Kevin Wolf writes: > Am 02.05.2013 um 15:41 hat Anthony Liguori geschrieben: >> Kevin Wolf writes: >> >> > Am 26.04.2013 um 21:43 hat Anthony Liguori geschrieben: >> >> +static void gd_block_device_menu_update(BlockDeviceMenu *bdm, BlockInfo >> >> *info) >> >> +{ >> >> +bool value; >> >> +

Re: [Qemu-devel] [PATCH 3/3] gtk: add devices menu to allow changing removable block devices

2013-05-02 Thread Anthony Liguori
Kevin Wolf writes: > Am 02.05.2013 um 15:41 hat Anthony Liguori geschrieben: >> Kevin Wolf writes: >> >> > >> > Ugh. Comparing the device name to an incomplete set of strings here and >> > then figuring out for each what the specific way for this device is to >> > create a nice string sounds li

Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())

2013-05-02 Thread Peter Maydell
On 2 May 2013 16:30, Paolo Bonzini wrote: > /me changes his scripts... > > -s/PATCH/PULL/ if (/PATCH 0+\\//); > +s/PATCH/PULL/ if (/^Subject:/); > > Yes, Perl... Heh, I use sed for this bit: sed -i -e 's/^Subject: \[PULL\(.*\)].*/Subject: [PULL\1] '"$BRANCHPFX"' queue/;/^$/q' "$COVERLETTER" (I r

Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())

2013-05-02 Thread Paolo Bonzini
Il 02/05/2013 15:51, Michael S. Tsirkin ha scritto: > Anthony, can we please make it a rule that > all patches in pull request are tagged specially? > > As it is, patchwork is full of patches that were already reviewed and > merged, all my scripts that were filtering and sorting patches are also >

Re: [Qemu-devel] [PATCH 3/3] gtk: add devices menu to allow changing removable block devices

2013-05-02 Thread Markus Armbruster
Kevin Wolf writes: > Am 02.05.2013 um 15:41 hat Anthony Liguori geschrieben: >> Kevin Wolf writes: >> >> > Am 26.04.2013 um 21:43 hat Anthony Liguori geschrieben: [...] >> >> + >> >> +if (strcmp(type, "ide-cd") == 0) { >> >> +disk_type = DT_CDROM; >> >> +} else if (s

[Qemu-devel] [Bug 1175513] Re: Qemu 1.5.0 gpu clock control doesn`t work after guest reboot

2013-05-02 Thread Alex Williamson
One-shot use is about the state of the art until we implement a way for vfio to do a bus reset on devices. A couple comments on the usage; we're using the x-vga option to vfio-pci and also using -vga qxl. Without specifying a bus for the vfio-pci device this will put qxl vga and vfio vga both on t

Re: [Qemu-devel] [PATCH qom-cpu 4/9] target-i386: Replace cpuid_*features fields with a feature word array

2013-05-02 Thread Eduardo Habkost
On Thu, May 02, 2013 at 01:03:01AM +0200, Andreas Färber wrote: > Am 22.04.2013 21:00, schrieb Eduardo Habkost: > > This replaces the feature-bit fields on both X86CPU and x86_def_t > > structs with an array. > > > > With this, we will be able to simplify code that simply does the same > > operati

Re: [Qemu-devel] [PATCH v5 0/6] vmdk: zeroed-grain GTE support

2013-05-02 Thread Stefan Hajnoczi
On Thu, May 02, 2013 at 10:25:21AM +0800, Fam Zheng wrote: > Added support for zeroed-grain GTE to VMDK according to VMDK Spec 5.0[1]. > > [1] Virtual Disk Format 5.0 - VMware, > http://www.vmware.com/support/developer/vddk/vmdk_50_technote.pdf?src=vmdk > > Changes since v4: > - 6/6: Correct

Re: [Qemu-devel] [PATCH qom-cpu for-1.5 3/4] target-i386: Emulate X86CPU subclasses for global properties

2013-05-02 Thread Eduardo Habkost
On Wed, May 01, 2013 at 06:07:19PM +0200, Andreas Färber wrote: > After initializing the object from its x86_def_t and before setting any > additional -cpu arguments, set any global properties for the designated > subclass -{i386,x86_64}-cpu. > > Signed-off-by: Andreas Färber > --- > target-i386

Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())

2013-05-02 Thread Stefan Hajnoczi
On Thu, May 02, 2013 at 04:51:43PM +0300, Michael S. Tsirkin wrote: > Anthony, can we please make it a rule that > all patches in pull request are tagged specially? > > As it is, patchwork is full of patches that were already reviewed and > merged, all my scripts that were filtering and sorting pa

Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())

2013-05-02 Thread Peter Maydell
On 2 May 2013 15:46, Gerd Hoffmann wrote: > On 05/02/13 16:21, Peter Maydell wrote: >> I think cc'ing somebody on half a pullrequest or series is >> a bit odd, personally. > > Not uncommon if you do this ... > > [sendemail] > to = qemu-devel@nongnu.org > cccmd = scripts/get_mai

Re: [Qemu-devel] [RFC 7/7] target-i386: Disable direct passthrough of PMU CPUID leaf by default

2013-05-02 Thread Andreas Färber
Am 02.05.2013 16:43, schrieb Eduardo Habkost: > On Wed, May 01, 2013 at 01:14:48PM +0200, Andreas Färber wrote: >> Am 30.04.2013 21:57, schrieb Eduardo Habkost: >>> On Tue, Apr 30, 2013 at 07:04:23PM +0200, Igor Mammedov wrote: It's impossible to implement "n270 movbe" fixup with compat props

Re: [Qemu-devel] [PATCH] blockdev: Replace "undefined error" in qmp_block_resize

2013-05-02 Thread Stefan Hajnoczi
On Thu, May 02, 2013 at 03:32:55PM +0200, Kevin Wolf wrote: > We have an errno value that can be displayed, so we should just do that. > An easy way to reproduce this case is to resize a raw image to a size > that is too large for the host file system. > > Signed-off-by: Kevin Wolf > --- > block

Re: [Qemu-devel] [PATCH] trace: inline control-internal.h into control.h

2013-05-02 Thread Stefan Hajnoczi
On Thu, May 02, 2013 at 04:25:20PM +0200, Lluís Vilanova wrote: > Stefan Hajnoczi writes: > > > trace/control.h is the API for manipulating trace events in QEMU. Some > > of the implementation of this API lives in trace/control-internal.h. > > > Older versions of gcc complain because a static pr

Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())

2013-05-02 Thread Gerd Hoffmann
On 05/02/13 16:21, Peter Maydell wrote: > On 2 May 2013 15:17, Michael S. Tsirkin wrote: >> On Thu, May 02, 2013 at 03:09:04PM +0100, Peter Maydell wrote: > >> Sometimes I'm Cc'd on 1 patch out of series. >> I might not want to go dig out the series only >> to check if it actually needs review. >

Re: [Qemu-devel] [RFC 7/7] target-i386: Disable direct passthrough of PMU CPUID leaf by default

2013-05-02 Thread Eduardo Habkost
On Wed, May 01, 2013 at 01:14:48PM +0200, Andreas Färber wrote: > Am 30.04.2013 21:57, schrieb Eduardo Habkost: > > On Tue, Apr 30, 2013 at 07:04:23PM +0200, Igor Mammedov wrote: > >> It's impossible to implement "n270 movbe" fixup with compat props > >> currently, > >> so 5/7 + 1/7 looks ok. We

Re: [Qemu-devel] [PATCH 1/3] virtio-pci: properly validate address before accessing config

2013-05-02 Thread Andreas Färber
Am 28.04.2013 10:35, schrieb Michael S. Tsirkin: > On Sun, Apr 28, 2013 at 03:54:20PM +0800, Jason Wang wrote: >> On 04/28/2013 03:26 AM, Michael S. Tsirkin wrote: >>> On Fri, Apr 26, 2013 at 04:34:02PM +0800, Jason Wang wrote: There are several several issues in the current checking: >>>

Re: [Qemu-devel] [PATCH] trace: inline control-internal.h into control.h

2013-05-02 Thread Lluís Vilanova
Stefan Hajnoczi writes: > trace/control.h is the API for manipulating trace events in QEMU. Some > of the implementation of this API lives in trace/control-internal.h. > Older versions of gcc complain because a static prototype is used but > the function is defined static inline later on: > C

[Qemu-devel] [PATCH 03/29] cpu: Introduce cpu_resume(), for single CPU

2013-05-02 Thread Andreas Färber
From: Igor Mammedov Also add a stub for it, to make possible to use it in qom/cpu.c, which is shared with user emulators. Signed-off-by: Igor Mammedov Signed-off-by: Andreas Färber --- cpus.c | 11 --- include/qom/cpu.h | 7 +++ stubs/Makefile.objs | 1 + stubs/cp

Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())

2013-05-02 Thread Michael S. Tsirkin
On Thu, May 02, 2013 at 03:21:14PM +0100, Peter Maydell wrote: > On 2 May 2013 15:17, Michael S. Tsirkin wrote: > > On Thu, May 02, 2013 at 03:09:04PM +0100, Peter Maydell wrote: > > > Sometimes I'm Cc'd on 1 patch out of series. > > I might not want to go dig out the series only > > to check if

Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())

2013-05-02 Thread Peter Maydell
On 2 May 2013 15:17, Michael S. Tsirkin wrote: > On Thu, May 02, 2013 at 03:09:04PM +0100, Peter Maydell wrote: > Sometimes I'm Cc'd on 1 patch out of series. > I might not want to go dig out the series only > to check if it actually needs review. I think cc'ing somebody on half a pullrequest or

[Qemu-devel] [PATCH 19/29] target-i386: Attach ICC bus to CPU on its creation

2013-05-02 Thread Andreas Färber
From: Igor Mammedov X86CPU should have parent bus so it could provide bus for child APIC. Signed-off-by: Igor Mammedov Signed-off-by: Andreas Färber --- hw/i386/pc.c | 10 ++ hw/i386/pc_piix.c| 2 +- hw/i386/pc_q35.c | 2 +- include/hw/i386/pc.h | 2 +- target-i386/

  1   2   >