On 2 May 2013 16:59, Andreas Färber <afaer...@suse.de> wrote: > Am 02.05.2013 16:57, schrieb Peter Maydell: >> Wow, you trust get_maintainer.pl that much? IME it >> tends to give a huge pile of useless cc suggestions. > > Useless? It's based on MAINTAINERS, which I expect maintainers to keep > up-to-date if they no longer want to maintain something. It's rather > that new files don't get entries and thus too few CCs at times IME.
The ccs based on MAINTAINERS are fine -- it's the random extras it picks based on other people who've made patches to the same files in the past that are usually wrong. For example I tried running it on a patch to MAINTAINERS itself, and it suggested ccing you, Alex, Stefan H, Peter Crosthwaite and Edgar, which is a random mishmash and doesn't include the key person you actually need to CC, ie Anthony. The actual rule as far as I can tell for CCs is "if file is explicitly listed in MAINTAINERS, cc those people; otherwise CC either Blue and Aurelien [if a random target-* patch] or Anthony [everything else]; cc trivial if sufficiently small; also for bugfixes CC whoever wrote the commit you're fixing". get_maintainer.pl doesn't do that, so I just write CCs manually. thanks -- PMM
