From: Liu Yuan
The 'TRIM' command from VM that is to release underlying data storage for
better thin-provision is already supported by the Sheepdog.
This patch adds the TRIM support at QEMU part.
For older Sheepdog that doesn't support it, we return EIO to upper layer.
Cc: MORITA Kazutaka
Cc:
From: Liu Yuan
The 'TRIM' command from VM that is to release underlying data storage for
better thin-provision is already supported by the Sheepdog.
This patch adds the TRIM support at QEMU part.
For older Sheepdog that doesn't support, we return EIO to upper layer.
Cc: MORITA Kazutaka
Cc: Ke
Public bug reported:
I would like to point out that identifiers like the following do not fit to the
expected naming convention of the C language standard.
- __COMMAND_H__
http://git.qemu.org/?p=qemu.git;a=blob;f=cmd.h;hb=64b85a8f2359ca3a995499afaf3c87d8e036e030#l17
- _QEMU_OPTIONS_H_
http
GetLastError() returns a DWORD value which is unsigned long,
so the correct format specifier is %lu.
Signed-off-by: Stefan Weil
---
Debian's w32 cross compiler does not complain about the wrong
specifiers, but the w64 cross compiler does.
I'm sorry that I did not notice this before sending the
Thanks, applied all.
On Thu, Apr 11, 2013 at 4:07 PM, Markus Armbruster wrote:
> This should unbreak "make check" on machines where char is unsigned.
> Blue, please give it a whirl.
>
> The JSON parser is still as broken as ever. Left for another day.
>
> v2:
> - Rebased, trivial conflicts in PA
You are correct about what the instruction is supposed to do. That said
the behaviour you describe is not reproducible. Which version of QEMU
are you using? Could you please send a testcase?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to Q
On Fri, Apr 12, 2013 at 04:37:52PM +0100, Peter Maydell wrote:
> In handling float64_muladd, if we end up doing a subtraction of the
> product and c, and the 128 bit result of this subtraction happens to
> have its most significant bit in bit 63, we weren't handling this
> correctly when attempting
On 13 April 2013 13:47, Aurelien Jarno wrote:
> fabs, fnabs and fneg are just flipping the bit sign of an FP register,
> this can be implemented in TCG instead of using softfloat.
> +tcg_gen_andi_i64(cpu_fpr[rD(ctx->opcode)], cpu_fpr[rB(ctx->opcode)],
> + ~(1LL << 63));
"1
On Fri, Jan 25, 2013 at 06:35:41PM +0800, Jason Wang wrote:
> This patch implements both userspace and vhost support for multiple queue
> virtio-net (VIRTIO_NET_F_MQ). This is done by introducing an array of
> VirtIONetQueue to VirtIONet.
>
> Signed-off-by: Jason Wang
> ---
> hw/virtio-net.c |
Power ISA 2.05 adds support for extended mtfsf/mtfsfi form, with a new
W field to select the upper part of the FPCSR register.
For that the helper is changed to handle 64-bit input values and mask with
up to 16 bits. The mtfsf/mtfsfi instructions do not have the W bit
marked as invalid anymore. In
Needed for Power ISA version 2.05 compliance.
Cc: Alexander Graf
Signed-off-by: Aurelien Jarno
---
target-ppc/translate.c | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index e928f6b..647c31f 100644
--- a
Needed for Power ISA version 2.05 compliance.
Cc: Alexander Graf
Signed-off-by: Aurelien Jarno
---
target-ppc/translate.c | 48
1 file changed, 48 insertions(+)
diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index 248e8ca..4ea701
fabs, fnabs and fneg are just flipping the bit sign of an FP register,
this can be implemented in TCG instead of using softfloat.
Cc: Alexander Graf
Signed-off-by: Aurelien Jarno
---
target-ppc/fpu_helper.c | 31 ---
target-ppc/helper.h |3 ---
target-ppc/t
Needed for Power ISA version 2.05 compliance.
Cc: Alexander Graf
Signed-off-by: Aurelien Jarno
---
target-ppc/translate.c | 38 ++
1 file changed, 38 insertions(+)
diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index 80b7111..1286ad2 100644
-
.. and enable it on POWER7 CPU.
Cc: Alexander Graf
Signed-off-by: Aurelien Jarno
---
target-ppc/cpu.h|4 +++-
target-ppc/translate_init.c |2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h
index 42c36e2..8b0b651 100644
-
Needed for Power ISA version 2.05 compliance.
Cc: Alexander Graf
Signed-off-by: Aurelien Jarno
---
target-ppc/translate.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index 1286ad2..e928f6b 100644
--- a/target-ppc/translat
Needed for Power ISA version 2.05 compliance.
Cc: Alexander Graf
Signed-off-by: Aurelien Jarno
---
target-ppc/helper.h |1 +
target-ppc/int_helper.c | 15 +++
target-ppc/translate.c |8
3 files changed, 24 insertions(+)
diff --git a/target-ppc/helper.h b/tar
Needed for Power ISA version 2.05 compliance.
Cc: Alexander Graf
Signed-off-by: Aurelien Jarno
---
target-ppc/translate.c | 48
1 file changed, 48 insertions(+)
diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index 647c31f..248e8c
qemu-system-ppc64 -M pseries clamis to emulate a POWER7 CPU,
corresponding to an ISA 2.06 compliant CPU, while QEMU emulates
something like an ISA 2.04 CPU.
Given that glibc and GCC start to use some instructions like cmpb and
fcpsgn, this starts to be problematic.
This patches series improves th
Cc: Alexander Graf
Signed-off-by: Aurelien Jarno
---
disas.c |1 +
1 file changed, 1 insertion(+)
diff --git a/disas.c b/disas.c
index 74d3ba0..89c8890 100644
--- a/disas.c
+++ b/disas.c
@@ -227,6 +227,7 @@ void target_disas(FILE *out, CPUArchState *env,
target_ulong code,
s.info.
On Tue, Apr 09, 2013 at 07:10:29PM +0200, Andreas Färber wrote:
> Am 09.04.2013 17:29, schrieb Peter Maydell:
> > On 9 April 2013 15:51, Andreas Färber wrote:
> >> This brings us a step closer to QOM'ified SH7750 SoC and
> >> fixes b350ab75 (target-sh4: Move PVR/PRR/CVR into SuperHCPUClass)
> >> a
On Fri, Apr 12, 2013 at 06:34:42PM +0200, Stefan Weil wrote:
> Hello Anthony,
>
> please pull these patches for QEMU git master.
> All of them were reviewed on qemu-devel.
>
> Thanks,
> Stefan W.
>
> The following changes since commit 93b48c201eb6c0404d15550a0eaa3c0f7937e35e:
>
> virtio-9p: F
On Fri, Apr 12, 2013 at 04:38:18PM +0200, Stefan Hajnoczi wrote:
> v2:
> * Andreas Färber noticed my patch scripts aren't unicode safe, fix his name
>
> The following changes since commit 93b48c201eb6c0404d15550a0eaa3c0f7937e35e:
>
> virtio-9p: Fix virtio-9p no longer building after hw-dirs br
On Thu, Apr 11, 2013 at 08:15:39PM +0200, Stefan Weil wrote:
> Hello Anthony,
>
> please pull these five patches for TCI. They fix a regression caused
> by commit 378df4b23753a11be650af7664ca76bc75cb9f01 and include
> some improvements.
>
> Thanks,
>
> Stefan Weil
>
>
> The following changes s
On Fri, Apr 05, 2013 at 01:47:28PM -0500, Richard Henderson wrote:
> Here's the latest set of tcg-s390 updates. The only real change
> from v1 is the addition of the last patch. This is able to run
> the i386-softmmu nbench test, and boot both arm and sparc32 kernels.
>
> I tried to look at addr
On Thu, Apr 04, 2013 at 05:56:10PM -0500, Richard Henderson wrote:
> Using a table to look up insns of the right width and sign.
> Include support for the Power 2.06 LDBRX and STDBRX insns.
>
> Signed-off-by: Richard Henderson
> ---
> tcg/ppc64/tcg-target.c | 166
> +
On Thu, Apr 04, 2013 at 05:56:09PM -0500, Richard Henderson wrote:
> The enhancements to and immediate obviate this.
>
> Signed-off-by: Richard Henderson
> ---
> tcg/ppc64/tcg-target.c | 5 -
> tcg/ppc64/tcg-target.h | 6 +++---
> 2 files changed, 3 insertions(+), 8 deletions(-)
>
> diff --
On Thu, Apr 04, 2013 at 05:56:08PM -0500, Richard Henderson wrote:
> Use RLDICL and RLDICR.
>
> Signed-off-by: Richard Henderson
> ---
> tcg/ppc64/tcg-target.c | 64
> +++---
> 1 file changed, 50 insertions(+), 14 deletions(-)
>
> diff --git a/tcg/pp
On Thu, Apr 04, 2013 at 05:55:53PM -0500, Richard Henderson wrote:
> Changes v3-v4:
>
> There were two problems, both related to the setcond opcode:
>
> * The first was pre-existing: the current code gets 32-bit NE wrong,
> failing to ignore the high 32-bits of the register. This problem
>
On Mon, Apr 01, 2013 at 09:23:19PM -0700, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
> ---
> tcg/ppc64/tcg-target.c | 43 +++
> tcg/ppc64/tcg-target.h | 18 ++
> 2 files changed, 53 insertions(+), 8 deletions(-)
>
> diff --
On Mon, Apr 01, 2013 at 09:23:28PM -0700, Richard Henderson wrote:
> Glibc 2.16 includes an easy way to get feature bits previously
> buried in /proc or the program startup auxiliary vector. Use it.
>
> Signed-off-by: Richard Henderson
> ---
> configure | 18 ++
> t
On Mon, Apr 01, 2013 at 09:23:17PM -0700, Richard Henderson wrote:
> Using a table to look up insns of the right width and sign.
> Include support for the Power 2.05 LDBRX and STDBRX insns
> included in e.g. Power6.
>
> Signed-off-by: Richard Henderson
> ---
> tcg/ppc64/tcg-target.c | 166
> +++
On Mon, Apr 01, 2013 at 09:23:16PM -0700, Richard Henderson wrote:
> Use RLDICL and RLDICR.
>
> Signed-off-by: Richard Henderson
> ---
> tcg/ppc64/tcg-target.c | 64
> +++---
> 1 file changed, 50 insertions(+), 14 deletions(-)
>
> diff --git a/tcg/pp
On Mon, Apr 01, 2013 at 09:23:03PM -0700, Richard Henderson wrote:
> Changes v2-v3:
> * Incorporated feedback from Aurelien's review.
>
> Tree updated at
>
> git://github.com/rth7680/qemu.git tcg-ppc64
>
> r~
>
>
>
> Richard Henderson (27):
> disas: Disassemble all ppc insns for the hos
From: Liu Yuan
The 'TRIM' command from VM that is to release underlying data storage for
better thin-provision is already supported by the Sheepdog.
This patch adds the TRIM support at QEMU part.
For older Sheepdog that doesn't support, we return EIO to upper layer.
Cc: MORITA Kazutaka
Cc: Ke
From: Liu Yuan
Signed-off-by: Liu Yuan
---
tests/058 | 30 ++
tests/058.out | 44
tests/group |1 +
3 files changed, 75 insertions(+)
create mode 100755 tests/058
create mode 100644 tests/058.out
diff --gi
From: Liu Yuan
Signed-off-by: Liu Yuan
---
include/sheepdog_proto.h |1 +
sheep/ops.c | 20
2 files changed, 21 insertions(+)
diff --git a/include/sheepdog_proto.h b/include/sheepdog_proto.h
index f3d69e1..99a6627 100644
--- a/include/sheepdog_proto.h
++
From: Liu Yuan
Signed-off-by: Liu Yuan
---
sheep/object_cache.c |2 +-
sheep/sheep_priv.h |4 ++--
sheep/store.c|6 +++---
sheep/vdi.c | 16
4 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/sheep/object_cache.c b/sheep/object_cac
From: Liu Yuan
Trim/discard is a command that allows VM to inform underlying storage system to
release unused space. Sheepdog takes use of this command to release unused
objects for better thin-provision.
This patch set aims to add trim/discard support to both Sheepdog and QEMU's
Sheepdog block
The code is simply moved into a separate function.
Signed-off-by: Wenchao Xia
---
blockdev.c | 20 +---
1 files changed, 13 insertions(+), 7 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 8d1faf8..38cb7d5 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -877,6 +877,18 @@
Signed-off-by: Wenchao Xia
---
blockdev.c | 12 +---
1 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 38cb7d5..3e69569 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -889,6 +889,14 @@ static void external_snapshot_commit(BlockdevAction
*action,
The code is moved into preparation function, and is changed
a bit to tip more clearly what it is doing.
Signed-off-by: Wenchao Xia
---
blockdev.c | 38 +++---
1 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index e01906
The code before really committing is moved into a function. Most
code are simply moved from qmp_transaction()i, except fail handling
label is changed from "delete_and_fail" to "fail". Other code such
as input parsing is not touched, to make it easier in review.
Signed-off-by: Wenchao Xia
---
b
Now qmp_transaction() can be extended with other operation,
external snapshot or backing chain creation, is just one case it.
Signed-off-by: Wenchao Xia
---
blockdev.c | 68 +++
1 files changed, 58 insertions(+), 10 deletions(-)
diff -
This serial will package backing chain snapshot code as one case, to make it
possible adding more operations later.
v2:
Address Kevin's comments:
Use the same prototype prepare, commit, rollback model in original code,
commit should never fail.
Wenchao Xia (5):
block: package preparation
To make it clear about id and name in searching, the API is changed
a bit to distinguish them, and caller can choose to search by id or name.
Searching will be done with higher priority of id. This function also
returns negative value from bdrv_snapshot_list() instead of -ENOENT on
error now.
N
This interface returns info of valid internal snapshots for whole vm.
Signed-off-by: Wenchao Xia
---
block/qapi.c | 17 +++
qapi-schema.json | 14 +
qmp-commands.hx | 58 ++
3 files changed, 89 insertions(+)
With these parameters, user can choose the information to be showed,
to avoid message flood in the monitor.
Signed-off-by: Wenchao Xia
Reviewed-by: Kevin Wolf
---
hmp.c | 23 +++
monitor.c |7 ---
2 files changed, 19 insertions(+), 11 deletions(-)
diff --git
This patch using new added function in last commit which retrieve
info from qmp for snapshot info.
Signed-off-by: Wenchao Xia
Reviewed-by: Kevin Wolf
Reviewed-by: Eric Blake
---
monitor.c |2 +-
savevm.c | 65 -
2 files chang
Now human monitor can show image details, include internal
snapshot and backing chain info for every block device.
Signed-off-by: Wenchao Xia
---
hmp.c | 12
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/hmp.c b/hmp.c
index cef5eee..1d13030 100644
--- a/hmp.c
+
This function will simply call qmp interface qmp_query_snapshots()
added in last commit and then dump information in monitor console.
To get snapshot info, Now qemu and qemu-img both call block layer
function bdrv_query_snapshot_info_list() in their calling path, and
then they just translate th
This patch adds block/snapshot.c and then moves the function
there. It also fixes small code style errors reported by check script.
Signed-off-by: Wenchao Xia
Reviewed-by: Eric Blake
Reviewed-by: Kevin Wolf
---
block/Makefile.objs |1 +
block/snapshot.c | 48 ++
New member *backing-image is added to reflect the backing chain
status.
Signed-off-by: Wenchao Xia
---
block/qapi.c | 18 +-
qapi-schema.json |5 -
2 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/block/qapi.c b/block/qapi.c
index 13c7860..2f33a05 1
This patch introduce a new print function, which will output message to
monitor when it present. With it, bdrv_snapshot_dump() need no more buffer
and can avoid string truncation, bdrv_image_info_dump() can also be used by
hmp code later, besides qemu-img code.
Signed-off-by: Wenchao Xia
---
b
Now image info will be retrieved as an embbed json object inside
BlockDeviceInfo, backing chain info and all related internal snapshot
info can be got in the enhanced recursive structure of ImageInfo.
Signed-off-by: Wenchao Xia
---
block/qapi.c | 40 ++--
incl
Original logic is different with load_vmstate(), this patch change it
to be exactly the same with load_vmstate(), so any VM snapshot shown in
qmp/hmp should succeed in load_vmstate().
Note that, runtime snapshot info maybe different with what is got
in "qemu-img info" as static snapshot info, a
They are needed later in hmp command, dump_human_image_info()
is renamed to bdrv_image_info_dump().
Signed-off-by: Wenchao Xia
Reviewed-by: Kevin Wolf
---
block.c | 33
block/qapi.c | 100 +
include/blo
This patch adds a parameter to tell whether return valid snapshots
for whole VM only.
Note that the snapshot check logic is copied from do_info_snapshots(),
which is different with load_vmstate() and will be changed in next patch.
Signed-off-by: Wenchao Xia
Reviewed-by: Eric Blake
Reviewed-b
This patch adds function bdrv_query_snapshot_info_list(), which will
retrieve snapshot info of an image in qmp object format. The implementation
is based on the code moved from qemu-img.c with modification to fit more
for qmp based block layer API.
Signed-off-by: Wenchao Xia
Reviewed-by: Eric B
This patch adds function bdrv_query_image_info(), which will
retrieve image info in qmp object format. The implementation is
based on the code moved from qemu-img.c, but uses block layer
function to get snapshot info.
Signed-off-by: Wenchao Xia
---
block/qapi.c | 37 +
This is a code move patch, except in qmp_query_block bdrv_next(bs)
is used instead of direct traverse of global array 'bdrv_states'.
This patch also fix code style error reported by check script.
Signed-off-by: Wenchao Xia
Reviewed-by: Kevin Wolf
Reviewed-by: Eric Blake
---
block.c
This patch adds block/qapi.c and moves the functions there. To avoid
conflict and tip better, macro in header file is BLOCK_QAPI_H instead
of QAPI_H. The moving is for making review easier, those functions
will be modified and renamed later.
Signed-off-by: Wenchao Xia
Reviewed-by: Eric Blake
R
Parameter *fmt was not used, so remove it.
Signed-off-by: Wenchao Xia
Reviewed-by: Eric Blake
Reviewed-by: Kevin Wolf
---
qemu-img.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 31627b0..937ec01 100644
--- a/qemu-img.c
+++ b/qemu-
This serial let qmp interface show info for internal snapshot/backing chain
on all block device at runtime, it helps management stack to find the correct
image to merge when qemu is running, and retrieve exactly the same info of what
qemu saws, avoiding async trouble if management stack use qemu-
64 matches
Mail list logo
