[Qemu-devel] rpiqemuwindows bug

2013-04-05 Thread Gaston Gutierrez
Hello, I installed rpiqemuwindows in a lenovo T420, 64bits, intel core i5 2.5GHz, 4GB RAM, win7 motebok. At running 2013-02-09-wheezy-raspbian.img, the boot process enters in a loop and throws INIT: Id "1" respawning too fast :: disabled for 5 minutes. This is a image bug or qemu is not full comp

Re: [Qemu-devel] [PATCH 02/24] hw/vmware_vga.c: fix screen resize bug introduced after console revamp

2013-04-05 Thread Alexandru Damian
+1, verified to work with both 16-bit and 32-bit depth consoles. Alex On Thu, Apr 04, 2013 at 09:28:44AM +0200, Gerd Hoffmann wrote: > From: Igor Mitsyanko > > In vmsvga display update function, a pointer to DisplaySurface must be > acquired > after a call to vmsvga_check_size since this func

Re: [Qemu-devel] sparc-linux-user: Fix missing symbols in .rel/.rela.plt sections

2013-04-05 Thread Michael Tokarev
This patch was submitted more than a year ago (at Jan-2012). Is it still needed? If yes, why it hasn't been applied? It still applies cleanly to the current git, with the exception of s|^|ldscripts/| - sparc.ld moved from the top directory to ldscripts/. (Ref: http://patchwork.ozlabs.org/patch/1

Re: [Qemu-devel] [PATCH v2 0/2] configure: fix coroutine backend selection logic

2013-04-05 Thread Brad Smith
On Thu, Apr 04, 2013 at 11:22:22AM +0100, Peter Maydell wrote: > Ping^2! > > PS: I note that the patches script doesn't list a patch > in the 'to:foo' list if foo was forgotten on initial send but > cc'd on subsequent pings... > > thanks > -- PMM I'd love to see this go in. This would remove the

Re: [Qemu-devel] Virtualbox svga card in KVM

2013-04-05 Thread Sriram Murthy
For starters, virtual box has better SVGA WDDM drivers that allows for a much richer display when the VM display is local. I am yet to completely understand both the KVM and the virtualbox SVGA card (actually, the virtualbox SVGA card is based off of the KVM VGA card), so I may not be the author

Re: [Qemu-devel] [PATCH 0/2] Allow xen guests to plug disks of 1 TiB or more

2013-04-05 Thread Stefano Stabellini
Ian, you might want to apply these two fixes to qemu-xen-traditional. On Wed, 3 Apr 2013, Felipe Franciosi wrote: > This series fixes an issue where disks of 1 TiB or more cannot be added > to a xen guest. The problem lies in the xen backend driver using a 32 bit > integer xenstore interface to w

Re: [Qemu-devel] [PATCH 3/3] PPC PReP: can run without bios image

2013-04-05 Thread Scott Wood
On 04/04/2013 06:59:24 AM, Alexander Graf wrote: On 04.04.2013, at 13:53, Andreas Färber wrote: > For PReP, Fabien has not stated what his use case actually is (in > particular which hardware?), so it's hard for me to comment on what the > hardware actually does and I thus won't accept rando

[Qemu-devel] [PATCH 18/22] target-i386: move APIC to ICC bus

2013-04-05 Thread Igor Mammedov
... to allow it to be hotplugged * map APIC's mmio at board level if it is present Signed-off-by: Igor Mammedov --- v2: * fix compile error "cpu may be used uninitialized" with --enable-werror but without --enable-debug. --- hw/apic_common.c | 17 - hw/apic_internal.h

Re: [Qemu-devel] [PATCH 18/22] target-i386: move APIC to ICC bus

2013-04-05 Thread Igor Mammedov
On Fri, 5 Apr 2013 13:15:03 -0300 Eduardo Habkost wrote: > On Fri, Apr 05, 2013 at 04:37:10PM +0200, Igor Mammedov wrote: > [...] > > void pc_cpus_init(const char *cpu_model) > > { > > int i; > > +X86CPU *cpu; > > Error *error = NULL; > > +SysBusDevice *ib; > > > > /* i

Re: [Qemu-devel] RFC: vfio API changes needed for powerpc (v3)

2013-04-05 Thread Scott Wood
On 04/04/2013 05:10:27 PM, Yoder Stuart-B08248 wrote: /* * VFIO_IOMMU_PAMU_UNMAP_MSI_BANK * * Unmaps the MSI bank at the specified iova. * Caller provides struct vfio_pamu_msi_bank_unmap with all fields set. * Operates on VFIO file descriptor (/dev/vfio/vfio). * Return: 0 on success, -er

Re: [Qemu-devel] [PATCHv5 06/10] migration: search for zero instead of dup pages

2013-04-05 Thread Peter Lieven
Am 05.04.2013 um 22:00 schrieb Paolo Bonzini : > Il 05/04/2013 21:23, Kevin Wolf ha scritto: virtually all dup pages are zero pages. remove the special is_dup_page() function and use the optimized buffer_find_nonzero_offset() function instead. here buffer_find_nonze

Re: [Qemu-devel] [PATCHv5 06/10] migration: search for zero instead of dup pages

2013-04-05 Thread Peter Lieven
Am 05.04.2013 um 22:00 schrieb Paolo Bonzini : > Il 05/04/2013 21:23, Kevin Wolf ha scritto: virtually all dup pages are zero pages. remove the special is_dup_page() function and use the optimized buffer_find_nonzero_offset() function instead. here buffer_find_nonze

Re: [Qemu-devel] [PATCHv2] rdma: add a new IB_ACCESS_GIFT flag

2013-04-05 Thread Michael R. Hines
Well, I have the "is_dup_page()" commented out...when RDMA is activated. Is there something else in QEMU that could be touching the page that I don't know about? - Michael On 04/05/2013 05:03 PM, Roland Dreier wrote: On Fri, Apr 5, 2013 at 1:51 PM, Michael R. Hines wrote: Sorry,

Re: [Qemu-devel] [PATCHv2] rdma: add a new IB_ACCESS_GIFT flag

2013-04-05 Thread Roland Dreier
On Fri, Apr 5, 2013 at 1:51 PM, Michael R. Hines wrote: > Sorry, I was wrong. ignore the comments about cgroups. That's still broken. > (i.e. trying to register RDMA memory while using a cgroup swap limit cause > the process get killed). > > But the GIFT flag patch works (my understanding is that

Re: [Qemu-devel] [PATCHv2] rdma: add a new IB_ACCESS_GIFT flag

2013-04-05 Thread Michael R. Hines
To be more specific, here's what I did: 1. apply kernel module patch - re-insert module 1. QEMU does: ibv_reg_mr(IBV_ACCESS_GIFT | IBV_ACCESS_REMOTE_READ) 2. Start the RDMA migration 3. Migration completes without any errors This test does *not* work with a cgroup swap limit, however. Th

Re: [Qemu-devel] [PATCHv2] rdma: add a new IB_ACCESS_GIFT flag

2013-04-05 Thread Michael R. Hines
Sorry, I was wrong. ignore the comments about cgroups. That's still broken. (i.e. trying to register RDMA memory while using a cgroup swap limit cause the process get killed). But the GIFT flag patch works (my understanding is that GIFT flag allows the adapter to transmit stale memory informat

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-04-05 Thread Michael R. Hines
FYI, I used the following redhat cgroups instructions, to test if overcommit + RDMA was working: https://access.redhat.com/site/documentation/en-US/Red_Hat_Enterprise_Linux/6/html/Resource_Management_Guide/sec-memory.html - Michael On 03/21/2013 02:11 AM, Michael S. Tsirkin wrote: On Tue, Mar

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-04-05 Thread Michael R. Hines
On 03/21/2013 02:11 AM, Michael S. Tsirkin wrote: On Tue, Mar 19, 2013 at 01:49:34PM -0400, Michael R. Hines wrote: I also did a test using RDMA + cgroup, and the kernel killed my QEMU :) So, infiniband is not smart enough to know how to avoid pinning a zero page, I guess. - Michael On 03/19/

Re: [Qemu-devel] [PATCHv2] rdma: add a new IB_ACCESS_GIFT flag

2013-04-05 Thread Roland Dreier
On Fri, Apr 5, 2013 at 1:17 PM, Michael R. Hines wrote: > I also removed the IBV_*_WRITE flags on the sender-side and activated > cgroups with the "memory.memsw.limit_in_bytes" activated and the migration > with RDMA also succeeded without any problems (both with *and* without GIFT > also worked).

Re: [Qemu-devel] [PATCHv2] rdma: add a new IB_ACCESS_GIFT flag

2013-04-05 Thread Michael R. Hines
The userland part of the patch was missing (IBV_ACCESS_GIFT). I added flag that to /usr/include in addition to this patch and did a test RDMA migrate and it seems to work without any problems. I also removed the IBV_*_WRITE flags on the sender-side and activated cgroups with the "memory.memsw

Re: [Qemu-devel] [PATCHv5 06/10] migration: search for zero instead of dup pages

2013-04-05 Thread Paolo Bonzini
Il 05/04/2013 21:23, Kevin Wolf ha scritto: >> > virtually all dup pages are zero pages. remove >> > the special is_dup_page() function and use the >> > optimized buffer_find_nonzero_offset() function >> > instead. >> > >> > here buffer_find_nonzero_offset() is used directly >> > to avoid the unne

[Qemu-devel] [PATCH 4/4] qemu-iotests: A few more bdrv_pread/pwrite tests

2013-04-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- tests/qemu-iotests/002 | 13 + tests/qemu-iotests/002.out | 26 ++ 2 files changed, 39 insertions(+) diff --git a/tests/qemu-iotests/002 b/tests/qemu-iotests/002 index bebed84..51d0a8f 100755 --- a/tests/qemu-iotests/002 +++ b

[Qemu-devel] [PATCH 2/4] savevm: Implement block_writev_buffer()

2013-04-05 Thread Kevin Wolf
Instead of breaking up RAM state into many small chunks, pass the iovec to the block layer for better performance. Signed-off-by: Kevin Wolf --- include/migration/qemu-file.h | 2 +- savevm.c | 25 + 2 files changed, 22 insertions(+), 5 deletions(-)

[Qemu-devel] [PATCH 0/4] block: Vectored bdrv_writev_vmstate

2013-04-05 Thread Kevin Wolf
This gives us back reasonable savevm performance, which regressed in commit 500f0061. Kevin Wolf (4): block: Introduce bdrv_writev_vmstate savevm: Implement block_writev_buffer() block: Introduce bdrv_pwritev() for qcow2_save_vmstate qemu-iotests: A few more bdrv_pread/pwrite tests block

[Qemu-devel] [PATCH 1/4] block: Introduce bdrv_writev_vmstate

2013-04-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block.c | 25 - block/qcow2.c | 12 +--- block/sheepdog.c | 13 ++--- include/block/block.h | 1 + include/block/block_int.h | 4 ++-- 5 files changed, 42 insertions(+), 13 deletions

[Qemu-devel] [PATCH 3/4] block: Introduce bdrv_pwritev() for qcow2_save_vmstate

2013-04-05 Thread Kevin Wolf
Directly pass the QEMUIOVector on instead of linearising it. Signed-off-by: Kevin Wolf --- block.c | 80 +-- block/qcow2.c | 8 +- include/block/block.h | 2 ++ 3 files changed, 61 insertions(+), 29 deletions(-) diff --

Re: [Qemu-devel] [PATCH 1/8] virtio-blk-x: fix configuration synchronization.

2013-04-05 Thread Anthony Liguori
Peter Maydell writes: > On 5 April 2013 17:47, Anthony Liguori wrote: >> Kevin Wolf writes: >> >>> From: KONRAD Frederic >>> >>> The virtio-blk-x configuration is not in sync with virtio-blk configuration. >>> So this patch remove the virtio-blk-x configuration field, and use >>> virtio-blk >

Re: [Qemu-devel] [PATCHv5 06/10] migration: search for zero instead of dup pages

2013-04-05 Thread Kevin Wolf
Am 26.03.2013 um 10:58 hat Peter Lieven geschrieben: > virtually all dup pages are zero pages. remove > the special is_dup_page() function and use the > optimized buffer_find_nonzero_offset() function > instead. > > here buffer_find_nonzero_offset() is used directly > to avoid the unnecssary addit

Re: [Qemu-devel] [PATCH arm-devs v1 15/15] xilinx_spips: lqspi: Fix byte/misaligned access

2013-04-05 Thread Peter Maydell
On 3 April 2013 05:33, Peter Crosthwaite wrote: > The LQSPI bus attachment supports byte/halfword and misaligned > accesses. Fixed. Refactored the LQSPI cache to be byte-wise > instead of word wise accordingly. > > Signed-off-by: Peter Crosthwaite > --- > > hw/xilinx_spips.c | 31 +

Re: [Qemu-devel] [PATCH arm-devs v1 11/15] xilinx_spips: Fix striping behaviour

2013-04-05 Thread Peter Maydell
On 3 April 2013 05:33, Peter Crosthwaite wrote: > The QSPI controller was using byte-wide stripes when striping across > the two flashes in dual parallel mode. The real hardware however uses > individual bit striping. QEMU misbehaves in the (corner) case where > data is written/read in dual-parall

Re: [Qemu-devel] [PATCH arm-devs v1 10/15] xilinx_spips: Fix CTRL register RW bits

2013-04-05 Thread Peter Maydell
On 3 April 2013 05:33, Peter Crosthwaite wrote: > The CTRL register was RAZ/WI on some of the RW bits. Even though the > function behind these bits is invalid in QEMU, they should still be > guest accessible. Fix. > > Signed-off-by: Peter Crosthwaite > --- > > hw/xilinx_spips.c |4 ++-- > 1

Re: [Qemu-devel] [PATCH arm-devs v1 06/15] xilinx_spips: Fix QSPI FIFO size

2013-04-05 Thread Peter Maydell
On 3 April 2013 05:32, Peter Crosthwaite wrote: > QSPI has a bigger FIFO than the regular SPI controller. Differentiate > between the two with correct FIFO sizes for each. > > Signed-off-by: Peter Crosthwaite > --- > > hw/xilinx_spips.c |7 +++ > 1 files changed, 7 insertions(+), 0 delet

Re: [Qemu-devel] [PATCH arm-devs v1 07/15] xilinx_spips: Trash LQ page cache on mode change

2013-04-05 Thread Peter Maydell
On 3 April 2013 05:32, Peter Crosthwaite wrote: > Invalidate the LQSPI cached page when transitioning into LQSPI mode. > Otherwise there is a possibility that the controller will return stale > data to the guest when transitioning back to LQ_MODE after a page > program. > > Signed-off-by: Peter Cr

[Qemu-devel] [PULL v2 10/13] tcg-s390: Cleanup argument shuffling fixme in softmmu code

2013-04-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 85 +++ 1 file changed, 38 insertions(+), 47 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index 2bab245..43a0de8 100644 --- a/tcg/s390/tcg-target.c +++ b/tcg/s3

[Qemu-devel] [PULL v2 13/13] tcg-s390: Fix merge error in tgen_brcond

2013-04-05 Thread Richard Henderson
When the TCG condition codes were re-organized last year, we failed to update all of the "old-style" tests for unsigned. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c in

[Qemu-devel] [PULL v2 12/13] tcg-s390: Use all 20 bits of the offset in tcg_out_mem

2013-04-05 Thread Richard Henderson
This can save one insn, if the constant has any bits in 32-63 set, but no bits in 21-31 set. It never results in more insns. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/t

[Qemu-devel] [PULL v2 11/13] tcg-s390: Use load-address for addition

2013-04-05 Thread Richard Henderson
Since we're always in 64-bit mode, load address performs a full 64-bit add. Use that for 3-address addition, as well as for larger constant addends when we lack extended-immediates facility. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 113 +--

[Qemu-devel] [PULL v2 07/13] tcg-s390: Implement deposit opcodes

2013-04-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 24 tcg/s390/tcg-target.h | 8 ++-- 2 files changed, 30 insertions(+), 2 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index dbe2fa6..673a568 100644 --- a/tcg/s390/tcg-target.c ++

[Qemu-devel] [PULL v2 08/13] tcg-s390: Remove constraint letters for and

2013-04-05 Thread Richard Henderson
Since we have a free temporary and can always just load the constant, we ought to do so, rather than spending the same effort constraining the const. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 149 +++--- 1 file changed, 32 insertions

[Qemu-devel] [PULL v2 03/13] tcg-s390: Remove useless preprocessor conditions

2013-04-05 Thread Richard Henderson
We only support 64-bit code generation for s390x. Don't clutter the code with ifdefs that suggest otherwise. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 17 + tcg/s390/tcg-target.h | 2 -- 2 files changed, 5 insertions(+), 14 deletions(-) diff --git a/tcg/s390/

[Qemu-devel] [PULL v2 09/13] tcg-s390: Use risbgz for andi

2013-04-05 Thread Richard Henderson
This is immediately usable by the tlb lookup code. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 58 ++- 1 file changed, 53 insertions(+), 5 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index 203cbb5..2bab

[Qemu-devel] [PULL v2 06/13] tcg-s390: Implement movcond opcodes

2013-04-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 41 +++-- tcg/s390/tcg-target.h | 4 ++-- 2 files changed, 41 insertions(+), 4 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index 81e2f6a..dbe2fa6 100644 --- a/tcg/s390/tc

[Qemu-devel] [PULL v2 05/13] tcg-s390: Implement mulu2_i64 opcode

2013-04-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 5 + tcg/s390/tcg-target.h | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index b007763..81e2f6a 100644 --- a/tcg/s390/tcg-target.c +++ b/tcg/s390/tcg-target.c @@

[Qemu-devel] [PULL v2 04/13] tcg-s390: Implement add2/sub2 opcodes

2013-04-05 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 38 ++ tcg/s390/tcg-target.h | 8 2 files changed, 42 insertions(+), 4 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index ba314b3..b007763 100644 --- a/tcg/s390/t

[Qemu-devel] [PULL v2 01/13] tcg-s390: Fix movi

2013-04-05 Thread Richard Henderson
The code to load the high 64 bits assumed that the insn used to load the low 64 bits zero-extended. Enforce that. --- tcg/s390/tcg-target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index e12a152..0132010 100644 --- a/tcg/s39

[Qemu-devel] [PULL v2 02/13] tcg-s390: Properly allocate a stack frame.

2013-04-05 Thread Richard Henderson
Set TCG_TARGET_CALL_STACK_OFFSET properly for the abi. Allocate the standard TCG_STATIC_CALL_ARGS_SIZE. And while we're at it, allocate space for CPU_TEMP_BUF_NLONGS. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 20 ++-- tcg/s390/tcg-target.h | 2 +- 2 files ch

[Qemu-devel] [PULL v2 00/13] tcg-s390 updates

2013-04-05 Thread Richard Henderson
Here's the latest set of tcg-s390 updates. The only real change from v1 is the addition of the last patch. This is able to run the i386-softmmu nbench test, and boot both arm and sparc32 kernels. I tried to look at addressing Aurelien's comment in response to patch 3, that 32-bit s390 defer to t

Re: [Qemu-devel] [PATCH arm-devs v1 05/15] xilinx_spips: lqspi: Dont trash config register

2013-04-05 Thread Peter Maydell
On 3 April 2013 05:32, Peter Crosthwaite wrote: > The LQSPI code currently manipulates the config register to achieve its > ends. Some (agressively designed) drivers assume that the config > register preserves state across a transition into and out of LQSPI > mode. Fixed by just restoring R_CONFIG

Re: [Qemu-devel] [PATCH arm-devs v1 04/15] xilinx_spips: Add verbose LQSPI debug output

2013-04-05 Thread Peter Maydell
On 3 April 2013 05:32, Peter Crosthwaite wrote: > You really need this is you want to track a guest banging on LQSPI. > > Signed-off-by: Peter Crosthwaite > --- > > hw/xilinx_spips.c |5 - > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/hw/xilinx_spips.c b/hw/xilinx_s

Re: [Qemu-devel] [PATCH arm-devs v1 03/15] xilinx_spips: Inhibit interrupts in LQSPI mode

2013-04-05 Thread Peter Maydell
On 3 April 2013 05:27, Peter Crosthwaite wrote: > The real hardware does not produce interrupts in LQSPI mode. Inhibit > generation of interrupts when the LQ_MODE bit is set. > > Signed-off-by: Peter Crosthwaite > --- > > hw/xilinx_spips.c |7 ++- > 1 files changed, 6 insertions(+), 1 de

[Qemu-devel] virtio-scsi WRITE_VERIFY crash

2013-04-05 Thread Venkatesh Srinivas
Hi, When a Linux guest does a simple 'sg_verify /dev/', qemu (-master from git) crashes, tripping an assertion in scsi-disk.c:scsi_dma_complete(), that the completing DMA command has no IOCB. The callpath is: scsi_dma_complete dma_complete dma_bdrv_cb dma_bdrv_io dma_bdrv_read scsi_do_read bdrv_c

Re: [Qemu-devel] [PATCH 1/8] virtio-blk-x: fix configuration synchronization.

2013-04-05 Thread Peter Maydell
On 5 April 2013 17:47, Anthony Liguori wrote: > Kevin Wolf writes: > >> From: KONRAD Frederic >> >> The virtio-blk-x configuration is not in sync with virtio-blk configuration. >> So this patch remove the virtio-blk-x configuration field, and use virtio-blk >> one for setting the properties. >>

[Qemu-devel] [PULL 00/14] arm-devs queue

2013-04-05 Thread Peter Maydell
Here's the latest set of arm-devs patches; mostly migration related fixes, plus a few random minor bug zaps. Please pull. thanks -- PMM The following changes since commit d05ef160453e98546a4197496dc8a3cb2defac53: Allow clock_gettime() monotonic clock to be utilized on more OS's (2013-04-04 20

[Qemu-devel] [PATCH 02/14] pl050: Don't send always-constant is_mouse field

2013-04-05 Thread Peter Maydell
The is_mouse field of the pl050 state structure is constant (it tracks whether this is a 'pl050_keyboard' or 'pl050_mouse'), so there's no need to include it in the VMState structure. Signed-off-by: Peter Maydell Message-id: 1363628480-29306-1-git-send-email-peter.mayd...@linaro.org --- hw/pl050

[Qemu-devel] [PATCH 06/14] hw/onenand.c: fix migration of dynamically allocated buffer "otp"

2013-04-05 Thread Peter Maydell
From: Igor Mitsyanko VMSTATE_BUFFER_UNSAFE should be used for buffers inlined in device state, not for buffers allocated dynamically. Change to VMSTATE_BUFFER_POINTER_UNSAFE macro, which will do migration right. Signed-off-by: Igor Mitsyanko Reviewed-by: Peter Maydell Message-id: 1362923278-4

[Qemu-devel] [PATCH 10/14] pflash_cfi01: Drop unused 'bypass' field

2013-04-05 Thread Peter Maydell
For pflash_cfi01 the 'bypass' field is set to zero and never changes, so remove it (it is a leftover from pflash_cfi02, where bypass is implemented). Signed-off-by: Peter Maydell Message-id: 1363717469-30980-2-git-send-email-peter.mayd...@linaro.org --- hw/pflash_cfi01.c | 10 ++ 1 fil

[Qemu-devel] [PATCH 07/14] vmstate: Add support for two dimensional arrays

2013-04-05 Thread Peter Maydell
Add support for migrating two dimensional arrays, by defining a set of new macros VMSTATE_*_2DARRAY paralleling the existing VMSTATE_*_ARRAY macros. 2D arrays are handled the same for actual state serialization; the only difference is that the type check has to change for a 2D array. Signed-off-by

[Qemu-devel] [PATCH 08/14] arm_gic: Fix sizes of state fields in preparation for vmstate support

2013-04-05 Thread Peter Maydell
In preparation for switching to vmstate for migration support, fix the sizes of various GIC state fields. In particular, we replace all the bitfields (which VMState can't deal with) with straightforward uint8_t values which we do bit operations on. (The bitfields made more sense when NCPU was set d

[Qemu-devel] [PATCH 09/14] hw/arm_gic_common: Use vmstate struct rather than save/load functions

2013-04-05 Thread Peter Maydell
Update the GIC save/restore to use vmstate rather than hand-rolled save/load functions. Signed-off-by: Peter Maydell Reviewed-by: Igor Mitsyanko Message-id: 1363975375-3166-4-git-send-email-peter.mayd...@linaro.org --- hw/arm_gic_common.c | 108 +++--

[Qemu-devel] [PATCH 01/14] hw/arm/nseries: don't print to stdout or stderr

2013-04-05 Thread Peter Maydell
Remove various bits of printing to stdout or stderr from the nseries code, replacing it with a qemu log message where there's an appropriate log category, and just dropping the output for some of the more debug-like printing. In particular, this will get rid of the 'mipid_reset' message you curren

[Qemu-devel] [PATCH 13/14] cadence_uart: Flush queued characters on reset

2013-04-05 Thread Peter Maydell
From: Peter Crosthwaite Reset can be used to empty the rx-fifo. As the fifo full condition is used to return false from can_receive, queued rx data should be flushed on reset accordingly. Cc: Wendy Liang Cc: Jason Wu Signed-off-by: Peter Crosthwaite Reported-by: Jason Wu Message-id: 494c1e

[Qemu-devel] [PATCH 05/14] hw/sd.c: fix migration of dynamically allocated buffer "buf"

2013-04-05 Thread Peter Maydell
From: Igor Mitsyanko VMSTATE_BUFFER_UNSAFE should be used for buffers inlined in device state, not for buffers allocated dynamically. Change to VMSTATE_BUFFER_POINTER_UNSAFE macro, which will do migration right. Signed-off-by: Igor Mitsyanko Reviewed-by: Peter Maydell Tested-by: Michael Walle

[Qemu-devel] [PATCH 11/14] pflash_cfi01: Implement migration support

2013-04-05 Thread Peter Maydell
Add a vmstate to pflash_cfi01, so that it can be live migrated. Signed-off-by: Peter Maydell Message-id: 1363717469-30980-3-git-send-email-peter.mayd...@linaro.org --- hw/pflash_cfi01.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/hw/pflash_cfi01.c

[Qemu-devel] [PATCH 12/14] pl330: Don't inhibit ES bits on INTEN

2013-04-05 Thread Peter Maydell
From: Peter Crosthwaite This if-else logic inhibits setting of the event status (ES) bits when interrupts are enabled. This is incorrect. ES should be set regardless on INTEN state. INTEN only inhibits the signalling of events to PL330 threads, not setting of the ES register. Signed-off-by: Pete

[Qemu-devel] [PATCH 03/14] hw/arm_mptimer: Save the timer state

2013-04-05 Thread Peter Maydell
Add a missing VMSTATE_TIMER() entry to the arm_mptimer vmstate description; this omission meant that we would probably hang on reload when the timer failed to fire. Signed-off-by: Peter Maydell Reviewed-by: Peter Crosthwaite Message-id: 1363967348-3044-1-git-send-email-peter.mayd...@linaro.org -

[Qemu-devel] [PATCH 14/14] hw/nand.c: Fix nand erase operation

2013-04-05 Thread Peter Maydell
From: Wendy Liang Usually, nand erase operation has only 2 or 3 address cycles. We need to mask s->addr to zero unset stale high-order bytes in the nand address before using it as the erase address. This fixes the NAND erase operation in Linux. [PC: Generalised to work for any number of address

Re: [Qemu-devel] [PATCH 22/22] add cpu-add qmp command and implement CPU hot-add for target-i386

2013-04-05 Thread Eduardo Habkost
On Fri, Apr 05, 2013 at 02:10:54PM -0300, Eduardo Habkost wrote: > On Fri, Apr 05, 2013 at 04:37:16PM +0200, Igor Mammedov wrote: > [...] > > diff --git a/qapi-schema.json b/qapi-schema.json > > index db542f6..a760ed5 100644 > > --- a/qapi-schema.json > > +++ b/qapi-schema.json > > @@ -1387,6 +1387

[Qemu-devel] [PATCH 04/14] vmstate.h: introduce VMSTATE_BUFFER_POINTER_UNSAFE macro

2013-04-05 Thread Peter Maydell
From: Igor Mitsyanko Macro could be used to migrate a dynamically allocated buffer of known size. Signed-off-by: Igor Mitsyanko Reviewed-by: Peter Maydell Message-id: 1362923278-4080-2-git-send-email-i.mitsya...@gmail.com Signed-off-by: Peter Maydell --- include/migration/vmstate.h |9 ++

Re: [Qemu-devel] [PATCH 22/22] add cpu-add qmp command and implement CPU hot-add for target-i386

2013-04-05 Thread Eduardo Habkost
On Fri, Apr 05, 2013 at 04:37:16PM +0200, Igor Mammedov wrote: [...] > diff --git a/qapi-schema.json b/qapi-schema.json > index db542f6..a760ed5 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -1387,6 +1387,17 @@ > { 'command': 'cpu', 'data': {'index': 'int'} } > > ## > +# @cpu-ad

[Qemu-devel] [PULL v2 0/7] Block patches

2013-04-05 Thread Kevin Wolf
The following changes since commit d05ef160453e98546a4197496dc8a3cb2defac53: Allow clock_gettime() monotonic clock to be utilized on more OS's (2013-04-04 20:22:45 -0500) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony for you to fetch changes up to c2b6

Re: [Qemu-devel] [PATCH v4 30/33] tcg-ppc64: Use getauxval for ISA detection

2013-04-05 Thread Richard Henderson
On 2013-04-04 17:56, Richard Henderson wrote: +#ifdef CONFIG_GETAUXVAL +#include +static bool have_isa_2_06; +#define HAVE_ISA_2_06 have_isa_2_06 +#define HAVE_ISEL have_isa_2_06 +#else #define HAVE_ISA_2_06 0 -#define HAVE_ISEL 0 +#define HAVE_ISA_ISEL 0 Guh. I've pushed a new

Re: [Qemu-devel] [PATCH 1/8] virtio-blk-x: fix configuration synchronization.

2013-04-05 Thread Anthony Liguori
Kevin Wolf writes: > From: KONRAD Frederic > > The virtio-blk-x configuration is not in sync with virtio-blk configuration. > So this patch remove the virtio-blk-x configuration field, and use virtio-blk > one for setting the properties. > > This also remove a useless configuration copy in virti

Re: [Qemu-devel] [PULL] xen_disk fixes 2013-04-05

2013-04-05 Thread Alex Bligh
Stefano, --On 5 April 2013 17:22:04 +0100 Stefano Stabellini wrote: Thanks for that. Do you plan to get the 4.2 patches in for 4.2.2? Yes Great - thanks. -- Alex Bligh

Re: [Qemu-devel] [PULL] xen_disk fixes 2013-04-05

2013-04-05 Thread Stefano Stabellini
On Fri, 5 Apr 2013, Alex Bligh wrote: > Stefano, > > --On 5 April 2013 16:51:24 +0100 Stefano Stabellini > wrote: > > > Hi Anthony, > > please pull from the following tree based on > > d05ef160453e98546a4197496dc8a3cb2defac53: > > > > git://xenbits.xen.org/people/sstabellini/qemu-dm.git xen-201

Re: [Qemu-devel] [PULL] xen_disk fixes 2013-04-05

2013-04-05 Thread Alex Bligh
Stefano, --On 5 April 2013 16:51:24 +0100 Stefano Stabellini wrote: Hi Anthony, please pull from the following tree based on d05ef160453e98546a4197496dc8a3cb2defac53: git://xenbits.xen.org/people/sstabellini/qemu-dm.git xen-2013-04-05 Alex Bligh (2): Xen PV backend: Move call to bdr

Re: [Qemu-devel] [PATCH 18/22] target-i386: move APIC to ICC bus

2013-04-05 Thread Eduardo Habkost
On Fri, Apr 05, 2013 at 04:37:10PM +0200, Igor Mammedov wrote: [...] > void pc_cpus_init(const char *cpu_model) > { > int i; > +X86CPU *cpu; > Error *error = NULL; > +SysBusDevice *ib; > > /* init CPUs */ > if (cpu_model == NULL) { > @@ -902,14 +907,22 @@ void pc_cpu

Re: [Qemu-devel] [PATCH] hw/nand.c: Fix nand erase operation

2013-04-05 Thread Peter Maydell
On 3 April 2013 06:33, Peter Crosthwaite wrote: > From: Wendy Liang > > Usually, nand erase operation has only 2 or 3 address cycles. > We need to mask s->addr to zero unset stale high-order bytes in the nand > address > before using it as the erase address. > > This fixes the NAND erase operati

Re: [Qemu-devel] [PATCH arm-devs v1 1/1] cadence_uart: Flush queued characters on reset

2013-04-05 Thread Peter Maydell
On 3 April 2013 05:52, Peter Crosthwaite wrote: > Reset can be used to empty the rx-fifo. As the fifo full condition is > used to return false from can_receive, queued rx data should be flushed > on reset accordingly. > > Cc: Wendy Liang > Cc: Jason Wu > > Signed-off-by: Peter Crosthwaite > Rep

Re: [Qemu-devel] [PATCH arm-devs v1] pl330: Dont inhibit ES bits on INTEN

2013-04-05 Thread Peter Maydell
On 3 April 2013 04:59, Peter Crosthwaite wrote: > This if-else logic inhibits setting of the event status (ES) bits > when interrupts are enabled. This is incorrect. ES should be set > regardless on INTEN state. INTEN only inhibits the signalling of > events to PL330 threads, not setting of the ES

[Qemu-devel] [PATCH v2] qemu-char: eliminate busy waiting on can_read returning zero

2013-04-05 Thread Paolo Bonzini
The character backend refactoring introduced an undesirable busy wait. The busy wait happens if can_read returns zero and there is data available on the character device's file descriptor. Then, the I/O watch will fire continuously and, with TCG, the CPU thread will never run. 1) Char backend

Re: [Qemu-devel] [PATCH v5 7/7] Use qemu_put_buffer_async for guest memory pages

2013-04-05 Thread Kevin Wolf
Am 05.04.2013 um 17:42 hat Paolo Bonzini geschrieben: > Il 05/04/2013 17:39, Kevin Wolf ha scritto: > >> > The solution could be to make bdrv_load_vmstate take an iov/iovcnt pair. > > Ah, so you're saying that instead of linearising the buffer it breaks up > > the requests in tiny pieces? > > Only

[Qemu-devel] [PULL] xen_disk fixes 2013-04-05

2013-04-05 Thread Stefano Stabellini
Hi Anthony, please pull from the following tree based on d05ef160453e98546a4197496dc8a3cb2defac53: git://xenbits.xen.org/people/sstabellini/qemu-dm.git xen-2013-04-05 Alex Bligh (2): Xen PV backend: Move call to bdrv_new from blk_init to blk_connect Xen PV backend: Disable use of O_D

[Qemu-devel] [PATCH 18/22] target-i386: move IOAPIC to ICC bus

2013-04-05 Thread Igor Mammedov
* inherit IOAPICs from ICCDevice and attach them to ICC bus * map IOAPIC's mmio at board level * make IOAPIC a child device of icc-bridge Signed-off-by: Igor Mammedov --- hw/i386/pc.c | 23 +-- hw/i386/pc_piix.c | 2 +- hw/i386/pc_q35.c | 2 +- hw/icc_b

[Qemu-devel] [PATCH 12/22] cpu: add helper cpu_exists(), to check if CPU with specified id exists

2013-04-05 Thread Igor Mammedov
... it should be used only on slow path since it does recursive search on /machine QOM tree for objects of TYPE_CPU Signed-off-by: Igor Mammedov --- include/qom/cpu.h | 10 ++ qom/cpu.c | 21 + 2 files changed, 31 insertions(+) diff --git a/include/qom/cp

Re: [Qemu-devel] [PATCH] main-loop: drop the BQL if the I/O appears to be spinning

2013-04-05 Thread Anthony Liguori
Eric Blake writes: > On 04/05/2013 07:46 AM, Anthony Liguori wrote: >> The char-flow refactoring introduced a busy-wait that depended on >> an action from the VCPU thread. However, the VCPU thread could >> never take that action because the busy-wait starved the VCPU thread >> of the BQL because

Re: [Qemu-devel] [PATCHv2 1/2] Xen PV backend: Move call to bdrv_new from blk_init to blk_connect

2013-04-05 Thread Alex Bligh
Stefano, --On 5 April 2013 15:22:16 +0100 Stefano Stabellini wrote: @@ -756,6 +753,41 @@ static int blk_init(struct XenDevice *xendev) info |= VDISK_CDROM; } +blkdev->file_blk = BLOCK_SIZE; This is useless, you are setting file_blk twice. Just remove this please. Act

Re: [Qemu-devel] [PATCH v5 7/7] Use qemu_put_buffer_async for guest memory pages

2013-04-05 Thread Paolo Bonzini
Il 05/04/2013 17:39, Kevin Wolf ha scritto: >> > The solution could be to make bdrv_load_vmstate take an iov/iovcnt pair. > Ah, so you're saying that instead of linearising the buffer it breaks up > the requests in tiny pieces? Only for RAM (header/page/header/page...), because the page comes stra

[Qemu-devel] [PATCHv3 1/2] Xen PV backend: Move call to bdrv_new from blk_init to blk_connect

2013-04-05 Thread Alex Bligh
This commit delays the point at which bdrv_new (and hence blk_open on the underlying device) is called from blk_init to blk_connect. This ensures that in an inbound live migrate, the block device is not opened until it has been closed at the other end. This is in preparation for supporting devices

[Qemu-devel] [PATCHv3 2/2] Xen PV backend: Disable use of O_DIRECT by default as it results in crashes.

2013-04-05 Thread Alex Bligh
Due to what is almost certainly a kernel bug, writes with O_DIRECT may continue to reference the page after the write has been marked as completed, particularly in the case of TCP retransmit. In other scenarios, this "merely" risks data corruption on the write, but with Xen pages from domU are only

[Qemu-devel] [PATCH 03/22] target-i386: split out CPU creation and features parsing into cpu_x86_create()

2013-04-05 Thread Igor Mammedov
Move CPU creation and features parsing into a separate cpu_x86_create() function, so that board would be able to set board specific CPU properties before CPU is realized. Keep cpu_x86_init() for compatibility with the code that uses cpu_init() and doesn't need to modify CPU properties. Signed-off

Re: [Qemu-devel] [PATCH v5 7/7] Use qemu_put_buffer_async for guest memory pages

2013-04-05 Thread Kevin Wolf
Am 05.04.2013 um 17:23 hat Paolo Bonzini geschrieben: > Il 05/04/2013 15:44, Kevin Wolf ha scritto: > > This seems to have killed savevm performance. I noticed that > > qemu-iotests case 007 took forever on my test box (882 seconds instead > > of something like 10 seconds). It can be reproduced by

[Qemu-devel] [PATCH 14/22] target-i386: introduce apic-id property

2013-04-05 Thread Igor Mammedov
... and use it from board level to set APIC ID for CPUs it creates. Signed-off-by: Igor Mammedov --- Note: * pc_new_cpu() function will be reused later in CPU hot-plug hook. v2: * use generic cpu_exists() instead of custom one * make apic-id dynamic property, so it won't be possible to use

Re: [Qemu-devel] [PATCH v5 0/7] virtio-serial refactoring.

2013-04-05 Thread Anthony Liguori
fred.kon...@greensocs.com writes: > From: KONRAD Frederic > > This is the next part of virtio-refactoring. > > Basically it creates virtio-serial device which extends virtio-device. > Then a virtio-serial can be connected on a virtio-bus. > virtio-serial-pci, virtio-serial-s390 and virtio-serial-

[Qemu-devel] [PATCH 05/22] cpu: call cpu_synchronize_post_init() from CPUClass.realize() if hotplugged

2013-04-05 Thread Igor Mammedov
... to synchronize CPU state to KVM * in addition link kvm-stub.o to *-user target and fix related compiling issues. Signed-off-by: Igor Mammedov --- Makefile.target | 6 ++ include/sysemu/kvm.h | 22 -- kvm-all.c| 1 + kvm-stub.c | 5 +

[Qemu-devel] [PATCH 09/22] introduce CPU hot-plug notifier

2013-04-05 Thread Igor Mammedov
hot-added CPU will be distributed to acpi_piix4, rtc_cmos and icc_bridge Signed-off-by: Igor Mammedov --- v2: * move notifier to qom/cpu.c and call it from CPUClass.realize() on hotplug --- include/qom/cpu.h | 2 ++ include/sysemu/sysemu.h | 3 +++ qom/cpu.c | 12

Re: [Qemu-devel] [PATCH v5 7/7] Use qemu_put_buffer_async for guest memory pages

2013-04-05 Thread Paolo Bonzini
Il 05/04/2013 15:44, Kevin Wolf ha scritto: > This seems to have killed savevm performance. I noticed that > qemu-iotests case 007 took forever on my test box (882 seconds instead > of something like 10 seconds). It can be reproduced by this script: > > export MALLOC_PERTURB_=11 > qemu-img create

[Qemu-devel] [PATCH 15/22] introduce ICC bus/device/bridge

2013-04-05 Thread Igor Mammedov
... to provide hotplug-able bus. * icc-bridge will serve as a parent for icc-bus, provide mmio mapping services to child icc-device and create IOAPIC when requested. * icc-device will replace SysBusDevice as a parent of APIC and IOAPIC devices. Signed-off-by: Igor Mammedov --- hw/i386/Mak

Re: [Qemu-devel] Finding first TranslationBlock in user mode emulation

2013-04-05 Thread Ivan Jovanovic
Thank you for your reply! The thing is that, for one particular binary I can determine the address of main() in the way that you've described, or even by compiling the program with debug information and observing the in_asm log. What I need is this to work in a general case, for every binary, with

[Qemu-devel] [PATCH 10/22] rtc: update rtc_cmos on CPU hot-plug

2013-04-05 Thread Igor Mammedov
... so that on reboot BIOS could read current available CPU count Signed-off-by: Igor Mammedov v2: * s/qemu_register_cpu_add_notifier()/qemu_register_cpu_added_notifier()/ --- hw/mc146818rtc.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c

[Qemu-devel] [PATCH 17/22] target-i386: replace MSI_SPACE_SIZE with APIC_SPACE_SIZE

2013-04-05 Thread Igor Mammedov
... and put APIC_SPACE_SIZE in public header so that it could be reused later elsewhere. Signed-off-by: Igor Mammedov --- hw/apic.c | 2 +- hw/apic_internal.h | 2 -- hw/kvm/apic.c | 2 +- hw/xen_apic.c | 2 +- target-i386/cpu.h | 1 + 5 files changed, 4 insertions(+), 5 dele

  1   2   3   >