Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-07 Thread Stefan Weil
Compilation on 32 bit Linux results in lots of warnings caused by wrong format specifiers. Please don't add type casts, but try to use the format specifiers needed (PRIu64, ...). CChw/nvme.o /qemu/hw/nvme.c: In function 'nvme_init_file': /qemu/hw/nvme.c:834:5: error: format '%lu' expects arg

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-07 Thread Stefan Weil
> An implementation of a generic NVMe Controller PCI device, developed > from the open standard available at nvmexpress.org. > > Cc: Michael S. Tsirkin > Cc: Keith Busch > Signed-off-by: Keith Busch > --- > I've developed for QEMU for a little while, but this is my first patch, so > I wouldn't b

Re: [Qemu-devel] [RFC 3/3] docs: document virtio-balloon stats

2012-12-07 Thread Dietmar Maurer
> 2. wait for the (kernel-based) auto-ballooning feature, which is on the > works Do you have more information on that? Any links?

[Qemu-devel] [Bug 1087590] Re: gdbstub step instruction locks up on OS X

2012-12-07 Thread Niel van der Westhuizen
(Though note it seems to always freeze on boot with '--with- coroutine=sigaltstack') -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1087590 Title: gdbstub step instruction locks up on OS X Status i

[Qemu-devel] [Bug 1087590] Re: gdbstub step instruction locks up on OS X

2012-12-07 Thread Niel van der Westhuizen
(new backtrace:) Thread 9 (process 58073): #0 0x7fff93dcd0fa in __psynch_cvwait () #1 0x7fff931c0f89 in _pthread_cond_wait () #2 0x000100202cf3 in qemu_sem_timedwait (sem=0x100996618, ms=1) at qemu-thread-posix.c:214 #3 0x000100230b0e in worker_thread (unused=0x0) at threa

[Qemu-devel] [Bug 1087590] Re: gdbstub step instruction locks up on OS X

2012-12-07 Thread Niel van der Westhuizen
Yes. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1087590 Title: gdbstub step instruction locks up on OS X Status in QEMU: New Bug description: OS X 10.8.2 (Darwin Niels-MacBook-Air.local

[Qemu-devel] [Bug 1087035] Re: qemu plumbs virtual to wrong backing devices

2012-12-07 Thread Adam Jacob Muller
this was not a qemu bug, i hate linux disk labels. ** Changed in: qemu Assignee: (unassigned) => Adam Jacob Muller (78luphr0rnk2nuqimstywepozxn9kl19tqh0tx66b5dki1xxsh5mkz9gl21a5rlwfnr8jn6ln0m3jxne2k9x1ohg85w3jabxlrqbgszpjpwcmvk-launchpad) ** Changed in: qemu Status: New => Invalid -

[Qemu-devel] [PATCH 1/2] softfloat: Fix uint64_to_float64

2012-12-07 Thread Richard Henderson
The interface to normalizeRoundAndPackFloat64 requires that the high bit be clear. Perform one shift-right-and-jam if needed. Signed-off-by: Richard Henderson --- fpu/softfloat.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index

[Qemu-devel] [PATCH 2/2] softfloat: Implement uint64_to_float128

2012-12-07 Thread Richard Henderson
Signed-off-by: Richard Henderson --- fpu/softfloat.c | 8 fpu/softfloat.h | 3 +++ 2 files changed, 11 insertions(+) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 62830d7..d3290d8 100644 --- a/fpu/softfloat.c +++ b/fpu/softfloat.c @@ -1337,6 +1337,14 @@ float128 int64_to_float128

[Qemu-devel] [PATCH v2 0/2] soft-float fixes for target-s390x

2012-12-07 Thread Richard Henderson
... or for upcoming s390x changes. The s390x isa has insns for both signed and unsigned conversions to all three (binary) floating point types. One of these was missing and the other producing incorrect results. Tested with the s390x rewrite on the gcc testsuite. Changes v1-v2: Incorporating

[Qemu-devel] [PATCH v2] tcg: Add TCGV_IS_UNUSED_*

2012-12-07 Thread Richard Henderson
Cc: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/tcg-op.h | 2 ++ tcg/tcg.h| 3 +++ 2 files changed, 5 insertions(+) Changes since v1: * Add tl-sized TCGV_IS_UNUSED to tcg-op.h. r~ diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h index 0b3cb0b..91c9d80 100644 --- a/tcg/tcg-op.h +++

Re: [Qemu-devel] [PATCH/RFC] block: Ensure that block size constraints are considered

2012-12-07 Thread Heinz Graalfs
Hello Kevin, I'm resending my answer as of Nov 23rd. Is this still on your queue? Heinz On Wed, 2012-11-21 at 10:15 +0100, Kevin Wolf wrote: > Am 21.11.2012 09:58, schrieb Christian Borntraeger: > > From: Heinz Graalfs > > > > While testing IPL code (booting) for s390x we faced some problems

Re: [Qemu-devel] [PATCH 2/2] target-i386: use visit_type_unit_suffixed_int() to parse tsc_freq property value

2012-12-07 Thread Eduardo Habkost
On Fri, Dec 07, 2012 at 08:00:09PM +0100, Andreas Färber wrote: > Am 06.12.2012 22:12, schrieb Igor Mammedov: > > Signed-off-by: Igor Mammedov > > --- > > v2: > >- replace visit_type_freq() with visit_type_unit_suffixed_int() > > in x86_cpuid_set_tsc_freq() > > --- > > target-i386/cpu.

Re: [Qemu-devel] [PATCH 1/2] qapi: add visitor for parsing int[KMGT] input string

2012-12-07 Thread Eduardo Habkost
On Fri, Dec 07, 2012 at 07:57:35PM +0100, Andreas Färber wrote: [...] > > +static void parse_type_unit_suffixed_int(Visitor *v, int64_t *obj, > > + const char *name, const int unit, > > + Error **errp) > > +{ > > +S

[Qemu-devel] [PATCH] kvm: Detect number of available memory slots from the host kernel

2012-12-07 Thread Alex Williamson
The kernel already exposes an interface for this, x86 returns a proper value and for the rest we can default to the defacto standard of 32. The primary motivation for this is to support more PCI assigned devices, both through pci-assign and vfio-pci. Signed-off-by: Alex Williamson --- kvm-all.c

Re: [Qemu-devel] [PATCH 3/3] s390: add cpu reset handler

2012-12-07 Thread Andreas Färber
Am 07.12.2012 14:55, schrieb Jens Freimann: > Add a CPU reset handler to have all CPUs in a PoP compliant > state. > > Signed-off-by: Jens Freimann > --- > target-s390x/cpu.c | 25 + > target-s390x/kvm.c | 10 +- > 2 files changed, 34 insertions(+), 1 deletion

Re: [Qemu-devel] [PATCH 2/2] target-i386: use visit_type_unit_suffixed_int() to parse tsc_freq property value

2012-12-07 Thread Andreas Färber
Am 06.12.2012 22:12, schrieb Igor Mammedov: > Signed-off-by: Igor Mammedov > --- > v2: >- replace visit_type_freq() with visit_type_unit_suffixed_int() > in x86_cpuid_set_tsc_freq() > --- > target-i386/cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/targ

Re: [Qemu-devel] [PATCH v7 2/2] qemu-ga: sample fsfreeze hooks

2012-12-07 Thread Luiz Capitulino
On Fri, 07 Dec 2012 11:37:44 -0700 Eric Blake wrote: > On 12/07/2012 11:31 AM, Luiz Capitulino wrote: > +++ b/.gitignore > @@ -93,3 +93,4 @@ cscope.* > tags > TAGS > *~ > +!scripts/qemu-guest-agent/fsfreeze-hook.d > >>> > >>> Why? Do we expect to have *~ files in

Re: [Qemu-devel] [PATCH 1/2] qapi: add visitor for parsing int[KMGT] input string

2012-12-07 Thread Andreas Färber
Am 06.12.2012 22:12, schrieb Igor Mammedov: > Caller of visit_type_unit_suffixed_int() will have to specify > value of 'K' suffix via unit argument. > For Kbytes it's 1024, for Khz it's 1000. > > Signed-off-by: Igor Mammedov > --- > v2: > - convert type_freq to type_unit_suffixed_int. > - pr

Re: [Qemu-devel] [RFC 3/3] docs: document virtio-balloon stats

2012-12-07 Thread Luiz Capitulino
On Fri, 7 Dec 2012 15:01:36 + Dietmar Maurer wrote: > > > Is it possible to extent those statistic to include buffer/cache values? > > > > Yes, should be possible but the kernel virtio-balloon driver has to be > > extended too (and I suspect this kind of change goes into the kernel first). >

Re: [Qemu-devel] [PATCH v7 2/2] qemu-ga: sample fsfreeze hooks

2012-12-07 Thread Eric Blake
On 12/07/2012 11:31 AM, Luiz Capitulino wrote: +++ b/.gitignore @@ -93,3 +93,4 @@ cscope.* tags TAGS *~ +!scripts/qemu-guest-agent/fsfreeze-hook.d >>> >>> Why? Do we expect to have *~ files in there? >> >> What does your question have to do with the patch, which isn

Re: [Qemu-devel] [PATCH v7 2/2] qemu-ga: sample fsfreeze hooks

2012-12-07 Thread Eric Blake
On 12/07/2012 01:39 AM, Tomoki Sekiyama wrote: > Adds sample hook scripts for --fsfreeze-hook option of qemu-ga. > - fsfreeze-hook : execute scripts in fsfreeze-hook.d/ > - fsfreeze-hook.d/mysql-flush.sh.sample : quiesce MySQL before snapshot > > Signed-off-by: Tomoki Sekiyama > --- > @@ -0,

Re: [Qemu-devel] [PATCH v7 2/2] qemu-ga: sample fsfreeze hooks

2012-12-07 Thread Luiz Capitulino
On Fri, 07 Dec 2012 11:22:54 -0700 Eric Blake wrote: > On 12/07/2012 06:55 AM, Luiz Capitulino wrote: > > On Fri, 07 Dec 2012 17:39:32 +0900 > > Tomoki Sekiyama wrote: > > > >> Adds sample hook scripts for --fsfreeze-hook option of qemu-ga. > >> - fsfreeze-hook : execute scripts in fsfreeze-h

Re: [Qemu-devel] [PATCH 3/4] ppc: use FWCfgState* instead of void* for fw_cfg data

2012-12-07 Thread Alexander Graf
On 07.12.2012, at 17:07, Eduardo Habkost wrote: > There's no point in using void* if all functions dealing with that data > use FWCfgState*. Acked-by: Alexander Graf Alex > > Signed-off-by: Eduardo Habkost > --- > Cc: Alexander Graf > --- > hw/ppc_newworld.c | 2 +- > hw/ppc_oldworld.c | 2

Re: [Qemu-devel] [PULL] target-s390x reorg, v4

2012-12-07 Thread Peter Maydell
On 6 December 2012 00:09, Alexander Graf wrote: > I would like to make sure that someone knowledgable in the areas acks > the tcg and softfloat patches. Peter, you had been involved in this > quite a bit, right? I commented on the two softfloat patches in an earlier round: http://lists.gnu.org/ar

Re: [Qemu-devel] [PATCH v7 2/2] qemu-ga: sample fsfreeze hooks

2012-12-07 Thread Luiz Capitulino
On Fri, 7 Dec 2012 11:47:24 -0600 mdroth wrote: > On Fri, Dec 07, 2012 at 11:55:16AM -0200, Luiz Capitulino wrote: > > On Fri, 07 Dec 2012 17:39:32 +0900 > > Tomoki Sekiyama wrote: > > > > > Adds sample hook scripts for --fsfreeze-hook option of qemu-ga. > > > - fsfreeze-hook : execute script

Re: [Qemu-devel] [PATCH] target-i386: Postpone cpuid_level update to realize time

2012-12-07 Thread Andreas Färber
Am 07.12.2012 19:00, schrieb Eduardo Habkost: > From: Igor Mammedov > > Delay capping cpuid_level to 7 to realize time so property setters > for cpuid_7_0_ebx_features and "level" could be used in any order/time > between x86_cpu_initfn() and x86_cpu_realize(). > > Signed-off-by: Igor Mammedov

Re: [Qemu-devel] [PATCH v7 2/2] qemu-ga: sample fsfreeze hooks

2012-12-07 Thread Eric Blake
On 12/07/2012 06:55 AM, Luiz Capitulino wrote: > On Fri, 07 Dec 2012 17:39:32 +0900 > Tomoki Sekiyama wrote: > >> Adds sample hook scripts for --fsfreeze-hook option of qemu-ga. >> - fsfreeze-hook : execute scripts in fsfreeze-hook.d/ >> - fsfreeze-hook.d/mysql-flush.sh.sample : quiesce MySQL

Re: [Qemu-devel] [PULL] QOM CPUState patch queue 2012-12-06

2012-12-07 Thread Andreas Färber
Am 06.12.2012 10:06, schrieb Andreas Färber: > Hello, > > This is my current QOM CPU patch queue. Please pull. > > Regards, > Andreas > > Cc: Eduardo Habkost > Cc: Igor Mammedov > Cc: Paolo Bonzini Both branches updated with a fix: The following changes since commit 19e6c50d2d843220efbdd3b2

Re: [Qemu-devel] [PATCH 13/13] target-i386: Postpone cpuid_level update to realize time

2012-12-07 Thread Andreas Färber
Am 07.12.2012 18:57, schrieb Eduardo Habkost: > On Thu, Dec 06, 2012 at 10:06:57AM +0100, Andreas Färber wrote: > [...] >> --- >> target-i386/cpu.c |3 --- >> 1 Datei geändert, 3 Zeilen entfernt(-) >> >> diff --git a/target-i386/cpu.c b/target-i386/cpu.c >> index a631ae9..f56aa0d 100644 >> ---

Re: [Qemu-devel] [PULL] target-s390x reorg, v4

2012-12-07 Thread Richard Henderson
On 2012-12-05 18:09, Alexander Graf wrote: > I would like to make sure that someone knowledgable in the areas acks the tcg > and softfloat patches. Peter, you had been involved in this quite a bit, > right? We've already got an Reviewed-by for the tcg patch from Aurelien. Shall I pull these pie

Re: [Qemu-devel] [PATCH v5 10/11] dataplane: add virtio-blk data plane code

2012-12-07 Thread Kevin Wolf
Am 05.12.2012 21:47, schrieb Stefan Hajnoczi: > virtio-blk-data-plane is a subset implementation of virtio-blk. It only > handles read, write, and flush requests. It does this using a dedicated > thread that executes an epoll(2)-based event loop and processes I/O > using Linux AIO. > > This appr

[Qemu-devel] [PATCH] target-i386: Postpone cpuid_level update to realize time

2012-12-07 Thread Eduardo Habkost
From: Igor Mammedov Delay capping cpuid_level to 7 to realize time so property setters for cpuid_7_0_ebx_features and "level" could be used in any order/time between x86_cpu_initfn() and x86_cpu_realize(). Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost Signed-off-by: Eduardo Habkost

[Qemu-devel] [PATCH 3/8] qcow2: Allocate l2meta dynamically

2012-12-07 Thread Kevin Wolf
As soon as delayed COW is introduced, the l2meta struct is needed even after completion of the request, so it can't live on the stack. Signed-off-by: Kevin Wolf --- block/qcow2.c | 26 +++--- 1 files changed, 15 insertions(+), 11 deletions(-) diff --git a/block/qcow2.c b/b

Re: [Qemu-devel] [PATCH 13/13] target-i386: Postpone cpuid_level update to realize time

2012-12-07 Thread Eduardo Habkost
On Thu, Dec 06, 2012 at 10:06:57AM +0100, Andreas Färber wrote: [...] > --- > target-i386/cpu.c |3 --- > 1 Datei geändert, 3 Zeilen entfernt(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index a631ae9..f56aa0d 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -138

[Qemu-devel] [PATCH 2/8] qcow2: Introduce Qcow2COWRegion

2012-12-07 Thread Kevin Wolf
This makes it easier to address the areas for which a COW must be performed. As a nice side effect, the COW code in qcow2_alloc_cluster_link_l2 becomes really trivial. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c | 85 +++-- block/qcow2.h

Re: [Qemu-devel] [PATCH v7 2/2] qemu-ga: sample fsfreeze hooks

2012-12-07 Thread mdroth
On Fri, Dec 07, 2012 at 11:55:16AM -0200, Luiz Capitulino wrote: > On Fri, 07 Dec 2012 17:39:32 +0900 > Tomoki Sekiyama wrote: > > > Adds sample hook scripts for --fsfreeze-hook option of qemu-ga. > > - fsfreeze-hook : execute scripts in fsfreeze-hook.d/ > > - fsfreeze-hook.d/mysql-flush.sh.s

[Qemu-devel] [PATCH 0/8] qcow2: Cleanups and refactoring

2012-12-07 Thread Kevin Wolf
This is the first part of the Delayed COW series, which consists of some simple changes to qcow2 to bring the code into a shape that is easier to extend. I'm trying to get this in first so that the series with the really scary stuff becomes a bit shorter. Kevin Wolf (8): qcow2: Round QCowL2Meta.

[Qemu-devel] [PATCH 1/8] qcow2: Round QCowL2Meta.offset down to cluster boundary

2012-12-07 Thread Kevin Wolf
The offset within the cluster is already present as n_start and this is what the code uses. QCowL2Meta.offset is only needed at a cluster granularity. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c |4 ++-- block/qcow2.h | 22 ++ 2 files changed, 24 inserti

[Qemu-devel] [PATCH 8/8] qcow2: Factor out handle_dependencies()

2012-12-07 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c | 70 +--- 1 files changed, 42 insertions(+), 28 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 7a038ac..468ef1b 100644 --- a/block/qcow2-cluster.c +++ b/block/qcow2-c

[Qemu-devel] [PATCH 7/8] qcow2: Execute run_dependent_requests() without lock

2012-12-07 Thread Kevin Wolf
There's no reason for run_dependent_requests() to hold s->lock, and a later patch will require that in fact the lock is not held. Also, before this patch, run_dependent_requests() not only does what its name suggests, but also removes the l2meta from the list of in-flight requests. When changing t

[Qemu-devel] [PATCH 5/8] qcow2: Allocate l2meta only for cluster allocations

2012-12-07 Thread Kevin Wolf
Even for writes to already allocated clusters, an l2meta is allocated, though it stays effectively unused. After this patch, only allocating requests still have one. Each l2meta now describes an in-flight request that writes to clusters that are not yet hooked up in the L2 table. Signed-off-by: Ke

[Qemu-devel] [PATCH 4/8] qcow2: Drop l2meta.cluster_offset

2012-12-07 Thread Kevin Wolf
There's no real reason to have an l2meta for normal requests that don't allocate anything. Before we can get rid of it, we must return the host cluster offset in a different way. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c | 10 ++ block/qcow2.c | 14 +++--- b

[Qemu-devel] [PATCH 6/8] qcow2: Enable dirty flag in qcow2_alloc_cluster_link_l2

2012-12-07 Thread Kevin Wolf
This is closer to where the dirty flag is really needed, and it avoids having checks for special cases related to cluster allocation directly in the writev loop. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c |5 - block/qcow2.c |7 +-- block/qcow2.h |2 +

[Qemu-devel] [PATCH 3/4] ppc: use FWCfgState* instead of void* for fw_cfg data

2012-12-07 Thread Eduardo Habkost
There's no point in using void* if all functions dealing with that data use FWCfgState*. Signed-off-by: Eduardo Habkost --- Cc: Alexander Graf --- hw/ppc_newworld.c | 2 +- hw/ppc_oldworld.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ppc_newworld.c b/hw/ppc_newwor

[Qemu-devel] [PATCH 2/4] pc: use FWCfgState* instead of void* for fw_cfg data

2012-12-07 Thread Eduardo Habkost
There's no point in using void* if all functions dealing with that data use FWCfgState*. Signed-off-by: Eduardo Habkost --- Cc: Anthony Liguori --- hw/acpi_piix4.c | 2 +- hw/pc.c | 28 ++-- hw/pc.h | 19 ++- hw/pc_piix.c| 2 +- 4 fi

[Qemu-devel] [PATCH 4/4] sparc: use FWCfgState* instead of void* for fw_cfg data

2012-12-07 Thread Eduardo Habkost
There's no point in using void* if all functions dealing with that data use FWCfgState*. Signed-off-by: Eduardo Habkost --- Cc: Blue Swirl --- hw/sun4m.c | 6 +++--- hw/sun4u.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/sun4m.c b/hw/sun4m.c index 1a78676..efcd5dd

Re: [Qemu-devel] [Xen-devel] [PATCH 0/2] QEMU/xen: simplify cpu_ioreq_pio and cpu_ioreq_move

2012-12-07 Thread Ian Campbell
On Fri, 2012-12-07 at 16:14 +, Ian Jackson wrote: > +target_phys_addr_t offset = (target_phys_addr_t)req->size * i; > +if (req->df) addr -= offset; > +else addr -= offset; One of these -= should be a += I presume? [...] > +write_phys_req_item((target_phys_addr_t) r

Re: [Qemu-devel] [Xen-devel] [PATCH 0/2] QEMU/xen: simplify cpu_ioreq_pio and cpu_ioreq_move

2012-12-07 Thread Ian Jackson
Ian Campbell writes ("Re: [Xen-devel] [PATCH 0/2] QEMU/xen: simplify cpu_ioreq_pio and cpu_ioreq_move"): > On Fri, 2012-12-07 at 16:14 +, Ian Jackson wrote: > > +target_phys_addr_t offset = (target_phys_addr_t)req->size * i; > > +if (req->df) addr -= offset; > > +else addr -=

[Qemu-devel] [PATCH 0/4] use FWCfgState* instead of void* for fw_cfg data

2012-12-07 Thread Eduardo Habkost
Many parts of the code use void* for fw_cfg data when it could simply use the right data type (FWCfgState*). This series changes that code to use FWCfgState*. Eduardo Habkost (4): multiboot: use FWCfgState* as argument instead of void* pc: use FWCfgState* instead of void* for fw_cfg data ppc

Re: [Qemu-devel] [Xen-devel] [PATCH 0/2] QEMU/xen: simplify cpu_ioreq_pio and cpu_ioreq_move

2012-12-07 Thread Ian Jackson
Stefano Stabellini writes ("[Xen-devel] [PATCH 0/2] QEMU/xen: simplify cpu_ioreq_pio and cpu_ioreq_move"): > after reviewing the patch "fix multiply issue for int and uint types" > with Ian Jackson, we realized that cpu_ioreq_pio and cpu_ioreq_move are > in much need for a simplification as well a

[Qemu-devel] [PATCH 1/4] multiboot: use FWCfgState* as argument instead of void*

2012-12-07 Thread Eduardo Habkost
There's no point in using void* if we can simply use the right type for the argument (FWCfgState*). Signed-off-by: Eduardo Habkost --- Cc: Anthony Liguori --- hw/multiboot.c | 2 +- hw/multiboot.h | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/multiboot.c b/hw/multi

Re: [Qemu-devel] [PATCH v2] target-arm: GIC: bug fixes for arm_gic.c

2012-12-07 Thread Johannes Winter
On 07.12.2012 15:38, Peter Maydell wrote: [...] On 7 December 2012 14:31, Daniel Sangorrin wrote: > [...] In particular, I'm interested in helping to make current TrustZone support by Johannes Winter (https://github.com/jowinter/qemu-trustzone) mainstream. I can contribute by testing it or add

[Qemu-devel] [Bug 1087590] Re: gdbstub step instruction locks up on OS X

2012-12-07 Thread Peter Maydell
With current git master, does the bug still occur if you add '--with- coroutine=sigaltstack' to your configure line? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1087590 Title: gdbstub step instru

[Qemu-devel] [PATCH v2] configure: Default to 'cc', not 'gcc'

2012-12-07 Thread Peter Maydell
Default to 'cc' as our compiler, rather than 'gcc'. We used to have to insist on gcc when we still kept the CPU env in a fixed global register, but this is no longer necessary and we will now compile OK on clang as well as gcc. Using 'cc' should generally result in us using the most standard and m

[Qemu-devel] [Bug 1087590] [NEW] gdbstub step instruction locks up on OS X

2012-12-07 Thread Niel van der Westhuizen
Public bug reported: OS X 10.8.2 (Darwin Niels-MacBook-Air.local 12.2.0 Darwin Kernel Version 12.2.0: Sat Aug 25 00:48:52 PDT 2012; root:xnu-2050.18.24~1/RELEASE_X86_64 x86_64) -Only seems to occur with a drive attached -To reproduce (from current git master): ./configure --cc=clang --enable-d

[Qemu-devel] [RFC/PATCH 0/2] ipl device followup

2012-12-07 Thread Christian Borntraeger
Alex, here is were the IPL device code would move into. Some rough edges are still there, but it can ipl almost anything that was zipled under LPAR/VM. Christian Borntraeger (2): s390: Add bootmap parsing to ipl device s390: enable ipl device for virtio-ccw hw/s390x/Makefile.objs |2 +-

[Qemu-devel] [RFC/PATCH 1/2] s390: Add bootmap parsing to ipl device

2012-12-07 Thread Christian Borntraeger
The zipl bios code only works for specially prepared disks. This adds parsing of the on disk bootmap of disks that are zipled with a zipl under LPAR/zVM. Since all bootmaps are pretty similar the code is written in a way to not only fcp bootmaps (which are architectured and also parsed by the firm

[Qemu-devel] [RFC/PATCH 2/2] s390: enable ipl device for virtio-ccw

2012-12-07 Thread Christian Borntraeger
In case of virtio-ccw we also want to get a disk by its device id. Signed-off-by: Christian Borntraeger --- hw/s390x/ipl-disk.c |5 + 1 file changed, 5 insertions(+) diff --git a/hw/s390x/ipl-disk.c b/hw/s390x/ipl-disk.c index 1aab32b..6a83d9c 100644 --- a/hw/s390x/ipl-disk.c +++ b/hw/s

Re: [Qemu-devel] [RFC 3/3] docs: document virtio-balloon stats

2012-12-07 Thread Dietmar Maurer
> > Is it possible to extent those statistic to include buffer/cache values? > > Yes, should be possible but the kernel virtio-balloon driver has to be > extended too (and I suspect this kind of change goes into the kernel first). The current statistics are quite useless without that information,

[Qemu-devel] [PATCH 3/3] vnc: fix possible uninitialized removals

2012-12-07 Thread Tim Hardeck
Some VncState values are not initialized before the Websocket handshake. If it fails QEMU segfaults during the cleanup. To prevent this behavior intialization checks are added. Signed-off-by: Tim Hardeck --- ui/vnc.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --gi

[Qemu-devel] [PATCH 2/3 v4] vnc: added initial websocket protocol support

2012-12-07 Thread Tim Hardeck
This patch adds basic Websocket Protocol version 13 - RFC 6455 - support to QEMU VNC. Binary encoding support on the client side is mandatory. Because of the GnuTLS requirement the Websockets implementation is optional (--enable-vnc-ws). To activate Websocket support the VNC option "websocket"is

[Qemu-devel] [PATCH 1/3] vnc: added buffer_advance function

2012-12-07 Thread Tim Hardeck
Following Anthony Liguori's Websocket implementation I have added the buffer_advance function to VNC and replaced all related buffer memmove operations with it. Signed-off-by: Tim Hardeck --- ui/vnc.c | 13 + ui/vnc.h |1 + 2 files changed, 10 insertions(+), 4 deletions(-) dif

[Qemu-devel] [PATCH 0/3 v4] vnc: added initial websocket protocol support

2012-12-07 Thread Tim Hardeck
This patch set adds basic Websocket Protocol version 13 - RFC 6455 - support to QEMU VNC. Binary encoding support on the client side is mandatory. Because of the GnuTLS requirement the Websockets implementation is optional (--enable-vnc-ws). To activate Websocket support the VNC option "websocket

Re: [Qemu-devel] [PATCH] linux-user: Merge pread/pwrite into pread64/pwrite64

2012-12-07 Thread Peter Maydell
Ping^2, now we're out of freeze? Patchwork URL: http://patchwork.ozlabs.org/patch/191133/ -- PMM On 24 October 2012 13:27, Peter Maydell wrote: > Ping? > > -- PMM > > On 12 October 2012 14:55, Peter Maydell wrote: >> The Linux syscalls underlying pread() and pwrite() take a 64 bit >> offset on

Re: [Qemu-devel] [RFC PATCH v6 6/6] virtio-blk : Add the virtio-blk device.

2012-12-07 Thread Peter Maydell
On 7 December 2012 13:32, wrote: > From: KONRAD Frederic > > Create virtio-blk which extends virtio-device, so it can be connected on > virtio-bus. I suggest one step to refactor virtio-blk-pci, and one more to > clean > virtio-blk. Yes; I think you need to take this patchseries another step f

Re: [Qemu-devel] [PATCH v5 04/11] dataplane: add virtqueue vring code

2012-12-07 Thread Stefan Hajnoczi
On Fri, Dec 7, 2012 at 3:07 PM, Kevin Wolf wrote: > Am 05.12.2012 21:47, schrieb Stefan Hajnoczi: >> The virtio-blk-data-plane cannot access memory using the usual QEMU >> functions since it executes outside the global mutex and the memory APIs >> are this time are not thread-safe. >> >> This patc

[Qemu-devel] [PATCH 2/3] s390: Move IPL code into a separate device

2012-12-07 Thread Jens Freimann
From: Christian Borntraeger Lets move the code to setup IPL for external kernel or via the zipl rom into a separate file. This allows to - define a reboot handler, setting up the PSW appropriately - enhance the boot code to IPL disks that contain a bootmap that was created with zipl under LPAR

[Qemu-devel] [PATCH 4/8] s390: Add channel I/O instructions.

2012-12-07 Thread Cornelia Huck
Provide handlers for (most) channel I/O instructions. Signed-off-by: Cornelia Huck --- target-s390x/cpu.h| 87 +++ target-s390x/ioinst.c | 694 +- target-s390x/ioinst.h | 16 ++ trace-events | 6 + 4 files changed, 796 insertio

[Qemu-devel] [RFC PATCH v4 0/8] s390: channel I/O support in qemu.

2012-12-07 Thread Cornelia Huck
Hi, just a quick dump of my qemu patch series for channel I/O. I've managed to chop the virtual css patch into some smaller chunks (patches 2-6), which are hopefully easier to review. The virtio-ccw patch is still based upon the current virtio infrastructure; I'll try to rebase it upon the virti

Re: [Qemu-devel] [PATCH v2] target-arm: GIC: bug fixes for arm_gic.c

2012-12-07 Thread Peter Maydell
On 7 December 2012 14:31, Daniel Sangorrin wrote: > Thanks for your kind explanation. I will fix the patch and send it > again next Monday (hopefully I won't make any mistake this time). And > yes, I would like to collaborate with more patches in the future so it > might be good practice. OK, coo

[Qemu-devel] [RFC PATCH v6 4/6] virtio-pci : Refactor virtio-pci device.

2012-12-07 Thread fred . konrad
From: KONRAD Frederic Create the virtio-pci device. This transport device will create a virtio-pci-bus, so one VirtIODevice can be connected. Signed-off-by: KONRAD Frederic --- hw/virtio-pci.c | 112 hw/virtio-pci.h | 14 +++ 2 file

[Qemu-devel] [PATCH 6/8] s390: Wire up channel I/O in kvm.

2012-12-07 Thread Cornelia Huck
Trigger the code for our virtual css in case of instruction intercepts for I/O instructions. Handle the tsch exit for the subchannel-related part of tsch. Signed-off-by: Cornelia Huck --- target-s390x/cpu.h | 11 +++ target-s390x/kvm.c | 246 ++--

[Qemu-devel] [PATCH 2/8] s390: Channel I/O basic defintions.

2012-12-07 Thread Cornelia Huck
Basic channel I/O structures and helper function. Signed-off-by: Cornelia Huck --- target-s390x/Makefile.objs | 2 +- target-s390x/ioinst.c | 46 ++ target-s390x/ioinst.h | 207 + 3 files changed, 254 insertions(+), 1 deletion(-)

[Qemu-devel] [PATCH 1/3] s390: Fix empty kernel command line

2012-12-07 Thread Jens Freimann
From: Christian Borntraeger Since commit 967c0da73a7b0da186baba6632301d83644a570c vl.c: Avoid segfault when started with no arguments the user can specify a kernel without a command line. Lets not overwrite the default command line with \0 in that case. Signed-off-by: Christian Borntraeger

Re: [Qemu-devel] [PATCH v2] target-arm: GIC: bug fixes for arm_gic.c

2012-12-07 Thread Daniel Sangorrin
Peter, Thanks for your kind explanation. I will fix the patch and send it again next Monday (hopefully I won't make any mistake this time). And yes, I would like to collaborate with more patches in the future so it might be good practice. In particular, I'm interested in helping to make current T

[Qemu-devel] [PATCH 1/8] Update linux headers.

2012-12-07 Thread Cornelia Huck
Signed-off-by: Cornelia Huck --- linux-headers/asm-generic/kvm_para.h | 4 +++ linux-headers/asm-powerpc/kvm.h | 59 linux-headers/asm-powerpc/kvm_para.h | 7 +++-- linux-headers/linux/kvm.h| 36 +++--- 4 files changed, 98 in

[Qemu-devel] [PATCH 3/3] s390: add cpu reset handler

2012-12-07 Thread Jens Freimann
Add a CPU reset handler to have all CPUs in a PoP compliant state. Signed-off-by: Jens Freimann --- target-s390x/cpu.c | 25 + target-s390x/kvm.c | 10 +- 2 files changed, 34 insertions(+), 1 deletions(-) diff --git a/target-s390x/cpu.c b/target-s390x/cpu.c i

[Qemu-devel] [PATCH 3/8] s390: I/O interrupt and machine check injection.

2012-12-07 Thread Cornelia Huck
I/O interrupts are queued per isc. Only crw pending machine checks are supported. Signed-off-by: Cornelia Huck --- target-s390x/cpu.h| 67 +++ target-s390x/helper.c | 145 ++ 2 files changed, 212 insertions(+) diff --git a

[Qemu-devel] [RFC PATCH v6 5/6] virtio-device : Refactor virtio-device.

2012-12-07 Thread fred . konrad
From: KONRAD Frederic Create the virtio-device which is abstract. All the virtio-device can extend this class. Signed-off-by: KONRAD Frederic --- hw/virtio.c | 50 +++--- hw/virtio.h | 28 2 files changed, 67 insertions(+

Re: [Qemu-devel] [PATCH v5 06/11] dataplane: add Linux AIO request queue

2012-12-07 Thread Kevin Wolf
Am 05.12.2012 21:47, schrieb Stefan Hajnoczi: > The IOQueue has a pool of iocb structs and a function to add new > read/write requests. Multiple requests can be added before calling the > submit function to actually tell the host kernel to begin I/O. This > allows callers to batch requests and su

[Qemu-devel] [PATCH 8/8] s390: Add new channel I/O based virtio transport.

2012-12-07 Thread Cornelia Huck
Add a new virtio transport that uses channel commands to perform virtio operations. Add a new machine type s390-ccw that uses this virtio-ccw transport and make it the default machine for s390. Signed-off-by: Cornelia Huck --- hw/s390-virtio.c | 149 ++-- hw/s390x/Makefile.objs | 1

[Qemu-devel] [RFC PATCH v6 6/6] virtio-blk : Add the virtio-blk device.

2012-12-07 Thread fred . konrad
From: KONRAD Frederic Create virtio-blk which extends virtio-device, so it can be connected on virtio-bus. I suggest one step to refactor virtio-blk-pci, and one more to clean virtio-blk. Signed-off-by: KONRAD Frederic --- hw/virtio-blk.c | 101 +

Re: [Qemu-devel] [PATCH 1/8] Update linux headers.

2012-12-07 Thread Cornelia Huck
On Fri, 7 Dec 2012 13:01:27 + Peter Maydell wrote: > On 7 December 2012 12:50, Cornelia Huck wrote: > > Signed-off-by: Cornelia Huck > > I think it would be good if commit messages for linux-headers > updates stated the kernel tree and commit that the updated headers > come from. This one

Re: [Qemu-devel] [PATCH v5 04/11] dataplane: add virtqueue vring code

2012-12-07 Thread Kevin Wolf
Am 05.12.2012 21:47, schrieb Stefan Hajnoczi: > The virtio-blk-data-plane cannot access memory using the usual QEMU > functions since it executes outside the global mutex and the memory APIs > are this time are not thread-safe. > > This patch introduces a virtqueue module based on the kernel's vho

[Qemu-devel] [RFC PATCH v6 1/6] qdev : add a maximum device allowed field for the bus.

2012-12-07 Thread fred . konrad
From: KONRAD Frederic Add a max_dev field to BusState to specify the maximum amount of devices allowed on the bus ( have no effect if max_dev=0 ) Signed-off-by: KONRAD Frederic --- hw/qdev-core.h| 2 ++ hw/qdev-monitor.c | 11 +++ 2 files changed, 13 insertions(+) diff --git a/hw

[Qemu-devel] [PATCH 7/8] s390-virtio: Factor out some initialization code.

2012-12-07 Thread Cornelia Huck
Some of the machine initialization for s390-virtio will be reused by virtio-ccw. Signed-off-by: Cornelia Huck --- hw/s390-virtio.c | 132 +-- 1 file changed, 79 insertions(+), 53 deletions(-) diff --git a/hw/s390-virtio.c b/hw/s390-virtio.c in

Re: [Qemu-devel] [PATCH 2/7] target-alpha: Turn CPU definitions into subclasses

2012-12-07 Thread Richard Henderson
On 2012-12-06 04:11, Andreas Färber wrote: >> The "2*" names are aliases of the "ev*" names. There's no need for so >> much duplication. And for that matter, "ev68" is no different from "ev67" >> at the level for which we emulate. In hw, it was more cache and a faster >> multiply implementation.

Re: [Qemu-devel] [PATCH v7 1/2] qemu-ga: execute hook to quiesce the guest on fsfreeze-freeze/thaw

2012-12-07 Thread Luiz Capitulino
On Fri, 07 Dec 2012 17:39:29 +0900 Tomoki Sekiyama wrote: > To use the online disk snapshot for online-backup, application-level > consistency of the snapshot image is required. However, currently the > guest agent can provide only filesystem-level consistency, and the > snapshot may contain dirt

[Qemu-devel] [RFC PATCH v6 2/6] virtio-bus : Introduce virtio-bus

2012-12-07 Thread fred . konrad
From: KONRAD Frederic Introduce virtio-bus. Refactored transport device will create a bus which extends virtio-bus. Signed-off-by: KONRAD Frederic --- hw/Makefile.objs | 1 + hw/virtio-bus.c | 111 +++ hw/virtio-bus.h | 82 ++

[Qemu-devel] [PATCH 0/3] s390: ipl device and cpu reset handler

2012-12-07 Thread Jens Freimann
Hi Alex, some s390 patches dealing with ipl device, CPU reset and a bugfix: Patch 1 fixes a bug that overwrites the standard kernel command line Patch 2 is an initial patch towards the previously discussed ipl device. More patches will follow soon. Patch 3 adds a cpu reset handler. With

Re: [Qemu-devel] [PATCH v7 2/2] qemu-ga: sample fsfreeze hooks

2012-12-07 Thread Luiz Capitulino
On Fri, 07 Dec 2012 17:39:32 +0900 Tomoki Sekiyama wrote: > Adds sample hook scripts for --fsfreeze-hook option of qemu-ga. > - fsfreeze-hook : execute scripts in fsfreeze-hook.d/ > - fsfreeze-hook.d/mysql-flush.sh.sample : quiesce MySQL before snapshot > > Signed-off-by: Tomoki Sekiyama >

[Qemu-devel] [RFC PATCH v6 3/6] virtio-pci-bus : Introduce virtio-pci-bus.

2012-12-07 Thread fred . konrad
From: KONRAD Frederic Introduce virtio-pci-bus, which extends virtio-bus. It is used with virtio-pci transport device. Signed-off-by: KONRAD Frederic --- hw/virtio-pci.c | 37 + hw/virtio-pci.h | 19 +-- 2 files changed, 54 insertions(+), 2 d

[Qemu-devel] [RFC PATCH v6 0/6] Virtio refactoring.

2012-12-07 Thread fred . konrad
From: KONRAD Frederic You can clone that from here : git.greensocs.com/home/greensocs/git/qemu_virtio.git virtio_refactoring_v6 The problem with the last RFC v5 was that virtio-blk refactoring broke virtio-blk-pci device ( SEGFAULT ). So I modify this last step to fix that issue. In order to no

[Qemu-devel] [PATCH 5/8] s390: Virtual channel subsystem support.

2012-12-07 Thread Cornelia Huck
Provide a mechanism for qemu to provide fully virtual subchannels to the guest. Signed-off-by: Cornelia Huck --- hw/s390x/Makefile.objs |1 + hw/s390x/css.c | 1195 hw/s390x/css.h | 92 target-s390x/cpu.h | 65 +++

Re: [Qemu-devel] [PATCH 1/1] tmp105: Fix I2C protocol bug

2012-12-07 Thread Alex Horn
> [T]he change is entirely correct since the 'else' clause currently seems > to take the increment into account: > if (s->len <= 2) > s->buf[s->len - 1] = data; > tmp105_write(s); > > Shouldn't the '- 1' in the middle line be removed? Several clarifications follow. Th

Re: [Qemu-devel] [PATCH 1/8] Update linux headers.

2012-12-07 Thread Peter Maydell
On 7 December 2012 12:50, Cornelia Huck wrote: > Signed-off-by: Cornelia Huck I think it would be good if commit messages for linux-headers updates stated the kernel tree and commit that the updated headers come from. -- PMM

[Qemu-devel] Auto start script

2012-12-07 Thread Ignacio Geli
Hi all...     Sorry if im not posting in the proper list, but i have a solaris 2.5.1 up and running under qemu virtualization, the thing is that every time i boot it i need to enter "boot disk0" on the console to get it up and if I close that console i goes down.

Re: [Qemu-devel] [RFC 3/3] docs: document virtio-balloon stats

2012-12-07 Thread Luiz Capitulino
On Fri, 7 Dec 2012 05:30:17 + Dietmar Maurer wrote: > > +The memory statistics are: > > + > > + o stat-swap-in > > + o stat-swap-out > > + o stat-major-faults > > + o stat-minor-faults > > + o stat-free-memory > > + o stat-total-memory > > I want to implement an automatic ballooning policy,

[Qemu-devel] [PATCH 01/13] sd: Send debug printfery to stderr not stdout

2012-12-07 Thread Stefan Hajnoczi
From: Peter Crosthwaite Some debug printfs for SD are coming up in stdout. Redirected them to stderr instead. Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- hw/sd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/sd.c

  1   2   >